On Tue, Jul 21, 2009 at 06:23:16PM +0200, Thomas Treutner wrote:
I think there's a cp error:
http://libvirt.org/html/libvirt-libvirt.html#virStoragePoolUndefine
Returns: a virStoragePoolPtr object, or NULL if creation failed
I assume it is 0 on success, -1 on failure as the return
On Tue, Jul 21, 2009 at 06:34:31PM +0200, Thomas Treutner wrote:
On Tuesday 21 July 2009 18:23:16 Thomas Treutner wrote:
I think there's a cp error:
http://libvirt.org/html/libvirt-libvirt.html#virStoragePoolUndefine
Returns: a virStoragePoolPtr object, or NULL if creation failed
I
On Tue, Jul 21, 2009 at 05:25:37PM -0400, David Allan wrote:
This pool type contains volumes for the multipath devices that are present on
the host. It does not (yet) support any sort of multipath configuration, so
that aspect of system administration must still be done at host build time.
On Wed, Jul 22, 2009 at 12:36:10PM +0900, Nguyen Anh Quynh wrote:
Hi,
This patch provides support for physical memory in
virDomainMemoryPeek(). Please consider applying.
Signed-off-by: Nguyen Anh Quynh aqu...@gmail.com
okay a couple of comments:
# diffstat pmemsave3.diff
On Wed, Jul 22, 2009 at 4:02 PM, Daniel Veillardveill...@redhat.com wrote:
On Wed, Jul 22, 2009 at 12:36:10PM +0900, Nguyen Anh Quynh wrote:
Hi,
This patch provides support for physical memory in
virDomainMemoryPeek(). Please consider applying.
Signed-off-by: Nguyen Anh Quynh
On Wed, Jul 22, 2009 at 04:19:48PM +0900, Nguyen Anh Quynh wrote:
On Wed, Jul 22, 2009 at 4:02 PM, Daniel Veillardveill...@redhat.com wrote:
[...]
Then having no error handling here would make sense, but currently
if you pass a wrong argument you would just silently assume flags ==
On Wed, Jul 22, 2009 at 4:19 PM, Nguyen Anh Quynhaqu...@gmail.com wrote:
On Wed, Jul 22, 2009 at 4:02 PM, Daniel Veillardveill...@redhat.com wrote:
On Wed, Jul 22, 2009 at 12:36:10PM +0900, Nguyen Anh Quynh wrote:
Hi,
This patch provides support for physical memory in
virDomainMemoryPeek().
On Wed, Jul 22, 2009 at 04:27:45PM +0900, Nguyen Anh Quynh wrote:
On Wed, Jul 22, 2009 at 4:19 PM, Nguyen Anh Quynhaqu...@gmail.com wrote:
Acutally, to avoid all those ugly sanity checks, it is best to define
S/ugly/sane/
VIR_MEMORY_* as an enum type, then redefine virDomainMemoryCheck() as
On Wed, Jul 22, 2009 at 4:44 PM, Daniel Veillardveill...@redhat.com wrote:
On Wed, Jul 22, 2009 at 04:27:45PM +0900, Nguyen Anh Quynh wrote:
On Wed, Jul 22, 2009 at 4:19 PM, Nguyen Anh Quynhaqu...@gmail.com wrote:
Acutally, to avoid all those ugly sanity checks, it is best to define
On Wed, Jul 22, 2009 at 01:20:56AM -0400, Laine Stump wrote:
This avoids a problem when building under MINGW32
Known issue, uncontroversial, applied, thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine
Running make check from a tarball would show two test failures,
since some test-related files were not being distributed.
[that is one of the things that make distcheck tests for]
With these two fixes, make distcheck passes once again:
From 553cecaf27e86755e40bab346d4014fb0291e5cd Mon Sep 17
On Wed, Jul 22, 2009 at 08:43:43AM +0200, Daniel Veillard wrote:
On Tue, Jul 21, 2009 at 06:34:31PM +0200, Thomas Treutner wrote:
On Tuesday 21 July 2009 18:23:16 Thomas Treutner wrote:
I think there's a cp error:
http://libvirt.org/html/libvirt-libvirt.html#virStoragePoolUndefine
On Wed, Jul 22, 2009 at 10:33:13AM +0200, Daniel Veillard wrote:
On Wed, Jul 22, 2009 at 01:20:56AM -0400, Laine Stump wrote:
This avoids a problem when building under MINGW32
Known issue, uncontroversial, applied, thanks !
This problem is repeated throughout the interface_conf.c/.h files
On Tue, Jul 21, 2009 at 07:39:07PM +0900, Jun Koi wrote:
Hi,
I play around with MemoryPeek() API on QEMU. While it works well, I
found that it is too slow.
That is expected because of the way it works: we always need to save
memory to a file, and read it in again, and that is too
Hi,
the python example imports pygtk but uses gtk.main() so it fails to
work. Attached patch fixes this.
Cheers,
-- Guido
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Wed, 22 Jul 2009 12:00:47 +0200
Subject: [PATCH] use gtk instead of pygtk
the example uses gtk.* everywhere
Hi,
the python example is lacking the details argument in the callback. This
makes the example fail due to the wrong number of arguments.
Cheers,
-- Guido
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Wed, 22 Jul 2009 12:01:36 +0200
Subject: [PATCH] add missing details argument
On Wed, Jul 22, 2009 at 02:55:59PM +0900, Yuji NISHIDA wrote:
Hi,
I'm bit confuing between 2 problems with libvirt-0.6.5 for OpenVZ.
[1] bridge was created but no interface assigned to it
[2] virsh dumpxml returns xml in which type is qemu
sounds a serious bug
[2]
On Wed, Jul 22, 2009 at 11:17:21AM +0200, Jim Meyering wrote:
Running make check from a tarball would show two test failures,
since some test-related files were not being distributed.
[that is one of the things that make distcheck tests for]
With these two fixes, make distcheck passes once
On Mon, Jul 20, 2009 at 06:20:06PM +0100, Mark McLoughlin wrote:
On Mon, 2009-07-20 at 17:03 +0100, Daniel P. Berrange wrote:
On Mon, Jul 20, 2009 at 02:54:34PM +0100, Mark McLoughlin wrote:
diff --git a/include/libvirt/libvirt.h b/include/libvirt/libvirt.h
index 90007a1..d1cf5fb 100644
On Wed, Jul 22, 2009 at 02:55:59PM +0900, Yuji NISHIDA wrote:
Hi,
I'm bit confuing between 2 problems with libvirt-0.6.5 for OpenVZ.
The followings are python script and xml that I tested with.
~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~
[r...@node13 test]# cat test.py
import libvirt
conn =
On Tue, Jul 21, 2009 at 04:01:37PM +0100, Mark McLoughlin wrote:
In qemu-0.11 there is a 'pc-0.10' machine type which allows you to run
guests with a machine which is compatible with the pc machine in
qemu-0.10 - e.g. using the original PCI class for virtio-blk and
virtio-console and disabling
On Wed, 2009-07-22 at 11:24 +0100, Daniel P. Berrange wrote:
On Mon, Jul 20, 2009 at 06:20:06PM +0100, Mark McLoughlin wrote:
On Mon, 2009-07-20 at 17:03 +0100, Daniel P. Berrange wrote:
On Mon, Jul 20, 2009 at 02:54:34PM +0100, Mark McLoughlin wrote:
diff --git
On Tue, Jul 21, 2009 at 05:25:36PM -0400, David Allan wrote:
The following patch implements multipath pool support. It's very
basic functionality, consisting of creating a pool that contains all
the multipath devices on the host. That will cover the common case of
users who just want to
On Wed, Jul 22, 2009 at 04:56:53PM +0900, Nguyen Anh Quynh wrote:
On Wed, Jul 22, 2009 at 4:44 PM, Daniel Veillardveill...@redhat.com wrote:
On Wed, Jul 22, 2009 at 04:27:45PM +0900, Nguyen Anh Quynh wrote:
On Wed, Jul 22, 2009 at 4:19 PM, Nguyen Anh Quynhaqu...@gmail.com wrote:
Acutally,
On Wed, Jul 22, 2009 at 01:20:58AM -0400, Laine Stump wrote:
Since virRaiseErrorFull needs to lock the conn, we must take care to
call it with the lock *not* held.
If this patch is approved, similar patches need to be done for other
types in datatypes.c
Doh, that's a annoying edge case !
On Wed, Jul 22, 2009 at 01:20:59AM -0400, Laine Stump wrote:
I noticed that one of my virInterface commandline functions in virsh.c
was forgetting to call virInterfaceFree() before it was done, and
since I had written it with copy-paste, I decided to check other
functions in virsh.c for the
On Wed, Jul 22, 2009 at 12:22:08PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 22, 2009 at 01:20:57AM -0400, Laine Stump wrote:
If the mac address of an interface is changed, we must either create a
new virInterface object in the cache that has the new name/mac, or
modify the existing
On Wed, Jul 22, 2009 at 04:56:53PM +0900, Nguyen Anh Quynh wrote:
On Wed, Jul 22, 2009 at 4:44 PM, Daniel Veillardveill...@redhat.com wrote:
On Wed, Jul 22, 2009 at 04:27:45PM +0900, Nguyen Anh Quynh wrote:
On Wed, Jul 22, 2009 at 4:19 PM, Nguyen Anh Quynhaqu...@gmail.com wrote:
Acutally,
I have a single KVM server on which I want to allow co-workers the
ability to create vm's. Here are my criteria in order of importance:
1. I do not want to have to grant all users root privileges.
2. I would like the vm's to use the host's bridge (br0) by default.
3. I do not want one user to be
On Tue, Jul 21, 2009 at 04:58:50PM +0200, Matthias Bolte wrote:
Hi,
I checked the diff patch, i.e. change to the current infrastructure,
it all look clean and uncontroversial. I think it just misses adequate
changes to the spec file including libcurl BuidDeps but I will handle
this one :-)
---
qemud/remote.c |2 +-
src/interface_conf.c | 34 +-
src/interface_conf.h |4 ++--
src/veth.c |6 +++---
src/veth.h |2 +-
5 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/qemud/remote.c
This is a follow-on to 528d37. It's fixing several other cases in
datatypes.c where we try to report an error while holding the conn's
lock, which can't work because the error reporting also tries to lock
the conn.
---
src/datatypes.c | 133
This is an updated series of the v1 patches here:
http://www.redhat.com/archives/libvir-list/2009-July/msg00435.html
I have re-ordered the patches a little to put the generic refactoring
all first. I identified some bugs in the existing LXC driver schedular
parameter handling which I fixed. Also
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/cgroup.c | 87 ++
1 files changed, 27 insertions(+), 60 deletions(-)
diff --git a/src/cgroup.c b/src/cgroup.c
index 4955298..aecdf47 100644
--- a/src/cgroup.c
+++
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/cgroup.c | 46 +-
1 files changed, 29 insertions(+), 17 deletions(-)
diff --git a/src/cgroup.c b/src/cgroup.c
index 50517e2..4955298 100644
--- a/src/cgroup.c
+++ b/src/cgroup.c
@@ -31,15
Allow the driver level cgroup to be managed explicitly by the
hypervisor drivers, in order to detect whether to enable or
disable cgroup support for domains. Provides better error
reporting of failures. Also allow for creation of cgroups for
unprivileged drivers if controller is accessible by the
* src/cgroup.c: Detect the mount location of every controller at
time a virCgroupPtr is created. Detect current process' placement
within group to avoid assuming it is in the root. Pass controller
ID into SetValueStr/GetValueStr to enable much duplicated code to
be eliminated
* qemud/libvirtd_qemu.aug, qemud/test_libvirtd_qemu.aug,
src/qemu.conf: Add 'cgroups_controllers' and 'cgroups_device_acl'
parameters
* src/qemu_conf.h, src/qemu_conf.c: Load parse configuration params
for cgroups
* src/qemu_driver.c: Only use cgroups controllers that are activated,
* src/qemu_driver.c: Place guest in cgroup upon startup. Remove
cgroup upon shutdown
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/qemu_conf.h |2 +
src/qemu_driver.c | 133 ++---
2 files changed, 128 insertions(+), 7
On 07/22/2009 10:21 AM, Daniel Veillard wrote:
On Wed, Jul 22, 2009 at 12:23:31PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 22, 2009 at 01:20:58AM -0400, Laine Stump wrote:
Since virRaiseErrorFull needs to lock the conn, we must take care to
call it with the lock *not* held.
If
Even though we are not using gcrypt directly in any libvirt code,
it turns out that we are responsible for initializing its thread
support, since its used by gnutls. This really sucks in terms of
library API encapsulation. It is also a little annoying if libvirt
is used within an app that already
* src/remote_internal.c: Register thread functions for gcrypt
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/remote_internal.c | 43 +++
1 files changed, 43 insertions(+), 0 deletions(-)
diff --git a/src/remote_internal.c
* src/lxc_conf.h: Add queue for dispatch of domain events
* src/lxc_driver.c: Trigger domain events upon important lifecycle transitions
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/lxc_conf.h |7 ++
src/lxc_driver.c | 181
This patch series simply adds a couple of easy features to
the LXC driver.
Daniel P. Berrange (2):
Add domain events support to LXC driver
Add domain autostart for LXC driver
src/lxc_conf.h |7 +
src/lxc_driver.c | 365 +-
2 files
On Tue, Jul 21, 2009 at 05:28:27PM -0400, Jim Paris wrote:
Daniel P. Berrange wrote:
On Tue, Jul 21, 2009 at 09:46:17AM -0400, Jim Paris wrote:
Speaking of this, I've noticed that
domain type='qemu'
os
type arch='i686' machine='pc'hvm/type
/os
/domain
runs
On Wed, Jul 22, 2009 at 11:13:27AM -0400, Laine Stump wrote:
---
qemud/remote.c |2 +-
src/interface_conf.c | 34 +-
src/interface_conf.h |4 ++--
src/veth.c |6 +++---
src/veth.h |2 +-
5 files changed, 24
On Wed, Jul 22, 2009 at 11:13:45AM -0400, Laine Stump wrote:
This is a follow-on to 528d37. It's fixing several other cases in
datatypes.c where we try to report an error while holding the conn's
lock, which can't work because the error reporting also tries to lock
the conn.
---
On Tue, Jul 21, 2009 at 01:12:00PM +0200, Miloslav Trma?? wrote:
Supports only virStorageVolCreateXML, not virStorageVolCreateXMLFrom.
Curiously, qemu-img does not need the passphrase for anything to create
an encrypted volume. This implementation is sufficient for the qcow2
format, and for
On Mon, Jul 20, 2009 at 10:04:31AM +0200, Pritesh Kothari wrote:
I don't think this is quite correct. We call VBoxCGlueInit()
in the vboxRegister() function, which is run when libvirt first
initializes the whole library.
The real bug is the vboxClose() method which calls
On Fri, Jul 17, 2009 at 03:39:07PM +0200, Pritesh Kothari wrote:
I think your .gitconfig needs email addr fixing :-)
thanks did it ;)
I'm thinking it is going to get rather painful to #if/else/endif this
stuff throughout the file.
Perhaps it wouldbe better to define some wrapper
On Wed, Jul 22, 2009 at 10:33:19AM -0400, Juan Miscaro wrote:
I have a single KVM server on which I want to allow co-workers the
ability to create vm's. Here are my criteria in order of importance:
1. I do not want to have to grant all users root privileges.
2. I would like the vm's to use
On Wed, Jul 22, 2009 at 05:02:55PM +0100, Daniel P. Berrange wrote:
* src/lxc_conf.h: Add queue for dispatch of domain events
* src/lxc_driver.c: Trigger domain events upon important lifecycle transitions
[...]
@@ -293,6 +303,8 @@ static virDomainPtr lxcDomainDefine(virConnectPtr conn,
const
On Wed, Jul 22, 2009 at 05:02:56PM +0100, Daniel P. Berrange wrote:
* src/lxc_driver.c: Implement support for domain autostart
Signed-off-by: Daniel P. Berrange berra...@redhat.com
except that
+static void
+lxcAutostartConfigs(lxc_driver_t *driver) {
+unsigned int i;
+/* XXX:
On Wed, Jul 22, 2009 at 11:13:27AM -0400, Laine Stump wrote:
---
qemud/remote.c |2 +-
src/interface_conf.c | 34 +-
src/interface_conf.h |4 ++--
src/veth.c |6 +++---
src/veth.h |2 +-
5 files changed, 24
On Wed, Jul 22, 2009 at 05:24:09PM +0100, Daniel P. Berrange wrote:
On Tue, Jul 21, 2009 at 04:58:50PM +0200, Matthias Bolte wrote:
Hi,
the development was hindered by our testing cluster being offline
since 2 weeks due to server room cooling system maintenance. But I
finally got a
On 07/22/2009 11:36 AM, Daniel P. Berrange wrote:
On Wed, Jul 22, 2009 at 11:25:38AM -0400, Laine Stump wrote:
On 07/22/2009 10:20 AM, Daniel Veillard wrote:
Agreed, patch applied, I only had to add _() to get the message localized,
I've idly wondered about that macro, as it
On Wed, Jul 22, 2009 at 02:30:55PM -0400, Laine Stump wrote:
On 07/22/2009 11:36 AM, Daniel P. Berrange wrote:
On Wed, Jul 22, 2009 at 11:25:38AM -0400, Laine Stump wrote:
On 07/22/2009 10:20 AM, Daniel Veillard wrote:
Agreed, patch applied, I only had to add _() to get the message
On Wed, Jul 22, 2009 at 02:30:55PM -0400, Laine Stump wrote:
On 07/22/2009 11:36 AM, Daniel P. Berrange wrote:
It's actually because I like doing this that I'd like to know the
preferred method of eliminating the warnings I mentioned. There are a
bunch of them pre-existing in the code that
On Tue, Jul 21, 2009 at 05:28:27PM -0400, Jim Paris wrote:
Daniel P. Berrange wrote:
On Tue, Jul 21, 2009 at 09:46:17AM -0400, Jim Paris wrote:
Speaking of this, I've noticed that
domain type='qemu'
os
type arch='i686' machine='pc'hvm/type
/os
/domain
runs
Hello everyone,
This should be the official patch for the libvrt-0.7.0 release. Here
I'll comment all the features already implemented and the roadmap we
have ahead:
Features supported:
* Connects to HMC/VIOS or IVM systems.
* Life cycle commands (resume and shutdown).
* dumpxml
* 'list' and
Latest GCC changed the meaning of 'printf' attribute annotation to refer
to the host platform's native format specifiers. On Win32/mingw32 this
means it is now validating against Microsoft's useless format specifiers.
We replace all the printf like functions on Win32 thanks to GNULIB and
thus
---
src/datatypes.c | 24
src/domain_conf.c |9 +
src/interface_conf.c |4 ++--
src/lxc_driver.c |2 +-
src/qemu_driver.c |4 ++--
src/storage_backend.c |6 +++---
src/virsh.c |4 ++--
7 files changed, 27
Add a little helper function to write the monitor command followed by
carriage return in a single write.
This doesn't make any real difference, but allows us to more easily
switch to using sendmsg() when using the monitor over a unix socket.
* src/qemu_conf.c: split qemudMonitorSend() out
---
* src/qemu_conf.h: export qemudNetworkIfaceConnect()
* src/qemu_conf.c: move vnet_hdr logic into qemudNetworkIfaceConnect()
since we need it for hotplug too
---
src/qemu_conf.c | 17 -
src/qemu_conf.h |5 +
2 files changed, 13 insertions(+), 9 deletions(-)
diff --git
Switch from using write() to using sendmsg() on QEMU's monitor socket
so that we can add support for SCM_RIGHTS.
* src/qemu_driver.c: add sendmsg() based qemudMonitorSendUnix() and use
it when the monitor fd is a unix socket
---
src/qemu_driver.c | 37 +++--
1
Add qemudMonitorCommandWithFd() which allows a file descriptor to be
sent to qemu over a unix monitor socket using SCM_RIGHTS. See the
unix(7) and cmsg(3) man pages.
* src/qemu_conf.c: add a scm_fd param to qemudMonitorCommandExtra(),
add qemudMonitorCommandWithFd(), implement SCM_RIGHTS
With hotplug, we're going to want to pass a tapfd name rather than an
actual file descriptor, so prepare the way by passing a string tapfd to
qemuBuildHostNetStr().
* src/qemu_conf.h: qemuBuildHostNetStr() takes a string tapfd now
* src/qemu_conf.c: pass qemuBuildHostNetStr() a string rather
Hey,
So, here are the patches needed to complete the QEMU NIC hotplug
work by supporting network and bridge backed interfaces.
We support this by passing a tap file descriptor to qemu over
the monitor socket using SCM_RIGHTS.
The monitor commands required for this (getfd
In subsequent patches we're going to have a file descriptor to close
too, so centralize the error handling cleanups to make things easier.
* src/qemu_conf.c: in qemudDomainAttachNetDevice() consolidate the
error handling cleanups together
---
src/qemu_driver.c | 37
In order to hotplug a network/bridge backed NIC, we need to first create
the tap file descriptor, add the tap interface to the bridge and then
pass the file descriptor to the qemu process using the 'getfd' monitor
command.
Once the tapfd has been accepted, we create the network backend using
This patch allows passing of a -mem-path arg
flag to qemu for support of huge page backed
guests. A guest may request this option via
specifying:
hugepageon/hugepage
in its domain definition xml file. The request
for huge page backing will be attempted within
libvirt if the host system has
Hi,
I'm trying to use libvirt-0.6.5 within a multithreaded application without
libvirtd and from what it looks like, it appears to have two things
that are somewhat undesirable:
1) It tries to connect to libvirtd which isn't running. But it does
eventually connect to the hypervisor.
2) It
On Thu, Jul 23, 2009 at 1:36 PM, Jun Koijunkoi2...@gmail.com wrote:
On Wed, Jul 22, 2009 at 7:02 PM, Richard W.M. Jonesrjo...@redhat.com wrote:
On Tue, Jul 21, 2009 at 07:39:07PM +0900, Jun Koi wrote:
Hi,
I play around with MemoryPeek() API on QEMU. While it works well, I
found that it is
73 matches
Mail list logo
