Daniel P. Berrange schrieb:
Fix kvm to include a relevant version number instead of just the 'devel'
eg, Instead of
QEMU PC emulator version 0.10.0 (kvm-devel), Copyright (c) 2003-2008
have
QEMU PC emulator version 0.10.0 (kvm-85-devel), Copyright (c) 2003-2008
So that its clear this de
On Thu, Aug 06, 2009 at 02:37:53PM +0200, Daniel Veillard wrote:
> On Thu, Aug 06, 2009 at 12:39:34PM +0100, Daniel P. Berrange wrote:
> > On Wed, Aug 05, 2009 at 12:58:33PM +0200, Jonas Eriksson wrote:
> > > * src/remote_internal.c: Honour USE_SOCAT by selecting between
> > > netcat/nc and socat
- "Daniel P. Berrange" wrote:
> >
> >
> > @@ -74,6 +76,7 @@
> >
> >
> >
> > +
> >
> >
>
> To allow removal of "" for non-encrypted cases, I
> believe we'd need to add
>
>
>
>
>
> Unless that's 'encryption' schema rule itself ha
Hi All,
I have just added support for getting/setting number of cpus in VirtualBox.
The patch for the same is include below.
Regards,
Pritesh
commit 3dcaf67d0bb4aa58c4e2224779bebcf2263068b8
Author: Pritesh Kothari
Date: Fri Aug 7 15:49:16 2009 +0200
libvirt: support for getting/setting nu
Implement a compressed save image format for qemu. While ideally
we would have the choice between compressed/non-compressed
available to the libvirt API, unfortunately there is no "flags"
parameter to the virDomainSave() API. Therefore, implement this
as a qemu.conf option. Both gzip and bzip2 a
Chris Lalancette wrote:
> +if (header.compressed == QEMUD_SAVE_FORMAT_RAW)
> +internalret = virAsprintf(&command, "migrate \"exec:"
> + "dd of='%s' oflag=append conv=notrunc
> 2>/dev/null"
> + "\"", safe_path);
> +el
When doing a restore, we were forgetting to update the state file
for the VM. That means that if you do a save/restore, then shut
down libvirtd, then start it back up, you'll see the state of the
guest as "paused", even though it is really running. We were
just forgetting a "virDomainSaveStatus"
Implement a compressed save image format for qemu. While ideally
we would have the choice between compressed/non-compressed
available to the libvirt API, unfortunately there is no "flags"
parameter to the virDomainSave() API. Therefore, implement this
as a qemu.conf option. Both gzip and bzip2 a
Matthias Bolte wrote:
> Hi,
>
> I came across this line in the phypOpen function:
>
> char string[strlen(conn->uri->path)];
>
> Here the path part of the given URI is used without checking it for
> NULL, this can cause a segfault as strlen expects a string != NULL.
Heh, it's worse than that; th
On Fri, Aug 07, 2009 at 02:13:15PM +0200, Diego Mari?o wrote:
> Hi all,
>
> This is a one-time post to announce a project which supports libvirt
> for managing virtual machines: abiCloud.
>
> AbiCloud is an open source cloud platform manager which allows to
> easily deploy a private cloud in your
On Fri, Aug 7, 2009 at 2:29 PM, Rakotomandimby
Mihamina wrote:
>>
>> Requirements:
>> - Linux/Windows/MacOSX
>> - Any hypervisor supported installed in a node
>> - Sun Java Runtime Environment (JRE) 1.6
>
> Uh,... not possible to have another langage used?
> I mean, Python, OCaml,...
abiCloud has
Daniel P. Berrange wrote:
> On Mon, Aug 03, 2009 at 08:56:48AM +0200, Dominik Klein wrote:
>> Hi
>>
>> I am running kvm-78 with libvirt 0.6.1 and see the following error from
>> time to time when my linux-ha cluster tries to run "virsh domstate" to
>> figure out a virtual machine's state:
>>
>> err
Hi,
I came across this line in the phypOpen function:
char string[strlen(conn->uri->path)];
Here the path part of the given URI is used without checking it for
NULL, this can cause a segfault as strlen expects a string != NULL.
Beside that uuid_db and connection_data leak in case of an error.
I
08/07/2009 03:13 PM, Diego Mariño:
Requirements:
- Linux/Windows/MacOSX
- Any hypervisor supported installed in a node
- Sun Java Runtime Environment (JRE) 1.6
Uh,... not possible to have another langage used?
I mean, Python, OCaml,...
Licenses
- CPAL 1.0 for the UI
- MPL 1.1 for the services
Daniel P. Berrange wrote:
> Fix kvm to include a relevant version number instead of just the 'devel'
>
> eg, Instead of
>
>QEMU PC emulator version 0.10.0 (kvm-devel), Copyright (c) 2003-2008
>
> have
>
>QEMU PC emulator version 0.10.0 (kvm-85-devel), Copyright (c) 2003-2008
>
> So tha
Hi all,
This is a one-time post to announce a project which supports libvirt
for managing virtual machines: abiCloud.
AbiCloud is an open source cloud platform manager which allows to
easily deploy a private cloud in your datacenter. One of the key
differences of AbiCloud is the the web rich inte
On Fri, Aug 07, 2009 at 01:57:34PM +0200, Chris Lalancette wrote:
> Anton Protopopov wrote:
> > Hi.
> >
> > Libvirt tryes to extract kvm version from the string
> > "QEMU PC emulator version .. (kvm-)..."
> > For examle,
> > # kvm -help | head -1
> > QEMU PC emulator version 0.10.0 (kvm-85),
Anton Protopopov wrote:
> Hi.
>
> Libvirt tryes to extract kvm version from the string
> "QEMU PC emulator version .. (kvm-)..."
> For examle,
> # kvm -help | head -1
> QEMU PC emulator version 0.10.0 (kvm-85), Copyright (c) 2003-2008
> Fabrice Bellard
>
> The problem occures if you are try
Matthias Bolte wrote:
>> diff --git a/src/esx/esx_vmx.c b/src/esx/esx_vmx.c
>> index af5234e..91a86e2 100644
>> --- a/src/esx/esx_vmx.c
>> +++ b/src/esx/esx_vmx.c
>> @@ -397,10 +397,7 @@ def->parallels[0]...
>>
>> #define ESX_BUILD_VMX_NAME(_suffix)
>> \
2009/8/7 Chris Lalancette :
> While trying to remove uses of unsafe strncpy in the tree, I came
> across a couple of usage in the ESX driver. To my eyes, the snprintf
> replacements do the same thing in less code, and are also safer.
> This has been compile tested only. Mattias, is there any reas
Hi.
Libvirt tryes to extract kvm version from the string
"QEMU PC emulator version .. (kvm-)..."
For examle,
# kvm -help | head -1
QEMU PC emulator version 0.10.0 (kvm-85), Copyright (c) 2003-2008 Fabrice
Bellard
The problem occures if you are trying to run it on the devel version of kvm:
Re-factor virDomainMigrate to split out the version 1 and version 2
protocols into their own functions. In reality, the two versions share
very little in common, so forcing them together in the same function was
just confusing. This will also make adding tunnelled migration easier.
Signed-off-by
Allow the daemon itself to make RPCs to an external libvirtd, but only if
the URI is fully specified. While this isn't used at the moment, it will
be for the tunnelled migration support in the future.
Signed-off-by: Chris Lalancette
---
src/remote_internal.c |2 +-
1 files changed, 1 insert
As of qemu 0.10.6, qemu now honors the -S flag on incoming migration.
That means that when the migration completes, we have to issue a
'cont' command to get the VM running again. We do it unconditionally
since it won't hurt on older qemu.
Signed-off-by: Chris Lalancette
---
src/qemu_driver.c |
Add the virStrcpy function, which takes a dst string, source string, and
number of bytes available in the dest string. If the source string is
too large to fit into the destination string, including the \0 byte, then
no data is copied and the function returns NULL. Otherwise, this
function copies
qemudExtractMonitorPath() was doing a VIR_ALLOC_N followed by a
strncpy. However, this isn't necessary; we can do the same thing
using virAsprintf(), which is much safer.
Signed-off-by: Chris Lalancette
---
src/qemu_driver.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff
Signed-off-by: Chris Lalancette
---
src/test.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/test.c b/src/test.c
index 470816b..ab6cfdf 100644
--- a/src/test.c
+++ b/src/test.c
@@ -417,9 +417,8 @@ static char *testBuildFilename(const char *relativeTo,
c
A couple of minor fixes to phyp escape_specialcharacters. Make it
a static function (since it's only used in phyp/phyp_driver.c), and
make it take a dstlen parameter. This paves the way for removing
strncpy in the future.
Signed-off-by: Chris Lalancette
---
src/phyp/phyp_driver.c | 10 ++
Signed-off-by: Chris Lalancette
---
src/xm_internal.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/xm_internal.c b/src/xm_internal.c
index b7f9e67..71b852e 100644
--- a/src/xm_internal.c
+++ b/src/xm_internal.c
@@ -1160,7 +1160,6 @@ xenXMDomainConfigParse(virConnec
Signed-off-by: Chris Lalancette
---
src/xen_internal.c |8
src/xend_internal.c |2 +-
src/xm_internal.c |2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/xen_internal.c b/src/xen_internal.c
index b6bf10d..ae78f84 100644
--- a/src/xen_internal.c
+++
Minor fix to openvzGetVPSUUID to make it take a length parameter.
This ensures that it doesn't make assumptions about the length
of the UUID buffer, and paves the way for removal of strncpy in
the future.
Signed-off-by: Chris Lalancette
---
src/openvz_conf.c | 10 +-
1 files changed, 5
Signed-off-by: Chris Lalancette
---
src/opennebula/one_client.c | 16 ++--
1 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/src/opennebula/one_client.c b/src/opennebula/one_client.c
index d1641bf..21f303a 100644
--- a/src/opennebula/one_client.c
+++ b/src/opennebula/o
While trying to remove uses of unsafe strncpy in the tree, I came
across a couple of usage in the ESX driver. To my eyes, the snprintf
replacements do the same thing in less code, and are also safer.
This has been compile tested only. Mattias, is there any reason we
can't use these simpler (and s
Signed-off-by: Chris Lalancette
---
src/datatypes.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/src/datatypes.c b/src/datatypes.c
index 1889dc3..ac61682 100644
--- a/src/datatypes.c
+++ b/src/datatypes.c
@@ -863,19 +863,16 @@ virGetStorageVol(virConnectPtr conn, c
Signed-off-by: Chris Lalancette
---
src/console.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/console.c b/src/console.c
index badb62c..4a1a80b 100644
--- a/src/console.c
+++ b/src/console.c
@@ -78,7 +78,7 @@ int vshRunConsole(const char *tty) {
return -1
Signed-off-by: Chris Lalancette
---
src/hash.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/hash.c b/src/hash.c
index bde3a0b..9308c0c 100644
--- a/src/hash.c
+++ b/src/hash.c
@@ -141,7 +141,7 @@ virHashGrow(virHashTablePtr table, int size)
}
table->size
36 matches
Mail list logo