Paolo Bonzini wrote:
On 08/28/2009 04:55 PM, Chris Lalancette wrote:
While reproducing this issue, I also noticed that we wouldn't
always properly propagate an error message. In particular, I
found that if you blocked off the migration ports (with iptables)
and then tried the migration, it
We need to provide support for CPU ID masking. Xen and VMware ESX are
examples
of current hypervisors which support such masking.
My proposal is to define new 'cpuid' feature advertised in guest
capabilities:
...
domain type='xen' id='42'
...
features
pae/
On Wed, Aug 19, 2009 at 10:48:45AM +0200, Pritesh Kothari wrote:
On Thursday 13 August 2009 20:50:25 Daniel P. Berrange wrote:
On Mon, Aug 10, 2009 at 01:55:03PM +0200, Pritesh Kothari wrote:
Hi All,
I have added support for defining/dumping video device in VirtualBox. The
patch for
Jim Paris wrote:
Daniel P. Berrange wrote:
On Wed, Sep 02, 2009 at 12:26:43PM +0200, Jim Meyering wrote:
Daniel Veillard wrote:
On Wed, Sep 02, 2009 at 11:58:07AM +0200, Jim Meyering wrote:
Here's the test just before the else-if in the patch below:
if (conn
clang was complaining that a NULL inputvol would be dereferenced
in that could not open... diagnostic.
Since the two sole callers of this function are careful
to call it only when inputvol is non-NULL, this is a good
case for giving the parameter the nonnull attribute:
From
This looks like a real bug.
From 170af3320e68a0ac2cfe854fba28abe0e4040d2c Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 11:24:44 +0200
Subject: [PATCH] openvz_conf.c: don't use undefined local, net
* src/openvz_conf.c (openvzReadNetworkConf): Upon
On Thu, Sep 03, 2009 at 11:19:47AM +0300, Dor Laor wrote:
On 09/02/2009 07:09 PM, Daniel P. Berrange wrote:
On Wed, Sep 02, 2009 at 11:59:39AM -0400, Jim Paris wrote:
Jiri Denemark wrote:
Hi,
We need to provide support for CPU ID masking. Xen and VMware ESX are
examples
of current
Another real bug:
From 6697607bf0b023ffb692576b31d652d10719b08a Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 12:05:52 +0200
Subject: [PATCH] uml_conf.c: don't return an uninitialized pointer
* src/uml_conf.c (umlBuildCommandLineChr): Initialize ret also
another real bug:
From fd41bd47252654f84684830e02ecbeb3d26e7dee Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 12:12:19 +0200
Subject: [PATCH] test.c: don't use undefined local, def
* src/test.c (testOpenVolumesForPool): Upon early virAsprintf or
On Wed, Sep 02, 2009 at 04:29:37PM +0100, Andreas Sommer wrote:
Hi, I just wondered whether the Xen Client project
(http://www.xen.org/products/xci.html) has been tested, or is supported
by libvirt at all?
I'm not sure if it has a different Xen API, but it definitely has
different domain
On Thu, Sep 03, 2009 at 11:18:00AM +0200, Jim Meyering wrote:
clang was complaining that a NULL inputvol would be dereferenced
in that could not open... diagnostic.
Since the two sole callers of this function are careful
to call it only when inputvol is non-NULL, this is a good
case for
On Thu, Sep 03, 2009 at 11:25:19AM +0200, Jim Meyering wrote:
This looks like a real bug.
From 170af3320e68a0ac2cfe854fba28abe0e4040d2c Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 11:24:44 +0200
Subject: [PATCH] openvz_conf.c: don't use undefined
On Thu, Sep 03, 2009 at 12:07:14PM +0200, Jim Meyering wrote:
Another real bug:
From 6697607bf0b023ffb692576b31d652d10719b08a Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 12:05:52 +0200
Subject: [PATCH] uml_conf.c: don't return an uninitialized
On Thu, Sep 03, 2009 at 12:13:00PM +0200, Jim Meyering wrote:
another real bug:
From fd41bd47252654f84684830e02ecbeb3d26e7dee Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 12:12:19 +0200
Subject: [PATCH] test.c: don't use undefined local, def
*
Jim Meyering wrote:
This looks like a real bug.
From 170af3320e68a0ac2cfe854fba28abe0e4040d2c Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 11:24:44 +0200
Subject: [PATCH] openvz_conf.c: don't use undefined local, net
* src/openvz_conf.c
On Thu, Sep 03, 2009 at 12:38:43PM +0200, Jim Meyering wrote:
Jim Meyering wrote:
This looks like a real bug.
From 170af3320e68a0ac2cfe854fba28abe0e4040d2c Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 11:24:44 +0200
Subject: [PATCH]
Daniel P. Berrange wrote:
On Thu, Sep 03, 2009 at 12:07:14PM +0200, Jim Meyering wrote:
Another real bug:
From 6697607bf0b023ffb692576b31d652d10719b08a Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 12:05:52 +0200
Subject: [PATCH] uml_conf.c: don't
Daniel P. Berrange wrote:
On Thu, Sep 03, 2009 at 11:18:00AM +0200, Jim Meyering wrote:
clang was complaining that a NULL inputvol would be dereferenced
in that could not open... diagnostic.
Since the two sole callers of this function are careful
to call it only when inputvol is non-NULL,
Daniel P. Berrange wrote:
On Thu, Sep 03, 2009 at 11:18:00AM +0200, Jim Meyering wrote:
clang was complaining that a NULL inputvol would be dereferenced
in that could not open... diagnostic.
Since the two sole callers of this function are careful
to call it only when inputvol is non-NULL,
On Thu, Sep 03, 2009 at 12:43:10PM +0200, Jim Meyering wrote:
Daniel P. Berrange wrote:
On Thu, Sep 03, 2009 at 12:07:14PM +0200, Jim Meyering wrote:
Another real bug:
From 6697607bf0b023ffb692576b31d652d10719b08a Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date:
On Wed, 2009-08-26 at 14:03 +0100, Daniel P. Berrange wrote:
I hope you're planning on adding all that useful info from the 0/1 mail
to the git commit log?
* configure.in: Add check for mntent.h
* qemud/libvirtd_qemu.aug, qemud/test_libvirtd_qemu.aug, src/qemu.conf
Add 'hugetlbfs_mount'
Daniel P. Berrange wrote:
...
Actually I did that first, but then un-did it in favor
of the change above. Why? because that initialization could
mask a failure to initialize in a new case.
With per-case initialization, we'd detect the bug at
compile/static-analysis time. With the up-front
On Wed, Sep 02, 2009 at 11:48:21AM -0400, Jim Paris wrote:
Yeah, for functions where it is expected that the passed in param
be non-NULL, then annotations are definitely the way togo. This
lets the compiler/checkers validate the callers instead, avoiding
the need to clutter the methods
On Thu, Sep 03, 2009 at 11:48:53AM +0100, Mark McLoughlin wrote:
@@ -290,10 +305,22 @@ int qemudLoadDriverConfig(struct qemud_driver *driver,
}
}
+ p = virConfGetValue (conf, hugetlbfs_mount);
+ CHECK_TYPE (hugetlbfs_mount, VIR_CONF_STRING);
+ if (p
On Wed, 2009-09-02 at 15:11 +0100, Daniel P. Berrange wrote:
* tests/testutils.c: Run test function twice, once to prime it for
static allocations, once to count the non-static allocations.
* tests/testutilsqemu.c: Initialize variable correctl
* src/capabilities.c: Don't free machines
On Thu, Sep 03, 2009 at 12:07:33PM +0100, Mark McLoughlin wrote:
On Wed, 2009-09-02 at 15:11 +0100, Daniel P. Berrange wrote:
* tests/testutils.c: Run test function twice, once to prime it for
static allocations, once to count the non-static allocations.
* tests/testutilsqemu.c:
Jim Meyering wrote:
Daniel P. Berrange wrote:
...
Actually I did that first, but then un-did it in favor
of the change above. Why? because that initialization could
mask a failure to initialize in a new case.
With per-case initialization, we'd detect the bug at
compile/static-analysis
The following use of caps is the assignment in a for-loop,
so the initialization is unnecessary.
From 7032a0b370db1a9489cf19fce0cabbb6959320ab Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 13:38:57 +0200
Subject: [PATCH] node_device_conf.c: remove dead
Jim Meyering wrote:
Jim Meyering wrote:
Daniel P. Berrange wrote:
...
Actually I did that first, but then un-did it in favor
of the change above. Why? because that initialization could
mask a failure to initialize in a new case.
With per-case initialization, we'd detect the bug at
The only following uses of group look like this:
(always preceded by initialization):
AVAHI_DEBUG(Client collision/connecting %p, mdns-client);
group = mdns-group;
while (group) {
if (group-handle)
On Thu, Sep 03, 2009 at 01:39:25PM +0200, Jim Meyering wrote:
Jim Meyering wrote:
Daniel P. Berrange wrote:
...
Actually I did that first, but then un-did it in favor
of the change above. Why? because that initialization could
mask a failure to initialize in a new case.
With
On Thu, Sep 03, 2009 at 01:40:29PM +0200, Jim Meyering wrote:
The following use of caps is the assignment in a for-loop,
so the initialization is unnecessary.
From 7032a0b370db1a9489cf19fce0cabbb6959320ab Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep
On Thu, Sep 03, 2009 at 01:46:59PM +0200, Jim Meyering wrote:
The only following uses of group look like this:
(always preceded by initialization):
AVAHI_DEBUG(Client collision/connecting %p, mdns-client);
group = mdns-group;
while (group) {
Apart from DV's comments, ACK to patches 1-3
On Tue, 2009-09-01 at 16:28 +0100, Daniel P. Berrange wrote:
* src/security.h: Driver API for relabelling host devices
* src/security_selinux.c: Implement relabelling of PCI and USB
devices
* src/qemu_driver.c: Relabel USB/PCI devices before
On Tue, Aug 25, 2009 at 01:58:28PM +0100, Daniel P. Berrange wrote:
* docs/schemas/domain.rng: Add serial element to disks
* src/domain_conf.h, src/domain_conf.c: XML parsing and
formatting for disk serial numbers
* src/qemu_conf.c: Set serial number when launching guests
*
On Thu, Sep 03, 2009 at 01:04:30PM +0100, Mark McLoughlin wrote:
Apart from DV's comments, ACK to patches 1-3
On Tue, 2009-09-01 at 16:28 +0100, Daniel P. Berrange wrote:
* src/security.h: Driver API for relabelling host devices
* src/security_selinux.c: Implement relabelling of PCI and
First dead-store-related bug fix:
From 6024fb05dfa2dd408ad79abbac88791f5048af11 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 14:09:49 +0200
Subject: [PATCH] python: let libvirt_virConnectDomainEventCallback indicate
success
* python/libvir.c
On Fri, Aug 07, 2009 at 11:06:31AM +0200, Chris Lalancette wrote:
Allow the daemon itself to make RPCs to an external libvirtd, but only if
the URI is fully specified. While this isn't used at the moment, it will
be for the tunnelled migration support in the future.
Signed-off-by: Chris
On Wed, Aug 26, 2009 at 02:03:07PM +0100, Daniel P. Berrange wrote:
[...]
+if (def-hugepage_backed) {
+if (!driver-hugetlbfs_mount) {
+qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
+ %s, _(hugetlbfs filesystem is not mounted));
This removes dead code and suppresses a warning from clang.
However, see below:
From 2ed548cbe948aa7ef37ccd121bd084bd05019ac8 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 16:35:47 +0200
Subject: [PATCH] esx_vi: remove unreachable code
* src/esx/esx_vi.c
2009/9/3 Jim Meyering j...@meyering.net:
This removes dead code and suppresses a warning from clang.
However, see below:
From 2ed548cbe948aa7ef37ccd121bd084bd05019ac8 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 16:35:47 +0200
Subject: [PATCH]
Matthias Bolte wrote:
Oops, however that happened... good find. The clang analyzer seems to
be a valuable tool.
The fix for this is to swap goto cleanup; and result = -1; (see
attached patch).
Matthias
diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c
index 724e945..0919774 100644
---
On Thu, Aug 13, 2009 at 03:32:45PM +0200, Pritesh Kothari wrote:
Hi All,
I have made some changes to the functions vboxNetworkCreateXML(),
vboxNetworkDefineXML(), vboxNetworkUndefine() and vboxNetworkDestroy() to
handle
multiple host only interfaces as multiple host only interfaces are
Obviously unnecessary.
Maybe someone had plans for these long ago?
From 94730ec1d99076cd18b04b950adad7c7a576071f Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 17:11:14 +0200
Subject: [PATCH] xen_internal.c: remove two unused local variables
*
On Mon, Aug 24, 2009 at 09:51:05PM +0100, Daniel P. Berrange wrote:
If a file descriptor with events=0 was added to the libvirtd
event loop, it would still be added to the poll() fds' array.
While it wouldn't see any POLLIN/OUT events, it'd still get
triggered for HANGUP/ERROR events which was
On Wed, 2009-08-26 at 15:59 +0100, Daniel P. Berrange wrote:
This patch series does three things
- Moves QEMU monitor sockets in /var/lib/libvirt/qemu, since this is
created file and thus should be separate from libvirtd created data
to avoid risk from QEMU compromise.
- Sets QEMU
On Thu, Sep 03, 2009 at 02:10:24PM +0200, Jim Meyering wrote:
First dead-store-related bug fix:
From 6024fb05dfa2dd408ad79abbac88791f5048af11 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 14:09:49 +0200
Subject: [PATCH] python: let
On Thu, Sep 03, 2009 at 05:12:14PM +0200, Jim Meyering wrote:
Obviously unnecessary.
Maybe someone had plans for these long ago?
From 94730ec1d99076cd18b04b950adad7c7a576071f Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 17:11:14 +0200
Subject:
Hi All,
I have added support for Storage Volumes in VirtualBox, the patch for the same
is attached here.
(needs the little bit cleanup patch previously posted)
Regards,
Pritesh
commit 4fc1ae881a8c45985c777605a012933c783f7d7c
Author: Pritesh Kothari pritesh.koth...@sun.com
Date: Thu Sep 3
* src/logging.c: Fix buffer offset in logging read
---
src/logging.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/logging.c b/src/logging.c
index e46e2be..07c2b0e 100644
--- a/src/logging.c
+++ b/src/logging.c
@@ -240,7 +240,7 @@ static void virLogStr(const char
* src/qemu_conf.c: Fix leak of values upon OOM
* src/xend_internal.c: Fix missing check for OOM failure
* tests/qemuargv2xmltest.c, tests/qemuxml2argvtest.c: Free
stateDir upon exit to avoid leak
---
src/qemu_conf.c | 21 ++---
src/xend_internal.c |6 ++
* src/esx/esx_driver.c: handle spaces in VMX file path and use a
virBuffer to encode spaces correctly in the resulting URL
* src/esx/esx_vi.c: include the URL in the error message in case
of a download error
0001-VMware-ESX-Fix-VMX-path-parsing-and-URL-encoding.patch
Description:
Check the config status before requesting config subelements
* src/esx/esx_driver.c: add configStatus to the requested properties
to check it in esxVI_GetVirtualMachineIdentity()
* src/esx/esx_vi.[ch]: add esxVI_GetManagedEntityStatus()
and use it in esxVI_GetVirtualMachineIdentity()
*
* src/esx/esx_vi.[ch]: use virXPathNode*() in esxVI_RemoteRequest_Execute()
and remove esxVI_RemoteResponse_DeserializeXPathObject*()
* src/esx/esx_vi_methods.c: update callers to use the new syntax of
esxVI_RemoteRequest_Execute()
0003-VMware-ESX-Use-virXPathNode-to-simplify-XPath-ha.patch
* src/esx/esx_util.c: let esxUtil_GetConfigUUID() report an error if
virUUIDParse() fails
0007-VMware-ESX-Check-the-result-of-virUUIDParse-in-es.patch
Description: application/mbox
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
* src/esx/esx_driver.c: add esxCapsInit() with default caps and add
esxGetCapabilities()
0005-VMware-ESX-Add-esxGetCapabilities-with-basic-defa.patch
Description: application/mbox
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
* src/esx/esx_driver.c: add esxDomainUndefine() based on
esxVI_UnregisterVM()
* src/esx/esx_vi_methods.[ch]: add esxVI_UnregisterVM()
0006-VMware-ESX-Add-esxDomainUndefine-based-on-esxVI_U.patch
Description: application/mbox
--
Libvir-list mailing list
Libvir-list@redhat.com
clang reported that this assignment to type is a dead store,
since type is never used after this point.
This is xm_internal.c, line 1074:
/* XXX Forcing to pretend its a bridge */
if (type == -1) {
type = 1;
}
Normally I'd just remove the
On Wed, Sep 02, 2009 at 11:28:27AM -0400, Dave Allan wrote:
@@ -1177,6 +1180,26 @@ if test $with_storage_scsi = check; then
fi
AM_CONDITIONAL([WITH_STORAGE_SCSI], [test $with_storage_scsi = yes])
+if test $with_storage_mpath = check; then
+ with_storage_mpath=yes
+
+
From a2d03c987bb724283207dbeef873178c08a6c4c5 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 18:14:48 +0200
Subject: [PATCH 1/3] storage_backend_logical.c: appease clang: remove useless
increment
* src/storage_backend_logical.c
60 matches
Mail list logo
