Daniel Veillard wrote:
On Fri, Aug 07, 2009 at 11:06:31AM +0200, Chris Lalancette wrote:
Allow the daemon itself to make RPCs to an external libvirtd, but only if
the URI is fully specified. While this isn't used at the moment, it will
be for the tunnelled migration support in the future.
On Fri, Sep 04, 2009 at 09:22:30AM +0200, Chris Lalancette wrote:
Daniel Veillard wrote:
On Fri, Aug 07, 2009 at 11:06:31AM +0200, Chris Lalancette wrote:
Allow the daemon itself to make RPCs to an external libvirtd, but only if
the URI is fully specified. While this isn't used at the
These changes fix two dead stores and add a comment suggesting
why *not* to remove the third one.
From 41c778fdbaef9abf52bc4c3e278d3389d8198c34 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 4 Sep 2009 10:55:55 +0200
Subject: [PATCH 1/3] interface_conf.c: remove a
Jim Meyering wrote:
From a2d03c987bb724283207dbeef873178c08a6c4c5 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 18:14:48 +0200
Subject: [PATCH 1/3] storage_backend_logical.c: appease clang: remove useless
increment
...
From
Daniel P. Berrange wrote:
* src/logging.c: Fix buffer offset in logging read
---
src/logging.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/logging.c b/src/logging.c
index e46e2be..07c2b0e 100644
--- a/src/logging.c
+++ b/src/logging.c
@@ -240,7 +240,7 @@
(sorry for a really late reply)
Dave wrote:
Hello,
I'm trying to get eucalyptus v1.5.2 working with debian lenny, the
relevant versions of libvirt software installed are from the apt-get
repos, which are:
# dpkg -l|grep libvirt
ii libvirt-bin 0.4.6-10
On Wed, Aug 26, 2009 at 03:53:01AM -0300, Eduardo Otubo wrote:
Hello friends,
This is the new version of phyp driver now using libssh2. I also did
some other changes:
* Added some debug information. Sometimes its worth to know which
command is being executed and where. So I added the
Erkan Unal wrote:
Hi,
I am using libvirt for qemu/kvm. I have following questions in terms of
save and restore (Version 0.6.2):
1) As I checked the libvirt code, restore command is asynchronous. There
is a macro called VIR_EXEC_NONBLOCK but there is no macro called
VIR_EXEC_BLOCK. Is
On Fri, Sep 04, 2009 at 12:14:20PM +0200, Daniel Veillard wrote:
On Wed, Aug 26, 2009 at 03:53:01AM -0300, Eduardo Otubo wrote:
Hello friends,
This is the new version of phyp driver now using libssh2. I also did
some other changes:
* Added some debug information. Sometimes its
On Wed, Aug 26, 2009 at 06:24:09PM +0100, Daniel P. Berrange wrote:
* src/xend_internal.c: Lookup guest after starting persistent
config in order to refresh the domain ID field
Makes sense, pushing.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
On Wed, Aug 26, 2009 at 11:39:54AM -0600, Jim Fehlig wrote:
Finally have some time to submit this small patch for a bug I'm seeing
with Xen 3.3.1.
If s-expression returned by xend contains an empty list, sexpr2string()
failed to serialize it. E.g. sexpr containing (cpus (()())) would cause
Hi!
My buildbot spotted a problem with the latest changes to Phyp, as the
function libssh2_session_block_directions() only is available with
libssh2 version 1.0 and later.
At least on Debian Lenny there is an older one which prevents libVirt
from building, so I updated the configure.in script to
On Fri, Aug 28, 2009 at 11:21:07AM +0100, Daniel P. Berrange wrote:
Latest upstream QEMU can be built with Xen support, which introduces
a -xen-domid argument. This was mistakenly detected as -domid due
to old Xenner support. Adapt to cope with both syntax. Also only
set domid if the virt
On Sun, Aug 30, 2009 at 03:59:08PM -0400, Laine Stump wrote:
I found this while looking for examples of using
virNodeDeviceGetXMLDesc(). AFAIK, *all* of the *GetXMLDesc() functions
return a newly allocated chunk of memory that is owned by the caller,
who must free it when they're done...
On Sun, Aug 30, 2009 at 04:06:45PM -0400, Laine Stump wrote:
Fix some minor grammer (and one other) nits in comments that end up in
generated API reference documentation. No functional/binary differences.
Thanks ! Applied too, I will regenerate the docs later though,
Daniel
--
Daniel
On Mon, Aug 31, 2009 at 02:49:16PM +0200, Pritesh Kothari wrote:
Hi All,
Just cleaned up some code to make the it more readable.
The patch is attached here with. Directly applies to the HEAD as of today.
Yup, nice, applied,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML
On Thu, Sep 03, 2009 at 08:51:52AM +0900, Ryota Ozaki wrote:
Hi,
This is the revised patch. The changes include dropping two fixes
and revising one along with Chris' and Daniel's suggestions. Other
fixes keep as they were.
[...]
diff --git a/src/network_conf.c b/src/network_conf.c
index
On Thu, Sep 03, 2009 at 12:49:25PM +0200, Jim Meyering wrote:
Daniel P. Berrange wrote:
On Thu, Sep 03, 2009 at 11:18:00AM +0200, Jim Meyering wrote:
clang was complaining that a NULL inputvol would be dereferenced
in that could not open... diagnostic.
Since the two sole callers of this
On Thu, Sep 03, 2009 at 12:38:43PM +0200, Jim Meyering wrote:
Jim Meyering wrote:
When I reran the tool, there was still a potential NULL-deref,
so I propose to do this instead:
From d120f7693f1ae0e213bd9e8b244968b49dfe1427 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
This started with a dead-store report:
File: lxc_container.c
Location: line 417, column 10
Description:Although the value stored to 'rc' is used in the
enclosing expression, the value is never actually read from 'rc'
But there was a leak,
On Thu, Sep 03, 2009 at 01:39:25PM +0200, Jim Meyering wrote:
Jim Meyering wrote:
Daniel P. Berrange wrote:
...
Actually I did that first, but then un-did it in favor
of the change above. Why? because that initialization could
mask a failure to initialize in a new case.
With
On Thu, Sep 03, 2009 at 05:55:53PM +0200, Pritesh Kothari wrote:
Hi All,
I have added support for Storage Volumes in VirtualBox, the patch for the
same
is attached here.
(needs the little bit cleanup patch previously posted)
Looks fine, to the extend that I understand the code
On Fri, Sep 04, 2009 at 11:34:09AM +0200, Jim Meyering wrote:
Jim Meyering wrote:
From a2d03c987bb724283207dbeef873178c08a6c4c5 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 3 Sep 2009 18:14:48 +0200
Subject: [PATCH 1/3] storage_backend_logical.c: appease
Daniel Veillard wrote:
On Thu, Sep 03, 2009 at 01:39:25PM +0200, Jim Meyering wrote:
Jim Meyering wrote:
Daniel P. Berrange wrote:
...
Actually I did that first, but then un-did it in favor
of the change above. Why? because that initialization could
mask a failure to initialize in a
On Thu, Sep 03, 2009 at 06:28:13PM +0200, Jim Meyering wrote:
clang reported that this assignment to type is a dead store,
since type is never used after this point.
This is xm_internal.c, line 1074:
/* XXX Forcing to pretend its a bridge */
if (type == -1) {
On Thu, Sep 03, 2009 at 05:39:24PM +0100, Daniel P. Berrange wrote:
* src/logging.c: Fix buffer offset in logging read
---
src/logging.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/logging.c b/src/logging.c
index e46e2be..07c2b0e 100644
---
On 09/02/2009 07:09 PM, Daniel P. Berrange wrote:
On Wed, Sep 02, 2009 at 11:59:39AM -0400, Jim Paris wrote:
Jiri Denemark wrote:
Hi,
We need to provide support for CPU ID masking. Xen and VMware ESX are examples
of current hypervisors which support such masking.
My proposal is to define new
On Thu, Sep 03, 2009 at 05:39:53PM +0100, Daniel P. Berrange wrote:
* src/qemu_conf.c: Fix leak of values upon OOM
* src/xend_internal.c: Fix missing check for OOM failure
* tests/qemuargv2xmltest.c, tests/qemuxml2argvtest.c: Free
stateDir upon exit to avoid leak
---
src/qemu_conf.c
From dead-store warnings:
From c925b02828083a016f7b9a7ae93eb3a7bf5f4609 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 4 Sep 2009 17:18:29 +0200
Subject: [PATCH] storage_driver.c: remove two useless calls to
virStorageBackendForType
* src/storage_driver.c
Two more dead stores:
From 92bf654b02e5c1eb3334fc13ef52f5b0679512ea Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 4 Sep 2009 17:22:19 +0200
Subject: [PATCH] xm_internal.c: remove two ret=... dead stores
* src/xm_internal.c (xenXMDomainCreate): Remove dead stores.
---
Another dead store:
From 06c5ed162cbdcfec74461e9d09c82244242cc6a2 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 4 Sep 2009 17:27:34 +0200
Subject: [PATCH] domain_conf.c: remove dead store
* src/domain_conf.c (virDomainSaveXML): ...and decl of err.
---
Hi,
This is an attempt to provide similar flexibility to CPU ID masking without
being x86-specific and unfriendly to users. As suggested by Dan, we need a way
to specify both CPU flags and topology to achieve this goal.
Firstly, CPU topology and all (actually all that libvirt knows about) CPU
Daniel Veillard wrote:
On Thu, Sep 03, 2009 at 06:28:13PM +0200, Jim Meyering wrote:
clang reported that this assignment to type is a dead store,
since type is never used after this point.
This is xm_internal.c, line 1074:
/* XXX Forcing to pretend its a bridge */
On Thu, Sep 03, 2009 at 06:44:47PM +0200, Matthias Bolte wrote:
* src/esx/esx_driver.c: handle spaces in VMX file path and use a
virBuffer to encode spaces correctly in the resulting URL
* src/esx/esx_vi.c: include the URL in the error message in case
of a download error
Looks fine, ACK,
On Thu, Sep 03, 2009 at 06:44:59PM +0200, Matthias Bolte wrote:
Check the config status before requesting config subelements
* src/esx/esx_driver.c: add configStatus to the requested properties
to check it in esxVI_GetVirtualMachineIdentity()
* src/esx/esx_vi.[ch]: add
On Thu, Sep 03, 2009 at 06:45:11PM +0200, Matthias Bolte wrote:
* src/esx/esx_vi.[ch]: use virXPathNode*() in esxVI_RemoteRequest_Execute()
and remove esxVI_RemoteResponse_DeserializeXPathObject*()
* src/esx/esx_vi_methods.c: update callers to use the new syntax of
On Thu, Sep 03, 2009 at 06:45:34PM +0200, Matthias Bolte wrote:
* src/esx/esx_vi.[ch]: convert esxVI_RemoteRequest_Execute() to a
simpler esxVI_Context_Execute() version, remove esxVI_RemoteRequest
and convert esxVI_RemoteResponse to esxVI_Response
* src/esx/esx_vi_methods.c: update and
On Thu, Sep 03, 2009 at 06:45:44PM +0200, Matthias Bolte wrote:
* src/esx/esx_driver.c: add esxCapsInit() with default caps and add
esxGetCapabilities()
Hum ... That one looks really incomplete. Does it really make sense
to implement it just based on pure default without asking the ESX
On Thu, Sep 03, 2009 at 06:45:54PM +0200, Matthias Bolte wrote:
* src/esx/esx_driver.c: add esxDomainUndefine() based on
esxVI_UnregisterVM()
* src/esx/esx_vi_methods.[ch]: add esxVI_UnregisterVM()
Looks fine, there is just that small limitiation
+if (powerState !=
On Thu, Sep 03, 2009 at 06:46:03PM +0200, Matthias Bolte wrote:
* src/esx/esx_util.c: let esxUtil_GetConfigUUID() report an error if
virUUIDParse() fails
Nice fix ! Applied too,
thanks,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
On Fri, Sep 04, 2009 at 11:22:28AM +0200, Jim Meyering wrote:
These changes fix two dead stores and add a comment suggesting
why *not* to remove the third one.
From 41c778fdbaef9abf52bc4c3e278d3389d8198c34 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 4 Sep 2009
2009/9/4 Daniel Veillard veill...@redhat.com:
On Thu, Sep 03, 2009 at 06:44:47PM +0200, Matthias Bolte wrote:
* src/esx/esx_driver.c: handle spaces in VMX file path and use a
virBuffer to encode spaces correctly in the resulting URL
* src/esx/esx_vi.c: include the URL in the error message in
On Fri, Sep 04, 2009 at 04:52:07PM +0200, Jim Meyering wrote:
Daniel Veillard wrote:
On Thu, Sep 03, 2009 at 06:28:13PM +0200, Jim Meyering wrote:
clang reported that this assignment to type is a dead store,
since type is never used after this point.
This is xm_internal.c, line 1074:
2009/9/4 Daniel Veillard veill...@redhat.com:
On Thu, Sep 03, 2009 at 06:45:44PM +0200, Matthias Bolte wrote:
* src/esx/esx_driver.c: add esxCapsInit() with default caps and add
esxGetCapabilities()
Hum ... That one looks really incomplete. Does it really make sense
to implement it just
On Fri, Sep 04, 2009 at 04:15:20PM +0200, Jim Meyering wrote:
This started with a dead-store report:
File: lxc_container.c
Location: line 417, column 10
Description: Although the value stored to 'rc' is used in the
enclosing expression, the
2009/9/4 Daniel Veillard veill...@redhat.com:
On Thu, Sep 03, 2009 at 06:45:54PM +0200, Matthias Bolte wrote:
* src/esx/esx_driver.c: add esxDomainUndefine() based on
esxVI_UnregisterVM()
* src/esx/esx_vi_methods.[ch]: add esxVI_UnregisterVM()
Looks fine, there is just that small
On Fri, Sep 04, 2009 at 05:19:21PM +0200, Jim Meyering wrote:
From dead-store warnings:
From c925b02828083a016f7b9a7ae93eb3a7bf5f4609 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 4 Sep 2009 17:18:29 +0200
Subject: [PATCH] storage_driver.c: remove two useless
Daniel Veillard wrote:
On Fri, Sep 04, 2009 at 04:15:20PM +0200, Jim Meyering wrote:
This started with a dead-store report:
File:lxc_container.c
Location:line 417, column 10
Description: Although the value stored to 'rc' is used in the
On Fri, Sep 04, 2009 at 05:23:04PM +0200, Jim Meyering wrote:
Two more dead stores:
From 92bf654b02e5c1eb3334fc13ef52f5b0679512ea Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 4 Sep 2009 17:22:19 +0200
Subject: [PATCH] xm_internal.c: remove two ret=... dead
On Fri, Sep 04, 2009 at 05:27:58PM +0200, Jim Meyering wrote:
Another dead store:
From 06c5ed162cbdcfec74461e9d09c82244242cc6a2 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 4 Sep 2009 17:27:34 +0200
Subject: [PATCH] domain_conf.c: remove dead store
*
On Fri, Sep 04, 2009 at 06:38:29PM +0200, Matthias Bolte wrote:
2009/9/4 Daniel Veillard veill...@redhat.com:
On Thu, Sep 03, 2009 at 06:44:47PM +0200, Matthias Bolte wrote:
* src/esx/esx_driver.c: handle spaces in VMX file path and use a
virBuffer to encode spaces correctly in the
Daniel Veillard wrote:
Hum ... I'm afraid it changes the semantic. If
virStorageBackendForType fails because def-type is not one of the
registered type for storage backend.
Oh! of course. Glad you're alert.
Here's the corrected patch:
From b9821214789025ca9621b2651d326e261a0d14aa Mon
From 7a2202539b6445017c420644e5327ce64eaf3bac Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 4 Sep 2009 17:27:34 +0200
Subject: [PATCH 1/2] domain_conf.c: remove two dead stores
* src/domain_conf.c (virDomainSaveXML): Remove use and decl of err.
This patch series implements the AppArmor security driver for sVirt.
This implementation was developed for the Ubuntu AppArmorLibvirtProfile
specification[1], but is general enough for any AppArmor deployment
(such as Ubuntu, *SUSE and Mandriva).
This patch has seen quite a bit of real world
On Fri, 04 Sep 2009, Jamie Strandboge wrote:
[PATCH 4]
patch_4_tests.patch:
--
Jamie Strandboge | http://www.canonical.com
diff -Nurp ./libvirt.orig/tests/Makefile.am ./libvirt/tests/Makefile.am
--- ./libvirt.orig/tests/Makefile.am 2009-08-17 11:00:40.0 -0500
+++
On Fri, 04 Sep 2009, Jamie Strandboge wrote:
[PATCH 3]
patch_3_security_apparmor.patch:
--
Jamie Strandboge | http://www.canonical.com
diff -Nurp ./libvirt.orig/po/POTFILES.in ./libvirt/po/POTFILES.in
--- ./libvirt.orig/po/POTFILES.in 2009-09-02 14:34:08.0 -0500
+++
On Fri, 04 Sep 2009, Jamie Strandboge wrote:
[PATCH 1*]
patch_1a_reenable-nonfile-labels.patch:
patch_1b_optional.patch:
Resending with the proper subject line. :\
--
Jamie Strandboge | http://www.canonical.com
diff -Nurp ./libvirt.orig/src/qemu_driver.c
On Fri, 04 Sep 2009, Jamie Strandboge wrote:
[PATCH 6]
patch_6_autoconf.patch:
--
Jamie Strandboge | http://www.canonical.com
diff -Nurp ./libvirt.orig/configure.in ./libvirt/configure.in
--- ./libvirt.orig/configure.in 2009-09-03 13:36:00.0 -0500
+++
From 99610dd77b95914623bd78f2bcac5d15a6c87024 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 4 Sep 2009 19:14:09 +0200
Subject: [PATCH] xend_internal.c: Remove two dead stores to ret
* src/xend_internal.c (xenDaemonCreateXML): Don't set ret after
last use.
---
From 66133e3b9d80e9fadefd810786b0ff2f5c8e6875 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 4 Sep 2009 19:15:51 +0200
Subject: [PATCH] network_conf.c: remove dead store to err
* src/network_conf.c (virNetworkDefParseXML): ...and its decl.
---
src/network_conf.c |
From 559c1ba31a89fd3a6ed54631d5d900fa16140187 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 4 Sep 2009 19:11:31 +0200
Subject: [PATCH] openvz_driver.c: avoid dead store to err
* src/openvz_driver.c (openvzGenerateContainerVethName): Remove use
and decl of err.
---
On Fri, 04 Sep 2009, Jamie Strandboge wrote:
[PATCH 5]
patch_5_docs.patch:
--
Jamie Strandboge | http://www.canonical.com
diff -Nurp ./libvirt.orig/docs/drvqemu.html.in ./libvirt/docs/drvqemu.html.in
--- ./libvirt.orig/docs/drvqemu.html.in 2009-09-02 14:34:08.0 -0500
+++
On Fri, 04 Sep 2009, Jamie Strandboge wrote:
[PATCH 1*]
patch_1a_reenable-nonfile-labels.patch:
patch_1b_optional.patch:
--
Jamie Strandboge | http://www.canonical.com
diff -Nurp ./libvirt.orig/src/qemu_driver.c ./libvirt/src/qemu_driver.c
--- ./libvirt.orig/src/qemu_driver.c
On Fri, 04 Sep 2009, Jamie Strandboge wrote:
[PATCH 2]
patch_2_security_c.patch:
--
Jamie Strandboge | http://www.canonical.com
diff -Nurp ./libvirt.orig/src/security.c ./libvirt/src/security.c
--- ./libvirt.orig/src/security.c 2009-08-17 11:00:40.0 -0500
+++
On Fri, Sep 04, 2009 at 12:23:33PM -0500, Jamie Strandboge wrote:
This patch series implements the AppArmor security driver for sVirt.
This implementation was developed for the Ubuntu AppArmorLibvirtProfile
specification[1], but is general enough for any AppArmor deployment
(such as Ubuntu,
On Fri, Sep 04, 2009 at 06:49:32PM +0200, Matthias Bolte wrote:
2009/9/4 Daniel Veillard veill...@redhat.com:
On Thu, Sep 03, 2009 at 06:45:44PM +0200, Matthias Bolte wrote:
* src/esx/esx_driver.c: add esxCapsInit() with default caps and add
esxGetCapabilities()
Hum ... That one
On Fri, Sep 04, 2009 at 06:54:14PM +0200, Matthias Bolte wrote:
2009/9/4 Daniel Veillard veill...@redhat.com:
On Thu, Sep 03, 2009 at 06:45:54PM +0200, Matthias Bolte wrote:
* src/esx/esx_driver.c: add esxDomainUndefine() based on
esxVI_UnregisterVM()
* src/esx/esx_vi_methods.[ch]: add
On Fri, Sep 04, 2009 at 07:04:57PM +0200, Jim Meyering wrote:
Daniel Veillard wrote:
Hum ... I'm afraid it changes the semantic. If
virStorageBackendForType fails because def-type is not one of the
registered type for storage backend.
Oh! of course. Glad you're alert.
Here's the
On Fri, 04 Sep 2009, Daniel Veillard wrote:
On Fri, Sep 04, 2009 at 12:23:33PM -0500, Jamie Strandboge wrote:
This patch series implements the AppArmor security driver for sVirt.
This implementation was developed for the Ubuntu AppArmorLibvirtProfile
specification[1], but is general enough
While debugging something that looked like an file descriptor leak, we
(Maximilian Wilhelm and me) found some places where
close/fclose/closedir calls are missing, mostly in error handling
if-branches.
See attached patch.
Max and Matthias
close.patch
Description: application/mbox
--
70 matches
Mail list logo
