Re: [libvirt] [RFC] Support for CPUID masking v2

2009-09-14 Thread 'Jiri Denemark'
I'm not sure how to deal with named CPUs suggested by Dan. Either we need to come up with global set of named CPUs and document what they mean or let drivers specify their own named CPUs and advertise them through guest capabilities: guest ... cpu model=NAME

[libvirt] [PATCH]: API Change patch for VBox 3.0.6

2009-09-14 Thread Pritesh Kothari
Hi All, VirtualBox 3.0.6 was released few days ago and there were some minor API changes in it. I have created a patch for the same and posting it here. Regards, Pritesh commit 72088db113ce5837cce91616ebbf64dcd1a2b0ee Author: Pritesh Kothari pritesh.koth...@sun.com Date: Mon Sep 14 09:05:38

Re: [libvirt] Interface driver and ESX support

2009-09-14 Thread Shahar Klein
Thanks Matthias works great : ) From: Matthias Bolte matthias.bo...@googlemail.com To: Shahar Klein shaharkl...@yahoo.com Cc: libvir-list@redhat.com Sent: Monday, September 14, 2009 3:57:52 AM Subject: Re: [libvirt] Interface driver and ESX support Okay, I

Re: [libvirt] [PATCH]: API Change patch for VBox 3.0.6

2009-09-14 Thread Daniel Veillard
On Mon, Sep 14, 2009 at 09:11:29AM +0200, Pritesh Kothari wrote: Hi All, VirtualBox 3.0.6 was released few days ago and there were some minor API changes in it. I have created a patch for the same and posting it here. Okay, since you promised me on IRC this was really risk free and fully

[libvirt] Python binding to virConnectListInterfaces

2009-09-14 Thread Shahar Klein
Hi I'm trying to implement virConnectListInterfaces for the ESX driver (actually the esx_interface driver) but the python generator does not write the code for this function in generator.py this function is in a special table called: skip_impl and there is a comment saying: # Class methods

Re: [libvirt] ESX [11/12]: Reorder some function calls to avoid potential virDomainPtr leaks

2009-09-14 Thread Daniel Veillard
On Mon, Sep 14, 2009 at 02:45:34AM +0200, Matthias Bolte wrote: * src/esx/esx_driver.c: avoid potential virDomainPtr leaks diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 5a93d1f..91de407 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c Okay, that's clearly a

Re: [libvirt] ESX [05/12]: Also strip (C) and (TM) from the CPU model string

2009-09-14 Thread Daniel Veillard
On Mon, Sep 14, 2009 at 02:42:35AM +0200, Matthias Bolte wrote: * src/esx/esx_driver.c: also strip (C) and (TM) from the CPU model string diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 3f3ee30..96d5976 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -746,9

Re: [libvirt] ESX [07/12]: Whitespace cleanup

2009-09-14 Thread Daniel Veillard
On Mon, Sep 14, 2009 at 02:43:33AM +0200, Matthias Bolte wrote: Subject says it all. diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 745b744..8194b49 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -752,13 +752,13 @@ esxGetHostname(virConnectPtr conn)

[libvirt] [PATCH] Fix win32 platform build

2009-09-14 Thread Daniel P. Berrange
* configure.in: Only define WITH_SECRETS if libvirtd is present * src/Makefile.am: Only build secrets driver if WITH_SECRETS is defined. Always add SECRET_DRIVER_SOURCES to EXTRA_DIST --- configure.in| 11 +++ src/Makefile.am |3 +++ 2 files changed, 14 insertions(+), 0

Re: [libvirt] [PATCH] Fix win32 platform build

2009-09-14 Thread Daniel Veillard
On Mon, Sep 14, 2009 at 01:32:38PM +0100, Daniel P. Berrange wrote: * configure.in: Only define WITH_SECRETS if libvirtd is present * src/Makefile.am: Only build secrets driver if WITH_SECRETS is defined. Always add SECRET_DRIVER_SOURCES to EXTRA_DIST --- configure.in| 11 +++

[libvirt] RFE storage cloning across connections.

2009-09-14 Thread Jóhann B. Guðmundsson
Virt-manager now supports migration and VM cloning however cloning only works within a connection though so you can't clone to another machine. It certainly would be a nice addition if supports storage cloning across connections. Best regards. Jóhann B. -- Libvir-list mailing

Re: [libvirt] [PATCH 1/4] Fix UUID handling in secrets/storage encryption APIs

2009-09-14 Thread Daniel P. Berrange
On Fri, Sep 11, 2009 at 08:28:59PM -0400, Miloslav Trmac wrote: - Daniel P. Berrange berra...@redhat.com wrote: @@ -635,49 +620,25 @@ secretLookupByUUIDString(virConnectPtr conn, const char *uuid) pptr = secretFind(driver, uuid); if (pptr == NULL) { +char

Re: [libvirt] Interface driver and ESX support

2009-09-14 Thread Daniel Veillard
On Mon, Sep 14, 2009 at 02:57:52AM +0200, Matthias Bolte wrote: Okay, I finally got the patches cleaned up. I just posted this 12 patches series to the mailing list. Apply them all to an up to date git clone and apply the attached, updated ESX interface driver stub patch in the end. Patch

Re: [libvirt] [PATCH 2/4] Add usage type/id as a public API property of virSecret

2009-09-14 Thread Daniel Veillard
On Fri, Sep 11, 2009 at 06:31:02PM +0100, Daniel P. Berrange wrote: On Fri, Sep 11, 2009 at 06:17:40PM +0200, Daniel Veillard wrote: On Fri, Sep 11, 2009 at 03:19:18PM +0100, Daniel P. Berrange wrote: +/** + * virSecretGetUsageType: + * @secret: a secret object + * + * Get

Re: [libvirt] Interface driver and ESX support

2009-09-14 Thread Matthias Bolte
2009/9/14 Daniel Veillard veill...@redhat.com: On Mon, Sep 14, 2009 at 02:57:52AM +0200, Matthias Bolte wrote: Okay, I finally got the patches cleaned up. I just posted this 12 patches series to the mailing list. Apply them all to an up to date git clone and apply the attached, updated ESX

Re: [libvirt] [RFC, PATCH] network: add 'netboot' option to dhcp config

2009-09-14 Thread Paolo Bonzini
On 09/11/2009 06:47 AM, Jeremy Kerr wrote: Currently, libvirtd will start a dnsmasq process for the virtual network, but (aside from killing the dnsmasq process and replacing it), there's no way to define tftp boot options. This change introduces a 'netboot' tag to the dhcp configuration:

[libvirt] [PATCH]: Bug when you try to start machines made will older VBox versions

2009-09-14 Thread Pritesh Kothari
Hi All, Thanks to Florian, who pointed out the bug, due to which you can't start domains defined with older builds or with empty FRONTEND/Type tag in their xml files. Fixed it in the following patch. Regards, Pritesh commit 612e914a8b5902f779223f70552a16d86ede6e6f Author: Pritesh Kothari

Re: [libvirt] [PATCH]: Bug when you try to start machines made will older VBox versions

2009-09-14 Thread Daniel Veillard
On Mon, Sep 14, 2009 at 04:53:32PM +0200, Pritesh Kothari wrote: Hi All, Thanks to Florian, who pointed out the bug, due to which you can't start domains defined with older builds or with empty FRONTEND/Type tag in their xml files. Fixed it in the following patch. Okay since it's a

[libvirt] [PATCH] network: add 'bootp' and 'tftp' config

2009-09-14 Thread Paolo Bonzini
Currently, libvirtd will start a dnsmasq process for the virtual network, but (aside from killing the dnsmasq process and replacing it), there's no way to define tftp boot options. This change introduces the appropriate tags to the dhcp configuration: network namedefault/name bridge

[libvirt] ANNOUNCE: perl bindings Sys-Virt release 0.2.2

2009-09-14 Thread Daniel P. Berrange
FYI I have just uploaded a new release 0.2.2 of the libvirt perl bindings, Sys-Virt, to CPAN. http://search.cpan.org/dist/Sys-Virt/ Direct download link http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.2.2.tar.gz Changes since 0.2.1: - Add all new APIs upto libvirt 0.7.0

Re: [libvirt] [RFC, PATCH] network: add 'netboot' option to dhcp config

2009-09-14 Thread Jeremy Kerr
Hi Paolo, Since there is only one TFTP server running in the network IIRC, it's possible to have more than one: the Server-Name (id 66) of the DHCP response specifies which. However, we probably only ever want to start one server, so the tftp tag should work fine. , it is not possible to

Re: [libvirt] [RFC, PATCH] network: add 'netboot' option to dhcp config

2009-09-14 Thread Paolo Bonzini
On 09/15/2009 01:01 AM, Jeremy Kerr wrote: Hi Paolo, Since there is only one TFTP server running in the network IIRC, it's possible to have more than one: the Server-Name (id 66) of the DHCP response specifies which. However, we probably only ever want to start one server, so thetftp tag