Re: [libvirt] Some problem with the save function

2009-09-22 Thread Chris Lalancette
Charles Duffy wrote: Chris Lalancette wrote: No, you are right. This was part of the refactoring, and I just didn't re-read the code. I would prefer to move prog to the top of the block myself, and add args there; it just seems tidier. I agree that it's tidier -- but looking at

[libvirt] 0.7.1 compile fails on opensuse 11.1

2009-09-22 Thread Dominik Klein
Hi it seems openSuSE 11.1 does not come with a pkgconfig for the device-mapper-devel package. I created a bug [1] for opensuse but was also told to mention it here so configure.in could be patched once the bug was fixed. Regards Dominik 1 https://bugzilla.novell.com/show_bug.cgi?id=54094 --

Re: [libvirt] [PATCH] lxc: suspend/resume support

2009-09-22 Thread Daniel P. Berrange
On Mon, Sep 21, 2009 at 11:33:12PM +0900, Ryota Ozaki wrote: OK, fixed the two parts. Thanks for the review! And the fixed patch is here! ozaki-r PS: git rebase works well ;-) From abe363de43f5053a01593de6e634f654525cd8b4 Mon Sep 17 00:00:00 2001 From: Ryota Ozaki

[libvirt] [PATCH] Allow control over QEMU audio backend

2009-09-22 Thread Daniel P. Berrange
When using VNC for graphics + keyboard + mouse, we shouldn't then use the host OS for audio. Audio should go back over VNC. When using SDL for graphics, we should use the host OS for audio since that's where the display is. We need to allow certain QEMU env variables to be passed through to guest

Re: [libvirt] [RFC] Support for CPUID masking v2

2009-09-22 Thread Daniel P. Berrange
On Fri, Sep 04, 2009 at 04:58:25PM +0200, Jiri Denemark wrote: Firstly, CPU topology and all (actually all that libvirt knows about) CPU features have to be advertised in host capabilities: host cpu ... features featureNAME/feature

[libvirt] [PATCH] virStrncpy

2009-09-22 Thread Chris Lalancette
Next revision of the virStrncpy patch. This one has the feedback from Mattias Bolte incorporated in, and passes all of the make check tests. I've also done basic testing on the hypervisors I have access to, (xen and kvm) and it seems to work there. That doesn't guarantee that it is bug-free,

[libvirt] [PATCH] Introduce virStrncpy.

2009-09-22 Thread Chris Lalancette
Add the virStrncpy function, which takes a dst string, source string, the number of bytes to copy and the number of bytes available in the dest string. If the source string is too large to fit into the destination string, including the \0 byte, then no data is copied and the function returns

Re: [libvirt] 0.7.1 compile fails on opensuse 11.1

2009-09-22 Thread Pritesh Kothari
it seems openSuSE 11.1 does not come with a pkgconfig for the device-mapper-devel package. I created a bug [1] for opensuse but was also told to mention it here so configure.in could be patched once the bug was fixed. Hi All, Just fixed this for ubuntu (should work now for suse as well) with

Re: [libvirt] qemu_driver migrateuri handling broken?

2009-09-22 Thread Gregor Schaffrath
On Mon, Sep 21, 2009 at 12:46:46PM +0100, Daniel P. Berrange wrote: On Wed, Sep 16, 2009 at 05:42:50PM +0200, Gregor Schaffrath wrote: Hi all. Short summary on DV's request ;) I ran into a problem migrating kvm machines with libvirt-0.6.5: 1) At first, using the same syntax for

Re: [libvirt] [PATCH: 0/MANY] Re-arrange files in the source tree

2009-09-22 Thread Daniel Veillard
[ Sending again since my outgoing mail was down yesterday :-( ] On Wed, Sep 16, 2009 at 07:38:14PM +0100, Daniel P. Berrange wrote: This is a followup to http://www.redhat.com/archives/libvir-list/2009-September/msg00477.html I am not actually going to spam the list with all the patches,

Re: [libvirt] [RFC] Support for CPUID masking v2

2009-09-22 Thread Daniel Veillard
[ Sending again as my mail from yesterday seems to not have gone out :-( ] On Fri, Sep 04, 2009 at 04:58:25PM +0200, Jiri Denemark wrote: Hi, This is an attempt to provide similar flexibility to CPU ID masking without being x86-specific and unfriendly to users. As suggested by Dan, we need a

Re: [libvirt] [PATCH] add doc for graphic and video elements

2009-09-22 Thread Daniel Veillard
[ Sending again as my outgoing mail had troubles ] On Mon, Sep 21, 2009 at 03:31:44PM +0200, Florian Vichot wrote: Hello The title says it all. Here's some doc explaining the new syntax of the video and graphic elements in the domain XML. It (probably) won't get me any literary awards but,

Re: [libvirt] [PATCH] Support a new peer-to-peer migration mode public API

2009-09-22 Thread Daniel Veillard
[ Sending again due to mail output problems ] On Thu, Sep 17, 2009 at 06:25:01PM +0100, Daniel P. Berrange wrote: Introduces several new public API options for migration - VIR_MIGRATE_PEER2PEER: With this flag the client only invokes the virDomainMigratePerform method, expecting the

Re: [libvirt] [PATCH] tiny tiny typos

2009-09-22 Thread Daniel Veillard
On Wed, Sep 16, 2009 at 12:32:25PM +0300, Dan Kenigsberg wrote: --- docs/auth.html.in |2 +- docs/downloads.html.in|2 +- docs/errors.html |2 +- docs/errors.html.in |2 +- docs/formatdomain.html.in |2 +- docs/java.html.in |2 +-

Re: [libvirt] Re: SOLVED kvm networking on debian unstable

2009-09-22 Thread Daniel Veillard
On Thu, Sep 17, 2009 at 09:58:53AM +0200, Thomas Koch wrote: The solution is, to delete /etc/udev/rules.d/70-persistent-net.rules in the guest and reboot. This is an autogenerated file, which stores the mapping of MAC adresses to interface names. Since my MAC address changed, the

[libvirt] Re: Fix Xen virConnectPtr leak

2009-09-22 Thread Chris Lalancette
Matthias Bolte wrote: The fix for this problem is simple: remove the virConnectRef/virUnrefConnect calls from the Xen subdrivers (see attached patch). Maybe someone could explain why the Xen Inotify and Xen Store driver do this extra ref-counting, but none of the other Xen subdrivers. It

Re: [libvirt] [RFC] Support for CPUID masking v2

2009-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2009 at 02:41:08PM +0200, Daniel Veillard wrote: I'm not 100% sure we should represent CPU features as featureNAME/feature especially because some features are currently advertised as NAME/. However, extending XML schema every time a new feature is introduced doesn't

Re: [libvirt] [RFC] Support for CPUID masking v2

2009-09-22 Thread Daniel Veillard
On Tue, Sep 22, 2009 at 02:25:54PM +0100, Daniel P. Berrange wrote: On Tue, Sep 22, 2009 at 02:41:08PM +0200, Daniel Veillard wrote: IMHO the worst is that the definition of the names. First there is gonna be a bunch of them and second their name if you rely just on the procinfo output

Re: [libvirt] [RFC] Support for CPUID masking v2

2009-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2009 at 03:52:08PM +0200, Daniel Veillard wrote: On Tue, Sep 22, 2009 at 02:25:54PM +0100, Daniel P. Berrange wrote: No, we should't rely on /proc/cpuinfo because that is Linux specific. For Xen and VMWare drivers we want a naming scheme for flags that is OS agnostic, in

Re: [libvirt] [PATCH] Introduce virStrncpy.

2009-09-22 Thread Daniel Veillard
On Tue, Sep 22, 2009 at 02:23:26PM +0200, Chris Lalancette wrote: Add the virStrncpy function, which takes a dst string, source string, the number of bytes to copy and the number of bytes available in the dest string. If the source string is too large to fit into the destination string,

Re: [libvirt] [PATCH] Introduce virStrncpy.

2009-09-22 Thread Chris Lalancette
Daniel Veillard wrote: On Tue, Sep 22, 2009 at 02:23:26PM +0200, Chris Lalancette wrote: Add the virStrncpy function, which takes a dst string, source string, the number of bytes to copy and the number of bytes available in the dest string. If the source string is too large to fit into the

Re: [libvirt] [PATCH] Introduce virStrncpy.

2009-09-22 Thread Daniel Veillard
On Tue, Sep 22, 2009 at 04:16:51PM +0200, Chris Lalancette wrote: Daniel Veillard wrote: On Tue, Sep 22, 2009 at 02:23:26PM +0200, Chris Lalancette wrote: Add the virStrncpy function, which takes a dst string, source string, the number of bytes to copy and the number of bytes available in

Re: [libvirt] [RFC] Support for CPUID masking v2

2009-09-22 Thread Daniel Veillard
On Tue, Sep 22, 2009 at 03:01:18PM +0100, Daniel P. Berrange wrote: On Tue, Sep 22, 2009 at 03:52:08PM +0200, Daniel Veillard wrote: On Tue, Sep 22, 2009 at 02:25:54PM +0100, Daniel P. Berrange wrote: No, we should't rely on /proc/cpuinfo because that is Linux specific. For Xen and VMWare

Re: [libvirt] [RFC] Support for CPUID masking v2

2009-09-22 Thread Jiri Denemark
I'm not 100% sure we should represent CPU features as featureNAME/feature especially because some features are currently advertised as NAME/. However, extending XML schema every time a new feature is introduced doesn't look like a good idea at all. The problem is we can't get rid

Re: [libvirt] [RFC] Support for CPUID masking v2

2009-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2009 at 05:51:02PM +0200, Jiri Denemark wrote: I'm not 100% sure we should represent CPU features as featureNAME/feature especially because some features are currently advertised as NAME/. However, extending XML schema every time a new feature is introduced doesn't

Re: [libvirt] [PATCH] Introduce virStrncpy.

2009-09-22 Thread Paolo Bonzini
Unfortunately that's not possible in the case of virStrcpyStatic(). Because virStrcpyStatic() does a sizeof(dest), you have to have the original char foo[123], not a char *, to get something meaningful. That means that it has to either be a macro or not exist at all. (I could be convinced of

Re: [libvirt] 0.7.1 compile fails on opensuse 11.1

2009-09-22 Thread Jim Fehlig
Dominik Klein wrote: Hi it seems openSuSE 11.1 does not come with a pkgconfig for the device-mapper-devel package. I created a bug [1] for opensuse but was also told to mention it here so configure.in could be patched once the bug was fixed. Regards Dominik 1