Re: [Libcg-devel] [libvirt]: Not able to login to container when cgroup is enabled

2009-10-12 Thread Rishikesh
Hi daniel, Sorry for late response, was busy with some other high priority task. Daniel P. Berrange wrote: On Wed, Oct 07, 2009 at 08:12:02PM +0530, Dhaval Giani wrote: The most likely suspect is that the cgroups controllers were mounted or unmounted after libvirtd started. A restart of

[libvirt] [PATCH 1/2] Fix schema to allow missing machine type

2009-10-12 Thread Mark McLoughlin
The domain/os/type element may have an arch specified without having a machine variant specified. In fact, this is what python-virtinst does when defining a guest. * docs/schemas/domain.rng: allow missing machine type --- docs/schemas/domain.rng | 86

[libvirt] [PATCH 2/2] Take domain type into account when looking up default machine

2009-10-12 Thread Mark McLoughlin
If one has e.g. guest os_typehvm/os_type arch name='x86_64' wordsize64/wordsize emulator/usr/bin/qemu-system-x86_64/emulator machinepc-0.11/machine machine canonical='pc-0.11'pc/machine machinepc-0.10/machine machineisapc/machine domain

[libvirt] Execute script on migration

2009-10-12 Thread Radek Hladík
Short question: What is the best way to run some script on VM migration? Detailed description: We use own system for volume management. Its based on md and we found it very flexible. Basic idea is that we have md mirror everywhere we can. This suits great for libvirt: We have a disk on iSCSI

Re: [libvirt] Re: Libvir Xen and domain events

2009-10-12 Thread Daniel P. Berrange
On Fri, Oct 09, 2009 at 06:46:40PM -0400, Christopher Pyper wrote: I have been looking into registering some domain events though the python Libvir API. However, I am getting errors and I believe it may be due to lack of event support in Xen. This is the error I am getting: libvir: Xen

[libvirt] [PATCH] Finer grained migration control

2009-10-12 Thread Chris Lalancette
Normally, when you migrate a domain from host A to host B, the domain on host A remains defined but shutoff and the domain on host B remains running but is a transient. Add a new flag to virDomainMigrate() to allow the original domain to be undefined on source host A, and a new flag to

Re: [libvirt] [RFC] Support for CPUID masking

2009-10-12 Thread Hugh O. Brock
On Sun, Oct 11, 2009 at 11:44:04AM +0200, Dor Laor wrote: On 10/09/2009 12:58 PM, Mukesh G wrote: Speaking from an x86 angle,providing an ability to enable or disable high level constructs like SSE instead of low level constructs, will make it easy to understand. ain't SSE a low level

[libvirt] [PATCH] remote: Don't print a warning every time a remote call fails

2009-10-12 Thread Cole Robinson
$ sudo virsh pool-start idontexist 10:58:18.716: warning : processCallDispatchReply:7612 : Method call error error: failed to get pool 'idontexist' error: Storage pool not found: no pool with matching name 'idontexist' That warning doesn't server much purpose being printed via a virsh call.

[libvirt] [PATCH] storage: Report errors in FindPoolSources

2009-10-12 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- src/storage/storage_driver.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 9ab53e1..4f8949b 100644 --- a/src/storage/storage_driver.c

[libvirt] [PATCH] util: Make sure random data is initialized when in virRandom

2009-10-12 Thread Cole Robinson
When writing some tests, I mistakenly attempted to auto-generate a UUID, which caused a segfault: virRandom was being used without calling virRandomInitialize. Make sure this case can't happen. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/util/util.c |8 1 files changed,

[libvirt] [PATCH] test: Activate interfaces specified through driver config file.

2009-10-12 Thread Cole Robinson
This matches the behavior of domains, storage, etc. Also, fix up some whitespace issues in the area. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/test/test_driver.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/test/test_driver.c

[libvirt] [PATCH 00/10] tests: More XML 2 XML tests and cleanups

2009-10-12 Thread Cole Robinson
In attempting to refactor some storage pool XML parsing, I wanted some unit tests to ensure I wasn't causing regressions. So, the following series adds XML 2 XML tests for storage pools (and virtual networks and storage vols). Also included are several cleanups in tests/, and bug fixes needed to

[libvirt] [PATCH 01/10] tests: Fix text output for interface XML 2 XML

2009-10-12 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- tests/interfacexml2xmltest.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/interfacexml2xmltest.c b/tests/interfacexml2xmltest.c index 6e6c5e8..5ffebad 100644 --- a/tests/interfacexml2xmltest.c +++

[libvirt] [PATCH 02/10] tests: Document VIR_TEST_DEBUG environment variable.

2009-10-12 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- HACKING | 10 ++ tests/interfacexml2xmltest.c |2 -- tests/statstest.c|2 +- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/HACKING b/HACKING index bcff8c6..fba7778 100644 ---

[libvirt] [PATCH 06/10] tests: Add XML 2 XML tests for storage pools.

2009-10-12 Thread Cole Robinson
Move existing schema data to an input directory. Add extra files for more thorough XML testing. Signed-off-by: Cole Robinson crobi...@redhat.com --- tests/.gitignore |1 + tests/Makefile.am | 12 ++-

[libvirt] [PATCH 08/10] schema: Update network schema.

2009-10-12 Thread Cole Robinson
Fix issue with delay/forwardDelay attribute, and add 'none' as a valid forward type. Signed-off-by: Cole Robinson crobi...@redhat.com --- docs/schemas/network.rng | 41 - 1 files changed, 36 insertions(+), 5 deletions(-) diff --git

[libvirt] [PATCH 03/10] tests: Break out duplicate schema verification functionality.

2009-10-12 Thread Cole Robinson
All schema tests have identical functionality, so avoid the duplication. Signed-off-by: Cole Robinson crobi...@redhat.com --- tests/Makefile.am |1 + tests/capabilityschematest | 34 -- tests/domainschematest | 33

[libvirt] [PATCH 09/10] tests: Add network XML to XML tests.

2009-10-12 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- tests/.gitignore |1 + tests/Makefile.am | 12 +++- tests/networkschemadata/netboot-network.xml | 12 --- tests/networkschematest |3

[libvirt] [PATCH 11/11] tests: Add storage volume XML 2 XML tests.

2009-10-12 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- tests/.gitignore |1 + tests/Makefile.am | 12 ++- tests/storagevolschemadata/vol-logical.xml | 20 --- tests/storagevolschemadata/vol-partition.xml |

[libvirt] [PATCH 05/10] schema: Update storage pool schema.

2009-10-12 Thread Cole Robinson
- mpath pools weren't listed - scsi pools were missing an adapter section - iscsi pools were missing an auth section - Logical pools do not require a source name to be specified Signed-off-by: Cole Robinson crobi...@redhat.com --- docs/schemas/storagepool.rng | 51

[libvirt] [PATCH 07/10] network: Fix reading 'forwardDelay' attribute.

2009-10-12 Thread Cole Robinson
When reading network XML, we were looking for a 'delay' attribute, but this value was being dumped as 'forwardDelay'. Support reading both names on input, but continue to only dump 'forwardDelay' Signed-off-by: Cole Robinson crobi...@redhat.com --- src/conf/network_conf.c | 10 -- 1

[libvirt] [PATCH 10/11] tests: Add network XML to XML tests.

2009-10-12 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- tests/.gitignore |1 + tests/Makefile.am | 12 +++- tests/networkschemadata/netboot-network.xml | 12 --- tests/networkschematest |3

[libvirt] Re: [PATCH 11/11] tests: Add storage volume XML 2 XML tests.

2009-10-12 Thread Cole Robinson
On 10/12/2009 10:46 AM, Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com Sorry, this series was a little butchered. This should be patch 10, please ignore the duplicate 'tests: Add network XML to XML tests' - Cole -- Libvir-list mailing list Libvir-list@redhat.com

[libvirt] [PATCH 04/10] storage: Fix generating iscsi 'auth' xml

2009-10-12 Thread Cole Robinson
We were missing a closing tag, so the XML wasn't proper. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/conf/storage_conf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 788de15..1633aac 100644 ---

[libvirt] [PATCH] Fix QEMU restore from file in raw format

2009-10-12 Thread Daniel P. Berrange
The logic for running the decompression programs was broken in commit f238709304f9f6c57204cdd943e542cbae38fa5f, so that for non-raw formats the decompression program was never run, and for raw formats, it tried to exec an argv[] with initial NULL in the program name. * src/qemu/qemu_driver.c: Fix

[libvirt] [PATCH] Fix virFileReadLimFD/virFileReadAll to handle EINTR

2009-10-12 Thread Daniel P. Berrange
The fread_file_lim() function uses fread() but never handles EINTR results, causing unexpected failures when reading QEMU help arg info. It was unneccessarily using FILE * instead of plain UNIX file handles, which prevented use of saferead() * src/util/util.c: Switch fread_file_lim over to use

[libvirt] [PATCH] LXC fix rc handling in lxcVmStart

2009-10-12 Thread Ryota Ozaki
Hi, In lxcVmStart we have to set rc = -1 before jumping to the cleanup code when a local procedure call fails and the rc is overwritten, however, some codes don't observe the rule and so invalid cleanups are likely to happen. A simple solution for the defect is to add rc = -1 before every

Re: [Libcg-devel] [libvirt]: Not able to login to container when cgroup is enabled

2009-10-12 Thread Rishikesh
Rishikesh wrote: Hi daniel, Sorry for late response, was busy with some other high priority task. Daniel P. Berrange wrote: On Wed, Oct 07, 2009 at 08:12:02PM +0530, Dhaval Giani wrote: The most likely suspect is that the cgroups controllers were mounted or unmounted after libvirtd