[libvirt] [PATCH 0/2] Fix a couple problems encountered during virInterface testing

2009-10-28 Thread Laine Stump
When testing all the different possibilities of interfaces with the new netcf release + my latest libvirt patches (ACKed, but not yet committed), I came across some problems, addressed by the following two patches. The first patch is for a bug that crept in due to a last minute change suggested

[libvirt] [PATCH 1/2] Fix improper error return in virInterfaceDefParseProtoIPvX

2009-10-28 Thread Laine Stump
--- src/conf/interface_conf.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 7cb71ed..fc18eba 100644 --- a/src/conf/interface_conf.c +++ b/src/conf/interface_conf.c @@ -309,10 +309,11 @@

[libvirt] [PATCH 2/2] Make some vlan, bond, and bridge properties optional in the interface XML.

2009-10-28 Thread Laine Stump
This is necessary because netcf does not yet know how to get this information from the kernel, so the live config XML doesn't contain it, leading to errors when passing it through the current libvirt parsers. --- src/conf/interface_conf.c | 86 ++-- 1

Re: [libvirt] [PATCH] create() and destroy() support for Power Hypervisor

2009-10-28 Thread Daniel Veillard
On Mon, Oct 19, 2009 at 03:53:14PM -0200, Eduardo Otubo wrote: Mark McLoughlin wrote: On Tue, 2009-10-06 at 05:12 -0300, Eduardo Otubo wrote: I've been told that libvirt possibly would make a mini-release this week to push some major fixes on Fedora 12. F12 is frozen and there has been

Re: [libvirt] Re: [PATCH] Implement finer grained migration control for Xen

2009-10-28 Thread Daniel Veillard
On Sun, Oct 18, 2009 at 02:33:26AM +0200, Maximilian Wilhelm wrote: Anno domini 2009 Chris Lalancette scripsit: Attached you can find a patch implementing the same flags for Xen: * src/xen/xen_driver.c: Add support for VIR_MIGRATE_PERSIST_DEST flag * src/xen/xend_internal.c: Add

Re: [libvirt] [PATCH] create() and destroy() support for Power Hypervisor

2009-10-28 Thread Pasi Kärkkäinen
On Tue, Oct 06, 2009 at 09:15:19AM +0100, Mark McLoughlin wrote: On Tue, 2009-10-06 at 05:12 -0300, Eduardo Otubo wrote: I've been told that libvirt possibly would make a mini-release this week to push some major fixes on Fedora 12. F12 is frozen and there has been significant changes

Re: [libvirt] [PATCH] create() and destroy() support for Power Hypervisor

2009-10-28 Thread Mark McLoughlin
On Wed, 2009-10-28 at 10:48 +0200, Pasi Kärkkäinen wrote: On Tue, Oct 06, 2009 at 09:15:19AM +0100, Mark McLoughlin wrote: On Tue, 2009-10-06 at 05:12 -0300, Eduardo Otubo wrote: I've been told that libvirt possibly would make a mini-release this week to push some major fixes on Fedora

Re: [libvirt] [PATCH 1/3] Make startmode optional in toplevel interface definitions.

2009-10-28 Thread Daniel Veillard
On Fri, Oct 16, 2009 at 10:56:17AM -0400, la...@laine.org wrote: From: Laine Stump la...@laine.org The minimal XML returned from ncf_if_xml_state() doesn't contain this attribute (which makes no sense in the case of reporting current status of the interface), and it was preventing it from

Re: [libvirt] [PATCH] create() and destroy() support for Power Hypervisor

2009-10-28 Thread Pasi Kärkkäinen
On Wed, Oct 28, 2009 at 08:51:13AM +, Mark McLoughlin wrote: On Wed, 2009-10-28 at 10:48 +0200, Pasi Kärkkäinen wrote: On Tue, Oct 06, 2009 at 09:15:19AM +0100, Mark McLoughlin wrote: On Tue, 2009-10-06 at 05:12 -0300, Eduardo Otubo wrote: I've been told that libvirt possibly would

Re: [libvirt] [PATCH] create() and destroy() support for Power Hypervisor

2009-10-28 Thread Pasi Kärkkäinen
On Wed, Oct 28, 2009 at 11:27:35AM +0200, Pasi Kärkkäinen wrote: On Wed, Oct 28, 2009 at 08:51:13AM +, Mark McLoughlin wrote: On Wed, 2009-10-28 at 10:48 +0200, Pasi Kärkkäinen wrote: On Tue, Oct 06, 2009 at 09:15:19AM +0100, Mark McLoughlin wrote: On Tue, 2009-10-06 at 05:12 -0300,

Re: [libvirt] virsh: error: failed to disconnect from the hypervisor in F12/rawhide with Xen

2009-10-28 Thread Pasi Kärkkäinen
On Tue, Oct 27, 2009 at 06:07:09PM +0200, Pasi Kärkkäinen wrote: On Tue, Oct 27, 2009 at 10:04:45AM -0600, Jim Fehlig wrote: Pasi Kärkkäinen wrote: Hello, I have a testbox running current Fedora 12 (rawhide), with custom 2.6.31.4 Xen pv_ops dom0 kernel. [r...@f12test ~]# xm

Re: [libvirt] [PATCH 2/3] Support reporting live interface IP/netmask.

2009-10-28 Thread Daniel Veillard
On Fri, Oct 16, 2009 at 10:56:18AM -0400, la...@laine.org wrote: From: Laine Stump la...@laine.org This patch adds the flag VIR_INTERFACE_XML_INACTIVE to virInterfaceGetXMLDesc's flags. When it is*not* set (the default), the live interface info will be returned in the XML (in particular, the

Re: [libvirt] Trouble starting a QEMU guest with IPv6 VNC address

2009-10-28 Thread Daniel P. Berrange
On Tue, Oct 27, 2009 at 10:47:54AM -0700, Kaitlin Rupert wrote: It looks like specifying an address of [::1] instead of ::1 will work. However, that seems like a bug. The bracket syntax is specific to qemu, which means the user needs to have prior knowledge of this. Yes, that's a bug.

Re: [libvirt] [PATCH 1/2] Fix improper error return in virInterfaceDefParseProtoIPvX

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 03:25:43AM -0400, Laine Stump wrote: --- src/conf/interface_conf.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 7cb71ed..fc18eba 100644 ---

Re: [libvirt] [PATCH 3/3] (REVISED) Support for IPv6 / multiple addresses per interface in virInterface

2009-10-28 Thread Daniel Veillard
On Fri, Oct 23, 2009 at 01:31:19PM -0400, Laine Stump wrote: (How's this?) This patch updates the xml parsing and formatting, and the associated virInterfaceDef data structure to support IPv6, along the way adding support for multiple protocols per interface, and multiple IP addresses per

Re: [libvirt] udev node device backend

2009-10-28 Thread Chris Lalancette
Dave Allan wrote: Attached is a fully functional version of the node device udev based backend, incorporating all the feedback from earlier revisions. I broke the new capability fields out into a separate patch per Dan's suggestion, and I have also included a patch removing the DevKit

Re: [libvirt] [PATCH 3/3] (REVISED) Support for IPv6 / multiple addresses per interface in virInterface

2009-10-28 Thread Daniel Veillard
On Wed, Oct 28, 2009 at 12:06:24PM +0100, Daniel Veillard wrote: [...] But the main problem I faced when running the regression tests. I had installed netcf-0.1.3 and a number of thing just break with this patch. For example when libvirtd exits in the testing with corrupted config libvirtd

Re: [libvirt] [PATCH 3/3] (REVISED) Support for IPv6 / multiple addresses per interface in virInterface

2009-10-28 Thread Daniel Veillard
On Wed, Oct 28, 2009 at 02:25:38PM +0100, Daniel Veillard wrote: On Wed, Oct 28, 2009 at 12:06:24PM +0100, Daniel Veillard wrote: [...] But the main problem I faced when running the regression tests. I had installed netcf-0.1.3 and a number of thing just break with this patch. For example

Re: [libvirt] [PATCH 1/3] Rename internal APis

2009-10-28 Thread Daniel Veillard
On Wed, Oct 21, 2009 at 07:15:23PM +0100, Daniel P. Berrange wrote: --- src/conf/domain_conf.c |4 +- src/conf/domain_conf.h |2 +- src/conf/interface_conf.h |2 +- src/conf/network_conf.c |2 +- src/conf/network_conf.h |2 +- src/lxc/lxc_driver.c

Re: [libvirt] [PATCH] virterror: Add a missing 'break' for VIR_ERR_INVALID_SECRET

2009-10-28 Thread Chris Lalancette
Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- src/util/virterror.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/util/virterror.c b/src/util/virterror.c index 657cb3f..10f979c 100644 --- a/src/util/virterror.c +++

Re: [libvirt] [PATCH 2/3] New APIs for checking some object properties

2009-10-28 Thread Daniel Veillard
On Wed, Oct 21, 2009 at 07:15:24PM +0100, Daniel P. Berrange wrote: Introduce a number of new APIs to expose some boolean properties of objects, which cannot otherwise reliably determined, nor are aspects of the XML configuration. [...] +/** + * virStoragePoolIsPersistent: + * + *

Re: [libvirt] [PATCH 3/3] Implmentation of new APIs to checking state/persistence of objects

2009-10-28 Thread Daniel Veillard
On Wed, Oct 21, 2009 at 07:15:25PM +0100, Daniel P. Berrange wrote: This implements the virConnectIsSecure, virConnectIsEncrypted, virDomainIsPersistent, virDomainIsActive, virNetworkIsActive, virNetworkIsPersistent, virStoragePoolIsActive, virStoragePoolIsPersistent, virInterfaceIsActive APIs

Re: [libvirt] [PATCH] qemu: migrate: Don't require manual URI to specify a port

2009-10-28 Thread Chris Lalancette
Cole Robinson wrote: The xen driver will generate a migration port if only a hostname is passed in the optional migrate URI, so let's do the same in qemu. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c | 29 +++-- 1 files changed, 23

Re: [libvirt] [PATCH] qemu: migrate: Error if we collide with an inactive domain

2009-10-28 Thread Chris Lalancette
Cole Robinson wrote: Currently the check for a VM name/uuid collision on the migrate destination only errors for active domains. Not sure why this wouldn't apply for non running VMs as well, so drop the check. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c |

Re: [libvirt] [PATCH] qemu: migrate: Error if we collide with an inactive domain

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 03:12:45PM +0100, Chris Lalancette wrote: Cole Robinson wrote: Currently the check for a VM name/uuid collision on the migrate destination only errors for active domains. Not sure why this wouldn't apply for non running VMs as well, so drop the check.

Re: [libvirt] [PATCH 1/4] storage: Break out pool source parsing to a separate function.

2009-10-28 Thread Daniel Veillard
On Fri, Oct 16, 2009 at 12:35:11PM -0400, Cole Robinson wrote: We need to parse a source XML block for FindPoolSources, so this is a step in sharing the parsing. The new storage pool XML 2 XML tests cover this area pretty well to ensure we aren't causing regressions. Signed-off-by: Cole

Re: [libvirt] [PATCH 2/4] storage: Break out function to add pool source to a SourceList.

2009-10-28 Thread Daniel Veillard
On Fri, Oct 16, 2009 at 12:35:12PM -0400, Cole Robinson wrote: Similar in theory to *AssignDef type functions, this duplicate functionality will be used by an future FindPoolSources implementations. Signed-off-by: Cole Robinson crobi...@redhat.com ACK, looks fine ! Daniel -- Daniel

Re: [libvirt] [PATCH] Fix p2p migration without a passed uri.

2009-10-28 Thread Chris Lalancette
Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- src/libvirt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 926c539..126675e 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -3217,7 +3217,7 @@

Re: [libvirt] [PATCH] qemu: Fix an error message in GetVcpus

2009-10-28 Thread Chris Lalancette
Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 082cb04..a3beedb 100644 --- a/src/qemu/qemu_driver.c +++

Re: [libvirt] [PATCH 3/4] storage: Add ParseSourceString function for use with FindPoolSources.

2009-10-28 Thread Daniel Veillard
On Fri, Oct 16, 2009 at 12:35:13PM -0400, Cole Robinson wrote: This will simplify adding FindPoolSources support to more pool backends in the future (as well as the test driver). Signed-off-by: Cole Robinson crobi...@redhat.com ACK, this looks right and similar to other parsing functions

Re: [libvirt] [PATCH 4/4] test: Support virStorageFindPoolSources

2009-10-28 Thread Daniel Veillard
On Fri, Oct 16, 2009 at 12:35:14PM -0400, Cole Robinson wrote: The results are hardcoded into the test driver, no option to read from a testfile is implemented at this time. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/test/test_driver.c | 75

Re: [libvirt] [PATCH] Improve error reporting for virConnectGetHostname calls

2009-10-28 Thread Chris Lalancette
Cole Robinson wrote: All drivers have copy + pasted inadequate error reporting which wraps util.c:virGetHostname. Move all error reporting to this function, and improve what we report. Overall, a good idea, I think. A few nits below. diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index

Re: [libvirt] [PATCH] network utilities

2009-10-28 Thread Daniel Veillard
On Thu, Oct 22, 2009 at 04:42:20PM -0400, Laine Stump wrote: +/* + * Helpers to extract the IP arrays from the virSocketAddrPtr + * That part is the less portable of the module + */ +typedef unsigned char virIPv4Addr[4]; +typedef virIPv4Addr *virIPv4AddrPtr; +typedef unsigned short

Re: [libvirt] [PATCH] Improve error reporting for virConnectGetHostname calls

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 03:32:32PM +0100, Chris Lalancette wrote: Cole Robinson wrote: static int umlListDomains(virConnectPtr conn, int *ids, int nids) { diff --git a/src/util/util.c b/src/util/util.c index 98f8a14..49eac6d 100644 --- a/src/util/util.c +++ b/src/util/util.c @@

Re: [libvirt] [PATCH] Improve error reporting for virConnectGetHostname calls

2009-10-28 Thread Cole Robinson
On 10/28/2009 10:44 AM, Daniel P. Berrange wrote: On Wed, Oct 28, 2009 at 03:32:32PM +0100, Chris Lalancette wrote: Cole Robinson wrote: static int umlListDomains(virConnectPtr conn, int *ids, int nids) { diff --git a/src/util/util.c b/src/util/util.c index 98f8a14..49eac6d 100644 ---

Re: [libvirt] [PATCH] add bootp server=...

2009-10-28 Thread Daniel Veillard
On Thu, Oct 22, 2009 at 06:20:32PM +0200, Paolo Bonzini wrote: This patch adds an optional attribute to the bootp tag, that allows to specify a TFTP server address other than the address of the DHCP server itself. This can be used to forward the BOOTP settings of the host down to the guest.

Re: [libvirt] [PATCH] network utilities

2009-10-28 Thread Laine Stump
On 10/28/2009 10:35 AM, Daniel Veillard wrote: On Thu, Oct 22, 2009 at 04:42:20PM -0400, Laine Stump wrote: +/* + * Helpers to extract the IP arrays from the virSocketAddrPtr + * That part is the less portable of the module + */ +typedef unsigned char virIPv4Addr[4]; +typedef virIPv4Addr

Re: [libvirt] [PATCH] Better error message when libvirtd fails to start.

2009-10-28 Thread Daniel Veillard
On Fri, Oct 23, 2009 at 01:01:34PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- daemon/libvirtd.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 78dfb2d..03bc1b4 100644 ---

Re: [libvirt] [PATCH] Update the documentation for virDomainMigrateToURI

2009-10-28 Thread Daniel Veillard
On Fri, Oct 23, 2009 at 01:01:40PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/libvirt.c | 41 ++--- 1 files changed, 22 insertions(+), 19 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index

Re: [libvirt] [PATCH] Update the documentation for virDomainMigrateToURI

2009-10-28 Thread Chris Lalancette
Daniel Veillard wrote: On Fri, Oct 23, 2009 at 01:01:40PM +0200, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/libvirt.c | 41 ++--- 1 files changed, 22 insertions(+), 19 deletions(-) diff --git a/src/libvirt.c

Re: [libvirt] [PATCH 4/4] test: Support virStorageFindPoolSources

2009-10-28 Thread Cole Robinson
On 10/28/2009 10:29 AM, Daniel Veillard wrote: On Fri, Oct 16, 2009 at 12:35:14PM -0400, Cole Robinson wrote: The results are hardcoded into the test driver, no option to read from a testfile is implemented at this time. Signed-off-by: Cole Robinson crobi...@redhat.com ---

Re: [libvirt] [PATCH] qemu: migrate: Don't require manual URI to specify a port

2009-10-28 Thread Cole Robinson
On 10/28/2009 10:09 AM, Chris Lalancette wrote: Cole Robinson wrote: The xen driver will generate a migration port if only a hostname is passed in the optional migrate URI, so let's do the same in qemu. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c | 29

Re: [libvirt] [PATCH] virterror: Add a missing 'break' for VIR_ERR_INVALID_SECRET

2009-10-28 Thread Cole Robinson
On 10/28/2009 09:34 AM, Chris Lalancette wrote: Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- src/util/virterror.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/util/virterror.c b/src/util/virterror.c index 657cb3f..10f979c 100644

Re: [libvirt] [PATCH] Fix p2p migration without a passed uri.

2009-10-28 Thread Cole Robinson
On 10/28/2009 10:26 AM, Chris Lalancette wrote: Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- src/libvirt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 926c539..126675e 100644 --- a/src/libvirt.c

Re: [libvirt] [PATCH] qemu: Fix an error message in GetVcpus

2009-10-28 Thread Cole Robinson
On 10/28/2009 10:26 AM, Chris Lalancette wrote: Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 082cb04..a3beedb

Re: [libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

2009-10-28 Thread Guido Günther
Hi Daniel, On Fri, Oct 23, 2009 at 02:05:39PM +0100, Daniel P. Berrange wrote: The daemonizing code lets the parent exit almost immediately. This means that it may think it has successfully started even when important failures occur like not being able to acquire the PID file. It also means

Re: [libvirt] [PATCH 00/21] Rewrite the QEMU monitor handling

2009-10-28 Thread Daniel Veillard
On Fri, Oct 23, 2009 at 02:05:29PM +0100, Daniel P. Berrange wrote: This patch series rewrites the QEMU monitor handling almost completely. The key theme here is to move from a totally synchronous way of interacting with the monitor, to a totally asynchronous way. This allows us to handle

Re: [libvirt] [PATCH 00/21] Rewrite the QEMU monitor handling

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 05:03:55PM +0100, Daniel Veillard wrote: On Fri, Oct 23, 2009 at 02:05:29PM +0100, Daniel P. Berrange wrote: This patch series rewrites the QEMU monitor handling almost completely. The key theme here is to move from a totally synchronous way of interacting with

Re: [libvirt] [PATCH 01/21] Convert virDomainObjListPtr to use a hash of domain objects

2009-10-28 Thread Daniel Veillard
On Fri, Oct 23, 2009 at 02:05:30PM +0100, Daniel P. Berrange wrote: The current virDomainObjListPtr object stores domain objects in an array. This means that to find a particular objects requires O(n) time, and more critically acquiring O(n) mutex locks. The new impl replaces the array with

Re: [libvirt] [PATCH 02/21] Implement a RWLock primitive for drivers to use

2009-10-28 Thread Daniel Veillard
On Fri, Oct 23, 2009 at 02:05:31PM +0100, Daniel P. Berrange wrote: This implements a thin wrapper around the pthread_rwlock primitives. No impl is provided for Win32 at this time since it is rather hard, and none of our code yet requires it on Win32 * src/util/threads.h: Add virRWLockInit,

Re: [libvirt] [PATCH] create() and destroy() support for Power Hypervisor

2009-10-28 Thread Eduardo Otubo
Daniel Veillard wrote: On Mon, Oct 19, 2009 at 03:53:14PM -0200, Eduardo Otubo wrote: Mark McLoughlin wrote: On Tue, 2009-10-06 at 05:12 -0300, Eduardo Otubo wrote: I've been told that libvirt possibly would make a mini-release this week to push some major fixes on Fedora 12. F12 is frozen

Re: [libvirt] [PATCH 03/21] Convert QEMU driver mutex into a rwlock

2009-10-28 Thread Daniel Veillard
On Fri, Oct 23, 2009 at 02:05:32PM +0100, Daniel P. Berrange wrote: A number of driver API methods which acquire the driver mutex only ever used the driver object in a read-only fashion. All these uses are converted to call qemuDriverLockRO() allowing for greater concurrency. *

Re: [libvirt] [PATCH 04/21] Allow for a driver specific private data blob in virDomainObjPtr

2009-10-28 Thread Daniel Veillard
On Fri, Oct 23, 2009 at 02:05:33PM +0100, Daniel P. Berrange wrote: The virDomainObjPtr object stores state about a running domain. This object is shared across all drivers so it is not appropriate to include driver specific state here. This patch adds the ability to request a blob of private

Re: [libvirt] [PATCH 05/21] Annotate many methods with ATTRIBUTE_RETURN_CHECK fix problems

2009-10-28 Thread Daniel Veillard
On Fri, Oct 23, 2009 at 02:05:34PM +0100, Daniel P. Berrange wrote: Nearly all of the methods in src/util/util.h have error codes that must be checked by the caller to correct detect report failure. Add ATTRIBUTE_RETURN_CHECK to ensure compile time validation of this * daemon/libvirtd.c:

[libvirt] [PATCH] libvirt-devel should only require libvirt-client

2009-10-28 Thread Mark McLoughlin
There's a long known issue where if you install libvirt in a guest, the default virtual network will conflict with the default virtual network in the host. That's one of the reasons we have the libvirt-client RPM - it allows you to install the client library without having the host side

[libvirt] QEMU driver thread safety rules

2009-10-28 Thread Daniel P. Berrange
The current QEMU driver makes use of 2 locks - The driver lock - The virDomainObjPtr lock The idea is the driver lock is not held for long periods of time. Unfortunately we don't always deal with this very well - some code needs todo quite alot with the driver - particularly starting and

Re: [libvirt] [PATCH 03/21] Convert QEMU driver mutex into a rwlock

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 05:24:00PM +0100, Daniel Veillard wrote: On Fri, Oct 23, 2009 at 02:05:32PM +0100, Daniel P. Berrange wrote: A number of driver API methods which acquire the driver mutex only ever used the driver object in a read-only fashion. All these uses are converted to call

Re: [libvirt] [PATCH 02/21] Implement a RWLock primitive for drivers to use

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 05:15:05PM +0100, Daniel Veillard wrote: On Fri, Oct 23, 2009 at 02:05:31PM +0100, Daniel P. Berrange wrote: This implements a thin wrapper around the pthread_rwlock primitives. No impl is provided for Win32 at this time since it is rather hard, and none of our code

Re: [libvirt] QEMU driver thread safety rules

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 05:49:15PM +, Daniel P. Berrange wrote: Helper methods -- To lock the driver qemuDriverLock() - Acquires the driver lock qemuDriverUnlock() - Releases the driver lock To lock the virDomainObjPtr virDomainObjLock() -

Re: [libvirt] [PATCH] libvirt-devel should only require libvirt-client

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 05:28:58PM +, Mark McLoughlin wrote: There's a long known issue where if you install libvirt in a guest, the default virtual network will conflict with the default virtual network in the host. That's one of the reasons we have the libvirt-client RPM - it allows

Re: [libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 03:22:38PM +0100, Guido G?nther wrote: Hi Daniel, On Fri, Oct 23, 2009 at 02:05:39PM +0100, Daniel P. Berrange wrote: The daemonizing code lets the parent exit almost immediately. This means that it may think it has successfully started even when important failures

Re: [libvirt] udev node device backend

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 12:16:40PM +0100, Chris Lalancette wrote: Dave Allan wrote: Attached is a fully functional version of the node device udev based backend, incorporating all the feedback from earlier revisions. I broke the new capability fields out into a separate patch per Dan's

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-28 Thread Daniel P. Berrange
On Sun, Oct 25, 2009 at 10:54:19PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at 05:15:26PM +0200, Dan Kenigsberg wrote: Just stumpbled on another issue: On Tue, Sep 29, 2009 at 04:43:50PM +0100, Daniel P. Berrange wrote: @@ -366,6 +367,13 @@ struct _virDomainGraphicsDef {

[libvirt] [PATCH] ESX: Fallback to the preliminary name if the datastore cannot be found.

2009-10-28 Thread Matthias Bolte
This allows to use domain-xml-from-native with VMX files that reference unavailable datastores. * src/esx/esx_vmx.c: fallback to the preliminary name if the datastore cannot be found --- src/esx/esx_vmx.c | 43 +++ 1 files changed, 23 insertions(+), 20

[libvirt] [PATCH] ESX: Change disk selection for datastore detection.

2009-10-28 Thread Matthias Bolte
In order to register a new virtual machine the ESX driver needs to upload a VMX file to a datastore. Try to put this file beside the main VMDK file of the virtual machine. Change the disk selection for datastore detection to choose the first file-based harddisk instead of just the first disk. The

[libvirt] [PATCH] ESX: Unify naming of VI API utility and convenience functions.

2009-10-28 Thread Matthias Bolte
Unified function naming scheme: - 'lookup' functions query the ESX or vCenter for information - 'get' functions return information from a local object * src/esx/esx_driver.c, src/esx/esx_vi.[ch]: unify function naming --- src/esx/esx_driver.c | 95

[libvirt] [PATCH] ESX: Don't automatically follow redirects.

2009-10-28 Thread Matthias Bolte
The default transport for the VI API is HTTPS. If the server redirects from HTTPS to HTTP the driver would silently follow that redirection. The user assumes to communicate with the server over a secure transport but isn't. This patch disables automatical redirection following. The driver reports

[libvirt] [PATCH] ESX: Fix memory leak in list handling functions.

2009-10-28 Thread Matthias Bolte
If an error occurs between the allocation of an item and appending it to the list, the item leaks. Free such orphaned items in error cases. * src/esx/esx_vi.c: free orphaned items in error cases --- src/esx/esx_vi.c | 24 1 files changed, 8 insertions(+), 16

Re: [libvirt] udev node device backend

2009-10-28 Thread Dave Allan
Daniel P. Berrange wrote: On Wed, Oct 28, 2009 at 12:16:40PM +0100, Chris Lalancette wrote: Dave Allan wrote: Attached is a fully functional version of the node device udev based backend, incorporating all the feedback from earlier revisions. I broke the new capability fields out into a

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-28 Thread Dan Kenigsberg
On Wed, Oct 28, 2009 at 07:57:05PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at 10:54:19PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at 05:15:26PM +0200, Dan Kenigsberg wrote: Just stumpbled on another issue: On Tue, Sep 29, 2009 at 04:43:50PM +0100, Daniel P.

Re: [libvirt] Application using libvirt crashes when having concurrent TLS connections (gnutls problem)

2009-10-28 Thread Thomas Treutner
On Friday 09 October 2009 19:38:34 Bryan Kearney wrote: The Java bindings should now be pretty light weight. Are you seeing this in them? If so, spin up a bug and I will take a look. It took me quite some time to get to the bottom of this, as I'm not a professional full time dev. From what I

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-28 Thread Hugh O. Brock
On Wed, Oct 28, 2009 at 10:53:48PM +0200, Dan Kenigsberg wrote: On Wed, Oct 28, 2009 at 07:57:05PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at 10:54:19PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at 05:15:26PM +0200, Dan Kenigsberg wrote: Just stumpbled on

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-28 Thread Dan Kenigsberg
On Wed, Oct 28, 2009 at 05:01:48PM -0400, Hugh O. Brock wrote: On Wed, Oct 28, 2009 at 10:53:48PM +0200, Dan Kenigsberg wrote: On Wed, Oct 28, 2009 at 07:57:05PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at 10:54:19PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at

Re: [libvirt] [PATCH] ESX: Fix memory leak in list handling functions.

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 09:12:57PM +0100, Matthias Bolte wrote: If an error occurs between the allocation of an item and appending it to the list, the item leaks. Free such orphaned items in error cases. * src/esx/esx_vi.c: free orphaned items in error cases --- src/esx/esx_vi.c | 24

Re: [libvirt] [PATCH] ESX: Don't automatically follow redirects.

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 09:12:06PM +0100, Matthias Bolte wrote: The default transport for the VI API is HTTPS. If the server redirects from HTTPS to HTTP the driver would silently follow that redirection. The user assumes to communicate with the server over a secure transport but isn't. Good

Re: [libvirt] [PATCH] ESX: Unify naming of VI API utility and convenience functions.

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 09:10:11PM +0100, Matthias Bolte wrote: Unified function naming scheme: - 'lookup' functions query the ESX or vCenter for information - 'get' functions return information from a local object * src/esx/esx_driver.c, src/esx/esx_vi.[ch]: unify function naming ---

Re: [libvirt] [PATCH] ESX: Change disk selection for datastore detection.

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 09:08:56PM +0100, Matthias Bolte wrote: In order to register a new virtual machine the ESX driver needs to upload a VMX file to a datastore. Try to put this file beside the main VMDK file of the virtual machine. Change the disk selection for datastore detection to

Re: [libvirt] [PATCH] ESX: Fallback to the preliminary name if the datastore cannot be found.

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 09:07:55PM +0100, Matthias Bolte wrote: This allows to use domain-xml-from-native with VMX files that reference unavailable datastores. * src/esx/esx_vmx.c: fallback to the preliminary name if the datastore cannot be found --- src/esx/esx_vmx.c | 43

Re: [libvirt] Application using libvirt crashes when having concurrent TLS connections (gnutls problem)

2009-10-28 Thread Bryan Kearney
On 10/28/2009 05:00 PM, Thomas Treutner wrote: On Friday 09 October 2009 19:38:34 Bryan Kearney wrote: The Java bindings should now be pretty light weight. Are you seeing this in them? If so, spin up a bug and I will take a look. It took me quite some time to get to the bottom of this, as I'm

Re: [libvirt] Application using libvirt crashes when having concurrent TLS connections (gnutls problem)

2009-10-28 Thread Bryan Kearney
On 10/28/2009 08:18 PM, Bryan Kearney wrote: On 10/28/2009 05:00 PM, Thomas Treutner wrote: On Friday 09 October 2009 19:38:34 Bryan Kearney wrote: Let me work on a patch and send it to you. Ok.. patch is attached. You can see a test build at:

Re: [libvirt] [PATCH] ESX: Don't automatically follow redirects.

2009-10-28 Thread Matthias Bolte
2009/10/28 Daniel P. Berrange berra...@redhat.com: On Wed, Oct 28, 2009 at 09:12:06PM +0100, Matthias Bolte wrote: The default transport for the VI API is HTTPS. If the server redirects from HTTPS to HTTP the driver would silently follow that redirection. The user assumes to communicate with

Re: [libvirt] [PATCH] ESX: Change disk selection for datastore detection.

2009-10-28 Thread Matthias Bolte
2009/10/28 Daniel P. Berrange berra...@redhat.com: On Wed, Oct 28, 2009 at 09:08:56PM +0100, Matthias Bolte wrote: In order to register a new virtual machine the ESX driver needs to upload a VMX file to a datastore. Try to put this file beside the main VMDK file of the virtual machine. Change