Re: [libvirt] [PATCH] (v2) avoid chowning domain devices if higer-level mgmt does it for us

2009-11-25 Thread Daniel Veillard
On Wed, Nov 25, 2009 at 09:27:13AM +0200, Dan Kenigsberg wrote: this is particularily important if said device is a file sitting on a root_squashing nfs export. my previous attempt for a patch missed 3 chowns that should be avoided. --- src/qemu/qemu.conf |4

[libvirt] Re: libvir: QEMU error : remoteDomainProcessEvent: unmarshalling msg

2009-11-25 Thread Daniel P. Berrange
On Wed, Nov 25, 2009 at 10:59:27AM +0800, ajia wrote: Hi all, I create successfully a vm, then opening one terminal to run example event-python.py from libvirt-0.7.4 source code package with qemu:///system parameter.in another opening terminal,running basic domain operation, such as

Re: [libvirt] [PATCH] remove ebtables rules at qemud shutdown

2009-11-25 Thread Daniel P. Berrange
On Tue, Nov 24, 2009 at 10:42:13AM +0100, Gerhard Stenzel wrote: This patch removes ebtables rules at qemud shutdown time Signed-off-by: Gerhard Stenzel gerhard.sten...@de.ibm.com This is not desirable. Our expectation is that everything remains active unchanged when libvirtd shuts down.

Re: [libvirt] crash in libvirtd when assigning PCI device (storage controller)

2009-11-25 Thread Daniel P. Berrange
On Mon, Nov 23, 2009 at 10:08:17PM +, Terje Marthinussen wrote: [ 987.286791] libvirtd[3193]: segfault at 10 ip 7f921b4546b4 sp 7f9216e165e0 error 4 in libpthread-2.10.1.so[7f921b44a000+17000] Ok, so this is the libvirtd daemon crash From GDB 06:45:32.434: error :

Re: [libvirt] [PATCH] Put libraries in $LIBS, not $LDFLAGS, during configure tests.

2009-11-25 Thread Daniel P. Berrange
On Mon, Nov 23, 2009 at 09:28:24PM +, Nix wrote: If libraries go in $LDFLAGS while AC_CHECK_LIBbing, they'll end up in front of the object file name, which rarely works well. They belong in $LIBS. What platforms / scenarios show this problem ? Empirically it has been working fine on our

Re: [libvirt] [PATCH] Add test for legacy console ... tty= syntax

2009-11-25 Thread Daniel P. Berrange
On Mon, Nov 23, 2009 at 01:48:30PM +, Matthew Booth wrote: * tests/qemuxml2argvtest.c: Test legacy syntax for QEMU argument generation * tests/qemuxml2argvdata/qemuxml2argv-console-legacy.(xml|args): Add test data This test doesn't seem to test anything we're not already testing ? Daniel

Re: [libvirt] [PATCH 1/3] Make QEMU driver use -chardev everywhere when it's available

2009-11-25 Thread Daniel P. Berrange
On Mon, Nov 23, 2009 at 12:30:27PM +, Matthew Booth wrote: Change -monitor, -serial and -parallel output to use -chardev if it is available. * src/qemu/qemu_conf.c: Update qemudBuildCommandLine to use -chardev where available. * tests/qemuxml2argvtest.c tests/qemuxml2argvdata/: Add

Re: [libvirt] [PATCH 2/3] Extract the assigned pty device for channels

2009-11-25 Thread Daniel P. Berrange
On Mon, Nov 23, 2009 at 12:30:28PM +, Matthew Booth wrote: * src/qemu/qemu_driver.c: Parse pty devices for channels --- src/qemu/qemu_driver.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

Re: [libvirt] [PATCH] Add test for legacy console ... tty= syntax

2009-11-25 Thread Matthew Booth
On 25/11/09 11:25, Daniel P. Berrange wrote: On Mon, Nov 23, 2009 at 01:48:30PM +, Matthew Booth wrote: * tests/qemuxml2argvtest.c: Test legacy syntax for QEMU argument generation * tests/qemuxml2argvdata/qemuxml2argv-console-legacy.(xml|args): Add test data This test doesn't seem to test

Re: [libvirt] [PATCH 3/3] Get QEMU pty paths from the monitor

2009-11-25 Thread Daniel P. Berrange
On Mon, Nov 23, 2009 at 12:30:29PM +, Matthew Booth wrote: This change makes the QEMU driver get pty paths from the output of the monitor 'info chardev' command. This output is structured, and contains both the name of the device and the path on the same line. This is considerably more

Re: [libvirt] [PATCH] Add test for legacy console ... tty= syntax

2009-11-25 Thread Daniel P. Berrange
On Wed, Nov 25, 2009 at 11:27:48AM +, Matthew Booth wrote: On 25/11/09 11:25, Daniel P. Berrange wrote: On Mon, Nov 23, 2009 at 01:48:30PM +, Matthew Booth wrote: * tests/qemuxml2argvtest.c: Test legacy syntax for QEMU argument generation *

Re: [libvirt] [PATCH] (v2) avoid chowning domain devices if higer-level mgmt does it for us

2009-11-25 Thread Dan Kenigsberg
On Wed, Nov 25, 2009 at 10:31:03AM +0100, Daniel Veillard wrote: On Wed, Nov 25, 2009 at 09:27:13AM +0200, Dan Kenigsberg wrote: this is particularily important if said device is a file sitting on a root_squashing nfs export. my previous attempt for a patch missed 3 chowns that should be

Re: [libvirt] [PATCH] (v2) avoid chowning domain devices if higer-level mgmt does it for us

2009-11-25 Thread Daniel P. Berrange
On Wed, Nov 25, 2009 at 01:38:52PM +0200, Dan Kenigsberg wrote: On Wed, Nov 25, 2009 at 10:31:03AM +0100, Daniel Veillard wrote: On Wed, Nov 25, 2009 at 09:27:13AM +0200, Dan Kenigsberg wrote: this is particularily important if said device is a file sitting on a root_squashing nfs export.

[libvirt] [PATCH] Fix threading problems in python bindings

2009-11-25 Thread Daniel P. Berrange
* libvirt-override.c: Add many missing calls to allow threading when entering C code, otherwise python blocks then deadlocks when we have an async event to dispatch back into python code --- python/libvirt-override.c | 106 1 files changed, 96

Re: [libvirt] [PATCH] Fix threading problems in python bindings

2009-11-25 Thread Matthias Bolte
2009/11/25 Daniel P. Berrange berra...@redhat.com: * libvirt-override.c: Add many missing calls to allow threading  when entering C code, otherwise python blocks then deadlocks  when we have an async event to dispatch back into python code ---  python/libvirt-override.c |  106

Re: [libvirt] [PATCH] (v2) avoid chowning domain devices if higer-level mgmt does it for us

2009-11-25 Thread Hugh O. Brock
On Wed, Nov 25, 2009 at 11:49:32AM +, Daniel P. Berrange wrote: On Wed, Nov 25, 2009 at 01:38:52PM +0200, Dan Kenigsberg wrote: On Wed, Nov 25, 2009 at 10:31:03AM +0100, Daniel Veillard wrote: On Wed, Nov 25, 2009 at 09:27:13AM +0200, Dan Kenigsberg wrote: this is particularily

Re: [libvirt] [PATCH] Fix threading problems in python bindings

2009-11-25 Thread Daniel Veillard
On Wed, Nov 25, 2009 at 12:06:03PM +, Daniel P. Berrange wrote: * libvirt-override.c: Add many missing calls to allow threading when entering C code, otherwise python blocks then deadlocks when we have an async event to dispatch back into python code --- python/libvirt-override.c |

Re: [libvirt] crash in libvirtd when assigning PCI device (storage controller)

2009-11-25 Thread Daniel P. Berrange
On Wed, Nov 25, 2009 at 11:23:07AM +, Daniel P. Berrange wrote: On Mon, Nov 23, 2009 at 10:08:17PM +, Terje Marthinussen wrote: [ 987.286791] libvirtd[3193]: segfault at 10 ip 7f921b4546b4 sp 7f9216e165e0 error 4 in libpthread-2.10.1.so[7f921b44a000+17000] Ok, so this is

[libvirt] [PATCH 0/3] fix migration of paused vms

2009-11-25 Thread Paolo Bonzini
From: Paolo Bonzini pbonz...@gnu.org This is yet another try on fixing migration of paused vms. Since the driver-only solution didn't work out, I'm now fixing it directly in libvirt.c. The first two patches are the same as for the previous series. The first is a bugfix for failed migration for

[libvirt] [PATCH 1/3] fix migration of paused vms upon failure

2009-11-25 Thread Paolo Bonzini
This makes a small change on the failed-migration path. Up to now, all VMs that failed non-live migration after the stop command were restarted. This must not be done when the VM was paused in the first place. * src/qemu/qemu_driver.c (qemudDomainMigratePerform): Do not restart a paused VM that

[libvirt] [PATCH 2/3] add virsh --suspend

2009-11-25 Thread Paolo Bonzini
This adds a new flag, VIR_MIGRATE_PAUSED, that mandates pausing the migrated VM before starting it. * include/libvirt/libvirt.h.in (virDomainMigrateFlags): Add VIR_MIGRATE_PAUSED. * src/qemu/qemu_driver.c (qemudDomainMigrateFinish2): Handle VIR_MIGRATE_PAUSED. * tools/virsh.c (opts_migrate): Add

[libvirt] [PATCH 3/3] retrieve paused/running state at the beginning of migration

2009-11-25 Thread Paolo Bonzini
This patch fixes the bug where paused/running state is not transmitted during migration. As a result, in the QEMU driver for example the machine was always started on the destination end. In order to do so, I just read the state and if it is appropriate I set the VIR_MIGRATE_PAUSED flag. *

[libvirt] [PATCH 4/3] [RFC] pass paused/running state at the end of the migration

2009-11-25 Thread Paolo Bonzini
This patch would fix the case where paused/running state is changed during live migration. In order to do so, libvirt attaches an event handler that tracks the paused/running state on the source side. Then, based on the state _just before_ the end of the migration, it can stick a

[libvirt] How do I import an old VM image to a new Install

2009-11-25 Thread Michael N. Moran
First, I am a casual VM user. I have been using Fedora Core 7 on my Dell laptop for a couple of years with a single QEMU/KVM guest running Windoze XP. I recently installed Fedora 12 on a new hard disk and would like to use my old Windows VM image on the new install. Is there an easy way to do

Re: [libvirt] How do I import an old VM image to a new Install

2009-11-25 Thread Cole Robinson
On 11/25/2009 11:36 AM, Michael N. Moran wrote: First, I am a casual VM user. I have been using Fedora Core 7 on my Dell laptop for a couple of years with a single QEMU/KVM guest running Windoze XP. I recently installed Fedora 12 on a new hard disk and would like to use my old Windows VM

Re: [libvirt] How do I import an old VM image to a new Install

2009-11-25 Thread Michael N. Moran
On 11/25/2009 12:53 PM, Cole Robinson wrote: On 11/25/2009 11:36 AM, Michael N. Moran wrote: First, I am a casual VM user. I have been using Fedora Core 7 on my Dell laptop for a couple of years with a single QEMU/KVM guest running Windoze XP. I recently installed Fedora 12 on a new hard disk

Re: [libvirt] How do I import an old VM image to a new Install

2009-11-25 Thread Cole Robinson
On 11/25/2009 01:27 PM, Michael N. Moran wrote: On 11/25/2009 12:53 PM, Cole Robinson wrote: On 11/25/2009 11:36 AM, Michael N. Moran wrote: First, I am a casual VM user. I have been using Fedora Core 7 on my Dell laptop for a couple of years with a single QEMU/KVM guest running Windoze XP.

Re: [libvirt] [PATCH] Put libraries in $LIBS, not $LDFLAGS, during configure tests.

2009-11-25 Thread Nix
On 25 Nov 2009, Daniel P. Berrange spake thusly: On Mon, Nov 23, 2009 at 09:28:24PM +, Nix wrote: If libraries go in $LDFLAGS while AC_CHECK_LIBbing, they'll end up in front of the object file name, which rarely works well. They belong in $LIBS. What platforms / scenarios show this