Re: [libvirt] [PATCH] nwfilter: fix for directionality of ICMP traffic

2010-04-08 Thread Daniel Veillard
On Wed, Apr 07, 2010 at 11:44:01AM -0400, Stefan Berger wrote: This patch enables the skipping of some of the ICMP traffic rules on the iptables level under certain circumstances so that the following filter properly enables unidirectional pings: filter name='testcase'

Re: [libvirt] [PATCH v2] nwfilter: fix for directionality of ICMP traffic

2010-04-08 Thread Daniel Veillard
On Wed, Apr 07, 2010 at 05:44:53PM -0400, Stefan Berger wrote: Changes from V1 to V2 of this patch - I had reversed the logic thinking that icmp type 0 is a echo request,but it's reply -- needed to reverse the logic - Found that ebtables takes the --ip-tos argument only as a hex number This

Re: [libvirt] [PATCH v2]

2010-04-08 Thread Daniel Veillard
On Wed, Apr 07, 2010 at 05:34:50PM -0400, Stefan Berger wrote: This patch adds new test cases to the existing nwfilter test program and adds a test script that must be run while a VM is running. This test script verifies that input network filter XML creates expected user-defined tables and

Re: [libvirt] [PATCH] nwfilters: Test suite for checking created firewall entries

2010-04-08 Thread Daniel P. Berrange
On Wed, Apr 07, 2010 at 02:53:28PM -0400, Stefan Berger wrote: This patch adds new test cases to the existing nwfilter test program and adds a test script that must be run while a VM is running. This test script verifies that input network filter XML creates expected user-defined tables and

Re: [libvirt] [PATCH] Fix Win32 portability problems

2010-04-08 Thread Daniel P. Berrange
On Wed, Apr 07, 2010 at 12:12:10PM -0600, Eric Blake wrote: +#ifdef WIN32 +int +virHookCall(int driver ATTRIBUTE_UNUSED, +const char *id ATTRIBUTE_UNUSED, +int op ATTRIBUTE_UNUSED, +int sub_op ATTRIBUTE_UNUSED, +const char *extra

Re: [libvirt] [PATCH v2]

2010-04-08 Thread Stefan Berger
Daniel Veillard veill...@redhat.com wrote on 04/08/2010 03:54:07 AM: Please respond to veillard On Wed, Apr 07, 2010 at 05:34:50PM -0400, Stefan Berger wrote: This patch adds new test cases to the existing nwfilter test program and adds a test script that must be run while a VM is

Re: [libvirt] [PATCH v2]

2010-04-08 Thread Gerhard Stenzel
On Thu, 2010-04-08 at 07:16 -0400, Stefan Berger wrote: Ok, I'll adapt it for the TCK project. Some time ago, I started with some libvirt-tck scripts - 210-no-mac-spoofing.t - 220-no-ip-spoofing.t - 230-no-mac-broadcast.t - 240-no-arp-spoofing.t which try to perform an action (like mac

[libvirt] FYI: [PATCH] Fix unterminated B... in virsh man page

2010-04-08 Thread Jiri Denemark
FYI, I've just pushed the following trivial fix: From 7ea025aed0ff110bd7b5ab2037e04aa3205f2c13 Mon Sep 17 00:00:00 2001 Message-Id: 7ea025aed0ff110bd7b5ab2037e04aa3205f2c13.1270731158.git.jdene...@redhat.com From: Jiri Denemark jdene...@redhat.com Date: Thu, 8 Apr 2010 14:44:48 +0200 Subject:

Re: [libvirt] FYI: [PATCH] Fix unterminated B... in virsh man page

2010-04-08 Thread Eric Blake
On 04/08/2010 06:54 AM, Jiri Denemark wrote: FYI, I've just pushed the following trivial fix: Returns basic information about the domain. -=item Bdomjobabort Idomain-id-or-uuid +=item Bdomjobabort Idomain-id-or-uuid Thanks. Looks like I flubbed that one. -- Eric Blake

Re: [libvirt] [PATCH v2]

2010-04-08 Thread Daniel P. Berrange
On Thu, Apr 08, 2010 at 02:48:35PM +0200, Gerhard Stenzel wrote: On Thu, 2010-04-08 at 07:16 -0400, Stefan Berger wrote: Ok, I'll adapt it for the TCK project. Some time ago, I started with some libvirt-tck scripts - 210-no-mac-spoofing.t - 220-no-ip-spoofing.t - 230-no-mac-broadcast.t

Re: [libvirt] [PATCH v2]

2010-04-08 Thread Stefan Berger
Gerhard Stenzel gsten...@linux.vnet.ibm.com wrote on 04/08/2010 08:48:35 AM: On Thu, 2010-04-08 at 07:16 -0400, Stefan Berger wrote: Ok, I'll adapt it for the TCK project. Some time ago, I started with some libvirt-tck scripts - 210-no-mac-spoofing.t - 220-no-ip-spoofing.t -

Re: [libvirt] [PATCH v2]

2010-04-08 Thread Gerhard Stenzel
On Thu, 2010-04-08 at 14:07 +0100, Daniel P. Berrange wrote: So I think what we'd want todo is to write a kickstart file that installs a bare minimum Fedora guest OS, with a pre-set root password, ssh daemon active known IP address. Then use that with Rich Jones' febootstrap script to

Re: [libvirt] Problems accessing ESX using libvirt

2010-04-08 Thread Matthias Bolte
2010/4/8 Matthew Booth mbo...@redhat.com: I was forwarded the following query relating to v2v: === There are no firewalls between the hosts and the ESX firewall is configured to allow all incoming outgoing connections. The virsh -c 'esx://elabhost011.xxx/' list --all command also fails in

Re: [libvirt] Problems accessing ESX using libvirt

2010-04-08 Thread Matthew Booth
On 08/04/10 16:37, Matthias Bolte wrote: ESX support was added in libvirt 0.7.0. So libvirt 0.6.3 is too old. Libvirt will give unexpected error messages when you give it URIs that no driver handles. For example if no local driver claims to handle an URI the remote driver will try to connect

Re: [libvirt] [PATCH 06/15] Generate libvirt.def from libvirt.syms

2010-04-08 Thread Matthias Bolte
2010/4/7 Daniel P. Berrange berra...@redhat.com: On Mon, Mar 22, 2010 at 02:25:36AM +0100, Matthias Bolte wrote: The MinGW linker needs the libvirt.def file. ---  configure.ac    |    5 +  src/.gitignore  |    1 +  src/Makefile.am |   15 +++  3 files changed, 17

Re: [libvirt] [PATCH 07/15] virsh: Handle absence of SA_SIGINFO

2010-04-08 Thread Matthias Bolte
2010/4/7 Daniel P. Berrange berra...@redhat.com: On Mon, Mar 22, 2010 at 02:25:37AM +0100, Matthias Bolte wrote: MinGW and gnulib don't provide SA_SIGINFO on Windows. ---  tools/virsh.c |    4  1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c

Re: [libvirt] [PATCH] esx: Add domain snapshot support

2010-04-08 Thread Matthias Bolte
2010/4/7 Daniel Veillard veill...@redhat.com: On Wed, Apr 07, 2010 at 12:00:01PM +0200, Matthias Bolte wrote: Fix invalid code generating in esx_vi_generator.py regarding deep copy types that contain enum properties. Add strptime and timegm to bootstrap.conf. Both are used to convert a

[libvirt] [PATCH 0/1] enospace disk error policy

2010-04-08 Thread David Allan
Dan Kenigsberg requested that we add an option to explicitly request enospace as the disk error policy. David Allan (1): Add enospace option to qemu disk error policy docs/schemas/domain.rng|1 + src/conf/domain_conf.c |3 +-

[libvirt] [PATCH 1/1] Add enospace option to qemu disk error policy

2010-04-08 Thread David Allan
* Dan Kenigsberg requested explicit support for the qemu default disk error policy which is enospace --- docs/schemas/domain.rng|1 + src/conf/domain_conf.c |3 +- src/conf/domain_conf.h |1 +

[libvirt] [PATCH] Remove undefined symbols from symbols file

2010-04-08 Thread Matthias Bolte
--- src/libvirt_private.syms |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 814e2d8..b76f2da 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -209,7 +209,6 @@

Re: [libvirt] [PATCH 1/1] Add enospace option to qemu disk error policy

2010-04-08 Thread Daniel Veillard
On Thu, Apr 08, 2010 at 04:11:33PM -0400, David Allan wrote: * Dan Kenigsberg requested explicit support for the qemu default disk error policy which is enospace --- docs/schemas/domain.rng|1 + src/conf/domain_conf.c |3 +-

Re: [libvirt] [PATCH] Remove undefined symbols from symbols file

2010-04-08 Thread Daniel Veillard
On Thu, Apr 08, 2010 at 10:16:42PM +0200, Matthias Bolte wrote: --- src/libvirt_private.syms |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 814e2d8..b76f2da 100644 -#nwfilter_learnipaddr.h

Re: [libvirt] [PATCH] Remove undefined symbols from symbols file

2010-04-08 Thread Matthias Bolte
2010/4/8 Daniel Veillard veill...@redhat.com: On Thu, Apr 08, 2010 at 10:16:42PM +0200, Matthias Bolte wrote: ---  src/libvirt_private.syms |    7 +--  1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index

Re: [libvirt] [RFC] Unify KVM kernel-space and user-space code into a single project

2010-04-08 Thread Antoine Martin
Hi, I am moving this thread here as this seems more appropriate. Sorry it has taken so long.. Here are 2 things that really get in the way of moving my existing installations to libvirt: * I tend to store much meta data with each VM instance: it can be things like ownership (contact details as

Re: [libvirt] [PATCH 17/30] remote: Remove virConnectPtr from error/errorf

2010-04-08 Thread Matthias Bolte
2010/4/5 Eric Blake ebl...@redhat.com: On 04/04/2010 11:36 AM, Matthias Bolte wrote: Also unify error/errorf to remoteError and update cfg.mk accordingly. +++ b/src/remote/remote_driver.c @@ -239,11 +239,9 @@ static int remoteAuthSASL (virConnectPtr conn, struct private_data *priv, int in  

Re: [libvirt] [PATCH 28/30] remote: Replace some virRaiseError with remoteError

2010-04-08 Thread Matthias Bolte
2010/4/5 Eric Blake ebl...@redhat.com: On 04/04/2010 11:36 AM, Matthias Bolte wrote: ---  src/remote/remote_driver.c |   29 -  1 files changed, 12 insertions(+), 17 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index

[libvirt] [PATCH] nwfilter: More XML parser test cases

2010-04-08 Thread Stefan Berger
This patch adds a couple more nwfilter test cases for the XML parser tests. Signed-off-by: Stefan Berger stef...@us.ibm.com Index: libvirt-acl/tests/nwfilterxml2xmlin/ipt-no-macspoof-test.xml === --- /dev/null +++

[libvirt] Domain not stable while created...

2010-04-08 Thread Sankamesh
Hello, I am using Scientific Linux 5.4 and xen. I want to deploy a sample ttyimage by creating a domain using virsh create. My configuration file is : - ?xml version=1.0 encoding=utf-8? domain