Re: [libvirt] (Resend with updates) Live Migration with non-shared storage for kvm

2010-05-05 Thread Kenneth Nagin
Ph: +972-4-8296227 Cell: 054-6976227 Fx: +972-4- 8296113 Do not look back in anger, or forward in fear, but around in awareness. --James Thurber Eric Blake ebl...@redhat.com wrote on 05/05/2010 01:04:23: From: Eric Blake ebl...@redhat.com To: Cole Robinson crobi...@redhat.com Cc: Kenneth

Re: [libvirt] (Resend with updates) Live Migration with non-shared storage for kvm

2010-05-05 Thread Daniel P. Berrange
On Mon, May 03, 2010 at 09:52:10AM -0400, Cole Robinson wrote: On 05/03/2010 04:13 AM, Kenneth Nagin wrote: ... This the patch file: (See attached file: libvirt_migration_ns_100503.patch) ACK, patch looks fine now. No objections to the patch that was committed, but FYI there

Re: [libvirt] Alternative to XML Creation and Parsing?

2010-05-05 Thread Daniel P. Berrange
On Mon, May 03, 2010 at 10:23:11PM +0530, Ganesh Pagade wrote: Hello, We plan to develop a fancy GUI which would help creating and managing VMs/Domains for RHEL 5.4 KVM. However looking at the schemas provided in docs/schemas/ (Ex: domain.rng) generating the XML file from the inputs

[libvirt] [PATCH] rpmbuild: add ebtables ip(6)tables dependency for rpm

2010-05-05 Thread Stefan Berger
Add ebtables,iptables iptables-ipv6 dependency to rpm. Signed-off-by: Stefan Berger stef...@us.ibm.com --- libvirt.spec.in |7 +++ 1 file changed, 7 insertions(+) Index: libvirt-acl/libvirt.spec.in === ---

[libvirt] libvirt with qemu-kvm, not recognizing NIC model

2010-05-05 Thread Jonathan Hoover
Is this the right list for this question, or should I be elsewhere? I am trying to specify a network card model type of pcnet (to emulate vmware esxi's network card). No matter what I put for model type in my xml config file, it comes up as an Intel e1000. I ran qemu-kvm -net nic,model=?

[libvirt] [PATCH v2 2/2] Implement SCSI disk unplugging

2010-05-05 Thread Wolfgang Mauerer
With the introduction of the generic qemu device model, unplugging SCSI disks works like a charm, so support it in libvirt. * src/qemu/qemu_driver.c: Add qemudDomainDetachSCSIDiskDevice() to do the unplugging, extend qemudDomainDetachDeviceAdd(). Signed-off-by: Wolfgang Mauerer

Re: [libvirt] [PATCH] Fix SCSI disk unplugging

2010-05-05 Thread Wolfgang Mauerer
Daniel P. Berrange wrote: On Tue, May 04, 2010 at 05:18:24PM +0200, Wolfgang Mauerer wrote: Detaching disk devices is not only possible for VIR_DOMAIN_DISK_BUS_VIRTIO, but also for VIR_DOMAIN_DISK_BUS_SCSI, so take care of this possibility. Additionally, when the new-style device syntax is

[libvirt] [PATCH v2 1/2] Refactor disk unplugging

2010-05-05 Thread Wolfgang Mauerer
We can reuse some of the code for other purposes. Signed-off-by: Wolfgang Mauerer wolfgang.maue...@siemens.com --- src/qemu/qemu_driver.c | 56 ++- 1 files changed, 36 insertions(+), 20 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 6/5] build: simplify checks for sched.h

2010-05-05 Thread Eric Blake
* configure.ac: Remove redundant checks. --- Noticed this simplification after sending my series. configure.ac | 34 ++ 1 files changed, 10 insertions(+), 24 deletions(-) diff --git a/configure.ac b/configure.ac index c643c56..c187420 100644 --- a/configure.ac

Re: [libvirt] (Resend with updates) Live Migration with non-shared storage for kvm

2010-05-05 Thread Eric Blake
On 05/05/2010 12:26 AM, Kenneth Nagin wrote: Eric Blake ebl...@redhat.com wrote on 05/05/2010 01:04:23: [feel free to trim content unrelated to your reply, it makes it easier to get to your comments] Then I verified that it passes 'make check' and 'make syntax-check', and finally pushed

Re: [libvirt] [PATCH] rpmbuild: add ebtables ip(6)tables dependency for rpm

2010-05-05 Thread Eric Blake
On 05/05/2010 05:24 AM, Stefan Berger wrote: Add ebtables,iptables iptables-ipv6 dependency to rpm. Signed-off-by: Stefan Berger stef...@us.ibm.com ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description:

Re: [libvirt] [PATCH] rpmbuild: add ebtables ip(6)tables dependency for rpm

2010-05-05 Thread Daniel P. Berrange
On Wed, May 05, 2010 at 07:24:29AM -0400, Stefan Berger wrote: Add ebtables,iptables iptables-ipv6 dependency to rpm. Signed-off-by: Stefan Berger stef...@us.ibm.com --- libvirt.spec.in |7 +++ 1 file changed, 7 insertions(+) Index: libvirt-acl/libvirt.spec.in

Re: [libvirt] libvirt with qemu-kvm, not recognizing NIC model

2010-05-05 Thread Chris Lalancette
On 05/04/2010 12:46 PM, Jonathan Hoover wrote: Is this the right list for this question, or should I be elsewhere? I am trying to specify a network card “model type” of “pcnet” (to emulate vmware esxi’s network card). No matter what I put for model type in my xml config file, it comes

Re: [libvirt] libvirt with qemu-kvm, not recognizing NIC model

2010-05-05 Thread Jonathan Hoover
Sorry, it turned out to be the operating system of the guest OS having the issue. It was not an issue with libvirt. My bad, Jon -Original Message- From: Chris Lalancette [mailto:clala...@redhat.com] Sent: Wednesday, May 05, 2010 10:34 AM To: Jonathan Hoover Cc: libvirt-l...@redhat.com

Re: [libvirt] [PATCH] rpmbuild: add ebtables ip(6)tables dependency for rpm

2010-05-05 Thread Stefan Berger
Daniel P. Berrange berra...@redhat.com wrote on 05/05/2010 11:33:15 AM: Also need to wire up the %{with_nwfilter} arg to the %configure call eg, %if ! %{with_nwfilter} %define _without_nwfilter --without-nwfilter %endif %configure \ ...snip...

[libvirt] [PATCH v2] rpmbuild: add ebtables ip(6)tables dependency for rpm

2010-05-05 Thread Stefan Berger
Add ebtables,iptables iptables-ipv6 dependency to rpm. Changes from V1 to V2: -passing --without-libpcap to configure script, if libpcap is not to be used Signed-off-by: Stefan Berger stef...@us.ibm.com --- libvirt.spec.in |7 +++ 1 file changed, 7 insertions(+) Index:

Re: [libvirt] [PATCH v2] rpmbuild: add ebtables ip(6)tables dependency for rpm

2010-05-05 Thread Stefan Berger
Daniel P. Berrange berra...@redhat.com wrote on 05/05/2010 12:03:15 PM: [...] %configure %{?_without_xen} \ %{?_without_qemu} \ %{?_without_openvz} \ @@ -545,6 +556,7 @@ of recent versions of Linux (and other O %{?_without_hal} \

[libvirt] [PATCH] build: silence a clang false positive

2010-05-05 Thread Eric Blake
* src/qemu/qemu_monitor.c (qemuMonitorIOWriteWithFD): Work around recent clang shortcoming in analysis. --- False positive encountered with the latest F-13 clang :( src/qemu/qemu_monitor.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_monitor.c

Re: [libvirt] [PATCH 6/5] build: simplify checks for sched.h

2010-05-05 Thread Jim Meyering
Eric Blake wrote: * configure.ac: Remove redundant checks. Noticed this simplification after sending my series. configure.ac | 34 ++ 1 files changed, 10 insertions(+), 24 deletions(-) Nice. ACK. -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Eric Blake
I was getting failures of domain/103-blockdev-save-restore.t when connecting as qemu:///session, since my uid could stat /dev/sdb but not open it. That test now skips for unprivileged users, as well as adds a layer of sanity checking against expected size to avoid trashing the wrong device. *

Re: [libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Dave Allan
On Wed, May 05, 2010 at 08:54:35PM +0200, Jim Meyering wrote: Eric Blake wrote: I was getting failures of domain/103-blockdev-save-restore.t when connecting as qemu:///session, since my uid could stat /dev/sdb but not open it. That test now skips for unprivileged users, as well as adds a

Re: [libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Jim Meyering
Dave Allan wrote: On Wed, May 05, 2010 at 08:54:35PM +0200, Jim Meyering wrote: Eric Blake wrote: I was getting failures of domain/103-blockdev-save-restore.t when connecting as qemu:///session, since my uid could stat /dev/sdb but not open it. That test now skips for unprivileged users,

Re: [libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Jim Meyering
Dave Allan wrote: On Wed, May 05, 2010 at 08:54:35PM +0200, Jim Meyering wrote: Eric Blake wrote: I was getting failures of domain/103-blockdev-save-restore.t when connecting as qemu:///session, since my uid could stat /dev/sdb but not open it. That test now skips for unprivileged users,

[libvirt] [PATCH] cgroup: Change virCgroupRemove to remove all child groups at first

2010-05-05 Thread Ryota Ozaki
As same as normal directories, a cgroup cannot be removed if it contains sub groups. This patch changes virCgroupRemove to remove all child groups (subdirectories) of a target group before removing the target group. The handling is required when we run lxc with ns subsystem of cgroup. Ns

Re: [libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Eric Blake
On 05/05/2010 01:31 PM, Jim Meyering wrote: Can we provide the option to specify the device serial number so that it's really impossible to trash the wrong device? Given that this is a good idea, next question is obviously how to get the serial number. One way seems to be via hdparm, e.g.,

Re: [libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Eric Blake
On 05/05/2010 12:54 PM, Jim Meyering wrote: +if (!defined $device) { +$device = $self-config(host_block_devices/[$devindex], undef); +} This can be equivalently (idiomatically) written as: $device ||= $self-config(host_block_devices/[$devindex], undef); Thanks for the

Re: [libvirt] [PATCH] build: silence a clang false positive

2010-05-05 Thread Jim Meyering
Eric Blake wrote: * src/qemu/qemu_monitor.c (qemuMonitorIOWriteWithFD): Work around recent clang shortcoming in analysis. ... diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c ... cmsg = CMSG_FIRSTHDR(msg); +/* Some static analyzers, like clang 2.6-0.6.pre2, fail to see

Re: [libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Jim Meyering
Eric Blake wrote: On 05/05/2010 12:54 PM, Jim Meyering wrote: +if (!defined $device) { + $device = $self-config(host_block_devices/[$devindex], undef); +} This can be equivalently (idiomatically) written as: $device ||= $self-config(host_block_devices/[$devindex], undef);

Re: [libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Jim Paris
Eric Blake wrote: On 05/05/2010 01:31 PM, Jim Meyering wrote: Can we provide the option to specify the device serial number so that it's really impossible to trash the wrong device? Given that this is a good idea, next question is obviously how to get the serial number. One way seems

Re: [libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Eric Blake
On 05/05/2010 02:21 PM, Jim Paris wrote: Great for SCSI, not so great for USB sticks: # hdparm -i /dev/sdb /dev/sdb: HDIO_DRIVE_CMD(identify) failed: Invalid exchange HDIO_GET_IDENTITY failed: Invalid argument # echo $? 22 Using a device path in /dev/disk/by-id/ would make more sense

[libvirt] [TCK PATCHv2] block devices: allow specification of size for safety

2010-05-05 Thread Eric Blake
I was getting failures of domain/103-blockdev-save-restore.t when connecting as qemu:///session, since my uid could stat /dev/sdb but not open it. That test now skips for unprivileged users, as well as adds a layer of sanity checking against expected size to avoid trashing the wrong device. *

Re: [libvirt] [PATCH] build: silence a clang false positive

2010-05-05 Thread Eric Blake
On 05/05/2010 01:59 PM, Jim Meyering wrote: Eric Blake wrote: * src/qemu/qemu_monitor.c (qemuMonitorIOWriteWithFD): Work around recent clang shortcoming in analysis. ... diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c ... cmsg = CMSG_FIRSTHDR(msg); +/* Some static

Re: [libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Dave Allan
On Wed, May 05, 2010 at 01:56:20PM -0600, Eric Blake wrote: On 05/05/2010 01:31 PM, Jim Meyering wrote: Can we provide the option to specify the device serial number so that it's really impossible to trash the wrong device? Given that this is a good idea, next question is obviously how

Re: [libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Eric Blake
On 05/05/2010 02:48 PM, Dave Allan wrote: Great for SCSI, not so great for USB sticks: # hdparm -i /dev/sdb What does the following give you? scsi_id --whitelisted --replace-whitespace --device=/dev/sdb # scsi_id --whitelisted --replace-whitespace --device=/dev/sdb # echo $? 1 Not a

Re: [libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Dave Allan
On Wed, May 05, 2010 at 02:49:44PM -0600, Eric Blake wrote: On 05/05/2010 02:48 PM, Dave Allan wrote: Great for SCSI, not so great for USB sticks: # hdparm -i /dev/sdb What does the following give you? scsi_id --whitelisted --replace-whitespace --device=/dev/sdb # scsi_id

[libvirt] [TCK PATCHv3] block devices: allow specification of size for safety

2010-05-05 Thread Eric Blake
I was getting failures of domain/103-blockdev-save-restore.t when connecting as qemu:///session, since my uid could stat /dev/sdb but not open it. That test now skips for unprivileged users, as well as adds a layer of sanity checking against expected size to avoid trashing the wrong device. *