Re: [libvirt] [PATCH] Remove dead code after refactoring qemudDomainStart

2010-05-24 Thread Jiri Denemark
The event is already generated and sent by qemudDomainObjStart, no need to do anything about here. ACK Thanks, pushed now. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [v2 PATCH] add 802.1Qbh handling for port-profiles based on Stefan's previous patches

2010-05-24 Thread Scott Feldman
From: Scott Feldman scofe...@cisco.com This patch builds on the work recently posted by Stefan Berger. It builds on top of Stefan's two posted patches: [PATCH v8] vepa: parsing for 802.1Qb{g|h} XML [RFC][PATCH 1/3] vepa+vsi: Introduce dependency on libnl Stefan's patches 2/3

[libvirt] Question about the libvirt Java bindings

2010-05-24 Thread Dustin Xiong
Dear all: I encounter a problem when I running the libvirt java bindings test program. I download the libvirt-java-0.4.3.tar.gz. Then compiled successful, but the test program can't running. # ant build Buildfile: build.xml init: [copy] Copying 1 file to /home/dustin/libvirt-java-0.4.3

Re: [libvirt] [RFC PATCH v2] qemu: Add suport for pci-assign.configfd option

2010-05-24 Thread Daniel P. Berrange
On Thu, May 20, 2010 at 10:02:10AM -0400, Alex Williamson wrote: This allows libvirt to open the PCI device sysfs config file prior to dropping privileges so qemu can access the full config space. Without this, a de-privileged qemu can only access the first 64 bytes of config space.

Re: [libvirt] [V2 PATCH] V2 port-profile ID support using new IFLA_VF_PORTS netlink msg

2010-05-24 Thread Daniel P. Berrange
On Thu, May 20, 2010 at 04:52:44PM -0400, Stefan Berger wrote: Scott Feldman scofe...@cisco.com wrote on 05/20/2010 03:22:12 PM: Next steps for V3, etc: 1) merge with Stefan's latest patch, as much as possible Yes. Try to make it a patch on top of my V5 patch... 2) assign VM

Re: [libvirt] [PATCH 3/3] storage: Check for invalid storage mode before opening

2010-05-24 Thread Daniel P. Berrange
On Thu, May 20, 2010 at 04:25:54PM -0600, Eric Blake wrote: On 05/20/2010 01:23 PM, Cole Robinson wrote: If a directory pool contains pipes or sockets, a pool start can fail or hang: https://bugzilla.redhat.com/show_bug.cgi?id=589577 We already try to avoid these special files, but

Re: [libvirt] [PATCH] network: bridge: Don't start network if it collides with host routing

2010-05-24 Thread Daniel P. Berrange
On Fri, May 21, 2010 at 11:21:34AM -0600, Eric Blake wrote: On 05/21/2010 09:28 AM, Cole Robinson wrote: Any interest in doing this with netlink instead? (I've got this thing against parsing text files to get information if it can be retrieved via a nice clean API). If so, I think I can

Re: [libvirt] [RFC] [PATCH 3/3 v2] vepa+vsi: Some experimental code for 802.1Qbh

2010-05-24 Thread Daniel P. Berrange
On Sat, May 22, 2010 at 02:34:33PM -0400, Dave Allan wrote: On Sat, May 22, 2010 at 11:14:20AM -0400, Stefan Berger wrote: On Fri, 2010-05-21 at 23:35 -0700, Scott Feldman wrote: On 5/21/10 6:50 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote: This patch may get 802.1Qbh devices

Re: [libvirt] [PATCH v2] storage: Check for invalid storage mode before opening

2010-05-24 Thread Daniel P. Berrange
On Fri, May 21, 2010 at 02:24:24PM -0400, Cole Robinson wrote: On 05/21/2010 02:17 PM, Eric Blake wrote: On 05/21/2010 11:03 AM, Cole Robinson wrote: If a directory pool contains pipes or sockets, a pool start can fail or hang: https://bugzilla.redhat.com/show_bug.cgi?id=589577 We

Re: [libvirt] [PATCH 00/10] Add support for SPICE graphics in QEMU

2010-05-24 Thread Daniel P. Berrange
On Mon, May 24, 2010 at 12:18:57PM +0800, Bitman Zhou wrote: Hi, I want to test your SPICE patch. Where can I get it? Thanks a lot. Best bet if you want to test SPICE bits, is to pull from my personal staging tree which hsa the SPICE bits from RHEL6

Re: [libvirt] [PATCH] network: bridge: Don't start network if it collides with host routing

2010-05-24 Thread Neil Wilson
You need to be very careful not to hit a valid use case here. RFC3069 provides for a mechanism whereby a supernet/subnet system is setup to allow better use of available IPv4 address space. This is becoming of increasing concern as IPv4 space exhausts. To implement this you turn on Proxy ARP on

Re: [libvirt] [PATCH] network: bridge: Don't start network if it collides with host routing

2010-05-24 Thread Daniel P. Berrange
On Mon, May 24, 2010 at 12:52:40PM +0100, Neil Wilson wrote: You need to be very careful not to hit a valid use case here. RFC3069 provides for a mechanism whereby a supernet/subnet system is setup to allow better use of available IPv4 address space. This is becoming of increasing concern as

Re: [libvirt] [PATCH] network: bridge: Don't start network if it collides with host routing

2010-05-24 Thread Neil Wilson
On 24 May 2010 13:00, Daniel P. Berrange berra...@redhat.com wrote: The current network code only supports NAT, or a separate routed subnet thus currently require a non-clashing subnet. Proxy ARP is a future RFE, so not a problem wrt this patchset currently. So you shouldn't attempt to use

Re: [libvirt] Question about the libvirt Java bindings

2010-05-24 Thread Bryan Kearney
On 05/24/2010 05:18 AM, Dustin Xiong wrote: Dear all: I encounter a problem when I running the libvirt java bindings test program. I download the libvirt-java-0.4.3.tar.gz. Then compiled successful, but the test program can't running. # ant build Buildfile: build.xml init: [copy]

Re: [libvirt] [PATCH] network: bridge: Don't start network if it collides with host routing

2010-05-24 Thread Daniel P. Berrange
On Mon, May 24, 2010 at 01:08:05PM +0100, Neil Wilson wrote: On 24 May 2010 13:00, Daniel P. Berrange berra...@redhat.com wrote: The current network code only supports NAT, or a separate routed subnet thus currently require a non-clashing subnet. Proxy ARP is a future RFE, so not a

[libvirt] [RFC] [PATCH 1/3 v3] vepa+vsi: Introduce dependency on libnl

2010-05-24 Thread Stefan Berger
This patch introduces a dependency on libnl, which subsequent patches will then use. Changes from V2 to V3: - Added requirement for libnl during runtime (Requires: libnl) Changes from V1 to V2: - added diffstats - following changes in tree Signed-off-by: Stefan Berger stef...@us.ibm.com ---

[libvirt] [PATCH] Add host UUID (to libvirt capabilities)

2010-05-24 Thread Stefan Berger
This patch adds the host UUID (to the capabilities of libvirt). The user may provide it in libvirtd.conf overriding whatever dmidecode may return. If none or no valid UUID is provided in libvirtd.conf, dmidecode is being used. If that function doesn't provide a valid (not all digits may be equal),

Re: [libvirt] [PATCH] Add host UUID (to libvirt capabilities)

2010-05-24 Thread Daniel P. Berrange
On Mon, May 24, 2010 at 08:55:33AM -0400, Stefan Berger wrote: Index: libvirt-acl/daemon/libvirtd.c === --- libvirt-acl.orig/daemon/libvirtd.c +++ libvirt-acl/daemon/libvirtd.c @@ -2718,6 +2718,7 @@ remoteReadConfigFile (struct

[libvirt] [PATCH v2] Add host UUID (to libvirt capabilities)

2010-05-24 Thread Stefan Berger
This patch adds the host UUID (to the capabilities of libvirt). The user may provide it in libvirtd.conf overriding whatever sysfs may return. If none or no valid UUID is provided in libvirtd.conf, reading the UUID from sysfs is attempted. If that function doesn't provide a valid (not all digits

[libvirt] [PATCH] [DOCS] nwfilter: documentation

2010-05-24 Thread Stefan Berger
This patch adds documentation of the nwfilter subsystem of libvirt to the existing (web) docs. Previous post with attached PDF of the docs is probably stuck in the mail filter of this list. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- docs/formatnwfilter.html.in | 1407

Re: [libvirt] [PATCH] qemu: Allow using regular audio backends with VNC

2010-05-24 Thread Daniel P. Berrange
On Thu, May 20, 2010 at 12:04:04PM -0400, Cole Robinson wrote: Currently all host audio backends are disabled if a VM is using VNC, in favor of the QEMU VNC audio extension. Unfortunately no released VNC client supports this extension, so users have no way of getting audio to work if using

Re: [libvirt] [PATCH] qemu: Allow using regular audio backends with VNC

2010-05-24 Thread Cole Robinson
On 05/24/2010 10:14 AM, Daniel P. Berrange wrote: On Thu, May 20, 2010 at 12:04:04PM -0400, Cole Robinson wrote: Currently all host audio backends are disabled if a VM is using VNC, in favor of the QEMU VNC audio extension. Unfortunately no released VNC client supports this extension, so users

Re: [libvirt] [PATCH] qemu: Allow using regular audio backends with VNC

2010-05-24 Thread Daniel P. Berrange
On Mon, May 24, 2010 at 10:26:43AM -0400, Cole Robinson wrote: On 05/24/2010 10:14 AM, Daniel P. Berrange wrote: On Thu, May 20, 2010 at 12:04:04PM -0400, Cole Robinson wrote: Currently all host audio backends are disabled if a VM is using VNC, in favor of the QEMU VNC audio extension.

Re: [libvirt] [v2 PATCH] add 802.1Qbh handling for port-profiles based on Stefan's previous patches

2010-05-24 Thread Laine Stump
Scott, I got build errors (with upstream source, haven't tried RHEL yet) trying to build with the latest versions of Stefan's two patches plus yours. In the first case it looks like it's caused by IFLA_VF_PORT_MAX not being #defined (vf is not referenced inside that part of the #if). In the

Re: [libvirt] [PATCH] qemu: Allow using regular audio backends with VNC

2010-05-24 Thread Cole Robinson
On 05/24/2010 10:31 AM, Daniel P. Berrange wrote: On Mon, May 24, 2010 at 10:26:43AM -0400, Cole Robinson wrote: On 05/24/2010 10:14 AM, Daniel P. Berrange wrote: On Thu, May 20, 2010 at 12:04:04PM -0400, Cole Robinson wrote: Currently all host audio backends are disabled if a VM is using VNC,

Re: [libvirt] [PATCH v2] storage: mpath: Clean up some error handling

2010-05-24 Thread Cole Robinson
On 05/21/2010 03:34 PM, Eric Blake wrote: On 05/21/2010 11:05 AM, Cole Robinson wrote: We were squashing error messages in a few cases. Recode to follow common ret = -1 convention. v2: Handle more error squashing issues further up in MakeNewVol and CreateVols. Use ret = -1 convention in

Re: [libvirt] [PATCH v2] storage: Combine some duplicate code

2010-05-24 Thread Cole Robinson
On 05/21/2010 03:35 PM, Eric Blake wrote: On 05/21/2010 11:05 AM, Cole Robinson wrote: Volume detection in the scsi backend was duplicating code already present in storage_backend.c. Let's drop the duplicate code. Also, change the shared function name to be less generic, and remove some

[libvirt] LIbvirt Java Bindings 0.4.5 Released

2010-05-24 Thread Bryan Kearney
I have just released 0.4.5 of the libvirt java bindings. This release rings the supported libvirt API up to 0.8.1. You can access the latest version via the following means: Source Code: http://www.libvirt.org/git/?p=libvirt-java.git;a=summary Bundled Source (tarball and SRPM):

Re: [libvirt] [PATCH] qemu: Allow using regular audio backends with VNC

2010-05-24 Thread Daniel P. Berrange
On Mon, May 24, 2010 at 10:56:39AM -0400, Cole Robinson wrote: On 05/24/2010 10:31 AM, Daniel P. Berrange wrote: On Mon, May 24, 2010 at 10:26:43AM -0400, Cole Robinson wrote: On 05/24/2010 10:14 AM, Daniel P. Berrange wrote: On Thu, May 20, 2010 at 12:04:04PM -0400, Cole Robinson wrote:

Re: [libvirt] [PATCH] build: fix cppi warnings

2010-05-24 Thread Jim Fehlig
Eric Blake wrote: * src/util/bitmap.h (includes): Placate cppi. --- Pushing as obvious, to keep 'make syntax-check' happy. src/util/bitmap.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Thanks Eric. I didn't have cppi installed and missed this. Rectifying that now

[libvirt] [PATCH] Correct two memory leaks triggered by udev events

2010-05-24 Thread Nigel Jones
Hi List, Please find below a patch that should correct two memory leaks within the udev device handling code. The issue is triggered by 'add' udev calls and will slowly cause libvirtd to consume the majority of system memory. The first part of the patch deals with udevAddOneDevice() and frees

Re: [libvirt] [PATCH] Correct two memory leaks triggered by udev events

2010-05-24 Thread Chris Lalancette
On 05/24/2010 12:10 PM, Nigel Jones wrote: From 6c8183e83fbfeb031b16cf9ae2d41b16e3145378 Mon Sep 17 00:00:00 2001 From: Nigel Jones d...@nigelj.com Date: Mon, 24 May 2010 15:05:53 + Subject: [PATCH] Patch 2 memory leaks. 1. Ensure that memory is free'd from udevAddOneDevice() if the

Re: [libvirt] [PATCH v2] Add host UUID (to libvirt capabilities)

2010-05-24 Thread Scott Feldman
Thanks Stefan! Using/testing this now. I'm hitting this on make check: TEST: capabilityschematest 12 FAILED FAIL: capabilityschematest -scott On 5/24/10 6:56 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote: This patch adds the host UUID

Re: [libvirt] [PATCH v2] Add host UUID (to libvirt capabilities)

2010-05-24 Thread Daniel P. Berrange
On Mon, May 24, 2010 at 09:56:22AM -0400, Stefan Berger wrote: This patch adds the host UUID (to the capabilities of libvirt). The user may provide it in libvirtd.conf overriding whatever sysfs may return. If none or no valid UUID is provided in libvirtd.conf, reading the UUID from sysfs is

Re: [libvirt] [PATCH v2] Add host UUID (to libvirt capabilities)

2010-05-24 Thread Stefan Berger
On Mon, 2010-05-24 at 09:48 -0700, Scott Feldman wrote: Thanks Stefan! Using/testing this now. I'm hitting this on make check: TEST: capabilityschematest 12 FAILED FAIL: capabilityschematest Oops. Yes, so I'll add the UUID to the test

Re: [libvirt] [PATCH v8] vepa: parsing for 802.1Qb{g|h} XML

2010-05-24 Thread Daniel P. Berrange
On Sun, May 23, 2010 at 12:51:50PM -0400, Stefan Berger wrote: Index: libvirt-acl/src/util/macvtap.h === --- libvirt-acl.orig/src/util/macvtap.h +++ libvirt-acl/src/util/macvtap.h @@ -27,15 +27,14 @@ # if defined(WITH_MACVTAP)

Re: [libvirt] [PATCH v2] Add host UUID (to libvirt capabilities)

2010-05-24 Thread Eric Blake
On 05/24/2010 07:56 AM, Stefan Berger wrote: This patch adds the host UUID (to the capabilities of libvirt). The user may provide it in libvirtd.conf overriding whatever sysfs may return. If none or no valid UUID is provided in libvirtd.conf, reading the UUID from sysfs is attempted. If that

[libvirt] [PATCH 0/2] Device assignment hotplug fixes

2010-05-24 Thread Alex Williamson
These add a couple fixes for device assignment hotplug --- Alex Williamson (2): qemu: Release bus address on PCI host device remove qemu: avoid corrupting guest info struct on host device PCI hot add src/qemu/qemu_driver.c | 23 +++ 1 files changed, 15

[libvirt] [PATCH 1/2] qemu: avoid corrupting guest info struct on host device PCI hot add

2010-05-24 Thread Alex Williamson
The device path doesn't make use of guestAddr, so the memcpy corrupts the guest info struct. Signed-off-by: Alex Williamson alex.william...@redhat.com --- src/qemu/qemu_driver.c | 19 +++ 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [RFC PATCH v3] qemu: Add suport for pci-assign.configfd option

2010-05-24 Thread Alex Williamson
This allows libvirt to open the PCI device sysfs config file prior to dropping privileges so qemu can access the full config space. Without this, a de-privileged qemu can only access the first 64 bytes of config space. Signed-off-by: Alex Williamson alex.william...@redhat.com --- Note: this is

[libvirt] [PATCH 2/2] qemu: Release bus address on PCI host device remove

2010-05-24 Thread Alex Williamson
Signed-off-by: Alex Williamson alex.william...@redhat.com --- src/qemu/qemu_driver.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 32ce835..afdc718 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c

Re: [libvirt] [v2 PATCH] add 802.1Qbh handling for port-profiles based on Stefan's previous patches

2010-05-24 Thread Daniel P. Berrange
On Mon, May 24, 2010 at 12:07:06AM -0700, Scott Feldman wrote: +static int +nlCommWaitSuccess(struct nlmsghdr *nlmsg, int nl_groups, + char **respbuf, int *respbuflen, long to_usecs) +{ +int rc = 0; +struct sockaddr_nl nladdr = { +.nl_family =

Re: [libvirt] [PATCH 1/2] qemu: avoid corrupting guest info struct on host device PCI hot add

2010-05-24 Thread Daniel P. Berrange
On Mon, May 24, 2010 at 01:33:27PM -0400, Alex Williamson wrote: The device path doesn't make use of guestAddr, so the memcpy corrupts the guest info struct. Signed-off-by: Alex Williamson alex.william...@redhat.com --- src/qemu/qemu_driver.c | 19 +++ 1 files changed,

Re: [libvirt] [RFC PATCH v3] qemu: Add suport for pci-assign.configfd option

2010-05-24 Thread Daniel P. Berrange
On Mon, May 24, 2010 at 01:39:37PM -0400, Alex Williamson wrote: This allows libvirt to open the PCI device sysfs config file prior to dropping privileges so qemu can access the full config space. Without this, a de-privileged qemu can only access the first 64 bytes of config space.

Re: [libvirt] [PATCH 2/2] qemu: Release bus address on PCI host device remove

2010-05-24 Thread Daniel P. Berrange
On Mon, May 24, 2010 at 01:33:48PM -0400, Alex Williamson wrote: Signed-off-by: Alex Williamson alex.william...@redhat.com --- src/qemu/qemu_driver.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

Re: [libvirt] [PATCH] network: bridge: Don't start network if it collides with host routing

2010-05-24 Thread Cole Robinson
On 05/21/2010 01:35 PM, Laine Stump wrote: I'm stepping back, for now, on my suggestion of using libnl to do this. The proposed method works, and solves a serious problem. Using libnl would also work, but would create a new dependency (which can be a bit hairy with libnl - eg RHEL5 has

Re: [libvirt] [PATCH v8] vepa: parsing for 802.1Qb{g|h} XML

2010-05-24 Thread Chris Wright
* Daniel P. Berrange (berra...@redhat.com) wrote: On Sun, May 23, 2010 at 12:51:50PM -0400, Stefan Berger wrote: Index: libvirt-acl/src/util/macvtap.h === --- libvirt-acl.orig/src/util/macvtap.h +++

Re: [libvirt] [PATCH v2] storage: Sanitize pool target paths

2010-05-24 Thread Cole Robinson
On 05/21/2010 02:33 PM, Eric Blake wrote: On 05/21/2010 11:05 AM, Cole Robinson wrote: Spurious / in a pool target path makes life difficult for apps using the GetVolByPath, and doing other path based comparisons with pools. This has caused a few issues for virt-manager users:

[libvirt] [PATCH v3] storage: Sanitize pool target paths

2010-05-24 Thread Cole Robinson
Spurious / in a pool target path makes life difficult for apps using the GetVolByPath, and doing other path based comparisons with pools. This has caused a few issues for virt-manager users: https://bugzilla.redhat.com/show_bug.cgi?id=494005 https://bugzilla.redhat.com/show_bug.cgi?id=593565 Add

[libvirt] [PATCH v2] qemu: Allow using regular audio backends with VNC

2010-05-24 Thread Cole Robinson
Currently all host audio backends are disabled if a VM is using VNC, in favor of the QEMU VNC audio extension. Unfortunately no released VNC client supports this extension, so users have no way of getting audio to work if using VNC. Add a new config option in qemu.conf which allows changing

[libvirt] [PATCH v2] network: bridge: Don't start network if it collides with host routing

2010-05-24 Thread Cole Robinson
Fedora bug https://bugzilla.redhat.com/show_bug.cgi?id=235961 If using the default virtual network, an easy way to lose guest network connectivity is to install libvirt inside the VM. The autostarted default network inside the guest collides with host virtual network routing. This is a long

[libvirt] [PATCH] storage: mpath: Fix incorrect VIR_ERROR use

2010-05-24 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- src/storage/storage_backend_mpath.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/storage/storage_backend_mpath.c b/src/storage/storage_backend_mpath.c index 8d0a92a..3a137eb 100644 ---

[libvirt] [PATCH v3] Add host UUID (to libvirt capabilities)

2010-05-24 Thread Stefan Berger
This patch adds the host UUID (to the capabilities of libvirt). The user may provide it in libvirtd.conf overriding whatever sysfs may return. If none or no valid UUID is provided in libvirtd.conf, reading the UUID from sysfs is attempted. If that function doesn't provide a valid (not all digits

Re: [libvirt] [PATCH] Correct two memory leaks triggered by udev events

2010-05-24 Thread Chris Lalancette
On 05/24/2010 12:32 PM, Chris Lalancette wrote: On 05/24/2010 12:10 PM, Nigel Jones wrote: From 6c8183e83fbfeb031b16cf9ae2d41b16e3145378 Mon Sep 17 00:00:00 2001 From: Nigel Jones d...@nigelj.com Date: Mon, 24 May 2010 15:05:53 + Subject: [PATCH] Patch 2 memory leaks. 1. Ensure that

Re: [libvirt] [PATCH v8] vepa: parsing for 802.1Qb{g|h} XML

2010-05-24 Thread Hugh O. Brock
On Mon, May 24, 2010 at 11:47:18AM -0700, Chris Wright wrote: * Daniel P. Berrange (berra...@redhat.com) wrote: On Sun, May 23, 2010 at 12:51:50PM -0400, Stefan Berger wrote: Index: libvirt-acl/src/util/macvtap.h === ---

Re: [libvirt] [PATCH v8] vepa: parsing for 802.1Qb{g|h} XML

2010-05-24 Thread Stefan Berger
On Mon, 2010-05-24 at 15:35 -0400, Hugh O. Brock wrote: On Mon, May 24, 2010 at 11:47:18AM -0700, Chris Wright wrote: * Daniel P. Berrange (berra...@redhat.com) wrote: On Sun, May 23, 2010 at 12:51:50PM -0400, Stefan Berger wrote: Index: libvirt-acl/src/util/macvtap.h

Re: [libvirt] [PATCH] Don't overwrite virDomainAssignDef errors.

2010-05-24 Thread Chris Lalancette
On 05/20/2010 12:24 PM, Cole Robinson wrote: On 05/20/2010 11:14 AM, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/qemu/qemu_driver.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH v8] vepa: parsing for 802.1Qb{g|h} XML

2010-05-24 Thread Dave Allan
On Mon, May 24, 2010 at 03:57:10PM -0400, Stefan Berger wrote: On Mon, 2010-05-24 at 15:35 -0400, Hugh O. Brock wrote: On Mon, May 24, 2010 at 11:47:18AM -0700, Chris Wright wrote: * Daniel P. Berrange (berra...@redhat.com) wrote: On Sun, May 23, 2010 at 12:51:50PM -0400, Stefan Berger

Re: [libvirt] [PATCH] [DOCS] nwfilter: documentation

2010-05-24 Thread Eric Blake
On 05/22/2010 09:31 AM, Stefan Berger wrote: This patch adds documentation of the nwfilter subsystem of libvirt to the existing (web) docs. I am attaching a PDF in case you don't want to read the plain html sources. Sometimes, that really is a much easier way to review :) If nothing else, it

Re: [libvirt] [PATCH v8] vepa: parsing for 802.1Qb{g|h} XML

2010-05-24 Thread Chris Wright
* Hugh O. Brock (hbr...@redhat.com) wrote: On Mon, May 24, 2010 at 11:47:18AM -0700, Chris Wright wrote: * Daniel P. Berrange (berra...@redhat.com) wrote: On Sun, May 23, 2010 at 12:51:50PM -0400, Stefan Berger wrote: Index: libvirt-acl/src/util/macvtap.h

Re: [libvirt] [PATCH] Fix failing virGetHostname.

2010-05-24 Thread Chris Lalancette
On 05/21/2010 12:27 PM, Cole Robinson wrote: Hmm, why isn't one of the fallback options: if (conn) hostname = parse_uri(conn.get_uri()) if hostname != localhost: return hostname Seems like if MigratePrepare2 dconn is the remote connection, we are guaranteed to have a

Re: [libvirt] [PATCH] Fix up basic migration.

2010-05-24 Thread Chris Lalancette
On 05/21/2010 12:48 PM, Eric Blake wrote: On 05/21/2010 07:22 AM, Chris Lalancette wrote: -virCheckFlags(VIR_MIGRATE_NON_SHARED_DISK | VIR_MIGRATE_NON_SHARED_INC, - -1); - Why are you removing the valid flag check altogether? Is it a matter of adding more valid

[libvirt] [PATCH v2] Fix up basic migration.

2010-05-24 Thread Chris Lalancette
Basic live migration was broken by the commit that added non-shared block support in two ways: 1) It added a virCheckFlags() to doNativeMigrate(). Besides the fact that typical usage of virCheckFlags() is in driver entry points, and doNativeMigrate() is not an entry point, it was missing

[libvirt] [PATCH] Allow nwfilter functions to be compiled with C++

2010-05-24 Thread Chris Lalancette
Unfortunately the NWFilter functions were outside of the extern C { ... } declaration in include/libvirt/libvirt.h.in, which means that they couldn't be properly used with C++. Move them inside of the braces, which should fix the problem. Signed-off-by: Chris Lalancette clala...@redhat.com ---

Re: [libvirt] [PATCH] Fix up basic migration.

2010-05-24 Thread Eric Blake
On 05/24/2010 02:20 PM, Chris Lalancette wrote: Sounds good to me - if all entry points filter on all accepted flags, then helper functions can assume that flags are already valid. As long as the filtering gets done somewhere, we've left the door open for adding future flags while still

Re: [libvirt] [PATCH] Allow nwfilter functions to be compiled with C++

2010-05-24 Thread Eric Blake
On 05/24/2010 02:24 PM, Chris Lalancette wrote: Unfortunately the NWFilter functions were outside of the extern C { ... } declaration in include/libvirt/libvirt.h.in, which means that they couldn't be properly used with C++. Move them inside of the braces, which should fix the problem. ACK.

[libvirt] [v3 PATCH] add 802.1Qbh handling for port-profiles based on Stefan's previous patches

2010-05-24 Thread Scott Feldman
From: Scott Feldman scofe...@cisco.com This patch builds on the work recently posted by Stefan Berger. It builds on top of Stefan's two posted patches: [PATCH v8] vepa: parsing for 802.1Qb{g|h} XML [RFC][PATCH 1/3] vepa+vsi: Introduce dependency on libnl [PATCH v3] Add

Re: [libvirt] [PATCH] Fix failing virGetHostname.

2010-05-24 Thread Cole Robinson
On 05/24/2010 04:17 PM, Chris Lalancette wrote: On 05/21/2010 12:27 PM, Cole Robinson wrote: Hmm, why isn't one of the fallback options: if (conn) hostname = parse_uri(conn.get_uri()) if hostname != localhost: return hostname Seems like if MigratePrepare2 dconn is the remote

[libvirt] [PATCH v9] vepa: parsing for 802.1Qb{g|h} XML

2010-05-24 Thread Stefan Berger
Below is David Alan's original patch with lots of changes. In particular, it now parses the following two XML descriptions, one for 802.1Qbg and 802.1Qbh and stored the data internally. The actual triggering of the switch setup protocol has not been implemented here but the relevant code to do

Re: [libvirt] [v3 PATCH] add 802.1Qbh handling for port-profiles based on Stefan's previous patches

2010-05-24 Thread Stefan Berger
Scott Feldman scofe...@cisco.com wrote on 05/24/2010 04:48:40 PM: [image removed] [v3 PATCH] add 802.1Qbh handling for port-profiles based on Stefan's previous patches Scott Feldman to: libvir-list 05/24/2010 04:48 PM Cc: Stefan Berger, chrisw, dallan From: Scott

[libvirt] [PATCH v3] storage: Check for invalid storage mode before opening

2010-05-24 Thread Cole Robinson
If a directory pool contains pipes or sockets, a pool start can fail or hang: https://bugzilla.redhat.com/show_bug.cgi?id=589577 We already try to avoid these special files, but only attempt after opening the path, which is where the problems lie. Unify volume opening into helper functions,

Re: [libvirt] [PATCH v2] esx: Add read-only storage pool access

2010-05-24 Thread Eric Blake
On 05/18/2010 10:38 AM, Matthias Bolte wrote: Allows listing existing pools and requesting information about them. Alter the esxVI_ProductVersion enum in a way that allows to check for product type by masking. Changes in v2: - split not directly related parts into separate patches It's

Re: [libvirt] [PATCH v2] storage: Check for invalid storage mode before opening

2010-05-24 Thread Cole Robinson
On 05/24/2010 06:36 AM, Daniel P. Berrange wrote: On Fri, May 21, 2010 at 02:24:24PM -0400, Cole Robinson wrote: On 05/21/2010 02:17 PM, Eric Blake wrote: On 05/21/2010 11:03 AM, Cole Robinson wrote: If a directory pool contains pipes or sockets, a pool start can fail or hang:

Re: [libvirt] [PATCH] Query block allocation extent from QEMU monitor

2010-05-24 Thread Eric Blake
On 05/14/2010 07:10 AM, Daniel P. Berrange wrote: The virDomainGetBlockInfo API allows query physical block extent and allocated block extent. These are normally the same value unless storing a special format like qcow2 inside a block device. In this scenario we can query QEMU to get the

Re: [libvirt] [PATCH] lxcSetSchedulerParameters: reverse order of tests; improve a diagnostic

2010-05-24 Thread Eric Blake
On 05/12/2010 07:23 PM, Eric Blake wrote: [trying to clear out some old mail] From bc3404d9f12c42cf883a43395fee6fc14c952b2c Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 11 May 2010 15:43:32 +0200 Subject: [PATCH] lxcSetSchedulerParameters: reverse order of

Re: [libvirt] [PATCH] [DOCS] nwfilter: documentation

2010-05-24 Thread Stefan Berger
On Mon, 2010-05-24 at 14:09 -0600, Eric Blake wrote: On 05/22/2010 09:31 AM, Stefan Berger wrote: This patch adds documentation of the nwfilter subsystem of libvirt to the existing (web) docs. I am attaching a PDF in case you don't want to read the plain html sources. Sometimes, that

Re: [libvirt] [PATCH 1/2] qemu: avoid corrupting guest info struct on host device PCI hot add

2010-05-24 Thread Eric Blake
On 05/24/2010 11:49 AM, Daniel P. Berrange wrote: On Mon, May 24, 2010 at 01:33:27PM -0400, Alex Williamson wrote: The device path doesn't make use of guestAddr, so the memcpy corrupts the guest info struct. Signed-off-by: Alex Williamson alex.william...@redhat.com ACK Net + disk

Re: [libvirt] [PATCH v3] storage: Sanitize pool target paths

2010-05-24 Thread Eric Blake
On 05/24/2010 12:52 PM, Cole Robinson wrote: Spurious / in a pool target path makes life difficult for apps using the GetVolByPath, and doing other path based comparisons with pools. This has caused a few issues for virt-manager users: https://bugzilla.redhat.com/show_bug.cgi?id=494005

Re: [libvirt] [PATCH] storage: mpath: Fix incorrect VIR_ERROR use

2010-05-24 Thread Eric Blake
On 05/24/2010 12:52 PM, Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- src/storage/storage_backend_mpath.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/storage/storage_backend_mpath.c b/src/storage/storage_backend_mpath.c

Re: [libvirt] [PATCH v3] storage: Sanitize pool target paths

2010-05-24 Thread Eric Blake
On 05/24/2010 04:55 PM, Eric Blake wrote: Phooey. Need a v4; this can fault. If you have /// ending on a page boundary, then... +bool slash_before = (offset != 0 cur[-1] == '/'); + +/* Skip all extra / */ +if (*cur == '/') { +cur++;

[libvirt] [PATCH] virDrvStorageVolLookupByKey and virDrvStorageVolLookupByPath should use virStoragePoolPtr as parameter

2010-05-24 Thread Eduardo Otubo
Hello, These two functions, virDrvStorageVolLookupByKey and virDrvStorageVolLookupByPath should use virStoragePoolPtr as parameter instead of virConnectPtr for some few reasons: 1) Should follow the standard virStorage*Ptr parameters like the rest of storage related functions. 2)

[libvirt] [v4 PATCH] add 802.1Qbh handling for port-profiles based on Stefan's previous patches

2010-05-24 Thread Scott Feldman
From: Scott Feldman scofe...@cisco.com This patch builds on the work recently posted by Stefan Berger. It builds on top of Stefan's three posted patches: [PATCH v9] vepa: parsing for 802.1Qb{g|h} XML [RFC][PATCH 1/3] vepa+vsi: Introduce dependency on libnl [PATCH v3] Add

Re: [libvirt] [PATCH] phyp: first part of storage management driver

2010-05-24 Thread Stefan Berger
Eduardo Otubo ot...@linux.vnet.ibm.com wrote on 05/18/2010 05:01:40 PM: Please respond to otubo On 05/14/2010 05:27 PM, Stefan Berger wrote: + +virStoragePoolPtr +phypSPLookupByName(virConnectPtr conn, const char *sp_name) +{ + virStoragePoolPtr sp = NULL; + int

Re: [libvirt] Documentation for synchronous hooks

2010-05-24 Thread Osier Yang
still no /etc/libvirt/hooks and example hook scripts in 0.8.1-6. anyone can provide some simple hook scripts? thanks - Osier Daniel Veillard wrote: On Mon, Apr 26, 2010 at 08:42:12PM -0400, Jintao Yang wrote: hi DV, I saw the changelog of 0.7.8, which told the hooks scripts are

Re: [libvirt] [v4 PATCH] add 802.1Qbh handling for port-profiles based on Stefan's previous patches

2010-05-24 Thread Dave Allan
On Mon, May 24, 2010 at 05:22:15PM -0700, Scott Feldman wrote: From: Scott Feldman scofe...@cisco.com This patch builds on the work recently posted by Stefan Berger. It builds on top of Stefan's three posted patches: [PATCH v9] vepa: parsing for 802.1Qb{g|h} XML

[libvirt] [v5 PATCH] add 802.1Qbh handling for port-profiles based on Stefan's previous patches

2010-05-24 Thread Scott Feldman
From: Scott Feldman scofe...@cisco.com This patch builds on the work recently posted by Stefan Berger. It builds on top of Stefan's three posted patches: [PATCH v9] vepa: parsing for 802.1Qb{g|h} XML [RFC][PATCH 1/3] vepa+vsi: Introduce dependency on libnl [PATCH v3] Add