Re: [libvirt] [PATCH] [RFC] nwfilter: fix loadable module support

2010-06-15 Thread Daniel P. Berrange
On Mon, Jun 14, 2010 at 07:49:50AM -0400, Stefan Berger wrote: Hello! I am trying to fix the loadable modules support by removing all direct calls from qemu_driver.c and qemu_conf.c into nwfilter functions. The below patch extends the nwfilter driver interface with 2 more private

[libvirt] printf()'s in virsh?

2010-06-15 Thread Justin Clift
Hi guys, In virsh, in the cmdSchedinfo() function, there's a block of code using printf instead of vshPrintf(): for (i = 0; i nparams; i++){ switch (params[i].type) { case VIR_DOMAIN_SCHED_FIELD_INT: printf(%-15s: %d\n, params[i].field, params[i].value.i);

[libvirt] [PATCH] Allow one-or-more boot dev=.../ entries

2010-06-15 Thread Philipp Hahn
According to docs/formatdomain.html.in, The boot element can be repeated multiple times to setup a priority list of boot devices to try in turn. The Relax-NG schema required / allowed exactly one entry. Signed-off-by: Philipp Hahn h...@univention.de --- docs/schemas/domain.rng |4 +++- 1

[libvirt] [PATCH] Allow one-or-more boot dev=.../ entries

2010-06-15 Thread Philipp Hahn
According to docs/formatdomain.html.in, The boot element can be repeated multiple times to setup a priority list of boot devices to try in turn. The Relax-NG schema required / allowed exactly one entry. Signed-off-by: Philipp Hahn h...@univention.de --- docs/schemas/domain.rng |4 +++- 1

[libvirt] [PATCH] Fix description of virStorageVolGetInfo()

2010-06-15 Thread Philipp Hahn
Probably a copy-paste-bug in python/libvirt-override-api.xml: virStorageVolGetInfo() extracts information about a storage volume, not the storage pool as virStoragePoolGetInfo() does. Signed-off-by: Philipp Hahn h...@univention.de --- python/libvirt-override-api.xml |2 +- 1 files changed,

[libvirt] [PATCH 0/2]: Small fixes for PCI device assignment

2010-06-15 Thread Chris Lalancette
This series fixes a couple of bugs found while testing libvirt PCI device assignment. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/2] Check for active PCI devices when doing nodedevice operations.

2010-06-15 Thread Chris Lalancette
In the current libvirt PCI code, there is no checking whether a PCI device is in use by a guest when doing node device detach or reattach. This causes problems when a device is assigned to a guest, and the administrator starts issuing nodedevice commands. Make it so that we check the list of

[libvirt] [PATCH 2/2] Fix crash when detaching devices from qemu domains.

2010-06-15 Thread Chris Lalancette
Make sure to *not* call qemuDomainPCIAddressReleaseAddr if QEMUD_CMD_FLAG_DEVICE is *not* set (for older qemu). This prevents a crash when trying to do device detachment from a qemu guest. Signed-off-by: Chris Lalancette clala...@redhat.com --- src/qemu/qemu_driver.c |8 1 files

[libvirt] [PATCH v2] nwfilter: fix loadable module support

2010-06-15 Thread Stefan Berger
Following Daniel Berrange's suggestion of introducing another driver interface, I now wrote the below patch where the nwfilter driver registers the functions to instantiate and teardown the nwfilters with a function in conf/domain_nwfilter.c called virDomainConfNWFilterRegister. Previous

Re: [libvirt] [PATCH 1/2] Check for active PCI devices when doing nodedevice operations.

2010-06-15 Thread Daniel P. Berrange
On Tue, Jun 15, 2010 at 08:03:11AM -0400, Chris Lalancette wrote: In the current libvirt PCI code, there is no checking whether a PCI device is in use by a guest when doing node device detach or reattach. This causes problems when a device is assigned to a guest, and the administrator starts

Re: [libvirt] [PATCH 1/2] Check for active PCI devices when doing nodedevice operations.

2010-06-15 Thread Chris Lalancette
On 06/15/10 - 01:13:00PM, Daniel P. Berrange wrote: @@ -11179,6 +11179,7 @@ out: static int qemudNodeDeviceDettach (virNodeDevicePtr dev) { +struct qemud_driver *driver = dev-conn-privateData; pciDevice *pci; unsigned domain, bus, slot, function; int ret = -1;

Re: [libvirt] [PATCH] maint: simplify some ignore files

2010-06-15 Thread Jiri Denemark
* .hgignore: Delete, no longer used. * examples/python/.gitignore: Delete, covered globally. * include/.gitignore: Likewise. * python/tests/.gitignore: Likewise. * docs/schemas/.gitignore: Likewise. * tests/xml2sexprdata/.gitignore: Likewise. * tests/sexpr2xmldata/.gitignore: Likewise. *

Re: [libvirt] [PATCH] maint: simplify some ignore files

2010-06-15 Thread Eric Blake
On 06/15/2010 07:29 AM, Jiri Denemark wrote: * .hgignore: Delete, no longer used. * examples/python/.gitignore: Delete, covered globally. * include/.gitignore: Likewise. * python/tests/.gitignore: Likewise. * docs/schemas/.gitignore: Likewise. * tests/xml2sexprdata/.gitignore: Likewise. *

Re: [libvirt] [PATCH] esx: Accept 'disk' as harddisk device type in .vmx files

2010-06-15 Thread Jiri Denemark
src/esx/esx_vmx.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/esx/esx_vmx.c b/src/esx/esx_vmx.c index 5cadb5a..675318f 100644 --- a/src/esx/esx_vmx.c +++ b/src/esx/esx_vmx.c @@ -1542,16 +1542,20 @@ esxVMX_ParseDisk(esxVI_Context *ctx, virConfPtr

Re: [libvirt] [PATCH] esx: Update case insensitive .vmx tests

2010-06-15 Thread Jiri Denemark
Commit b9efc7dc3b97ef667ab99cee884b8485ebcb2f91 made virFileHasSuffix case insensitive. Honor this in the tests by switching vmdk to VMDK. --- tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx |2 +- tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml |2 +- 2 files changed, 2

Re: [libvirt] [PATCH] virsh: mark autostart answers for translation

2010-06-15 Thread Jiri Denemark
This is a trivial fix for several autostart yes/no strings that weren't correctly marked for translation. --- tools/virsh.c |8 1 files changed, 4 insertions(+), 4 deletions(-) ACK Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCHv2 2/5] remote: protocol implementation for virDomainCreateWithFlags

2010-06-15 Thread Eric Blake
On 06/11/2010 07:33 AM, Daniel P. Berrange wrote: On Thu, Jun 10, 2010 at 12:21:20PM -0600, Eric Blake wrote: Define the wire format for the new virDomainCreateWithFlags API, and implement client and server side of marshaling code. * daemon/remote.c (remoteDispatchDomainCreateWithFlags): Add

Re: [libvirt] [PATCH] virsh: mark autostart answers for translation

2010-06-15 Thread Eric Blake
On 06/15/2010 08:50 AM, Jiri Denemark wrote: This is a trivial fix for several autostart yes/no strings that weren't correctly marked for translation. --- tools/virsh.c |8 1 files changed, 4 insertions(+), 4 deletions(-) ACK Pushed. -- Eric Blake ebl...@redhat.com

Re: [libvirt] Update to libvirt-lxc driver doc page

2010-06-15 Thread Eric Blake
On 06/07/2010 08:55 AM, Serge Hallyn wrote: Here is a new drvlxc.html.in file to make the first example work. I'll play with the second example next. Thanks for the sample text; it looked good to me on a first read. Are you willing to finish out this patch by also including the patch to

Re: [libvirt] Update to libvirt-lxc driver doc page

2010-06-15 Thread Serge E. Hallyn
Quoting Eric Blake (ebl...@redhat.com): On 06/07/2010 08:55 AM, Serge Hallyn wrote: Here is a new drvlxc.html.in file to make the first example work. I'll play with the second example next. Thanks for the sample text; it looked good to me on a first read. Are you willing to finish out

Re: [libvirt] Update to libvirt-lxc driver doc page

2010-06-15 Thread Eric Blake
On 06/15/2010 04:11 PM, Serge E. Hallyn wrote: Thanks for the sample text; it looked good to me on a first read. Are you willing to finish out this patch by also including the patch to Makefile.am to generate drvlxc.html and distribute the new file? Uh, sure. As I got yelled at last time

Re: [libvirt] Update to libvirt-lxc driver doc page

2010-06-15 Thread Eric Blake
On 06/15/2010 04:18 PM, Eric Blake wrote: find /usr -name libvirt_lxc should take its place. Doh! Yep, that would explain it. I'll try again ;) Yes, it worked just fine with /usr/libexec/libvirt_lxc - I was able to attach to a limited lxc console. -- Eric Blake ebl...@redhat.com

Re: [libvirt] Update to libvirt-lxc driver doc page

2010-06-15 Thread Serge E. Hallyn
Quoting Eric Blake (ebl...@redhat.com): http://libvirt.org/git/?p=libvirt.git;a=blob;f=README-hacking Doh - I had no idea the web pages were just sitting in libvirt.git/docs! Now it all makes sense. Thanks. -serge -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] virsh: change printf() calls to vshPrint()

2010-06-15 Thread Justin Clift
Trivial fix changing printf() calls to vshPrint() where the ctl variable is available. --- Haven't created a BZ for this yet, as I'm not sure it's important enough to warrant pushing into anything other than git head. Should a BZ be created anyway? tools/virsh.c | 40