Always call the free function of the base type. The base type
function then dynamically dispatches the call to the free function
for the actual type.
---
src/esx/esx_vi_generator.py | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/esx/esx_vi_generator.py
From: Laine Stump la...@redhat.com
This fixes a leak described in
https://bugzilla.redhat.com/show_bug.cgi?id=590073
xenUnifiedDomainInfoList has a pointer to a list of pointers to
xenUnifiedDomain. We were freeing up all the domains, but neglecting
to free the list.
This was found by Paolo
(The only change to this version of the patch is to make the warning
message more verbose when we fail to add the CHECKSUM rule, noting
that the failure would likely be solved by updating iptables and the
kernel.)
This patch attempts to take advantage of a newly added netfilter
module to correct
Move virDomainChrTargetTypeToString out of the #ifndef PROXY
block, because it's used outside of it.
---
src/conf/domain_conf.c | 40
1 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
On 07/29/2010 07:47 AM, Laine Stump wrote:
From: Laine Stump la...@redhat.com
This fixes a leak described in
https://bugzilla.redhat.com/show_bug.cgi?id=590073
xenUnifiedDomainInfoList has a pointer to a list of pointers to
xenUnifiedDomain. We were freeing up all the domains, but
On 07/29/2010 08:07 AM, Matthias Bolte wrote:
Move virDomainChrTargetTypeToString out of the #ifndef PROXY
block, because it's used outside of it.
---
src/conf/domain_conf.c | 40
1 files changed, 20 insertions(+), 20 deletions(-)
ACK.
--
Eric
On 07/29/10 - 09:47:53AM, Laine Stump wrote:
From: Laine Stump la...@redhat.com
This fixes a leak described in
https://bugzilla.redhat.com/show_bug.cgi?id=590073
xenUnifiedDomainInfoList has a pointer to a list of pointers to
xenUnifiedDomain. We were freeing up all the domains, but
On 07/29/10 - 04:07:08PM, Matthias Bolte wrote:
Move virDomainChrTargetTypeToString out of the #ifndef PROXY
block, because it's used outside of it.
---
src/conf/domain_conf.c | 40
1 files changed, 20 insertions(+), 20 deletions(-)
diff --git
On 07/29/2010 04:29 AM, Matthias Bolte wrote:
Always call the free function of the base type. The base type
function then dynamically dispatches the call to the free function
for the actual type.
---
src/esx/esx_vi_generator.py | 14 ++
1 files changed, 10 insertions(+), 4
lxcStartup forgot to call lxcAutostartConfigs. Fix it.
This patch should fix https://bugzilla.redhat.com/show_bug.cgi?id=589863 .
---
src/lxc/lxc_driver.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index 4fc1ecd..b286692
On 07/28/10 - 02:39:38PM, Chris Wright wrote:
* Chris Lalancette (clala...@redhat.com) wrote:
If detecting the FLR flag of a pci device fails, then we
could run into the situation of trying to close a file
descriptor twice, once in pciInitDevice() and once in pciFreeDevice().
Fix that by
2010/7/21 Daniel Veillard veill...@redhat.com:
Small reminder, we will try to get back to a monthly release schedule
so I'm targetting an end of month release for 0.8.3 . Assuming Friday 30
this would mean we enter the feature freeze at the end of the week.
I'm gonna go over the pending
On 07/29/2010 08:21 AM, Ryota Ozaki wrote:
lxcStartup forgot to call lxcAutostartConfigs. Fix it.
This patch should fix https://bugzilla.redhat.com/show_bug.cgi?id=589863 .
---
src/lxc/lxc_driver.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git
2010/7/29 Eric Blake ebl...@redhat.com:
On 07/29/2010 08:07 AM, Matthias Bolte wrote:
Move virDomainChrTargetTypeToString out of the #ifndef PROXY
block, because it's used outside of it.
---
src/conf/domain_conf.c | 40
1 files changed, 20
the followup on the boot=on problem, basically it's not needed to
specify it when booting out of IDE devices when using KVM (and with
newer seabios version it's also not needed for virtio).
That patch isn't critical, it's more a cleanup one, I would delay
this after the 0.8.3 release in any
Folks,
Anyone got any information about support in libvirt for automatic
handling of IO controller throttling/IO limits with recent kernels? I'd
love it if libvirt just supported assigning IO bandwidth automatically.
:)
Jon.
--
libvir-list mailing list
libvir-list@redhat.com
Hi everyone:
using this command to install a kvm virtual machine:
virt-install --connect qemu:///system \
--name p3k0401 \
--ram 2048 \
--file //dev/VolGroup01/p3k0401logvol \
--accelerate \
-s 10 \
--nographics \
--hvm \
--location='http://10.1.4.80'
I get:
Starting install...
Retrieving
The first of thse two patches is an uncorrupted version of the patch in the
parent message. The second is a few suggested changes. Overall, it looks
very good.
If you're okay with these changes, and at least one other person ACKs
the combination, I can squash the two patches together and push
Some suggested changes to your latest patch (I did the review by
applying your patch, then examining the functions that were touched,
focusing just on setting of rc)
Summary:
1) virAsprintf() will return the number of characters in the new
string on success, not 0, so we need to only set rc
From: Ryota Ozaki ozaki.ry...@gmail.com
Previously, the functions in src/lxc/veth.c could sometimes return
positive values on failure rather than -1. This made accurate error
reporting difficult, and led to one failure to catch an error in a
calling function.
This patch makes all the functions
On 07/29/2010 10:10 AM, Eric Blake wrote:
On 07/29/2010 07:47 AM, Laine Stump wrote:
From: Laine Stumpla...@redhat.com
This fixes a leak described in
https://bugzilla.redhat.com/show_bug.cgi?id=590073
xenUnifiedDomainInfoList has a pointer to a list of pointers to
xenUnifiedDomain. We
On Wed, Jul 28, 2010 at 05:34:14PM -0600, Eric Blake wrote:
The recent switch to enable -Wlogical-op paid off again.
gcc 4.5.0 (rawhide) is smarter than 4.4.4 (Fedora 13).
* src/xen/xend_internal.c (xenDaemonAttachDeviceFlags)
(xenDaemonUpdateDeviceFlags, xenDaemonDetachDeviceFlags): Use
On Wed, Jul 28, 2010 at 05:34:15PM -0600, Eric Blake wrote:
* src/esx/esx_vi_types.c (_DESERIALIZE_NUMBER)
(ESX_VI__TEMPLATE__DESERIALIZE_NUMBER): Add range check to shut up
gcc 4.5.0 regarding long long.
---
src/esx/esx_vi_types.c |6 --
1 files changed, 4 insertions(+), 2
On Thu, Jul 29, 2010 at 12:18:23PM -0400, Laine Stump wrote:
From: Ryota Ozaki ozaki.ry...@gmail.com
Previously, the functions in src/lxc/veth.c could sometimes return
positive values on failure rather than -1. This made accurate error
reporting difficult, and led to one failure to catch an
On Thu, Jul 29, 2010 at 12:18:24PM -0400, Laine Stump wrote:
Some suggested changes to your latest patch (I did the review by
applying your patch, then examining the functions that were touched,
focusing just on setting of rc)
Summary:
1) virAsprintf() will return the number of characters
From: Ryota Ozaki ozaki.ry...@gmail.com
From: Ryota Ozaki ozaki.ry...@gmail.com
Previously, the functions in src/lxc/veth.c could sometimes return
positive values on failure rather than -1. This made accurate error
reporting difficult, and led to one failure to catch an error in a
calling
On Mon, Jul 26, 2010 at 03:12:25AM +0200, Matthias Bolte wrote:
esxVI_WaitForTaskCompletion can take a UUID to lookup the
corresponding domain and check if the current task for it
is blocked by a question. It calls another function to do
this: esxVI_LookupAndHandleVirtualMachineQuestion looks
Hi,
i think that I know where is the problem. My messages log says:
Jul 29 19:36:41 divinus libvirtd: 19:36:41.032: error :
qemudDispatchServer:1315 : Too many active clients (100), dropping
connection
It looks like that ruby-libvirt doesn't closing connection, when it's
running under
On Fri, Jul 30, 2010 at 2:32 AM, Laine Stump la...@laine.org wrote:
From: Ryota Ozaki ozaki.ry...@gmail.com
From: Ryota Ozaki ozaki.ry...@gmail.com
Previously, the functions in src/lxc/veth.c could sometimes return
positive values on failure rather than -1. This made accurate error
On 07/29/2010 01:53 PM, Ryota Ozaki wrote:
On Fri, Jul 30, 2010 at 2:32 AM, Laine Stumpla...@laine.org wrote:
From: Ryota Ozakiozaki.ry...@gmail.com
Previously, the functions in src/lxc/veth.c could sometimes return
positive values on failure rather than -1. This made accurate error
30 matches
Mail list logo
