Re: [libvirt] Mac OS X: dyld: lazy symbol binding failed

2010-10-18 Thread Mitchell Hashimoto
All, With a few small patches (to remove documentation generation, thanks to Justin) to my local git checkout, I was finally able to make dist and test the resulting distribution. The result is that this worked great on my Mac as well as another Mac I have that was having trouble. I think this

[libvirt] [PATCH] Update docs for memory parameters and memtune command

2010-10-18 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com docs/formatdomain.html.in: Add memtune element details src/libvirt.c: Update virDomainGetMemoryParameters api description, make it more clear that the user first needs to call the api to get the number of parameters supported and then call again

Re: [libvirt] [PATCH] Update docs for memory parameters and memtune command

2010-10-18 Thread Matthias Bolte
2010/10/18 Nikunj A. Dadhania nik...@linux.vnet.ibm.com: From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com docs/formatdomain.html.in: Add memtune element details src/libvirt.c: Update virDomainGetMemoryParameters api description, make it more clear that the user first needs to call the api

Re: [libvirt] [PATCH] Update docs for memory parameters and memtune command

2010-10-18 Thread Nikunj A. Dadhania
On Mon, 18 Oct 2010 09:55:46 +0200, Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/10/18 Nikunj A. Dadhania nik...@linux.vnet.ibm.com: From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com docs/formatdomain.html.in: Add memtune element details [...] @@ -211,6 +216,22 @@        

Re: [libvirt] [virt-tools-list] KVM Windows guest: add hard drive

2010-10-18 Thread Tapas Mishra
On Tue, Oct 12, 2010 at 11:47 PM, Mihamina Rakotomandimby miham...@gulfsat.mg wrote: Manao ahoana, Hello, Bonjour, I installed a Windows (XP and 2003) guest using one partition as hard drive. I used: sudo virt-install --connect qemu:///system \ --name win2003-01 \ --ram 1024 \

Re: [libvirt] [PATCH] Update docs for memory parameters and memtune command

2010-10-18 Thread Balbir Singh
* Nikunj A. Dadhania nik...@linux.vnet.ibm.com [2010-10-18 14:03:53]: On Mon, 18 Oct 2010 09:55:46 +0200, Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/10/18 Nikunj A. Dadhania nik...@linux.vnet.ibm.com: From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com

Re: [libvirt] [PATCH] Update docs for memory parameters and memtune command

2010-10-18 Thread Nikunj A. Dadhania
Hi Matthias, Here goes the updated patch. From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com docs/formatdomain.html.in: Add memtune element details, added min_guarantee src/libvirt.c: Update virDomainGetMemoryParameters api description, make it more clear that the user first needs to call the

Re: [libvirt] [PATCH] Don't fail lxc domain start when memory controller support is missing

2010-10-18 Thread Daniel P. Berrange
On Fri, Oct 15, 2010 at 06:05:10PM +0200, Guido Günther wrote: On Fri, Oct 15, 2010 at 10:15:02AM +0200, Guido Günther wrote: Hi, starting of lxc domains currently fails if memory controller support is disabled in the kernel. Attached patch fixes this by ignoring the error in case the

[libvirt] [PATCH] memtune: Add min_guarantee to the virsh tool

2010-10-18 Thread Nikunj A. Dadhania
Hi, I am adding the min_guarantee to the memtune command with this patch. I have tested this at the virsh tool level. This parameter is not supported by QEMU or LXC. Can be used by ESX and in future by other hypervisors. Nikunj From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com tools/virsh.c:

Re: [libvirt] Mac OS X: dyld: lazy symbol binding failed

2010-10-18 Thread Justin Clift
On 10/18/2010 05:43 PM, Mitchell Hashimoto wrote: All, With a few small patches (to remove documentation generation, thanks to Justin) to my local git checkout, I was finally able to make dist and test the resulting distribution. The result is that this worked great on my Mac as well as another

Re: [libvirt] [PATCH] initgroups() in qemudOpenAsUID()

2010-10-18 Thread Daniel P. Berrange
On Sun, Oct 17, 2010 at 10:58:55PM +0200, Dan Kenigsberg wrote: qemudOpenAsUID is intended to open a file with the credentials of a specified uid. Current implementation fails if the file is accessible to one of uid's groups but not owned by uid. This patch replaces the supplementary group

Re: [libvirt] Mac OS X: dyld: lazy symbol binding failed

2010-10-18 Thread Daniel Veillard
On Mon, Oct 18, 2010 at 08:34:56PM +1100, Justin Clift wrote: On 10/18/2010 05:43 PM, Mitchell Hashimoto wrote: All, With a few small patches (to remove documentation generation, thanks to Justin) to my local git checkout, I was finally able to make dist and test the resulting distribution.

Re: [libvirt] Mac OS X: dyld: lazy symbol binding failed

2010-10-18 Thread Justin Clift
On 10/18/2010 09:00 PM, Daniel Veillard wrote: snip Builds are not done on the server but on my workstation, currently running Fedora 12: paphio:~ - rpm -q autoconf automake libtool autoconf-2.63-5.fc12.noarch automake-1.11.1-1.fc12.noarch libtool-2.2.6-18.fc12.1.x86_64 I should probably

[libvirt] [libvirt-tck 1/3] Correct typos in documents

2010-10-18 Thread Osier Yang
* docs/intro.pod * docs/writing-tests.pod --- docs/intro.pod | 10 +- docs/writing-tests.pod |8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/intro.pod b/docs/intro.pod index 5943f3b..3684d51 100644 --- a/docs/intro.pod +++ b/docs/intro.pod @@

[libvirt] [libvirt-tck 2/3] Add module for hooks testing

2010-10-18 Thread Osier Yang
To test daemon, qemu, lxc hook. * lib/Sys/Virt/TCK/Hooks.pm --- lib/Sys/Virt/TCK/Hooks.pm | 262 + 1 files changed, 262 insertions(+), 0 deletions(-) create mode 100644 lib/Sys/Virt/TCK/Hooks.pm diff --git a/lib/Sys/Virt/TCK/Hooks.pm

[libvirt] [libvirt-tck 3/3] Add test case for daemon hook testing

2010-10-18 Thread Osier Yang
Validate daemon hook is invocated correctly while start, restart, stop, reload libvirtd --- scripts/hooks/051-daemon-hook.t | 156 +++ 1 files changed, 156 insertions(+), 0 deletions(-) create mode 100644 scripts/hooks/051-daemon-hook.t diff --git

Re: [libvirt] [libvirt-tck 1/3] Correct typos in documents

2010-10-18 Thread Justin Clift
On 10/18/2010 10:18 AM, Osier Yang wrote: -Notice that since the tst script declared upfront that it intended +Notice that since the test script declared upfront that it intended (missing the is) ...script *is* declared up front ... Didn't look at the rest though, just noticed this as I

[libvirt] Suggested schedule for next release

2010-10-18 Thread Daniel Veillard
Last release was 5 weeks ago so this release cycle will be longuer than usual. There was still a number of patches I wanted to get in for next release, but now it might be time to get ready for next release. I suggest to keep until the end of the week for feature patches but enter the feeze

[libvirt] C# bindings (Was: First patch)

2010-10-18 Thread Daniel Veillard
On Mon, Oct 18, 2010 at 02:41:26PM +0200, arnaud.champ...@devatom.fr wrote: ?Hi, Hi Arnaud, this is my first patch import for libvirt C# bindings. Sorry I haven't been able to change the mime type for the patch (Windows Mail doesn't allow this it seems) Okay, I can't really test this,

Re: [libvirt] C# bindings (Was: First patch)

2010-10-18 Thread arnaud.champion
?Hi, so, in fact, strings in Properties/AssemblyInfo.cs are auto generated by Visual Studio. I can change strings values, but I have to know What to put as society and copyright. For the comments in this file, they are also generated by visual Studio and as my installation is in french,

Re: [libvirt] RFC: automatic setting of ip_forwarding (or not)

2010-10-18 Thread Laine Stump
I'd forgotten to reply to this before... On 10/07/2010 08:14 AM, Daniel P. Berrange wrote: On Fri, Oct 01, 2010 at 02:46:34PM -0400, Laine Stump wrote: Currently libvirt will turn on net.ipv4.ip_forward by writing 1\n to /proc/sys/net/ipv4/ip_forward whenever a virtual network of with a

Re: [libvirt] Need review of new vswitch concept info for technical accuracy

2010-10-18 Thread Justin Clift
On 10/18/2010 04:34 PM, Laine Stump wrote: On 10/16/2010 03:01 PM, Justin Clift wrote: Hi all, Working on the Foundation Concepts for virtual switches at the moment. Does anyone have time/inclination to check over the concept graphics thus far, for technical accuracy? I think it would more

Re: [libvirt] C# bindings (Was: First patch)

2010-10-18 Thread Justin Clift
On 10/19/2010 12:25 AM, Daniel Veillard wrote: snip Anyway, since the git tree was currently empty (except for Licence files) I commited and pushed the patch (just cleaned up a few trailing whitespaces). It's there now http://libvirt.org/git/?p=libvirt-csharp.git Are the C# bindings there

Re: [libvirt] [libvirt-tck 1/3] Correct typos in documents

2010-10-18 Thread Osier
- Justin Clift jcl...@redhat.com wrote: On 10/18/2010 10:18 AM, Osier Yang wrote: -Notice that since the tst script declared upfront that it intended +Notice that since the test script declared upfront that it intended (missing the is) yup, need danpb's ACK.. :-) - Osier

Re: [libvirt] [PATCH] esx: Handle non-UTF-8 encoded VMX files

2010-10-18 Thread Eric Blake
On 10/16/2010 12:37 PM, Matthias Bolte wrote: ESX(i) uses UTF-8, but a Windows based GSX server writes Windows-1252 encoded VMX files. Add a test case to ensure that libxml2 provides Windows-1252 to UTF-8 conversion. --- + +if (result == NULL) { +virReportOOMError(); +

Re: [libvirt] [PATCH] esx: Handle non-UTF-8 encoded VMX files

2010-10-18 Thread Laine Stump
On 10/18/2010 11:22 AM, Eric Blake wrote: On 10/16/2010 12:37 PM, Matthias Bolte wrote: ESX(i) uses UTF-8, but a Windows based GSX server writes Windows-1252 encoded VMX files. Add a test case to ensure that libxml2 provides Windows-1252 to UTF-8 conversion. --- + +if (result == NULL)

[libvirt] [PATCH] qemu: let qemu group look below /var/lib/libvirt/qemu/

2010-10-18 Thread Eric Blake
From: Dan Kenigsberg dan...@redhat.com Vdsm needs to communicate with its guest agent via unix domain socket, which qemu creates due to the following domain xml device: channel type='unix' target type='virtio' name='com.redhat.rhevm.vdsm'/ source mode='bind'

Re: [libvirt] [PATCH] esx: Handle non-UTF-8 encoded VMX files

2010-10-18 Thread Eric Blake
On 10/18/2010 10:22 AM, Laine Stump wrote: + + if (result == NULL) { + virReportOOMError(); + goto cleanup; + } + + cleanup: Is that last goto necessary, since the label is reached next anyways? Maybe this is a defensive goto, assuming that someday someone may add extra code after that if

Re: [libvirt] [libvirt-tck 1/3] Correct typos in documents

2010-10-18 Thread Daniel P. Berrange
On Mon, Oct 18, 2010 at 07:18:07AM +0800, Osier Yang wrote: * docs/intro.pod * docs/writing-tests.pod --- docs/intro.pod | 10 +- docs/writing-tests.pod |8 2 files changed, 9 insertions(+), 9 deletions(-) ACK Daniel -- |: Red Hat, Engineering, London

Re: [libvirt] [PATCH] qemu: let qemu group look below /var/lib/libvirt/qemu/

2010-10-18 Thread Eric Blake
On 10/18/2010 10:24 AM, Eric Blake wrote: From: Dan Kenigsbergdan...@redhat.com Due to other (storage) reasons, vdsm is to join the qemu group. With this patch, vdsm can look below /var/lib/libvirt/qemu and connect to the socket. +++ b/libvirt.spec.in @@ -782,8 +782,8 @@ fi %if %{with_qemu}

Re: [libvirt] [libvirt-tck 2/3] Add module for hooks testing

2010-10-18 Thread Daniel P. Berrange
On Mon, Oct 18, 2010 at 07:18:08AM +0800, Osier Yang wrote: To test daemon, qemu, lxc hook. * lib/Sys/Virt/TCK/Hooks.pm --- lib/Sys/Virt/TCK/Hooks.pm | 262 + 1 files changed, 262 insertions(+), 0 deletions(-) create mode 100644

Re: [libvirt] [libvirt-tck 3/3] Add test case for daemon hook testing

2010-10-18 Thread Daniel P. Berrange
On Mon, Oct 18, 2010 at 07:18:09AM +0800, Osier Yang wrote: Validate daemon hook is invocated correctly while start, restart, stop, reload libvirtd --- scripts/hooks/051-daemon-hook.t | 156 +++ 1 files changed, 156 insertions(+), 0 deletions(-)

Re: [libvirt] C# bindings (Was: First patch)

2010-10-18 Thread Justin Clift
On 10/19/2010 02:29 AM, arnaud.champ...@devatom.fr wrote: ?Hi justin, here is a xls that I use to keep advance of bindings. Nice. :) Converted it into HTML, for adding to the libvirt documentation. Here is what it looks like: http://justinclift.fedorapeople.org/csharp/csharp.html Does

Re: [libvirt] process= support for 'qemu-kvm -name' [Bug 576950]

2010-10-18 Thread Daniel P. Berrange
On Mon, Oct 18, 2010 at 01:45:12PM -0400, John Morrissey wrote: [plowing through a stack of small patches that i've been neglecting... sorry for the delay.] On Tue, Mar 30, 2010 at 03:05:06PM +0100, Daniel P. Berrange wrote: On Sun, Mar 28, 2010 at 10:19:51PM -0400, John Morrissey wrote:

Re: [libvirt] process= support for 'qemu-kvm -name' [Bug 576950]

2010-10-18 Thread John Morrissey
[plowing through a stack of small patches that i've been neglecting... sorry for the delay.] On Tue, Mar 30, 2010 at 03:05:06PM +0100, Daniel P. Berrange wrote: On Sun, Mar 28, 2010 at 10:19:51PM -0400, John Morrissey wrote: I wrote (attached here, and to the bug) a quick patch that sets the

Re: [libvirt] C# bindings (Was: First patch)

2010-10-18 Thread arnaud.champion
?Wow it's very nice :) Just one thing you had to know, I plan to add sample code of using libvirt bindings, so in the future, I will add a column to indicate the sample code snippet for each function et bindings. Arnaud -- From: Justin Clift

Re: [libvirt] C# bindings (Was: First patch)

2010-10-18 Thread arnaud.champion
?Whoops, just a little thing, there coverage table show only types, there is another tab in the excel that show function coverage. -- From: arnaud.champ...@devatom.fr Sent: Monday, October 18, 2010 8:13 PM To: Justin Clift jcl...@redhat.com Cc:

Re: [libvirt] C# bindings (Was: First patch)

2010-10-18 Thread Justin Clift
On 10/19/2010 05:13 AM, arnaud.champ...@devatom.fr wrote: ?Wow it's very nice :) Just one thing you had to know, I plan to add sample code of using libvirt bindings, so in the future, I will add a column to indicate the sample code snippet for each function et bindings. That sounds like a

Re: [libvirt] C# bindings (Was: First patch)

2010-10-18 Thread Daniel Veillard
On Tue, Oct 19, 2010 at 04:21:19AM +1100, Justin Clift wrote: On 10/19/2010 02:29 AM, arnaud.champ...@devatom.fr wrote: ?Hi justin, here is a xls that I use to keep advance of bindings. Nice. :) Converted it into HTML, for adding to the libvirt documentation. Here is what it looks

[libvirt] [PATCH] docs: added initial page for c# binding, with links to it

2010-10-18 Thread Justin Clift
--- docs/bindings.html.in |2 +- docs/csharp.html.in | 128 + docs/sitemap.html.in |4 ++ 3 files changed, 133 insertions(+), 1 deletions(-) create mode 100644 docs/csharp.html.in diff --git a/docs/bindings.html.in

Re: [libvirt] C# bindings (Was: First patch)

2010-10-18 Thread arnaud.champion
?In fact, yes. The current content is a Visual Studio solution/project architecture, tested only with windows .Net, not Mono. Also it's an evidence but bindings require the libvirt binary, in the .Net case the libvirt-0.dll which is the result of the compilation of libvirt for windows. Maybe

Re: [libvirt] [PATCH] docs: added initial page for c# binding, with links to it

2010-10-18 Thread Justin Clift
On 10/19/2010 06:03 AM, Justin Clift wrote: --- docs/bindings.html.in |2 +- docs/csharp.html.in | 128 + docs/sitemap.html.in |4 ++ 3 files changed, 133 insertions(+), 1 deletions(-) create mode 100644 docs/csharp.html.in

Re: [libvirt] process= support for 'qemu-kvm -name' [Bug 576950]

2010-10-18 Thread John Morrissey
On Mon, Oct 18, 2010 at 06:58:34PM +0100, Daniel P. Berrange wrote: On Mon, Oct 18, 2010 at 01:45:12PM -0400, John Morrissey wrote: Unfortunately, qemu uses prctl() to set the process title, which has a limit of 16 characters. How about qemu:$VM_NAME for the process title (attached), so we

Re: [libvirt] [libvirt-tck 2/3] Add module for hooks testing

2010-10-18 Thread Osier
- Daniel P. Berrange berra...@redhat.com wrote: On Mon, Oct 18, 2010 at 07:18:08AM +0800, Osier Yang wrote: To test daemon, qemu, lxc hook. * lib/Sys/Virt/TCK/Hooks.pm --- lib/Sys/Virt/TCK/Hooks.pm | 262 + 1 files changed, 262