[libvirt] Html docs for win32 build?

2011-02-14 Thread Justin Clift
Hi Matthias, Thinking we should include the generated html docs in the win32 installer. Any thoughts/objections? Also, thinking that if we do, it shouldn't be too hard to install the xhtml1-dtds and use them during the libvirt compile process. As a quick test, since I'd already worked out the

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Jiri Denemark
Hi, Just a reminder that we are in feature freeze for 0.8.8, I just uploaded a new candidate version: ftp://libvirt.org/libvirt/libvirt-0.8.8-rc2.tar.gz Shouldn't this kind of messages be cross-posted to libvirt-announce? I believe that was the reason for creating that list :-) Also it

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Justin Clift
On 14/02/2011, at 3:22 PM, Daniel Veillard wrote: snip it does fix the error messages I had on linux configure, but I'm not sure the issues on Win32 and OS-X are all sorted out yet, so please check. Still broken on OSX. :( I'll try and take a look at it properly sometime today. The

[libvirt] [PATCH] Fix cleanup on VM state after failed QEMU startup

2011-02-14 Thread Daniel P. Berrange
Commit 9962e406c664ed5521f5aca500c860a331cb3979 introduced a problem where if the VM failed to startup, it would not be correctly cleaned up. Amongst other things the SELinux security label would not be removed, which prevents the VM from ever starting again. The virDomainIsActive() check at the

Re: [libvirt] [PATCH 2/8] fix OOM handling in hash.c

2011-02-14 Thread Christophe Fergeau
2011/2/14 Daniel Veillard veill...@redhat.com:  Okay, I commited that one, there was just a lack of declaration for new_name in virHashUpdateEntry Ooops , sorry for that. Christophe -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Matthias Bolte
2011/2/14 Daniel Veillard veill...@redhat.com:  Just a reminder that we are in feature freeze for 0.8.8, I just uploaded a new candidate version:  ftp://libvirt.org/libvirt/libvirt-0.8.8-rc2.tar.gz it does fix the error messages I had on linux configure, but I'm not sure the issues on

Re: [libvirt] [PATCH] Fix cleanup on VM state after failed QEMU startup

2011-02-14 Thread Wen Congyang
At 02/14/2011 05:38 PM, Daniel P. Berrange Write: Commit 9962e406c664ed5521f5aca500c860a331cb3979 introduced a problem where if the VM failed to startup, it would not be correctly cleaned up. Amongst other things the SELinux security label would not be removed, which prevents the VM from ever

Re: [libvirt] [PATCH] Fix cleanup on VM state after failed QEMU startup

2011-02-14 Thread Daniel P. Berrange
On Mon, Feb 14, 2011 at 06:01:49PM +0800, Wen Congyang wrote: At 02/14/2011 05:38 PM, Daniel P. Berrange Write: Commit 9962e406c664ed5521f5aca500c860a331cb3979 introduced a problem where if the VM failed to startup, it would not be correctly cleaned up. Amongst other things the SELinux

Re: [libvirt] [PATCH 0/3] Basic libxenlight driver

2011-02-14 Thread Markus Gross
Jim Fehlig wrote: Jim Fehlig wrote: Markus Groß wrote: 2. The driver supports libvirtxml - xen-xm conversion, thanks to the unified xen driver which already offered this functionality. But since this driver is not part of xen unified, I had to copy this functionality, rather than

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Justin Clift
On 14/02/2011, at 8:15 PM, Justin Clift wrote: On 14/02/2011, at 3:22 PM, Daniel Veillard wrote: snip it does fix the error messages I had on linux configure, but I'm not sure the issues on Win32 and OS-X are all sorted out yet, so please check. Still broken on OSX. :( Found the commit

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Daniel P. Berrange
On Mon, Feb 14, 2011 at 09:46:01PM +1100, Justin Clift wrote: On 14/02/2011, at 8:15 PM, Justin Clift wrote: On 14/02/2011, at 3:22 PM, Daniel Veillard wrote: snip it does fix the error messages I had on linux configure, but I'm not sure the issues on Win32 and OS-X are all sorted out

[libvirt] [PATCH] libvirt-qemu: Fix enum type declaration

2011-02-14 Thread Jiri Denemark
--- Ugh! Sorry for this stupid typo. include/libvirt/libvirt-qemu.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/libvirt/libvirt-qemu.h b/include/libvirt/libvirt-qemu.h index 9257c2f..f172eff 100644 --- a/include/libvirt/libvirt-qemu.h +++

[libvirt] [PATCH] conf: Fix XMl generation for smartcards

2011-02-14 Thread Jiri Denemark
When formating XML for smartcard device with mode=host, libvirt generates invalid XML if the device has address info associated: smartcard mode='host' address type='ccid' controller='0' slot='1'/ --- src/conf/domain_conf.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[libvirt] [PATCH] osx: fix broken enum typedef declaration breaking compilation on osx

2011-02-14 Thread Justin Clift
As pointed out by Daniel Berrange, this broken enum declaration was the cause of duplicate symbol _virDomainQemuMonitorCommandFlags ... errors on OSX. --- include/libvirt/libvirt-qemu.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/libvirt/libvirt-qemu.h

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Justin Clift
On 14/02/2011, at 9:58 PM, Daniel P. Berrange wrote: It is a broken enum declaration in the header libvirt-qemu.h: enum { VIR_DOMAIN_QEMU_MONITOR_COMMAND_DEFAULT = 0, VIR_DOMAIN_QEMU_MONITOR_COMMAND_HMP = (1 0), /* cmd is in HMP */ } virDomainQemuMonitorCommandFlags; There

Re: [libvirt] [PATCH] libvirt-qemu: Fix enum type declaration

2011-02-14 Thread Justin Clift
On 14/02/2011, at 10:19 PM, Jiri Denemark wrote: --- Ugh! Sorry for this stupid typo. include/libvirt/libvirt-qemu.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/libvirt/libvirt-qemu.h b/include/libvirt/libvirt-qemu.h index 9257c2f..f172eff 100644 ---

Re: [libvirt] [PATCH] osx: fix broken enum typedef declaration breaking compilation on osx

2011-02-14 Thread Justin Clift
On 14/02/2011, at 10:26 PM, Justin Clift wrote: As pointed out by Daniel Berrange, this broken enum declaration was the cause of duplicate symbol _virDomainQemuMonitorCommandFlags ... errors on OSX. --- include/libvirt/libvirt-qemu.h |2 +- 1 files changed, 1 insertions(+), 1

Re: [libvirt] [PATCH] libvirt-qemu: Fix enum type declaration

2011-02-14 Thread Jiri Denemark
On Mon, Feb 14, 2011 at 22:31:18 +1100, Justin Clift wrote: On 14/02/2011, at 10:19 PM, Jiri Denemark wrote: --- a/include/libvirt/libvirt-qemu.h +++ b/include/libvirt/libvirt-qemu.h @@ -20,7 +20,7 @@ extern C { # endif -enum { +typedef enum {

Re: [libvirt] [Xen-devel] [PATCH] libxenlight driver

2011-02-14 Thread Stefano Stabellini
On Mon, 14 Feb 2011, Jim Fehlig wrote: Hi All, Here's a first cut of libxenlight driver for libvirt. The driver is stateful and provides functionality for managed (persistent) domains. The driver only maintains state for and manages domains under its control, ignoring domains created by

[libvirt] Strange periodic failures of the commandtest case

2011-02-14 Thread Daniel P. Berrange
I'm getting periodic failures of the 'commandtest' case where the diff is DAEMON:no -- DAEMON:yes For test cases 'test3' through to 'test15', except 'test'4. Tests 1, 2, 4, 16, 17, 18 are all unaffected. I can never reproduce it when I run just that one test case manually, but the automated

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Daniel Veillard
On Mon, Feb 14, 2011 at 10:13:08AM +0100, Jiri Denemark wrote: Hi, Just a reminder that we are in feature freeze for 0.8.8, I just uploaded a new candidate version: ftp://libvirt.org/libvirt/libvirt-0.8.8-rc2.tar.gz Shouldn't this kind of messages be cross-posted to

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Daniel Veillard
On Mon, Feb 14, 2011 at 10:30:13PM +1100, Justin Clift wrote: On 14/02/2011, at 9:58 PM, Daniel P. Berrange wrote: It is a broken enum declaration in the header libvirt-qemu.h: never underestimate the power of being multi platform in chasing weird bugs ! enum {

Re: [libvirt] [PATCH] Fix cleanup on VM state after failed QEMU startup

2011-02-14 Thread Daniel Veillard
On Mon, Feb 14, 2011 at 09:38:37AM +, Daniel P. Berrange wrote: Commit 9962e406c664ed5521f5aca500c860a331cb3979 introduced a problem where if the VM failed to startup, it would not be correctly cleaned up. Amongst other things the SELinux security label would not be removed, which prevents

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Jiri Denemark
On Mon, Feb 14, 2011 at 20:36:24 +0800, Daniel Veillard wrote: If you know how to configure mailman to make the list moderated, I'm all ears ... you may even win moderator status :-) Heh, to be honest, I've never setup any mailing list so I don't have a foggiest glue how to configure it that

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Diego Elio Pettenò
Il giorno lun, 14/02/2011 alle 12.22 +0800, Daniel Veillard ha scritto: Just a reminder that we are in feature freeze for 0.8.8, I just uploaded a new candidate version: All green in Gentoo, even tests working without workarounds this time! Thanks! -- Diego Elio Pettenò — Flameeyes

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Justin Clift
On 14/02/2011, at 11:53 PM, Jiri Denemark wrote: On Mon, Feb 14, 2011 at 20:36:24 +0800, Daniel Veillard wrote: If you know how to configure mailman to make the list moderated, I'm all ears ... you may even win moderator status :-) Heh, to be honest, I've never setup any mailing list so I

Re: [libvirt] Strange periodic failures of the commandtest case

2011-02-14 Thread Daniel P. Berrange
On Mon, Feb 14, 2011 at 12:32:18PM +, Daniel P. Berrange wrote: I'm getting periodic failures of the 'commandtest' case where the diff is DAEMON:no -- DAEMON:yes For test cases 'test3' through to 'test15', except 'test'4. Tests 1, 2, 4, 16, 17, 18 are all unaffected. I can never

[libvirt] [PATCH] storage: Create enough volumes for mpath pool

2011-02-14 Thread Osier Yang
virStorageBackendCreateVols: names-next serves as condition expression for do...while, however, names was shifted before, it then results in one less loop, and thus, one less volume will be created for mpath pool, the patch is to fix it. * src/storage/storage_backend_mpath.c ---

[libvirt] [PATCH] nwfilter: reorder match extensions relative to state match

2011-02-14 Thread Stefan Berger
This patch reorders the connlimit and comment match extensions relative to the state match (-m state); connlimit being most useful if found after a -m state --state NEW and not before it. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/nwfilter/nwfilter_ebiptables_driver.c |

[libvirt] [TCK] [PATCH] follow reordering of match extensions relative to state match

2011-02-14 Thread Stefan Berger
This patch adjusts the tck test cases following the reordering of the match extensions relative to the state match in libvirt. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- scripts/nwfilter/nwfilterxml2fwallout/comment-test.fwall | 30 +++

Re: [libvirt] [PATCH 1/2] Get cpuMhz of virNodeGetInfo() from cpufreq/cpuinfo_max_freq, if exist

2011-02-14 Thread Eric Blake
On 02/13/2011 06:08 PM, Minoru Usui wrote: So with rounding up request and truncating reports we are on the safe side in both cases. Matthias I agree with you. In this case we are reporting cpu MHz, so we should truncate it. Eric, what do you think? Truncation works for me. I think

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Zdenek Styblik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/14/11 05:22, Daniel Veillard wrote: Just a reminder that we are in feature freeze for 0.8.8, I just uploaded a new candidate version: ftp://libvirt.org/libvirt/libvirt-0.8.8-rc2.tar.gz it does fix the error messages I had on linux

Re: [libvirt] [PATCH v3] storage: Allow to delete device mapper disk partition

2011-02-14 Thread Eric Blake
On 02/12/2011 12:36 AM, Osier Yang wrote: The name convention of device mapper disk is different, and 'parted' can't be used to delete a device mapper disk partition. e.g. Name Path - 3600a0b80005ad1d793604cae912fp1

Re: [libvirt] [PATCH] docs: added link for nimbus to apps page

2011-02-14 Thread Matthias Bolte
2011/2/14 Justin Clift jcl...@redhat.com: On 15/02/2011, at 2:25 AM, Matthias Bolte wrote: snip While you're at it you could also list OpenStack Compute, OpenNebula and Eucalyptus here :) Yeah, I was kind of thinking that for OpenNebula, but haven't looked into the others enough yet to

Re: [libvirt] [PATCH] conf: Fix XMl generation for smartcards

2011-02-14 Thread Eric Blake
On 02/14/2011 04:18 AM, Jiri Denemark wrote: When formating XML for smartcard device with mode=host, libvirt s/formating/formatting/ generates invalid XML if the device has address info associated: smartcard mode='host' address type='ccid' controller='0' slot='1'/ ---

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Matthias Bolte
2011/2/14 Zdenek Styblik sty...@turnovfree.net: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/14/11 05:22, Daniel Veillard wrote:   Just a reminder that we are in feature freeze for 0.8.8, I just uploaded a new candidate version:   ftp://libvirt.org/libvirt/libvirt-0.8.8-rc2.tar.gz

Re: [libvirt] Strange periodic failures of the commandtest case

2011-02-14 Thread Eric Blake
On 02/14/2011 06:45 AM, Daniel P. Berrange wrote: On Mon, Feb 14, 2011 at 12:32:18PM +, Daniel P. Berrange wrote: I'm getting periodic failures of the 'commandtest' case where the diff is DAEMON:no -- DAEMON:yes For test cases 'test3' through to 'test15', except 'test'4. Tests 1, 2,

Re: [libvirt] [PATCH] storage: Create enough volumes for mpath pool

2011-02-14 Thread Eric Blake
On 02/14/2011 06:48 AM, Osier Yang wrote: virStorageBackendCreateVols: names-next serves as condition expression for do...while, however, names was shifted before, it then results in one less loop, and thus, one less volume will be created for mpath pool, the patch is to fix it. @@

Re: [libvirt] [PATCH] nwfilter: reorder match extensions relative to state match

2011-02-14 Thread Eric Blake
On 02/14/2011 08:07 AM, Stefan Berger wrote: This patch reorders the connlimit and comment match extensions relative to the state match (-m state); connlimit being most useful if found after a -m state --state NEW and not before it. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com

Re: [libvirt] [TCK] [PATCH] follow reordering of match extensions relative to state match

2011-02-14 Thread Eric Blake
On 02/14/2011 08:09 AM, Stefan Berger wrote: This patch adjusts the tck test cases following the reordering of the match extensions relative to the state match in libvirt. -RETURN udp -- 0.0.0.0/010.1.2.3MAC 01:02:03:04:05:06 DSCP match 0x22/* udp rule */ udp

Re: [libvirt] [PATCH] docs: added link for nimbus to apps page

2011-02-14 Thread Eric Blake
On 02/14/2011 08:25 AM, Matthias Bolte wrote: 2011/2/14 Justin Clift jcl...@redhat.com: --- docs/apps.html.in | 12 1 files changed, 12 insertions(+), 0 deletions(-) +h2a name=iaasInfrastructure as a Service (IaaS)/a/h2 + +dl + dta

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Daniel P. Berrange
On Mon, Feb 14, 2011 at 06:07:59PM +0100, Zdenek Styblik wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/14/11 17:35, Matthias Bolte wrote: [...] Could you run make V=1 to get the full command line that produces this error? Either libvirt itself or some other library

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Zdenek Styblik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/14/11 18:15, Daniel P. Berrange wrote: [...] What does the following print # pcap-config --cflags --libs If it includes a space, then pcap-config needs to be fixed Regards, Daniel # pcap-config --cflags --libs - -I

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available

2011-02-14 Thread Matthias Bolte
2011/2/14 Zdenek Styblik sty...@turnovfree.net: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/14/11 18:15, Daniel P. Berrange wrote: [...] What does the following print    # pcap-config --cflags --libs If it includes a space, then pcap-config needs to be fixed Regards, Daniel

Re: [libvirt] [PATCH] conf: Fix XMl generation for smartcards

2011-02-14 Thread Jiri Denemark
On Mon, Feb 14, 2011 at 09:31:49 -0700, Eric Blake wrote: On 02/14/2011 04:18 AM, Jiri Denemark wrote: When formating XML for smartcard device with mode=host, libvirt s/formating/formatting/ generates invalid XML if the device has address info associated: smartcard mode='host'

Re: [libvirt] [TCK] [PATCH] follow reordering of match extensions relative to state match

2011-02-14 Thread Stefan Berger
On 02/14/2011 11:44 AM, Eric Blake wrote: On 02/14/2011 08:09 AM, Stefan Berger wrote: This patch adjusts the tck test cases following the reordering of the match extensions relative to the state match in libvirt. -RETURN udp -- 0.0.0.0/010.1.2.3MAC

Re: [libvirt] [PATCH] nwfilter: reorder match extensions relative to state match

2011-02-14 Thread Stefan Berger
On 02/14/2011 11:42 AM, Eric Blake wrote: On 02/14/2011 08:07 AM, Stefan Berger wrote: This patch reorders the connlimit and comment match extensions relative to the state match (-m state); connlimit being most useful if found after a -m state --state NEW and not before it. Signed-off-by:

[libvirt] [PATCH] macvtap: Work-around failing nl_connect calls (weird problem)

2011-02-14 Thread Stefan Berger
When trying to start / stop a domain with macvtap device (direct type of interface) having a device description like this one here interface type='direct' source dev='static' mode='vepa'/ /interface then I see netlink related errors when a 'virsh edit' session is happening at the same time.

Re: [libvirt] [PATCH] macvtap: Work-around failing nl_connect calls (weird problem)

2011-02-14 Thread Daniel P. Berrange
On Mon, Feb 14, 2011 at 02:34:28PM -0500, Stefan Berger wrote: When trying to start / stop a domain with macvtap device (direct type of interface) having a device description like this one here interface type='direct' source dev='static' mode='vepa'/ /interface then I see netlink related

[libvirt] [PATCH] qemu: ignore failure of qemu -M ? on older qemu

2011-02-14 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=676563 Regression introduced in commit 2211518. * src/qemu/qemu_capabilities.c (qemuCapsProbeMachineTypes): Allow non-zero exit status. --- src/qemu/qemu_capabilities.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] macvtap: Work-around failing nl_connect calls (weird problem)

2011-02-14 Thread Stefan Berger
On 02/14/2011 02:51 PM, Daniel P. Berrange wrote: This approach feels like a nasty hack to me and potentially still leaves us with a problem in netcf which is also using netlink sockets. I think we need to get a clearer picture of what the root cause is before going for this kind of patch

[libvirt] [PATCH] xml: avoid compiler warning

2011-02-14 Thread Eric Blake
Detected by clang. * src/util/xml.c (virXPathStringLimit): Use %zd, not obsolete %Zd. --- Pushing under the trivial rule; just because glibc treats %Zd as a synonym for %zd does not mean other platforms do likewise, nor that gettext() gracefully handles it. src/util/xml.c |2 +- 1 files

[libvirt] [PATCH] build: silence false positive clang report

2011-02-14 Thread Eric Blake
clang complained that STREQ(group-controllers[i].mountPoint,...) was a NULL dereference when i==VIR_CGROUP_CONTROLLER_CPUSET, because it assumes the worst about virCgroupPathOfController. Marking the argument const doesn't yet have an effect, per this clang bug:

Re: [libvirt] [PATCH] build: silence false positive clang report

2011-02-14 Thread Laine Stump
On 02/14/2011 04:37 PM, Eric Blake wrote: clang complained that STREQ(group-controllers[i].mountPoint,...) was a NULL dereference when i==VIR_CGROUP_CONTROLLER_CPUSET, because it assumes the worst about virCgroupPathOfController. Marking the argument const doesn't yet have an effect, per this

Re: [libvirt] [PATCH] macvtap: Work-around failing nl_connect calls (weird problem)

2011-02-14 Thread Stefan Berger
On 02/14/2011 03:30 PM, Stefan Berger wrote: On 02/14/2011 02:51 PM, Daniel P. Berrange wrote: This approach feels like a nasty hack to me and potentially still leaves us with a problem in netcf which is also using netlink sockets. I think we need to get a clearer picture of what the root

[libvirt] [PATCH] build: address clang reports about virCommand

2011-02-14 Thread Eric Blake
clang had 5 reports against virCommand; three were false positives (a NULL deref in ProcessIO solved by sa_assert, and two uninitialized memory operations solved by adding an initializer), but two were real. * src/util/command.c (virCommandProcessIO): Fix real bug of possible NULL dereference.

Re: [libvirt] [PATCH] qemu: ignore failure of qemu -M ? on older qemu

2011-02-14 Thread Eric Blake
On 02/14/2011 03:06 PM, Laine Stump wrote: On 02/14/2011 03:02 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=676563 Regression introduced in commit 2211518. * src/qemu/qemu_capabilities.c (qemuCapsProbeMachineTypes): Allow non-zero exit status. -if

[libvirt] [PATCH] qemu: avoid NULL derefs

2011-02-14 Thread Eric Blake
The processWatchdogEvent fix is real, although it can only trigger on OOM, since bad things happen if doCoreDump is called with a NULL pathname argument. The other fixes silence clang, but aren't a real bug because virReportErrorHelper tolerates a NULL format string even though *printf does not.

[libvirt] [PATCH] qemu: avoid NULL deref on error

2011-02-14 Thread Eric Blake
* src/qemu/qemu_command.c (qemuParseCommandLineDisk): Report error before cleaning def. --- Pushing under the trivial rule, as this is a blatant NULL deref. src/qemu/qemu_command.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c

[libvirt] [PATCH] maint: kill dead assignments

2011-02-14 Thread Eric Blake
* src/network/bridge_driver.c (networkStartNetworkDaemon): Delete unused assignments. --- Detected by clang. Pushing under the trivial rule, as it's pretty easy to see. src/network/bridge_driver.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [libvirt] [PATCH] virDomainMemoryStats: avoid null dereference

2011-02-14 Thread Laine Stump
On 02/14/2011 06:25 PM, Eric Blake wrote: * src/libvirt.c (virDomainMemoryStats): Check domain before flags. --- Another valid bug found by clang. User's generally should't call virDomainMemoryStats(NULL,...), but we don't forbid it elsewhere, and doing so is not supposed to crash libvirt.

[libvirt] libvirt 0.8.7 tests failure on arm and ppc

2011-02-14 Thread Serge E. Hallyn
Hi, as per the message after the tests fail, I'm reporting this on the list. Hopefully someone has seen this before. I've not yet tried this with the latest git snapshot. With 0.8.7, I get: TEST: qemuxml2argvtest

Re: [libvirt] [PATCH v3] storage: Allow to delete device mapper disk partition

2011-02-14 Thread Osier Yang
于 2011年02月15日 00:27, Eric Blake 写道: On 02/12/2011 12:36 AM, Osier Yang wrote: The name convention of device mapper disk is different, and 'parted' can't be used to delete a device mapper disk partition. e.g. Name Path -

Re: [libvirt] [PATCH] storage: Create enough volumes for mpath pool

2011-02-14 Thread Osier Yang
于 2011年02月15日 00:40, Eric Blake 写道: On 02/14/2011 06:48 AM, Osier Yang wrote: virStorageBackendCreateVols: names-next serves as condition expression for do...while, however, names was shifted before, it then results in one less loop, and thus, one less volume will be created for mpath pool,

Re: [libvirt] [PATCH 5/8] call virReportOOMError when appropriate in hash.c

2011-02-14 Thread Daniel Veillard
On Sun, Feb 13, 2011 at 10:45:21PM +0100, Christophe Fergeau wrote: --- src/util/hash.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) ACK, and pushed as it's something I would like to get for 0.8.8, thanks ! Daniel -- Daniel Veillard | libxml Gnome

Re: [libvirt] [PATCH 8/8] add missing error handling to virGetDomain

2011-02-14 Thread Daniel Veillard
On Sun, Feb 13, 2011 at 10:45:24PM +0100, Christophe Fergeau wrote: When creating the virDomain::snapshots hash table, virGetDomain wasn't checking if the creation was successful. This would then lead to failures in the vir*DomainSnapshot functions. Better to report this error early and make

Re: [libvirt] [PATCH] docs: added link for nimbus to apps page

2011-02-14 Thread Daniel Veillard
On Mon, Feb 14, 2011 at 09:47:32AM -0700, Eric Blake wrote: On 02/14/2011 08:25 AM, Matthias Bolte wrote: 2011/2/14 Justin Clift jcl...@redhat.com: --- docs/apps.html.in | 12 1 files changed, 12 insertions(+), 0 deletions(-) +h2a name=iaasInfrastructure as a

Re: [libvirt] [PATCH] qemu: avoid NULL derefs

2011-02-14 Thread Daniel Veillard
On Mon, Feb 14, 2011 at 04:59:39PM -0700, Eric Blake wrote: The processWatchdogEvent fix is real, although it can only trigger on OOM, since bad things happen if doCoreDump is called with a NULL pathname argument. The other fixes silence clang, but aren't a real bug because

Re: [libvirt] [PATCH] qemu: avoid NULL deref on error

2011-02-14 Thread Daniel Veillard
On Mon, Feb 14, 2011 at 05:34:54PM -0700, Eric Blake wrote: * src/qemu/qemu_command.c (qemuParseCommandLineDisk): Report error before cleaning def. --- Pushing under the trivial rule, as this is a blatant NULL deref. src/qemu/qemu_command.c |5 +++-- 1 files changed, 3

[libvirt] Still in freeze, third rc tarball available

2011-02-14 Thread Daniel Veillard
Thanks everybody for the testing feedback and fixes, in retrospect I should really had done this in previous releases ! So the third rc tarball is out, it's likely to be the last one before the release (within 48 hours): ftp://libvirt.org/libvirt/libvirt-0.8.8-rc3.tar.gz give it a try !

[libvirt] Mails rejected by mailist?

2011-02-14 Thread Lyre
Hi all: I've tried to send a patch for libvirt-php using git send-email yesterday. My user.email is configured as a gmail address, that is this one. But git sent patches from local postfix. git CC the patchs to my gmail and I can revice it, but not listed on the maillist. Is it rejected by

Re: [libvirt] Mails rejected by mailist?

2011-02-14 Thread Daniel Veillard
On Tue, Feb 15, 2011 at 11:36:44AM +0800, Lyre wrote: Hi all: I've tried to send a patch for libvirt-php using git send-email yesterday. My user.email is configured as a gmail address, that is this one. But git sent patches from local postfix. git CC the patchs to my gmail and I can

Re: [libvirt] [PATCH] macvtap: Work-around failing nl_connect calls (weird problem)

2011-02-14 Thread Stefan Berger
On 02/14/2011 05:22 PM, Stefan Berger wrote: On 02/14/2011 03:30 PM, Stefan Berger wrote: On 02/14/2011 02:51 PM, Daniel P. Berrange wrote: This approach feels like a nasty hack to me and potentially still leaves us with a problem in netcf which is also using netlink sockets. I think we

Re: [libvirt] Mails rejected by mailist?

2011-02-14 Thread Lyre
On Tue, Feb 15, 2011 at 12:05 PM, Daniel Veillard veill...@redhat.comwrote: On Tue, Feb 15, 2011 at 11:36:44AM +0800, Lyre wrote: Hi all: I've tried to send a patch for libvirt-php using git send-email yesterday. My user.email is configured as a gmail address, that is this one. But

Re: [libvirt] Mails rejected by mailist?

2011-02-14 Thread Osier Yang
于 2011年02月15日 12:05, Daniel Veillard 写道: On Tue, Feb 15, 2011 at 11:36:44AM +0800, Lyre wrote: Hi all: I've tried to send a patch for libvirt-php using git send-email yesterday. My user.email is configured as a gmail address, that is this one. But git sent patches from local postfix. git CC

Re: [libvirt] Still in freeze, third rc tarball available

2011-02-14 Thread Osier Yang
于 2011年02月15日 11:32, Daniel Veillard 写道: Thanks everybody for the testing feedback and fixes, in retrospect I should really had done this in previous releases ! So the third rc tarball is out, it's likely to be the last one before the release (within 48 hours):

[libvirt] [libvirt-php 2/2] Added libvirt-php.obs.spec

2011-02-14 Thread Lyre
* libvirt-php.obs.spec: this file should works for Fedora 14, openSuSE 11.3, and SLES 11 SP1 on openSuSE Build Service or localhost. * Makefile.am: added EXTRA_DIST = libvirt-php.obs.spec --- Makefile.am |2 + aclocal.m4 |4 +- libvirt-php.obs.spec | 80

[libvirt] [libvirt-php 0/2] Updated building system

2011-02-14 Thread Lyre
Fixed the install location of libvirt-php.ini; Added an spec file for openSuSE Build Service. Lyre (2): Fixed the php configuration file Added libvirt-php.obs.spec Makefile.am |2 + aclocal.m4 |4 +- libvirt-php.obs.spec | 80

[libvirt] [libvirt-php 1/2] Fixed the php configuration file

2011-02-14 Thread Lyre
Install the libvirt-php.ini to a appropriate location. * src/Makefile.am: Set $PHPCDIR to the php configuration file directory, and replace $sysconfdir/php.d with $PHPCDIR. Added suffix .so in libvirt-php.ini. --- src/Makefile.am |7 --- 1 files changed, 4 insertions(+), 3