[libvirt] [libvirt-php 1/2] spec file cleanup

2011-02-18 Thread Lyre
From: Lyre 417...@gmail.com * libvirt-php.spec: removed unnecessary macro 0{%sles_version} --- libvirt-php.spec |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libvirt-php.spec b/libvirt-php.spec index 2c6292e..51a9add 100644 --- a/libvirt-php.spec +++

Re: [libvirt] [PATCH] maint: Expand tabs in python code

2011-02-18 Thread Jiri Denemark
On Thu, Feb 17, 2011 at 13:23:52 -0700, Eric Blake wrote: On 02/17/2011 07:34 AM, Jiri Denemark wrote: Also cfg.mk is tweaked to force this for all future changes to *.py files. diff --git a/cfg.mk b/cfg.mk index 4bbeb96..f870723 100644 --- a/cfg.mk +++ b/cfg.mk @@ -327,8 +327,8

Re: [libvirt] [PATCH 0/6 v3] Add blkio cgroup support

2011-02-18 Thread Gui Jianfeng
Dominik Klein wrote: Hi Gui, thanks for your reply. Actually, this two series doesn't care how blkio cgroup works. They just provide the ability to put Guest into given cgroup and tune the tunables. Currently, You can only control the blkio.weight tunable. For examle, If you'd like

Re: [libvirt] [PATCH] check device-mapper when building without storage mpath

2011-02-18 Thread Osier Yang
于 2011年02月18日 11:00, Wen Congyang 写道: When I build libvirt without libvirtd, I receive the following errors: GENvirsh.1 CCLD virsh ../src/.libs/libvirt.so: undefined reference to `dm_is_dm_major' collect2: ld returned 1 exit status make[3]: *** [virsh] Error 1 My build step: #

Re: [libvirt] [PATCH 0/6 v3] Add blkio cgroup support

2011-02-18 Thread Igor Serebryany
On Fri, Feb 18, 2011 at 04:12:28PM +0800, Gui Jianfeng wrote: blkio.weight is used to control the Minimal Maximal Bandwidth. If you'd like to control Max bandwidth to let your guests become I/O hungery. blkio.throttle.* should helps. But these tunables aren't supported by blkiotune for the

Re: [libvirt] [PATCH] check device-mapper when building without storage mpath

2011-02-18 Thread Jiri Denemark
On Fri, Feb 18, 2011 at 16:21:20 +0800, Osier Yang wrote: 于 2011年02月18日 11:00, Wen Congyang 写道: +DEVMAPPER_CFLAGS= +DEVMAPPER_LIBS= +PKG_CHECK_MODULES([DEVMAPPER], [devmapper= $DEVMAPPER_REQUIRED], [], [DEVMAPPER_FOUND=no]) +if test $DEVMAPPER_FOUND = no; then + # devmapper is

Re: [libvirt] [PATCH 0/6 v3] Add blkio cgroup support

2011-02-18 Thread Gui Jianfeng
Dominik Klein wrote: Hmm.. blkio.weight is used to control the Minimal Maximal Bandwidth. If you'd like to control Max bandwidth to let your guests become I/O hungery. blkio.throttle.* should helps. But these tunables aren't supported by blkiotune for the time being. I'm considering to

Re: [libvirt] [libvirt-php 0/2] Another update for building system

2011-02-18 Thread Michal Novotny
On 02/18/2011 08:51 AM, Lyre wrote: Hi all: This patch updeted the building system. * Added necessary checkings in configure.ac * Cleared up libvirt-php.spec and src/Makefile.am BTW, I've changed my email to business address. Noted. Also, reviewed it and it's looking fine so I pushed this

Re: [libvirt] [PATCH 0/6 v3] Add blkio cgroup support

2011-02-18 Thread Dominik Klein
As far as I understand, and as far as I saw during my tests, the blkio controller only works for sync I/O requests (eg dd with oflag=direct). Buffered I/O is not part of the control. Yes, you are right. whew :) And since a VM's I/O is most likely buffered in some fashion, this does not

Re: [libvirt] [PATCH] check device-mapper when building without storage mpath

2011-02-18 Thread Wen Congyang
At 02/18/2011 05:00 PM, Justin Clift Write: On 18/02/2011, at 7:46 PM, Jiri Denemark wrote: snip Thanks for the fix, actually It can be reproduced simply by: % ./autogen.sh --with-storage-mpath=no % make As src/util/util.c invokes dm_is_dm_major. Yes it does, but I'm not convinced this

Re: [libvirt] [PATCH 0/6 v3] Add blkio cgroup support

2011-02-18 Thread Gui Jianfeng
Igor Serebryany wrote: On Fri, Feb 18, 2011 at 04:12:28PM +0800, Gui Jianfeng wrote: blkio.weight is used to control the Minimal Maximal Bandwidth. If you'd like to control Max bandwidth to let your guests become I/O hungery. blkio.throttle.* should helps. But these tunables aren't

Re: [libvirt] [PATCH 0/6 v3] Add blkio cgroup support

2011-02-18 Thread Dominik Klein
Hi I can only comment on some of your questions as I also can't say to understand this completely. Then, blkio.throttle can be used to set actual hard limits on IO consumption -- like, no more than 10Mbps for this VM. I can already do this with blkio cgroups, but just not from libvirt -- yes?

Re: [libvirt] [PATCH] check device-mapper when building without storage mpath

2011-02-18 Thread Wen Congyang
At 02/18/2011 04:46 PM, Jiri Denemark Write: On Fri, Feb 18, 2011 at 16:21:20 +0800, Osier Yang wrote: 于 2011年02月18日 11:00, Wen Congyang 写道: +DEVMAPPER_CFLAGS= +DEVMAPPER_LIBS= +PKG_CHECK_MODULES([DEVMAPPER], [devmapper= $DEVMAPPER_REQUIRED], [], [DEVMAPPER_FOUND=no]) +if test

Re: [libvirt] [PATCH 0/6 v3] Add blkio cgroup support

2011-02-18 Thread Gui Jianfeng
Gui Jianfeng wrote: Igor Serebryany wrote: On Fri, Feb 18, 2011 at 04:12:28PM +0800, Gui Jianfeng wrote: blkio.weight is used to control the Minimal Maximal Bandwidth. If you'd like to control Max bandwidth to let your guests become I/O hungery. blkio.throttle.* should helps. But these

[libvirt] [PATCH] esx: Ignore malformed host UUID from BIOS

2011-02-18 Thread Matthias Bolte
Matthias From 9026348a138962992491fb0eb07526dabd168a80 Mon Sep 17 00:00:00 2001 From: Matthias Bolte matthias.bo...@googlemail.com Date: Fri, 18 Feb 2011 10:09:32 +0100 Subject: [PATCH] esx: Ignore malformed host UUID from BIOS Etienne Gosset reported that libvirt fails to connect to his ESX

Re: [libvirt] [PATCH] build: recompute symbols after changing configure options

2011-02-18 Thread Matthias Bolte
2011/2/17 Eric Blake ebl...@redhat.com: $ ./configure ... $ make ...  GEN    libvirt.syms ... $ ./configure --with-driver-modules ... $ make ... libvirt.syms doesn't get regenerated but it should as it should contain virDriverLoadModule now. * src/Makefile.am (libvirt.syms): Depend

[libvirt] [PATCH] check device-mapper when building with mpath or disk storage driver

2011-02-18 Thread Wen Congyang
When I build libvirt without libvirtd, I receive the following errors: GENvirsh.1 CCLD virsh ../src/.libs/libvirt.so: undefined reference to `dm_is_dm_major' collect2: ld returned 1 exit status make[3]: *** [virsh] Error 1 My build step: # ./autogen.sh --without-libvirtd # make dist #

Re: [libvirt] [PATCH] check device-mapper when building without storage mpath

2011-02-18 Thread Wen Congyang
At 02/18/2011 05:35 PM, Justin Clift Write: On 18/02/2011, at 8:07 PM, Wen Congyang wrote: At 02/18/2011 05:00 PM, Justin Clift Write: On 18/02/2011, at 7:46 PM, Jiri Denemark wrote: snip Thanks for the fix, actually It can be reproduced simply by: % ./autogen.sh --with-storage-mpath=no %

Re: [libvirt] [PATCH v2] Requires gettext for client package

2011-02-18 Thread Daniel P. Berrange
On Thu, Feb 17, 2011 at 05:30:02PM -0700, Eric Blake wrote: On 02/17/2011 01:19 PM, Justin Clift wrote: On 18/02/2011, at 7:12 AM, Eric Blake wrote: snip [note to self - it might be possible to drop the nc dependency in the future, once I finish my conversion from -migration exec: to

Re: [libvirt] [libvirt-php 2/2] Added checkings for tools and libraries

2011-02-18 Thread Daniel P. Berrange
On Fri, Feb 18, 2011 at 03:51:32PM +0800, Lyre wrote: * configure.ac: Added checkings for compiler, sed, install, and so on; Added AM_PATH_XML2 to check libxml2. * src/Makefile.am: dropped needless macros since it is done by autoconf; Use $INSTALL to install files rather than cp. ---

Re: [libvirt] [PATCH] build: improve 'make install' for VPATH builds

2011-02-18 Thread Jiri Denemark
On Thu, Feb 17, 2011 at 15:22:13 -0700, Eric Blake wrote: On 02/17/2011 08:06 AM, Jiri Denemark wrote: I haven't tried that but xsltproc should support -o directory/ My recollection was that it didn't quite work: https://www.redhat.com/archives/libvir-list/2010-June/msg00675.html Quoting

Re: [libvirt] [Xen-devel] [PATCH] libxenlight driver

2011-02-18 Thread Stefano Stabellini
On Fri, 18 Feb 2011, Jim Fehlig wrote: +static int +libxlMakeDiskList(virDomainDefPtr def, libxl_domain_config *d_config) +{ +virDomainDiskDefPtr *l_disks = def-disks; +int ndisks = def-ndisks; +libxl_device_disk *x_disks; +int i; + +if (VIR_ALLOC_N(x_disks, ndisks)

[libvirt] [PATCH] build: Fix API docs generation in VPATH build

2011-02-18 Thread Jiri Denemark
--- docs/Makefile.am | 12 docs/devhelp/devhelp.xsl |7 +++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index adf74ee..c4926d4 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -88,7 +88,10 @@ EXTRA_DIST=

[libvirt] Driver ESX

2011-02-18 Thread Cédric Penas
Hi, I am currently working on a project where I must develop a function to clone domain for the driver ESX. I immediately saw that the function cloneVM_Task () from VMware API was not supported for standalone ESX. Does anyone know the best way to still implement this function or a

[libvirt] [PATCH v3] virsh: freecell --all getting wrong NUMA nodes count

2011-02-18 Thread Michal Privoznik
Virsh freecell --all was not only getting wrong NUMA nodes count, but even the NUMA nodes IDs. They doesn't have to be continuous, as I've found out during testing this. Therefore a modification of nodeGetCellsFreeMemory() error message. --- Hope it's good this time :) src/nodeinfo.c |3 +-

Re: [libvirt] [PATCH] check device-mapper when building without storage mpath

2011-02-18 Thread Osier Yang
于 2011年02月18日 17:00, Justin Clift 写道: On 18/02/2011, at 7:46 PM, Jiri Denemark wrote: snip Thanks for the fix, actually It can be reproduced simply by: % ./autogen.sh --with-storage-mpath=no % make As src/util/util.c invokes dm_is_dm_major. Yes it does, but I'm not convinced this is the

Re: [libvirt] [PATCH] check device-mapper when building without storage mpath

2011-02-18 Thread Osier Yang
于 2011年02月18日 16:46, Jiri Denemark 写道: On Fri, Feb 18, 2011 at 16:21:20 +0800, Osier Yang wrote: 于 2011年02月18日 11:00, Wen Congyang 写道: +DEVMAPPER_CFLAGS= +DEVMAPPER_LIBS= +PKG_CHECK_MODULES([DEVMAPPER], [devmapper= $DEVMAPPER_REQUIRED], [], [DEVMAPPER_FOUND=no]) +if test $DEVMAPPER_FOUND =

Re: [libvirt] [PATCH] check device-mapper when building without storage mpath

2011-02-18 Thread Daniel P. Berrange
On Fri, Feb 18, 2011 at 08:00:34PM +1100, Justin Clift wrote: On 18/02/2011, at 7:46 PM, Jiri Denemark wrote: snip Thanks for the fix, actually It can be reproduced simply by: % ./autogen.sh --with-storage-mpath=no % make As src/util/util.c invokes dm_is_dm_major. Yes it does,

Re: [libvirt] [PATCH] build: Fix API docs generation in VPATH build

2011-02-18 Thread Daniel Veillard
On Fri, Feb 18, 2011 at 12:25:03PM +0100, Jiri Denemark wrote: --- docs/Makefile.am | 12 docs/devhelp/devhelp.xsl |7 +++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index adf74ee..c4926d4 100644 ---

[libvirt] libvirt-ask

2011-02-18 Thread stone1927
windows7 connect to linux/kvm by libvirt that is always failure.sothere, I want to know why? Why use qemu+tcp:// connect to linux/kvm is failure. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Driver ESX

2011-02-18 Thread Cédric Penas
Hi, I am currently working on a project where I must develop a function to clone domain for the driver ESX. I immediately saw that the function cloneVM_Task () from VMware API was not supported for standalone ESX. Does anyone know the best way to still implement this function or a

Re: [libvirt] libvirt-ask

2011-02-18 Thread Matthias Bolte
2011/2/18 stone1927 stone1...@126.com: windows7 connect to linux/kvm by libvirt that is always failure.sothere, I want to know why? Why use qemu+tcp:// connect to linux/kvm is failure. I'm not sure I understood what your question actually is. Are you trying to use libvirt to connect from

Re: [libvirt] [PATCH] build: Fix API docs generation in VPATH build

2011-02-18 Thread Jiri Denemark
On Fri, Feb 18, 2011 at 20:42:10 +0800, Daniel Veillard wrote: $(addprefix $(srcdir)/,$(devhelphtml)): $(srcdir)/libvirt-api.xml $(devhelpxsl) -@echo Rebuilding devhelp files -@if [ -x $(XSLTPROC) ] ; then \ - $(XSLTPROC) --nonet -o devhelp/libvirt.devhelp \ +

[libvirt] [PATCH 1/2] Fix virDomainChrDefParseTargetXML() to parse the target port if available

2011-02-18 Thread Michal Novotny
Hi, this is the patch to fix the virDomainChrDefParseTargetXML() functionality to parse the target port from XML if available. This is necessary for multiple serial port support which is the second part of this patch. Michal Signed-off-by: Michal Novotny minov...@redhat.com ---

[libvirt] [PATCH 1/2 v3] Fix virDomainChrDefParseTargetXML() to parse the target port if available

2011-02-18 Thread Michal Novotny
Hi, this is the patch to fix the virDomainChrDefParseTargetXML() functionality to parse the target port from XML if available. This is necessary for multiple serial port support which is the second part of this patch. Michal Signed-off-by: Michal Novotny minov...@redhat.com ---

[libvirt] [PATCH 0/2] Add support for multiple serial ports into the Xen driver

2011-02-18 Thread Michal Novotny
Hi, this is the patch to add support for multiple serial ports to the libvirt Xen driver. It support both old style (serial = pty) and new style (serial = [ /dev/ttyS0, /dev/ttyS1 ]) definition and tests for xml2sexpr, sexpr2xml and xmconfig have been added as well. Written and tested on RHEL-5

[libvirt] [PATCH 2/2] Add support for multiple serial ports into the Xen driver

2011-02-18 Thread Michal Novotny
Hi, this is the patch to add support for multiple serial ports to the libvirt Xen driver. It support both old style (serial = pty) and new style (serial = [ /dev/ttyS0, /dev/ttyS1 ]) definition and tests for xml2sexpr, sexpr2xml and xmconfig have been added as well. Written and tested on RHEL-5

[libvirt] [PATCH 2/2 v3] Add support for multiple serial ports into the Xen driver

2011-02-18 Thread Michal Novotny
Hi, this is the patch to add support for multiple serial ports to the libvirt Xen driver. It support both old style (serial = pty) and new style (serial = [ /dev/ttyS0, /dev/ttyS1 ]) definition and tests for xml2sexpr, sexpr2xml and xmconfig have been added as well. Written and tested on RHEL-5

Re: [libvirt] [PATCH 0/2] Add support for multiple serial ports into the Xen driver

2011-02-18 Thread Michal Novotny
Oops, please ignore those patches and review only v3 patches of this one since I accidentally sent this to the list e-mail instead my e-mail :( Sorry for that, Michal On 02/18/2011 03:10 PM, Michal Novotny wrote: Hi, this is the patch to add support for multiple serial ports to the libvirt

Re: [libvirt] Driver ESX

2011-02-18 Thread Cédric Penas
Le 18. 02. 11 14:11, Matthias Bolte a écrit : 2011/2/18 Cédric Penascedric.pe...@hesge.ch: Hi, I am currently working on a project where I must develop a function to clone domain for the driver ESX. I immediately saw that the function cloneVM_Task () from VMware API was not supported for

[libvirt] [PATCH] Drop empty argument from dnsmasq call

2011-02-18 Thread Guido Günther
Hi, Libvirt currently fails to start with dnsmasq = 2.56. since dnsmasq now bails out with empty arguments. See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613944 for the Debian bug and http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=589885 for the upstream reasoning. Tested with 2.55

Re: [libvirt] [TCK] [PATCH] follow reordering of match extensions relative to state match

2011-02-18 Thread Stefan Berger
On 02/14/2011 02:09 PM, Stefan Berger wrote: On 02/14/2011 11:44 AM, Eric Blake wrote: On 02/14/2011 08:09 AM, Stefan Berger wrote: This patch adjusts the tck test cases following the reordering of the match extensions relative to the state match in libvirt. -RETURN udp -- 0.0.0.0/0

[libvirt] Vietnamese Translation for libvirt

2011-02-18 Thread Hero Phương
Dear libvirt-list, I want to send my translation to upstream. But I have waited for being approved in translation site ( https://translate.fedoraproject.org/projects/p/libvirt/access/rq/add/) for a long time. Does anyone here have the responsibility for approving membership for libvirt

Re: [libvirt] [TCK] [PATCH] follow reordering of match extensions relative to state match

2011-02-18 Thread Eric Blake
On 02/18/2011 08:04 AM, Stefan Berger wrote: On 02/14/2011 02:09 PM, Stefan Berger wrote: On 02/14/2011 11:44 AM, Eric Blake wrote: On 02/14/2011 08:09 AM, Stefan Berger wrote: This patch adjusts the tck test cases following the reordering of the match extensions relative to the state match

[libvirt] [PATCH] nwfilter: enable rejection of packets

2011-02-18 Thread Stefan Berger
This patch adds the possibility to not just drop packets, but to also have them rejected where iptables at least sends an ICMP msg back to the originator. On ebtables this again maps into dropping packets since rejecting is not supported. I am adding 'since 0.8.9' to the docs assuming this

Re: [libvirt] [PATCH] esx: Ignore malformed host UUID from BIOS

2011-02-18 Thread Eric Blake
On 02/18/2011 02:30 AM, Matthias Bolte wrote: Etienne Gosset reported that libvirt fails to connect to his ESX server because it failed to parse its malformed host UUID, that contains a additional space and lacks one hexdigit in the last group: ---- xxx Could

Re: [libvirt] [PATCH] build: speed up non-maintainer builds

2011-02-18 Thread Eric Blake
On 02/13/2011 09:29 PM, Daniel Veillard wrote: On Fri, Feb 11, 2011 at 12:45:36PM -0700, Eric Blake wrote: * configure.ac (gl_ASSERT_NO_GNULIB_POSIXCHECK): Use to reduce time spent in configure. --- This skips out on the bulk of the 'declared without a macro' checks during configure time

Re: [libvirt] [PATCH v3] virsh: freecell --all getting wrong NUMA nodes count

2011-02-18 Thread Eric Blake
On 02/18/2011 04:42 AM, Michal Privoznik wrote: Virsh freecell --all was not only getting wrong NUMA nodes count, but even the NUMA nodes IDs. They doesn't have to be continuous, as I've found out during testing this. Therefore a modification of nodeGetCellsFreeMemory() error message. ---

Re: [libvirt] blkio cgroup

2011-02-18 Thread Vivek Goyal
On Fri, Feb 18, 2011 at 03:42:45PM +0100, Dominik Klein wrote: Hi Vivek I don't know whether you follow the libvirt list, I assume you don't. So I thought I'd forward you an E-Mail involving the blkio controller and a terrible situation arising from using it (maybe in a wrong way). I'd

Re: [libvirt] [PATCH] nwfilter: enable rejection of packets

2011-02-18 Thread Laine Stump
On 02/18/2011 09:56 AM, Stefan Berger wrote: This patch adds the possibility to not just drop packets, but to also have them rejected where iptables at least sends an ICMP msg back to the originator. On ebtables this again maps into dropping packets since rejecting is not supported. I am

Re: [libvirt] [PATCH 1/2 v3] Fix virDomainChrDefParseTargetXML() to parse the target port if available

2011-02-18 Thread Eric Blake
On 02/18/2011 07:11 AM, Michal Novotny wrote: Hi, this is the patch to fix the virDomainChrDefParseTargetXML() functionality to parse the target port from XML if available. This is necessary for multiple serial port support which is the second part of this patch. Michal Signed-off-by:

Re: [libvirt] [PATCH] maint: avoid 'make syntax-check' from tarball

2011-02-18 Thread Eric Blake
On 02/17/2011 01:51 PM, Eric Blake wrote: On 02/16/2011 08:14 PM, Daniel Veillard wrote: On Wed, Feb 16, 2011 at 02:39:30PM -0700, Eric Blake wrote: * .gnulib: update to latest gnulib for maint.mk fixes --- In testing the latest release candidate, I ran 'make syntax-check' out of habit, and

Re: [libvirt] [PATCH] build: Fix API docs generation in VPATH build

2011-02-18 Thread Eric Blake
On 02/18/2011 06:31 AM, Jiri Denemark wrote: +++ b/docs/devhelp/devhelp.xsl @@ -13,6 +13,13 @@ !-- Build keys for all symbols -- xsl:key name=symbols match=/api/symbols/* use=@name/ + xsl:template match=/ +xsl:document xmlns=http://www.devhelp.net/book; href=libvirt.devhelp

Re: [libvirt] [PATCH 2/2 v3] Add support for multiple serial ports into the Xen driver

2011-02-18 Thread Eric Blake
On 02/18/2011 07:11 AM, Michal Novotny wrote: Hi, this is the patch to add support for multiple serial ports to the libvirt Xen driver. It support both old style (serial = pty) and new style (serial = [ /dev/ttyS0, /dev/ttyS1 ]) definition and tests for xml2sexpr, sexpr2xml and xmconfig have

[libvirt] [PATCH] [libvirt-tck] Fix expected error code in network test

2011-02-18 Thread Jim Fehlig
I missed this one while fixing a similar bug in the domain transient autostart tests. Attempting to autostart a transient network results in ERR_OPERATION_INVALID not ERR_INTERNAL_ERROR. --- scripts/networks/051-transient-autostart.t |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [libvirt] [PATCH] [libvirt-tck] Fix expected error code in network test

2011-02-18 Thread Eric Blake
On 02/18/2011 10:02 AM, Jim Fehlig wrote: I missed this one while fixing a similar bug in the domain transient autostart tests. Attempting to autostart a transient network results in ERR_OPERATION_INVALID not ERR_INTERNAL_ERROR. --- scripts/networks/051-transient-autostart.t |2 +- 1

Re: [libvirt] [PATCH] esx: Ignore malformed host UUID from BIOS

2011-02-18 Thread Matthias Bolte
2011/2/18 Eric Blake ebl...@redhat.com: On 02/18/2011 02:30 AM, Matthias Bolte wrote: Etienne Gosset reported that libvirt fails to connect to his ESX server because it failed to parse its malformed host UUID, that contains a additional space and lacks one hexdigit in the last group:

Re: [libvirt] [PATCH] esx: Ignore malformed host UUID from BIOS

2011-02-18 Thread Daniel P. Berrange
On Fri, Feb 18, 2011 at 06:17:15PM +0100, Matthias Bolte wrote: 2011/2/18 Eric Blake ebl...@redhat.com: On 02/18/2011 02:30 AM, Matthias Bolte wrote: Etienne Gosset reported that libvirt fails to connect to his ESX server because it failed to parse its malformed host UUID, that contains a

[libvirt] [PATCH] Remove all object hashtable caches from virConnectPtr

2011-02-18 Thread Daniel P. Berrange
A followup to, merely rebased to latest GIT http://www.redhat.com/archives/libvir-list/2010-October/msg01213.html The virConnectPtr struct will cache instances of all other objects. APIs like virDomainLookupByUUID will return a cached object, so if you do virDomainLookupByUUID twice in a row,

[libvirt] RFC: make mac element required?

2011-02-18 Thread Michal Prívozník
Hi, I am about to fix https://bugzilla.redhat.com/show_bug.cgi?id=616721 It seems to me that problem is libvirt inserts a new element mac address='...' during parsing interface XML with random mac address which result in error described in BZ. I am not sure wheter to fix it just in virsh or

Re: [libvirt] [PATCH] Drop empty argument from dnsmasq call

2011-02-18 Thread Eric Blake
On 02/18/2011 07:37 AM, Guido Günther wrote: Hi, Libvirt currently fails to start with dnsmasq = 2.56. since dnsmasq now bails out with empty arguments. See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613944 for the Debian bug and

Re: [libvirt] [PATCH] Drop empty argument from dnsmasq call

2011-02-18 Thread Eric Blake
On 02/18/2011 11:32 AM, Eric Blake wrote: Oops - I sent my initial reply without finishing reading your patch. ./src/option.c:{pid-file, 2, 0, 'x'}, But your patch was about conf-file. Thankfully: ./src/option.c:{conf-file, 2, 0, 'C'}, so the same arguments apply. --pid-file

Re: [libvirt] [PATCH] check device-mapper when building without storage mpath

2011-02-18 Thread Eric Blake
On 02/18/2011 01:21 AM, Osier Yang wrote: 于 2011年02月18日 11:00, Wen Congyang 写道: When I build libvirt without libvirtd, I receive the following errors: GENvirsh.1 CCLD virsh ../src/.libs/libvirt.so: undefined reference to `dm_is_dm_major' collect2: ld returned 1 exit status

[libvirt] [PATCH] RFC: experimental libvirtd upstart job

2011-02-18 Thread apevec
From: Alan Pevec ape...@redhat.com To install it, disable libvirtd sysv initscript: chkconfig libvirtd off service libvirtd stop and enable libvirtd upstart job: cp /usr/share/doc/libvirt-*/libvirtd.upstart \ /etc/init/libvirtd.conf initctl reload-configuration

Re: [libvirt] [PATCH] Drop empty argument from dnsmasq call

2011-02-18 Thread Laine Stump
On 02/18/2011 01:32 PM, Eric Blake wrote: On 02/18/2011 07:37 AM, Guido Günther wrote: Hi, Libvirt currently fails to start with dnsmasq= 2.56. since dnsmasq now bails out with empty arguments. See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613944 for the Debian bug and

[libvirt] [PATCH] build: fix broken mingw cross-compilation

2011-02-18 Thread Eric Blake
Two regressions: Commit df1011ca broke builds for systems that lack devmapper (non-Linux, as well as Linux with ./autogen.sh --without-libvirtd and without the libraries present). Commit ce6fd650 broke cross-compilation, due to a gnulib bug. * .gnulib: Update to latest, for cross-compilation fix.

Re: [libvirt] [TCK] [PATCH] follow reordering of match extensions relative to state match

2011-02-18 Thread Stefan Berger
On 02/18/2011 10:12 AM, Eric Blake wrote: On 02/18/2011 08:04 AM, Stefan Berger wrote: On 02/14/2011 02:09 PM, Stefan Berger wrote: On 02/14/2011 11:44 AM, Eric Blake wrote: On 02/14/2011 08:09 AM, Stefan Berger wrote: This patch adjusts the tck test cases following the reordering of the

Re: [libvirt] [PATCH] Remove all object hashtable caches from virConnectPtr

2011-02-18 Thread Eric Blake
On 02/18/2011 10:28 AM, Daniel P. Berrange wrote: A followup to, merely rebased to latest GIT http://www.redhat.com/archives/libvir-list/2010-October/msg01213.html This patch removes all the hash table caching, so all APIs return brand new virDomainPtr (etc) object instances. ACK. --

Re: [libvirt] [PATCH 5/5] don't check for NULL before calling virHashFree

2011-02-18 Thread Jim Meyering
Eric Blake wrote: [adding Jim to cc, as author of useless-if-before-free] On 02/17/2011 02:14 PM, Christophe Fergeau wrote: virHashFree follows the convention described in HACKING that XXXFree() functions can be called with a NULL argument. --- src/conf/domain_conf.c |6 +---

Re: [libvirt] blkio cgroup

2011-02-18 Thread Vivek Goyal
On Fri, Feb 18, 2011 at 11:31:37AM -0500, Vivek Goyal wrote: [..] So I went and tried to throttle I/O of kernel3-8 to 10MB/s instead of weighing I/O. First I rebooted everything so that no old configuration of cgroup was left in place and then setup everything except the 100 and 1000

Re: [libvirt] [PATCH 5/5] don't check for NULL before calling virHashFree

2011-02-18 Thread Eric Blake
On 02/18/2011 12:30 PM, Jim Meyering wrote: -if (doms-objs) -virHashFree(doms-objs, virDomainObjListDeallocator); +virHashFree(doms-objs, virDomainObjListDeallocator); I tried adding --name=virHashFree to the useless_free_options variable in cfg.mk, to see if that would

Re: [libvirt] [PATCH] Drop empty argument from dnsmasq call

2011-02-18 Thread Eric Blake
On 02/18/2011 01:49 PM, Guido Günther wrote: On Fri, Feb 18, 2011 at 11:37:53AM -0700, Eric Blake wrote: [..snip..] This might as well be the shorter (and faster): virCommandAddArg(cmd, --conf-file=); now that it is only one argument. Like in the attached patch? ACK; please push! --

Re: [libvirt] [PATCH] Drop empty argument from dnsmasq call

2011-02-18 Thread Guido Günther
On Fri, Feb 18, 2011 at 01:52:03PM -0700, Eric Blake wrote: On 02/18/2011 01:49 PM, Guido Günther wrote: On Fri, Feb 18, 2011 at 11:37:53AM -0700, Eric Blake wrote: [..snip..] This might as well be the shorter (and faster): virCommandAddArg(cmd, --conf-file=); now that it is only

[libvirt] [PATCH] hash: make virHashFree more free-like

2011-02-18 Thread Eric Blake
Two-argument free functions are uncommon; match the style elsewhere by caching the callback at creation. * src/util/hash.h (virHashCreate, virHashFree): Move deallocator argument to creation. * cfg.mk (useless_free_options): Add virHashFree. * src/util/hash.c (_virHashTable): Track deallocator.

Re: [libvirt] [PATCH] RFC: experimental libvirtd upstart job

2011-02-18 Thread Serge E. Hallyn
Quoting ape...@gmail.com (ape...@gmail.com): From: Alan Pevec ape...@redhat.com To install it, disable libvirtd sysv initscript: chkconfig libvirtd off service libvirtd stop and enable libvirtd upstart job: cp /usr/share/doc/libvirt-*/libvirtd.upstart \

Re: [libvirt] [PATCH] hash: make virHashFree more free-like

2011-02-18 Thread Laine Stump
On 02/18/2011 04:31 PM, Eric Blake wrote: Two-argument free functions are uncommon; match the style elsewhere by caching the callback at creation. * src/util/hash.h (virHashCreate, virHashFree): Move deallocator argument to creation. * cfg.mk (useless_free_options): Add virHashFree. *

[libvirt] [PATCHv2 0/3] more VPATH build fixes

2011-02-18 Thread Eric Blake
Technically, this is a v2 of messages I've sent before, but now provided as a single series; see each commit for earlier references. I tested these on top of this unreviewed patch: https://www.redhat.com/archives/libvir-list/2011-February/msg00616.html but suspect that they will trivially

[libvirt] [PATCHv2 1/3] build: don't require pod2man for tarball builds

2011-02-18 Thread Eric Blake
Right now, 'man libvirtd' includes information that depends on configure results, so it must be generated on the fly and live in $(builddir); however, requiring pod2man on all end user machines is overkill. Meanwhile, 'man virsh' doesn't mention any configure results, so it can be built at 'make

[libvirt] [PATCHv2 2/3] maint: fix 'make dist' in VPATH build

2011-02-18 Thread Eric Blake
A diff of 'make dist' from in-tree vs. a VPATH build showed that we were missing docs/api_extension/*.patch files, but shipping other files that we didn't need. * bootstrap.conf (gnulib_extra_files): Don't distribute files we don't care about. * docs/Makefile.am (patches): Perform wildcard

[libvirt] [PATCHv3 3/3] autobuild.sh: use VPATH build

2011-02-18 Thread Eric Blake
Try to avoid future regressions on the VPATH front. * autobuild.sh: Uncomment VPATH use. * .gitignore: Exclude build directory. --- v2, not that much changed since: https://www.redhat.com/archives/libvir-list/2010-April/msg01422.html but now that all the intermediate VPATH issues that had

Re: [libvirt] [PATCH] [libvirt-tck] Fix expected error code in network test

2011-02-18 Thread Jim Fehlig
Eric Blake wrote: On 02/18/2011 10:02 AM, Jim Fehlig wrote: I missed this one while fixing a similar bug in the domain transient autostart tests. Attempting to autostart a transient network results in ERR_OPERATION_INVALID not ERR_INTERNAL_ERROR. ---

Re: [libvirt] [PATCH] nwfilter: enable rejection of packets

2011-02-18 Thread Stefan Berger
On 02/18/2011 11:48 AM, Laine Stump wrote: On 02/18/2011 09:56 AM, Stefan Berger wrote: This patch adds the possibility to not just drop packets, but to also have them rejected where iptables at least sends an ICMP msg back to the originator. On ebtables this again maps into dropping packets

Re: [libvirt] blkio cgroup

2011-02-18 Thread Vivek Goyal
On Fri, Feb 18, 2011 at 11:31:37AM -0500, Vivek Goyal wrote: On Fri, Feb 18, 2011 at 03:42:45PM +0100, Dominik Klein wrote: Hi Vivek I don't know whether you follow the libvirt list, I assume you don't. So I thought I'd forward you an E-Mail involving the blkio controller and a

[libvirt] [PATCH] 802.1Qbh: Delay IFF_UP'ing interface until migration final stage

2011-02-18 Thread Roopa Prabhu
From: Roopa Prabhu ropra...@cisco.com Current code does an IFF_UP on a 8021Qbh interface immediately after a port profile set. This is ok in most cases except when its the migration prepare stage. During migration we want to postpone IFF_UP'ing the interface on the destination host until the