Re: [libvirt] [PATCH] virsh: Make mac required when device-detaching interface

2011-02-23 Thread Michal Prívozník
On 02/23/2011 05:30 AM, Daniel Veillard wrote: On Tue, Feb 22, 2011 at 11:16:29AM +0100, Michal Privoznik wrote: Problem is, if user does not specify mac address in input XML, we generate a random one, which is why device-detach fails giving a confusing error message. Thereforemac needs to be

[libvirt] [PATCH 1/2] libvirt/qemu : allow persistent modification of disks via A(De)ttachDeviceFlags

2011-02-23 Thread KAMEZAWA Hiroyuki
Sorry, pervious mail was sent to wrong list... == From 030135224dd6563af0fb8615dc6a4b8e6084410d Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa@bluextal.(none) Date: Wed, 23 Feb 2011 15:25:26 +0900 Subject: [PATCH 1/2] libvirt/qemu : support attach/detach-disk --persistent Now, only Xen

[libvirt] [PATCH 2/2] libvirt/qemu : allow persistent modification of netifs via A(De)ttachDeviceFlags

2011-02-23 Thread KAMEZAWA Hiroyuki
From 3307d7228ea3c47884d626584db646d23a5a22ce Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa@bluextal.(none) Date: Wed, 23 Feb 2011 17:25:07 +0900 Subject: [PATCH 2/2] libvirt/qemu : allow persistent modification of netifs via A(De)ttachDeviceFlags This patch allows virsh

Re: [libvirt] [PATCH 1/2] libvirt/qemu : allow persistent modification of disks via A(De)ttachDeviceFlags

2011-02-23 Thread Hu Tao
libvirt uses spaces for indention, but the patches use tabs in several lines. make syntax-check will complains about this. -- Thanks, Hu Tao -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH V2] Add libxenlight driver

2011-02-23 Thread Paolo Bonzini
On 02/23/2011 03:56 AM, Jim Fehlig wrote: Add a new xen driver based on libxenlight [1], which is the primary toolstack starting with Xen 4.1.0. The driver is stateful, runs privileged only, and is accessed with libxl:/// URI. Why not let the user keep xen:/// ? Paolo -- libvir-list mailing

Re: [libvirt] [PATCH V2] Add libxenlight driver

2011-02-23 Thread Daniel P. Berrange
On Wed, Feb 23, 2011 at 11:57:45AM +0100, Paolo Bonzini wrote: On 02/23/2011 03:56 AM, Jim Fehlig wrote: Add a new xen driver based on libxenlight [1], which is the primary toolstack starting with Xen 4.1.0. The driver is stateful, runs privileged only, and is accessed with libxl:/// URI.

Re: [libvirt] [PATCH] Add APIs for killing off processes inside a cgroup

2011-02-23 Thread Daniel P. Berrange
On Tue, Feb 22, 2011 at 11:17:05AM -0700, Eric Blake wrote: On 02/22/2011 10:55 AM, Daniel P. Berrange wrote: The virCgroupKill method kills all PIDs found in a cgroup The virCgroupKillRecursively method does this recursively for child cgroups. The virCgroupKillPainfully method does

Re: [libvirt] [PATCH] Add APIs for killing off processes inside a cgroup

2011-02-23 Thread Daniel P. Berrange
On Wed, Feb 23, 2011 at 03:26:30PM +0800, Daniel Veillard wrote: On Tue, Feb 22, 2011 at 11:17:05AM -0700, Eric Blake wrote: On 02/22/2011 10:55 AM, Daniel P. Berrange wrote: The virCgroupKill method kills all PIDs found in a cgroup The virCgroupKillRecursively method does this

Re: [libvirt] [PATCH] Allow hash tables to use generic pointers as keys

2011-02-23 Thread Daniel P. Berrange
On Tue, Feb 22, 2011 at 04:16:50PM -0700, Eric Blake wrote: On 02/22/2011 10:54 AM, Daniel P. Berrange wrote: Relax the restriction that the hash table key must be a string by allowing an arbitrary hash code generator + comparison func to be provided * util/hash.c, util/hash.h: Allow

[libvirt] [PATCH] Put stdbool.h into internal.h so it is available everywhere

2011-02-23 Thread Daniel P. Berrange
Remove the stdbool.h header from all source files / headers and just put it into internal.h * src/internal.h: Add stdbool.h --- daemon/dispatch.c |1 - src/conf/capabilities.h|2 -- src/conf/nwfilter_conf.h |1 -

Re: [libvirt] [PATCH] RFC: experimental libvirtd upstart job

2011-02-23 Thread Serge E. Hallyn
Quoting Daniel P. Berrange (berra...@redhat.com): On Fri, Feb 18, 2011 at 03:48:29PM -0600, Serge E. Hallyn wrote: Quoting ape...@gmail.com (ape...@gmail.com): From: Alan Pevec ape...@redhat.com = # libvirt-cgred-wait start on starting

Re: [libvirt] blkio cgroup

2011-02-23 Thread Dominik Klein
Hi so I ran these tests again. No patch applied yet. And - at least once - it worked. I did everything exactly the same way as before. Since the logs are 8 MB, even when best-bzip2'd, and I don't want everybody to have to download these, I uploaded them to an external hoster:

Re: [libvirt] [PATCH] Add APIs for killing off processes inside a cgroup

2011-02-23 Thread Eric Blake
On 02/23/2011 04:23 AM, Daniel P. Berrange wrote: On Tue, Feb 22, 2011 at 11:17:05AM -0700, Eric Blake wrote: On 02/22/2011 10:55 AM, Daniel P. Berrange wrote: The virCgroupKill method kills all PIDs found in a cgroup The virCgroupKillRecursively method does this recursively for child

Re: [libvirt] [PATCH] Add APIs for killing off processes inside a cgroup

2011-02-23 Thread Daniel P. Berrange
On Wed, Feb 23, 2011 at 07:58:36AM -0700, Eric Blake wrote: On 02/23/2011 04:23 AM, Daniel P. Berrange wrote: On Tue, Feb 22, 2011 at 11:17:05AM -0700, Eric Blake wrote: On 02/22/2011 10:55 AM, Daniel P. Berrange wrote: The virCgroupKill method kills all PIDs found in a cgroup The

Re: [libvirt] [PATCH] Put stdbool.h into internal.h so it is available everywhere

2011-02-23 Thread Eric Blake
On 02/23/2011 05:14 AM, Daniel P. Berrange wrote: Remove the stdbool.h header from all source files / headers and just put it into internal.h * src/internal.h: Add stdbool.h I was about to ACK this, but then I did a spot check: diff --git a/daemon/dispatch.c b/daemon/dispatch.c index

Re: [libvirt] [PATCH] Put stdbool.h into internal.h so it is available everywhere

2011-02-23 Thread Daniel P. Berrange
On Wed, Feb 23, 2011 at 08:02:01AM -0700, Eric Blake wrote: On 02/23/2011 05:14 AM, Daniel P. Berrange wrote: Remove the stdbool.h header from all source files / headers and just put it into internal.h * src/internal.h: Add stdbool.h I was about to ACK this, but then I did a spot

Re: [libvirt] [PATCH] Put stdbool.h into internal.h so it is available everywhere

2011-02-23 Thread Eric Blake
On 02/23/2011 08:11 AM, Daniel P. Berrange wrote: Huh, dispatch.c doesn't include internal.h. Nor does dispatch.h or remote.h. This only compiled because you included memory.h, which eventually included internal.h. I'm not really seeing that as a problem. This is true for anything from

Re: [libvirt] I need help for use virDomainInterfaceStats

2011-02-23 Thread Laine Stump
On 02/22/2011 10:12 AM, Фёдор Пранович wrote: Hi I want use the virDomainInterfaceStats for get statistic of domain, but I don't now how get path parametr. Please help me! The path argument in virDomainInterfaceStats() is intended to be the name of the tap interface on the host that's used to

[libvirt] [PATCH] Allow 32-on-64 execution for LXC guests

2011-02-23 Thread Daniel P. Berrange
Using the 'personality(2)' system call, we can make a container on an x86_64 host appear to be i686. Likewise for most other Linux 64bit arches. * src/lxc/lxc_conf.c: Fill in 32bit capabilities for x86_64 hosts * src/lxc/lxc_container.h, src/lxc/lxc_container.c: Add API to check if an arch has

[libvirt] [Xen-devel] Re: [PATCH V2] Add libxenlight driver

2011-02-23 Thread Ian Jackson
Paolo Bonzini writes ([Xen-devel] Re: [PATCH V2] Add libxenlight driver): On 02/23/2011 03:56 AM, Jim Fehlig wrote: Add a new xen driver based on libxenlight [1], which is the primary toolstack starting with Xen 4.1.0. The driver is stateful, runs privileged only, and is accessed with

[libvirt] NIC Bonding in libvirt

2011-02-23 Thread Shi Jin
Hi there, From http://wiki.libvirt.org/page/FAQ, it says: Network interface management: Any host running the libvirt daemon can be used to manage physical and logical network interfaces. Enumerate existing interfaces, as well as configure (and create) interfaces, bridges, vlans, and bond

Re: [libvirt] [PATCH] Allow 32-on-64 execution for LXC guests

2011-02-23 Thread Eric Blake
On 02/23/2011 10:20 AM, Daniel P. Berrange wrote: Using the 'personality(2)' system call, we can make a container on an x86_64 host appear to be i686. Likewise for most other Linux 64bit arches. * src/lxc/lxc_conf.c: Fill in 32bit capabilities for x86_64 hosts * src/lxc/lxc_container.h,

Re: [libvirt] [PATCH] Allow hash tables to use generic pointers as keys

2011-02-23 Thread Christophe Fergeau
Hi, On Tue, Feb 22, 2011 at 05:54:31PM +, Daniel P. Berrange wrote: +virHashTablePtr virHashCreateFull(int size, virHashDeallocator deallocator, + virHashCode code, virHashEqual equal, + virHashCopy copy, virHashRelease

[libvirt] [PATCHv2 2/5] audit: prepare qemu for listing vm in cgroup audits

2011-02-23 Thread Eric Blake
* src/qemu/qemu_cgroup.h (struct qemuCgroupData): New helper type. (qemuSetupDiskPathAllow, qemuSetupChardevCgroup) (qemuTeardownDiskPathDeny): Drop unneeded prototypes. (qemuSetupDiskCgroup, qemuTeardownDiskCgroup): Adjust prototype. * src/qemu/qemu_cgroup.c (qemuSetupDiskPathAllow,

[libvirt] [PATCHv2 5/5] audit: audit qemu pci and usb device passthrough

2011-02-23 Thread Eric Blake
* src/qemu/qemu_audit.h (qemuDomainHostdevAudit): New prototype. * src/qemu/qemu_audit.c (qemuDomainHostdevAudit): New function. (qemuDomainStartAudit): Call as appropriate. * src/qemu/qemu_hotplug.c (qemuDomainAttachHostPciDevice) (qemuDomainAttachHostUsbDevice, qemuDomainDetachHostPciDevice)

[libvirt] [PATCHv2 0/5] audit: add some more audit hooks

2011-02-23 Thread Eric Blake
I'm following up on danpb's patches to add initial audit support to qemu actions (see around commit 8dc136b in Oct 2010). This series adds the following additional audit points: All changes to the device ACL whitelist via the cgroup device controller All changes to memory balloon and vcpu sizes

[libvirt] [PATCHv2 4/5] audit: audit qemu memory and vcpu adjusments

2011-02-23 Thread Eric Blake
* src/qemu/qemu_audit.h (qemuDomainMemoryAudit) (qemuDomainVcpuAudit): New prototypes. * src/qemu/qemu_audit.c (qemuDomainResourceAudit) (qemuDomainMemoryAudit, qemuDomainVcpuAudit): New functions. (qemuDomainStartAudit): Call as appropriate. * src/qemu/qemu_driver.c (qemudDomainSetMemory)

[libvirt] [PATCHv2 3/5] audit: add qemu hooks for auditing cgroup events

2011-02-23 Thread Eric Blake
* src/qemu/qemu_audit.h (qemuDomainCgroupAudit): New prototype. * src/qemu/qemu_audit.c (qemuDomainCgroupAudit): Implement it. * src/qemu/qemu_driver.c (qemudDomainSaveFlag): Add audit. * src/qemu/qemu_cgroup.c (qemuSetupDiskPathAllow) (qemuSetupChardevCgroup, qemuSetupHostUsbDeviceCgroup)

[libvirt] [PATCHv2 1/5] cgroup: determine when skipping non-devices

2011-02-23 Thread Eric Blake
* src/util/cgroup.c (virCgroupAllowDevicePath) (virCgroupDenyDevicePath): Don't fail with EINVAL for non-devices. * src/qemu/qemu_driver.c (qemudDomainSaveFlag): Update caller. * src/qemu/qemu_cgroup.c (qemuSetupDiskPathAllow) (qemuSetupChardevCgroup, qemuSetupHostUsbDeviceCgroup)

Re: [libvirt] [PATCH 1/2] libvirt/qemu : allow persistent modification of disks via A(De)ttachDeviceFlags

2011-02-23 Thread KAMEZAWA Hiroyuki
On Wed, 23 Feb 2011 17:22:27 +0800 Hu Tao hu...@cn.fujitsu.com wrote: libvirt uses spaces for indention, but the patches use tabs in several lines. make syntax-check will complains about this. Thank you for pointing out, I'll fix. Thanks, -Kame -- libvir-list mailing list

Re: [libvirt] NIC Bonding in libvirt

2011-02-23 Thread Laine Stump
On 02/23/2011 03:49 PM, Shi Jin wrote: Hi there, From http://wiki.libvirt.org/page/FAQ, it says: Network interface management: Any host running the libvirt daemon can be used to manage physical and logical network interfaces. Enumerate existing interfaces, as well as configure (and create)

Re: [libvirt] [PATCH] Add APIs for killing off processes inside a cgroup

2011-02-23 Thread Daniel Veillard
On Wed, Feb 23, 2011 at 11:27:06AM +, Daniel P. Berrange wrote: On Wed, Feb 23, 2011 at 03:26:30PM +0800, Daniel Veillard wrote: On Tue, Feb 22, 2011 at 11:17:05AM -0700, Eric Blake wrote: On 02/22/2011 10:55 AM, Daniel P. Berrange wrote: The virCgroupKill method kills all PIDs found

[libvirt] Invitation to connect on LinkedIn

2011-02-23 Thread Lyre Li
LinkedIn I'd like to add you to my professional network on LinkedIn. - Lyre Lyre Li Engineer at Skybility China Confirm that you know Lyre Li https://www.linkedin.com/e/k4zv0-gkj412ae-3z/isd/2389916274/QzDJLaNZ/ -- (c) 2011, LinkedIn Corporation-- libvir-list mailing

[libvirt] [PATCH 1/2] libvirt/qemu - support updating inactive domains (take 2)

2011-02-23 Thread KAMEZAWA Hiroyuki
From d6c65102224c493f67008b6521b0115d798f5a67 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa@bluextal.(none) Date: Thu, 24 Feb 2011 12:14:25 +0900 Subject: [PATCH 1/2] libvirt/qemu - support updating inactive domains. Now, virsh attach-disk/detach-disk has --persistent option and it

[libvirt] [PATCH 2/2] support attach/detach-interface --persistent with qemu(take2)

2011-02-23 Thread KAMEZAWA Hiroyuki
From b06da6d9b4ee996046af72a81c89b90852372e53 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa@bluextal.(none) Date: Thu, 24 Feb 2011 13:08:54 +0900 Subject: [PATCH 2/2] libvirt/qemu : support attach/detach-interface --persistent with qemu Now, virsh attach/detach-interface have

Re: [libvirt] [PATCH 1/2] libvirt/qemu - support updating inactive domains (take 2)

2011-02-23 Thread Hu Tao
On Thu, Feb 24, 2011 at 01:06:36PM +0900, KAMEZAWA Hiroyuki wrote: From d6c65102224c493f67008b6521b0115d798f5a67 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa@bluextal.(none) Date: Thu, 24 Feb 2011 12:14:25 +0900 Subject: [PATCH 1/2] libvirt/qemu - support updating inactive

Re: [libvirt] [PATCH 2/2] support attach/detach-interface --persistent with qemu(take2)

2011-02-23 Thread Hu Tao
On Thu, Feb 24, 2011 at 01:08:40PM +0900, KAMEZAWA Hiroyuki wrote: From b06da6d9b4ee996046af72a81c89b90852372e53 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa@bluextal.(none) Date: Thu, 24 Feb 2011 13:08:54 +0900 Subject: [PATCH 2/2] libvirt/qemu : support attach/detach-interface

Re: [libvirt] [PATCH 1/2] libvirt/qemu - support updating inactive domains (take 2)

2011-02-23 Thread KAMEZAWA Hiroyuki
Thank you for review. On Thu, 24 Feb 2011 14:25:24 +0800 Hu Tao hu...@cn.fujitsu.com wrote: On Thu, Feb 24, 2011 at 01:06:36PM +0900, KAMEZAWA Hiroyuki wrote: From d6c65102224c493f67008b6521b0115d798f5a67 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa@bluextal.(none) Date:

Re: [libvirt] [PATCH 2/2] support attach/detach-interface --persistent with qemu(take2)

2011-02-23 Thread KAMEZAWA Hiroyuki
On Thu, 24 Feb 2011 14:47:00 +0800 Hu Tao hu...@cn.fujitsu.com wrote: On Thu, Feb 24, 2011 at 01:08:40PM +0900, KAMEZAWA Hiroyuki wrote: From b06da6d9b4ee996046af72a81c89b90852372e53 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa@bluextal.(none) Date: Thu, 24 Feb 2011 13:08:54

[libvirt] [PATCH 2/2] Ignore backing file errors in FS storage pool

2011-02-23 Thread Philipp Hahn
Currently a single storage volume with a broken backing file will disable the whole storage pool. This can happen when the backing file is on some unavailable network storage or if the backing volume is deleted, while the storage volumes using it are not. Since the storage pool then can not be

[libvirt] [PATCH 1/2] Fix spelling mistake: seek

2011-02-23 Thread Philipp Hahn
Replace wrong set by correct seek in error message. Signed-off-by: Philipp Hahn h...@univention.de --- src/util/storage_file.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/storage_file.c b/src/util/storage_file.c index 4faa99d..62dad0d 100644 ---

[libvirt] [PATCH 2/2] Ignore backing file errors in FS storage pool (v2)

2011-02-23 Thread Philipp Hahn
Currently a single storage volume with a broken backing file will disable the whole storage pool. This can happen when the backing file is on some unavailable network storage or if the backing volume is deleted, while the storage volumes using it are not. Since the storage pool then can not be

[libvirt] [PATCH 2/2] Ignore backing file errors in FS storage pool (v3)

2011-02-23 Thread Philipp Hahn
Currently a single storage volume with a broken backing file will disable the whole storage pool. This can happen when the backing file is on some unavailable network storage or if the backing volume is deleted, while the storage volumes using it are not. Since the storage pool then can not be

Re: [libvirt] [PATCH 1/2] libvirt/qemu - support updating inactive domains (take 2)

2011-02-23 Thread Hu Tao
+ +driver = dom-conn-privateData; +qemuDriverLock(driver); +vm = virDomainFindByUUID(driver-domains, dom-uuid); +if (!vm) { +qemuReportError(VIR_ERR_NO_DOMAIN, _(cannot find domain '%s'), +dom-name); +goto unlock_out;

[libvirt] [libvirt-php] add list function for storagepool

2011-02-23 Thread Lyre
* add libvirt_list_active_storagepools libvirt_list_inactive_storagepools * modified EXTRA_DIST for necessary files * generate libvirt-php.spec from .in file * bug fix for memeory leak --- Makefile.am |2 +- configure.ac|1 + libvirt-php.spec| 82