Re: [libvirt] [PATCH] build: drop files generated by config.status from tarball

2011-05-09 Thread Daniel Veillard
On Fri, May 06, 2011 at 10:25:50AM -0600, Eric Blake wrote: The rule of thumb is that any file generated by config.status is a) reproducible by any user, b) dependent on configure options. Therefore, it is inappropriate to include such generated files in the tarball (for proof, Makefile is

[libvirt] virsh nodedev-dempxml is not supported by the connection driver

2011-05-09 Thread guan qin
Hi, I meet a problem when I use the command virsh nodedev-dumpxml pci__00_19_0,it shows as follows: root@shahe26:~# virsh nodedev-list error: Failed to count node devices error: this function is not supported by the connection driver: virNodeNumOfDevices root@shahe26:~# virsh

[libvirt] [PATCH] Allow bootstrap to build gnulib from local git source if $GNULIB_SRCDIR is non-empty.

2011-05-09 Thread Prerna Saxena
'bootstrap' script clones the .gnulib submodule from upstream git sources only (provided in .gitmodules), irrespective of whether $GNULIB_SRCDIR is provided. This patch allows gnulib git sources provided by $GNULIB_SRCDIR to be used for adding the gnulib submodule. From

[libvirt] [PATCH v2 0/4] support for changing cpu.shares for inactive domains from virsh cmd

2011-05-09 Thread Hu Tao
Currently cpu.shares can only be configured by editing domains' xmls. this series enables us to change cpu.shares from virsh cmd schedinfo even when domain is inactive. changes: v2: - since v1 patches that delete all generated RPC files(by Daniel) and that refactor remote generator(by

[libvirt] [PATCH v2 1/4] introduce virDomainSetSchedulerParametersFlags

2011-05-09 Thread Hu Tao
This new function allows aditional flags to be passed into from the virsh command line. --- include/libvirt/libvirt.h.in | 13 + python/generator.py |1 + src/driver.h |8 + src/esx/esx_driver.c |1 + src/libvirt.c| 62

Re: [libvirt] virsh nodedev-dempxml is not supported by the connection driver

2011-05-09 Thread Osier Yang
于 2011年05月09日 16:02, guan qin 写道: Hi, I meet a problem when I use the command virsh nodedev-dumpxml pci__00_19_0,it shows as follows: root@shahe26:~# virsh nodedev-list error: Failed to count node devices error: this function is not supported by the connection driver: virNodeNumOfDevices

[libvirt] [PATCH v2 2/4] qemu: introduce qemuSetSchedulerParametersFlags

2011-05-09 Thread Hu Tao
Support for virDomainSetSchedulerParametersFlags of qemu driver. --- src/qemu/qemu_driver.c | 67 --- 1 files changed, 51 insertions(+), 16 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5f3167a..9ba1e56 100644 ---

[libvirt] [PATCH v2 3/4] remote: introduce remoteSetSchedulerParametersFlags

2011-05-09 Thread Hu Tao
support for virDomainSetSchedulerParametersFlags of remote driver. --- daemon/remote.c | 71 ++ daemon/remote_generator.pl |2 + src/remote/remote_driver.c | 70 - src/remote/remote_protocol.x

Re: [libvirt] [PATCH 4/5] qemu: Build command line for NUMA tuning

2011-05-09 Thread Osier Yang
于 2011年05月07日 05:04, Bill Gray 写道: Looks like there is only a single call-back function -- qemudSecurityHook() -- which has had some cgroup and CPU affinity code already added in it. Perhaps a good approach would be to add an invocation of a new function -- qemudInitMemAffinity() -- as a peer

[libvirt] [PATCH v2 4/4] virsh: add --persistent to cmd schedinfo

2011-05-09 Thread Hu Tao
This enables user to modify cpu.shares even when domain is inactive. --- tools/virsh.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 2b16714..58facc4 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1590,6 +1590,7 @@

Re: [libvirt] RFC: APIs for managing a subset of a domain's disks

2011-05-09 Thread Daniel P. Berrange
On Mon, May 02, 2011 at 05:31:00PM -0600, Eric Blake wrote: Consider the case of a guest that has multiple virtual disks, some residing on shared storage (such as the OS proper) and some on local storage (scratch space, where the OS has faster response if the virtual disk does not have to go

Re: [libvirt] RFC: APIs for managing a subset of a domain's disks

2011-05-09 Thread Daniel P. Berrange
On Sat, May 07, 2011 at 03:33:10AM -0500, Igor Serebryany wrote: On Fri, May 06, 2011 at 06:00:09PM +0100, Richard W.M. Jones wrote: How about just adding flags into the disk XML, eg: disk ... flags migratefalse/migrate snapshotfalse/snapshot /flags

Re: [libvirt] Magic error introduced by commit f09accc

2011-05-09 Thread Jiri Denemark
On Fri, May 06, 2011 at 16:33:13 -0600, Eric Blake wrote: On 05/06/2011 01:18 PM, Jiri Denemark wrote: We discussed more on IRC. The problem is due to a bug in out-of-the-box libnl headers, and has been patched in most distros to just delete the 'inline' as then you don't have to worry about

Re: [libvirt] [PATCH] Allow destroying QEMU VM even if a job is active

2011-05-09 Thread Daniel P. Berrange
On Fri, May 06, 2011 at 08:34:43AM -0600, Eric Blake wrote: On 05/06/2011 05:57 AM, Daniel P. Berrange wrote: Introduce a virProcessKill function that can be safely called even when the job mutex is held. This allows virDomainDestroy to kill any VM even if it is asleep in a monitor job. The

Re: [libvirt] [PATCH] Remove all generated RPC files from GIT

2011-05-09 Thread Daniel P. Berrange
On Fri, May 06, 2011 at 10:11:48AM -0600, Eric Blake wrote: On 05/06/2011 07:11 AM, Daniel P. Berrange wrote: commit 7a2fd256cb85dd9a9d6640d9faed0b66ca617411 Author: Daniel P. Berrange berra...@redhat.com Date: Fri May 6 13:36:21 2011 +0100 Remove all generated files for remote

Re: [libvirt] [TCK] [PATCH] Switch to installation of FC14 image and other fixes

2011-05-09 Thread Daniel P. Berrange
On Fri, May 06, 2011 at 10:39:52AM -0400, Stefan Berger wrote: This patch fixes the creation of VM images. Previously, FC12 images were created but the files necessary for FC12 image creation are no longer available in the public repositories. This patch now switches it to create FC14 images.

Re: [libvirt] How to suppress error printing to stderr from virConnectOpen*?

2011-05-09 Thread Daniel P. Berrange
On Fri, May 06, 2011 at 05:43:41PM +0100, Richard W.M. Jones wrote: I can set the global error handling function (virSetErrorFunc). That doesn't seem to be a good idea from a library. Looking at the code, it doesn't appear that the internal virErrorHandler is thread-local, so I can't set

Re: [libvirt] [PATCH v2 4/4] virsh: add --persistent to cmd schedinfo

2011-05-09 Thread Osier Yang
于 2011年05月09日 16:31, Hu Tao 写道: This enables user to modify cpu.shares even when domain is inactive. --- tools/virsh.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 2b16714..58facc4 100644 --- a/tools/virsh.c +++

Re: [libvirt] How to suppress error printing to stderr from virConnectOpen*?

2011-05-09 Thread Richard W.M. Jones
On Mon, May 09, 2011 at 10:32:10AM +0100, Daniel P. Berrange wrote: On Fri, May 06, 2011 at 05:43:41PM +0100, Richard W.M. Jones wrote: I can set the global error handling function (virSetErrorFunc). That doesn't seem to be a good idea from a library. Looking at the code, it doesn't

Re: [libvirt] virsh nodedev-dempxml is not supported by the connection driver

2011-05-09 Thread guan qin
thanks for your reply ! At first ,I use apt-get install libvirt-bin to install the libvirt ,the version is 0.8.3 ,and virsh nodedev-list works well . but I need the version 0.9.0. So I complied the libvirt use source code as follows: #./configure --prefix=/usr --libdir=/usr/lib64

Re: [libvirt] virsh nodedev-dempxml is not supported by the connection driver

2011-05-09 Thread Osier Yang
于 2011年05月09日 17:43, guan qin 写道: thanks for your reply ! At first ,I use apt-get install libvirt-bin to install the libvirt ,the version is 0.8.3 ,and virsh nodedev-list works well . but I need the version 0.9.0. So I complied the libvirt use source code as follows: #./configure --prefix=/usr

Re: [libvirt] [TCK] [PATCH] Switch to installation of FC14 image and other fixes

2011-05-09 Thread Stefan Berger
On 05/09/2011 05:26 AM, Daniel P. Berrange wrote: On Fri, May 06, 2011 at 10:39:52AM -0400, Stefan Berger wrote: This patch fixes the creation of VM images. Previously, FC12 images were created but the files necessary for FC12 image creation are no longer available in the public repositories.

Re: [libvirt] [TCK] [PATCH] Switch to installation of FC14 image and other fixes

2011-05-09 Thread Daniel P. Berrange
On Mon, May 09, 2011 at 06:34:38AM -0400, Stefan Berger wrote: On 05/09/2011 05:26 AM, Daniel P. Berrange wrote: On Fri, May 06, 2011 at 10:39:52AM -0400, Stefan Berger wrote: This patch fixes the creation of VM images. Previously, FC12 images were created but the files necessary for FC12

Re: [libvirt] virsh nodedev-dempxml is not supported by the connection driver

2011-05-09 Thread guan qin
I do as you said ,and find one machine can work well,but the other is still can't work. I check the Configuration summary ,find that compare to the machine can't work, the machine working well has an item: polkit: /usr/bin/pkcheck (version 1) what's the polkit ? can I configure the libvirt with

Re: [libvirt] [PATCHv2 5/3] build: fix VPATH builds

2011-05-09 Thread Jiri Denemark
On Sat, May 07, 2011 at 14:18:35 +0200, Matthias Bolte wrote: 2011/5/7 Eric Blake ebl...@redhat.com: * src/Makefile.am (REMOTE_DRIVER_GENERATED): Generated files should live in $(srcdir). Update rules to reflect this. --- This still doesn't fix the fact that 'make dist' under

Re: [libvirt] [PATCH] json: Fix *GetBoolean functions

2011-05-09 Thread Jiri Denemark
On Thu, May 05, 2011 at 13:13:13 -0600, Eric Blake wrote: On 05/05/2011 07:10 AM, Jiri Denemark wrote: They were not used anywhere so far so nobody noticed they are broken. --- src/util/json.c | 11 ++- src/util/json.h |4 ++-- 2 files changed, 8 insertions(+), 7

Re: [libvirt] virsh nodedev-dempxml is not supported by the connection driver

2011-05-09 Thread guan qin
OK,I recompile with #./configure --prefix=/usr --libdir=/usr/lib64 --localstatedir=/var --sysconfdir=/etc --with-hal=yes --with-udev=yes --with-polkit=yes,now I can use the command virsh nodedev-list. thank you very much! best regards, qinguan 在 2011年5月9日 下午8:04,guan qin

[libvirt] [PATCH] virsh: Correctly initialize libvirt

2011-05-09 Thread Jiri Denemark
virsh didn't call virInitialize(), which (among other things) initializes virLastErr thread local variable. As a result of that, virsh could just segfault in virEventRegisterDefaultImpl() since that is the first call that touches (resets) virLastErr. I have no idea what lucky coincidence made

Re: [libvirt] [PATCH] virsh: Correctly initialize libvirt

2011-05-09 Thread Matthias Bolte
2011/5/9 Jiri Denemark jdene...@redhat.com: virsh didn't call virInitialize(), which (among other things) initializes virLastErr thread local variable. As a result of that, virsh could just segfault in virEventRegisterDefaultImpl() since that is the first call that touches (resets) virLastErr.

[libvirt] [RFC Patch 0/3]virsh: Enable env support for virsh logging

2011-05-09 Thread Supriya Kannery
Defining environment variables for debug log-level and log-file will avoid specifying the same in each virsh command. Following is a patchset for enabling env variable support for virsh logging. Two new environment variables are defined: a. VIRSH_DEBUG=log_level log_level can be a value

Re: [libvirt] [PATCH] apparmor: Fix uninitalized variable warning in virt-aa-helper

2011-05-09 Thread Jamie Strandboge
On Sat, 7 May 2011 13:13:41 +0200, Matthias Bolte matthias.bo...@googlemail.com wrote: --- src/security/virt-aa-helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index a4e8549..e481095 100644 ---

[libvirt] [RFC Patch 2/3]virsh: Change log level order

2011-05-09 Thread Supriya Kannery
Change log level order so that messages at all other levels get logged for DEBUG level. Replace log level 5 with log level 4 (DEBUG). Signed-off-by: Supriya Kannery supri...@in.ibm.com --- tools/virsh.c | 100 +- 1 file changed, 50

[libvirt] [RFC Patch 1/3]virsh: Use Env variables for debug level and logfile

2011-05-09 Thread Supriya Kannery
Use variables VIRSH_DEBUG and VIRSH_LOG_FILE for controlling virsh logging. Signed-off-by: Supriya Kannery supri...@in.ibm.com --- tools/virsh.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) Index: libvirt/tools/virsh.c

[libvirt] [RFC Patch 3/3]virsh: Update virsh man page

2011-05-09 Thread Supriya Kannery
Update virsh man page with usage of new env variables Signed-off-by: Supriya Kannery supri...@in.ibm.com --- tools/virsh.pod | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) Index: libvirt/tools/virsh.pod

Re: [libvirt] [PATCH] build: drop files generated by config.status from tarball

2011-05-09 Thread Doug Goldstein
On Mon, May 9, 2011 at 1:32 AM, Daniel Veillard veill...@redhat.com wrote: On Fri, May 06, 2011 at 10:25:50AM -0600, Eric Blake wrote: The rule of thumb is that any file generated by config.status is a) reproducible by any user, b) dependent on configure options. Therefore, it is inappropriate

Re: [libvirt] [PATCH] build: drop files generated by config.status from tarball

2011-05-09 Thread Eric Blake
On 05/09/2011 08:45 AM, Doug Goldstein wrote: EXTRA_DIST = \ ChangeLog-old \ - libvirt.spec libvirt.spec.in \ + libvirt.spec.in \ Actually that part is wrong. The libvirt.spec need to be in the tarball to allow to build rpms from it. This breaks for example make rpm. I reverted

Re: [libvirt] [PATCH] build: drop files generated by config.status from tarball

2011-05-09 Thread Daniel P. Berrange
On Mon, May 09, 2011 at 09:45:49AM -0500, Doug Goldstein wrote: On Mon, May 9, 2011 at 1:32 AM, Daniel Veillard veill...@redhat.com wrote: On Fri, May 06, 2011 at 10:25:50AM -0600, Eric Blake wrote: The rule of thumb is that any file generated by config.status is a) reproducible by any

Re: [libvirt] [PATCH] build: drop files generated by config.status from tarball

2011-05-09 Thread Daniel Veillard
On Mon, May 09, 2011 at 09:45:49AM -0500, Doug Goldstein wrote: On Mon, May 9, 2011 at 1:32 AM, Daniel Veillard veill...@redhat.com wrote: Since the Makefile doesn't ship in the tarball but only Makefile.in, which requires ./configure be run before make rpm be run, that would mean that you

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-05-09 Thread Daniel P. Berrange
On Mon, May 02, 2011 at 04:29:49PM -0500, Adam Litke wrote: After several long distractions, I am back to working on disk streaming. Before I hit the list with a new series of patches, I was hoping to reach some middle ground on the proposed streaming API. On Fri, 2011-04-08 at 14:31 +0100,

Re: [libvirt] [PATCH 1/6 V3] inject-nmi: Defining the public API

2011-05-09 Thread Daniel P. Berrange
On Thu, Apr 21, 2011 at 02:42:52PM +0800, Lai Jiangshan wrote: Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- include/libvirt/libvirt.h.in |2 ++ src/libvirt_public.syms |5 + 2 files changed, 7 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH 2/6 V3] inject-nmi: Defining the internal API

2011-05-09 Thread Daniel P. Berrange
On Thu, Apr 21, 2011 at 02:42:55PM +0800, Lai Jiangshan wrote: Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- src/driver.h |4 src/esx/esx_driver.c |1 + src/libxl/libxl_driver.c |1 + src/lxc/lxc_driver.c |1 +

Re: [libvirt] [PATCH 6/6 V3] qemu, inject-nmi: Implement the driver methods

2011-05-09 Thread Daniel P. Berrange
On Thu, Apr 21, 2011 at 02:43:07PM +0800, Lai Jiangshan wrote: Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- src/qemu/qemu_driver.c | 46 +- src/qemu/qemu_monitor.c | 14 src/qemu/qemu_monitor.h |2 +

Re: [libvirt] [PATCH 3/6 V3] inject-nmi: Implementing the public API

2011-05-09 Thread Daniel P. Berrange
On Thu, Apr 21, 2011 at 02:42:58PM +0800, Lai Jiangshan wrote: Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- src/libvirt.c | 44 1 files changed, 44 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index

Re: [libvirt] [PATCH 4/6 V3] inject-nmi: Implementing the remote protocol

2011-05-09 Thread Daniel P. Berrange
On Thu, Apr 21, 2011 at 02:43:01PM +0800, Lai Jiangshan wrote: Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- daemon/remote.c | 28 daemon/remote_dispatch_args.h |1 + daemon/remote_dispatch_prototypes.h |8

Re: [libvirt] [PATCH 5/6 V3] inject-nmi: Expose the new API in virsh

2011-05-09 Thread Daniel P. Berrange
On Thu, Apr 21, 2011 at 02:43:04PM +0800, Lai Jiangshan wrote: Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- tools/virsh.c | 35 +++ tools/virsh.pod |4 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c

[libvirt] [PATCH v2] Add support for YAJL version 2 API/ABI

2011-05-09 Thread Daniel P. Berrange
Version 2.0.0 or yajl changed API. It is fairly trivial for us to cope with both APIs in libvirt, so adapt. * configure.ac: Probe for yajl2 API * src/util/json.c: Conditional support for yajl2 API --- configure.ac|8 ++ src/util/json.c | 74

[libvirt] [PATCH v2] Allow destroying QEMU VM even if a job is active

2011-05-09 Thread Daniel P. Berrange
Introduce a virProcessKill function that can be safely called even when the job mutex is held. This allows virDomainDestroy to kill any VM even if it is asleep in a monitor job. The PID will die and the thread asleep on the monitor will then wake up releasing the job mutex. *

Re: [libvirt] Magic error introduced by commit f09accc

2011-05-09 Thread Eric Blake
On 05/09/2011 03:05 AM, Jiri Denemark wrote: work around the issue by doing: #define inline #include netlink/msg.h #undef inline in src/util/macvtap.c. I think we shouldn't do this. In one regards, the only people that ever run into this are those that are using incompatible

[libvirt] [PATCH] build: make python optional at configure time

2011-05-09 Thread Eric Blake
Regression introduced in commit 53cb23f4. * configure.ac: Let --with-python default to check. --- configure.ac | 29 - 1 files changed, 20 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index dcec371..1fdcf27 100644 --- a/configure.ac +++

Re: [libvirt] [PATCH 1/6] Add new API virDomainStreamDisk[Info] to header and drivers

2011-05-09 Thread Adam Litke
On 05/09/2011 11:09 AM, Daniel P. Berrange wrote: On Mon, May 02, 2011 at 04:29:49PM -0500, Adam Litke wrote: After several long distractions, I am back to working on disk streaming. Before I hit the list with a new series of patches, I was hoping to reach some middle ground on the proposed

Re: [libvirt] [PATCHv2 4/3] build: translate generated strings

2011-05-09 Thread Eric Blake
On 05/07/2011 06:07 AM, Matthias Bolte wrote: 2011/5/7 Eric Blake ebl...@redhat.com: Make sure that xgettext scans generated files for translatable strings, rather than just files stored in libvirt.git. * .gnulib: Update, for bootstrap and syntax-check fixes. * bootstrap: Resynchronize with

Re: [libvirt] [PATCH] Remove all generated RPC files from GIT

2011-05-09 Thread Eric Blake
On 05/09/2011 03:21 AM, Daniel P. Berrange wrote: +my $fixup = $^O eq linux; I guess I'll see what happens when I try this on Cygwin, but if there are any followups needed, it should be separate patches. As is, cygwin already can't use -Werror because of repetitive declarations in the

[libvirt] [RFC][PATCH 1/7] interface: add new public API

2011-05-09 Thread Michal Privoznik
API agreed on in: https://www.redhat.com/archives/libvir-list/2011-May/msg00026.html --- include/libvirt/libvirt.h.in |7 +++ src/libvirt_public.syms |7 +++ 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/include/libvirt/libvirt.h.in

[libvirt] [RFC][PATCH 0/7] interface: Transaction API

2011-05-09 Thread Michal Privoznik
This is a RFC implementation of what some may call network transaction API. The new interface driver functions now do not contain anything valuable, they are just stub. Later on, a real netcf calls will be added. This should only give us an image of whole thing. So any comments are more than

[libvirt] [RFC][PATCH 2/7] interface: define internal driver API

2011-05-09 Thread Michal Privoznik
--- src/driver.h | 12 src/esx/esx_interface_driver.c |3 +++ src/interface/netcf_driver.c |3 +++ src/phyp/phyp_driver.c |5 - src/remote/remote_driver.c |3 +++ src/test/test_driver.c |3 +++ 6 files changed, 28

[libvirt] [RFC][PATCH 4/7] interface: implement the remote protocol

2011-05-09 Thread Michal Privoznik
--- src/remote/remote_driver.c |6 +++--- src/remote/remote_protocol.x | 18 +- src/remote_protocol-structs |9 + 3 files changed, 29 insertions(+), 4 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index d56f352..a974b39

[libvirt] [RFC][PATCH 3/7] interface: implement the public APIs

2011-05-09 Thread Michal Privoznik
--- src/libvirt.c | 129 + 1 files changed, 129 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index abacf85..d9b659d 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -7481,6 +7481,135 @@

[libvirt] [RFC][PATCH 7/7] interface: implement test driver

2011-05-09 Thread Michal Privoznik
--- src/test/test_driver.c | 116 ++- 1 files changed, 113 insertions(+), 3 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 83dcf1a..9ae6e7a 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -85,6

[libvirt] [RFC][PATCH 6/7] interface: Implement the driver methods

2011-05-09 Thread Michal Privoznik
--- configure.ac |5 + src/interface/netcf_driver.c | 36 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index dcec371..041d738 100644 --- a/configure.ac +++ b/configure.ac @@ -1483,6

Re: [libvirt] [PATCH] Allow bootstrap to build gnulib from local git source if $GNULIB_SRCDIR is non-empty.

2011-05-09 Thread Eric Blake
On 05/09/2011 02:25 AM, Prerna Saxena wrote: 'bootstrap' script clones the .gnulib submodule from upstream git sources only (provided in .gitmodules), irrespective of whether $GNULIB_SRCDIR is provided. Which is what we want. A local gnulib checkout is not the same as upstream gnulib, and

[libvirt] [PATCH 1/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds support for continue and return actions in filter rules. Signed-off-by: David L Stevens dlstev...@us.ibm.com diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 13b5b38..6a15f04 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@

[libvirt] [PATCH 0/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
The following series of patches replaces IP address learning in network filtering with DHCP snooping. The existing address learning capability does not provide security since it relies on addresses used in initial packets sent by the guest to determine an IP address. A spoofing guest can

[libvirt] [PATCH 2/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
The ARP protocol requires processing of packets that may not be explicitly addressed to a host and only defines request and reply. This patch removes the filtering of gratuitous ARPs and ARP requests which must update a VMs patch for correct function and removes the unnecessary check for

[libvirt] [PATCH 3/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch changes rules of the form: if ! addr drop accept to: if addr return ... drop The patch adds a mac chain to do a mac address list and separates the arp chain into separate arpmac and arpip chains that can check multiple MAC or IP addresses in any

[libvirt] [PATCH 3/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch changes rules of the form: if ! addr drop accept to: if addr return ... drop The patch adds a mac chain to do a mac address list and separates the arp chain into separate arpmac and arpip chains that can check multiple MAC or IP addresses in any

[libvirt] [PATCH 5/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds the internal capability to add rules to existing chains instead of using temporary chains and to generate placeholders for chains that are referenced without generating a rule for them immediately. Finally, it includes variable matching for filter instantiation (i.e., instantiate

[libvirt] [PATCH 4/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch simplifies the table rules by setting the protocol chains policy to be DROP and removes the explicit -j DROP entries that the protocol rules had previously. It also makes no-other-rarp-traffic.xml obsolete. Signed-off-by: David L Stevens dlstev...@us.ibm.com diff --git

[libvirt] [PATCH 5/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds the internal capability to add rules to existing chains instead of using temporary chains and to generate placeholders for chains that are referenced without generating a rule for them immediately. Finally, it includes variable matching for filter instantiation (i.e., instantiate

[libvirt] [PATCH 4/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch simplifies the table rules by setting the protocol chains policy to be DROP and removes the explicit -j DROP entries that the protocol rules had previously. It also makes no-other-rarp-traffic.xml obsolete. Signed-off-by: David L Stevens dlstev...@us.ibm.com diff --git

[libvirt] [PATCH 6/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds the capability of adding individual rules to existing chains. Signed-off-by: David L Stevens dlstev...@us.ibm.com diff --git a/src/conf/nwfilter_conf.h b/src/conf/nwfilter_conf.h index 25f7b60..4b6759a 100644 --- a/src/conf/nwfilter_conf.h +++ b/src/conf/nwfilter_conf.h @@ -532,6

[libvirt] [PATCH 6/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds the capability of adding individual rules to existing chains. Signed-off-by: David L Stevens dlstev...@us.ibm.com diff --git a/src/conf/nwfilter_conf.h b/src/conf/nwfilter_conf.h index 25f7b60..4b6759a 100644 --- a/src/conf/nwfilter_conf.h +++ b/src/conf/nwfilter_conf.h @@ -532,6

[libvirt] [PATCH 8/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds DHCP Snooping support to libvirt. Signed-off-by: David L Stevens dlstev...@us.ibm.com diff --git a/examples/xml/nwfilter/no-ip-spoofing.xml b/examples/xml/nwfilter/no-ip-spoofing.xml index 2fccd12..2ae9500 100644 --- a/examples/xml/nwfilter/no-ip-spoofing.xml +++

[libvirt] [PATCH 7/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds a function that applies or deletes filter rules to existing chains. Rules referencing the given variable are instantiated with the given value, or optionally deleted. For example, passing variable IP with different values will install rules using the IP variable with each of the

[libvirt] [PATCH 9/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch removes remaining pieces of IP address learning. diff --git a/src/Makefile.am b/src/Makefile.am index 3da0797..53cdc00 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -389,9 +389,7 @@ NWFILTER_DRIVER_SOURCES = \

[libvirt] [PATCH 7/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds a function that applies or deletes filter rules to existing chains. Rules referencing the given variable are instantiated with the given value, or optionally deleted. For example, passing variable IP with different values will install rules using the IP variable with each of the

[libvirt] [PATCH 9/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 8/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David L Stevens
This patch adds DHCP Snooping support to libvirt. Signed-off-by: David L Stevens dlstev...@us.ibm.com diff --git a/examples/xml/nwfilter/no-ip-spoofing.xml b/examples/xml/nwfilter/no-ip-spoofing.xml index 2fccd12..2ae9500 100644 --- a/examples/xml/nwfilter/no-ip-spoofing.xml +++

Re: [libvirt] [PATCH 2/2] docs: updates to CA cert and client cert/key info

2011-05-09 Thread Doug Goldstein
On Fri, May 6, 2011 at 10:01 AM, Doug Goldstein car...@gentoo.org wrote: Update the documentation to mention that the CA certificate and the client cert/key pair can come from the user's location or the global location independent of each other. Signed-off-by: Doug Goldstein car...@gentoo.org

Re: [libvirt] [PATCH 1/2] virsh: flexibility in CA cert and user cert/key

2011-05-09 Thread Doug Goldstein
On Fri, May 6, 2011 at 10:00 AM, Doug Goldstein car...@gentoo.org wrote: Allow the CA certificate to come from the user's home directory or from the global location independently of the client certificate/key pair. Mostly for the case when each user on a system has their own cert/key pair but

Re: [libvirt] [PATCH 0/9] add DHCP snooping support to nwfilter

2011-05-09 Thread Eric Blake
On 05/09/2011 02:00 PM, David L Stevens wrote: The following series of patches replaces IP address learning in network filtering with DHCP snooping. The existing address learning capability does not provide security since it relies on addresses used in initial packets sent by the

Re: [libvirt] [TCK] [PATCH] Switch to installation of FC14 image and other fixes

2011-05-09 Thread Stefan Berger
On 05/09/2011 05:26 AM, Daniel P. Berrange wrote: On Fri, May 06, 2011 at 10:39:52AM -0400, Stefan Berger wrote: This patch fixes the creation of VM images. Previously, FC12 images were created but the files necessary for FC12 image creation are no longer available in the public repositories.

Re: [libvirt] [PATCH 0/9] add DHCP snooping support to nwfilter

2011-05-09 Thread David Stevens
Eric Blake ebl...@redhat.com wrote on 05/09/2011 01:41:37 PM: Can you configure your mailer to send related patches threaded to one another (or at least all as a reply to the 0/9 cover-letter), rather than starting an independent thread for each mail in the series? 'git send-email' can do

Re: [libvirt] [PATCH 1/5] Rename internal DumpXML functions to GetXMLDesc

2011-05-09 Thread Eric Blake
On 05/07/2011 06:28 AM, Matthias Bolte wrote: This matches the public API and helps to get rid of some speical case s/speical/special/ code in the remote generator. Rename driver API functions and XDR protocol structs. No functional change included outside of the remote generator. 31

Re: [libvirt] [PATCH 2/5] remote generator: Fix comment ignoring regex

2011-05-09 Thread Eric Blake
On 05/07/2011 06:28 AM, Matthias Bolte wrote: --- daemon/remote_generator.pl |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl index b06e51a..8d62c37 100755 --- a/daemon/remote_generator.pl +++

Re: [libvirt] [TCK] [PATCH] Switch to installation of FC14 image and other fixes

2011-05-09 Thread Richard W.M. Jones
On Mon, May 09, 2011 at 12:01:16PM +0100, Daniel P. Berrange wrote: On Mon, May 09, 2011 at 06:34:38AM -0400, Stefan Berger wrote: On 05/09/2011 05:26 AM, Daniel P. Berrange wrote: On Fri, May 06, 2011 at 10:39:52AM -0400, Stefan Berger wrote: This patch fixes the creation of VM images.

Re: [libvirt] [TCK] [PATCH] Switch to installation of FC14 image and other fixes

2011-05-09 Thread Richard W.M. Jones
On Mon, May 09, 2011 at 04:49:48PM -0400, Stefan Berger wrote: On 05/09/2011 05:26 AM, Daniel P. Berrange wrote: On Fri, May 06, 2011 at 10:39:52AM -0400, Stefan Berger wrote: This patch fixes the creation of VM images. Previously, FC12 images were created but the files necessary for FC12

Re: [libvirt] [PATCH 3/5] remote generator: Unify unsigned int notation in .x files

2011-05-09 Thread Eric Blake
On 05/07/2011 06:28 AM, Matthias Bolte wrote: Rename u_int and unsigned to unsigned int. This gets rid of some special case code in the generator. --- daemon/remote_generator.pl | 10 +++--- src/remote/remote_protocol.x | 72 +- 2 files

Re: [libvirt] [PATCH 4/5] remote generator: Make parsing stricter

2011-05-09 Thread Eric Blake
On 05/07/2011 06:28 AM, Matthias Bolte wrote: Anchor matches at the beginning of a line. Specialize some general matches. Add some comments to special cases. --- daemon/remote_generator.pl | 172 +++- 1 files changed, 105 insertions(+), 67

Re: [libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-09 Thread Eric Blake
On 05/07/2011 06:28 AM, Matthias Bolte wrote: --- daemon/Makefile.am | 20 - daemon/qemu_dispatch.blacklist |3 + daemon/qemu_dispatch.whitelist |1 + daemon/remote_dispatch.blacklist | 37 daemon/remote_dispatch.whitelist | 169

Re: [libvirt] [PATCH v2 4/4] virsh: add --persistent to cmd schedinfo

2011-05-09 Thread Hu Tao
On Mon, May 09, 2011 at 05:37:04PM +0800, Osier Yang wrote: 于 2011年05月09日 16:31, Hu Tao 写道: This enables user to modify cpu.shares even when domain is inactive. --- tools/virsh.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c

Re: [libvirt] [PATCH v2 4/4] virsh: add --persistent to cmd schedinfo

2011-05-09 Thread Osier Yang
于 2011年05月10日 09:31, Hu Tao 写道: On Mon, May 09, 2011 at 05:37:04PM +0800, Osier Yang wrote: 于 2011年05月09日 16:31, Hu Tao 写道: This enables user to modify cpu.shares even when domain is inactive. --- tools/virsh.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff

Re: [libvirt] [PATCH] Allow bootstrap to build gnulib from local git source if $GNULIB_SRCDIR is non-empty.

2011-05-09 Thread Prerna Saxena
Hi Eric, On 05/10/2011 01:16 AM, Eric Blake wrote: On 05/09/2011 02:25 AM, Prerna Saxena wrote: 'bootstrap' script clones the .gnulib submodule from upstream git sources only (provided in .gitmodules), irrespective of whether $GNULIB_SRCDIR is provided. Which is what we want. A local gnulib