On 26.05.2011 07:30, Laine Stump wrote:
On 05/24/2011 02:24 AM, Daniel Veillard wrote:
On Thu, May 19, 2011 at 04:51:29PM -0400, Laine Stump wrote:
From: Michal Privoznikmpriv...@redhat.com
---
src/conf/interface_conf.c | 45
src/conf/interface_conf.h |4 ++
On Thu, May 19, 2011 at 04:51:25PM -0400, Laine Stump wrote:
From: Michal Privoznik mpriv...@redhat.com
---
src/libvirt.c | 141
-
1 files changed, 139 insertions(+), 2 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
On Thu, May 19, 2011 at 04:51:27PM -0400, Laine Stump wrote:
From: Michal Privoznik mpriv...@redhat.com
This implements the commands iface-begin, iface-commit, and iface-rollback,
which simply call the corresponding functions in the libvirt API.
---
tools/virsh.c | 103
On Thu, May 19, 2011 at 04:51:28PM -0400, Laine Stump wrote:
From: Michal Privoznik mpriv...@redhat.com
This is the functionality at the end of the libvirt part of the call
chain - for each function, the corresponding netcf API is called.
---
configure.ac |5 +++
On Thu, May 19, 2011 at 04:51:29PM -0400, Laine Stump wrote:
From: Michal Privoznik mpriv...@redhat.com
---
src/conf/interface_conf.c | 45
src/conf/interface_conf.h |4 ++
src/test/test_driver.c| 83
+
3
Hi,
I am trying to write the patch file for live migration which uses UDP as the
transport protocol.
---So I prepare to edit the existing API which uses the TCP as the transport
protocol for the migration.I want to know the modules executing during live
migration in current libvirt.(I m using
On Thu, May 26, 2011 at 02:56:55PM +0530, prakash hr wrote:
Hi,
I am trying to write the patch file for live migration which uses UDP as the
transport protocol.
---So I prepare to edit the existing API which uses the TCP as the transport
protocol for the migration.I want to know the modules
On 05/26/2011 12:36 AM, Daniel P. Berrange wrote:
On Wed, May 25, 2011 at 05:37:42PM +0800, Lai Jiangshan wrote:
Add API virDomainSendKey() and virsh send-key command.
# virsh help send-key
NAME
send-key - Send keycodes to the guest
SYNOPSIS
send-key domain [--codeset string]
You are right.
My question was something like repeating the same set of questions.
I m sorry for that.
I just want to know how the migration is done using libvirt API, I mean the
functions in libvirt does the job of migration.
I know by default all the connections are done with tcp only. So
On 05/26/2011 12:43 AM, Daniel P. Berrange wrote:
On Wed, May 25, 2011 at 05:37:47PM +0800, Lai Jiangshan wrote:
Add public virDomainSendKey() and enum libvirt_keycode_set
for the @codeset.
Python version of virDomainSendKey() has not been implemented yet,
it will be done soon.
On Thu, May 26, 2011 at 06:00:08PM +0800, Lai Jiangshan wrote:
On 05/26/2011 12:36 AM, Daniel P. Berrange wrote:
On Wed, May 25, 2011 at 05:37:42PM +0800, Lai Jiangshan wrote:
Add API virDomainSendKey() and virsh send-key command.
# virsh help send-key
NAME
send-key - Send
On 05/25/2011 05:53 PM, Eric Blake wrote:
-localtime_r(creation,time_info);
+creation_time_t = creation_longlong;
+if (creation_time_t != creation_longlong) {
+vshError(ctl, %s, _(time_t overflow));
We shouldn't hit this error until
We support this in code, but forgot to add this to RNG schema as well.
According to documentation, the value match the dateTime type.
---
docs/schemas/domain.rng | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
On Tue, May 24, 2011 at 18:06:42 +0100, Daniel P. Berrange wrote:
Currently whenever there is any failure with parsing the monitor,
this is treated in the same was as end-of-file (ie QEMU quit).
The domain is terminated, if not already dead.
With this change, failures in parsing the monitor
---
tests/domainschemadata/domain-complex-1.xml | 87 +++
1 files changed, 87 insertions(+), 0 deletions(-)
create mode 100644 tests/domainschemadata/domain-complex-1.xml
diff --git a/tests/domainschemadata/domain-complex-1.xml
On Thu, May 26, 2011 at 01:50:37PM +0200, Michal Privoznik wrote:
We support this in code, but forgot to add this to RNG schema as well.
According to documentation, the value match the dateTime type.
---
docs/schemas/domain.rng | 10 ++
1 files changed, 10 insertions(+), 0
On Thu, May 26, 2011 at 01:53:33PM +0200, Michal Privoznik wrote:
---
tests/domainschemadata/domain-complex-1.xml | 87
+++
1 files changed, 87 insertions(+), 0 deletions(-)
create mode 100644 tests/domainschemadata/domain-complex-1.xml
diff --git
On 26.05.2011 15:54, Daniel Veillard wrote:
On Thu, May 26, 2011 at 01:50:37PM +0200, Michal Privoznik wrote:
We support this in code, but forgot to add this to RNG schema as well.
According to documentation, the value match the dateTime type.
---
docs/schemas/domain.rng | 10 ++
On Wed, May 18, 2011 at 11:34:36AM +0200, Markus Groß wrote:
Am Mittwoch 18 Mai 2011 09:22:43 schrieb Markus Groß:
v2:
- free dev before using it again.
When modifying the disk devices of a live domain and the domain
configuration, the function qemuDomainAttachDeviceConfig
first sets
On 05/26/2011 01:33 AM, Laine Stump wrote:
From: Michal Privoznikmpriv...@redhat.com
---
src/libvirt.c | 178 -
1 files changed, 176 insertions(+), 2 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index ff16c48..12b849a
On 05/26/2011 04:31 AM, Daniel P. Berrange wrote:
On Thu, May 19, 2011 at 04:51:27PM -0400, Laine Stump wrote:
From: Michal Privoznikmpriv...@redhat.com
This implements the commands iface-begin, iface-commit, and iface-rollback,
which simply call the corresponding functions in the libvirt API.
On 05/26/2011 04:35 AM, Daniel P. Berrange wrote:
On Thu, May 19, 2011 at 04:51:28PM -0400, Laine Stump wrote:
From: Michal Privoznikmpriv...@redhat.com
This is the functionality at the end of the libvirt part of the call
chain - for each function, the corresponding netcf API is called.
---
Coverity spotted this off-by-one. Thankfully, no one in libvirt
was ever calling virAuditSend with an argument of 3.
* src/util/virtaudit.c (virAuditSend): Use correct comparison.
---
src/util/virtaudit.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git
On Wed, May 18, 2011 at 10:06:35AM +0200, Markus Groß wrote:
This patch series adds the infrastructure to support
attaching and detaching of devices to the libxl driver.
Currently only disk devices are supported.
The first patch refactors some functions that
are needed to create the
Before commit 145d6cb05c45f4 (in August 2010) absolute file names
in VMX and domain XML configs were handled correctly. But this got
lost during the refactoring. The test cases didn't highlight this
problem because they have their own set of file name handling
functions. The actual ones require a
On 05/26/2011 04:18 AM, Michal Prívozník wrote:
On 26.05.2011 07:30, Laine Stump wrote:
There *is* a problem in general with this function, though - dest is not
cleaned out before copying over the contents of src, so if it starts out
non-empty, there may be extra stuff in there at the end.
From: Michal Privoznik mpriv...@redhat.com
Changes from previous version:
1) don't print extra/incorrect error on format failure.
2) use cleanup: instead of no_memory: and end:
3) always clear out the destination list at the start.
4) remove bogus conn-ref++
---
src/conf/interface_conf.c | 38
From: Michal Privoznik mpriv...@redhat.com
No change from previous version of ACKed patch.
---
src/driver.h | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/src/driver.h b/src/driver.h
index 450dd53..c9747aa 100644
--- a/src/driver.h
+++ b/src/driver.h
@@
From: Michal Privoznik mpriv...@redhat.com
No change from previously ACKed patch.
This is the API agreed on in:
https://www.redhat.com/archives/libvir-list/2011-May/msg00026.html
(with a slight name change to use ...begin rather than
...start). This implements transactional changes to the
(This is v3 of some of the patches and v4 of some others. Changes from
previous versions are noted in the individual patches.)
This patch series implements three new APIs for the interface
driver which support transactional changes to the host's network
config - at any point you can begin a
From: Michal Privoznik mpriv...@redhat.com
change from previous version: modified to be the same code style as other
libvirt public API functions.
---
src/libvirt.c | 182 -
1 files changed, 180 insertions(+), 2 deletions(-)
diff --git
From: Michal Privoznik mpriv...@redhat.com
This is the functionality at the end of the libvirt part of the call
chain - for each function, the corresponding netcf API is called.
Change from previous version: modify the error log format as suggested by danpb.
---
configure.ac |
From: Michal Privoznik mpriv...@redhat.com
No change from previously ACKed patch
---
src/remote/remote_driver.c |3 +++
src/remote/remote_protocol.x | 17 -
src/remote_protocol-structs |9 +
3 files changed, 28 insertions(+), 1 deletions(-)
diff --git
From: Michal Privoznik mpriv...@redhat.com
This implements the commands iface-begin, iface-commit, and iface-rollback,
which simply call the corresponding functions in the libvirt API.
change from previous version: follow the same pattern as other virsh commands.
---
tools/virsh.c | 91
On 05/26/2011 09:45 AM, Matthias Bolte wrote:
-if (datastorePath == NULL) {
+/* If it's an absolute path outside of a datastore just use it as is
*/
+if (result == NULL *fileName == '/') {
+/* FIXME: need to deal with Windows paths here too */
On 05/26/2011 11:11 AM, Eric Blake wrote:
Coverity spotted this off-by-one. Thankfully, no one in libvirt
was ever calling virAuditSend with an argument of 3.
* src/util/virtaudit.c (virAuditSend): Use correct comparison.
---
src/util/virtaudit.c |4 ++--
1 files changed, 2
On 05/26/2011 03:45 AM, Federico Simoncelli wrote:
If this is correct I'll squash it with the v4 patch.
---
src/qemu/qemu_domain.h|4 ++--
src/qemu/qemu_driver.c|6 ++
src/qemu/qemu_migration.c |8
3 files changed, 8 insertions(+), 10 deletions(-)
It was suggested during review of a different patch that the libvirt
interface driver API's should have netcf: in their log
messages. This patch eliminates that from all interface driver API
functions, and also eliminates the extra - in the case that netcf
returns no details in its error info
On 05/26/2011 11:04 AM, Laine Stump wrote:
On 05/26/2011 11:11 AM, Eric Blake wrote:
Coverity spotted this off-by-one. Thankfully, no one in libvirt
was ever calling virAuditSend with an argument of 3.
* src/util/virtaudit.c (virAuditSend): Use correct comparison.
---
On 05/26/2011 11:18 AM, Laine Stump wrote:
It was suggested during review of a different patch that the libvirt
interface driver API's should have netcf: in their log
messages. This patch eliminates that from all interface driver API
functions, and also eliminates the extra - in the case
2011/5/18 Taisuke Yamada t...@rakugaki.org:
Hi.
As reported by Diego Blanco in
- https://bugzilla.redhat.com/show_bug.cgi?id=702602
commit f0443765 which replaced openvz_readline to getline(3)
broke OpenVZ driver as it changed semantics of EOF-handling
when parsing OpenVZ configuration.
This testcase passes before the regression is added in f0443765, fails
after that commit and passes again after the regression was fixed.
---
src/openvz/openvz_conf.c |2 +-
src/openvz/openvz_conf.h |1 +
tests/Makefile.am | 18 +
tests/openvzutilstest.c| 91
Since directories can be used for filesystem passthrough, they are
basically storage volumes. Not sure if anyone has an opinion about
not listing directories like ., .., or lost+found, but this patch
doesn't do anything explicit with them.
---
src/storage/storage_backend.c| 34
If we can choose live or config when setting, then we need to
be able to choose which one we are querying.
Also, make the documentation clear that set must use a non-empty
subset (some of the hypervisors fail if params is NULL).
* include/libvirt/libvirt.h.in
* daemon/remote.c (remoteDispatchDomainGetSchedulerParameters):
New function.
* src/remote/remote_driver.c (remoteDomainGetSchedulerParameters):
Likewise.
* src/remote/remote_protocol.x
(remote_domain_get_scheduler_parameters_flags_args)
(remote_domain_get_scheduler_parameters_flags_ret): New
V2 of this original series:
https://www.redhat.com/archives/libvir-list/2011-May/msg01142.html
Changes in this version:
rebase to latest
avoid regression in virTypedParameter consolidation
write new API in terms of virTypedParameter instead of virSchedParameter
Eric Blake (8):
libvirt.h: avoid
Commit 824dcaff was a regression (thankfully unreleased) for any
client code that used 'struct _virSchedParameter' directly rather
than the preferred virSchedParameter typedef. Adding a #define
avoids even that API change, while rearranging the file makes it
clear what the old vs. new API is.
*
Since we can now set just --live or --config, we also need to be
able to query that back.
In the case of setting both --live and --config, it shouldn't matter
which value we read back; otherwise, since querying treats the two
flags as mutually exclusive, so does this patch.
* tools/virsh.c
Rather mechanical in nature.
* src/driver.h: Use newer virTypedParameter API names.
* src/libvirt.c: Likewise.
* daemon/remote.c: Likewise.
* src/esx/esx_driver.c: Likewise.
* src/libxl/libxl_driver.c: Likewise.
* src/lxc/lxc_driver.c: Likewise.
* src/qemu/qemu_driver.c: Likewise.
*
* src/qemu/qemu_driver.c (qemuGetSchedulerParameters): Move
guts...
(qemuGetSchedulerParametersFlags): ...to new callback, and honor
flags more accurately.
---
src/qemu/qemu_driver.c | 77 +---
1 files changed, 66 insertions(+), 11 deletions(-)
diff
On Thu, May 26, 2011 at 03:37:27PM +0530, prakash hr wrote:
I just want to know how the migration is done using libvirt API, I mean the
functions in libvirt does the job of migration.
src/qemu/qemu_migration.c in the libvirt source tree.
Rich.
--
Richard Jones, Virtualization Group, Red Hat
* src/remote/remote_protocol.x (remote_typed_param_value)
(remote_typed_param): New types.
(remote_sched_param_value, remote_sched_param)
(remote_blkio_param_value, remote_blkio_param)
(remote_memory_param_value, remote_memory_param): Delete.
(remote_domain_get_scheduler_parameters_ret)
Well, the remaining drivers that already had the get/set
scheduler parameter functionality to begin with.
For now, this blindly treats VIR_DOMAIN_SCHEDINFO_CURRENT as
the only supported operation for these 5 domains; it will
take domain-specific patches if more specific behavior is
preferred.
*
On Thu, May 26, 2011 at 02:10:24PM -0400, Cole Robinson wrote:
Since directories can be used for filesystem passthrough, they are
basically storage volumes. Not sure if anyone has an opinion about
not listing directories like ., .., or lost+found, but this patch
doesn't do anything explicit
On 05/11/2011 02:36 PM, Stefan Berger wrote:
This patch reorders the locks for the nwfilter updates and the access
the nwfilter objects. In the case that the IP address learning thread
was instantiating filters while an update happened, the previous order
lead to a deadlock.
I am also
On 05/26/2011 12:17 PM, Eric Blake wrote:
If we can choose live or config when setting, then we need to
be able to choose which one we are querying.
Also, make the documentation clear that set must use a non-empty
subset (some of the hypervisors fail if params is NULL).
+int
On 05/26/2011 12:58 PM, Daniel P. Berrange wrote:
On Thu, May 26, 2011 at 02:10:24PM -0400, Cole Robinson wrote:
Since directories can be used for filesystem passthrough, they are
basically storage volumes. Not sure if anyone has an opinion about
not listing directories like ., .., or
Since directories can be used for filesystem passthrough, they are
basically storage volumes.
v2:
Skip ., .., lost+found dirs
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/storage/storage_backend.c| 44 +++--
src/storage/storage_backend.h
2011/5/26 Matthias Bolte matthias.bo...@googlemail.com:
This testcase passes before the regression is added in f0443765, fails
after that commit and passes again after the regression was fixed.
I should have referenced the patch that fixes the regression:
On 05/26/2011 01:34 PM, Cole Robinson wrote:
Since directories can be used for filesystem passthrough, they are
basically storage volumes.
v2:
Skip ., .., lost+found dirs
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/storage/storage_backend.c| 44
On 05/26/2011 12:06 PM, Matthias Bolte wrote:
This testcase passes before the regression is added in f0443765, fails
after that commit and passes again after the regression was fixed.
---
src/openvz/openvz_conf.c |2 +-
src/openvz/openvz_conf.h |1 +
tests/Makefile.am |
On 05/20/2011 04:46 AM, Daniel P. Berrange wrote:
This is exactly the opposite to LIBVIRT_DEBUG=log level which
has
*1: DEBUG
*2: INFO
*3: WARNING
*4: ERROR
IMHO, these need to be kept the same.
Through out virsh.c, the vshDebug is called with the assumption that
On 05/17/2011 08:34 PM, Hu Tao wrote:
This causes problem when setting parameters for an inactive domain, with
--current. In the case, the flags is 0, which fails flag-check in
virDomainSetSchedulerParametersFlags. Maybe we should not check flags
at this stage, and leave it for drivers.
The
Markus Groß wrote:
Am Dienstag 24 Mai 2011 06:06:08 schrieb Jim Fehlig:
+
+event = virDomainEventNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED,
+ VIR_DOMAIN_EVENT_STOPPED_SAVED);
+
+if (libxlVmReap(driver, vm, 1, VIR_DOMAIN_SHUTOFF_SAVED)
On 05/20/2011 03:36 AM, Daniel P. Berrange wrote:
On Fri, May 20, 2011 at 03:05:28PM +0530, Supriya Kannery wrote:
Change log level order so that messages at all other levels get logged
for DEBUG level. Replace magic numbers with corresponding VSH_ERR_xx.
} vshErrorLevel;
NACK I don't
Since directories can be used for filesystem passthrough, they are
basically storage volumes.
v2:
Skip ., .., lost+found dirs
v3:
Use gnulib last_component
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/storage/storage_backend.c| 45
If we can choose live or config when setting, then we need to
be able to choose which one we are querying.
Also, make the documentation clear that set must use a non-empty
subset (some of the hypervisors fail if params is NULL).
* include/libvirt/libvirt.h.in
On 05/26/2011 02:21 PM, Cole Robinson wrote:
Since directories can be used for filesystem passthrough, they are
basically storage volumes.
v2:
Skip ., .., lost+found dirs
v3:
Use gnulib last_component
diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c
On 05/26/2011 12:17 PM, Eric Blake wrote:
V2 of this original series:
https://www.redhat.com/archives/libvir-list/2011-May/msg01142.html
Changes in this version:
rebase to latest
avoid regression in virTypedParameter consolidation
write new API in terms of virTypedParameter instead of
2011/5/26 Eric Blake ebl...@redhat.com:
On 05/26/2011 12:06 PM, Matthias Bolte wrote:
This testcase passes before the regression is added in f0443765, fails
after that commit and passes again after the regression was fixed.
---
src/openvz/openvz_conf.c | 2 +-
src/openvz/openvz_conf.h
Markus Groß wrote:
For core dumping to work correctly the following patch
for xen is needed:
http://lists.xensource.com/archives/html/xen-devel/2011-05/msg01469.html
This patch is in xen-unstable and is considered for backport to
the xen stable branches. Without this patch the mapped
memory
Export a bunch of missing symbols and link the remote driver to gnulib.
---
src/Makefile.am |8 +++-
src/libvirt_private.syms |3 +++
src/libvirt_xenxs.syms | 21 +
3 files changed, 31 insertions(+), 1 deletions(-)
create mode 100644
2011/5/26 Eric Blake ebl...@redhat.com:
On 05/26/2011 09:45 AM, Matthias Bolte wrote:
- if (datastorePath == NULL) {
+ /* If it's an absolute path outside of a datastore just use it as
is */
+ if (result == NULL *fileName == '/') {
+ /* FIXME: need to deal
Markus Groß wrote:
Based on the device attach/detach code from the QEMU driver.
---
src/libxl/libxl_driver.c | 519
++
1 files changed, 519 insertions(+), 0 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index
74 matches
Mail list logo
