Changes made, will submit an updated patchset after finalizing the next
patch.
On 6/13/11 10:50 PM, Eric Blake wrote:
Question: is this sufficient? That is, do all virsh.c callers that read
file contents eventually call into this function, or do you need to also
hook up some other locations
Changes made, will submit an updated patchset after finalizing the rest
of this patch.
On 6/13/11 11:06 PM, Eric Blake wrote:
I'm debating whether this line belongs here, or whether it belongs
better in virsh.c. That is, I don't know whether this is a
virsh-specific feature, or whether all of
Push under trivial rule.
---
src/util/virterror.c | 52 +-
1 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/src/util/virterror.c b/src/util/virterror.c
index 948c8c5..75058f3 100644
--- a/src/util/virterror.c
+++
On Tue, Jun 14, 2011 at 09:25:45AM +0900, Taku Izumi wrote:
On Mon, 13 Jun 2011 23:53:59 +0800
Daniel Veillard veill...@redhat.com wrote:
[...]
Okay, I have commited the patch set, including modified 3/4
thanks a lot !
Thank you!
Hopefully, could you commit the following ?
On Mon, Jun 13, 2011 at 06:55:02PM +0200, Michal Novotny wrote:
This commit introduces the dns element and txt record for the virtual DNS
network. The DNS TXT record can be defined using following syntax in the
network XML file:
dns
txt name=example value=example value /
/dns
Hi,
The following patches add the ability to format filesystem pools when
the appropriate flags are passed to pool build. This patch set introduces
two new flags:
VIR_STORAGE_POOL_BUILD_NO_OVERWRITE causes the build to probe for an
existing pool of the requested type. The build operation
---
tools/virsh.c | 13 -
tools/virsh.pod | 11 ++-
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 863b2de..f9e2fd4 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -6183,6 +6183,8 @@ static const vshCmdInfo
On Mon, Jun 13, 2011 at 04:22:56PM -0600, Eric Blake wrote:
s/superflous/superfluous/
On 06/11/2011 10:18 AM, Guido Günther wrote:
that break compilation on non intel architectures:
mips:
https://buildd.debian.org/status/fetch.php?pkg=libvirtarch=mipsver=0.9.2-1stamp=1307570195
---
configure.ac| 26 ++
libvirt.spec.in |4
2 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac
index f816696..eee5299 100644
--- a/configure.ac
+++ b/configure.ac
@@ -69,6 +69,7 @@ LIBCURL_REQUIRED=7.18.0
On Mon, Jun 13, 2011 at 02:08:14PM -0600, Eric Blake wrote:
On 06/13/2011 01:54 PM, Guido Günther wrote:
since it's needed for the lock manager too. Fixes linking on non intel
architectures. See e.g.
This patch adds the ability to make the filesystem for a filesystem
pool during a pool build.
The patch adds two new flags, no overwrite and overwrite, to control
when mkfs gets executed. By default, the patch preserves the
current behavior, i.e., if no flags are specified, pool build on a
On 14.06.2011 01:51, Eric Blake wrote:
On 06/09/2011 06:24 AM, Michal Prívozník wrote:
From: Michal Privoznik mpriv...@redhat.com
'virsh version' might report against which version of libvirtd is
running.
---
diff to v1:
- added 'daemon' switch
- don't fail when no deamon version is
Hi,
I'm seeing spurious test failures of test-nonblocking-pipe.sh on several
of Debian's autobuilders, e.g.:
https://buildd.debian.org/status/fetch.php?pkg=libvirtarch=mipselver=0.9.2-4stamp=1308020396
Since I can't reproduce this locally I wonder if somebody else is seeing
this?
Cheers,
--
On Tue, Jun 07, 2011 at 09:59:44AM +0900, Minoru Usui wrote:
virNodeGetCPUStats: Define internal driver API
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
src/driver.h |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/src/driver.h b/src/driver.h
On Tue, Jun 07, 2011 at 09:58:47AM +0900, Minoru Usui wrote:
virNodeGetCPUStats: Expose new API
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
include/libvirt/libvirt.h.in | 75
+-
src/libvirt_public.syms |5 +++
2 files changed,
On Tue, Jun 07, 2011 at 10:00:23AM +0900, Minoru Usui wrote:
virNodeGetCPUTime: Implement public API
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
src/libvirt.c | 91
+
1 files changed, 91 insertions(+), 0 deletions(-)
On Tue, Jun 07, 2011 at 10:01:12AM +0900, Minoru Usui wrote:
virNodeGetCPUStats: Implement remote protocol
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
daemon/remote.c | 77
++
src/remote/remote_driver.c | 67
On Tue, Jun 07, 2011 at 10:02:13AM +0900, Minoru Usui wrote:
virNodeGetCPUStats: Implement virsh support
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
tools/virsh.c | 134
+++
tools/virsh.pod |7 +++
2 files changed, 141
2011/6/13 Eric Blake ebl...@redhat.com:
* include/libvirt/libvirt.h.in (virDomainModificationImpact): Reword.
---
include/libvirt/libvirt.h.in | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list
On Mon, Jun 13, 2011 at 06:55:03PM +0200, Michal Novotny wrote:
The regression testing done by comparison of command-line
generated from the network XML file and the expected
command-line arguments (read from file).
For the tests the pidfile should be set to NULL string, i.e.
(null) since
On Tue, Jun 07, 2011 at 10:02:55AM +0900, Minoru Usui wrote:
virNodeGetCPUStats: Implement linux support
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
src/libvirt_private.syms |1 +
src/lxc/lxc_driver.c |1 +
src/nodeinfo.c | 138
On Tue, Jun 07, 2011 at 10:04:12AM +0900, Minoru Usui wrote:
virNodeGetMemoryStats: Define internal driver API
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
src/driver.h |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/src/driver.h b/src/driver.h
On Tue, Jun 07, 2011 at 10:03:36AM +0900, Minoru Usui wrote:
virNodeGetMemoryStats: Expose new API
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
include/libvirt/libvirt.h.in | 78
++
src/libvirt_public.syms |1 +
2 files
On Tue, Jun 07, 2011 at 10:04:54AM +0900, Minoru Usui wrote:
virNodeGetMemoryStats: Implement public API
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
include/libvirt/libvirt.h.in |2 +-
src/libvirt.c| 87
++
2 files
On Tue, Jun 07, 2011 at 10:05:40AM +0900, Minoru Usui wrote:
virNodeGetMemoryStats: Implement remote protocol
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
daemon/remote.c | 77
++
src/remote/remote_driver.c | 65
On Tue, Jun 07, 2011 at 10:09:15AM +0900, Minoru Usui wrote:
virNodeGetMemoryStats: Implement virsh support
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
tools/virsh.c | 62
+++
tools/virsh.pod |5
2 files changed,
On Tue, Jun 07, 2011 at 10:11:17AM +0900, Minoru Usui wrote:
virNodeGetMemoryStats: Implement linux support
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
src/libvirt_private.syms |1 +
src/lxc/lxc_driver.c |1 +
src/nodeinfo.c | 161
2011/6/14 Daniel P. Berrange berra...@redhat.com:
On Tue, Jun 07, 2011 at 05:11:15PM +0800, Lai Jiangshan wrote:
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
src/remote/remote_driver.c | 1 +
src/remote/remote_protocol.x | 16 +++-
src/remote_protocol-structs |
On Tue, Jun 14, 2011 at 11:21:39AM +0200, Matthias Bolte wrote:
2011/6/14 Daniel P. Berrange berra...@redhat.com:
On Tue, Jun 07, 2011 at 05:11:15PM +0800, Lai Jiangshan wrote:
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
src/remote/remote_driver.c | 1 +
2011/6/14 Eric Blake ebl...@redhat.com:
This also reduces malloc pressure for invoking a child when
VIR_DEBUG is enabled.
* src/util/command.c (virExecWithHook): Drop debug, since the only
caller (virCommandRunAsync) also prints debug info.
---
Suggested here:
On 06/14/2011 09:28 AM, Daniel Veillard wrote:
On Mon, Jun 13, 2011 at 06:55:02PM +0200, Michal Novotny wrote:
This commit introduces the dns element and txt record for the virtual DNS
network. The DNS TXT record can be defined using following syntax in the
network XML file:
dns
txt
2011/6/14 Daniel P. Berrange berra...@redhat.com:
On Tue, Jun 14, 2011 at 11:21:39AM +0200, Matthias Bolte wrote:
2011/6/14 Daniel P. Berrange berra...@redhat.com:
On Tue, Jun 07, 2011 at 05:11:15PM +0800, Lai Jiangshan wrote:
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
On Tue, Jun 14, 2011 at 10:15:36AM +0100, Daniel P. Berrange wrote:
On Tue, Jun 07, 2011 at 10:02:55AM +0900, Minoru Usui wrote:
virNodeGetCPUStats: Implement linux support
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
src/libvirt_private.syms |1 +
src/lxc/lxc_driver.c
On Mon, Jun 06, 2011 at 01:17:55PM -0500, Adam Litke wrote:
Set up the types for the block pull functions and insert them into the
virDriver structure definition. Symbols are exported in this patch to prevent
documentation compile failures.
* include/libvirt/libvirt.h.in: new API
*
[snip]
--- /dev/null
+++ b/tests/networkxml2argvtest.c
@@ -0,0 +1,99 @@
+#include config.h
+
+#include stdio.h
+#include stdlib.h
+#include unistd.h
+#include string.h
+
+#include sys/types.h
+#include fcntl.h
+
+#include internal.h
+#include testutils.h
+#include network_conf.h
On Mon, Jun 06, 2011 at 01:17:56PM -0500, Adam Litke wrote:
* src/libvirt.c: implement the main entry points
Signed-off-by: Adam Litke a...@us.ibm.com
---
src/libvirt.c | 252
+
1 files changed, 252 insertions(+), 0 deletions(-)
On Mon, Jun 06, 2011 at 01:17:57PM -0500, Adam Litke wrote:
The generator can handle DomainBlockPullAll and DomainBlockPullAbort.
DomainBlockPull and DomainBlockPullInfo must be written by hand.
* src/remote/remote_protocol.x: provide defines for the new entry points
*
On Thu, Jun 09, 2011 at 12:10:07PM -0500, Adam Litke wrote:
Set up the types for the block pull functions and insert them into the
virDriver structure definition. Symbols are exported in this patch to prevent
documentation compile failures.
* include/libvirt/libvirt.h.in: new API
*
On Thu, Jun 09, 2011 at 12:10:08PM -0500, Adam Litke wrote:
* src/libvirt.c: implement the main entry points
Signed-off-by: Adam Litke a...@us.ibm.com
---
src/libvirt.c | 252
+
1 files changed, 252 insertions(+), 0 deletions(-)
On Thu, Jun 09, 2011 at 12:10:09PM -0500, Adam Litke wrote:
The generator can handle DomainBlockPullAll and DomainBlockPullAbort.
DomainBlockPull and DomainBlockPullInfo must be written by hand.
* src/remote/remote_protocol.x: provide defines for the new entry points
*
On Thu, Jun 09, 2011 at 12:10:10PM -0500, Adam Litke wrote:
The virDomainBlockPull* family of commands are enabled by the
'block_stream' and 'info block_stream' qemu monitor commands.
* src/qemu/qemu_driver.c src/qemu/qemu_monitor_text.[ch]: implement disk
streaming by using the stream and
On Thu, Jun 09, 2011 at 12:10:11PM -0500, Adam Litke wrote:
Define three new virsh commands:
* blockpull: Perform incremental block pull
* blockpull: Start/stop full device block pull
* blockpullinfo: Retrieve progress info for full device block pull
Share print_job_progress() with the
On Thu, Jun 09, 2011 at 12:10:12PM -0500, Adam Litke wrote:
virDomainBlockPullAll and virDomainBlockPullAbort are handled automatically.
virDomainBlockPull and virDomainBlockPullInfo require manual overrides since
they return a custom type.
* python/generator.py: reenable bindings for this
On Thu, Jun 09, 2011 at 12:10:13PM -0500, Adam Litke wrote:
When an operation started by virDomainBlockPullAll completes (either with
success or with failure), raise an event to indicate the final status. This
allows an API user to avoid polling on virDomainBlockPullInfo if they would
prefer
On Thu, Jun 09, 2011 at 12:10:14PM -0500, Adam Litke wrote:
*** Please do not consider for merging, example tests only ***
Here are the testcases I am currently running to verify the correctness of
this
API. These are continuing to evolve.
Signed-off-by: Adam Litke a...@us.ibm.com
---
On Tue, Jun 14, 2011 at 10:58:59AM +0200, Guido Günther wrote:
Hi,
I'm seeing spurious test failures of test-nonblocking-pipe.sh on several
of Debian's autobuilders, e.g.:
https://buildd.debian.org/status/fetch.php?pkg=libvirtarch=mipselver=0.9.2-4stamp=1308020396
Since I can't reproduce
2011/6/14 Eric Blake ebl...@redhat.com:
Suggested here:
https://www.redhat.com/archives/libvir-list/2011-May/msg00594.html
* src/storage/storage_backend.c (virStorageBackendCreateQemuImg):
Generate size inline.
---
src/storage/storage_backend.c | 20 ++--
1 files
2011/6/14 Eric Blake ebl...@redhat.com:
Previously, the parent process opened 'null' to /dev/null, then
the child process closes 'null' as well as 'childout'. But if
childout was set to be null, then this is a double close. At
least the double close was confined to the child process after a
I've attached a diff at the end that will address all the problems I've
brought up in my review. I can either squash that in and push the result
(once the rest of the series is reviewed and ready), or Michal can
squash it into his local tree and resubmit.
On 06/13/2011 12:55 PM, Michal
From a security pov copy and paste between the guest and the client is not
always desirable. So we need to be able to enable/disable this. The best place
to do this from an administration pov is on the hypervisor, so the qemu cmdline
is getting a spice disable-copy-paste option, see bug 693645.
On Mon, 2011-06-13 at 12:09 -0600, Eric Blake wrote:
/tmp is probably not the best place; we already have a hierarchy under
/var/run/libvirt/ and this information should live somewhere in that
hierarchy.
How about /var/run/libvirt/network ?
--
Best regards,
Gerhard Stenzel,
On 06/14/2011 01:16 PM, Laine Stump wrote:
I've attached a diff at the end that will address all the problems I've
brought up in my review. I can either squash that in and push the result
(once the rest of the series is reviewed and ready), or Michal can
squash it into his local tree and
On 06/13/2011 12:55 PM, Michal Novotny wrote:
The regression testing done by comparison of command-line
generated from the network XML file and the expected
command-line arguments (read from file).
For the tests the pidfile should be set to NULL string, i.e.
(null) since no real invocation of
This commit introduces names definition for the DNS hosts file using
the following syntax:
dns
host ip=192.168.1.1
namealias1/name
namealias2/name
/host
/dns
Signed-off-by: Michal Novotny minov...@redhat.com
---
docs/formatnetwork.html.in|9
This patch moves the dnsmasqContext creation to the
networkSaveDnsmasqHostsfile()
and saves and passes the hostsfile to the dnsmasq only if applicable.
Signed-off-by: Michal Novotny minov...@redhat.com
---
src/network/bridge_driver.c| 38 +++-
Hi,
this is the patch to introduce the TXT record and DNS hosts support
for the DNS service on the virtual network. This can be defined using
the txt-record subelement in the dns element of the network XML
description. The definition of TXT record names containing spaces
is rejected with the error
The regression testing done by comparison of command-line
generated from the network XML file and the expected
command-line arguments (read from file).
For the tests the pidfile should be set to NULL string, i.e.
(null) since no real invocation of the command is being done,
just the command-line
This commit introduces the dns element and txt record for the virtual DNS
network. The DNS TXT record can be defined using following syntax in the
network XML file:
dns
txt name=example value=example value /
/dns
Also, the Relax-NG scheme has been altered to allow the texts without
Signed-off-by: Michal Novotny minov...@redhat.com
---
docs/formatnetwork.html.in | 14 ++
src/libvirt_private.syms|1 +
src/network/bridge_driver.c |3 +
src/util/dnsmasq.c | 285 ---
src/util/dnsmasq.h | 22 +++-
5 files
On 06/14/2011 04:49 AM, Daniel P. Berrange wrote:
On Thu, Jun 09, 2011 at 12:10:08PM -0500, Adam Litke wrote:
+if (flags != 0) {
+virLibDomainError(VIR_ERR_INVALID_ARG,
+ _(flags must be zero));
+goto error;
+}
We don't want to check
On 06/14/2011 04:49 AM, Daniel P. Berrange wrote:
On Thu, Jun 09, 2011 at 12:10:09PM -0500, Adam Litke wrote:
The generator can handle DomainBlockPullAll and DomainBlockPullAbort.
DomainBlockPull and DomainBlockPullInfo must be written by hand.
* src/remote/remote_protocol.x: provide
On Mon, Jun 13, 2011 at 06:55:03PM +0200, Michal Novotny wrote:
diff --git a/tests/networkxml2argvdata/isolated-network.argv
b/tests/networkxml2argvdata/isolated-network.argv
new file mode 100644
index 000..dce6034
--- /dev/null
+++ b/tests/networkxml2argvdata/isolated-network.argv
@@
On Tue, Jun 14, 2011 at 11:37:32AM +0200, Michal Novotny wrote:
On 06/14/2011 09:28 AM, Daniel Veillard wrote:
On Mon, Jun 13, 2011 at 06:55:02PM +0200, Michal Novotny wrote:
This commit introduces the dns element and txt record for the virtual
DNS
network. The DNS TXT record can be
On Tue, Jun 14, 2011 at 11:42:42AM +0200, Michal Novotny wrote:
[snip]
Well, don't know exactly however I did to rewrite this for the latest
codebase since test infrastructure changed since last version of my
patch. However the strange thing is that it's working fine on my F-14
i386 box. Need
On 06/14/2011 03:26 PM, Daniel P. Berrange wrote:
On Mon, Jun 13, 2011 at 06:55:03PM +0200, Michal Novotny wrote:
diff --git a/tests/networkxml2argvdata/isolated-network.argv
b/tests/networkxml2argvdata/isolated-network.argv
new file mode 100644
index 000..dce6034
--- /dev/null
+++
On 06/14/2011 04:59 AM, Daniel P. Berrange wrote:
+static bool
+cmdBlockPullAll(vshControl *ctl, const vshCmd *cmd)
+{
+int mode;
+
+if (vshCommandOptBool (cmd, abort))
+mode = VSH_CMD_BLOCK_PULL_ABORT;
+else
+mode = VSH_CMD_BLOCK_PULL_ALL;
+
+if
(please cc me in response as I have not subscribed to this list)
Hi all,
A minor nitpick:
Every-time I suggest someone to do a force shut-down a guest using 'virsh destroy foo' ,
the very first question I get is -- does it _destroy_ my data?
This causes confusion to the inexperienced user
sVirt provides SELinux MAC isolation for Qemu guest processes and their
corresponding resources (image files). sVirt provides this support
by labeling guests and resources with security labels that are stored
in file system extended attributes. Some file systems, such as NFS, do
not support the
On 06/14/2011 05:03 AM, Daniel P. Berrange wrote:
+static virDomainEventPtr
+virDomainEventBlockPullNew(int id, const char *name, unsigned char *uuid,
+ const char *path, int status)
+{
+virDomainEventPtr ev =
+
Hi Kashyap,
I remember we were talking about this on IRC and I know it could make
confusion and first time I've been using the destroy command of virsh I
remember I've been asking somebody the same thing.
The issue is that this command exists in virsh/libvirt for a really long
and I don't know
On 14.06.2011 12:31, Kashyap Chamarthy wrote:
(please cc me in response as I have not subscribed to this list)
Hi all,
A minor nitpick:
Every-time I suggest someone to do a force shut-down a guest using
'virsh destroy foo' , the very first question I get is -- does it
_destroy_ my
On 06/14/2011 04:15 PM, Michal Privoznik wrote:
On 14.06.2011 12:31, Kashyap Chamarthy wrote:
(please cc me in response as I have not subscribed to this list)
Hi all,
A minor nitpick:
Every-time I suggest someone to do a force shut-down a guest using
'virsh destroy foo' , the very first
On 06/14/2011 12:12 AM, Michael Williams wrote:
isatty() produces the correct behavior in all cases but the first one
you mentioned, ie running virsh define, which will not wait for input
with the patch as it is.
I see the ctl-imode parameter used in main() to determine the
interactivity of
On 06/14/2011 07:53 PM, Michal Novotny wrote:
On 06/14/2011 04:15 PM, Michal Privoznik wrote:
On 14.06.2011 12:31, Kashyap Chamarthy wrote:
(please cc me in response as I have not subscribed to this list)
Hi all,
A minor nitpick:
Every-time I suggest someone to do a force shut-down a guest
On 06/14/2011 04:26 PM, Kashyap Chamarthy wrote:
On 06/14/2011 07:53 PM, Michal Novotny wrote:
On 06/14/2011 04:15 PM, Michal Privoznik wrote:
On 14.06.2011 12:31, Kashyap Chamarthy wrote:
(please cc me in response as I have not subscribed to this list)
Hi all,
A minor nitpick:
Set up the types for the block pull functions and insert them into the
virDriver structure definition. Symbols are exported in this patch to prevent
documentation compile failures.
* include/libvirt/libvirt.h.in: new API
* src/driver.h: add the new entry to the driver structure
*
The generator can handle DomainBlockPullAll and DomainBlockPullAbort.
DomainBlockPull and DomainBlockPullInfo must be written by hand.
* src/remote/remote_protocol.x: provide defines for the new entry points
* src/remote/remote_driver.c daemon/remote.c: implement the client and
server side
*
*** Please do not consider for merging, example tests only ***
Here are the testcases I am currently running to verify the correctness of this
API. These are continuing to evolve.
Signed-off-by: Adam Litke a...@us.ibm.com
---
blockPull-test.py | 301
* src/libvirt.c: implement the main entry points
Signed-off-by: Adam Litke a...@us.ibm.com
Acked-by: Daniel P. Berrange berra...@redhat.com
---
src/libvirt.c | 228 +
1 files changed, 228 insertions(+), 0 deletions(-)
diff --git
This round addresses all review comments from the last posting and should be
ready for inclusion. Thanks for the review.
Changes since V3:
- Don't check flags at the libvirt API level
- qemu: Check disk-type before looking up alias
- virsh: Merge blockpullall into blockpull
- event: Drop
When an operation started by virDomainBlockPullAll completes (either with
success or with failure), raise an event to indicate the final status. This
allows an API user to avoid polling on virDomainBlockPullInfo if they would
prefer to use the event mechanism.
* daemon/remote.c: Dispatch events
The virDomainBlockPull* family of commands are enabled by the
'block_stream' and 'info block_stream' qemu monitor commands.
* src/qemu/qemu_driver.c src/qemu/qemu_monitor_text.[ch]: implement disk
streaming by using the stream and info stream text monitor commands
*
The LXC driver networking uses veth device pairs. These can
be easily hooked into the network filtering code.
* src/lxc/lxc_driver.c: Add calls to setup/teardown nwfilter
New in v2:
- Add missing hooks for automatic rebuild of filters for
online guests
---
src/lxc/lxc_driver.c | 40
On Tue, Jun 07, 2011 at 09:51:56AM -0400, Stefan Berger wrote:
Daniel P. Berrange berra...@redhat.com wrote on 06/07/2011 09:36:22
AM:
The LXC driver networking uses veth device pairs. These can
be easily hooked into the network filtering code.
* src/lxc/lxc_driver.c: Add calls
On 06/13/2011 02:06 PM, Eric Blake wrote:
On 06/08/2011 10:36 AM, Cole Robinson wrote:
If qemu supports -chardev, our char frontend aliases are ex. 'charserial0'
not just 'serial0'. Typically we don't use this code path because the
pty's are scraped from stdout.
Signed-off-by: Cole Robinson
On 06/14/2011 08:46 AM, Daniel P. Berrange wrote:
The LXC driver networking uses veth device pairs. These can
be easily hooked into the network filtering code.
* src/lxc/lxc_driver.c: Add calls to setup/teardown nwfilter
New in v2:
- Add missing hooks for automatic rebuild of filters
The domain lock manager forgot to include a bunch of checks
for NULL which could occur on OOM
* src/locking/domain_lock.c: Add checks for NULL
---
src/locking/domain_lock.c | 49 ++--
1 files changed, 38 insertions(+), 11 deletions(-)
diff --git
If the 'mac_filter' configuration parameter is enabled, and there
is a failure to enable filtering, no error is reported back to
the caller. Also fix some bogus whitespace indentation for
hugetlbfs_mount
* src/qemu/qemu_conf.c: Add missing error reporting
---
src/qemu/qemu_conf.c | 24
Most of the safezero() implementations return -1 on error,
setting errno. The safezero() impl using posix_fallocate()
though returned a positive errno value on error (due to
the unusual API contract of posix_fallocate() compared to
most syscall APIs).
* src/util/util.c: Ensure safezero() returns
The virt-tools.org website, launched last year, provides tutorials,
videos, documentation, online help and roadmaps relevant to libvirt,
libguestfs, gtk-vnc, spice, other related libraries, and tools or
applications like virt-manager virt-install. The site goal is to
inform assist end users,
On 06/14/2011 08:57 AM, Daniel P. Berrange wrote:
If the 'mac_filter' configuration parameter is enabled, and there
is a failure to enable filtering, no error is reported back to
the caller. Also fix some bogus whitespace indentation for
hugetlbfs_mount
I probably would have split this into
On 06/14/2011 08:57 AM, Daniel P. Berrange wrote:
The domain lock manager forgot to include a bunch of checks
for NULL which could occur on OOM
* src/locking/domain_lock.c: Add checks for NULL
---
src/locking/domain_lock.c | 49 ++--
1 files
On 06/14/2011 08:58 AM, Daniel P. Berrange wrote:
Most of the safezero() implementations return -1 on error,
setting errno. The safezero() impl using posix_fallocate()
though returned a positive errno value on error (due to
the unusual API contract of posix_fallocate() compared to
most
On Tue, Jun 14, 2011 at 09:05:55AM -0600, Eric Blake wrote:
On 06/14/2011 08:58 AM, Daniel P. Berrange wrote:
Most of the safezero() implementations return -1 on error,
setting errno. The safezero() impl using posix_fallocate()
though returned a positive errno value on error (due to
the
On 06/14/2011 04:24 AM, Matthias Bolte wrote:
2011/6/14 Eric Blake ebl...@redhat.com:
Suggested here:
https://www.redhat.com/archives/libvir-list/2011-May/msg00594.html
* src/storage/storage_backend.c (virStorageBackendCreateQemuImg):
Generate size inline.
---
On 06/14/2011 03:07 AM, Matthias Bolte wrote:
2011/6/13 Eric Blake ebl...@redhat.com:
* include/libvirt/libvirt.h.in (virDomainModificationImpact): Reword.
---
include/libvirt/libvirt.h.in | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
ACK.
Thanks; pushed.
--
On 06/07/2011 05:38 AM, Matthias Bolte wrote:
Shared folders are handled as filesystems and can also be hotplugged.
---
Currently this just maps shared folder to a filesystem element with type
mount. The filesystem element has an accessmode attribute that is not
useful for VirtualBox. Als
On 06/12/2011 04:37 PM, Guido Günther wrote:
since the testfiles assume a /proc/cpuinfo specific to this
architecture. We e.g. can't parse the number of cores on other
architectures.
O.k. to apply?
Cheers,
-- Guido
---
tests/nodeinfotest.c |4 +++-
1 files changed, 3
On 06/14/2011 07:31 AM, Corey Bryant wrote:
This patch contains the Qemu code to support this solution. I would
like to solicit input from the libvirt community prior to starting
the libvirt patch.
Currently, Qemu opens an image file in addition to performing the
necessary read and write
For virtio disks and interfaces, qemu allows users to enable or disable
ioeventfd feature. This means, qemu can execute domain code, while
another thread waits for I/O event. Basically, in some cases it is win,
in some loss. This feature is available via 'asyncio' attribute in disk
and interface
1 - 100 of 143 matches
Mail list logo
