At 06/30/2011 11:36 AM, Daniel Veillard Write:
Following the changes done in the daemon and client code to use the
new RPC implementation, and the large amount of patches and fixes since
RC1 I have made a new release candidate RC2 based on current git.
于 2011年06月30日 00:26, Eric Blake 写道:
On 06/29/2011 06:19 AM, Osier Yang wrote:
These two patches is to introduce two new virsh commands, one is
eject-media, which is to eject media from CD or floppy drive, the other
is insert-media, which is to insert media into CD or floppy drive.
There are
On Thu, 30 Jun 2011 11:19:14 +0800
Wen Congyang we...@cn.fujitsu.com wrote:
Introduce new command vcpu-bandwidth to change and query bandwidth for each
vcpu.
Usage:
1. query bandwidth for all vcpus:
# virsh vcpu-bandwidth domain
2. query bandwidth for a vcpu:
# virsh
于 2011年06月30日 11:36, Daniel Veillard 写道:
Following the changes done in the daemon and client code to use the
new RPC implementation, and the large amount of patches and fixes since
RC1 I have made a new release candidate RC2 based on current git.
At 06/30/2011 03:27 PM, Taku Izumi Write:
On Thu, 30 Jun 2011 11:19:14 +0800
Wen Congyang we...@cn.fujitsu.com wrote:
Introduce new command vcpu-bandwidth to change and query bandwidth for each
vcpu.
Usage:
1. query bandwidth for all vcpus:
# virsh vcpu-bandwidth domain
2. query
At 06/30/2011 11:09 AM, Wen Congyang Write:
---
src/conf/domain_conf.c | 272
++-
src/conf/domain_conf.h | 25 ++
src/libvirt_private.syms|4 +
src/qemu/qemu_cgroup.c
Virsh logging has some basic issues:
1. In code, magic numbers are used for logging rather than loglevel
variables.
2. Magic number 5 is used for logging which doesn't map to any
loglevel variable. Valid loglevel range is 0-4
3. Usage of loglevel variables doesn't align with that of libvirt
Aligning loglevel values of virsh to that of libvirt.
DEBUG=0 loglevel, when specified through commandline or
env variable, should log all the messages. ERROR=4
should log only error messages.
Signed-off-by: Supriya Kannery supri...@in.ibm.com
---
tools/virsh.c | 12
1 file
Replace magic numbers with loglevel variables.
Signed-off-by: Supriya Kannery supri...@in.ibm.com
---
tools/virsh.c | 112 +-
1 file changed, 65 insertions(+), 47 deletions(-)
Index: libvirt/tools/virsh.c
Valid loglevel range for virsh is 0-4. Update virsh man page
accordingly. Also explain virsh ENV variables and values.
Signed-off-by: Supriya Kannery supri...@in.ibm.com
---
tools/virsh.pod | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
Index:
On 05/27/2011 01:39 AM, Eric Blake wrote:
On 05/20/2011 03:36 AM, Daniel P. Berrange wrote:
On Fri, May 20, 2011 at 03:05:28PM +0530, Supriya Kannery wrote:
Change log level order so that messages at all other levels get logged
for DEBUG level. Replace magic numbers with corresponding
Hi, Eric
On Wed, 29 Jun 2011 11:52:41 -0600
Eric Blake ebl...@redhat.com wrote:
Incorporating my own suggestions from earlier rounds of review.
Minoru's original 2/2 patch is unchanged.
I think this series is probably worth including in 0.9.3, since
it is fixing a just-added feature, but
It doesn't generate name and format nodes for source
even if they are explictly specified. This patch fixes it.
---
tools/virsh.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index d15d206..e82ddae 100644
--- a/tools/virsh.c
+++
sysinfo: delete unnecessary white space of sysinfo.
* Trim each element and delete null entry of sysinfo by
virSkipSpacesBackwards().
This patch is rebased to following Eric's patches.
Eric's 1/3, 2/3 patches do not change.
http://www.spinics.net/linux/fedora/libvir/msg41063.html
On Thu, Jun 30, 2011 at 11:16:27AM +0800, Gui Jianfeng wrote:
Since we have controlled Guest cpu affinity by using cpuset cgroup.
Get rid of this part.
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
---
src/qemu/qemu_process.c |6 --
1 files changed, 0 insertions(+), 6
On Thu, Jun 30, 2011 at 11:08:32AM +0800, Gui Jianfeng wrote:
Currently, libvirt makes use of sched_setaffinity() to set Guest processes's
cpu affinity. But, sometimes, for instance, when QEmu uses vhost-net, the
kernel part of vhost will create a kernel thread for some purpose. In this
case,
LVM allows one specify the VG with VG path like /dev/lv_pool, and
it gets the correct VG name internally by skipping /dev.
snip
vg_name = skip_dev_dir(cmd, argv[0], NULL);
if (strrchr(vg_name, '/')) {
log_error(Volume group name expected
(no slash));
On Thu, Jun 30, 2011 at 06:40:20PM +0800, Osier Yang wrote:
LVM allows one specify the VG with VG path like /dev/lv_pool, and
it gets the correct VG name internally by skipping /dev.
snip
vg_name = skip_dev_dir(cmd, argv[0], NULL);
if (strrchr(vg_name, '/')) {
Hi All
I am working on integrating GlusterFS with OpenStack so that VM volumes can
be placed on shared GlusterFS volumes. I would highly appreciate if you
please help me find the answers to some questions:
1. Whats the difference between a storage driver and a storage backend driver?
2. Why
These patches do three small fixes to the RPC code in libvirtd
to make sure stream upload works correctly again
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
The virNetServerClient object had a hardcoded limit of 10 requests
per client. Extend constructor to allow it to be passed in as a
configurable variable. Wire this up to the 'max_client_requests'
config parameter in libvirtd
* daemon/libvirtd.c: Pass max_client_requests into services
*
To save on memory reallocation, virNetMessage instances that
have been transmitted, may be reused for a subsequent incoming
message. We forgot to clear out the old data of the message
fully, which caused later confusion upon read.
* src/rpc/virnetserverclient.c: memset entire message before
The stream code was reusing a stream message object before
it was removed from the linked list of filtered messages.
This caused any later queued messages to be completely lost.
* daemon/stream.c: Delay reuse of stream message until
after it is removed from the queue
---
daemon/stream.c | 20
I am happy to announce a new release[1] of the libvirt Perl bindings,
Sys::Virt 0.2.8 is available for download:
http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.2.8.tar.gz
Changes in this release
- Add all new APIs in libvirt 0.9.0
- Add examples for different ways of using
On Thu, Jun 30, 2011 at 12:29:48PM +0100, Daniel P. Berrange wrote:
These patches do three small fixes to the RPC code in libvirtd
to make sure stream upload works correctly again
FYI, this was discovered validated using 6 test scripts I just added
to the TCK to cover the different ways you
* src/rpc/virnetserver.c: Free mdnsGroupName
---
src/rpc/virnetserver.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
index 8a2b113..0ef81fd 100644
--- a/src/rpc/virnetserver.c
+++ b/src/rpc/virnetserver.c
@@ -746,6
When adding a callback to an FD stream, we take an extra reference
on the virStreamPtr instance. We forgot to registered a free function
with the callback, so when the callback was removed, the extra
reference held on virStreamPtr was not released.
* src/fdstream.c: Use a free callback to release
On 06/30/2011 12:04 AM, Wen Congyang wrote:
At 06/30/2011 11:36 AM, Daniel Veillard Write:
Following the changes done in the daemon and client code to use the
new RPC implementation, and the large amount of patches and fixes since
RC1 I have made a new release candidate RC2 based on current
On 06/30/2011 01:55 AM, Osier Yang wrote:
于 2011年06月30日 11:36, Daniel Veillard 写道:
Following the changes done in the daemon and client code to use the
new RPC implementation, and the large amount of patches and fixes since
RC1 I have made a new release candidate RC2 based on current git.
On 06/30/2011 03:23 AM, Osier Yang wrote:
It doesn't generate name and format nodes for source
even if they are explictly specified. This patch fixes it.
s/explictly/explicitly/
---
tools/virsh.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c
于 2011年06月30日 21:34, Eric Blake 写道:
On 06/30/2011 03:23 AM, Osier Yang wrote:
It doesn't generate name andformat nodes forsource
even if they are explictly specified. This patch fixes it.
s/explictly/explicitly/
---
tools/virsh.c |2 +-
1 files changed, 1 insertions(+), 1
于 2011年06月30日 18:22, Daniel P. Berrange 写道:
On Thu, Jun 30, 2011 at 06:40:20PM +0800, Osier Yang wrote:
LVM allows one specify the VG with VG path like /dev/lv_pool, and
it gets the correct VG name internally by skipping /dev.
snip
vg_name = skip_dev_dir(cmd, argv[0], NULL);
if
The event handler functions do not free the virJSONValuePtr
object. Every event received from a VM thus caused a memory
leak
* src/qemu/qemu_monitor_json.c: Fix leak of event object
---
src/qemu/qemu_monitor_json.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git
The qemudDomainSaveFlag method will call EndJob on the 'vm'
object it is passed in. This can result in the 'vm' object
being free'd if the last reference is removed. Thus no caller
of 'qemudDomainSaveFlag' must *ever* reference 'vm' again
upon return.
Unfortunately qemudDomainSave and
The 'function' field in the PCI address was not correctly
initialized, so it was building the wrong address address
string and so not removing all functions from the in use
list.
* src/qemu/qemu_command.c: Fix initialization of PCI function
---
src/qemu/qemu_command.c |6 +++---
1 files
While investigating some memory leaks it was unclear whether the
JSON code correctly free'd all memory during parsing. Add a test
case which can be run under valgrind to clearly demonstrate that
the parser is leak free.
* tests/Makefile.am: Add 'jsontest'
* tests/jsontest.c: A few simple JSON
The 'char control[CMSG_SPACE(sizeof(int))];' was not being
wiped, so could potentially contain uninitialized bytes.
While this was harmless in this case, it caused complaints
from valgrind
* src/qemu/qemu_monitor.c: memset 'control' variable
in qemuMonitorIOWriteWithFD
---
* src/util/json.c: Remove warning message
---
src/util/json.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/util/json.c b/src/util/json.c
index 48521f2..a85f580 100644
--- a/src/util/json.c
+++ b/src/util/json.c
@@ -950,7 +950,6 @@ cleanup:
if (parser.nstate)
Detected by Coverity. Both are instances of bad things happening
if pipe2 fails; the virNetClientNew failure could free garbage,
and virNetSocketNewConnectCommand could close random fds.
Note: POSIX doesn't guarantee the contents of fd[0] and fd[1]
after pipe failure:
Detected by Coverity; neither vshCmddefHelp nor vshCmdOptParse
was initializing opts_required.
* tools/virsh.c (vshCmddefOptParse): Always initialize bitmaps.
---
tools/virsh.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index
I ran Coverity on the state of yesterday's git; while I have not
finished reading through all the findings, I figured I'd get some
review started on these.
Eric Blake (4):
virsh: avoid integer overflow
virsh: avoid uninitialized variable
rpc: avoid freeing uninitialized variable
build:
Detected by Coverity. info.nrVirtCpu is unsigned short, but if
cpumaplen is int, then the product of the two in vshMalloc risks
unintended sign extension. cmdVcpuinfo had already solved this
by using size_t cpumaplen.
* tools/virsh.c (cmdVcpuPin): Use correct type.
---
tools/virsh.c |2 +-
Based on Coverity's finding on the previous patch, I audited
gnulib's pipe2 code and found that we had the potential for
a subtle double-close bug, unless gnulib guarantees that the
contents of the fd array are unchanged on pipe2() failure.
* .gnulib: Update to latest, for pipe2 fix.
---
.gnulib
On 06/30/2011 08:09 AM, Daniel P. Berrange wrote:
The 'function' field in the PCI address was not correctly
initialized, so it was building the wrong address address
string and so not removing all functions from the in use
list.
* src/qemu/qemu_command.c: Fix initialization of PCI function
On 06/30/2011 08:10 AM, Daniel P. Berrange wrote:
The event handler functions do not free the virJSONValuePtr
object. Every event received from a VM thus caused a memory
leak
* src/qemu/qemu_monitor_json.c: Fix leak of event object
---
src/qemu/qemu_monitor_json.c |5 ++---
1 files
On 06/30/2011 08:10 AM, Daniel P. Berrange wrote:
The 'char control[CMSG_SPACE(sizeof(int))];' was not being
wiped, so could potentially contain uninitialized bytes.
While this was harmless in this case, it caused complaints
from valgrind
* src/qemu/qemu_monitor.c: memset 'control' variable
On 06/30/2011 08:10 AM, Daniel P. Berrange wrote:
The qemudDomainSaveFlag method will call EndJob on the 'vm'
object it is passed in. This can result in the 'vm' object
being free'd if the last reference is removed. Thus no caller
of 'qemudDomainSaveFlag' must *ever* reference 'vm' again
upon
On 06/30/2011 08:09 AM, Daniel P. Berrange wrote:
* src/util/json.c: Remove warning message
---
src/util/json.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/util/json.c b/src/util/json.c
index 48521f2..a85f580 100644
--- a/src/util/json.c
+++
On Thu, Jun 30, 2011 at 08:14:55AM -0600, Eric Blake wrote:
Detected by Coverity. Both are instances of bad things happening
if pipe2 fails; the virNetClientNew failure could free garbage,
and virNetSocketNewConnectCommand could close random fds.
Note: POSIX doesn't guarantee the contents
On Thu, Jun 30, 2011 at 08:14:56AM -0600, Eric Blake wrote:
Based on Coverity's finding on the previous patch, I audited
gnulib's pipe2 code and found that we had the potential for
a subtle double-close bug, unless gnulib guarantees that the
contents of the fd array are unchanged on pipe2()
On Thu, Jun 30, 2011 at 08:14:54AM -0600, Eric Blake wrote:
Detected by Coverity; neither vshCmddefHelp nor vshCmdOptParse
was initializing opts_required.
* tools/virsh.c (vshCmddefOptParse): Always initialize bitmaps.
---
tools/virsh.c |5 -
1 files changed, 4 insertions(+), 1
On Thu, Jun 30, 2011 at 08:14:53AM -0600, Eric Blake wrote:
Detected by Coverity. info.nrVirtCpu is unsigned short, but if
cpumaplen is int, then the product of the two in vshMalloc risks
unintended sign extension. cmdVcpuinfo had already solved this
by using size_t cpumaplen.
*
On 06/30/2011 08:10 AM, Daniel P. Berrange wrote:
While investigating some memory leaks it was unclear whether the
JSON code correctly free'd all memory during parsing. Add a test
case which can be run under valgrind to clearly demonstrate that
the parser is leak free.
* tests/Makefile.am:
Hi,
I get this error when compiling 0.9.3-rc2 on FreeBSD. Is there a fix for
this?
rpc/virnetsocket.c: In function 'virNetSocketFree':
rpc/virnetsocket.c:654: warning: implicit declaration of function 'kill'
rpc/virnetsocket.c:654: warning: nested extern declaration of 'kill'
[-Wnested-externs]
On Thu, Jun 30, 2011 at 07:36:24AM -0700, Jason Helfman wrote:
Hi,
I get this error when compiling 0.9.3-rc2 on FreeBSD. Is there a fix for
this?
rpc/virnetsocket.c: In function 'virNetSocketFree':
rpc/virnetsocket.c:654: warning: implicit declaration of function 'kill'
---
tests/Makefile.am |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7db9d1f..e6c5a5e 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -74,7 +74,8 @@ EXTRA_DIST = \
xencapsdata \
xmconfigdata
On 06/30/2011 06:14 AM, Daniel P. Berrange wrote:
* src/rpc/virnetserver.c: Free mdnsGroupName
---
src/rpc/virnetserver.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
index 8a2b113..0ef81fd 100644
---
On 06/30/2011 06:14 AM, Daniel P. Berrange wrote:
When adding a callback to an FD stream, we take an extra reference
on the virStreamPtr instance. We forgot to registered a free function
with the callback, so when the callback was removed, the extra
reference held on virStreamPtr was not
On 06/30/2011 08:53 AM, Daniel P. Berrange wrote:
On Thu, Jun 30, 2011 at 07:36:24AM -0700, Jason Helfman wrote:
Hi,
I get this error when compiling 0.9.3-rc2 on FreeBSD. Is there a fix for
this?
We're using 'kill' without explicitly including signal.h. I suspect
we're lucky to get it
On 06/30/2011 09:31 AM, Osier Yang wrote:
---
tests/Makefile.am |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7db9d1f..e6c5a5e 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -74,7 +74,8 @@ EXTRA_DIST =
On 06/30/2011 05:29 AM, Daniel P. Berrange wrote:
The virNetServerClient object had a hardcoded limit of 10 requests
per client. Extend constructor to allow it to be passed in as a
configurable variable. Wire this up to the 'max_client_requests'
config parameter in libvirtd
*
On 06/30/2011 05:29 AM, Daniel P. Berrange wrote:
To save on memory reallocation, virNetMessage instances that
have been transmitted, may be reused for a subsequent incoming
message. We forgot to clear out the old data of the message
fully, which caused later confusion upon read.
*
On 06/30/2011 05:29 AM, Daniel P. Berrange wrote:
The stream code was reusing a stream message object before
it was removed from the linked list of filtered messages.
This caused any later queued messages to be completely lost.
* daemon/stream.c: Delay reuse of stream message until
after
于 2011年06月30日 23:07, Eric Blake 写道:
On 06/30/2011 09:31 AM, Osier Yang wrote:
---
tests/Makefile.am |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7db9d1f..e6c5a5e 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
The virDomainMigratePrepareTunnel3 impl in the remote driver
was using the procedure number for the virDomainMigratePrepareTunnel
method. This doesn't work out so well, because it makes the server
ignore drop all stream packets
* src/remote/remote_driver.c: Fix procedure for PrepareTunnel3
---
If a message packet for a invalid stream is received it is just
free'd. This is not good because it doesn't let the client RPC
request counter decrement. If a stream is shutdown with pending
packets the message also isn't released properly because of an
incorrect header type
* daemon/stream.c:
We ignore any stream data packets which come in for streams which
are not registered, since these packets are async and do not have
a reply. If we get a stream control packet though we must send back
an actual error, otherwise a (broken) client may hang forever
making it hard to diagnose the
On 06/30/2011 10:09 AM, Daniel P. Berrange wrote:
If a message packet for a invalid stream is received it is just
free'd. This is not good because it doesn't let the client RPC
request counter decrement. If a stream is shutdown with pending
packets the message also isn't released properly
On 06/30/2011 10:10 AM, Daniel P. Berrange wrote:
We ignore any stream data packets which come in for streams which
are not registered, since these packets are async and do not have
a reply. If we get a stream control packet though we must send back
an actual error, otherwise a (broken) client
On 06/30/2011 10:10 AM, Daniel P. Berrange wrote:
The virDomainMigratePrepareTunnel3 impl in the remote driver
was using the procedure number for the virDomainMigratePrepareTunnel
method. This doesn't work out so well, because it makes the server
ignore drop all stream packets
*
On Thu, Jun 30, 2011 at 10:22:59AM -0600, Eric Blake wrote:
On 06/30/2011 10:10 AM, Daniel P. Berrange wrote:
The virDomainMigratePrepareTunnel3 impl in the remote driver
was using the procedure number for the virDomainMigratePrepareTunnel
method. This doesn't work out so well, because it
On Thu, Jun 30, 2011 at 03:53:01PM +0100, Daniel P. Berrange thus spake:
On Thu, Jun 30, 2011 at 07:36:24AM -0700, Jason Helfman wrote:
Hi,
I get this error when compiling 0.9.3-rc2 on FreeBSD. Is there a fix for
this?
rpc/virnetsocket.c: In function 'virNetSocketFree':
On 06/30/2011 01:51 PM, Jason Helfman wrote:
On Thu, Jun 30, 2011 at 03:53:01PM +0100, Daniel P. Berrange thus spake:
On Thu, Jun 30, 2011 at 07:36:24AM -0700, Jason Helfman wrote:
Hi,
I get this error when compiling 0.9.3-rc2 on FreeBSD. Is there a fix for
this?
rpc/virnetsocket.c: In
* daemon/libvirtd.c, daemon/remote.c: Add #if HAVE_SASL and
suitable function stubs to allow build without SASL
---
daemon/libvirtd.c |6 ++
daemon/remote.c | 44
2 files changed, 50 insertions(+), 0 deletions(-)
diff --git
On 06/30/2011 11:18 AM, Daniel P. Berrange wrote:
* daemon/libvirtd.c, daemon/remote.c: Add #if HAVE_SASL and
suitable function stubs to allow build without SASL
---
daemon/libvirtd.c |6 ++
daemon/remote.c | 44
2 files changed, 50
2011/6/30 Daniel P. Berrange berra...@redhat.com:
* daemon/libvirtd.c, daemon/remote.c: Add #if HAVE_SASL and
suitable function stubs to allow build without SASL
---
daemon/libvirtd.c | 6 ++
daemon/remote.c | 44
2 files changed, 50
On Thu, Jun 30, 2011 at 06:18:43PM +0100, Daniel P. Berrange thus spake:
* daemon/libvirtd.c, daemon/remote.c: Add #if HAVE_SASL and
suitable function stubs to allow build without SASL
---
daemon/libvirtd.c |6 ++
daemon/remote.c | 44
2
On 06/30/2011 08:24 AM, Daniel P. Berrange wrote:
On Thu, Jun 30, 2011 at 08:14:56AM -0600, Eric Blake wrote:
Based on Coverity's finding on the previous patch, I audited
gnulib's pipe2 code and found that we had the potential for
a subtle double-close bug, unless gnulib guarantees that the
[adding libvirt]
On 06/04/2011 12:24 AM, Paolo Bonzini wrote:
On Sat, Jun 4, 2011 at 00:37, Matthias Bolte
matthias.bo...@googlemail.com wrote:
After testing a while and reading MSDN docs the problem seems to be
that MsgWaitForMultipleObjects doesn't work on pipes. It doesn't
actually wait
Gnulib documents that mingw [v]snprintf is broken (it returns -1
on out-of-space, instead of the count of what would have been
printed); but while we were using the snprintf wrapper, we had
not yet been using the vsnprintf wrapper.
* bootstrap.conf (gnulib_modules): Add vsnprintf.
Reported by
According to the automake manual, CPPFLAGS (aka INCLUDES, as spelled
in automake 1.9.6) should only include -I, -D, and -U directives; more
generic directives like -Wall belong in CFLAGS since they affect more
phases of the build process. Therefore, we should be sticking CFLAGS
additions into a
* .gitignore: Exempt jsontest binary.
---
Pushing under the trivial rule.
.gitignore |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index be4193d..1bfb7b9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -57,6 +57,7 @@
/tests/*.log
/tests/cputest
For good or for bad, I did a fresh checkout, ./autogen.sh, then
'configure', then 'make syntax-check', and was surprised that it
failed. Running 'make' before 'make syntax-check' cleaned up the
issue, but this patch makes it work up front.
* cfg.mk (sc_po_check): Add prerequisites.
---
v3: also
On 06/29/2011 06:13 PM, Wen Congyang wrote:
This sounds highly related to Matthias' issue:
https://www.redhat.com/archives/libvir-list/2011-June/msg01484.html
Matthias was using 1.3...
What version of systemtap headers and gcc are you using, that produce
this error?
I use RHEL6RC, and
On 06/30/2011 12:00 PM, Eric Blake wrote:
Gnulib documents that mingw [v]snprintf is broken (it returns -1
on out-of-space, instead of the count of what would have been
printed); but while we were using the snprintf wrapper, we had
not yet been using the vsnprintf wrapper.
* bootstrap.conf
On 06/30/2011 04:55 PM, Eric Blake wrote:
For good or for bad, I did a fresh checkout, ./autogen.sh, then
'configure', then 'make syntax-check', and was surprised that it
failed. Running 'make' before 'make syntax-check' cleaned up the
issue, but this patch makes it work up front.
* cfg.mk
Detected by Coverity. No real harm in leaving these, but fixing
them cuts down on the noise for future analysis.
* src/rpc/virnetserver.c (virNetServerAddService): Delete unused
entry.
* src/util/sysinfo.c (virSysinfoRead): Delete dead assignment to
base.
---
src/rpc/virnetserver.c |7
On 06/30/2011 04:38 PM, Laine Stump wrote:
On 06/30/2011 04:55 PM, Eric Blake wrote:
For good or for bad, I did a fresh checkout, ./autogen.sh, then
'configure', then 'make syntax-check', and was surprised that it
failed. Running 'make' before 'make syntax-check' cleaned up the
issue, but
On 06/29/2011 11:31 AM, Eric Blake wrote:
EXTRA_DIST files should unconditionally be part of the tarball,
rather than depending on the presence of sanlock-devel.
Meanwhile, parallel builds could fail if we don't use mkdir -p.
* src/Makefile.am (EXTRA_DIST): Always ship sanlock .aug and
On 06/30/2011 02:09 PM, Eric Blake wrote:
According to the automake manual, CPPFLAGS (aka INCLUDES, as spelled
in automake 1.9.6) should only include -I, -D, and -U directives; more
generic directives like -Wall belong in CFLAGS since they affect more
phases of the build process. Therefore, we
On 06/30/2011 07:12 PM, Laine Stump wrote:
On 06/30/2011 02:09 PM, Eric Blake wrote:
According to the automake manual, CPPFLAGS (aka INCLUDES, as spelled
in automake 1.9.6) should only include -I, -D, and -U directives; more
generic directives like -Wall belong in CFLAGS since they affect more
On 06/30/2011 05:12 PM, Laine Stump wrote:
On 06/30/2011 02:09 PM, Eric Blake wrote:
According to the automake manual, CPPFLAGS (aka INCLUDES, as spelled
in automake 1.9.6) should only include -I, -D, and -U directives; more
generic directives like -Wall belong in CFLAGS since they affect more
On 06/30/2011 07:06 PM, Eric Blake wrote:
Detected by Coverity. No real harm in leaving these, but fixing
them cuts down on the noise for future analysis.
* src/rpc/virnetserver.c (virNetServerAddService): Delete unused
entry.
* src/util/sysinfo.c (virSysinfoRead): Delete dead assignment to
On 06/30/2011 05:09 PM, Laine Stump wrote:
On 06/29/2011 11:31 AM, Eric Blake wrote:
EXTRA_DIST files should unconditionally be part of the tarball,
rather than depending on the presence of sanlock-devel.
Meanwhile, parallel builds could fail if we don't use mkdir -p.
* src/Makefile.am
Detected by Coverity; only strikes on OOM so not serious.
* daemon/libvirtd.c (daemonPidFilePath): Plug leak.
---
daemon/libvirtd.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 60ee705..06d2077 100644
---
Detected by Coverity. Unlikely to hit unless the file contents
were corrupted.
* src/util/interface.c (ifaceRestoreMacAddress): Plug leak.
---
src/util/interface.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/util/interface.c b/src/util/interface.c
index
Detected by Coverity. Some, but not all, error paths were clean;
but they were repetitive so I refactored them.
* src/util/pci.c (pciGetDevice): Plug leak.
---
src/util/pci.c | 31 +++
1 files changed, 15 insertions(+), 16 deletions(-)
diff --git a/src/util/pci.c
Detected by Coverity. The leak is on an error path, but I'm not
sure whether that path is likely to be triggered in practice.
* src/rpc/virnetserverservice.c (virNetServerServiceAccept): Plug
leak.
---
src/rpc/virnetserverservice.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
On 06/30/2011 07:29 PM, Laine Stump wrote:
On 06/30/2011 07:12 PM, Laine Stump wrote:
On 06/30/2011 02:09 PM, Eric Blake wrote:
According to the automake manual, CPPFLAGS (aka INCLUDES, as spelled
in automake 1.9.6) should only include -I, -D, and -U directives; more
generic directives like
At 07/01/2011 07:36 AM, Eric Blake Write:
Detected by Coverity. Unlikely to hit unless the file contents
were corrupted.
* src/util/interface.c (ifaceRestoreMacAddress): Plug leak.
---
src/util/interface.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git
1 - 100 of 109 matches
Mail list logo
