At 07/04/2011 07:19 PM, Nikunj A. Dadhania Write:
On Thu, 30 Jun 2011 11:13:18 +0800, Wen Congyang we...@cn.fujitsu.com wrote:
We want to control bandwidth for each vcpu, so we can not use the
API virDomainSetSchedulerParameters(). Introduce two new APIs to
change and query bandwidth for each
Add --sharable option for attach-disk to allow user to specify whether
the disk device is sharable between domains when attaching a disk
device from virsh command line.
---
tools/virsh.c |4
tools/virsh.pod |5 +++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git
Add --serial option for attach-disk to allow user to specify serial
string of disk device from virsh command line when attaching a disk
device.
---
tools/virsh.c |7 ++-
tools/virsh.pod |2 ++
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c
Add --cache option to allow user to specify cache mode of disk device
from virsh command line when attaching a disk device.
---
tools/virsh.c | 10 --
tools/virsh.pod |5 +++--
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index
The network driver needs to assign physical devices for use by modes
that use macvtap, keeping track of which physical devices are in use
(and how many instances, when the devices can be shared). Three calls
are added:
networkAllocateActualDevice - finds a physical device for use by the
domain,
---
docs/schemas/Makefile.am |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/schemas/Makefile.am b/docs/schemas/Makefile.am
index dbad35f..36b9aeb 100644
--- a/docs/schemas/Makefile.am
+++ b/docs/schemas/Makefile.am
@@ -2,16 +2,16 @@
schemadir =
Previously all networks were composed of bridge devices created and
managed by libvirt, and the same operations needed to be done for all
of them when they were started and stopped (create and start the
bridge device, configure its MAC address and IP address, add iptables
rules). The new network
Although most functions with flags check to verify no application is
passing in flag bits that are currently undefined, for some reason
this function wasn't.
---
src/qemu/qemu_driver.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_driver.c
This patch is in response to the following bug reports:
https://bugzilla.redhat.com/show_bug.cgi?id=643947 (RHEL)
https://bugzilla.redhat.com/show_bug.cgi?id=636106 (upstream)
It is functionally complete, and has gone through rudimentary testing
for bridge networks (host bridge) and direct
* Change all flags args from int to unsigned int
* Allow passing flags in virDomainObjParseFile (and propogate those
flags all the way down the call chain). Previously the flags were
hardcoded (to VIR_DOMAIN_XML_INTERNAL_STATUS) several layers down
the chain. Pass that value in at the one
virtPortProfiles are currently only used in the domain XML, but will
soon also be used in the network XML. To prepare for that change, this
patch moves the structure definition into util/network.h and the parse
and format functions into util/network.c (I decided that this was a
better choice than
This adds virtualportprofile and portgroup (which itself can
contain a portgroup) to network, adds several new options to
forward mode, and adds an optional pool of interfaces to forward.
Since virtualPortProfile is now used in both the domain and network
RNG, its definition was moved into a
The qemu driver accesses fields in the virDomainNetDef directly, but
with the advent of the virDomainActualNetDef, some pieces of
information may be found in a different place (the ActualNetDef) if
the network connection is of type='network' and that network is of
forward
domain.rng, network.rng, and interface.rng already use a few of the
same types (or in some cases *should* but don't), and an upcoming code
change will have them sharing even more. To prepare for that, this
patch takes those common data type definitions and moves them into
basictypes.rng.
This may
This implements the changes to network and domain interface XML that
were earlier specified in the RNG.
Each virDomainNetDef now also potentially has a virDomainActualNetDef
which is a private object (never exported/imported via the public API,
and not defined in the RNG) that is used to maintain
On Tue, 05 Jul 2011 15:06:06 +0800, Wen Congyang we...@cn.fujitsu.com wrote:
At 07/04/2011 07:19 PM, Nikunj A. Dadhania Write:
On Thu, 30 Jun 2011 11:13:18 +0800, Wen Congyang we...@cn.fujitsu.com
wrote:
We want to control bandwidth for each vcpu, so we can not use the
API
2011/7/5 Justin Clift jcl...@redhat.com:
On 05/07/2011, at 1:23 AM, Matthias Bolte wrote:
2011/7/4 Justin Clift jcl...@redhat.com:
Just went to update the OSX libvirt build for 0.9.3, but it's
giving a duplicate symbol error:
ld: duplicate symbol _virNetworkDNSHostsDef in
On 05/07/2011, at 6:46 PM, Matthias Bolte wrote:
2011/7/5 Justin Clift jcl...@redhat.com:
Thanks Matthias, that fixes it perfectly. :)
Just incorporated your patch into the new OSX 0.9.3 libvirt build. Should be
live to the wider OSX public within 24 hours or so. :)
Regards and best
On Tue, Jul 05, 2011 at 03:45:50AM -0400, Laine Stump wrote:
Although most functions with flags check to verify no application is
passing in flag bits that are currently undefined, for some reason
this function wasn't.
---
src/qemu/qemu_driver.c |4
1 files changed, 4
On Tue, Jul 05, 2011 at 03:45:49AM -0400, Laine Stump wrote:
---
docs/schemas/Makefile.am |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/schemas/Makefile.am b/docs/schemas/Makefile.am
index dbad35f..36b9aeb 100644
--- a/docs/schemas/Makefile.am
+++
From: Daniel P. Berrange berra...@redhat.com
When no seclabel is present in the XML, the virDomainSeclabelDef
struct is left as all zeros. Unfortunately, this means it gets setup
as type=dynamic, with relabel=no, which is an illegal combination.
Change the 'bool relabel' attribute in
On Tue, Jul 05, 2011 at 12:34:38AM -0400, Laine Stump wrote:
I had libvirtd build from 0.9.2+something running on my test
machine. There was a single guest running on it.
I grabbed the latest libvirt from git (0.9.3+??), built an rpm, and
installed it. My guest reconnected with no problems,
On Tue, Jul 05, 2011 at 03:45:52AM -0400, Laine Stump wrote:
domain.rng, network.rng, and interface.rng already use a few of the
same types (or in some cases *should* but don't), and an upcoming code
change will have them sharing even more. To prepare for that, this
patch takes those common
On Tue, Jul 05, 2011 at 03:45:52AM -0400, Laine Stump wrote:
domain.rng, network.rng, and interface.rng already use a few of the
same types (or in some cases *should* but don't), and an upcoming code
change will have them sharing even more. To prepare for that, this
patch takes those common
On Tue, Jul 5, 2011 at 2:53 AM, Jagane Sundar jag...@sundar.org wrote:
/* Create a snapshot of a storage volume. XML is optional, if non-NULL,
* it would be a new top-level elementvolsnapshot which is similar to
* the top-leveldomainsnapshot for virDomainSnapshotCreateXML, to
* specify
Hi all,
Building libvirt 0.9.3 from source with --without-network, make check
fails with:
CC networkxml2xmltest.o
CCLD networkxml2xmltest
CC networkxml2argvtest.o
make[2]: *** No rule to make target
`../src/libvirt_driver_network.la', needed by `networkxml2argvtest'.
Stop.
make[2]:
2011/7/4 Osier Yang jy...@redhat.com:
于 2011年07月04日 16:50, Matthias Bolte 写道:
virFileMakePath returns an errno value on error, that will never be
negative. So a virFileMakePath error whould have been ignored here.
s/whould/should/
No. Actually the typo is s/whould/would/, because an error
On 06/16/2011 01:41 PM, Eric Blake wrote:
Right now, libvirt has a snapshot API via virDomainSnapshotCreateXML,
but for qemu domains, it only works if all the guest disk images are
qcow2, and qemu rather than libvirt does all the work. However, it has
a couple of drawbacks: it is inherently
This patch creates new attribute 'sga' for serial element. Serial Graphics
Adapter allows users to see BIOS messages from the very first moment
domain boots up. Therefore, users can choose boot medium, set PXE, etc.
However, to be able to use this, one need SGABIOS, which is accessible
here:
2011/7/5 Ruben Kerkhof ru...@rubenkerkhof.com:
Hi all,
Building libvirt 0.9.3 from source with --without-network, make check
fails with:
CC networkxml2xmltest.o
CCLD networkxml2xmltest
CC networkxml2argvtest.o
make[2]: *** No rule to make target
2011/7/4 Daniel P. Berrange berra...@redhat.com:
* daemon/remote.c: Server side dispatcher
* src/remote/remote_driver.c: Client side dispatcher
* src/remote/qemu_protocol.x: Wire protocol definition
---
daemon/remote.c | 41 +
2011/7/4 Daniel P. Berrange berra...@redhat.com:
This command allows libvirt to attach to an existing QEMU
instance.
$ qemu-kvm -cdrom ~/demo.iso \
-monitor unix:/tmp/demo,server,nowait \
-name foo \
-uuid cece4f9f-dff0-575d-0e8e-01fe380f12ea
$ QEMUPID=$!
$ virsh
2011/7/4 Daniel P. Berrange berra...@redhat.com:
Avoid re-formatting the pidfile path everytime we need it. Create
it once when starting the guest, and preserve it until the guest
is shutdown.
* src/libvirt_private.syms, src/util/util.c,
src/util/util.h: Add virFileReadPidPath
*
2011/7/4 Daniel P. Berrange berra...@redhat.com:
When converting QEMU argv into a virDomainDefPtr, also extract
the pidfile, monitor character device config and the monitor
mode.
* src/qemu/qemu_command.c, src/qemu/qemu_command.h: Extract
pidfile monitor config from QEMU argv
*
2011/7/4 Daniel P. Berrange berra...@redhat.com:
To enable attaching to externally launched QEMU, we need
to be able to reverse engineer a guest XML config based
on the argv for a PID in /proc
* src/qemu/qemu_command.c, src/qemu/qemu_command.h: Add
qemuParseCommandLinePid which extracts
On Tue, Jul 5, 2011 at 12:45, Matthias Bolte
matthias.bo...@googlemail.com wrote:
2011/7/5 Ruben Kerkhof ru...@rubenkerkhof.com:
Hi all,
Building libvirt 0.9.3 from source with --without-network, make check
fails with:
CC networkxml2xmltest.o
CCLD networkxml2xmltest
CC
On 07/05/2011 06:45 PM, Matthias Bolte wrote:
2011/7/5 Ruben Kerkhofru...@rubenkerkhof.com:
Hi all,
Building libvirt 0.9.3 from source with --without-network, make check
fails with:
CC networkxml2xmltest.o
CCLD networkxml2xmltest
CC networkxml2argvtest.o
make[2]: *** No rule to
2011/7/4 Daniel P. Berrange berra...@redhat.com:
Given a PID, the QEMU driver reads /proc/$PID/cmdline and
/proc/$PID/environ to get the configuration. This is fed
into the ARGV-XML convertor to build an XML configuration
for the process.
/proc/$PID/exe is resolved to identify the full
2011/7/5 Osier Yang jy...@redhat.com:
On 07/05/2011 06:45 PM, Matthias Bolte wrote:
2011/7/5 Ruben Kerkhof ru...@rubenkerkhof.com:
Hi all,
Building libvirt 0.9.3 from source with --without-network, make check
fails with:
CC networkxml2xmltest.o
CCLD networkxml2xmltest
CC
Also be explicity about the != 0 check in the few places that weren't.
---
src/conf/domain_conf.c |6 +++---
src/conf/network_conf.c |2 +-
src/conf/nwfilter_conf.c |4 ++--
src/conf/storage_conf.c |2 +-
src/libxl/libxl_driver.c | 20 ++--
This patch adds #if HAVE_SASL where needed in libvirtd.h
---
daemon/libvirtd.h |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/daemon/libvirtd.h b/daemon/libvirtd.h
index 6c604fc..8e1843c 100644
--- a/daemon/libvirtd.h
+++ b/daemon/libvirtd.h
@@ -38,7 +38,9 @@
#
On Tue, Jul 05, 2011 at 05:30:09PM +0200, Jean-Baptiste Rouault wrote:
This patch adds #if HAVE_SASL where needed in libvirtd.h
---
daemon/libvirtd.h |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
This was already fixed last week
commit
On 07/05/2011 05:51 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
When noseclabel is present in the XML, the virDomainSeclabelDef
struct is left as all zeros. Unfortunately, this means it gets setup
as type=dynamic, with relabel=no, which is an illegal combination.
On Tuesday 05 July 2011 17:43:06 Daniel P. Berrange wrote:
On Tue, Jul 05, 2011 at 05:30:09PM +0200, Jean-Baptiste Rouault wrote:
This patch adds #if HAVE_SASL where needed in libvirtd.h
---
daemon/libvirtd.h |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
This
On 07/01/2011 11:52 AM, Eric Blake wrote:
Gnulib documents that mingw vsnprintf is broken (it returns -1
on out-of-space, instead of the count of what would have been
printed); but while we were using the snprintf wrapper, we had
not yet been using the vsnprintf wrapper.
Oh well, this missed
On 07/02/2011 02:13 PM, Sethuraman Subbiah wrote:
Hi ,
I am trying to perform offline migration (i.e) Create an incremental image
using the qcow format, transfer the vm memory state to a state fie.Use the
image and statefile together as a template. Now create a new vm using the
template.
On 07/04/2011 01:10 AM, Matthias Bolte wrote:
+/* The double cast is necessary to silence gcc warnings; any pointer
+ * can safely go to intptr_t and back to void *, which collapses
+ * arrays into pointers; while any integer can be widened to intptr_t
+ * then cast to void *. */
+# define
On 07/03/2011 08:14 PM, Wen Congyang wrote:
At 07/03/2011 08:09 PM, Guannan Ren Write:
Initilize three state value of device driver to 1. This is just for a new
call to
s/initilize/initialize/
qemudNodeDeviceReAttach()
---
src/libvirt_private.syms |1 +
src/qemu/qemu_driver.c |
On 07/05/2011 08:00 AM, Matthias Bolte wrote:
Also be explicity about the != 0 check in the few places that weren't.
s/explicity/explicit/
---
src/conf/domain_conf.c |6 +++---
src/conf/network_conf.c |2 +-
src/conf/nwfilter_conf.c |4 ++--
On 07/05/2011 01:25 AM, Hu Tao wrote:
Add --cache option to allow user to specify cache mode of disk device
from virsh command line when attaching a disk device.
---
tools/virsh.c | 10 --
tools/virsh.pod |5 +++--
2 files changed, 11 insertions(+), 4 deletions(-)
diff
On 07/05/2011 05:45 AM, Daniel P. Berrange wrote:
On Tue, Jul 05, 2011 at 03:45:49AM -0400, Laine Stump wrote:
---
docs/schemas/Makefile.am |8
1 files changed, 4 insertions(+), 4 deletions(-)
ACK
Thanks. I pushed this, and the other 3 ACKed patches from the series,
now to
On 07/05/2011 05:45 AM, Daniel P. Berrange wrote:
On Tue, Jul 05, 2011 at 03:45:50AM -0400, Laine Stump wrote:
Although most functions with flags check to verify no application is
passing in flag bits that are currently undefined, for some reason
this function wasn't.
---
On 07/05/2011 05:55 AM, Daniel P. Berrange wrote:
On Tue, Jul 05, 2011 at 03:45:52AM -0400, Laine Stump wrote:
domain.rng, network.rng, and interface.rng already use a few of the
same types (or in some cases *should* but don't), and an upcoming code
change will have them sharing even more. To
On 07/05/2011 02:06 AM, Wen Congyang wrote:
At 07/04/2011 07:19 PM, Nikunj A. Dadhania Write:
On Thu, 30 Jun 2011 11:13:18 +0800, Wen Congyang we...@cn.fujitsu.com
wrote:
We want to control bandwidth for each vcpu, so we can not use the
API virDomainSetSchedulerParameters(). Introduce two
On 07/05/2011 04:26 AM, Osier Yang wrote:
Does it also need to enhance volume's XML so that it can include
volSnapshot/volSnapshot?
No. We _don't_ want to modify virStorageVolGetXMLDesc to output
snapshot information from a virStorageVolPtr, rather you would use the
new APIs to query
On 07/04/2011 08:19 AM, Stefan Hajnoczi wrote:
On Thu, Jun 16, 2011 at 6:41 AM, Eric Blake ebl...@redhat.com wrote:
Robert, Fernando, Jagane: I have CCed you because we have discussed
snapshot APIs and I thought you'd be interested in Eric's work to
build them for libvirt.
Does each
Some callers expected virFileMakePath to set errno, some expected
it to return an errno value. Unify this to return 0 on success and
-1 on error. Set errno to report detailed error information.
Also Make virFileMakePath report an error when stat fails with an
errno different from ENOENT.
---
On 07/04/2011 07:53 PM, Jagane Sundar wrote:
Thanks for looping me in, Stefan.
Does each volume have its own independent snapshot namespace? It may
be wise to document that snapshot namespaces are *not* independent
because storage backends may not be able to provide these semantics.
There
2011/7/5 Eric Blake ebl...@redhat.com:
On 07/05/2011 08:00 AM, Matthias Bolte wrote:
Also be explicity about the != 0 check in the few places that weren't.
s/explicity/explicit/
---
src/conf/domain_conf.c | 6 +++---
src/conf/network_conf.c | 2 +-
On 07/05/2011 04:02 AM, Stefan Hajnoczi wrote:
On Tue, Jul 5, 2011 at 2:53 AM, Jagane Sundar jag...@sundar.org wrote:
/* Create a snapshot of a storage volume. XML is optional, if non-NULL,
* it would be a new top-level elementvolsnapshot which is similar to
* the top-leveldomainsnapshot
---
src/node_device/node_device_linux_sysfs.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/node_device/node_device_linux_sysfs.c
b/src/node_device/node_device_linux_sysfs.c
index 4f4acc7..34e4501 100644
--- a/src/node_device/node_device_linux_sysfs.c
+++
On 7/5/2011 2:36 PM, Eric Blake wrote:
On 07/04/2011 07:53 PM, Jagane Sundar wrote:
Thanks for looping me in, Stefan.
Does each volume have its own independent snapshot namespace? It may
be wise to document that snapshot namespaces are *not* independent
because storage backends may not be
On 07/05/2011 03:04 PM, Matthias Bolte wrote:
Some callers expected virFileMakePath to set errno, some expected
it to return an errno value. Unify this to return 0 on success and
-1 on error. Set errno to report detailed error information.
Also Make virFileMakePath report an error when stat
On 07/05/2011 03:59 PM, Matthias Bolte wrote:
---
src/node_device/node_device_linux_sysfs.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/node_device/node_device_linux_sysfs.c
b/src/node_device/node_device_linux_sysfs.c
index 4f4acc7..34e4501 100644
---
On 07/04/2011 02:48 AM, Michal Privoznik wrote:
This option accepts 3 values:
-keep, to keep current client connected (Spice+VNC)
-disconnect, to disconnect client (Spice)
-fail, to fail setting password if there is a client connected (Spice)
---
diff to v3:
-rebase to current HEAD resend
On 07/04/2011 02:41 AM, Michal Privoznik wrote:
Since virsh is not multi-threaded,
Technically, virsh _is_ multi-threaded, in that it uses multiple threads
in order to process Ctrl-C to abort a migration; however, in this
instance, the main thread waits for the worker thread to complete, and
On 07/04/2011 02:41 AM, Michal Privoznik wrote:
This commit introduces command-based completer. Any command can now have
a completer, which will generate additional command arguments. Completer
is called repeatedly until it returns NULL. On the first call, @state is
non-zero.
Don't you mean
On 07/04/2011 02:41 AM, Michal Privoznik wrote:
This completer allows selection of active and/or inactive domains so
only domains in valid state for a command are listed, e.g. only inactive
for 'start' command, active for 'shutdown' and so on.
---
tools/virsh.c | 250
On 07/04/2011 02:41 AM, Michal Privoznik wrote:
This completer returns command names and group keywords as well.
---
tools/virsh.c | 43 ++-
1 files changed, 42 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index
Nikunj is correct here. We only need to ensure that the bandwidth is
distributed equally between all of the cpus. This can be accomplished
internally by creating a cgroup for each vcpu and ensuring that
'cpu.share' is the same for each vcpu cgroup.
When taken together, virsh I/F and
The qemu-sanlock.conf file is not installed in this case
Pushed under build breaker rules
Daniel
diff --git a/libvirt.spec.in b/libvirt.spec.in
index bf220f3..230237e 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1031,7 +1031,9 @@ fi
%if %{with_sanlock}
%files lock-sanlock
I realized that PATCH 10/10 would cause the build to fail if someone
did a build --with-qemu but --without-network. I'm squashing the
following into the original patch to remedy that.
I'm not really a fan of putting #if all over the place, but this is
similar to what's done with WITH_MACVTAP, so
Today I added some patches to the f15 branch of Fedora libvirt, ran
fedpkg local to be sure it was all in order, then did a fedpkg commit
-p and fedpkg build. When I came back awhile later, I found that it
had failed. Looking in the logs, I could see that the failure was due to
On Wed, 6 Jul 2011 10:18:05 +0900, Taku Izumi izumi.t...@jp.fujitsu.com wrote:
Nikunj is correct here. We only need to ensure that the bandwidth is
distributed equally between all of the cpus. This can be accomplished
internally by creating a cgroup for each vcpu and ensuring that
When building the latest code in a clean building environment, with sasl
disabled, I get this error:
gmake[3]: Entering directory
`/work/a/ports/devel/libvirt/work/libvirt-0.9.3/daemon'
CC libvirtd-libvirtd.o
In file included from libvirtd.h:41,
from libvirtd.c:41:
75 matches
Mail list logo
