2011/7/8 Jim Fehlig jfeh...@novell.com:
Kernel cmdline args can be passed to xen pv domains even when a
bootloader is specified. The current config-to-sxpr mapping
ignores cmdline when bootloader is present.
Since the xend sub-driver is used with many xen toolstack versions,
this patch
On 07.07.2011 20:12, Laine Stump wrote:
On 07/07/2011 12:00 PM, Michal Privoznik wrote:
On 07.07.2011 17:52, Eric Blake wrote:
On 07/07/2011 09:33 AM, Michal Privoznik wrote:
When dynamic ownership is disabled we don't want to chown any files,
not just local.
Is there more details on a
The drivers were accepting domain configs without checking if those
were actually meant for them. For example the LXC driver happily
accepts configs with type QEMU.
For convenience add an optional check for the domain type for the
virDomainDefParse* functions. It's optional because in some places
On Thu, Jul 7, 2011 at 8:34 PM, Eric Blake ebl...@redhat.com wrote:
On 07/07/2011 03:13 AM, Stefan Hajnoczi wrote:
On Wed, Jul 6, 2011 at 3:03 PM, Eric Blake ebl...@redhat.com wrote:
In other words, it looks like we are stuck with updating XML to track
new file names any time we take a
From: Daniel P. Berrange berra...@redhat.com
The virNetTLSContextNew was being passed key/cert parameters in
the wrong order. This wasn't immediately visible because if
virNetTLSContextNewPath was used, a second bug reversed the order
of those parameters again.
Only if the paths were manually
When auto_disk_lease is off we should avoid the automatic lockspace
creation.
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
---
src/locking/lock_driver_sanlock.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/locking/lock_driver_sanlock.c
From: Daniel P. Berrange berra...@redhat.com
In one exit path we forgot to free the virNetMessage object causing
a large memory leak for streams which send alot of data. Some other
paths were calling VIR_FREE directly instead of virNetMessageFree
although this was (currently) harmless.
*
From: Daniel P. Berrange berra...@redhat.com
The dispatch for the CLOSE RPC call was invoking the method
virNetServerClientClose(). This caused the client connection
to be immediately terminated. This meant the reply to the
final RPC message was never sent. Prior to the RPC rewrite
we merely
From: Daniel P. Berrange berra...@redhat.com
When closing a remote connection we issue a (fairly pointless)
'CLOSE' RPC call to the daemon. If this fails we skip all the
cleanup of private data, but the virConnectPtr object still
gets released as normal. This causes a memory leak. Since the
CLOSE
On Tue, Jul 05, 2011 at 12:54:32PM +0200, Matthias Bolte wrote:
2011/7/4 Daniel P. Berrange berra...@redhat.com:
Introduce a new API in libvirt-qemu.so
virDomainPtr virDomainQemuAttach(virConnectPtr domain,
unsigned long long pid,
From: Daniel P. Berrange berra...@redhat.com
This tweaks the RPC generator to cope with some naming
conventions used for the QEMU specific APIs
* daemon/remote.c: Server side dispatcher
* src/remote/remote_driver.c: Client side dispatcher
* src/remote/qemu_protocol.x: Wire protocol definition
*
On Tue, Jul 05, 2011 at 03:09:23PM +0200, Matthias Bolte wrote:
2011/7/4 Daniel P. Berrange berra...@redhat.com:
Given a PID, the QEMU driver reads /proc/$PID/cmdline and
/proc/$PID/environ to get the configuration. This is fed
into the ARGV-XML convertor to build an XML configuration
for
On Tue, Jul 05, 2011 at 01:07:45PM +0200, Matthias Bolte wrote:
2011/7/4 Daniel P. Berrange berra...@redhat.com:
* daemon/remote.c: Server side dispatcher
* src/remote/remote_driver.c: Client side dispatcher
* src/remote/qemu_protocol.x: Wire protocol definition
---
daemon/remote.c
On Tue, Jul 05, 2011 at 03:45:53AM -0400, Laine Stump wrote:
virtPortProfiles are currently only used in the domain XML, but will
soon also be used in the network XML. To prepare for that change, this
patch moves the structure definition into util/network.h and the parse
and format functions
From: Daniel P. Berrange berra...@redhat.com
When sending back the final OK or ERROR message on completion
of a stream, we were not decrementing the 'nrequests' tracker
on the client. With the default requests limit of '5', this
meant once a client had created 5 streams, they are unable to
From: Daniel P. Berrange berra...@redhat.com
If a client disconnects while it has a stream active, there is
a race condition which could see libvirtd crash. This is because
the client struct may be freed before the last stream event has
triggered. THis is trivially solved by holding an extra
On Tue, Jul 05, 2011 at 03:45:54AM -0400, Laine Stump wrote:
This adds virtualportprofile and portgroup (which itself can
contain a portgroup) to network, adds several new options to
forward mode, and adds an optional pool of interfaces to forward.
Since virtualPortProfile is now used in
This series of patches fixes a couple of memory leaks, one crash
and a missing reply to the final RPC message on a connection
being closed
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Jul 05, 2011 at 03:45:55AM -0400, Laine Stump wrote:
This implements the changes to network and domain interface XML that
were earlier specified in the RNG.
Each virDomainNetDef now also potentially has a virDomainActualNetDef
which is a private object (never exported/imported via
2011/7/8 Daniel P. Berrange berra...@redhat.com:
From: Daniel P. Berrange berra...@redhat.com
This tweaks the RPC generator to cope with some naming
conventions used for the QEMU specific APIs
* daemon/remote.c: Server side dispatcher
* src/remote/remote_driver.c: Client side dispatcher
*
When virFileOpenAs is called with VIR_FILE_OPEN_AS_UID flag and uid/gid
different from root/root while libvirtd is running as root, we fork a
new child, change its effective UID/GID to uid/gid and run
virFileOpenAsNoFork. It doesn't make any sense to fchown() the opened
file in this case since we
On Tue, Jul 05, 2011 at 03:45:56AM -0400, Laine Stump wrote:
Previously all networks were composed of bridge devices created and
managed by libvirt, and the same operations needed to be done for all
of them when they were started and stopped (create and start the
bridge device, configure its
On 07/08/11 10:58, Stefan Hajnoczi wrote:
On Thu, Jul 7, 2011 at 8:34 PM, Eric Blake ebl...@redhat.com wrote:
Well, the best thing (from libvirt's point of view) would be if
snapshot_blkdev took a single string argument, which is either a
/path/to/filename (and qemu does open()) or fd:name
On 07/08/2011 02:13 AM, Matthias Bolte wrote:
The drivers were accepting domain configs without checking if those
were actually meant for them. For example the LXC driver happily
accepts configs with type QEMU.
For convenience add an optional check for the domain type for the
On 07/08/2011 06:20 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
This tweaks the RPC generator to cope with some naming
conventions used for the QEMU specific APIs
* daemon/remote.c: Server side dispatcher
* src/remote/remote_driver.c: Client side dispatcher
On 07/08/2011 07:30 AM, Jiri Denemark wrote:
When virFileOpenAs is called with VIR_FILE_OPEN_AS_UID flag and uid/gid
different from root/root while libvirtd is running as root, we fork a
new child, change its effective UID/GID to uid/gid and run
virFileOpenAsNoFork. It doesn't make any sense
On 07/08/2011 07:35 AM, Jes Sorensen wrote:
On 07/08/11 10:58, Stefan Hajnoczi wrote:
On Thu, Jul 7, 2011 at 8:34 PM, Eric Blake ebl...@redhat.com wrote:
Well, the best thing (from libvirt's point of view) would be if
snapshot_blkdev took a single string argument, which is either a
This patch creates new bios element which, at this time has the only
attribute useserial='yes|no'. This attribute allow users to use
Serial Graphics Adapter and see BIOS messages from the very first moment
domain boots up. Therefore, users can choose boot medium, set PXE, etc.
---
diff to v2:
Hi all,
In order to nicely support domains that use qemu's SDL support,
libvirt-cim is looking for a way to confirm if the underlying qemu
emulator can support SDL. Libvirt already knows this information
internally. It seems to me that the best way to provide this
information is by reporting it
2011/7/8 Daniel P. Berrange berra...@redhat.com:
From: Daniel P. Berrange berra...@redhat.com
It is common for the $HOME/.libvirt/libvirtd.conf file to not
exist. Treat this situation as non-fatal since we can carry
on with our default settings just fine.
* daemon/libvirtd.c: Treat ENOENT
On Fri, Jul 08, 2011 at 11:16:03 +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The virNetTLSContextNew was being passed key/cert parameters in
the wrong order. This wasn't immediately visible because if
virNetTLSContextNewPath was used, a second bug reversed
On 07/08/2011 05:57 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If a client disconnects while it has a stream active, there is
a race condition which could see libvirtd crash. This is because
the client struct may be freed before the last stream event has
On 07/08/2011 05:57 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
In one exit path we forgot to free the virNetMessage object causing
a large memory leak for streams which send alot of data. Some other
s/alot/a lot/
paths were calling VIR_FREE directly instead
On 07/08/2011 05:57 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
When sending back the final OK or ERROR message on completion
of a stream, we were not decrementing the 'nrequests' tracker
on the client. With the default requests limit of '5', this
meant once a
On 07/08/2011 05:57 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
When closing a remote connection we issue a (fairly pointless)
'CLOSE' RPC call to the daemon. If this fails we skip all the
cleanup of private data, but the virConnectPtr object still
gets
On 07/08/2011 05:57 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The dispatch for the CLOSE RPC call was invoking the method
virNetServerClientClose(). This caused the client connection
to be immediately terminated. This meant the reply to the
final RPC message
On 07.07.2011 20:25, Eric Blake wrote:
On 07/07/2011 02:59 AM, Michal Privoznik wrote:
On 06.07.2011 00:34, Eric Blake wrote:
This patch changes the .xml, but not the corresponding .args file, which
to me says it is probably incomplete. We covered the case of changing
the attribute affecting
---
src/qemu/qemu_bridge_filter.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_bridge_filter.c b/src/qemu/qemu_bridge_filter.c
index f700631..03ed284 100644
--- a/src/qemu/qemu_bridge_filter.c
+++ b/src/qemu/qemu_bridge_filter.c
@@ -78,6 +78,7 @@
---
src/qemu/qemu_command.c | 40
1 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 6e4480e..19151ce 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -5712,6
On Fri, Jul 08, 2011 at 09:19:46AM -0500, Adam Litke wrote:
Hi all,
In order to nicely support domains that use qemu's SDL support,
libvirt-cim is looking for a way to confirm if the underlying qemu
emulator can support SDL. Libvirt already knows this information
internally. It seems to
On 07/07/2011 04:21 PM, Eric Blake wrote:
Oh, and our testsuite has a cosmetic bug. After applying your patch, I
see this during 'make check':
TEST: xencapstest
.. 10 OK
PASS: xencapstest
SKIP: reconnect
TEST: statstest
0 FAIL
SKIP:
On 07/08/2011 10:14 AM, Richard W.M. Jones wrote:
On Fri, Jul 08, 2011 at 09:19:46AM -0500, Adam Litke wrote:
Hi all,
In order to nicely support domains that use qemu's SDL support,
libvirt-cim is looking for a way to confirm if the underlying qemu
emulator can support SDL. Libvirt
On 07/08/2011 08:28 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
It is common for the $HOME/.libvirt/libvirtd.conf file to not
exist. Treat this situation as non-fatal since we can carry
on with our default settings just fine.
* daemon/libvirtd.c: Treat
On 07/08/2011 10:07 AM, Eric Blake wrote:
On 07/08/2011 08:28 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
It is common for the $HOME/.libvirt/libvirtd.conf file to not
exist. Treat this situation as non-fatal since we can carry
on with our default settings just
Fixes test regression introduced in commit 8e2e4780.
* daemon/libvirtd.c (daemonConfigLoad): Add argument.
(main): Update caller.
---
Pushing under the build-breaker rule, since it is detected by 'make check'.
daemon/libvirtd.c | 19 ---
1 files changed, 12 insertions(+), 7
* cfg.mk (VC_LIST_ALWAYS_EXCLUDE_REGEX): Exempt
docs/api_extension/*.patch.
(exclude_file_name_regexp--sc_prohibit_always_true_header_tests)
(exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF)
(exclude_file_name_regexp--sc_prohibit_fork_wrappers)
Like commit 1740c381, but for libvirt-qemu.
* src/remote/qemu_protocol.x (qemu_monitor_command_args): Adjust
type to match API.
* src/qemu_protocol-structs: Update accordingly.
---
v2: new patch
src/qemu_protocol-structs |2 +-
src/remote/qemu_protocol.x |4 ++--
2 files changed, 3
Addressing my review comments from round 1, and introducing a few
more goodies along the way. I've added some syntax checks to
make it easier to stick with this style in the future.
v1 was at https://www.redhat.com/archives/libvir-list/2011-July/msg00264.html,
with patches 1-5 already applied,
Silently ignored flags get in the way of new features that
use those flags.
* src/esx/esx_device_monitor.c (esxDeviceOpen): Reject unknown
flags.
* src/esx/esx_driver.c (esxOpen, esxDomainReboot)
(esxDomainXMLFromNative, esxDomainXMLToNative)
(esxDomainMigratePrepare, esxDomainMigratePerform)
Continuation of commit 313ac7fd, and enforce things with a syntax
check.
Technically, virNetServerClientCalculateHandleMode is not printing
a mode_t, but rather a collection of VIR_EVENT_HANDLE_* bits;
however, these bits are 8, so there is no different in the
output, and that was the easiest
* src/storage/storage_backend.c (virStorageBackendCreateBlockFrom)
(virStorageBackendCreateQemuImg)
(virStorageBackendCreateQcowCreate): Reject unknown flags.
* src/storage/storage_backend_disk.c (virStorageBackendDiskBuildPool)
(virStorageBackendDiskDeleteVol): Likewise.
*
* src/lxc/lxc_driver.c (lxcOpen, lxcDomainSetMemoryParameters)
(lxcDomainGetMemoryParameters): Reject unknown flags.
* src/lxc/lxc_container.c (lxcContainerStart): Use unsigned flags.
---
src/lxc/lxc_container.c |4 ++--
src/lxc/lxc_driver.c| 12 +---
2 files changed, 11
* src/phyp/phyp_driver.c (phypOpen, phypDomainReboot)
(phypVIOSDriverOpen): Reject unknown flags.
---
src/phyp/phyp_driver.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index d1ab5b4..dd5ab85 100644
---
Silently ignored flags get in the way of new features that
use those flags. Also, an upcoming syntax check will favor
unsigned flags.
* src/nodeinfo.h (nodeGetCPUStats, nodeGetMemoryStats): Drop
unused attribute.
* src/interface/netcf_driver.c (interfaceOpenInterface)
(interfaceDefineXML,
* src/vmware/vmware_driver.c (vmwareOpen, vmwareDomainReboot)
(vmwareDomainCreateXML, vmwareDomainCreateWithFlags): Reject
unknown flags.
---
src/vmware/vmware_driver.c | 17 -
1 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/vmware/vmware_driver.c
* src/uml/uml_driver.c (umlOpen, umlDomainGetXMLDesc)
(umlDomainBlockPeek): Reject unknown flags.
---
src/uml/uml_driver.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c
index 6a396e4..9f66aee 100644
---
* src/node_device/node_device_driver.c (nodeNumOfDevices)
(nodeListDevices, nodeDeviceGetXMLDesc, nodeDeviceCreateXML):
Reject unknown flags.
* src/node_device/node_device_hal.c (halNodeDrvOpen): Likewise.
* src/node_device/node_device_udev.c (udevNodeDrvOpen): Likewise.
---
* src/xen/xen_driver.c (xenUnifiedDomainXMLFromNative)
(xenUnifiedDomainXMLToNative, xenUnifiedDomainBlockPeek): Reject
unknown flags.
* src/xen/xen_hypervisor.c (xenHypervisorOpen)
(xenHypervisorGetDomainState): Likewise.
* src/xen/xen_inotify.c (xenInotifyOpen): Likewise.
* src/xen/xs_internal.c
* src/libxl/libxl_driver.c (libxlOpen, libxlDomainReboot)
(libxlDomainXMLFromNative, libxlDomainXMLToNative)
(libxlDomainCreateWithFlags): Reject unknown flags.
---
src/libxl/libxl_driver.c | 18 +-
1 files changed, 13 insertions(+), 5 deletions(-)
diff --git
* src/xenapi/xenapi_driver.c (xenapiOpen, xenapiDomainReboot)
(xenapiDomainGetXMLDesc): Reject unknown flags.
---
src/xenapi/xenapi_driver.c | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c
index
'unsigned a' and 'unsigned int a' are synonyms, but we generally
always spell out the 'int' in that case. Fixing this will avoid
a false positive in the next syntax-check commit.
* src/conf/node_device_conf.h (pci_config_address)
(_virNodeDevCapsDef): Prefer 'unsigned int' over 'unsigned'.
---
* src/remote/remote_driver.c (call, remoteOpenSecondaryDriver):
Prefer unsigned flags.
---
v2: new patch
src/remote/remote_driver.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 8dff6a8..2bfb15b 100644
* src/vbox/vbox_driver.c (vboxOpenDummy): Reject unknown flags.
* src/vbox/vbox_tmpl.c (vboxOpen, vboxDomainReboot)
(vboxNetworkOpen, vboxNetworkGetXMLDesc, vboxStorageOpen)
(vboxStorageVolCreateXML, vboxStorageVolDelete)
(vboxStorageVolGetXMLDesc, vboxDomainScreenshot): Likewise.
---
* tools/virsh.c (vshCmdDef): Change flags type.
* daemon/remote.c (remoteDispatchOpen): Likewise.
---
v2: new patch
daemon/remote.c |2 +-
tools/virsh.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c
index a2e79ef..1ade187
No need to repeat common code.
* src/util/bridge.c (brInit): Use virSetCloseExec.
(brSetInterfaceUp): Prefer unsigned flags.
* src/uml/uml_driver.c (umlSetCloseExec): Delete.
(umlStartVMDaemon): Use util version instead.
---
v2: new patch
src/uml/uml_driver.c | 19 +++
For static functions not used as callbacks, there's no need to
keep an unused parameter.
* src/conf/domain_conf.c (virDomainChrDefParseTargetXML)
(virDomainTimerDefParseXML, virDomainHostdevSubsysUsbDefParseXML)
(virDomainVcpuPinDefParseXML): Drop unused parameter.
(virDomainChrDefParseXML,
Enforce the recent flags cleanups - we want to use 'unsigned int flags'
in any of our APIs (except where backwards compatibility is important,
in the public migration APIs), and that all flags are checked for
validity (except when there are stub functions that completely
ignore the flags
On 07/05/2011 01:45 AM, Laine Stump wrote:
This implements the changes to network and domain interface XML that
were earlier specified in the RNG.
+++ b/include/libvirt/libvirt.h.in
@@ -1112,6 +1112,8 @@ typedef enum {
VIR_DOMAIN_XML_SECURE = (1 0), /* dump security sensitive
On 07/05/2011 01:45 AM, Laine Stump wrote:
The qemu driver accesses fields in the virDomainNetDef directly, but
with the advent of the virDomainActualNetDef, some pieces of
information may be found in a different place (the ActualNetDef) if
the network connection is of type='network' and that
On 07/05/2011 01:45 AM, Laine Stump wrote:
The network driver needs to assign physical devices for use by modes
that use macvtap, keeping track of which physical devices are in use
(and how many instances, when the devices can be shared). Three calls
are added:
networkAllocateActualDevice -
On 07/08/2011 07:48 AM, Michal Privoznik wrote:
This patch creates new bios element which, at this time has the only
s/the only/only the/
attribute useserial='yes|no'. This attribute allow users to use
Serial Graphics Adapter and see BIOS messages from the very first moment
domain boots up.
On 07/08/2011 07:40 AM, Eric Blake wrote:
On 07/08/2011 06:20 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
This tweaks the RPC generator to cope with some naming
conventions used for the QEMU specific APIs
* daemon/remote.c: Server side dispatcher
*
On 07/04/2011 04:28 AM, Daniel P. Berrange wrote:
Introduce a new API in libvirt-qemu.so
virDomainPtr virDomainQemuAttach(virConnectPtr domain,
unsigned long long pid,
We already assert elsewhere in our code base that pid_t will always fit
in int. For
On 07/07/2011 06:49 PM, Tyler Coumbes wrote:
The code changes it so that the TAP interface is created by libvirt
and then the file descriptor is passed to qemu. Much like what is done
when using bridged networking. This is done using fd= instead of
ifname= just like with the bridged
On Mon, Jul 04, 2011 at 10:05:21PM +0530, Vaidyanathan Srinivasan wrote:
* Dave Allan dal...@redhat.com [2011-07-01 16:56:29]:
libvirt has virConnectGetCapabilities() that would export an XML file
describing the capabilities of the host platform and guest features.
KVM
On Mon, Jul 04, 2011 at 10:00:20PM +0530, Vaidyanathan Srinivasan wrote:
* Dave Allan dal...@redhat.com [2011-07-01 17:19:06]:
On Fri, Jul 01, 2011 at 04:56:29PM -0400, Dave Allan wrote:
On Tue, Jun 28, 2011 at 08:55:31PM +0530, Vaidyanathan Srinivasan wrote:
Hi,
Linux host
Add missing line break and fix indention level.
Reported by Cole Robinson.
---
Pushing this under the trivial rule.
src/rpc/gendispatch.pl |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl
index 027560c..c69c5a2
On 07/07/2011 08:17 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
* src/rpc/virnetserverprogram.h: Remove unused typedef for
virNetServerProgramErrorHander function callback
* daemon/remote.h: Remove decl for non-existant variables
---
daemon/remote.h
On 07/08/2011 05:28 PM, Matthias Bolte wrote:
From a1508239af921289cd6e357e8521ff42faf535bd Mon Sep 17 00:00:00 2001
From: Matthias Bolte matthias.bo...@googlemail.com
Date: Sat, 9 Jul 2011 01:24:16 +0200
Subject: [PATCH] tests: Add the logic to skip the statstest to the right place
---
On 07/08/2011 05:28 PM, Matthias Bolte wrote:
TEST: virsh-all
40
80
120
... 159 OK
PASS: virsh-all
We're
On 07/08/2011 07:40 PM, Eric Blake wrote:
Instead count from 0 to 39 to fix this.
---
tests/test-lib.sh |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/test-lib.sh b/tests/test-lib.sh
index 768f96b..9eb6864 100644
--- a/tests/test-lib.sh
+++
81 matches
Mail list logo
