On Tue, Jul 12, 2011 at 11:50:51AM -0600, Eric Blake wrote:
On 07/12/2011 01:47 AM, Hu Tao wrote:
+ignore_value(vshCommandOptString(cmd, cache, cache));
Not so nice.
--cache ''
will make vshCommandOptString return -1, because that usage is a virsh
usage error and should be
At 07/07/2011 10:32 AM, Taku Izumi Write:
So why introduce VCPU level apis?
Adam Litke said IBM's performance team nead to control cpu bandwidth for
each
vcpu.
Right, but we do not export that as a User API, that was my suggestion.
We can internally control each vcpu's bandwidth, i.e.
On Mon, Jul 11, 2011 at 21:28:30 +0100, Daniel P. Berrange wrote:
On Fri, Jul 08, 2011 at 01:34:13AM +0200, Jiri Denemark wrote:
Most of the code in these two functions is supposed to be identical but
currently it isn't (which is natural since the code is duplicated).
Let's move common
On Fri, Jul 08, 2011 at 01:34:05 +0200, Jiri Denemark wrote:
This series is also available at
https://gitorious.org/~jirka/libvirt/jirka-staging/commits/migration-recovery
The series does several things:
- persists current job and its phase in status xml
- allows safe monitor commands to be
On Tue, Jul 12, 2011 at 12:57 PM, Michal Privoznik mpriv...@redhat.com wrote:
This patch series add support for setting traffic shaping and policing
on both domain's interface and network's virtual bridge. Basically,
this is done via 'tc' from iproute2 package. For shaping is HTB used,
for
On Mon, Jul 04, 2011 at 13:32:23 +0100, Daniel P. Berrange wrote:
* src/uml_conf.h: Add queue for dispatch of domain events
* src/uml_driver.c: Trigger domain events upon important lifecycle transitions
Does it mean someone is actually using UML? :-)
diff --git a/src/uml/uml_driver.c
Make the command 'virsh snapshot-delete' has the appropriate prompt
message when executing sucessful or failed.
---
tools/virsh.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index cd17f42..b7cea58 100644
--- a/tools/virsh.c
+++
On Wed, 13 Jul 2011 14:26:23 +0800, Wen Congyang we...@cn.fujitsu.com wrote:
At 07/07/2011 10:32 AM, Taku Izumi Write:
So why introduce VCPU level apis?
Adam Litke said IBM's performance team nead to control cpu bandwidth
for each
vcpu.
Right, but we do not export that as a User
At 07/13/2011 04:50 PM, Nikunj A. Dadhania Write:
On Wed, 13 Jul 2011 14:26:23 +0800, Wen Congyang we...@cn.fujitsu.com wrote:
At 07/07/2011 10:32 AM, Taku Izumi Write:
So why introduce VCPU level apis?
Adam Litke said IBM's performance team nead to control cpu bandwidth
for each
vcpu.
On Wed, Jul 13, 2011 at 2:29 AM, Zane Bitter zbit...@redhat.com wrote:
This schema change is necessary to ensure that classes keep the same names
after changing from the QMF to the QMFv2 API.
Odd. But if you say so, ACK :-)
---
src/DomainWrap.cpp | 2 +-
src/NodeWrap.cpp |
On Wed, Jul 13, 2011 at 2:46 AM, Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Jul 12, 2011 at 06:28:46PM +0200, Zane Bitter wrote:
diff --git a/src/DomainWrap.cpp b/src/DomainWrap.cpp
index 47876de..eab6bbc 100644
--- a/src/DomainWrap.cpp
+++ b/src/DomainWrap.cpp
@@ -2,266 +2,310 @@
Looks good to me. Ack
On Wed, Jul 13, 2011 at 2:29 AM, Zane Bitter zbit...@redhat.com wrote:
---
AUTHORS | 2
configure.ac | 1
libvirt-qpid.spec | 2
src/LibvirtAgent.cpp | 97
src/LibvirtAgent.h | 36 +
2011/7/8 Eric Blake ebl...@redhat.com:
* cfg.mk (VC_LIST_ALWAYS_EXCLUDE_REGEX): Exempt
docs/api_extension/*.patch.
(exclude_file_name_regexp--sc_prohibit_always_true_header_tests)
(exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF)
(exclude_file_name_regexp--sc_prohibit_fork_wrappers)
When qemuMonitorCloseFileHandle is called in error path, we need to
preserve the original error since a possible further error when running
closefd monitor command is not very useful to users.
---
src/qemu/qemu_monitor.c | 34 +-
src/qemu/qemu_monitor.h |3
Hi Daniel,
Thanks for the very helpful (and prompt!) feedback. Responses inline.
cheers,
Zane.
On 13/07/11 08:49, Andrew Beekhof wrote:
On Wed, Jul 13, 2011 at 2:46 AM, Daniel P. Berrangeberra...@redhat.com wrote:
On Tue, Jul 12, 2011 at 06:28:46PM +0200, Zane Bitter wrote:
diff --git
Hi,
Per discussion on
https://www.redhat.com/archives/libvir-list/2011-July/msg00556.html,
This patch series introduce new API virDomainUndefineFlags, which
only support flag VIR_DOMAIN_UNDEFINE_MANAGED_STATE now, might introduce
more flags in future.
If the flag is specified, the domain
1. Fix typos caused by the renaming
2. It should substitute remote/remote_protocol.h to remote_protocol.h.
---
src/rpc/gendispatch.pl |6 +++---
src/rpc/genprotocol.pl |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl
2011/7/8 Eric Blake ebl...@redhat.com:
Continuation of commit 313ac7fd, and enforce things with a syntax
check.
Technically, virNetServerClientCalculateHandleMode is not printing
a mode_t, but rather a collection of VIR_EVENT_HANDLE_* bits;
however, these bits are 8, so there is no
With small typo fixes (s/remote_generator/gendispatch/, and
s/remote_internal/remote_driver/)
---
src/remote/qemu_protocol.x |2 +-
src/remote/remote_driver.c |5 +++--
src/remote/remote_protocol.x | 14 ++
src/remote_protocol-structs |4
4 files changed, 18
---
src/driver.h |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/driver.h b/src/driver.h
index 71a52c9..3db9fb7 100644
--- a/src/driver.h
+++ b/src/driver.h
@@ -219,6 +219,9 @@ typedef virDomainPtr
typedef int
(*virDrvDomainUndefine)
---
src/libxl/libxl_driver.c | 32
1 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 808480f..f04931b 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -220,10 +220,8
---
tools/virsh.c | 12 +++-
tools/virsh.pod |6 +-
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 3cdf043..f81e923 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -1409,6 +1409,7 @@ static const vshCmdInfo info_undefine[]
---
src/libvirt.c | 53 -
1 files changed, 52 insertions(+), 1 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 7e70caa..eeb25a5 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -6381,7 +6381,8 @@ error:
* Returns 0 in case of
---
src/qemu/qemu_driver.c | 31 +++
1 files changed, 27 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f962e2c..a9f6986 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -2402,10 +2402,8 @@
2011/7/8 Eric Blake ebl...@redhat.com:
Like commit 1740c381, but for libvirt-qemu.
* src/remote/qemu_protocol.x (qemu_monitor_command_args): Adjust
type to match API.
* src/qemu_protocol-structs: Update accordingly.
---
v2: new patch
src/qemu_protocol-structs | 2 +-
2011/7/8 Eric Blake ebl...@redhat.com:
* src/node_device/node_device_driver.c (nodeNumOfDevices)
(nodeListDevices, nodeDeviceGetXMLDesc, nodeDeviceCreateXML):
Reject unknown flags.
* src/node_device/node_device_hal.c (halNodeDrvOpen): Likewise.
* src/node_device/node_device_udev.c
2011/7/8 Eric Blake ebl...@redhat.com:
Silently ignored flags get in the way of new features that
use those flags. Also, an upcoming syntax check will favor
unsigned flags.
* src/nodeinfo.h (nodeGetCPUStats, nodeGetMemoryStats): Drop
unused attribute.
* src/interface/netcf_driver.c
2011/7/8 Eric Blake ebl...@redhat.com:
* src/storage/storage_backend.c (virStorageBackendCreateBlockFrom)
(virStorageBackendCreateQemuImg)
(virStorageBackendCreateQcowCreate): Reject unknown flags.
* src/storage/storage_backend_disk.c (virStorageBackendDiskBuildPool)
2011/7/8 Eric Blake ebl...@redhat.com:
Silently ignored flags get in the way of new features that
use those flags.
* src/esx/esx_device_monitor.c (esxDeviceOpen): Reject unknown
flags.
* src/esx/esx_driver.c (esxOpen, esxDomainReboot)
(esxDomainXMLFromNative, esxDomainXMLToNative)
2011/7/8 Eric Blake ebl...@redhat.com:
* src/libxl/libxl_driver.c (libxlOpen, libxlDomainReboot)
(libxlDomainXMLFromNative, libxlDomainXMLToNative)
(libxlDomainCreateWithFlags): Reject unknown flags.
---
src/libxl/libxl_driver.c | 18 +-
1 files changed, 13 insertions(+),
2011/7/8 Eric Blake ebl...@redhat.com:
* src/lxc/lxc_driver.c (lxcOpen, lxcDomainSetMemoryParameters)
(lxcDomainGetMemoryParameters): Reject unknown flags.
* src/lxc/lxc_container.c (lxcContainerStart): Use unsigned flags.
---
src/lxc/lxc_container.c | 4 ++--
src/lxc/lxc_driver.c |
2011/7/8 Eric Blake ebl...@redhat.com:
* src/openvz/openvz_driver.c (openvzDomainReboot, openvzOpen):
Reject unknown flags.
---
src/openvz/openvz_driver.c | 9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list
2011/7/8 Eric Blake ebl...@redhat.com:
* src/phyp/phyp_driver.c (phypOpen, phypDomainReboot)
(phypVIOSDriverOpen): Reject unknown flags.
---
src/phyp/phyp_driver.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
2011/7/8 Eric Blake ebl...@redhat.com:
* src/qemu/qemu_driver.c (qemudOpen, qemuDomainScreenshot)
(qemuDomainXMLFromNative, qemuDomainXMLToNative)
(qemudDomainBlockPeek, qemuCPUCompare, qemuCPUBaseline): Reject
unknown flags.
* src/qemu/qemu_migration.c (qemuMigrationConfirm): Likewise.
2011/7/8 Eric Blake ebl...@redhat.com:
* src/test/test_driver.c (testOpen, testDomainCoreDump)
(testOpenNetwork, testNetworkGetXMLDesc, testOpenInterface)
(testInterfaceChangeBegin, testInterfaceChangeCommit)
(testInterfaceChangeRollback, testInterfaceGetXMLDesc)
(testInterfaceDefineXML,
2011/7/8 Eric Blake ebl...@redhat.com:
* src/uml/uml_driver.c (umlOpen, umlDomainGetXMLDesc)
(umlDomainBlockPeek): Reject unknown flags.
---
src/uml/uml_driver.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
@@ -1559,11 +1562,14 @@ cleanup:
static char
2011/7/8 Eric Blake ebl...@redhat.com:
* src/vbox/vbox_driver.c (vboxOpenDummy): Reject unknown flags.
* src/vbox/vbox_tmpl.c (vboxOpen, vboxDomainReboot)
(vboxNetworkOpen, vboxNetworkGetXMLDesc, vboxStorageOpen)
(vboxStorageVolCreateXML, vboxStorageVolDelete)
(vboxStorageVolGetXMLDesc,
2011/7/8 Eric Blake ebl...@redhat.com:
* src/vmware/vmware_driver.c (vmwareOpen, vmwareDomainReboot)
(vmwareDomainCreateXML, vmwareDomainCreateWithFlags): Reject
unknown flags.
---
src/vmware/vmware_driver.c | 17 -
1 files changed, 12 insertions(+), 5 deletions(-)
ACK.
于 2011年07月13日 16:36, Nan Zhang 写道:
Make the command 'virsh snapshot-delete' has the appropriate prompt
message when executing sucessful or failed.
---
tools/virsh.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index
2011/7/8 Eric Blake ebl...@redhat.com:
* src/xen/xen_driver.c (xenUnifiedDomainXMLFromNative)
(xenUnifiedDomainXMLToNative, xenUnifiedDomainBlockPeek): Reject
unknown flags.
* src/xen/xen_hypervisor.c (xenHypervisorOpen)
(xenHypervisorGetDomainState): Likewise.
* src/xen/xen_inotify.c
2011/7/8 Eric Blake ebl...@redhat.com:
* src/xenapi/xenapi_driver.c (xenapiOpen, xenapiDomainReboot)
(xenapiDomainGetXMLDesc): Reject unknown flags.
---
src/xenapi/xenapi_driver.c | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
@@ -1309,6 +1314,8 @@
2011/7/8 Eric Blake ebl...@redhat.com:
* src/conf/cpu_conf.h (virCPUDefFormat, virCPUDefFormatBuf):
Change flags type.
* src/conf/cpu_conf.c (virCPUDefFormat, virCPUDefFormatBuf):
Likewise.
* src/conf/storage_conf.c (_virStoragePoolOptions): Likewise.
* src/datatypes.h (_virConnect,
2011/7/8 Eric Blake ebl...@redhat.com:
* tools/virsh.c (vshCmdDef): Change flags type.
* daemon/remote.c (remoteDispatchOpen): Likewise.
---
v2: new patch
daemon/remote.c | 2 +-
tools/virsh.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
ACK.
--
Matthias Bolte
2011/7/8 Eric Blake ebl...@redhat.com:
* python/libvirt-override.c (libvirt_virConnectOpenAuth)
(libvirt_virDomainSnapshotListNames)
(libvirt_virDomainRevertToSnapshot): Change flags type.
---
v2: new patch
python/libvirt-override.c | 6 +++---
1 files changed, 3 insertions(+), 3
2011/7/8 Eric Blake ebl...@redhat.com:
'unsigned a' and 'unsigned int a' are synonyms, but we generally
always spell out the 'int' in that case. Fixing this will avoid
a false positive in the next syntax-check commit.
* src/conf/node_device_conf.h (pci_config_address)
(_virNodeDevCapsDef):
2011/7/8 Eric Blake ebl...@redhat.com:
For static functions not used as callbacks, there's no need to
keep an unused parameter.
* src/conf/domain_conf.c (virDomainChrDefParseTargetXML)
(virDomainTimerDefParseXML, virDomainHostdevSubsysUsbDefParseXML)
(virDomainVcpuPinDefParseXML): Drop
2011/7/8 Eric Blake ebl...@redhat.com:
No need to repeat common code.
* src/util/bridge.c (brInit): Use virSetCloseExec.
(brSetInterfaceUp): Prefer unsigned flags.
* src/uml/uml_driver.c (umlSetCloseExec): Delete.
(umlStartVMDaemon): Use util version instead.
---
v2: new patch
2011/7/8 Eric Blake ebl...@redhat.com:
* src/remote/remote_driver.c (call, remoteOpenSecondaryDriver):
Prefer unsigned flags.
---
v2: new patch
src/remote/remote_driver.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
On Wed, Jul 13, 2011 at 06:19:44PM +0800, Osier Yang wrote:
---
tools/virsh.c | 12 +++-
tools/virsh.pod |6 +-
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 3cdf043..f81e923 100644
--- a/tools/virsh.c
+++
On 07/12/2011 08:51 PM, Daniel Veillard wrote:
On Tue, Jul 12, 2011 at 04:51:51PM -0600, Eric Blake wrote:
I got bit in a debugging session on an uninstalled libvirtd; the
code tried to call out to the installed $LIBEXECDIR/libvirt_iohelper
instead of my just-built version. So I set a
2011/7/8 Eric Blake ebl...@redhat.com:
Enforce the recent flags cleanups - we want to use 'unsigned int flags'
in any of our APIs (except where backwards compatibility is important,
in the public migration APIs), and that all flags are checked for
validity (except when there are stub functions
On 07/12/2011 08:43 PM, Daniel Veillard wrote:
On Tue, Jul 12, 2011 at 02:09:34PM -0600, Eric Blake wrote:
virCommandTransferFD promises that the fd is no longer owned by
the caller. Normally, we want the fd to remain open until the
child runs, but in error situations, we must close it
2011/7/9 Eric Blake ebl...@redhat.com:
The compiler might optimize based on our declaration that something
is unused.
Can this actually happen? The unused marker only says that something
_might_ be unused. I don't think that a compiler can optimize
something based on this when it cannot
When creating new qemu process we saved domain status XML only after the
process was fully setup and running. In case libvirtd was killed before
the whole process finished, once libvirtd started again it didn't know
anything about the new process and we end up with an orphaned qemu
process. Let's
On 07/13/2011 03:49 AM, Matthias Bolte wrote:
2011/7/8 Eric Blake ebl...@redhat.com:
Continuation of commit 313ac7fd, and enforce things with a syntax
check.
Technically, virNetServerClientCalculateHandleMode is not printing
a mode_t, but rather a collection of VIR_EVENT_HANDLE_* bits;
In 2f4d2496a88055a8343b3efca618522da8715d92 I didn't notice that one
part of virFileOpenAs doesn't actually call to virFileOpenAsNoFork but
rather includes a copy of the code from there.
---
src/util/util.c | 35 +--
1 files changed, 5 insertions(+), 30
The name libvirt-qpid is probably not as descriptive of the project as
it could be. If we want to change the name then now is our best
opportunity to do so, as part of the process to convert it to QMFv2 and
make it a matahari agent - potentially breaking backward compatibility
with existing
On 07/13/2011 07:58 AM, Jiri Denemark wrote:
When creating new qemu process we saved domain status XML only after the
process was fully setup and running. In case libvirtd was killed before
the whole process finished, once libvirtd started again it didn't know
anything about the new process
On 07/13/2011 08:08 AM, Jiri Denemark wrote:
In 2f4d2496a88055a8343b3efca618522da8715d92 I didn't notice that one
part of virFileOpenAs doesn't actually call to virFileOpenAsNoFork but
rather includes a copy of the code from there.
---
src/util/util.c | 35
qemuDomainModifyDeviceFlags: Changing ret to 0, but don't
reset it to -1 on failure, it's not good idea to change the value
of ret in the codes to do some condition checking. This patch
fix it.
---
src/qemu/qemu_driver.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git
On 07/13/2011 03:54 AM, Matthias Bolte wrote:
2011/7/8 Eric Blake ebl...@redhat.com:
Like commit 1740c381, but for libvirt-qemu.
* src/remote/qemu_protocol.x (qemu_monitor_command_args): Adjust
type to match API.
* src/qemu_protocol-structs: Update accordingly.
---
v2: new patch
On 07/13/2011 09:17 AM, Osier Yang wrote:
qemuDomainModifyDeviceFlags: Changing ret to 0, but don't
reset it to -1 on failure, it's not good idea to change the value
of ret in the codes to do some condition checking. This patch
fix it.
Can you identify which commit introduced the regression,
On 07/08/2011 01:26 PM, Eric Blake wrote:
Enforce the recent flags cleanups - we want to use 'unsigned int flags'
in any of our APIs (except where backwards compatibility is important,
in the public migration APIs), and that all flags are checked for
validity (except when there are stub
On 07/13/2011 07:35 AM, Matthias Bolte wrote:
@@ -516,13 +516,13 @@ virFDStreamOpenFileInternal(virStreamPtr st,
int errfd = -1;
pid_t pid = 0;
-VIR_DEBUG(st=%p path=%s flags=%x offset=%llu length=%llu mode=%o
delete=%d,
- st, path, flags, offset, length, mode,
On 07/13/2011 03:25 AM, Jiri Denemark wrote:
When qemuMonitorCloseFileHandle is called in error path, we need to
preserve the original error since a possible further error when running
closefd monitor command is not very useful to users.
---
src/qemu/qemu_monitor.c | 34
Getting metadata on storage allocates a memory (path) which need to
be freed after use otherwise it gets leaked. This means after use of
virStorageFileGetMetadataFromFD or virStorageFileGetMetadata one
must call virStorageFileFreeMetadata to free it. Right now this
function frees only one variable
On 07/13/2011 05:34 AM, Matthias Bolte wrote:
2011/7/8 Eric Blake ebl...@redhat.com:
* src/storage/storage_backend.c (virStorageBackendCreateBlockFrom)
(virStorageBackendCreateQemuImg)
(virStorageBackendCreateQcowCreate): Reject unknown flags.
ACK.
I've pushed 5, 6, and 7.
--
Eric Blake
On 07/13/2011 06:44 AM, Osier Yang wrote:
于 2011年07月13日 18:11, Peter Krempa 写道:
While compiling on F15 build crashed (probably because of new GCC).
---
AUTHORS|1 +
src/qemu/qemu_driver.c |7 ---
2 files changed, 5 insertions(+), 3 deletions(-)
I meet the
On 07/13/2011 06:51 AM, Osier Yang wrote:
于 2011年07月13日 16:36, Nan Zhang 写道:
Make the command 'virsh snapshot-delete' has the appropriate prompt
message when executing sucessful or failed.
-if (virDomainSnapshotDelete(snapshot, flags) 0)
You can keep this line unchanged, and switch
On 07/13/2011 04:19 AM, Osier Yang wrote:
1. Fix typos caused by the renaming
2. It should substitute remote/remote_protocol.h to remote_protocol.h.
---
src/rpc/gendispatch.pl |6 +++---
src/rpc/genprotocol.pl |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
ACK.
+++
On 07/13/2011 06:15 AM, Matthias Bolte wrote:
2011/7/8 Eric Blake ebl...@redhat.com:
Silently ignored flags get in the way of new features that
use those flags.
@@ -3829,12 +3837,14 @@ esxDomainMigratePrepare(virConnectPtr dconn,
int *cookielen ATTRIBUTE_UNUSED,
On 07/13/2011 04:19 AM, Osier Yang wrote:
Only support to remove domain managed state file when undefining
s/to remove/removing/
the domain currently.
---
include/libvirt/libvirt.h.in | 10 ++
python/generator.py |1 +
src/libvirt_public.syms |5 +
3
On 07/13/2011 04:19 AM, Osier Yang wrote:
---
src/libvirt.c | 53 -
1 files changed, 52 insertions(+), 1 deletions(-)
per my comments in 2/8,
/**
+ * virDomainUndefineWithFlags:
On 07/13/2011 04:19 AM, Osier Yang wrote:
---
src/driver.h |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/driver.h b/src/driver.h
index 71a52c9..3db9fb7 100644
--- a/src/driver.h
+++ b/src/driver.h
@@ -219,6 +219,9 @@ typedef virDomainPtr
typedef int
On 07/13/2011 04:19 AM, Osier Yang wrote:
---
src/qemu/qemu_driver.c | 31 +++
1 files changed, 27 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f962e2c..a9f6986 100644
--- a/src/qemu/qemu_driver.c
+++
On 07/13/2011 04:19 AM, Osier Yang wrote:
---
src/libxl/libxl_driver.c | 32
1 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 808480f..f04931b 100644
--- a/src/libxl/libxl_driver.c
On 07/13/2011 04:19 AM, Osier Yang wrote:
With small typo fixes (s/remote_generator/gendispatch/, and
s/remote_internal/remote_driver/)
---
src/remote/qemu_protocol.x |2 +-
src/remote/remote_driver.c |5 +++--
src/remote/remote_protocol.x | 14 ++
On 07/13/2011 04:19 AM, Osier Yang wrote:
---
tools/virsh.c | 12 +++-
tools/virsh.pod |6 +-
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 3cdf043..f81e923 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@
Domain listing, basic information retrieval and domain life cycle
management is implemented. But currently the domian XML output
lacks the complete devices section.
The driver uses OpenWSMAN to directly communicate with an Hyper-V
server over its WS-Management interface exposed via Microsoft
This is the series version of this patch
https://www.redhat.com/archives/libvir-list/2011-July/msg00668.html
Daniel suggested to split it for easier review.
This series includes some small fixes for problem I noticed while
splitting the original patch.
Matthias
--
libvir-list mailing list
---
configure.ac | 38 ++
1 files changed, 38 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac
index e9d5be4..d7ebe79 100644
--- a/configure.ac
+++ b/configure.ac
@@ -66,6 +66,7 @@ XMLRPC_REQUIRED=1.14.0
HAL_REQUIRED=0.5.0
---
docs/drivers.html.in |1 +
docs/drvhyperv.html.in | 103
docs/index.html.in |3 +
docs/sitemap.html.in |4 ++
src/README |3 +-
5 files changed, 113 insertions(+), 1 deletions(-)
create mode 100644
2011/7/12 Matthias Bolte matthias.bo...@googlemail.com:
Domain listing, basic information retrieval and domain life cycle
management is implemented. But currently the domian XML output
lacks the complete devices section.
The driver uses OpenWSMAN to directly communicate with an Hyper-V
Add a generator script to generate the structs and serialization
information for OpenWSMAN.
openwsman.h collects workarounds for problems in OpenWSMAN = 2.2.6.
There are also disabled sections that would use ws_serializer_free_mem
but can't because it's broken in OpenWSMAN = 2.2.6. Patches to fix
---
cfg.mk |1 +
include/libvirt/virterror.h |1 +
libvirt.spec.in |9 +++
po/POTFILES.in |1 +
src/Makefile.am | 29 +
src/driver.h |1 +
On 07/13/2011 01:01 PM, Matthias Bolte wrote:
---
configure.ac | 38 ++
1 files changed, 38 insertions(+), 0 deletions(-)
I'd like to see the libvirt.spec.in changes from patch 2/5 squashed back
into this patch - that is, both introduce the new
Unfortunately, after committing the blockPull API to libvirt, the qemu
community decided to change the API somewhat and we needed to revert the
libvirt implementation. Now that the qemu API is settling out again, I would
like to propose an updated libvirt public API which has required only a
On 07/13/2011 01:01 PM, Matthias Bolte wrote:
---
cfg.mk |1 +
include/libvirt/virterror.h |1 +
libvirt.spec.in |9 +++
See patch 1/5 about this file.
po/POTFILES.in |1 +
src/Makefile.am
On 07/13/2011 06:21 AM, Matthias Bolte wrote:
2011/7/8 Eric Blake ebl...@redhat.com:
* src/lxc/lxc_driver.c (lxcOpen, lxcDomainSetMemoryParameters)
(lxcDomainGetMemoryParameters): Reject unknown flags.
* src/lxc/lxc_container.c (lxcContainerStart): Use unsigned flags.
@@ -889,7 +889,7 @@ int
On 07/13/2011 06:35 AM, Matthias Bolte wrote:
2011/7/8 Eric Blake ebl...@redhat.com:
static int testDomainCoreDump(virDomainPtr domain,
const char *to,
- unsigned int flags ATTRIBUTE_UNUSED)
+ unsigned
On 07/13/2011 06:41 AM, Matthias Bolte wrote:
2011/7/8 Eric Blake ebl...@redhat.com:
* src/uml/uml_driver.c (umlOpen, umlDomainGetXMLDesc)
(umlDomainBlockPeek): Reject unknown flags.
---
src/uml/uml_driver.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
@@
On 07/05/2011 01:45 AM, Laine Stump wrote:
The virDomainActualNetDef will only be parsed/formatted if the
parse/format function is called with the VIR_DOMAIN_XML_ACTUAL_NET
flags set (which is only needed when saving/loading a running domain's
state info to the stateDir). To prevent this flag
On 07/13/2011 03:14 PM, Eric Blake wrote:
Don't get fooled by the ATTRIBUTE_UNUSED again. All *DomainGetXMLDesc
use virDomainDefFormat and have to accept all flags that
virDomainDefFormat accepts. I suggest to recheck your series for this
pattern, here it's just the first time that I notice
On 07/13/2011 07:22 AM, Matthias Bolte wrote:
2011/7/8 Eric Blake ebl...@redhat.com:
No need to repeat common code.
* src/util/bridge.c (brInit): Use virSetCloseExec.
(brSetInterfaceUp): Prefer unsigned flags.
* src/uml/uml_driver.c (umlSetCloseExec): Delete.
(umlStartVMDaemon): Use util
At 07/13/2011 11:03 PM, Eric Blake Write:
On 07/13/2011 09:17 AM, Osier Yang wrote:
qemuDomainModifyDeviceFlags: Changing ret to 0, but don't
reset it to -1 on failure, it's not good idea to change the value
of ret in the codes to do some condition checking. This patch
fix it.
Can you
于 2011年07月13日 23:03, Eric Blake 写道:
On 07/13/2011 09:17 AM, Osier Yang wrote:
qemuDomainModifyDeviceFlags: Changing ret to 0, but don't
reset it to -1 on failure, it's not good idea to change the value
of ret in the codes to do some condition checking. This patch
fix it.
Can you identify which
Add virtkey lib for usage-improvment and keycode translating.
Expose send-key in virsh
Implement send-key function for the qemu driver
Daniel P. Berrange (1):
util: Add keymaps.csv
Lai Jiangshan (3):
util: add virtkey
send-key: Expose the new API in virsh
qemu:send-key: Implement the
Add virtkey lib for usage-improvment and keycode translating.
Add 4 internal API for the aim
const char *virKeycodeSetTypeToString(int codeset);
int virKeycodeSetTypeFromString(const char *name);
int virParseKeyName(virKeycodeSet codeset, const char *keyname);
int
From: Daniel P. Berrange berra...@redhat.com
Should keep it as the same as:
http://git.gnome.org/browse/gtk-vnc/commit/src/keymaps.csv
All master keymaps are defined in a CSV file. THis covers
Linux keycodes, OSX keycodes, AT set1, 2 3, XT keycodes,
the XT encoding used by the Linux KBD
qemu driver just accept xt_kbd codeset's keycode, so the lib virtkey
is used for translating keycodes from other codesets.
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
src/qemu/qemu_driver.c | 71 ++
src/qemu/qemu_monitor.c | 17
1 - 100 of 107 matches
Mail list logo
