* src/network/bridge_driver.c: Fix memory leak on cleanup section from
networkGetBridgeName function.
---
src/network/bridge_driver.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 0a12bc0..59e780d
2011/7/15 a...@redhat.com:
* src/network/bridge_driver.c: Fix memory leak on cleanup section from
networkGetBridgeName function.
---
src/network/bridge_driver.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/network/bridge_driver.c
Hi all,
This patchset adds the --current option to virsh setvcpus
command. Currently virsh setvcpus command supports
--live and --config , but --current option.
From view of consistency, it's reasonable to support
--current option too.
*[PATCH 1/3] setvcpus: extend virDomainSetVcpusFlags API
This patch extends virDomainSetVcpusFlags API to support
VIR_DOMAIN_AFFECT_CURRENT flag.
Now because most APIs accept VIR_DOMAIN_AFFECT_CURRENT flags,
virDomainSetVcpusFlags API should also do.
Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com
---
include/libvirt/libvirt.h.in |4 ++--
This patch extends qemudDomainSetVcpusFlags() function to support
VIR_DOMAIN_AFFECT_CURRENT flag.
Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com
---
src/qemu/qemu_driver.c | 37 +++--
1 file changed, 27 insertions(+), 10 deletions(-)
Index:
This patch adds the --current option to virsh setvcpus
command. Currently virsh setvcpus command supports
--live and --config , but --current option.
From view of consistency, it's reasonable to support
--current option too.
When --current is specified, it affects a current
domain.
On 07/15/2011 02:49 PM, Matthias Bolte wrote:
2011/7/15a...@redhat.com:
* src/network/bridge_driver.c: Fix memory leak on cleanup section from
networkGetBridgeName function.
---
src/network/bridge_driver.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git
Pointed out by Eric. Thanks.
---
tools/virsh.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index b7cea58..b43af70 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -12375,8 +12375,13 @@ vshCommandOptString(const vshCmd *cmd, const
2011/7/15 Alex Jia a...@redhat.com:
On 07/15/2011 03:03 PM, Alex Jia wrote:
On 07/15/2011 02:49 PM, Matthias Bolte wrote:
2011/7/15 a...@redhat.com:
* src/network/bridge_driver.c: Fix memory leak on cleanup section from
networkGetBridgeName function.
---
src/network/bridge_driver.c |
On Thu, Jul 14, 2011 at 10:20:28AM -0600, Eric Blake wrote:
As long as we guarantee RPC struct layout stability, we might as
well also guarantee RPC enum value constancy.
* src/Makefile.am (r1, r2, PDWTAGS): Adjust rule to pick up named
and anonymous enums.
* src/remote_protocol-structs:
On 07/14/2011 05:42 PM, Matthias Bolte wrote:
2011/7/14 Michal Novotny minov...@redhat.com:
Hi guys,
some time ago I've been investigating the options to get the guest's IP
address information without having to connect to guest's VNC window or
console. It was for one project I've been working
At 07/15/2011 12:03 PM, Nikunj A. Dadhania Write:
On Thu, 14 Jul 2011 16:14:01 +0900, Taku Izumi izumi.t...@jp.fujitsu.com
wrote:
On Wed, 13 Jul 2011 16:55:28 +0800
Wen Congyang we...@cn.fujitsu.com wrote:
At 07/13/2011 04:50 PM, Nikunj A. Dadhania Write:
On Wed, 13 Jul 2011 14:26:23
On 07/15/2011 03:35 PM, Matthias Bolte wrote:
2011/7/15 Alex Jiaa...@redhat.com:
On 07/15/2011 03:03 PM, Alex Jia wrote:
On 07/15/2011 02:49 PM, Matthias Bolte wrote:
2011/7/15a...@redhat.com:
* src/network/bridge_driver.c: Fix memory leak on cleanup section from
networkGetBridgeName
On 07/15/2011 10:04 AM, Michal Novotny wrote:
On 07/14/2011 05:42 PM, Matthias Bolte wrote:
2011/7/14 Michal Novotny minov...@redhat.com:
Hi guys,
some time ago I've been investigating the options to get the guest's IP
address information without having to connect to guest's VNC window or
On Thu, Jul 14, 2011 at 11:10:56AM -0600, Eric Blake wrote:
Commit 135554166 introduced a nice feature without documenting it.
* src/libvirt.c (virDomainMigrate2): Add paragraph.
---
src/libvirt.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git
2011/7/15 Michal Novotny minov...@redhat.com:
On 07/14/2011 05:42 PM, Matthias Bolte wrote:
2011/7/14 Michal Novotny minov...@redhat.com:
Hi guys,
some time ago I've been investigating the options to get the guest's IP
address information without having to connect to guest's VNC window or
This introduce a new API virDomainUndefineFlags to control the
domain undefine process, as the existed API virDomainUndefine
doesn't support flags.
Currently only flag VIR_DOMAIN_UNDEFINE_MANAGED_STATE is supported.
If the domain has a managed state file, including
Per discussion on
https://www.redhat.com/archives/libvir-list/2011-July/msg00556.html,
This patch series introduce new API virDomainUndefineFlags, which
only support flag VIR_DOMAIN_UNDEFINE_MANAGED_STATE now, might introduce
more flags in future though.
If the domain has a managed state file,
---
tools/virsh.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 8a62612..120f3c8 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -2366,6 +2366,7 @@ cmdDominfo(vshControl *ctl, const vshCmd *cmd)
int autostart;
---
src/remote/remote_driver.c |3 ++-
src/remote/remote_protocol.x |9 -
src/remote_protocol-structs |4
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index a2c62ba..1acef17 100644
---
This is just similiar as changes on qemu driver.
* src/libxl/libxl_driver.c: New callback for libxl_driver,
new function libxlDomainUndefineFlags, and changes libxlDomainUndefine
as a wrapper of libxlDomainUndefineFlags.
---
src/libxl/libxl_driver.c | 31 ++-
1
If the domain has managed state file, and --managed-state is
not specified, then it fails with error prompt to tell user
there is managed state file exists.
And the domain has managed state file, and --managed-state is
specified, it invokes virDomainUndefineFlags, if
virDomainUndefineFlag fails,
* src/qemu/qemu_driver.c: New call back for qemu_driver,
New function qemudDomainUndefineFlags, and changes on
qemudDomainUndefine.
---
src/qemu/qemu_driver.c | 35 ++-
1 files changed, 34 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_driver.c
Add domainUndefineFlags support for these drivers (except qemu and
libxl driver), and changes domainUndefine as a wrapper of
domainUndefineFlags, but they actually perform same.
---
src/esx/esx_driver.c | 11 ++-
src/lxc/lxc_driver.c | 11 ++-
On 07/15/2011 10:28 AM, Matthias Bolte wrote:
2011/7/15 Michal Novotny minov...@redhat.com:
On 07/14/2011 05:42 PM, Matthias Bolte wrote:
2011/7/14 Michal Novotny minov...@redhat.com:
Hi guys,
some time ago I've been investigating the options to get the guest's IP
address information without
* src/util/util.c: fix a typo error on virStrncpy.
---
src/util/util.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/util/util.c b/src/util/util.c
index 0ca81df..1080823 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@ -1754,7 +1754,7 @@ virStrncpy(char *dest,
2011/7/15 Michal Novotny minov...@redhat.com:
On 07/15/2011 10:28 AM, Matthias Bolte wrote:
2011/7/15 Michal Novotny minov...@redhat.com:
On 07/14/2011 05:42 PM, Matthias Bolte wrote:
2011/7/14 Michal Novotny minov...@redhat.com:
Hi guys,
some time ago I've been investigating the options to
On Thu, Jul 14, 2011 at 09:43:40 -0600, Eric Blake wrote:
Without this patch, the make rule in a VPATH build was trying to
invoke ../../docs/../../docs/todo.pl, which didn't exist.
* docs/Makefile.am (todo.html.in): Using $ already implies
$(srcdir) in GNU make VPATH situations.
Uh, and I
2011/7/15 a...@redhat.com:
* src/util/util.c: fix a typo error on virStrncpy.
---
src/util/util.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/util/util.c b/src/util/util.c
index 0ca81df..1080823 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@
Good morning,
I talked with Jordi Guitart, an author of EMOTIVE Cloud . And he say me that
you can use this email jordi.guit...@bsc.es in
http://libvirt.org/apps.html#iaas;.
Thanks a lot!
Alex Vaqué
2011/7/14 Alex Vaqué Brull mem...@gmail.com
You can put my name but I am a simple
[snip]
Wait a minute there please. The MAC address should be unique in the
system so user should be using just one IP address per one MAC address.
Since MAC address should be unique in the system then the IP address
assigned to this MAC address should be just one, shouldn't it ?
You can
On 07/15/2011 05:11 PM, Matthias Bolte wrote:
2011/7/15a...@redhat.com:
* src/util/util.c: fix a typo error on virStrncpy.
---
src/util/util.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/util/util.c b/src/util/util.c
index 0ca81df..1080823 100644
---
On Thu, Jul 14, 2011 at 05:14:57PM +0200, Michal Novotny wrote:
Hi guys,
some time ago I've been investigating the options to get the guest's IP
address information without having to connect to guest's VNC window or
console. It was for one project I've been working on and I found that
the
[snip]
ipv4s = virDomainGetIPAddress(domain, macaddr, count,
VIR_DOMAIN_ADDRESS_IPV4);
ipv6s = virDomainGetIPAddress(domain, macaddr, count,
VIR_DOMAIN_ADDRESS_IPV6);
This are the simple cases where the caller explicitly requests only
one version and knows the version of the returned IP
On Fri, Jul 15, 2011 at 03:03:07PM +0800, Alex Jia wrote:
On 07/15/2011 02:49 PM, Matthias Bolte wrote:
2011/7/15a...@redhat.com:
* src/network/bridge_driver.c: Fix memory leak on cleanup section from
networkGetBridgeName function.
---
src/network/bridge_driver.c |3 ++-
1 files
I am happy to announce a new release[1] of the libvirt Perl bindings,
Sys::Virt 0.9.3 is available for download:
http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.9.3.tar.gz
Changes in this release
- Add all new APIs in libvirt 0.9.3
- Requires libvirt = 0.9.3
The permanent
If we get an I/O error in the async event callback for an RPC
client, we might not have consumed all pending data off the
wire. This could result in the callback being immediately
invoked again. At which point the same I/O might occur. And
we're invoked again. And again...And again...
On Thu, Jul 14, 2011 at 7:47 PM, Adam Litke a...@us.ibm.com wrote:
On 07/13/2011 08:04 PM, Daniel Veillard wrote:
On Wed, Jul 13, 2011 at 03:46:30PM -0500, Adam Litke wrote:
Unfortunately, after committing the blockPull API to libvirt, the qemu
community decided to change the API somewhat and
If the libvirt daemon or libvirt client is configured with bogus
certificates, it is very unhelpful to only find out about this
when a TLS connection is actually attempted. Not least because
the error messages you get back for failures are incredibly
obscure.
This adds some basic sanity checking
* src/rpc/virnettlscontext.c: s/read/write/
---
src/rpc/virnettlscontext.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c
index 4963ab7..6a06565 100644
--- a/src/rpc/virnettlscontext.c
+++
If the server succesfully validates the client cert, it will send
back a single byte, under TLS. If it fails, it will close the
connection. In this case, we were just reporting the standard
I/O error. The original RPC code had a special case hack for the
GNUTLS_E_UNEXPECTED_PACKET_LENGTH error
On Thu, Jul 14, 2011 at 7:54 PM, Adam Litke a...@us.ibm.com wrote:
On 07/14/2011 05:33 AM, Stefan Hajnoczi wrote:
On Thu, Jul 14, 2011 at 11:19 AM, Jiri Denemark jdene...@redhat.com wrote:
On Thu, Jul 14, 2011 at 10:58:31 +0100, Stefan Hajnoczi wrote:
On Thu, Jul 14, 2011 at 10:21 AM, Jiri
On 07/15/2011 12:09 PM, Daniel P. Berrange wrote:
On Thu, Jul 14, 2011 at 05:14:57PM +0200, Michal Novotny wrote:
Hi guys,
some time ago I've been investigating the options to get the guest's IP
address information without having to connect to guest's VNC window or
console. It was for one
Am 15.07.2011 12:50, schrieb Stefan Hajnoczi:
On Thu, Jul 14, 2011 at 7:54 PM, Adam Litke a...@us.ibm.com wrote:
On 07/14/2011 05:33 AM, Stefan Hajnoczi wrote:
On Thu, Jul 14, 2011 at 11:19 AM, Jiri Denemark jdene...@redhat.com wrote:
On Thu, Jul 14, 2011 at 10:58:31 +0100, Stefan Hajnoczi
On Fri, Jul 15, 2011 at 12:05 PM, Kevin Wolf kw...@redhat.com wrote:
Am 15.07.2011 12:50, schrieb Stefan Hajnoczi:
On Thu, Jul 14, 2011 at 7:54 PM, Adam Litke a...@us.ibm.com wrote:
On 07/14/2011 05:33 AM, Stefan Hajnoczi wrote:
On Thu, Jul 14, 2011 at 11:19 AM, Jiri Denemark
On Fri, Jul 15, 2011 at 11:43:35 +0100, Daniel P. Berrange wrote:
* src/rpc/virnettlscontext.c: s/read/write/
---
src/rpc/virnettlscontext.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c
index
Gnutls requires that certificates have basic constraints present
to be used as a CA certificate. OpenSSL doesn't add this data
by default, so add a sanity check to catch this situation. Also
validate that the key usage and key purpose constraints contain
correct data
* src/rpc/virnettlscontext.c:
On Fri, Jul 15, 2011 at 11:25:08 +0100, Daniel P. Berrange wrote:
If we get an I/O error in the async event callback for an RPC
client, we might not have consumed all pending data off the
wire. This could result in the callback being immediately
invoked again. At which point the same I/O might
On Fri, Jul 15, 2011 at 11:43:22 +0100, Daniel P. Berrange wrote:
If the server succesfully validates the client cert, it will send
back a single byte, under TLS. If it fails, it will close the
connection. In this case, we were just reporting the standard
I/O error. The original RPC code had a
On Fri, Jul 15, 2011 at 11:40:01 +0100, Daniel P. Berrange wrote:
If the libvirt daemon or libvirt client is configured with bogus
certificates, it is very unhelpful to only find out about this
when a TLS connection is actually attempted. Not least because
the error messages you get back for
Many volume operations will fail if the volume in question is being
allocated. These operations were returning VIR_ERR_INTERNAL_ERROR
when they should be returning VIR_ERR_OPERATION_INVALID.
---
src/storage/storage_driver.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff
于 2011年07月15日 21:47, Dave Allan 写道:
Many volume operations will fail if the volume in question is being
allocated. These operations were returning VIR_ERR_INTERNAL_ERROR
when they should be returning VIR_ERR_OPERATION_INVALID.
---
src/storage/storage_driver.c |8
1 files
2011/7/14 Anthony Fox a.podava...@gmail.com:
ACK and applied, thanks. The comment to virStreamRecv misses two lines
in the returns block, so I'm squashing this in (this diff will
probably come through mangled because of the long lines)
diff --git a/Stream.cs b/Stream.cs
index b349605..d824726
Right now it is possible to undefine an active interface, or
destroy inactive. This patch add some checking to these operations
to prevent this. Also fix test driver.
---
src/interface/netcf_driver.c | 83 --
src/test/test_driver.c |5 +++
2
On 07/15/2011 12:54 AM, Taku Izumi wrote:
Hi all,
This patchset adds the --current option to virsh setvcpus
command. Currently virsh setvcpus command supports
--live and --config , but --current option.
From view of consistency, it's reasonable to support
--current option too.
On 07/15/2011 05:39 AM, Stefan Hajnoczi wrote:
On Thu, Jul 14, 2011 at 7:47 PM, Adam Litke a...@us.ibm.com wrote:
On 07/13/2011 08:04 PM, Daniel Veillard wrote:
On Wed, Jul 13, 2011 at 03:46:30PM -0500, Adam Litke wrote:
Unfortunately, after committing the blockPull API to libvirt, the qemu
On 07/15/2011 07:58 AM, Michal Privoznik wrote:
Right now it is possible to undefine an active interface, or
destroy inactive. This patch add some checking to these operations
to prevent this. Also fix test driver.
I'm inclined to NACK this on design principles (I haven't read the patch
On 07/15/2011 01:02 AM, Taku Izumi wrote:
This patch adds the --current option to virsh setvcpus
command. Currently virsh setvcpus command supports
--live and --config , but --current option.
From view of consistency, it's reasonable to support
--current option too.
When --current is
On 07/15/2011 01:00 AM, Taku Izumi wrote:
This patch extends virDomainSetVcpusFlags API to support
VIR_DOMAIN_AFFECT_CURRENT flag.
Now because most APIs accept VIR_DOMAIN_AFFECT_CURRENT flags,
virDomainSetVcpusFlags API should also do.
Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com
On 07/15/2011 01:01 AM, Taku Izumi wrote:
This patch extends qemudDomainSetVcpusFlags() function to support
VIR_DOMAIN_AFFECT_CURRENT flag.
We've been renaming qemudDomain to qemuDomain lately, so now is as good
a time to make the change for this function as any. Especially since
you used
On 15.07.2011 16:29, Eric Blake wrote:
On 07/15/2011 07:58 AM, Michal Privoznik wrote:
Right now it is possible to undefine an active interface, or
destroy inactive. This patch add some checking to these operations
to prevent this. Also fix test driver.
I'm inclined to NACK this on design
From: Daniel P. Berrange berra...@redhat.com
When libvirtd restarts it will attempt to reconnect to existing
LXC containers. If it loads a XML state file for the container
the container will appear running. If we fail to read the PID
file, or fail to connect to the LXC monitor, we should be
On 15.07.2011 16:45, Eric Blake wrote:
On 07/15/2011 08:36 AM, Michal Privoznik wrote:
On the other hand, if we don't support transient interfaces, then the
above analysis which works for domains would have to be adjusted for
interfaces, so you may have something to patch after all.
Well,
On 07/15/2011 08:45 AM, Eric Blake wrote:
On 07/15/2011 08:36 AM, Michal Privoznik wrote:
On the other hand, if we don't support transient interfaces, then the
above analysis which works for domains would have to be adjusted for
interfaces, so you may have something to patch after all.
Well,
From: David Allan dal...@redhat.com
The libvirt supports: section on the main page of libvirt.org
contains a list of hypervisors with links that point to the sites of
the underlying virt technologies. The entry for KVM points to
http://www.linux-kvm.org/, for example. People coming to
On 07/15/2011 08:48 AM, Michal Privoznik wrote:
On 15.07.2011 16:45, Eric Blake wrote:
On 07/15/2011 08:36 AM, Michal Privoznik wrote:
On the other hand, if we don't support transient interfaces, then the
above analysis which works for domains would have to be adjusted for
interfaces, so you
2011/7/15 Eric Blake ebl...@redhat.com:
On 07/15/2011 08:45 AM, Eric Blake wrote:
On 07/15/2011 08:36 AM, Michal Privoznik wrote:
On the other hand, if we don't support transient interfaces, then the
above analysis which works for domains would have to be adjusted for
interfaces, so you may
2011/7/15 Eric Blake ebl...@redhat.com:
On 07/15/2011 08:48 AM, Michal Privoznik wrote:
On 15.07.2011 16:45, Eric Blake wrote:
On 07/15/2011 08:36 AM, Michal Privoznik wrote:
On the other hand, if we don't support transient interfaces, then the
above analysis which works for domains would
On 07/15/2011 08:49 AM, Dave Allan wrote:
From: David Allan dal...@redhat.com
The libvirt supports: section on the main page of libvirt.org
contains a list of hypervisors with links that point to the sites of
the underlying virt technologies. The entry for KVM points to
On 07/15/2011 08:41 AM, Jiri Denemark wrote:
When an asynchronous job is running while another API that is
incompatible with that job is called, we now try to wait until the job
finishes and either run the API or fail with timeout. I guess nicer
solution is to just fail such API immediately
On 07/15/2011 09:16 AM, Osier Yang wrote:
The regression is introduced by Commit da1eba6b, the new
codes with this commit doesn't reset ret to -1 when
it fails on parsing the device XML (live device attachment)
This patch changes the codes to reset the ret and -1,
and also changes the codes
In light of discussion on V1 of this API, here is V2 of the next generation
BlockPull API. In this series we make the abort and info operations more
generic so that they may apply to future block jobs (such as compression, live
block copy, etc). We also add in a mechanism to set the maximum
On Fri, Jul 15, 2011 at 04:41:38PM +0200, Jiri Denemark wrote:
When an asynchronous job is running while another API that is
incompatible with that job is called, we now try to wait until the job
finishes and either run the API or fail with timeout. I guess nicer
solution is to just fail such
2011/7/15 Eric Blake ebl...@redhat.com:
The previous patches only cleaned up ATTRIBUTE_UNUSED flags cases;
auditing the drivers found other places where flags was being used
but not validated. In particular, domainGetXMLDesc had issues with
clients accepting a different set of flags than the
2011/7/15 Eric Blake ebl...@redhat.com:
* src/qemu/qemu_driver.c (QEMU_MIGRATION_FLAGS): New define.
Simplify all migration callbacks.
---
v3: new patch
src/qemu/qemu_driver.c | 101
++--
1 files changed, 21 insertions(+), 80 deletions(-)
2011/7/15 Eric Blake ebl...@redhat.com:
Silently ignored flags get in the way of new features that
use those flags.
Regarding ESX migration flags - right now, ESX silently enforces
VIR_MIGRATE_PERSIST_DEST, VIR_MIGRATE_UNDEFINE_SOURCE, and
VIR_MIGRATE_LIVE, even if those flags were not
2011/7/15 Eric Blake ebl...@redhat.com:
Also fix a logic bug in xenXMDomain{Attach,Detach}DeviceFlags,
where (flags VIR_DOMAIN_DEVICE_MODIFY_CURRENT) is always false.
* src/xen/xen_driver.c (xenUnifiedDomainXMLFromNative)
(xenUnifiedDomainXMLToNative, xenUnifiedDomainBlockPeek): Reject
On 07/15/2011 01:06 AM, Hu Tao wrote:
Pointed out by Eric. Thanks.
---
tools/virsh.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index b7cea58..b43af70 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -12375,8 +12375,13
2011/7/15 Eric Blake ebl...@redhat.com:
Enforce the recent flags cleanups - we want to use 'unsigned int flags'
in any of our APIs (except where backwards compatibility is important,
in the public migration APIs), and that all flags are checked for
validity (except when there are stub
The documentation for vshCommandOptString claims that it returns
-1 on a missing required argument, but in reality, that error
message was unreachable (it was buried inside an if clause that
is true only if the argument was present). The code was so hairy
that I decided a rewrite would make it
On 07/15/2011 09:25 AM, Matthias Bolte wrote:
2011/7/15 Eric Blake ebl...@redhat.com:
The previous patches only cleaned up ATTRIBUTE_UNUSED flags cases;
auditing the drivers found other places where flags was being used
but not validated. In particular, domainGetXMLDesc had issues with
On 07/15/2011 12:26 PM, Eric Blake wrote:
On 07/15/2011 09:27 AM, Matthias Bolte wrote:
2011/7/15 Eric Blake ebl...@redhat.com:
* src/qemu/qemu_driver.c (QEMU_MIGRATION_FLAGS): New define.
Simplify all migration callbacks.
---
v3: new patch
src/qemu/qemu_driver.c | 101
The libvirt supports: section on the main page of libvirt.org
contains a list of hypervisors with links that point to the sites of
the underlying virt technologies. The entry for KVM points to
http://www.linux-kvm.org/, for example. People coming to libvirt.org
for the first time are likely to
Hi,
I checked the libvirt git tree. It seems that this patch has not been applied.
I think to use virsh command line to control the migration bandwidth is useful.
Thanks.
- Hui
API virDomainMigrateSetMaxSpeed was introduced since 0.9.0, but
no command in virsh yet.
---
tools/virsh.c |
On 07/15/2011 12:34 PM, Hui Kang wrote:
Hi,
I checked the libvirt git tree. It seems that this patch has not been applied.
I think to use virsh command line to control the migration bandwidth is
useful. Thanks.
- Hui
API virDomainMigrateSetMaxSpeed was introduced since 0.9.0,
n 07/14/2011 04:42 PM, Eric Blake wrote:
The previous patches only cleaned up ATTRIBUTE_UNUSED flags cases;
auditing the drivers found other places where flags was being used
but not validated. In particular, domainGetXMLDesc had issues with
clients accepting a different set of flags than the
2011/7/15 Eric Blake ebl...@redhat.com:
The documentation for vshCommandOptString claims that it returns
-1 on a missing required argument, but in reality, that error
message was unreachable (it was buried inside an if clause that
is true only if the argument was present). The code was so
On 07/15/2011 01:05 PM, Eric Blake wrote:
Commit 461e0f1a broke migration, because there was a code path
that tried to enable an internal flag while still going through
the public function. Split the internal flag into a separate
callback, and validate that flags do not overlap.
*
On 07/15/2011 08:37 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
When libvirtd restarts it will attempt to reconnect to existing
LXC containers. If it loads a XML state file for the container
the container will appear running. If we fail to read the PID
file,
On 07/15/2011 06:15 AM, Jiri Denemark wrote:
On Fri, Jul 15, 2011 at 11:40:01 +0100, Daniel P. Berrange wrote:
If the libvirt daemon or libvirt client is configured with bogus
certificates, it is very unhelpful to only find out about this
when a TLS connection is actually attempted. Not least
On 07/15/2011 01:46 PM, Eric Blake wrote:
On 07/15/2011 05:57 AM, Daniel P. Berrange wrote:
Gnutls requires that certificates have basic constraints present
to be used as a CA certificate. OpenSSL doesn't add this data
by default, so add a sanity check to catch this situation. Also
validate
On 07/15/2011 03:06 AM, Osier Yang wrote:
These typos are introduced by file renaming in commit b17b4afaf.
src/remote/qemu_protocol.x \
src/remote/remote_protocol.x \
src/rpc/gendispatch.pl:
s/remote_generator/gendispatch/
src/rpc/genprotocol.pl:
On 07/15/2011 03:06 AM, Osier Yang wrote:
This introduce a new API virDomainUndefineFlags to control the
s/introduce/introduces/
domain undefine process, as the existed API virDomainUndefine
s/existed/existing/
doesn't support flags.
Currently only flag VIR_DOMAIN_UNDEFINE_MANAGED_STATE
On 07/15/2011 03:06 AM, Osier Yang wrote:
---
src/remote/remote_driver.c |3 ++-
src/remote/remote_protocol.x |9 -
src/remote_protocol-structs |4
3 files changed, 14 insertions(+), 2 deletions(-)
+++ b/src/remote_protocol-structs
@@ -533,6 +533,10 @@ struct
My bad. I found that in the 0.9.3 tags. Thanks.
- Hui
On 7/15/11 2:57 PM, Eric Blake ebl...@redhat.com wrote:
On 07/15/2011 12:34 PM, Hui Kang wrote:
Hi,
I checked the libvirt git tree. It seems that this patch has not been
applied.
I think to use virsh command line to control the
On 07/15/2011 03:06 AM, Osier Yang wrote:
* src/qemu/qemu_driver.c: New call back for qemu_driver,
New function qemudDomainUndefineFlags, and changes on
qemudDomainUndefine.
---
src/qemu/qemu_driver.c | 35 ++-
1 files changed, 34 insertions(+), 1
On 07/15/2011 03:06 AM, Osier Yang wrote:
This is just similiar as changes on qemu driver.
* src/libxl/libxl_driver.c: New callback for libxl_driver,
new function libxlDomainUndefineFlags, and changes libxlDomainUndefine
as a wrapper of libxlDomainUndefineFlags.
---
On 07/15/2011 03:06 AM, Osier Yang wrote:
Add domainUndefineFlags support for these drivers (except qemu and
libxl driver), and changes domainUndefine as a wrapper of
domainUndefineFlags, but they actually perform same.
---
src/esx/esx_driver.c | 11 ++-
src/lxc/lxc_driver.c
On 07/15/2011 03:06 AM, Osier Yang wrote:
If the domain has managed state file, and --managed-state is
not specified, then it fails with error prompt to tell user
there is managed state file exists.
Grammar suggestion:
then it fails with an error telling the user that a managed save still
On 07/15/2011 03:06 AM, Osier Yang wrote:
---
tools/virsh.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 8a62612..120f3c8 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -2366,6 +2366,7 @@ cmdDominfo(vshControl
1 - 100 of 117 matches
Mail list logo
