Re: [libvirt] RFC (V2) New virDomainBlockPull API family to libvirt

2011-07-22 Thread Daniel Veillard
On Thu, Jul 21, 2011 at 01:55:04PM -0500, Adam Litke wrote: Here are the patches to implement the BlockPull/BlockJob API as discussed and agreed to. I am testing with a python script (included for completeness as the final patch). The qemu monitor interface is not expected to change in the

Re: [libvirt] [PATCH RESEND RFC v4 1/6] Introduce the function virCgroupForVcpu

2011-07-22 Thread Wen Congyang
At 07/21/2011 11:25 PM, Adam Litke Write: On 07/21/2011 09:29 AM, Daniel P. Berrange wrote: On Thu, Jul 21, 2011 at 08:49:28AM -0500, Adam Litke wrote: On 07/21/2011 08:34 AM, Daniel P. Berrange wrote: On Thu, Jul 21, 2011 at 07:54:05AM -0500, Adam Litke wrote: Added Anthony to give him

Re: [libvirt] [Qemu-devel] live snapshot wiki updated

2011-07-22 Thread Kevin Wolf
Am 21.07.2011 17:01, schrieb Stefan Hajnoczi: On Thu, Jul 21, 2011 at 3:02 PM, Eric Blake ebl...@redhat.com wrote: Thank you for persisting - you've found another hole that needs to be plugged. It sounds like you are proposing that after a qemu process dies, that libvirt re-reads the qcow2

Re: [libvirt] [Qemu-devel] live snapshot wiki updated

2011-07-22 Thread Avi Kivity
On 07/20/2011 04:51 PM, Kevin Wolf wrote: The problem is that QEMU will find backing file file names inside the images which it will be unable to open. How do you suggest we get around that? This is the part with allowing libvirt to override the backing file. Of course, this is not

Re: [libvirt] [Qemu-devel] live snapshot wiki updated

2011-07-22 Thread Kevin Wolf
Am 22.07.2011 09:36, schrieb Avi Kivity: On 07/20/2011 04:51 PM, Kevin Wolf wrote: The problem is that QEMU will find backing file file names inside the images which it will be unable to open. How do you suggest we get around that? This is the part with allowing libvirt to override the

Re: [libvirt] [Qemu-devel] live snapshot wiki updated

2011-07-22 Thread Stefan Hajnoczi
On Fri, Jul 22, 2011 at 8:22 AM, Kevin Wolf kw...@redhat.com wrote: Am 21.07.2011 17:01, schrieb Stefan Hajnoczi: On Thu, Jul 21, 2011 at 3:02 PM, Eric Blake ebl...@redhat.com wrote: Thank you for persisting - you've found another hole that needs to be plugged.  It sounds like you are

Re: [libvirt] [PATCH 3/3] Add a test case for certificate validation

2011-07-22 Thread Daniel P. Berrange
On Thu, Jul 21, 2011 at 04:51:37PM -0600, Eric Blake wrote: On 07/21/2011 06:30 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com This test case checks certification validation rules for - Basic constraints - Key purpose - Key usage - Start/expiry times

Re: [libvirt] [PATCHv2 0/4] support the listenNetwork attribute in graphics

2011-07-22 Thread Daniel P. Berrange
On Wed, Jul 20, 2011 at 04:11:11AM -0400, Laine Stump wrote: This patch series resolves the following bug: https://bugzilla.redhat.com/show_bug.cgi?id=703851 In short, it implements support for a new listenNetwork attribute in the domain's graphics element. When listenNetwork is

[libvirt] [PATCH 1/2] Allow certificate sanity checking to be disabled

2011-07-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com When libvirtd starts it it will sanity check its own certs, and before libvirt clients connect to a remote server they will sanity check their own certs. This patch allows such sanity checking to be skipped. There is no strong reason to need to do

Re: [libvirt] [PATCH RESEND RFC v4 1/6] Introduce the function virCgroupForVcpu

2011-07-22 Thread Adam Litke
On 07/22/2011 01:56 AM, Wen Congyang wrote: So current behaviour if vCPU threads set quota in vCPU group else set nVCPUs * quota in VM group Would change to set nVCPUs * quota in VM group if vCPU threads set quota in vCPU group ? Yes. I treat this answer as

Re: [libvirt] [PATCHv2 0/4] support the listenNetwork attribute in graphics

2011-07-22 Thread Eric Blake
On 07/22/2011 04:37 AM, Daniel P. Berrange wrote: The 'listenNetwork' attribute would solve the second, but do nothing to solve the first. I think we ought to thus use a subelement graphics listen type='network' network='foo'/ /graphics graphics listen type='address'

Re: [libvirt] [PATCH 1/2] Allow certificate sanity checking to be disabled

2011-07-22 Thread Eric Blake
On 07/22/2011 05:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com When libvirtd starts it it will sanity check its own certs, and before libvirt clients connect to a remote server they will sanity check their own certs. This patch allows such sanity checking to be

Re: [libvirt] [PATCHv2 0/4] support the listenNetwork attribute in graphics

2011-07-22 Thread Eric Blake
On 07/22/2011 07:23 AM, Eric Blake wrote: On 07/22/2011 04:37 AM, Daniel P. Berrange wrote: The 'listenNetwork' attribute would solve the second, but do nothing to solve the first. I think we ought to thus use a subelement graphics listen type='network' network='foo'/ /graphics Oops - I

Re: [libvirt] [PATCH] util: make interface.c functions consistently return 0 on error

2011-07-22 Thread Laine Stump
On 07/22/2011 12:22 AM, Eric Blake wrote: On 07/21/2011 10:03 PM, Laine Stump wrote: (This patch must be pushed before the listenNetwork patches can be pushed) All of the functions in util/interface.c were returning 0 on success, but some returned -1 on error, and some returned a positive

Re: [libvirt] [PATCH 2/2] Add a test case for certificate validation

2011-07-22 Thread Eric Blake
On 07/22/2011 05:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com This test case checks certification validation rules for - Basic constraints - Key purpose - Key usage - Start/expiry times It checks initial context creation sanity checks, and live session

[libvirt] [PATCH 0/3] Support readonly mounts in LXC

2011-07-22 Thread Daniel P. Berrange
This patch series introduces support for readonly mounts in LXC. In includes general refactoring which will help other patches coming later too. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/3] Pull code for doing a bind mount into separate method

2011-07-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The bind mount setup is about to get more complicated. To avoid having to deal with several copies, pull it out into a separate lxcContainerMountFSBind method. Also pull out the iteration over container filesystems, so that it will be easier to drop

[libvirt] [PATCH 2/3] Refactor mounting of special filesystems

2011-07-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Even in non-virtual root filesystem mode we should be mounting more than just a new /proc. Refactor lxcContainerMountBasicFS so that it does everything except for /dev and /dev/pts moving that into lxcContainerMountDevFS. Pass in a source prefix to

[libvirt] [PATCH 3/3] Honour filesystem readonly flag make special FS readonly

2011-07-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com A container should not be allowed to modify stuff in /sys or /proc/sys so make them readonly. Make /selinux readonly so that containers think that selinux is disabled. Honour the readonly flag when mounting container filesystems from the guest XML

Re: [libvirt] [PATCH 1/3] Pull code for doing a bind mount into separate method

2011-07-22 Thread Eric Blake
On 07/22/2011 07:41 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The bind mount setup is about to get more complicated. To avoid having to deal with several copies, pull it out into a separate lxcContainerMountFSBind method. Also pull out the iteration over

[libvirt] [PATCH] build: Use $(PYTHON) instead of python for the keycode map generator

2011-07-22 Thread Matthias Bolte
Also prepend $(AM_V_GEN). --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 481caba..eef0669 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -90,7 +90,7 @@ EXTRA_DIST += $(srcdir)/util/virkeymaps.h

Re: [libvirt] [PATCH 2/3] Refactor mounting of special filesystems

2011-07-22 Thread Eric Blake
On 07/22/2011 07:42 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Even in non-virtual root filesystem mode we should be mounting more than just a new /proc. Refactor lxcContainerMountBasicFS so that it does everything except for /dev and /dev/pts moving that into

Re: [libvirt] [PATCH 3/3] Honour filesystem readonly flag make special FS readonly

2011-07-22 Thread Eric Blake
On 07/22/2011 07:42 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com A container should not be allowed to modify stuff in /sys or /proc/sys so make them readonly. Make /selinux readonly so that containers think that selinux is disabled. Are we ever going to want to

Re: [libvirt] [PATCH] xenapi: Fix double-freeing the session in xenapiClose

2011-07-22 Thread Matthias Bolte
2011/7/21 Eric Blake ebl...@redhat.com: On 07/21/2011 10:11 AM, Matthias Bolte wrote: xen_session_logout already frees the whole session object. Don't call xenSessionFree on a freed session object. Reported by Sharmila Radhakrishnan. ---  src/xenapi/xenapi_driver.c |    2 +-  1 files

Re: [libvirt] [PATCH] build: Use $(PYTHON) instead of python for the keycode map generator

2011-07-22 Thread Eric Blake
On 07/22/2011 07:56 AM, Matthias Bolte wrote: Also prepend $(AM_V_GEN). --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 481caba..eef0669 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -90,7 +90,7 @@

[libvirt] [PATCH v4 6/7] bandwidth: Add test cases for network

2011-07-22 Thread Michal Privoznik
--- tests/networkxml2xmlin/bandwidth-network.xml | 16 tests/networkxml2xmlout/bandwidth-network.xml | 16 tests/networkxml2xmltest.c|1 + 3 files changed, 33 insertions(+), 0 deletions(-) create mode 100644

[libvirt] [PATCH v4 5/7] bandwidth: Implement functions to enable and disable QoS

2011-07-22 Thread Michal Privoznik
These function executes 'tc' with appropriate arguments to set desired QoS setting on interface or bridge during its creation. --- configure.ac|4 + libvirt.spec.in |2 +- src/libvirt_private.syms|2 + src/network/bridge_driver.c | 18 +

[libvirt] [PATCH v4 3/7] bandwidth: Add parsing and free functions

2011-07-22 Thread Michal Privoznik
These functions parse given XML node and return pointer to the output. Unknown elements are silently ignored. Attributes must be integer and must fit in unsigned long long. Free function frees elements of virBandwidth structure. --- src/conf/domain_conf.c |5 ++ src/conf/domain_conf.h |

[libvirt] [PATCH v4 4/7] bandwidth: Create format functions

2011-07-22 Thread Michal Privoznik
--- src/conf/domain_conf.c |3 ++ src/conf/network_conf.c |3 ++ src/libvirt_private.syms |1 + src/util/network.c | 72 ++ src/util/network.h |3 ++ 5 files changed, 82 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH 3/3] Honour filesystem readonly flag make special FS readonly

2011-07-22 Thread Daniel P. Berrange
On Fri, Jul 22, 2011 at 08:03:59AM -0600, Eric Blake wrote: On 07/22/2011 07:42 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com A container should not be allowed to modify stuff in /sys or /proc/sys so make them readonly. Make /selinux readonly so that containers

Re: [libvirt] RFC: Implement virDomainGetIPAddress()

2011-07-22 Thread Michal Novotny
[snip] I'm not entirely convinced was want to have this in our APIs, since the arp probing is not really a reliable basis for reporting guest IP details. In the near future there will be guest agents for QEMU which can report this information reliably and I think they're a better bet for any

Re: [libvirt] [PATCH] build: Use $(PYTHON) instead of python for the keycode map generator

2011-07-22 Thread Daniel Veillard
On Fri, Jul 22, 2011 at 08:06:00AM -0600, Eric Blake wrote: On 07/22/2011 07:56 AM, Matthias Bolte wrote: Also prepend $(AM_V_GEN). --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 481caba..eef0669

[libvirt] [PATCH] Pre-create /var/lib/libvirt/sanlock directory

2011-07-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The sanlock plugin for libvirt expects the directory /var/lib/libvirt/sanlock to exist. Create this and add it to the RPM * libvirt.spec.in: Add /var/lib/libvirt/sanlock * src/Makefile.am: Create /var/lib/libvirt/sanlock --- libvirt.spec.in |1 +

Re: [libvirt] [PATCH] build: Use $(PYTHON) instead of python for the keycode map generator

2011-07-22 Thread Matthias Bolte
2011/7/22 Eric Blake ebl...@redhat.com: On 07/22/2011 07:56 AM, Matthias Bolte wrote: Also prepend $(AM_V_GEN). ---  src/Makefile.am |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 481caba..eef0669 100644 ---

Re: [libvirt] [PATCH] build: Use $(PYTHON) instead of python for the keycode map generator

2011-07-22 Thread Matthias Bolte
2011/7/22 Daniel Veillard veill...@redhat.com: On Fri, Jul 22, 2011 at 08:06:00AM -0600, Eric Blake wrote: On 07/22/2011 07:56 AM, Matthias Bolte wrote: Also prepend $(AM_V_GEN). ---  src/Makefile.am |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH 01/12] shutdown: Define new public API virDomainShutdownFlags

2011-07-22 Thread Daniel P. Berrange
On Thu, Jul 21, 2011 at 03:52:52PM -0600, Eric Blake wrote: On 07/21/2011 02:53 PM, Michal Privoznik wrote: This introduces new API virDomainShutdownFlags to allow domain destroying with flags, as the existing API virDomainShutdown misses flags. The set of flags is defined in

Re: [libvirt] [PATCH 01/10] qemu: Implement migration job phases

2011-07-22 Thread Eric Blake
On 07/18/2011 06:27 PM, Jiri Denemark wrote: This patch introduces several helper methods to deal with jobs and phases during migration in a simpler manner. --- src/qemu/MIGRATION.txt| 55 +++ src/qemu/qemu_domain.c|5 ++ src/qemu/qemu_migration.c | 91

Re: [libvirt] [PATCH 02/10] qemu: Migration job on destination daemon

2011-07-22 Thread Eric Blake
On 07/18/2011 06:27 PM, Jiri Denemark wrote: Make MIGRATION_IN use the new helper methods. --- src/qemu/qemu_domain.c|2 +- src/qemu/qemu_domain.h|1 - src/qemu/qemu_migration.c | 97 ++-- 3 files changed, 41 insertions(+), 59

Re: [libvirt] [PATCH] Pre-create /var/lib/libvirt/sanlock directory

2011-07-22 Thread Daniel P. Berrange
On Fri, Jul 22, 2011 at 08:46:10AM -0600, Eric Blake wrote: On 07/22/2011 08:15 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The sanlock plugin for libvirt expects the directory /var/lib/libvirt/sanlock to exist. Create this and add it to the RPM *

Re: [libvirt] [PATCH] Pre-create /var/lib/libvirt/sanlock directory

2011-07-22 Thread Eric Blake
On 07/22/2011 08:15 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The sanlock plugin for libvirt expects the directory /var/lib/libvirt/sanlock to exist. Create this and add it to the RPM * libvirt.spec.in: Add /var/lib/libvirt/sanlock * src/Makefile.am: Create

Re: [libvirt] [PATCH] build: Use $(PYTHON) instead of python for the keycode map generator

2011-07-22 Thread Eric Blake
On 07/22/2011 08:17 AM, Daniel Veillard wrote: chmod +x src/util/virkeycode-mapgen.py to match our style of .py files being executable (even if we run them via $(PYTHON)). just wondering loud, if you change a file attribute like this will git automatically detect it and all to commit the

Re: [libvirt] RFC (V2) New virDomainBlockPull API family to libvirt

2011-07-22 Thread Adam Litke
Thanks Daniel. The upstream code is looking good. I will work on adding some documentation to the development guide. On 07/22/2011 01:07 AM, Daniel Veillard wrote: On Thu, Jul 21, 2011 at 01:55:04PM -0500, Adam Litke wrote: Here are the patches to implement the BlockPull/BlockJob API as

Re: [libvirt] [Qemu-devel] live snapshot wiki updated

2011-07-22 Thread Blue Swirl
On Fri, Jul 22, 2011 at 8:06 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jul 21, 2011 at 8:42 PM, Blue Swirl blauwir...@gmail.com wrote: On Thu, Jul 21, 2011 at 6:01 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jul 21, 2011 at 3:02 PM, Eric Blake ebl...@redhat.com wrote:

[libvirt] [PATCH] driver.h: Fix two driver documentation mistakes

2011-07-22 Thread Wieland Hoffmann
--- src/driver.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/driver.h b/src/driver.h index 9d0d3de..adc3e1c 100644 --- a/src/driver.h +++ b/src/driver.h @@ -945,7 +945,7 @@ typedef virInterfaceDriver *virInterfaceDriverPtr; /** * _virInterfaceDriver: * - *

Re: [libvirt] [Qemu-devel] live snapshot wiki updated

2011-07-22 Thread Blue Swirl
On Fri, Jul 22, 2011 at 12:11 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Jul 22, 2011 at 8:22 AM, Kevin Wolf kw...@redhat.com wrote: Am 21.07.2011 17:01, schrieb Stefan Hajnoczi: On Thu, Jul 21, 2011 at 3:02 PM, Eric Blake ebl...@redhat.com wrote: Thank you for persisting - you've

Re: [libvirt] [Qemu-devel] live snapshot wiki updated

2011-07-22 Thread Blue Swirl
On Fri, Jul 22, 2011 at 11:11 AM, Kevin Wolf kw...@redhat.com wrote: Am 22.07.2011 09:36, schrieb Avi Kivity: On 07/20/2011 04:51 PM, Kevin Wolf wrote:  The problem is that QEMU will find backing file file names inside the  images which it will be unable to open. How do you suggest we get

Re: [libvirt] [PATCH 03/10] qemu: Migration job on source daemon

2011-07-22 Thread Eric Blake
On 07/18/2011 06:27 PM, Jiri Denemark wrote: Make MIGRATION_OUT use the new helper methods. This also introduces new protection to migration v3 process: the migration job is held from Begin to Confirm to avoid changes to a domain during migration (esp. between Begin and Perform phases). This

Re: [libvirt] [PATCH 2/2] Add a test case for certificate validation

2011-07-22 Thread Eric Blake
On 07/22/2011 05:06 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com This test case checks certification validation rules for - Basic constraints - Key purpose - Key usage - Start/expiry times It checks initial context creation sanity checks, and live session

Re: [libvirt] [PATCH v4 1/7] bandwidth: Define schema and create documentation

2011-07-22 Thread Laine Stump
On 07/22/2011 10:07 AM, Michal Privoznik wrote: Define new 'bandwidth' element with possible child element 'inbound' and 'outbound' addressing incoming and outgoing traffic respectively: bandwidth inbound average='1000' peak='2000' burst='5120'/ outbound average='500'/ /bandwidth Leaving

Re: [libvirt] [PATCH v4 2/7] bandwidth: Declare internal structures

2011-07-22 Thread Laine Stump
On 07/22/2011 10:07 AM, Michal Privoznik wrote: --- src/util/network.h | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/util/network.h b/src/util/network.h index 27347f8..3c090d8 100644 --- a/src/util/network.h +++ b/src/util/network.h @@ -48,6 +48,20

[libvirt] [PATCH] tests: fix compilation failures

2011-07-22 Thread Eric Blake
Even though gnutls is a hard-req for libvirt, and gnutls depends on libtasn1, that does not mean that you have to have the libtasn1 development files installed. Skip the test rather than failing compilation in that case. With newer gcc, the test consumed too much stack space. Move things to

Re: [libvirt] [PATCH v4 3/7] bandwidth: Add parsing and free functions

2011-07-22 Thread Laine Stump
On 07/22/2011 10:07 AM, Michal Privoznik wrote: These functions parse given XML node and return pointer to the output. Unknown elements are silently ignored. Attributes must be integer and must fit in unsigned long long. Free function frees elements of virBandwidth structure. ---

Re: [libvirt] [PATCH v4 4/7] bandwidth: Create format functions

2011-07-22 Thread Laine Stump
On 07/22/2011 10:07 AM, Michal Privoznik wrote: --- src/conf/domain_conf.c |3 ++ src/conf/network_conf.c |3 ++ src/libvirt_private.syms |1 + src/util/network.c | 72 ++ src/util/network.h |3 ++ 5 files

Re: [libvirt] [PATCH v4 5/7] bandwidth: Implement functions to enable and disable QoS

2011-07-22 Thread Laine Stump
On 07/22/2011 10:07 AM, Michal Privoznik wrote: These function executes 'tc' with appropriate arguments to set desired QoS setting on interface or bridge during its creation. --- configure.ac|4 + libvirt.spec.in |2 +- src/libvirt_private.syms|2 +

[libvirt] libvirt.org outage

2011-07-22 Thread Eric Blake
libvirt.org appears to be down, possibly for as long as the entire weekend. While that doesn't help anyone trying to browse the online documentation, we at least have the benefit of git being a distributed version control system. For those who would like to track what will be pushed to

Re: [libvirt] [PATCH v4 6/7] bandwidth: Add test cases for network

2011-07-22 Thread Laine Stump
On 07/22/2011 10:07 AM, Michal Privoznik wrote: --- tests/networkxml2xmlin/bandwidth-network.xml | 16 tests/networkxml2xmlout/bandwidth-network.xml | 16 tests/networkxml2xmltest.c|1 + 3 files changed, 33 insertions(+), 0

Re: [libvirt] [PATCH v4 7/7] bandwidth: Add domain schema test suite

2011-07-22 Thread Laine Stump
On 07/22/2011 10:07 AM, Michal Privoznik wrote: --- tests/domainschemadata/domain-bandwidth.xml | 72 +++ 1 files changed, 72 insertions(+), 0 deletions(-) create mode 100644 tests/domainschemadata/domain-bandwidth.xml Instead of putting this file in the

[libvirt] [PATCH] tests: detect gnutls errors

2011-07-22 Thread Eric Blake
* tests/virnettlscontexttest.c (testTLSLoadKey): Report errors. --- Something in gnutls 2.8.5 (RHEL 6) was more leniant than gnutls 2.8.6 (Fedora 14). This still doesn't solve the failure, but at least gets us to see that newer gnutls_x509_privkey_import doesn't like our define of PRIVATE_KEY.

Re: [libvirt] [PATCH] driver.h: Fix two driver documentation mistakes

2011-07-22 Thread Eric Blake
On 07/22/2011 09:53 AM, Wieland Hoffmann wrote: --- src/driver.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/driver.h b/src/driver.h index 9d0d3de..adc3e1c 100644 --- a/src/driver.h +++ b/src/driver.h @@ -945,7 +945,7 @@ typedef virInterfaceDriver

[libvirt] SSH URIs invoking askpass + sudo don't play well together

2011-07-22 Thread Cole Robinson
$ cat test.py import os import sys import libvirt def drop_tty(): if os.fork() != 0: os._exit(0) os.setsid() host = sys.argv[1] # Need to drop controlling tty otherwise SSH won't call askpass drop_tty() libvirt.open(qemu+ssh://root@%s/system % host) $ python test.py localhost

Re: [libvirt] [PATCH 04/10] qemu: Recover from interrupted migration

2011-07-22 Thread Eric Blake
On 07/18/2011 06:27 PM, Jiri Denemark wrote: --- src/qemu/qemu_process.c | 110 ++- 1 files changed, 109 insertions(+), 1 deletions(-) static int +qemuProcessRecoverMigration(struct qemud_driver *driver, +

Re: [libvirt] [PATCH 05/10] qemu: Remove special case for virDomainGetBlockInfo

2011-07-22 Thread Eric Blake
On 07/18/2011 06:27 PM, Jiri Denemark wrote: Like other query commands, this can now be called directly during migration. --- src/qemu/qemu_domain.h|4 src/qemu/qemu_driver.c| 42 -- src/qemu/qemu_migration.c | 14 --

Re: [libvirt] [PATCH] tests: detect gnutls errors

2011-07-22 Thread Matthias Bolte
2011/7/22 Eric Blake ebl...@redhat.com: * tests/virnettlscontexttest.c (testTLSLoadKey): Report errors. --- Something in gnutls 2.8.5 (RHEL 6) was more leniant than gnutls 2.8.6 (Fedora 14).  This still doesn't solve the failure, but at least gets us to see that newer