Re: [libvirt] libvirt.org outage

2011-07-25 Thread Daniel Veillard
On Sat, Jul 23, 2011 at 11:46:39PM +0800, Daniel Veillard wrote: On Fri, Jul 22, 2011 at 01:08:52PM -0600, Eric Blake wrote: libvirt.org appears to be down, possibly for as long as the entire weekend. While that doesn't help anyone trying to browse the online documentation, we at least

Re: [libvirt] [PATCH] docs: Break up 'Basic Resources' XML section

2011-07-25 Thread Daniel Veillard
On Sat, Jul 23, 2011 at 10:12:22PM -0400, Cole Robinson wrote: We had a bit too many elements crammed in there. Separate it into different headings: - CPU Allocation (vcpus) - CPU Tuning (cputune) - Memory allocation (memory and currentMemory) - Memory backing (memoryBacking) - Memory

Re: [libvirt] libvirt.org outage

2011-07-25 Thread Alex Jia
On 07/23/2011 03:08 AM, Eric Blake wrote: libvirt.org appears to be down, possibly for as long as the entire weekend. While that doesn't help anyone trying to browse the online documentation, we at least have the benefit of git being a distributed version control system. For those who would

Re: [libvirt] [PATCH 1/4] python: add Python binding for virDomainGetSchedulerParametersFlags API

2011-07-25 Thread Daniel Veillard
On Fri, Jul 22, 2011 at 02:11:55PM +0900, Taku Izumi wrote: This patch adds the Python bindings for virDomainGetSchedulerParametersFlags API. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- python/libvirt-override-api.xml |6 ++ python/libvirt-override.c | 83

Re: [libvirt] [PATCH 0/4] python: add some missing python bindings

2011-07-25 Thread Daniel Veillard
On Fri, Jul 22, 2011 at 02:03:21PM +0900, Taku Izumi wrote: Hi all, This patchset adds some missing python bindings. The bindings for the following APIs are added: - virDomainGetSchedulerParametersFlags - virDomainSetSchedulerParametersFlags - virDomainPinVcpusFlags -

[libvirt] [PATCHv3 2/2] qemu: support type=network in domain graphics listen

2011-07-25 Thread Laine Stump
The domain XML now understands the listen subelement of its graphics element (including when listen type='network'), and the network driver has an internal API that will turn a network name into an IP address, so the final logical step is to put the glue into the qemu driver so that when it is

Re: [libvirt] [libvirt-test-API][PATCH 2/2] Add clean part for install_windows_cdrom

2011-07-25 Thread Guannan Ren
On 07/25/2011 10:30 AM, Wayne Sun wrote: * Add cleanup function install_windows_cdrom_clean --- repos/domain/install_windows_cdrom.py | 88 +++- 1 files changed, 74 insertions(+), 14 deletions(-) diff --git a/repos/domain/install_windows_cdrom.py

Re: [libvirt] [libvirt-test-API][PATCH 1/2] Add cleap part for install_linux_net

2011-07-25 Thread Guannan Ren
On 07/25/2011 10:30 AM, Wayne Sun wrote: * Add the install_linux_net_clean function --- repos/domain/install_linux_net.py | 58 + 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/repos/domain/install_linux_net.py

[libvirt] FYI: qemu -M option deprecated upstream, removed from -help output

2011-07-25 Thread Richard W.M. Jones
I guess this may affect the qemu driver in future ... Thanks to Markus Armbruster for bringing this to my/our attention. commit 80f52a6694423da7a40e2ec39e14a5817184c7ef Author: Jan Kiszka Date: Sat Jul 23 12:39:46 2011 +0200 Deprecate -M command line options Superseded by

Re: [libvirt] [PATCH ] send-key: Implement Python API

2011-07-25 Thread Lai Jiangshan
ping. On 07/21/2011 05:21 PM, Lai Jiangshan wrote: Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/python/libvirt-override.c b/python/libvirt-override.c index b713b6a..1ef5bfa 100644 --- a/python/libvirt-override.c +++ b/python/libvirt-override.c @@ -3789,6 +3789,53 @@

Re: [libvirt] [PATCHv3 1/2] conf: add listen subelement to domain graphics element

2011-07-25 Thread Laine Stump
Sigh. I'd meant to add more explanation in the [0/2] mail, but forgot to add --compose on my git send-mail commandline. Just a couple of points: 1) The old fields in the unions of virDomainGraphicsDef that used to store the attributes from graphics (listen, port, tlsPort, autoport) have

Re: [libvirt] [PATCHv2 0/4] support the listenNetwork attribute in graphics

2011-07-25 Thread Laine Stump
On 07/22/2011 06:37 AM, Daniel P. Berrange wrote: On Wed, Jul 20, 2011 at 04:11:11AM -0400, Laine Stump wrote: This patch series resolves the following bug: https://bugzilla.redhat.com/show_bug.cgi?id=703851 In short, it implements support for a new listenNetwork attribute in the

Re: [libvirt] [PATCH] rename cfs_* to vcpu_*

2011-07-25 Thread Daniel Veillard
On Mon, Jul 25, 2011 at 01:38:51PM +0800, Wen Congyang wrote: In the XML file we now have cputune shares1024/shares period9/period quota0/quota /cputune But the schedinfo parameter are being named cpu_shares: 1024 cfs_period: 9 cfs_quota: 0 The

Re: [libvirt] [PATCH v4 0/7] Add support for setting QoS

2011-07-25 Thread Michal Privoznik
On 22.07.2011 16:07, Michal Privoznik wrote: This patch series add support for setting traffic shaping and policing on both domain's interface and network's virtual bridge. Basically, this is done via 'tc' from iproute2 package. For shaping is HTB used, for policing we need u32 match selector.

Re: [libvirt] [PATCH] docs: Break up 'Basic Resources' XML section

2011-07-25 Thread Cole Robinson
On 07/25/2011 01:58 AM, Daniel Veillard wrote: On Sat, Jul 23, 2011 at 10:12:22PM -0400, Cole Robinson wrote: We had a bit too many elements crammed in there. Separate it into different headings: - CPU Allocation (vcpus) - CPU Tuning (cputune) - Memory allocation (memory and currentMemory)

Re: [libvirt] FYI: qemu -M option deprecated upstream, removed from -help output

2011-07-25 Thread Paolo Bonzini
On 07/25/2011 11:12 AM, Richard W.M. Jones wrote: I guess this may affect the qemu driver in future ... Thanks to Markus Armbruster for bringing this to my/our attention. As long as QEMU supports -M ? it should not be a problem. The -M option is not scraped from -help output. Paolo --

Re: [libvirt] libvirt.org outage

2011-07-25 Thread Daniel P. Berrange
On Sat, Jul 23, 2011 at 11:46:39PM +0800, Daniel Veillard wrote: On Fri, Jul 22, 2011 at 01:08:52PM -0600, Eric Blake wrote: libvirt.org appears to be down, possibly for as long as the entire weekend. While that doesn't help anyone trying to browse the online documentation, we at least

Re: [libvirt] SSH URIs invoking askpass + sudo don't play well together

2011-07-25 Thread Daniel P. Berrange
On Fri, Jul 22, 2011 at 04:38:20PM -0400, Cole Robinson wrote: $ cat test.py import os import sys import libvirt def drop_tty(): if os.fork() != 0: os._exit(0) os.setsid() host = sys.argv[1] # Need to drop controlling tty otherwise SSH won't call askpass drop_tty()

Re: [libvirt] [PATCH v4 0/7] Add support for setting QoS

2011-07-25 Thread Laine Stump
On 07/25/2011 06:29 AM, Michal Privoznik wrote: On 22.07.2011 16:07, Michal Privoznik wrote: This patch series add support for setting traffic shaping and policing on both domain's interface and network's virtual bridge. Basically, this is done via 'tc' from iproute2 package. For shaping is HTB

[libvirt] New upstream repo for libvirt-qmf

2011-07-25 Thread Zane Bitter
As part of the renaming of libvirt-qpid to libvirt-qmf, the libvirt-qmf upstream is now hosted on the Matahari Project's GitHub account here: https://github.com/matahari/libvirt-qmf regards, Zane. -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] rename cfs_* to vcpu_*

2011-07-25 Thread Wen Congyang
At 07/25/2011 05:49 PM, Daniel Veillard write: On Mon, Jul 25, 2011 at 01:38:51PM +0800, Wen Congyang wrote: In the XML file we now have cputune shares1024/shares period9/period quota0/quota /cputune But the schedinfo parameter are being named cpu_shares: 1024

Re: [libvirt] [PATCH] tests: fix compilation failures

2011-07-25 Thread Daniel P. Berrange
On Fri, Jul 22, 2011 at 12:33:10PM -0600, Eric Blake wrote: Even though gnutls is a hard-req for libvirt, and gnutls depends on libtasn1, that does not mean that you have to have the libtasn1 development files installed. Skip the test rather than failing compilation in that case. With

[libvirt] [PATCH] python: Handle embedded NULL in stream.send data

2011-07-25 Thread Cole Robinson
Otherwise things like volume upload are only useful with text data. --- python/libvirt-override.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/python/libvirt-override.c b/python/libvirt-override.c index 9d1dac2..70e0238 100644 --- a/python/libvirt-override.c +++

Re: [libvirt] [PATCH] tests: detect gnutls errors

2011-07-25 Thread Daniel P. Berrange
On Fri, Jul 22, 2011 at 11:55:02PM +0200, Matthias Bolte wrote: 2011/7/22 Eric Blake ebl...@redhat.com: * tests/virnettlscontexttest.c (testTLSLoadKey): Report errors. --- Something in gnutls 2.8.5 (RHEL 6) was more leniant than gnutls 2.8.6 (Fedora 14).  This still doesn't solve the

Re: [libvirt] [PATCH] tests: detect gnutls errors

2011-07-25 Thread Matthias Bolte
2011/7/25 Daniel P. Berrange berra...@redhat.com: On Fri, Jul 22, 2011 at 11:55:02PM +0200, Matthias Bolte wrote: 2011/7/22 Eric Blake ebl...@redhat.com: * tests/virnettlscontexttest.c (testTLSLoadKey): Report errors. --- Something in gnutls 2.8.5 (RHEL 6) was more leniant than gnutls

Re: [libvirt] [PATCH] tests: detect gnutls errors

2011-07-25 Thread Daniel P. Berrange
On Mon, Jul 25, 2011 at 05:47:25PM +0200, Matthias Bolte wrote: 2011/7/25 Daniel P. Berrange berra...@redhat.com: On Fri, Jul 22, 2011 at 11:55:02PM +0200, Matthias Bolte wrote: 2011/7/22 Eric Blake ebl...@redhat.com: * tests/virnettlscontexttest.c (testTLSLoadKey): Report errors. ---

[libvirt] [PATCH 3/4] Report error if unable to bind to any socket

2011-07-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com When setting up a server socket, we must skip EADDRINUSE errors from bind, since the IPv6 socket bind may have already bound to the IPv4 socket too. If we don't manage to bind to any sockets at all though, we should then report the EADDRINUSE error as

[libvirt] [PATCH 2/4] Fix leak of mDNS object in virNetServer

2011-07-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com * src/rpc/virnetserver.c: Free mDNS object --- src/rpc/virnetserver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index bc7b476..2b9dd4d 100644 --- a/src/rpc/virnetserver.c

[libvirt] [PATCH 4/4] Add mutex protection to SASL and TLS modules

2011-07-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virNetSASLContext, virNetSASLSession, virNetTLSContext and virNetTLSSession classes previously relied in their owners (virNetClient / virNetServer / virNetServerClient) to provide locking protection for concurrent usage. When virNetSocket gained

[libvirt] [PATCH 1/4] Fix memory leaks in MDNS code

2011-07-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com * src/rpc/virnetservermdns.c: Fix leaks --- src/rpc/virnetservermdns.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/rpc/virnetservermdns.c b/src/rpc/virnetservermdns.c index ff2d92d..335274a 100644 ---

[libvirt] [PATCH 2/2] TLS: Introduce session mutex

2011-07-25 Thread Michal Privoznik
Some TLX interacting functions can be called within two or more threads with the same pointer. Therefore we need to protect virNetTLSSessionPtr with mutex to avoid non-consistent states. --- src/rpc/virnettlscontext.c | 41 +++-- 1 files changed, 39

[libvirt] [PATCH] Fix import of private key with older gnutls

2011-07-25 Thread Daniel P. Berrange
With older GNUTLS the gnutls_x509_privkey_import function is unable to import our private key. Instead we must use the alternative gnutls_x509_privkey_import_pkcs8() (as certtool does). * virnettlscontexttest.c: Fix import of private key with older gnutls. Also add missing newlines to key ---

Re: [libvirt] [PATCH] tests: detect gnutls errors

2011-07-25 Thread Daniel P. Berrange
On Mon, Jul 25, 2011 at 05:47:25PM +0200, Matthias Bolte wrote: 2011/7/25 Daniel P. Berrange berra...@redhat.com: On Fri, Jul 22, 2011 at 11:55:02PM +0200, Matthias Bolte wrote: 2011/7/22 Eric Blake ebl...@redhat.com: * tests/virnettlscontexttest.c (testTLSLoadKey): Report errors. ---

[libvirt] [PATCH] Add libtasn1-devel as a BuildRequires for libvirt.spec

2011-07-25 Thread Daniel P. Berrange
* libvirt.spec.in: Add libtasn1-devel --- libvirt.spec.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 002239c..e2b7f65 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -332,6 +332,7 @@ BuildRequires: libxslt BuildRequires:

Re: [libvirt] [PATCH] Fix import of private key with older gnutls

2011-07-25 Thread Matthias Bolte
2011/7/25 Daniel P. Berrange berra...@redhat.com: With older GNUTLS the gnutls_x509_privkey_import function is unable to import our private key. Instead we must use the alternative gnutls_x509_privkey_import_pkcs8() (as certtool does). * virnettlscontexttest.c: Fix import of private key with

[libvirt] [PATCH] util: change virFile*Pid functions to return 0 on failure

2011-07-25 Thread Laine Stump
Although most functions in libvirt return 0 on success and 0 on failure, there are a few functions lingering around that return errno (a positive value) on failure, and sometimes code calling those functions incorrectly assumes the 0 standard. I noticed one of these the other day when auditing

[libvirt] [PATCH 1/2] Allow different types of callbacks (just as the C API).

2011-07-25 Thread js
From: Julian Stecklina jstec...@os.inf.tu-dresden.de --- src/main/java/org/libvirt/Connect.java |3 ++- src/main/java/org/libvirt/jna/Libvirt.java | 22 -- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/libvirt/Connect.java

[libvirt] [PATCH 0/2] Libvirt-java event handling

2011-07-25 Thread js
From: Julian Stecklina jstec...@os.inf.tu-dresden.de I noticed that event handling in the libvirt Java bindings is incomplete. The first patch adds required data types and constants. The second relaxes the visibility of the Domain constructor, otherwise Callbacks are kind of useless. Regards,

[libvirt] [PATCH 2/2] Allow to construct Domain objects from inside callbacks.

2011-07-25 Thread js
From: Julian Stecklina jstec...@os.inf.tu-dresden.de --- src/main/java/org/libvirt/Domain.java |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/main/java/org/libvirt/Domain.java b/src/main/java/org/libvirt/Domain.java index 3b0298b..f84c420 100644 ---

Re: [libvirt] [PATCH 2/4] Fix leak of mDNS object in virNetServer

2011-07-25 Thread Laine Stump
On 07/25/2011 01:03 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com * src/rpc/virnetserver.c: Free mDNS object --- src/rpc/virnetserver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index

Re: [libvirt] [PATCH] Add libtasn1-devel as a BuildRequires for libvirt.spec

2011-07-25 Thread Laine Stump
On 07/25/2011 01:18 PM, Daniel P. Berrange wrote: * libvirt.spec.in: Add libtasn1-devel --- libvirt.spec.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 002239c..e2b7f65 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@

Re: [libvirt] [PATCH 3/4] Report error if unable to bind to any socket

2011-07-25 Thread Laine Stump
On 07/25/2011 01:03 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com When setting up a server socket, we must skip EADDRINUSE errors from bind, since the IPv6 socket bind may have already bound to the IPv4 socket too. If we don't manage to bind to any sockets at all

Re: [libvirt] [PATCH 1/4] Fix memory leaks in MDNS code

2011-07-25 Thread Laine Stump
On 07/25/2011 01:03 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com * src/rpc/virnetservermdns.c: Fix leaks --- src/rpc/virnetservermdns.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/rpc/virnetservermdns.c

Re: [libvirt] [PATCH 1/2] SASL: Introduce session mutex

2011-07-25 Thread Laine Stump
On 07/25/2011 01:04 PM, Michal Privoznik wrote: Some of SASL interacting functions can be called within two or more threads with the same pointer. Therefore we need to protect virNetSASLSessionPtr with mutex to avoid non-consistent states. Looks like you and danpb had the same idea at roughly

Re: [libvirt] [PATCH] util: change virFile*Pid functions to return 0 on failure

2011-07-25 Thread Eric Blake
On 07/25/2011 12:19 PM, Laine Stump wrote: Although most functions in libvirt return 0 on success and 0 on failure, there are a few functions lingering around that return errno (a positive value) on failure, and sometimes code calling those functions incorrectly assumes the0 standard. I noticed

Re: [libvirt] [PATCH] tests: fix compilation failures

2011-07-25 Thread Eric Blake
On 07/25/2011 09:39 AM, Daniel P. Berrange wrote: (struct testTLSCertReq): Alter time members. (testTLSGenerateCert): Reflect the change. (mymain): Reduce stack usage. --- -/* if zero, then the current time will be used */ -time_t start; -time_t expire; +/* zero for current

Re: [libvirt] [PATCH] Fix import of private key with older gnutls

2011-07-25 Thread Eric Blake
On 07/25/2011 11:59 AM, Matthias Bolte wrote: 2011/7/25 Daniel P. Berrangeberra...@redhat.com: With older GNUTLS the gnutls_x509_privkey_import function is unable to import our private key. Instead we must use the alternative gnutls_x509_privkey_import_pkcs8() (as certtool does). *

Re: [libvirt] FYI: qemu -M option deprecated upstream, removed from -help output

2011-07-25 Thread Eric Blake
On 07/25/2011 05:57 AM, Paolo Bonzini wrote: On 07/25/2011 11:12 AM, Richard W.M. Jones wrote: I guess this may affect the qemu driver in future ... Thanks to Markus Armbruster for bringing this to my/our attention. As long as QEMU supports -M ? it should not be a problem. The -M option is

Re: [libvirt] [PATCH] python: Handle embedded NULL in stream.send data

2011-07-25 Thread Eric Blake
On 07/25/2011 09:45 AM, Cole Robinson wrote: NULL refers to the pointer (4 or 8 bytes), NUL refers to the character (1 byte). Therefore, in the subject line: s/NULL/NUL/ Otherwise things like volume upload are only useful with text data. --- python/libvirt-override.c |5 +++-- 1

Re: [libvirt] [PATCH] Catch dnsmasq start failures

2011-07-25 Thread Guido Günther
On Sun, Jul 24, 2011 at 10:08:13AM -0400, Laine Stump wrote: On 07/23/2011 05:26 PM, Guido Günther wrote: While we checked the return value we didn't maks sure ret != 0 which resulted in dnsmasq errors being ignored. --- src/network/bridge_driver.c |4 +++- 1 files changed, 3

Re: [libvirt] [PATCH] util: change virFile*Pid functions to return 0 on failure

2011-07-25 Thread Laine Stump
On 07/25/2011 03:17 PM, Eric Blake wrote: On 07/25/2011 12:19 PM, Laine Stump wrote: Although most functions in libvirt return 0 on success and 0 on failure, there are a few functions lingering around that return errno (a positive value) on failure, and sometimes code calling those functions

Re: [libvirt] [PATCH] python: Handle embedded NULL in stream.send data

2011-07-25 Thread Cole Robinson
On 07/25/2011 04:28 PM, Eric Blake wrote: On 07/25/2011 09:45 AM, Cole Robinson wrote: NULL refers to the pointer (4 or 8 bytes), NUL refers to the character (1 byte). Therefore, in the subject line: s/NULL/NUL/ Otherwise things like volume upload are only useful with text data. ---

Re: [libvirt] [PATCH] vcpu: teach getVcpusFlags about current

2011-07-25 Thread Laine Stump
On 07/15/2011 07:38 PM, Eric Blake wrote: Now that virDomainSetVcpusFlags knows about VIR_DOMAIN_AFFECT_CURRENT, so should virDomainGetVcpusFlags. Unfortunately, the virsh counterpart 'virsh vcpucount' has already commandeered --current for a different meaning, so virsh does not have a way to

Re: [libvirt] [PATCH] virsh: make vcpucount use --current consistently

2011-07-25 Thread Laine Stump
On 07/18/2011 06:12 PM, Eric Blake wrote: Rename the existing --current flag to the new name --active, while adding a new flag --current to expose the new VIR_DOMAIN_AFFECT_CURRENT flag of virDomainGetVcpusFlags. For backwards compability, the output does not change (even though the label

Re: [libvirt] [PATCH] virsh: use faster bit search

2011-07-25 Thread Laine Stump
On 07/15/2011 05:50 PM, Eric Blake wrote: Now that gnulib gives us ffs, we might as well use it. * tools/virsh.c (vshCmddefGetData): Use ffs rather than count_one_bits. --- tools/virsh.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ACK. -- libvir-list mailing list

Re: [libvirt] [PATCH] vcpu: teach getVcpusFlags about current

2011-07-25 Thread Eric Blake
On 07/25/2011 03:33 PM, Laine Stump wrote: On 07/15/2011 07:38 PM, Eric Blake wrote: Now that virDomainSetVcpusFlags knows about VIR_DOMAIN_AFFECT_CURRENT, so should virDomainGetVcpusFlags. Unfortunately, the virsh counterpart 'virsh vcpucount' has already commandeered --current for a

Re: [libvirt] [PATCH] virsh: make vcpucount use --current consistently

2011-07-25 Thread Eric Blake
On 07/25/2011 03:33 PM, Laine Stump wrote: On 07/18/2011 06:12 PM, Eric Blake wrote: Rename the existing --current flag to the new name --active, while adding a new flag --current to expose the new VIR_DOMAIN_AFFECT_CURRENT flag of virDomainGetVcpusFlags. For backwards compability, the output

Re: [libvirt] [PATCH] virsh: use faster bit search

2011-07-25 Thread Eric Blake
On 07/25/2011 03:53 PM, Laine Stump wrote: On 07/15/2011 05:50 PM, Eric Blake wrote: Now that gnulib gives us ffs, we might as well use it. * tools/virsh.c (vshCmddefGetData): Use ffs rather than count_one_bits. --- tools/virsh.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ACK.

Re: [libvirt] [PATCH 0/4] python: add some missing python bindings

2011-07-25 Thread Taku Izumi
On Mon, 25 Jul 2011 15:07:41 +0800 Daniel Veillard veill...@redhat.com wrote: On Fri, Jul 22, 2011 at 02:03:21PM +0900, Taku Izumi wrote: Hi all, This patchset adds some missing python bindings. The bindings for the following APIs are added: - virDomainGetSchedulerParametersFlags

Re: [libvirt] [PATCH 4/4] Add mutex protection to SASL and TLS modules

2011-07-25 Thread Daniel Veillard
On Mon, Jul 25, 2011 at 06:03:25PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virNetSASLContext, virNetSASLSession, virNetTLSContext and virNetTLSSession classes previously relied in their owners (virNetClient / virNetServer / virNetServerClient) to

Re: [libvirt] [PATCH 1/4] Fix memory leaks in MDNS code

2011-07-25 Thread Daniel Veillard
On Mon, Jul 25, 2011 at 06:03:22PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com * src/rpc/virnetservermdns.c: Fix leaks ACK Okay, I applied and pushed the series, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/

Re: [libvirt] [PATCH] set cpu bandwidth for the vm

2011-07-25 Thread Gui Jianfeng
Daniel, Would you get a chance to take a look at this patch. Thanks, Gui On 2011-7-25 13:37, Wen Congyang wrote: The cpu bandwidth is applied at the vcpu group level. We should apply it at the vm group level too, because the vm may do heavy I/O, and it will affect the other vm. We apply

[libvirt] [PATCH 1/2] Correct minimum cpu_shares value

2011-07-25 Thread Dave Allan
Fixes bz 639591 --- tools/virsh.pod |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 5b7fa9c..dd3457c 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -696,7 +696,7 @@ If I--live is specified, set scheduler information of a

[libvirt] two manpage fixups

2011-07-25 Thread Dave Allan
The following two patches fix up a couple of errors in the virsh manpage. Dave -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/2] Fix incorrect implication about list options

2011-07-25 Thread Dave Allan
The description of the list command seemed to suggest that it could take a set of domains as an argument, which is not correct in the current HEAD. If virsh list is intended to take a list of domains, then this patch should be NAK'd and a bug opened against virsh list. Reported by hachi on #virt

[libvirt] [PATCH 1/2] update documentation for command attach-disk

2011-07-25 Thread Hu Tao
--- source/attach-disk.xml | 292 +++- 1 files changed, 288 insertions(+), 4 deletions(-) diff --git a/source/attach-disk.xml b/source/attach-disk.xml index 0922623..4e3d37e 100644 --- a/source/attach-disk.xml +++ b/source/attach-disk.xml @@ -9,16

[libvirt] [PATCH 0/2] about Virsh Command Reference

2011-07-25 Thread Hu Tao
Hi, We now have libvirt advanced at 0.9.3, but there is almost no progress has been made on Virsh Command Reference. I'm now starting on updating Virsh Command Reference to get it synced with libvirt/virsh, but since I'm not a native-English speaker, there must be grammers, typos,

[libvirt] [PATCH 2/2] update documentation for command detach-disk

2011-07-25 Thread Hu Tao
--- source/detach-disk.xml | 233 +++- 1 files changed, 229 insertions(+), 4 deletions(-) diff --git a/source/detach-disk.xml b/source/detach-disk.xml index 53f71e4..16d282c 100644 --- a/source/detach-disk.xml +++ b/source/detach-disk.xml @@ -9,16

Re: [libvirt] [PATCH 2/2] Fix incorrect implication about list options

2011-07-25 Thread Osier Yang
于 2011年07月26日 09:48, Dave Allan 写道: The description of the list command seemed to suggest that it could take a set of domains as an argument, which is not correct in the current HEAD. If virsh list is intended to take a list of domains, then this patch should be NAK'd and a bug opened against

[libvirt] [PATCH 1/1] Fix incorrect implication about list options

2011-07-25 Thread Dave Allan
The description of the list command seemed to suggest that it could take a set of domains as an argument, which is not correct in the current HEAD. If virsh list is intended to take a list of domains, then this patch should be NAK'd and a bug opened against virsh list. Reported by hachi on #virt

Re: [libvirt] [PATCH] set cpu bandwidth for the vm

2011-07-25 Thread Daniel Veillard
On Mon, Jul 25, 2011 at 01:37:14PM +0800, Wen Congyang wrote: The cpu bandwidth is applied at the vcpu group level. We should apply it at the vm group level too, because the vm may do heavy I/O, and it will affect the other vm. We apply cpu bandwidth at the vcpu and the vm group level, so we

Re: [libvirt] [PATCH 1/2] Correct minimum cpu_shares value

2011-07-25 Thread Osier Yang
于 2011年07月26日 09:48, Dave Allan 写道: Fixes bz 639591 --- tools/virsh.pod |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 5b7fa9c..dd3457c 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -696,7 +696,7 @@ If I--live is

Re: [libvirt] [PATCH 1/2] Correct minimum cpu_shares value

2011-07-25 Thread Dave Allan
On Tue, Jul 26, 2011 at 11:44:37AM +0800, Osier Yang wrote: 于 2011年07月26日 09:48, Dave Allan 写道: Fixes bz 639591 --- tools/virsh.pod |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 5b7fa9c..dd3457c 100644 ---

[libvirt] [PATCH 3/5] block_resize: Implement qemu monitor functions

2011-07-25 Thread Osier Yang
Implements functions for both HMP and QMP mode. (command block_resize is supported by qemu in both HMP and QMP mode). In HMP mode, qemu uses M as the units by default, so the passed sized is divided by 1024. In QMP mode, qemu uses Bytes as the units by default, the passed sized is multiplied by

[libvirt] [PATCH 5/5] block_resize: Expose the new API to virsh

2011-07-25 Thread Osier Yang
The units for size is kilobytes, path is the absolute path of the disk image, which can be extract from the disk XML. E.g. (disksource file='$path'/disk). --- tools/virsh.c | 61 ++- tools/virsh.pod |8 +++ 2 files changed, 68

[libvirt] [PATCH 4/5] block_resize: Implement qemu driver method

2011-07-25 Thread Osier Yang
It requires the domain is running, otherwise fails. Resize to a lower size is supported, but should be used with extreme caution. In order to prohibit the size overflowing after multiplied by 1024. We do checking in the codes. This might be not quite properly, as for QMP mode, the default units

[libvirt] [PATCH 1/5] block_resize: Define the new API

2011-07-25 Thread Osier Yang
The new API is named as virDomainBlockResize, intending to add support for qemu monitor command block_resize (both HMP and QMP). Similar with APIs like virDomainSetMemoryFlags, the units for argument size is kilobytes. --- include/libvirt/libvirt.h.in |4 ++ python/generator.py |

[libvirt] [PATCH 2/5] block_resize: Wire up the remote protocol

2011-07-25 Thread Osier Yang
--- src/remote/remote_driver.c |1 + src/remote/remote_protocol.x | 10 +- src/remote_protocol-structs |7 +++ 3 files changed, 17 insertions(+), 1 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 0652e0d..abb9015 100644 ---

[libvirt] [RFC PATCH 0/5] Support online resizing of block devices.

2011-07-25 Thread Osier Yang
This patch series introduce new API virDomainBlockResize to expose qemu monitor command block_size, which is for resizing the a block device while the domain is running. The prototype for the new API is: int virDomainBlockResize (virDomainPtr dom, const char