Re: [libvirt] [PATCH RFC] virsh: Add option to undefine storage with domains

2011-07-29 Thread Peter Krempa
On 07/28/2011 04:10 PM, Dave Allan wrote: On Thu, Jul 28, 2011 at 03:41:01PM +0200, Peter Krempa wrote: Adds an option to virsh undefine command to undefine managed storage volumes along with (inactive) domains. Storage volumes are enumerated and the user may interactivly choose volumes to

[libvirt] [PATCH] openvz: detect when a domain was shut down from the inside

2011-07-29 Thread Jean-Baptiste Rouault
This patch adds an internal function openvzGetVEStatus to get the real state of the domain. This function is used in various places in the driver, in particular to detect when the domain has been shut down by the user with the halt command. --- src/openvz/openvz_driver.c | 76

Re: [libvirt] [PATCH] qemu: fix crash when mixing sync and async monitor jobs

2011-07-29 Thread Wen Congyang
At 07/29/2011 07:47 AM, Eric Blake Write: Currently, we attempt to run sync job and async job at the same time. It means that the monitor commands for two jobs can be run in any order. In the function qemuDomainObjEnterMonitorInternal(): if (priv-job.active == QEMU_JOB_NONE

[libvirt] [PATCH 1/2] Add virBufferQuoteString

2011-07-29 Thread Guido Günther
Quote strings so they're safe to pass to the shell. Based on glib's g_quote_string. --- src/libvirt_private.syms |1 + src/util/buf.c | 29 + src/util/buf.h |1 + 3 files changed, 31 insertions(+), 0 deletions(-) diff --git

[libvirt] [PATCH 2/2] Use virBufferQuoteString in virNetSocketNewConnectSSH

2011-07-29 Thread Guido Günther
to quote the netcat command since it's passed to the shell. Adjust expected test case output accordingly. --- src/rpc/virnetsocket.c | 25 - tests/virnetsockettest.c | 10 +- 2 files changed, 25 insertions(+), 10 deletions(-) diff --git

[libvirt] [PATCH] utils: More useful error message for hook script failure

2011-07-29 Thread Osier Yang
Commit 3709a386 ported hooks codes to new command execution API, together with the useful error message removed. Though we can't get errbuf from the new command execution API anymore, still we can give a more useful error. https://bugzilla.redhat.com/show_bug.cgi?id=726398 --- src/util/hooks.c |

Re: [libvirt] [PATCH] freebsd: Avoid /bin/true in commandtest

2011-07-29 Thread Matthias Bolte
2011/7/28 Eric Blake ebl...@redhat.com: On 07/28/2011 09:52 AM, Matthias Bolte wrote: Rely on PATH and use just true, because on FreeBSD it's /usr/bin/true. What fun.  The autoconf manual has this gem under true, apropos to the current patch: | when asked whether false is more portable

Re: [libvirt] [PATCH] utils: More useful error message for hook script failure

2011-07-29 Thread Daniel Veillard
On Fri, Jul 29, 2011 at 06:23:41PM +0800, Osier Yang wrote: Commit 3709a386 ported hooks codes to new command execution API, together with the useful error message removed. Though we can't get errbuf from the new command execution API anymore, still we can give a more useful error.

[libvirt] [PATCH] Fix bug #611823 prohibit pools with duplicate storage

2011-07-29 Thread Lei Li
To make sure the unique storage pool defined and created from different directory to avoid inconsistent version of volume pool created, I add two API be called by storage driver to check for the probable duplicate pools and refused the duplicate pool. virStoragePoolObjFindByPath() provide a

[libvirt] How to connect to the running VM

2011-07-29 Thread bala suru
Hi, I have deployed some VM on to the KVM-qemu and installed libvirtd .. I could see the VM running by command virsh list . but how to login to the VMs other than SSH ..? i tried virsh vncdisplay , but no output .. regards bala -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] utils: More useful error message for hook script failure

2011-07-29 Thread Eric Blake
On 07/29/2011 04:23 AM, Osier Yang wrote: Commit 3709a386 ported hooks codes to new command execution API, together with the useful error message removed. Though we can't get errbuf from the new command execution API anymore, still we can give a more useful error.

[libvirt] [PATCH] tests: Don't use bash if we don't have to

2011-07-29 Thread Matthias Bolte
This tested failed on FreeBSD because it was using bash, that might not be installed. --- tests/int-overflow |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/int-overflow b/tests/int-overflow index baf2eef..36e5536 100755 --- a/tests/int-overflow +++

[libvirt] ANNOUNCE: ruby-libvirt 0.4.0

2011-07-29 Thread Chris Lalancette
All, I'm pleased to announce the release of ruby-libvirt 0.4.0. ruby-libvirt is a ruby wrapper around the libvirt API. Version 0.4.0 brings new APIs, more documentation, and bugfixes: * Updated Domain class, implementing dom.memory_parameters=, dom.memory_parameters, dom.updated?,

Re: [libvirt] [PATCHv2 2/2] freebsd: Fix build problem due to picking up the wrong libvirt.h

2011-07-29 Thread Matthias Bolte
2011/7/28 Eric Blake ebl...@redhat.com: From: Matthias Bolte matthias.bo...@googlemail.com Gettext annoyingly modifies CPPFLAGS in-place, putting -I/usr/local/include into the search patch if libintl headers must be used from that location.  But since we must support automake 1.9.6 which

Re: [libvirt] [PATCH] tests: Don't use bash if we don't have to

2011-07-29 Thread Eric Blake
On 07/29/2011 06:19 AM, Matthias Bolte wrote: This tested failed on FreeBSD because it was using bash, that might not be installed. --- tests/int-overflow |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/int-overflow b/tests/int-overflow index baf2eef..36e5536

Re: [libvirt] [PATCH] qemu: fix crash when mixing sync and async monitor jobs

2011-07-29 Thread Eric Blake
On 07/29/2011 02:59 AM, Wen Congyang wrote: At 07/29/2011 07:47 AM, Eric Blake Write: Currently, we attempt to run sync job and async job at the same time. It means that the monitor commands for two jobs can be run in any order. In the function qemuDomainObjEnterMonitorInternal(): if

Re: [libvirt] [PATCHv2 2/2] freebsd: Fix build problem due to picking up the wrong libvirt.h

2011-07-29 Thread Eric Blake
On 07/29/2011 07:16 AM, Matthias Bolte wrote: 2011/7/28 Eric Blakeebl...@redhat.com: From: Matthias Boltematthias.bo...@googlemail.com Gettext annoyingly modifies CPPFLAGS in-place, putting -I/usr/local/include into the search patch if libintl headers must be used from that location. But

Re: [libvirt] How to connect to the running VM

2011-07-29 Thread Zdenek Styblik
On 07/29/11 13:36, bala suru wrote: Hi, I have deployed some VM on to the KVM-qemu and installed libvirtd .. I could see the VM running by command virsh list . but how to login to the VMs other than SSH ..? i tried virsh vncdisplay , but no output .. regards bala --

Re: [libvirt] [PATCH] qemu: fix crash when mixing sync and async monitor jobs

2011-07-29 Thread Wen Congyang
At 07/29/2011 09:34 PM, Eric Blake write: On 07/29/2011 02:59 AM, Wen Congyang wrote: At 07/29/2011 07:47 AM, Eric Blake Write: Currently, we attempt to run sync job and async job at the same time. It means that the monitor commands for two jobs can be run in any order. In the function

Re: [libvirt] [PATCH] utils: More useful error message for hook script failure

2011-07-29 Thread Osier Yang
于 2011年07月29日 19:48, Eric Blake 写道: On 07/29/2011 04:23 AM, Osier Yang wrote: Commit 3709a386 ported hooks codes to new command execution API, together with the useful error message removed. Though we can't get errbuf from the new command execution API anymore, still we can give a more useful

[libvirt] [PATCH] build: avoid non-portable shell in test setup

2011-07-29 Thread Eric Blake
POSIX states that 'a=1; a=2 b=$a command' has unspecified results for the value of $b visible within command. In particular, on BSD, this resulted in PATH not picking up the in-test ssh. * tests/Makefile.am (lv_abs_top_builddir): New macro. (path_add, TESTS_ENVIRONMENT): Use it to avoid

Re: [libvirt] [PATCH] tests: Don't use bash if we don't have to

2011-07-29 Thread Matthias Bolte
2011/7/29 Eric Blake ebl...@redhat.com: On 07/29/2011 06:19 AM, Matthias Bolte wrote: This tested failed on FreeBSD because it was using bash, that might not be installed. ---  tests/int-overflow |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/int-overflow

Re: [libvirt] [PATCH] build: avoid non-portable shell in test setup

2011-07-29 Thread Matthias Bolte
2011/7/29 Eric Blake ebl...@redhat.com: POSIX states that 'a=1; a=2 b=$a command' has unspecified results for the value of $b visible within command.  In particular, on BSD, this resulted in PATH not picking up the in-test ssh. * tests/Makefile.am (lv_abs_top_builddir): New macro. (path_add,

Re: [libvirt] How to connect to the running VM

2011-07-29 Thread Dave Allan
On Fri, Jul 29, 2011 at 05:06:06PM +0530, bala suru wrote: Hi, I have deployed some VM on to the KVM-qemu and installed libvirtd .. I could see the VM running by command virsh list . but how to login to the VMs other than SSH ..? i tried virsh vncdisplay , but no output .. virt-viewer

Re: [libvirt] How to connect to the running VM

2011-07-29 Thread Zdenek Styblik
On 07/29/11 17:32, bala suru wrote: Hi, Thanks for the information i'll try this .. How to create a kvm image from machine which already has the kvm setup and virt-manager ..? So far I was using the images created for KVM for the VM .. now I want to create a kvm image my self from

Re: [libvirt] How to connect to the running VM

2011-07-29 Thread Osier Yang
? 2011?07?29? 19:36, bala suru ??: Hi, I have deployed some VM on to the KVM-qemu and installed libvirtd .. I could see the VM running by command virsh list . but how to login to the VMs other than SSH ..? snip i tried virsh vncdisplay , but no output .. /snip This means you don't configure

[libvirt] [PATCHv4 2/2] save: generate idempotent inactive xml for running domain

2011-07-29 Thread Eric Blake
Originally noticed by comparing the xml generated by virDomainSave with the xml produced by reparsing and redumping that xml, but I also did an audit of every last use of VIR_DOMAIN_XML_INACTIVE in domain_conf.c to ensure that no other discrepancies exist. * src/conf/domain_conf.c

[libvirt] [PATCHv4 1/2] conf: make 'vnet' prefix a macro

2011-07-29 Thread Eric Blake
Using a macro ensures that all the code is looking for the same prefix. * src/conf/domain_conf.h (VIR_NET_GENERATED_PREFIX): New macro. * src/conf/domain_conf.c (virDomainNetDefParseXML): Use it. * src/uml/uml_conf.c (umlConnectTapDevice): Likewise. * src/qemu/qemu_command.c

Re: [libvirt] [RFC: PATCHv3 3/3] save: generate idempotent inactive xml for running domain

2011-07-29 Thread Eric Blake
On 07/28/2011 12:59 PM, Laine Stump wrote: On 07/22/2011 12:21 AM, Eric Blake wrote: Noticed by comparing the xml generated by virDomainSave with the xml produced by reparsing and redumping that xml. * src/conf/domain_conf.c (virDomainDeviceInfoIsSet): Add parameter, and update all callers.

Re: [libvirt] How to connect to the running VM

2011-07-29 Thread Dave Allan
On Fri, Jul 29, 2011 at 10:36:48AM -0700, bala suru wrote: Hi, Can you suggest any links /docs which explain the kvm image creation steps ..? Replying on list for the benefit of everyone. I don't know what you're referring to when you say kvm image. Are you asking how to install the OS in

Re: [libvirt] [PATCH] build: avoid non-portable shell in test setup

2011-07-29 Thread Eric Blake
On 07/29/2011 10:07 AM, Matthias Bolte wrote: 2011/7/29 Eric Blakeebl...@redhat.com: POSIX states that 'a=1; a=2 b=$a command' has unspecified results for the value of $b visible within command. In particular, on BSD, this resulted in PATH not picking up the in-test ssh. * tests/Makefile.am

Re: [libvirt] Start of freeze for libvirt-0.9.4 and availability of rc1

2011-07-29 Thread Matthias Bolte
2011/7/26 Jason Helfman jhelf...@e-e.com: On Tue, Jul 26, 2011 at 12:26:20PM -0600, Eric Blake thus spake: On 07/26/2011 12:16 PM, Jason Helfman wrote: remote.c: At top level: remote.c:409: error: negative width in bit-field '_gl_verify_error_if_negative' remote.c: In function

[libvirt] [PATCH] build: fix include path for cygwin

2011-07-29 Thread Eric Blake
Without this, cygwin failed to compile: In file included from ../src/rpc/virnetmessage.h:24, from ../src/rpc/virnetclient.h:27, from remote/remote_driver.c:31: ../src/rpc/virnetprotocol.h:9:21: error: rpc/rpc.h: No such file or directory With that fixed,

[libvirt] [PATCH] network: don't forward DNS requests from isolated networks

2011-07-29 Thread Laine Stump
This is in response to: https://bugzilla.redhat.com/show_bug.cgi?id=723862 which points out that a guest on an isolated network could potentially exploit the DNS forwarding provided by dnsmasq to create a communication channel to the outside. This patch eliminates that possibility by adding

Re: [libvirt] [PATCH] network: don't forward DNS requests from isolated networks

2011-07-29 Thread Eric Blake
On 07/29/2011 02:35 PM, Laine Stump wrote: This is in response to: https://bugzilla.redhat.com/show_bug.cgi?id=723862 which points out that a guest on an isolated network could potentially exploit the DNS forwarding provided by dnsmasq to create a communication channel to the outside. This

Re: [libvirt] [PATCHv4 1/2] conf: make 'vnet' prefix a macro

2011-07-29 Thread Laine Stump
On 07/29/2011 01:15 PM, Eric Blake wrote: Using a macro ensures that all the code is looking for the same prefix. * src/conf/domain_conf.h (VIR_NET_GENERATED_PREFIX): New macro. * src/conf/domain_conf.c (virDomainNetDefParseXML): Use it. * src/uml/uml_conf.c (umlConnectTapDevice): Likewise. *

Re: [libvirt] [PATCHv4 2/2] save: generate idempotent inactive xml for running domain

2011-07-29 Thread Laine Stump
On 07/29/2011 01:15 PM, Eric Blake wrote: Originally noticed by comparing the xml generated by virDomainSave with the xml produced by reparsing and redumping that xml, but I also did an audit of every last use of VIR_DOMAIN_XML_INACTIVE in domain_conf.c to ensure that no other discrepancies

Re: [libvirt] [PATCH] Fix bug #611823 prohibit pools with duplicate storage

2011-07-29 Thread Adam Litke
Hi Lei Li, This patch doesn't seem to apply for me. Please recreate the patch against an up to date git repository. Make sure to test that you can apply the patch yourself. On 07/28/2011 11:34 PM, Lei Li wrote: To make sure the unique storage pool defined and created from different directory

Re: [libvirt] [PATCH] network: don't forward DNS requests from isolated networks

2011-07-29 Thread Laine Stump
On 07/29/2011 04:43 PM, Eric Blake wrote: On 07/29/2011 02:35 PM, Laine Stump wrote: This is in response to: https://bugzilla.redhat.com/show_bug.cgi?id=723862 which points out that a guest on an isolated network could potentially exploit the DNS forwarding provided by dnsmasq to create a

Re: [libvirt] [PATCHv3] qemu: fix crash when mixing sync and async monitor jobs

2011-07-29 Thread Eric Blake
On 07/29/2011 03:32 PM, Eric Blake wrote: Currently, we attempt to run sync job and async job at the same time. It means that the monitor commands for two jobs can be run in any order. v3: incorporate Wen's feedback - in particular, virProcessStartCPUs now checks for return type, restarting

Re: [libvirt] [PATCHv4 2/2] save: generate idempotent inactive xml for running domain

2011-07-29 Thread Eric Blake
On 07/29/2011 02:56 PM, Laine Stump wrote: On 07/29/2011 01:15 PM, Eric Blake wrote: Originally noticed by comparing the xml generated by virDomainSave with the xml produced by reparsing and redumping that xml, but I also did an audit of every last use of VIR_DOMAIN_XML_INACTIVE in

Re: [libvirt] [PATCHv3] qemu: fix crash when mixing sync and async monitor jobs

2011-07-29 Thread Wen Congyang
At 07/30/2011 05:37 AM, Eric Blake write: On 07/29/2011 03:32 PM, Eric Blake wrote: Currently, we attempt to run sync job and async job at the same time. It means that the monitor commands for two jobs can be run in any order. v3: incorporate Wen's feedback - in particular,