The patch that fixes SIGTERM handling with -no-shutdown was taken into
0.15.1 stable release of qemu.
---
src/qemu/qemu_capabilities.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 8f16a49..2f55000
Waiting for qemu-kvm cleaning up the PCI bar(s) mapping with long time
while the device is not managed is just waste of time.
---
src/qemu/qemu_hostdev.c | 15 ---
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c
index
From: Daniel P. Berrange berra...@redhat.com
I wrote this months ago and thought I had already submitted/merged
it. Obviously not. I need this for the virt sandbox tools asap.
We recently added support for VIR_DOMAIN_START_AUTODESTROY and
an impl to the QEMU driver. It is very desirable to
On 17.10.2011 12:18, Jiri Denemark wrote:
The patch that fixes SIGTERM handling with -no-shutdown was taken into
0.15.1 stable release of qemu.
---
src/qemu/qemu_capabilities.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c
于 2011年10月17日 09:40, Osier Yang 写道:
于 2011年10月15日 02:53, Eric Blake 写道:
On 10/12/2011 10:05 PM, Osier Yang wrote:
When failing on starting a domain, it tries to reattach all the PCI
devices defined in the domain conf, regardless of whether the devices
are still used by other domain. This will
gobject signals are generally not namespaced this way, removing
this prefix makes things look a bit nicer.
---
libvirt-gobject/libvirt-gobject-connection.c | 50 +-
libvirt-gobject/libvirt-gobject-domain.c | 10 +++---
libvirt-gobject/libvirt-gobject-manager.c|
On 09/30/2011 12:22 AM, Eric Blake wrote:
Although the compiler wasn't complaining (since it was the pointer,
rather than what was being pointed to, that was actually const), it
looks quite suspicious to call a function with an argument labeled
const when the nature of the pointer (virBufferPtr)
On Mon, Oct 17, 2011 at 01:32:58PM +0200, Christophe Fergeau wrote:
gobject signals are generally not namespaced this way, removing
this prefix makes things look a bit nicer.
---
libvirt-gobject/libvirt-gobject-connection.c | 50
+-
Quoting Eli Qiao (ta...@linux.vnet.ibm.com):
hi Serge :
Thanks for taking a look.
I checked the code , only in lxc_controller.c call virFileOpenTtyAt().
I didn't test the path, but my suggestion is that modify the
utility function in /src/util/util.c instead of adding a new
Hello,
I just encountered a situation, where a KVM instance was reported as no
state in virsh. This broke some code of mine, which was
using lookupByUUID() to lookup several VMs. The Python code did raise a
libvirt.libvirtError('virDomainLookupByUUID() failed',), where all
get_error_*()
I rebased this series for current head. To fetch this series from my
repo conviniently:
git checkout -b console_corruption 1afcfbdda0cac112faa61f74ec943e46aa43f2f5
git pull git://aeon.pipo.sk/libvirt.git console_corruption
Peter
--
libvir-list mailing list
libvir-list@redhat.com
On 10/17/2011 07:26 AM, Serge E. Hallyn wrote:
Quoting Eli Qiao (ta...@linux.vnet.ibm.com):
hi Serge :
Thanks for taking a look.
I checked the code , only in lxc_controller.c call virFileOpenTtyAt().
I didn't test the path, but my suggestion is that modify the
utility function in
For better handling of the sorting of chains introduce an internally used
priority. Use a lookup table to store the priorities. For now their actual
values do not matter just that the values cause the chains to be properly
sorted through changes in the following patches.
---
On 10/17/2011 05:20 AM, Hai Dong Li wrote:
On 09/30/2011 12:22 AM, Eric Blake wrote:
Although the compiler wasn't complaining (since it was the pointer,
rather than what was being pointed to, that was actually const), it
looks quite suspicious to call a function with an argument labeled
const
Use scripts for the renaming and cleaning up of chains. This allows us to get
rid of some of the code that is only capable of renaming and removing chains
whose names are hardcoded.
A shell function 'collect_chains' is introduced that is given the name
of an ebtables chain and then recursively
Use the name of the chain rather than its type index (enum).
This pushes the later enablement of chains with user-given names
into the XML parser. For now we still only allow those names that
are well known ('root', 'arp', 'rarp', 'ipv4' and 'ipv6').
---
src/conf/nwfilter_conf.c
Add a function to the virHashTable for getting an array of the hash table's
keys and have the keys optionally sorted.
---
src/libvirt_private.syms |3 +
src/util/hash.c | 98 +++
src/util/hash.h | 14 ++
3 files changed,
Use the previously introduced chain priorities to sort the chains for access
from the 'root' table and have them created in the proper order. This gets
rid of a lot of code that was previously creating the chains in a more
hardcoded way.
To detmerine what protocol a filter is used for evaluation
The following series of patches re-does some of the inner workings
of nwfilters with the goal to enable users to write filters that have other
than the system-known chains supported right now ('root','arp','rarp','ipv4'
and 'ipv6'). Ideally users should be able to provide a chain name in the
Only as an example show how to add a new 'system filter' called 'arpmac'.
Using 'prefix matching' introduced in previous patches, it generates
a table 'arpmac' that will be jumped into using '-p arp'.
The below patch adds arpmac with a priority of 650, which helps sorting
its entry in the 'root'
Signed-off-by: Philipp Hahn h...@univention.de
---
include/libvirt/virterror.h |2 +-
python/libvirt-override.py |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
index dfbe2bc..a8549b7 100644
---
On 10/17/2011 05:02 PM, Philipp Hahn wrote:
Signed-off-by: Philipp Hahnh...@univention.de
---
include/libvirt/virterror.h |2 +-
python/libvirt-override.py |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
ACK and pushed.
Peter
--
libvir-list mailing list
Hi all,
I meet the following compiler warnings today:
..
CC libvirt_util_la-buf.lo
util/buf.c: In function 'virBufferEscape':
util/buf.c:430: warning: logical '' with non-zero constant will always
evaluate as true [-Wlogical-op]
CC libvirt_util_la-command.lo
..
CC
On 10/17/2011 09:35 AM, Alex Jia wrote:
Hi all,
I meet the following compiler warnings today:
..
CC libvirt_util_la-buf.lo
util/buf.c: In function 'virBufferEscape':
util/buf.c:430: warning: logical '' with non-zero constant will always
evaluate as true [-Wlogical-op]
Which version
On 10/12/2011 03:50 PM, David L Stevens wrote:
This patch changes rules of the form:
if ! addr drop
accept
to:
if addr return
...
drop
The patch adds a mac chain to do a mac address list and separates the arp
chain into separate arpmac and arpip chains
Eric,
# rpm -q gcc
gcc-4.4.6-3.el6.x86_64
Regards,
Alex
- Original Message -
From: Eric Blake ebl...@redhat.com
To: Alex Jia a...@redhat.com
Cc: libvir-list@redhat.com
Sent: Monday, October 17, 2011 11:38:50 PM
Subject: Re: [libvirt] Compiler warnings
On 10/17/2011 09:35 AM, Alex Jia
On 10/12/2011 03:50 PM, David L Stevens wrote:
This patch simplifies the table rules by setting the protocol chains
policy to be DROP and removes the explicit -j DROP entries that the
protocol rules had previously. It also makes no-other-rarp-traffic.xml
obsolete.
I agree with Daniel's
On 10/17/2011 09:54 AM, Jiri Denemark wrote:
probes.h is generated in build directory; setting a dependency on
probes.h from source directory doesn't work well in VPATH builds. Caused
by commit 1afcfbdda0cac112faa61f74ec943e46aa43f2f5
---
src/Makefile.am |2 +-
1 files changed, 1
From: Alex Jia a...@redhat.com
* src/qemu/qemu_hostdev.c: function 'pciDeviceListFind' probably explicitly
returns null, however, the function 'pciDeviceSetUsedBy' directly uses it
without any judgement.
Signed-off-by: Alex Jia a...@redhat.com
---
src/qemu/qemu_hostdev.c |5 ++---
1
On 10/17/2011 09:51 AM, Alex Jia wrote:
Eric,
# rpm -q gcc
gcc-4.4.6-3.el6.x86_64
I'm still not seeing it on my RHEL 6 host. What version of glibc (in
case it's a header problem), and is this the latest libvirt.git or a
particular source rpm rebuild? What's on line 430 of the file in
On 10/12/2011 03:50 PM, David L Stevens wrote:
This patch adds the internal capability to add rules to existing
chains instead of using temporary chains and to generate placeholders for
chains that are referenced without generating a rule for them immediately.
Finally, it includes
Eric,
It's latest libvirt upstream, current commit id is commit 0a71c79.
# rpm -q glibc
glibc-2.12-1.42.el6.x86_64
399 void
400 virBufferEscape(const virBufferPtr buf,
401 const char *toescape,
402 const char *format,
403 const char *str)
404 {
On 10/17/2011 10:09 AM, a...@redhat.com wrote:
From: Alex Jiaa...@redhat.com
* src/qemu/qemu_hostdev.c: function 'pciDeviceListFind' probably explicitly
returns null, however, the function 'pciDeviceSetUsedBy' directly uses it
without any judgement.
Signed-off-by: Alex Jiaa...@redhat.com
The referenced page does not exist, but locking.html has a section about
sanlock.
Signed-off-by: Philipp Hahn h...@univention.de
---
tools/virt-sanlock-cleanup.in |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/virt-sanlock-cleanup.in
On 10/12/2011 03:50 PM, David L Stevens wrote:
This patch adds a function that applies or deletes filter rules to existing
chains. Rules referencing the given variable are instantiated with the given
value, or optionally deleted. For example, passing variable IP with different
values will
- Original Message -
From: Eric Blake ebl...@redhat.com
False positive. Just a few lines earlier, in loop 4, we guaranteed that
dev was added to driver-activePciHostdevs, therefore, activeDev cannot
be NULL here.
That said, we could probably simplify things by consolidating loop 5 and
On 10/12/2011 03:50 PM, David L Stevens wrote:
This patch adds support for saving DHCP snooping leases to an on-disk
file and restoring saved leases that are still active on restart.
Signed-off-by: David L Stevensdlstev...@us.ibm.com
---
src/nwfilter/nwfilter_dhcpsnoop.c | 370
On 10/17/2011 11:03 AM, Eric Blake wrote:
On 10/17/2011 10:17 AM, Alex Jia wrote:
Eric,
It's latest libvirt upstream, current commit id is commit 0a71c79.
# rpm -q glibc
glibc-2.12-1.42.el6.x86_64
430 if (strchr(toescape, *cur))
CC libvirt_util_la-buf.lo
util/buf.c: In function
On 10/17/2011 10:17 AM, Alex Jia wrote:
Eric,
It's latest libvirt upstream, current commit id is commit 0a71c79.
# rpm -q glibc
glibc-2.12-1.42.el6.x86_64
430 if (strchr(toescape, *cur))
CC libvirt_util_la-buf.lo
util/buf.c: In function 'virBufferEscape':
util/buf.c:430:
Stefan Berger stef...@linux.vnet.ibm.com wrote on 10/17/2011 08:50:14
AM:
I agree with Daniel's previous comments that this could introduce
compatibility problems. It would be best not to change it or if really
need be later on introduce an XML attribute for a chain that allows to
choose
Stefan Berger stef...@linux.vnet.ibm.com wrote on 10/17/2011 09:07:12
AM:
On 10/12/2011 03:50 PM, David L Stevens wrote:
This patch adds the internal capability to add rules to existing
chains instead of using temporary chains and to generate placeholders
for
chains that are
On 10/17/2011 01:23 PM, David Stevens wrote:
Stefan Bergerstef...@linux.vnet.ibm.com wrote on 10/17/2011 09:07:12
AM:
On 10/12/2011 03:50 PM, David L Stevens wrote:
This patch adds the internal capability to add rules to existing
chains instead of using temporary chains and to generate
On 10/17/2011 04:58 AM, Osier Yang wrote:
Waiting for qemu-kvm cleaning up the PCI bar(s) mapping with long time
while the device is not managed is just waste of time.
---
src/qemu/qemu_hostdev.c | 15 ---
1 files changed, 8 insertions(+), 7 deletions(-)
ACK.
--
Eric Blake
On 10/17/2011 01:04 PM, David Stevens wrote:
Stefan Bergerstef...@linux.vnet.ibm.com wrote on 10/17/2011 08:50:14
AM:
I agree with Daniel's previous comments that this could introduce
compatibility problems. It would be best not to change it or if really
need be later on introduce an XML
On 10/17/2011 04:44 AM, Osier Yang wrote:
After thinking a while, even we set the used_by during domains reloading,
the other attrs (dev-unbind_from_stub, dev-reprobe, dev-remove_slot)
of the PCI dev still will be lost. We can't known what values should be
for these attrs as generally they are
Stefan Berger stef...@linux.vnet.ibm.com wrote on 10/17/2011 09:17:21
AM:
+int
+virNWFilterChangeVar(virConnectPtr conn,
+if (virNWFilterHashTablePut(vars, var, value, 1)) {
+virNWFilterReportError(VIR_ERR_INTERNAL_ERROR, _(Cound not
add
+
On 10/15/2011 04:47 PM, Matthias Bolte wrote:
2011/10/8 Eric Blakeebl...@redhat.com:
Relatively straight-forward filtering.
* src/esx/esx_vi.h (esxVI_GetNumberOfSnapshotTrees)
(esxVI_GetSnapshotTreeNames): Add parameter.
* src/esx/esx_vi.c (esxVI_GetNumberOfSnapshotTrees)
Stefan Berger stef...@linux.vnet.ibm.com wrote on 10/17/2011 10:31:29
AM:
was not.
Yes, then I understood this correctly. See the other mails regarding the
problems I am seeing with it. If there was a way to figure out at what
position to insert a rule into an existing chain, i.e. at
On 10/17/2011 04:32 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
I wrote this months ago and thought I had already submitted/merged
it. Obviously not. I need this for the virt sandbox tools asap.
We recently added support for VIR_DOMAIN_START_AUTODESTROY and
an
On 10/17/2011 05:07 AM, Osier Yang wrote:
This patch fixes two problems:
1) The device will be reattached to host even if it's not
managed, as there is a pciDeviceSetManaged.
2) The device won't be reattached to host with original
driver properly. As it doesn't honor
On 10/17/2011 01:58 PM, David Stevens wrote:
Stefan Bergerstef...@linux.vnet.ibm.com wrote on 10/17/2011 10:31:29
AM:
was not.
Yes, then I understood this correctly. See the other mails regarding the
problems I am seeing with it. If there was a way to figure out at what
position to insert a
On 10/12/2011 03:50 PM, David L Stevens wrote:
+
+#includeconfig.h
+
+#ifdef HAVE_LIBPCAP
+#includepcap.h
+#endif
HAVE_LIBPCAP also has to be handled in the parts that actually call the
pcap library API and provide a way of failing if libpcap is not available.
--
libvir-list mailing list
The glibc ones cannot handle ptys opened in a devpts not mounted at
/dev/pts.
Changelog:
Oct 17: Per Eli Qiao, use VIR_ALLOC_N when appropriate, make
sure to check return values, and follow coding style
convention.
Change lxcGetTtyGid() to return -1 on error,
Adam Litke wrote:
On Mon, Oct 03, 2011 at 10:46:18PM -0600, Jim Fehlig wrote:
Adam Litke wrote:
Hi Jim. I was testing this and found that I could not boot from the sata
disks
I defined. When I switch them back to ide, they can be booted just fine.
Perhaps something is missing
On 09/28/2011 04:43 PM, Jim Fehlig wrote:
Tested with multiple AHCI controllers and multiple disks attached
to a controller. E.g.,
+++ b/src/qemu/qemu_capabilities.c
@@ -139,6 +139,7 @@ VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST,
no-shutdown,
cache-unsafe, /* 75 */
On 10/17/2011 01:04 PM, Serge E. Hallyn wrote:
The glibc ones cannot handle ptys opened in a devpts not mounted at
/dev/pts.
Changelog:
Oct 17: Per Eli Qiao, use VIR_ALLOC_N when appropriate, make
sure to check return values, and follow coding style
convention.
Stefan Berger stef...@linux.vnet.ibm.com wrote on 10/17/2011 10:29:08
AM:
Yes, '_at_the_end_', that's what I thought. I am not sure whether this
particular requirement is the best way to proceed since obviously you
cannot have any other rules with lesser priority after the ones doing
the
Quoting Eric Blake (ebl...@redhat.com):
On 10/17/2011 01:04 PM, Serge E. Hallyn wrote:
The glibc ones cannot handle ptys opened in a devpts not mounted at
/dev/pts.
Changelog:
Oct 17: Per Eli Qiao, use VIR_ALLOC_N when appropriate, make
sure to check return values, and follow
On 10/17/2011 03:29 PM, Serge E. Hallyn wrote:
that matter, the whole point of the mount(devpts,...,gid=5)
designation is that the new pty will be owned by gid 5, without
needing to fchown() it. Are there kernels that are new enough to
support newinstance mounting, yet old enough to not honor
Eric Blake wrote:
On 09/28/2011 04:43 PM, Jim Fehlig wrote:
Tested with multiple AHCI controllers and multiple disks attached
to a controller. E.g.,
+++ b/src/qemu/qemu_capabilities.c
@@ -139,6 +139,7 @@ VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST,
no-shutdown,
On 10/17/2011 05:22 PM, David Stevens wrote:
Stefan Bergerstef...@linux.vnet.ibm.com wrote on 10/17/2011 10:29:08
AM:
Yes, '_at_the_end_', that's what I thought. I am not sure whether this
particular requirement is the best way to proceed since obviously you
cannot have any other rules with
On 10/12/2011 03:50 PM, David L Stevens wrote:
This patch adds support for multiple static IP addresses in a
comma-separated list. For example:
interface type='network'
filterref filter='clean-traffic'
parameter name='ip_learning' value='none'/
parameter
于 2011年10月18日 01:47, Eric Blake 写道:
On 10/17/2011 04:58 AM, Osier Yang wrote:
Waiting for qemu-kvm cleaning up the PCI bar(s) mapping with long time
while the device is not managed is just waste of time.
---
src/qemu/qemu_hostdev.c | 15 ---
1 files changed, 8 insertions(+), 7
At 10/18/2011 01:04 AM, Eric Blake Write:
On 10/17/2011 11:03 AM, Eric Blake wrote:
On 10/17/2011 10:17 AM, Alex Jia wrote:
Eric,
It's latest libvirt upstream, current commit id is commit 0a71c79.
# rpm -q glibc
glibc-2.12-1.42.el6.x86_64
430 if (strchr(toescape, *cur))
CC
On 10/17/2011 10:36 PM, Eric Blake wrote:
On 10/17/2011 05:20 AM, Hai Dong Li wrote:
On 09/30/2011 12:22 AM, Eric Blake wrote:
Although the compiler wasn't complaining (since it was the pointer,
rather than what was being pointed to, that was actually const), it
looks quite suspicious to call
At 10/18/2011 01:03 AM, Eric Blake Write:
On 10/17/2011 10:17 AM, Alex Jia wrote:
Eric,
It's latest libvirt upstream, current commit id is commit 0a71c79.
# rpm -q glibc
glibc-2.12-1.42.el6.x86_64
430 if (strchr(toescape, *cur))
CC libvirt_util_la-buf.lo
util/buf.c:
At 10/18/2011 09:32 AM, Wen Congyang Write:
At 10/18/2011 01:04 AM, Eric Blake Write:
On 10/17/2011 11:03 AM, Eric Blake wrote:
On 10/17/2011 10:17 AM, Alex Jia wrote:
Eric,
It's latest libvirt upstream, current commit id is commit 0a71c79.
# rpm -q glibc
glibc-2.12-1.42.el6.x86_64
430
On 10/18/2011 10:09 AM, Wen Congyang wrote:
At 10/18/2011 09:32 AM, Wen Congyang Write:
At 10/18/2011 01:04 AM, Eric Blake Write:
On 10/17/2011 11:03 AM, Eric Blake wrote:
On 10/17/2011 10:17 AM, Alex Jia wrote:
Eric,
It's latest libvirt upstream, current commit id is commit 0a71c79.
# rpm
compile error:
../src/.libs/libvirt_driver_qemu.a(libvirt_driver_qemu_la-qemu_hostdev.o): In
function `qemuPrepareHostdevPCIDevices':
/home/soulxu/data/work-code/libvirt/src/qemu/qemu_hostdev.c:183: undefined
reference to `pciDeviceListFind'
On 09/30/2011 12:22 AM, Eric Blake wrote:
I had some temporary test failures while working on virbuf
improvements in later patches, with output that looked like:
Expected []
Actual []
which is pretty hard to figure out. Adding an Offset designation
made it much easier to find which particular
At 10/18/2011 10:46 AM, Xu He Jie Write:
compile error:
../src/.libs/libvirt_driver_qemu.a(libvirt_driver_qemu_la-qemu_hostdev.o): In
function `qemuPrepareHostdevPCIDevices':
/home/soulxu/data/work-code/libvirt/src/qemu/qemu_hostdev.c:183: undefined
reference to `pciDeviceListFind'
于 2011年10月18日 11:12, Wen Congyang 写道:
At 10/18/2011 10:46 AM, Xu He Jie Write:
compile error:
../src/.libs/libvirt_driver_qemu.a(libvirt_driver_qemu_la-qemu_hostdev.o): In
function `qemuPrepareHostdevPCIDevices':
/home/soulxu/data/work-code/libvirt/src/qemu/qemu_hostdev.c:183: undefined
This patch fixes two problems:
1) The device will be reattached to host even if it's not
managed, as there is a pciDeviceSetManaged.
2) The device won't be reattached to host with original
driver properly. As it doesn't honor the device original
properties which are
On 09/30/2011 12:22 AM, Eric Blake wrote:
The next patch wants to add some sanity checking, which would
be a different error than ENOMEM. Many existing callers blindly
report OOM failure if virBuf reports an error, and this will be
wrong in the (unlikely) case that they actually had a usage
74 matches
Mail list logo
