Re: [libvirt] [test-API][PATCH 2/3] clean keyword update in libvirt-test-api, mapper, proxy part

2011-11-10 Thread Guannan Ren
On 11/10/2011 11:25 AM, Guannan Sun wrote: NACK - Original Message - From: Guannan Reng...@redhat.com To: libvir-list@redhat.com Sent: Wednesday, November 9, 2011 12:38:38 PM Subject: [libvirt] [test-API][PATCH 2/3] clean keyword update in libvirt-test-api, mapper, proxy part ---

Re: [libvirt] nwfilter - limit VM traffic to specific mac address

2011-11-10 Thread Shahar Havivi
On 09.11.11 10:49, Stefan Berger wrote: On 11/09/2011 09:38 AM, Shahar Havivi wrote: On 09.11.11 09:20, Stefan Berger wrote: On 11/09/2011 07:44 AM, Shahar Havivi wrote: On 09.11.11 06:44, Stefan Berger wrote: On 11/09/2011 04:01 AM, Shahar Havivi wrote: On 08.11.11 16:34, Stefan Berger

Re: [libvirt] nwfilter - limit VM traffic to specific mac address

2011-11-10 Thread Shahar Havivi
On 10.11.11 11:30, Shahar Havivi wrote: On 09.11.11 10:49, Stefan Berger wrote: On 11/09/2011 09:38 AM, Shahar Havivi wrote: On 09.11.11 09:20, Stefan Berger wrote: On 11/09/2011 07:44 AM, Shahar Havivi wrote: On 09.11.11 06:44, Stefan Berger wrote: On 11/09/2011 04:01 AM, Shahar Havivi

Re: [libvirt] [PATCH] fix crash when starting network

2011-11-10 Thread lvroyce
tested-by: Wen Ruo Lvlvro...@linux.vnet.ibm.com tested 1.net-start cmd with bridge mac specified (failed) 2.attach-device cmd with a hot plug nic(ok) My network is as below: network namedefault/name uuid361441af-e1f0-472d-a503-dfcbbefa03fb/uuid forward mode='nat'/ bridge name='virbr0' stp='on'

Re: [libvirt] nwfilter - limit VM traffic to specific mac address

2011-11-10 Thread Stefan Berger
On 11/10/2011 05:21 AM, Shahar Havivi wrote: On 10.11.11 11:30, Shahar Havivi wrote: On 09.11.11 10:49, Stefan Berger wrote: On 11/09/2011 09:38 AM, Shahar Havivi wrote: On 09.11.11 09:20, Stefan Berger wrote: On 11/09/2011 07:44 AM, Shahar Havivi wrote: On 09.11.11 06:44, Stefan Berger

Re: [libvirt] nwfilter - limit VM traffic to specific mac address

2011-11-10 Thread Shahar Havivi
On 10.11.11 06:25, Stefan Berger wrote: On 11/10/2011 05:21 AM, Shahar Havivi wrote: On 10.11.11 11:30, Shahar Havivi wrote: On 09.11.11 10:49, Stefan Berger wrote: On 11/09/2011 09:38 AM, Shahar Havivi wrote: On 09.11.11 09:20, Stefan Berger wrote: On 11/09/2011 07:44 AM, Shahar Havivi

[libvirt] [PATCH 3/4] Allow creation of plain macvlan devices

2011-11-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update virNetDevMacVLanCreateWithVPortProfile to allow creation of plain macvlan devices, as well as macvtap devices. The former is useful for LXC containers * src/qemu/qemu_command.c: Explicitly request a macvtap device * src/util/virnetdevmacvlan.c,

[libvirt] [PATCH 4/4] Add support for interfaces with type=direct to LXC

2011-11-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Support creation of macvlan devices for LXC containers. Do not allow setting of network filters, bandwidth controls or vport profiles due to the complication that there is no host side visible device to work with. * src/lxc/lxc_driver.c: Support

[libvirt] [PATCH] Add libvirt confdir to files section in mingw32 spec

2011-11-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Pushed under the trivial rule - this fix pulled back from Fedora * mingw32-libvirt.spec.in: Ensure we own the confdir --- mingw32-libvirt.spec.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/mingw32-libvirt.spec.in

[libvirt] [PATCH 2/4] Refactor LXC network setup to allow future enhancements

2011-11-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The current lxcSetupInterfaces() method directly performs setup of the bridge devices. Since it will shortly need to also create macvlan devices, move the bridge related code into a separate method * src/lxc/lxc_driver.c: Split lxcSetupInterfaces() to

[libvirt] [PATCH 1/4] Add missing 'const' annotations for internal domain conf helpers

2011-11-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virDomainNetGetActualBridgeName and virDomainNetGetActualDirectDev methods both return strings that point to data in the virDomainDefPtr struct, and should therefore not be freed. The return values should thus be 'const char *' not 'char *'. *

[libvirt] [PATCH 0/4] Support macvlan devices for LXC containers

2011-11-10 Thread Daniel P. Berrange
This series does the bare minimum required to support the network inteface type=direct for LXC containers, using macvlan devices as the implementation. There is a slight complication though... For bridged container NICs we create a veth pair of devices. One of the devices lives host side, and is

[libvirt] [PATCH] Disable numactl on ARM architectures too

2011-11-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Pushed under trivial rule - a backport from the Fedora spec * libvirt.spec.in: Disable numactl on ARM --- libvirt.spec.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index

[libvirt] Problem with libvirt daemon

2011-11-10 Thread Wouter - Iamotor
Hello, I have a problem with the libvirt daemon. I have a little php script which should connect with libvirt, but it won't. When I try to start the libvirt daemon I get this error (using the command libvirtd --listen): 2011-11-09 19:35:18.095: 3560: info : libvirt version: 0.9.7

Re: [libvirt] [PATCH 2/4] Refactor LXC network setup to allow future enhancements

2011-11-10 Thread Stefan Berger
On 11/10/2011 06:28 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The current lxcSetupInterfaces() method directly performs setup of the bridge devices. Since it will shortly need to also create macvlan devices, move the bridge related code into a separate method *

Re: [libvirt] [PATCH 1/4] Add missing 'const' annotations for internal domain conf helpers

2011-11-10 Thread Stefan Berger
On 11/10/2011 06:28 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The virDomainNetGetActualBridgeName and virDomainNetGetActualDirectDev methods both return strings that point to data in the virDomainDefPtr struct, and should therefore not be freed. The return values

Re: [libvirt] [PATCH 3/4] Allow creation of plain macvlan devices

2011-11-10 Thread Stefan Berger
On 11/10/2011 06:28 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Update virNetDevMacVLanCreateWithVPortProfile to allow creation of plain macvlan devices, as well as macvtap devices. The former is useful for LXC containers * src/qemu/qemu_command.c: Explicitly

Re: [libvirt] [PATCH 4/4] Add support for interfaces with type=direct to LXC

2011-11-10 Thread Stefan Berger
On 11/10/2011 06:28 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Support creation of macvlan devices for LXC containers. Do not allow setting of network filters, bandwidth controls or vport profiles due to the complication that there is no host side visible device

Re: [libvirt] Problem with libvirt daemon

2011-11-10 Thread Daniel P. Berrange
On Thu, Nov 10, 2011 at 02:46:42PM +0100, Wouter - Iamotor wrote: Hello, I have a problem with the libvirt daemon. I have a little php script which should connect with libvirt, but it won't. When I try to start the libvirt daemon I get this error (using the command libvirtd

[libvirt] [PATCH 0/5] Support Blkio tune, CPU tune, NUMA, CPU affinity in LXC

2011-11-10 Thread Daniel P. Berrange
The following patch series brings the LXC driver upto parity with the QEMU driver in terms of support for various performance tuning controls -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/5] Refactor initial LXC mem tune / device ACL code

2011-11-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com To make lxcSetContainerResources smaller, pull the mem tune I/O tune, CPU tune, and device ACL setup code out into separate methods * src/lxc/lxc_controller.c: Split up lxcSetContainerResources --- src/lxc/lxc_controller.c | 154

[libvirt] [PATCH 4/5] Add support for CPU quota/period to LXC driver

2011-11-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com * src/lxc/lxc_driver.c: Support changing quota/period for LXC containers * src/lxc/lxc_controller.c: Set initial quota/period at startup --- src/lxc/lxc_controller.c | 18 ++ src/lxc/lxc_driver.c | 459

[libvirt] [PATCH 3/5] Support CPU placement in LXC driver

2011-11-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com While LXC does not have the concept of VCPUS, so we cann't do per-VCPU pCPU placement, we can support the VM level CPU placement. Todo this simply set the CPU affinity of the LXC controller at startup. All child processes will inherit this affinity. *

Re: [libvirt] [PATCH 4/4] Add support for interfaces with type=direct to LXC

2011-11-10 Thread Daniel P. Berrange
On Thu, Nov 10, 2011 at 09:02:41AM -0500, Stefan Berger wrote: On 11/10/2011 06:28 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Support creation of macvlan devices for LXC containers. Do not allow setting of network filters, bandwidth controls or vport profiles

[libvirt] [PATCH 2/5] Support NUMA memory placement for LXC containers

2011-11-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Use numactl to set NUMA memory placement for LXC containers * src/lxc/lxc_controller.c: Support NUMA memory placement --- src/lxc/lxc_controller.c | 111 ++ 1 files changed, 111 insertions(+), 0

[libvirt] [PATCH 5/5] Add support for blkio tuning of LXC containers

2011-11-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com * src/lxc/lxc_controller.c: Refactor setting of initial blkio tuning parameters * src/lxc/lxc_driver.c: Enable live change of blkio tuning --- src/lxc/lxc_driver.c | 283 ++ 1 files changed, 283

Re: [libvirt] Problem with libvirt daemon

2011-11-10 Thread Wouter - Iamotor
Hello, My bad, I thought it said that it was running but it that the daemon wasn't doing anything. Because when I try to run this php script: ?php $uri=qemu+tcp:///system; $credentials=Array(VIR_CRED_AUTHNAME=team7,VIR_CRED_PASSPHRASE=password); echo (Connecting to libvirt (URI:$uri)\n);

[libvirt] qemu: Remove code instantiating filters on direct interfaces

2011-11-10 Thread Stefan Berger
Remove code that instantiates network filters on direct type of interfaces. The parser already does not accept filters on those type of interfaces. --- src/qemu/qemu_command.c | 26 +- src/qemu/qemu_command.h |1 - src/qemu/qemu_hotplug.c |2 +- 3 files changed,

Re: [libvirt] [PATCH 4/4] Add support for interfaces with type=direct to LXC

2011-11-10 Thread Stefan Berger
On 11/10/2011 09:32 AM, Daniel P. Berrange wrote: On Thu, Nov 10, 2011 at 09:02:41AM -0500, Stefan Berger wrote: On 11/10/2011 06:28 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Support creation of macvlan devices for LXC containers. Do not allow setting of

Re: [libvirt] qemu: Remove code instantiating filters on direct interfaces

2011-11-10 Thread Daniel P. Berrange
On Thu, Nov 10, 2011 at 10:12:01AM -0500, Stefan Berger wrote: Remove code that instantiates network filters on direct type of interfaces. The parser already does not accept filters on those type of interfaces. --- src/qemu/qemu_command.c | 26 +-

Re: [libvirt] [PATCH 1/8] Add new API virDomain{Set, Get}BlockIoTune

2011-11-10 Thread Eric Blake
On 11/09/2011 11:11 PM, Xu He Jie wrote: +++ b/include/libvirt/libvirt.h.in @@ -1640,6 +1640,32 @@ int virDomainBlockJobSetSpeed(virDomainPtr dom, const char *path, int virDomainBlockPull(virDomainPtr dom, const char *path, unsigned long bandwidth, unsigned int flags); +/* + * Block I/O

Re: [libvirt] qemu: Remove code instantiating filters on direct interfaces

2011-11-10 Thread Stefan Berger
On 11/10/2011 10:14 AM, Daniel P. Berrange wrote: On Thu, Nov 10, 2011 at 10:12:01AM -0500, Stefan Berger wrote: Remove code that instantiates network filters on direct type of interfaces. The parser already does not accept filters on those type of interfaces. --- src/qemu/qemu_command.c |

Re: [libvirt] 0.9.7 virsh console regression?

2011-11-10 Thread Dave Allan
On Wed, Nov 09, 2011 at 06:26:41PM -0500, Albert W. Hopkins wrote: Hi folks, I have a few headless qemu domains that use serial consoles. Typically i connect to the consoles with # virsh console domain However with 0.9.7 I get Connected to domain gentoo-base

Re: [libvirt] [PATCH 1/8] Add new API virDomain{Set, Get}BlockIoTune

2011-11-10 Thread Adam Litke
On Thu, Nov 10, 2011 at 04:32:51AM +0800, Lei HH Li wrote: This patch add new pulic API virDomainSetBlockIoTune and virDomainGetBlockIoTune. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/libvirt/libvirt.h.in | 26

Re: [libvirt] [PATCH 2/8] Add virDomain{Set, Get}BlockIoTune support to the remote driver

2011-11-10 Thread Adam Litke
Looks good to me. On Thu, Nov 10, 2011 at 04:32:52AM +0800, Lei HH Li wrote: Support Block I/O Throttle setting and query to remote driver. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- daemon/remote.c | 87

Re: [libvirt] Problem with libvirt daemon

2011-11-10 Thread Laine Stump
(Please don't top-post when replying to messages on the list - it makes it more difficult to determine the context of what's being said as the thread gets longer.) On 11/10/2011 09:39 AM, Wouter - Iamotor wrote: Hello, My bad, I thought it said that it was running but it that the daemon

Re: [libvirt] Problem with libvirt daemon

2011-11-10 Thread Laine Stump
On 11/10/2011 09:39 AM, Wouter - Iamotor wrote: Hello, My bad, I thought it said that it was running but it that the daemon wasn't doing anything. Because when I try to run this php script: ?php $uri=qemu+tcp:///system; Instead of that uri, try this one: qemu:///system. And if you want to

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-10 Thread Anthony Liguori
On 11/10/2011 02:55 AM, Avi Kivity wrote: On 11/09/2011 07:35 PM, Anthony Liguori wrote: On 11/09/2011 11:02 AM, Avi Kivity wrote: On 11/09/2011 06:39 PM, Anthony Liguori wrote: Migration with qcow2 is not a supported feature for 1.0. Migration is only supported with raw images using

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-10 Thread Daniel P. Berrange
On Thu, Nov 10, 2011 at 12:27:30PM -0600, Anthony Liguori wrote: What does libvirt actually do in the monitor prior to migration completing on the destination? The least invasive way of doing delayed open of block devices is probably to make -incoming create a monitor and run a main loop

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-10 Thread Anthony Liguori
On 11/10/2011 12:42 PM, Daniel P. Berrange wrote: On Thu, Nov 10, 2011 at 12:27:30PM -0600, Anthony Liguori wrote: What does libvirt actually do in the monitor prior to migration completing on the destination? The least invasive way of doing delayed open of block devices is probably to make

[libvirt] Wiki spam!

2011-11-10 Thread Cole Robinson
The wiki's been spammed, see November 9 for example: http://wiki.libvirt.org/page/Special:Recentchanges virt-manager.org had a similar problem. Any one know any good proactive ways to prevent this? - Cole -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-10 Thread Anthony Liguori
On 11/10/2011 02:06 PM, Daniel P. Berrange wrote: On Thu, Nov 10, 2011 at 01:11:42PM -0600, Anthony Liguori wrote: On 11/10/2011 12:42 PM, Daniel P. Berrange wrote: On Thu, Nov 10, 2011 at 12:27:30PM -0600, Anthony Liguori wrote: What does libvirt actually do in the monitor prior to migration

Re: [libvirt] Wiki spam!

2011-11-10 Thread Daniel P. Berrange
On Thu, Nov 10, 2011 at 02:50:30PM -0500, Cole Robinson wrote: The wiki's been spammed, see November 9 for example: http://wiki.libvirt.org/page/Special:Recentchanges virt-manager.org had a similar problem. Any one know any good proactive ways to prevent this? I have enabled a captcha for

Re: [libvirt] [PATCH 3/8] Implement virDomain{Set, Get}BlockIoTune for the qemu driver

2011-11-10 Thread Adam Litke
On Thu, Nov 10, 2011 at 04:32:53AM +0800, Lei HH Li wrote: This patch implement the blk io throttle setting and getting support to qemu driver. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c | 216

Re: [libvirt] [PATCH 4/8] Support block I/O throtte in XML

2011-11-10 Thread Adam Litke
This looks good to me. On Thu, Nov 10, 2011 at 04:32:54AM +0800, Lei HH Li wrote: Enable block I/O throttle for per-disk in XML. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 101

[libvirt] [libvirt PATCHv5 1/2] add DHCP snooping

2011-11-10 Thread David L Stevens
This patch adds DHCP Snooping support to libvirt. Signed-off-by: David L Stevens dlstev...@us.ibm.com --- docs/formatnwfilter.html.in | 17 + examples/xml/nwfilter/no-ip-spoofing.xml |5 + src/Makefile.am |2 + src/nwfilter/nwfilter_dhcpsnoop.c

Re: [libvirt] Wiki spam!

2011-11-10 Thread Cole Robinson
On 11/10/2011 03:10 PM, Daniel P. Berrange wrote: On Thu, Nov 10, 2011 at 02:50:30PM -0500, Cole Robinson wrote: The wiki's been spammed, see November 9 for example: http://wiki.libvirt.org/page/Special:Recentchanges virt-manager.org had a similar problem. Any one know any good proactive

[libvirt] [libvirt PATCHv5 0/2] add DHCP Snooping support for libvirt

2011-11-10 Thread David L Stevens
These patches add DHCP snooping support to libvirt. The learning method for IP addresses is specified by setting the ip_learning variable to one of any [default] (existing IP learning code), none (static only addresses) or dhcp (DHCP snooping). Differences from v4: - added documentation

[libvirt] [libvirt PATCHv5 2/2] add leasefile support

2011-11-10 Thread David L Stevens
This patch adds support for saving DHCP snooping leases to an on-disk file and restoring saved leases that are still active on restart. Signed-off-by: David L Stevens dlstev...@us.ibm.com --- src/nwfilter/nwfilter_dhcpsnoop.c | 270 + 1 files changed,

[libvirt] [libvirt-glib 02/37] Use new helpers to simplify gvir_config_domain_set_features

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain.c | 17 +++-- 1 files changed, 3 insertions(+), 14 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c b/libvirt-gconfig/libvirt-gconfig-domain.c index 3290389..c847c14 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain.c

[libvirt] [libvirt-glib 21/37] Add gvir_config_domain_set_devices

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain.c | 21 + libvirt-gconfig/libvirt-gconfig-domain.h |2 ++ libvirt-gconfig/libvirt-gconfig.sym |3 ++- 3 files changed, 25 insertions(+), 1 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c

[libvirt] [libvirt-glib 15/37] Add test for GVirConfigOs

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index a5c5b99..8abca00 100644 ---

[libvirt] [libvirt-glib 29/37] Add GVirConfigDeviceInput

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am|2 + libvirt-gconfig/libvirt-gconfig-device-input.c | 109 libvirt-gconfig/libvirt-gconfig-device-input.h | 76 libvirt-gconfig/libvirt-gconfig.h |1 +

[libvirt] [libvirt-glib 06/37] Use glib-mkenums to register enums with glib

2011-11-10 Thread Christophe Fergeau
We don't currently have any enum in our API, but we will need some. This commit adds the generation of libvirt-gconfig-enum-types.[ch] using glib-mkenums. These files will register the various enums that will get added to libvirt-gconfig header files with glib. --- configure.ac

[libvirt] [libvirt-glib 03/37] Add gobject boilerplate for GVirConfigClock and GVirConfigTimer

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am |4 ++ libvirt-gconfig/libvirt-gconfig-clock.c | 82 +++ libvirt-gconfig/libvirt-gconfig-clock.h | 68 + libvirt-gconfig/libvirt-gconfig-timer.c | 82 +++

[libvirt] [libvirt-glib 23/37] Add test for adding a disk device

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index af960a9..db22eb5 100644 ---

[libvirt] [PATCH libvirt-glib 1/3] Add GVirDomainDevice abstract class

2011-11-10 Thread Marc-André Lureau
--- libvirt-gobject/Makefile.am|3 + .../libvirt-gobject-domain-device-private.h| 31 + libvirt-gobject/libvirt-gobject-domain-device.c| 139 libvirt-gobject/libvirt-gobject-domain-device.h| 64 +

[libvirt] [PATCH libvirt-glib 3/3] Add GVirDomainDisk

2011-11-10 Thread Marc-André Lureau
--- libvirt-gobject/Makefile.am |2 + libvirt-gobject/libvirt-gobject-domain-disk.c | 210 + libvirt-gobject/libvirt-gobject-domain-disk.h | 78 + libvirt-gobject/libvirt-gobject.h |1 + libvirt-gobject/libvirt-gobject.sym

[libvirt] [libvirt-glib 24/37] GVirConfigInterface derives from GVirConfigDevice

2011-11-10 Thread Christophe Fergeau
This base class is mainly useful as a generic type when we manipulate list of devices regardless of their actual type. --- libvirt-gconfig/libvirt-gconfig-interface.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-interface.c

[libvirt] [libvirt-glib 08/37] Create clock object in domain creation test

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index a719ed2..a5c5b99 100644 --- a/libvirt-gconfig/tests/test-domain-create.c +++

[libvirt] [PATCH libvirt-glib 2/3] Add GVirDomainInterface

2011-11-10 Thread Marc-André Lureau
--- libvirt-gobject/Makefile.am|2 + libvirt-gobject/libvirt-gobject-domain-interface.c | 213 libvirt-gobject/libvirt-gobject-domain-interface.h | 81 libvirt-gobject/libvirt-gobject.h |1 +

[libvirt] [libvirt-glib 10/37] Add gvir_config_genum_get_nick helper

2011-11-10 Thread Christophe Fergeau
We will often need to convert from an enum to its string representation, add an helper for that to avoid duplicating that code. --- libvirt-gconfig/libvirt-gconfig-clock.c | 15 ++- libvirt-gconfig/libvirt-gconfig-helpers-private.h |1 +

[libvirt] [libvirt-glib 05/37] Add gvir_config_domain_set_clock

2011-11-10 Thread Christophe Fergeau
The implementation is likely to need to be completed later. We might want to store pointers from GVirConfigDomain to the associated GVirConfigClock, from GVirConfigClock to the GVirConfigDomain that contains it. Since I'm not sure yet if they will be needed, I chose to keep the implementation

[libvirt] [libvirt-glib 09/37] Add gobject boilerplate for GVirConfigOs

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-os.c | 80 ++ libvirt-gconfig/libvirt-gconfig-os.h | 67 libvirt-gconfig/libvirt-gconfig.h|3 +- libvirt-gconfig/libvirt-gconfig.sym |4

[libvirt] [libvirt-glib 07/37] Implement gvir_config_clock_set_offset

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-clock.c | 19 +++ libvirt-gconfig/libvirt-gconfig-clock.h |8 libvirt-gconfig/libvirt-gconfig.sym |2 ++ 3 files changed, 29 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-clock.c

[libvirt] [libvirt-glib 17/37] Add gobject boilerplate for GVirConfigDevice

2011-11-10 Thread Christophe Fergeau
This is an abstract type which will be used as a base class for all objects stored in the devices section of a domain. --- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-device.c | 62 + libvirt-gconfig/libvirt-gconfig-device.h |

[libvirt] [libvirt-glib 04/37] Add some GVirConfigClock setters

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-clock.c | 32 ++ libvirt-gconfig/libvirt-gconfig-clock.h |5 libvirt-gconfig/libvirt-gconfig-domain.c |1 + libvirt-gconfig/libvirt-gconfig-domain.h |1 - libvirt-gconfig/libvirt-gconfig.sym |2 + 5

[libvirt] [libvirt-glib 16/37] Add GVirConfigDomain::vcpu

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain.c | 29 libvirt-gconfig/libvirt-gconfig-domain.h |3 ++ libvirt-gconfig/libvirt-gconfig.sym|2 + libvirt-gconfig/tests/test-domain-create.c |1 + 4 files changed, 35 insertions(+), 0 deletions(-)

[libvirt] [libvirt-glib 11/37] Implement gvir_config_os_set_os_type

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-os.c | 14 ++ libvirt-gconfig/libvirt-gconfig-os.h |6 ++ libvirt-gconfig/libvirt-gconfig.sym |1 + 3 files changed, 21 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-os.c

[libvirt] [libvirt-glib 25/37] Add gvir_config_interface_set_network_type

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-interface.c | 15 +++ libvirt-gconfig/libvirt-gconfig-interface.h | 11 +++ libvirt-gconfig/libvirt-gconfig.sym |2 ++ 3 files changed, 28 insertions(+), 0 deletions(-) diff --git

[libvirt] [libvirt-glib 31/37] Add GVirConfigDeviceVideo

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am|2 + libvirt-gconfig/libvirt-gconfig-device-video.c | 133 libvirt-gconfig/libvirt-gconfig-device-video.h | 82 +++ libvirt-gconfig/libvirt-gconfig.h |1 +

[libvirt] [libvirt-glib 19/37] Add various GVirConfigDeviceDisk setters

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-device-disk.c | 46 + libvirt-gconfig/libvirt-gconfig-device-disk.h | 25 + libvirt-gconfig/libvirt-gconfig.sym |6 +++ 3 files changed, 77 insertions(+), 0 deletions(-) diff --git

[libvirt] [libvirt-glib 30/37] Add basic GVirConfigGraphicsSpice

2011-11-10 Thread Christophe Fergeau
Only the (non-TLS) port can be set on it --- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-graphics-spice.c | 98 ++ libvirt-gconfig/libvirt-gconfig-graphics-spice.h | 69 +++ libvirt-gconfig/libvirt-gconfig.h

[libvirt] [libvirt-glib 14/37] Implement gvir_config_domain_set_os

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain.c |9 + libvirt-gconfig/libvirt-gconfig-domain.h |2 ++ libvirt-gconfig/libvirt-gconfig.h|4 +++- libvirt-gconfig/libvirt-gconfig.sym |1 + 4 files changed, 15 insertions(+), 1 deletions(-) diff --git

[libvirt] [libvirt-glib 20/37] Improve gvir_config_object_new_child

2011-11-10 Thread Christophe Fergeau
Add an overwrite boolean argument to indicate what to do when the child we are about to create already exists. --- libvirt-gconfig/libvirt-gconfig-clock.c |3 +- libvirt-gconfig/libvirt-gconfig-domain.c |2 +- libvirt-gconfig/libvirt-gconfig-object.c | 39 +++--

[libvirt] [libvirt-glib 18/37] Add gobject boilerplate for GVirConfigDeviceDisk

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-device-disk.c | 82 + libvirt-gconfig/libvirt-gconfig-device-disk.h | 68 libvirt-gconfig/libvirt-gconfig.h |1 +

[libvirt] [libvirt-glib 28/37] Add GVirConfigInterfaceNetwork

2011-11-10 Thread Christophe Fergeau
Make GVirConfigInterface an abstract base class, and move the actual code in subclasses. This will make handling of the various types of network interfaces more understandable and more logical with respect to the corresponding XML. --- libvirt-gconfig/Makefile.am|2 +

[libvirt] [libvirt-glib 22/37] More GVirConfigDeviceDisk setters

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-device-disk.c | 88 - libvirt-gconfig/libvirt-gconfig-device-disk.h | 10 +++ libvirt-gconfig/libvirt-gconfig.sym |7 ++- 3 files changed, 102 insertions(+), 3 deletions(-) diff --git

[libvirt] [libvirt-glib 26/37] Add gvir_config_interface_set_source

2011-11-10 Thread Christophe Fergeau
The way it's done is just a band-aid though. The need for this 'type' member in GVirConfigInterface and GVirConfigDeviceDisk is a clear indication that they should be separate class. --- libvirt-gconfig/libvirt-gconfig-interface.c | 30 ++-

[libvirt] [libvirt-glib 12/37] Add more GVirConfigOs setters

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-os.c | 85 ++ libvirt-gconfig/libvirt-gconfig-os.h | 19 libvirt-gconfig/libvirt-gconfig.sym |8 +++ 3 files changed, 112 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-os.c

[libvirt] [libvirt-glib 32/37] Add gobject boilerplate for chardev handling

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am |6 ++ libvirt-gconfig/libvirt-gconfig-chardev-source.c | 62 libvirt-gconfig/libvirt-gconfig-chardev-source.h | 64 + libvirt-gconfig/libvirt-gconfig-chardev-target.c | 62

[libvirt] [libvirt-glib 36/37] Add GVirConfigChardevTargetConsole

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am|2 + .../libvirt-gconfig-chardev-target-console.c | 83 .../libvirt-gconfig-chardev-target-console.h | 68 libvirt-gconfig/libvirt-gconfig.h |1 +

[libvirt] [libvirt-glib 33/37] Implement gvir_config_device_chardev_set_source

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-chardev-source.c | 44 +- libvirt-gconfig/libvirt-gconfig-chardev-source.h |2 + libvirt-gconfig/libvirt-gconfig-device-chardev.c | 18 + libvirt-gconfig/libvirt-gconfig.sym |2 + 4 files changed, 64

Re: [libvirt] [PATCH 5/8] Enable the blkdeviotune command in virsh

2011-11-10 Thread Adam Litke
OK. On Thu, Nov 10, 2011 at 04:32:55AM +0800, Lei HH Li wrote: Support virsh command blkdeviotune. Can set or query a block disk I/O throttle setting. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- tools/virsh.c | 146

[libvirt] [libvirt-glib 34/37] Implement gvir_config_device_chardev_set_target

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-chardev-target.c | 42 +- libvirt-gconfig/libvirt-gconfig-chardev-target.h |2 + libvirt-gconfig/libvirt-gconfig-device-chardev.c | 18 + libvirt-gconfig/libvirt-gconfig.sym |2 + 4 files changed, 63

[libvirt] [libvirt-glib 37/37] Add test for console node creation

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/tests/test-domain-create.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index ba08a9f..cca3316 100644 ---

Re: [libvirt] Wiki spam!

2011-11-10 Thread Daniel P. Berrange
On Thu, Nov 10, 2011 at 03:27:10PM -0500, Cole Robinson wrote: On 11/10/2011 03:10 PM, Daniel P. Berrange wrote: On Thu, Nov 10, 2011 at 02:50:30PM -0500, Cole Robinson wrote: The wiki's been spammed, see November 9 for example: http://wiki.libvirt.org/page/Special:Recentchanges

[libvirt] [libvirt-glib 35/37] Add GVirConfigChardevSourcePty

2011-11-10 Thread Christophe Fergeau
--- libvirt-gconfig/Makefile.am|2 + .../libvirt-gconfig-chardev-source-pty.c | 82 .../libvirt-gconfig-chardev-source-pty.h | 68 libvirt-gconfig/libvirt-gconfig.h |1 +

Re: [libvirt] [PATCH 7/8] Support virDomain{Set, Get}BlockIoThrottle in the python API

2011-11-10 Thread Adam Litke
Looks good. On Thu, Nov 10, 2011 at 04:32:57AM +0800, Lei HH Li wrote: Python support for both set and get block I/O throttle. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- python/generator.py |2 +

Re: [libvirt] [PATCH libvirt-glib 1/3] Add GVirDomainDevice abstract class

2011-11-10 Thread Christophe Fergeau
Hey, a few preliminary comments, On Thu, Nov 10, 2011 at 09:33:41PM +0100, Marc-André Lureau wrote: + +G_GNUC_INTERNAL +virDomainPtr gvir_domain_device_get_domain_handle(GVirDomainDevice *self) G_GNUC_INTERNAL isn't needed here since it's the default setting for symbols not listed in the .sym

Re: [libvirt] [PATCH libvirt-glib 2/3] Add GVirDomainInterface

2011-11-10 Thread Christophe Fergeau
A few preliminary remark below, they apply to the next patch as well. On Thu, Nov 10, 2011 at 09:33:42PM +0100, Marc-André Lureau wrote: --- libvirt-gobject/Makefile.am|2 + libvirt-gobject/libvirt-gobject-domain-interface.c | 213

Re: [libvirt] [PATCH libvirt-glib 1/3] Add GVirDomainDevice abstract class

2011-11-10 Thread Marc-André Lureau
Hi - Mensaje original - +G_GNUC_INTERNAL +virDomainPtr gvir_domain_device_get_domain_handle(GVirDomainDevice *self) G_GNUC_INTERNAL isn't needed here since it's the default setting for symbols not listed in the .sym file. I think it's better to be explicit about it. It's a

Re: [libvirt] [PATCH libvirt-glib 2/3] Add GVirDomainInterface

2011-11-10 Thread Marc-André Lureau
Hi On Thu, Nov 10, 2011 at 09:33:42PM +0100, Marc-André Lureau wrote: +case PROP_PATH: +if (priv-path) +g_free(priv-path); You can safely call g_free on a NULL pointer, this makes the code a bit simpler, there are several occurrences of this in the 2 patches.

Re: [libvirt] [Qemu-devel] qemu and qemu.git - Migration + disk stress introduces qcow2 corruptions

2011-11-10 Thread Anthony Liguori
On 11/10/2011 12:27 PM, Anthony Liguori wrote: On 11/10/2011 02:55 AM, Avi Kivity wrote: If we have to delay the release for a month to get it right, we should. Not that I think we have to. Adding libvirt to the discussion. What does libvirt actually do in the monitor prior to migration

Re: [libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-10 Thread Adam Litke
Hi Lei, I've tested this and found that it works well except for one small thing. When the domain is running and I change one of the throttle settings using the --config option in virsh, the on-disk domain xml file is properly updated, but the command 'virsh dumpxml' returns the old version. Is

Re: [libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-10 Thread Eric Blake
On 11/10/2011 02:50 PM, Adam Litke wrote: Hi Lei, I've tested this and found that it works well except for one small thing. When the domain is running and I change one of the throttle settings using the --config option in virsh, the on-disk domain xml file is properly updated, but the command

Re: [libvirt] [PATCH] qemu: fix domjobabort regression

2011-11-10 Thread Jim Fehlig
Daniel Veillard wrote: On Wed, Nov 09, 2011 at 09:29:23AM -0700, Eric Blake wrote: This reverts commit ef1065cf5ac; see also this bug report: https://bugzilla.redhat.com/show_bug.cgi?id=751900 In qemu 0.15.1 and earlier, during migration to file, the qemu_savevm_state_begin and

Re: [libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-10 Thread Eric Blake
On 11/10/2011 03:04 PM, Eric Blake wrote: We still need a v4 respinning this to use virTypedParameter; I can help by posting a patch 1/8 that shows the changes that I think we need in the public interface, but I don't want to spend the time rebasing the entire series. This is more along the

[libvirt] [test-API][PATCH 1/2] update env_clear for new way of function reference

2011-11-10 Thread Guannan Ren
--- env_clear.py | 23 ++- 1 files changed, 10 insertions(+), 13 deletions(-) diff --git a/env_clear.py b/env_clear.py index 302ff62..5e78ab5 100644 --- a/env_clear.py +++ b/env_clear.py @@ -14,7 +14,7 @@ # distribution and at http://www.gnu.org/licenses. # # This module

[libvirt] [test-API][PATCH 2/2] update proxy and mapper part for cleanup using new reference

2011-11-10 Thread Guannan Ren
--- mapper.py | 19 +++ proxy.py | 11 +-- 2 files changed, 28 insertions(+), 2 deletions(-) diff --git a/mapper.py b/mapper.py index affc510..f0b675a 100644 --- a/mapper.py +++ b/mapper.py @@ -55,3 +55,22 @@ class Mapper(object): prev_testcases_params =

  1   2   >