Re: [libvirt] [PATCH] Give correct error message when configure a wrong URI aliase.

2011-11-22 Thread Daniel Veillard
On Tue, Nov 22, 2011 at 11:27:04AM +0800, ta...@linux.vnet.ibm.com wrote: From: Eli Qiao ta...@linux.vnet.ibm.com Signed-off-by: Eli Qiao ta...@linux.vnet.ibm.com When configure the URI aliase like this in 'libvirt.conf': uri_aliases = [ jj#j=qemu+ssh://root@127.0.0.1/system,

Re: [libvirt] [PATCH] Give correct error message when configure a wrong URI aliase.

2011-11-22 Thread Osier Yang
On 2011年11月22日 16:07, Daniel Veillard wrote: On Tue, Nov 22, 2011 at 11:27:04AM +0800, ta...@linux.vnet.ibm.com wrote: From: Eli Qiaota...@linux.vnet.ibm.com Signed-off-by: Eli Qiaota...@linux.vnet.ibm.com When configure the URI aliase like this in 'libvirt.conf': uri_aliases = [

Re: [libvirt] problem with nwfilter and ip6tables

2011-11-22 Thread Reinier Schoof
That actually works, thanks a lot! Op 21-11-2011 17:07, Stefan Berger schreef: On 11/21/2011 08:46 AM, Reinier Schoof wrote: Going back to the original email: Hi, I'm investigating using the nwfilter-functionality of libvirt to give my clients the possibility to block ports of their VPSes.

Re: [libvirt] [test-API][PATCH] Update clean part for cases

2011-11-22 Thread Guannan Ren
On 11/21/2011 03:23 PM, Wayne Sun wrote: * add clean function for missing ones * clean the system configuration files which been touched --- repos/domain/balloon_memory.py |2 ++ repos/domain/cpu_topology.py |5 + repos/domain/ownership_test.py | 10

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 08:27:17PM +0100, Marc-André Lureau wrote: Hi On Mon, Nov 21, 2011 at 6:53 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: +    g_return_val_if_fail(error == NULL || *error == NULL, FALSE); This is wrong, it should be error != NULL *error == NULL. +    

Re: [libvirt] [PATCH] Give correct error message when configure a wrong URI aliase.

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 04:07:21PM +0800, Daniel Veillard wrote: On Tue, Nov 22, 2011 at 11:27:04AM +0800, ta...@linux.vnet.ibm.com wrote: From: Eli Qiao ta...@linux.vnet.ibm.com Signed-off-by: Eli Qiao ta...@linux.vnet.ibm.com When configure the URI aliase like this in

Re: [libvirt] [PATCH] Give correct error message when configure a wrong URI aliase.

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 11:27:04AM +0800, ta...@linux.vnet.ibm.com wrote: From: Eli Qiao ta...@linux.vnet.ibm.com Signed-off-by: Eli Qiao ta...@linux.vnet.ibm.com When configure the URI aliase like this in 'libvirt.conf': uri_aliases = [ jj#j=qemu+ssh://root@127.0.0.1/system,

[libvirt] [PATCH] Add strings.h include to capabilities.h for ffs() function prototype

2011-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Pushed the following to fix the build on mingw32 On Mingw32 the ffs() function was not declared due to missing header include * src/conf/capabilities.c: The ffs() function lives in strings.h --- src/conf/capabilities.c |2 ++ 1 files changed, 2

Re: [libvirt] [PATCH v3 0/2] API to invoke S3/S4 on a host and also resume from within libvirt

2011-11-22 Thread Alon Levy
On Mon, Nov 21, 2011 at 05:26:55PM -0700, Eric Blake wrote: On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: (This patch is positioned to go in after the patch that exports the host power management capabilities as XML, posted in [4]) I'm now reviewing that patch along with this series; if

[libvirt] [PATCH v4] virsh: Increase device-detach intelligence

2011-11-22 Thread Michal Privoznik
From: Michal Prívozník mpriv...@redhat.com Up to now users have to give a full XML description on input when device-detaching. If they omitted something it lead to unclear error messages (like generated MAC wasn't found, etc.). With this patch users can specify only those information which

[libvirt] New feature for libvirt network filter

2011-11-22 Thread Amit Tewari
Hi, I wanted to suggest a new feature in libvirt network filter. Currently libvirt allow only one ip address to be provided in the guest configuration xml file. We should allow multiple ip addresses to be provided statically in the guest xml for an interface, so that packets matching

Re: [libvirt] [PATCH v3 0/2] API to invoke S3/S4 on a host and also resume from within libvirt

2011-11-22 Thread Srivatsa S. Bhat
On 11/22/2011 05:56 AM, Eric Blake wrote: On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: (This patch is positioned to go in after the patch that exports the host power management capabilities as XML, posted in [4]) I'm now reviewing that patch along with this series; if we need another

Re: [libvirt] [PATCH v3 0/2] API to invoke S3/S4 on a host and also resume from within libvirt

2011-11-22 Thread Srivatsa S. Bhat
On 11/22/2011 03:48 PM, Alon Levy wrote: On Mon, Nov 21, 2011 at 05:26:55PM -0700, Eric Blake wrote: On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: (This patch is positioned to go in after the patch that exports the host power management capabilities as XML, posted in [4]) I'm now reviewing

[libvirt] [PATCH libvirt-glib 0/5] Misc fixes enhancements

2011-11-22 Thread Daniel P. Berrange
NB, this is an ABI changing series, to fix the bogus use of guint64 for flags parameters -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH libvirt-glib 2/5] Change all flags from guint64 to guint to match libvirt type

2011-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-connection.c |6 ++-- libvirt-gobject/libvirt-gobject-connection.h |4 +- libvirt-gobject/libvirt-gobject-domain-snapshot.c |2 +- libvirt-gobject/libvirt-gobject-domain-snapshot.h |2 +-

[libvirt] [PATCH libvirt-glib 4/5] Add API for creating transient domains

2011-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-connection.c | 49 ++ libvirt-gobject/libvirt-gobject-connection.h |4 ++ 2 files changed, 53 insertions(+), 0 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-connection.c

[libvirt] [PATCH libvirt-glib 3/5] Uncomment fix code for returning config objects

2011-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-domain-snapshot.c |5 + libvirt-gobject/libvirt-gobject-interface.c |5 + libvirt-gobject/libvirt-gobject-network-filter.c |5 + libvirt-gobject/libvirt-gobject-network.c |

[libvirt] [PATCH libvirt-glib 5/5] Ensure domains pools hash tables in connection are non-NULL

2011-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-connection.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt-gobject/libvirt-gobject-connection.c index b6e7f3b..affb496

[libvirt] [PATCH libvirt-glib 1/5] Add support for writing to streams

2011-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/Makefile.am |8 +- libvirt-gobject/libvirt-gobject-output-stream.c | 240 +++ libvirt-gobject/libvirt-gobject-output-stream.h | 68 +++ libvirt-gobject/libvirt-gobject-stream.c

Re: [libvirt] [PATCH v3 1/2] Implement the asynchronous suspend and RTC wakeup

2011-11-22 Thread Srivatsa S. Bhat
On 11/22/2011 06:18 AM, Eric Blake wrote: On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: Add the core functions that implement the functionality of the API. Suspend is done by using an asynchronous mechanism so that we can return the status to the caller successfully before the host gets

Re: [libvirt] [libvirt-gconfig PATCHv2 04/32] Add gvir_config_object_replace_child helper

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:01PM +0100, Christophe Fergeau wrote: This allows us to factor the code to add an XML node to a config object. -- v2: use g_return_if_fail to test function args for sanity replace object --- libvirt-gconfig/libvirt-gconfig-object-private.h |5 +

Re: [libvirt] [libvirt-gconfig PATCHv2 02/32] Remove unused prototype for gvir_config_object_parse

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:03:59PM +0100, Christophe Fergeau wrote: There is no corresponding implementation so no need to keep this prototype. --- libvirt-gconfig/libvirt-gconfig-object.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git

Re: [libvirt] [libvirt-gconfig PATCHv2 05/32] Use new helpers to simplify gvir_config_domain_set_features

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:02PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-domain.c | 17 +++-- libvirt-gconfig/libvirt-gconfig-domain.h |1 - 2 files changed, 3 insertions(+), 15 deletions(-) ACK Daniel -- |: http://berrange.com -o-

Re: [libvirt] [libvirt-gconfig PATCHv2 03/32] Make some GVirConfigObject helpers private

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:00PM +0100, Christophe Fergeau wrote: At this point, I'm not sure how/if the library user should be able to directly manipulate the XML data wrapped by a GVirConfigObject. It's preferrable to hide this API from the user until we have a clearer idea how to expose

Re: [libvirt] [PATCH RESEND v5] Export KVM Host Power Management capabilities

2011-11-22 Thread Srivatsa S. Bhat
On 11/22/2011 05:53 AM, Eric Blake wrote: On 11/13/2011 10:29 PM, Srivatsa S. Bhat wrote: On 11/09/2011 04:38 PM, Srivatsa S. Bhat wrote: This patch exports KVM Host Power Management capabilities as XML so that higher-level systems management software can make use of these features available

Re: [libvirt] [PATCH RESEND v5] Export KVM Host Power Management capabilities

2011-11-22 Thread Srivatsa S. Bhat
On 11/22/2011 08:59 AM, Daniel Veillard wrote: On Wed, Nov 09, 2011 at 04:38:02PM +0530, Srivatsa S. Bhat wrote: This patch exports KVM Host Power Management capabilities as XML so that higher-level systems management software can make use of these features available in the host. The script

Re: [libvirt] [libvirt-gconfig PATCHv2 01/32] Remove unneeded blank line in *_class_init

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:03:58PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-capabilities.c|1 - libvirt-gconfig/libvirt-gconfig-domain-snapshot.c |1 - libvirt-gconfig/libvirt-gconfig-interface.c |1 -

Re: [libvirt] [libvirt-gconfig PATCHv2 06/32] Add gobject boilerplate for GVirConfigClock and GVirConfigTimer

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:03PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/Makefile.am |4 ++ libvirt-gconfig/libvirt-gconfig-clock.c | 81 +++ libvirt-gconfig/libvirt-gconfig-clock.h | 68 ++

Re: [libvirt] [libvirt-gconfig PATCHv2 07/32] Add some GVirConfigClock setters

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:04PM +0100, Christophe Fergeau wrote: -- v2: use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-clock.c | 38 +++ libvirt-gconfig/libvirt-gconfig-clock.h |5

Re: [libvirt] [libvirt-gconfig PATCHv2 09/32] Use glib-mkenums to register enums with glib

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:06PM +0100, Christophe Fergeau wrote: We don't currently have any enum in our API, but we will need some. This commit adds the generation of libvirt-gconfig-enum-types.[ch] using glib-mkenums. These files will register the various enums that will get added to

Re: [libvirt] [libvirt-gconfig PATCHv2 10/32] Add gvir_config_genum_get_nick helper

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:07PM +0100, Christophe Fergeau wrote: We will often need to convert from an enum to its string representation, add an helper for that to avoid duplicating that code. -- v2: moved before gvir_config_clock_set_offset implementation since it needs it ---

Re: [libvirt] [libvirt-gconfig PATCHv2 11/32] Implement gvir_config_clock_set_offset

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:08PM +0100, Christophe Fergeau wrote: -- v2: use gvir_config_genum_get_nick helper since it's now added before this commit use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-clock.c | 17 +

Re: [libvirt] [libvirt-gconfig PATCHv2 08/32] Add gvir_config_domain_set_clock

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:05PM +0100, Christophe Fergeau wrote: The implementation is likely to need to be completed later. We might want to store pointers from GVirConfigDomain to the associated GVirConfigClock, from GVirConfigClock to the GVirConfigDomain that contains it. Since I'm not

Re: [libvirt] [libvirt-gconfig PATCHv2 12/32] Create clock object in domain creation test

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:09PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/tests/test-domain-create.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org

Re: [libvirt] [libvirt-gconfig PATCHv2 13/32] Add gobject boilerplate for GVirConfigOs

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:10PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-os.c | 79 ++ libvirt-gconfig/libvirt-gconfig-os.h | 67

Re: [libvirt] [libvirt-gconfig PATCHv2 14/32] Add some GVirConfigOs setters

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:11PM +0100, Christophe Fergeau wrote: -- v2: merged several related commits use safer g_strcmp0 for string comparison use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-os.c | 138

Re: [libvirt] [libvirt-gconfig PATCHv2 15/32] Implement gvir_config_domain_set_os

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:12PM +0100, Christophe Fergeau wrote: -- v2: use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-domain.c | 12 libvirt-gconfig/libvirt-gconfig-domain.h |2 ++ libvirt-gconfig/libvirt-gconfig.h|

Re: [libvirt] [libvirt-gconfig PATCHv2 08/32] Add gvir_config_domain_set_clock

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 12:56:02PM +, Daniel P. Berrange wrote: On Mon, Nov 21, 2011 at 07:04:05PM +0100, Christophe Fergeau wrote: The implementation is likely to need to be completed later. We might want to store pointers from GVirConfigDomain to the associated GVirConfigClock, from

Re: [libvirt] [libvirt-gconfig PATCHv2 16/32] Add test for GVirConfigOs

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:13PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/tests/test-domain-create.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |:

Re: [libvirt] [libvirt-gconfig PATCHv2 17/32] Add GVirConfigDomain::vcpu

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:14PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-domain.c | 29 libvirt-gconfig/libvirt-gconfig-domain.h |3 ++ libvirt-gconfig/libvirt-gconfig.sym|2 +

Re: [libvirt] [libvirt-gconfig PATCHv2 19/32] Add gobject boilerplate for GVirConfigDeviceDisk

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:16PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-device-disk.c | 81 + libvirt-gconfig/libvirt-gconfig-device-disk.h | 68 +

Re: [libvirt] [libvirt-gconfig PATCHv2 18/32] Add gobject boilerplate for GVirConfigDevice

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:15PM +0100, Christophe Fergeau wrote: This is an abstract type which will be used as a base class for all objects stored in the devices section of a domain. --- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-device.c | 61

Re: [libvirt] [PATCH libvirt-glib 4/5] Add API for creating transient domains

2011-11-22 Thread Christophe Fergeau
Hey, On Tue, Nov 22, 2011 at 12:39:31PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-connection.c | 49 ++ libvirt-gobject/libvirt-gobject-connection.h |4 ++ No addition of the new

Re: [libvirt] [libvirt-gconfig PATCHv2 20/32] Add various GVirConfigDeviceDisk setters

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:17PM +0100, Christophe Fergeau wrote: -- v2: use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-device-disk.c | 50 + libvirt-gconfig/libvirt-gconfig-device-disk.h | 25

Re: [libvirt] [libvirt-gconfig PATCHv2 21/32] Add gvir_config_domain_set_devices

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:18PM +0100, Christophe Fergeau wrote: -- v2: use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-domain.c | 23 +++ libvirt-gconfig/libvirt-gconfig-domain.h |2 ++

Re: [libvirt] [libvirt-gconfig PATCHv2 23/32] More GVirConfigDeviceDisk setters

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:20PM +0100, Christophe Fergeau wrote: -- v2: fix gvir_config_device_disk_set_source use g_return_if_fail to test function args for sanity --- libvirt-gconfig/libvirt-gconfig-device-disk.c | 78 -

Re: [libvirt] [libvirt-gconfig PATCHv2 24/32] Add test for adding a disk device

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:21PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/tests/test-domain-create.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |:

Re: [libvirt] [libvirt-gconfig PATCHv2 25/32] GVirConfigInterface derives from GVirConfigDevice

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:22PM +0100, Christophe Fergeau wrote: This base class is mainly useful as a generic type when we manipulate list of devices regardless of their actual type. --- libvirt-gconfig/libvirt-gconfig-interface.c |2 +- libvirt-gconfig/libvirt-gconfig-interface.h |

Re: [libvirt] [libvirt-gconfig PATCHv2 32/32] Add GVirConfigDeviceVideo

2011-11-22 Thread Daniel P. Berrange
On Mon, Nov 21, 2011 at 07:04:29PM +0100, Christophe Fergeau wrote: -- v2: use g_return_if_fail to test function args for sanity --- libvirt-gconfig/Makefile.am|2 + libvirt-gconfig/libvirt-gconfig-device-video.c | 133

Re: [libvirt] [libvirt-gconfig PATCHv2 06/32] Add gobject boilerplate for GVirConfigClock and GVirConfigTimer

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 12:48:54PM +, Daniel P. Berrange wrote: On Mon, Nov 21, 2011 at 07:04:03PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/Makefile.am |4 ++ libvirt-gconfig/libvirt-gconfig-clock.c | 81 +++

Re: [libvirt] [PATCH libvirt-glib 3/5] Uncomment fix code for returning config objects

2011-11-22 Thread Christophe Fergeau
Hi, On Tue, Nov 22, 2011 at 12:39:30PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-domain-snapshot.c |5 + libvirt-gobject/libvirt-gobject-interface.c |5 +

Re: [libvirt] [libvirt-gconfig PATCHv2 18/32] Add gobject boilerplate for GVirConfigDevice

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 01:06:11PM +, Daniel P. Berrange wrote: On Mon, Nov 21, 2011 at 07:04:15PM +0100, Christophe Fergeau wrote: This is an abstract type which will be used as a base class for all objects stored in the devices section of a domain. --- libvirt-gconfig/Makefile.am

Re: [libvirt] [PATCH libvirt-glib 5/5] Ensure domains pools hash tables in connection are non-NULL

2011-11-22 Thread Christophe Fergeau
Hi, I assume without this, it's easy to try to add data to NULL hash tables when using the transient domain API you added in this patch series? ACK patch, just curious... Christophe On Tue, Nov 22, 2011 at 12:39:32PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com

Re: [libvirt] [libvirt-gconfig PATCHv2 13/32] Add gobject boilerplate for GVirConfigOs

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 01:01:17PM +, Daniel P. Berrange wrote: On Mon, Nov 21, 2011 at 07:04:10PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-os.c | 79 ++

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-22 Thread Zeeshan Ali (Khattak)
On Tue, Nov 22, 2011 at 11:20 AM, Daniel P. Berrange berra...@redhat.com wrote: On Mon, Nov 21, 2011 at 08:27:17PM +0100, Marc-André Lureau wrote: Hi On Mon, Nov 21, 2011 at 6:53 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: +    g_return_val_if_fail(error == NULL || *error == NULL,

Re: [libvirt] [libvirt-gconfig PATCHv2 19/32] Add gobject boilerplate for GVirConfigDeviceDisk

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 01:06:52PM +, Daniel P. Berrange wrote: On Mon, Nov 21, 2011 at 07:04:16PM +0100, Christophe Fergeau wrote: --- libvirt-gconfig/Makefile.am |2 + libvirt-gconfig/libvirt-gconfig-device-disk.c | 81 +

Re: [libvirt] [PATCH libvirt-glib 5/5] Ensure domains pools hash tables in connection are non-NULL

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 02:22:40PM +0100, Christophe Fergeau wrote: Hi, I assume without this, it's easy to try to add data to NULL hash tables when using the transient domain API you added in this patch series? ACK patch, just curious... Actually the scenario was with persistent domains

Re: [libvirt] [PATCH libvirt-glib 4/5] Add API for creating transient domains

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 02:07:23PM +0100, Christophe Fergeau wrote: Hey, On Tue, Nov 22, 2011 at 12:39:31PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-connection.c | 49 ++

Re: [libvirt] [PATCH libvirt-glib 1/5] Add support for writing to streams

2011-11-22 Thread Christophe Fergeau
On Tue, Nov 22, 2011 at 12:39:28PM +, Daniel P. Berrange wrote: + +GType_gvir_output_stream_get_type (void) G_GNUC_CONST; +GVirOutputStream * _gvir_output_stream_new (GVirStream *stream); This brings the question of how to mark

Re: [libvirt] [PATCH libvirt-glib 3/5] Uncomment fix code for returning config objects

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 02:19:44PM +0100, Christophe Fergeau wrote: Hi, On Tue, Nov 22, 2011 at 12:39:30PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-domain-snapshot.c |5 +

Re: [libvirt] [libvirt-glib] Release 0.0.2

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 04:27:17AM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- NEWS | 20 configure.ac |3 +-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index

Re: [libvirt] [PATCH libvirt-glib 1/5] Add support for writing to streams

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 02:50:26PM +0100, Christophe Fergeau wrote: On Tue, Nov 22, 2011 at 12:39:28PM +, Daniel P. Berrange wrote: + +GType_gvir_output_stream_get_type (void) G_GNUC_CONST; +GVirOutputStream * _gvir_output_stream_new

[libvirt] [PATCH libvirt-glib] Don't reference GError **err parameter if it is NULL

2011-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-connection.c | 104 +- libvirt-gobject/libvirt-gobject-domain.c | 70 -- libvirt-gobject/libvirt-gobject-interface.c |7 +-

Re: [libvirt] [PATCH V1 4/9] Add a mac chain

2011-11-22 Thread Stefan Berger
On 11/21/2011 05:13 PM, Eric Blake wrote: On 10/26/2011 09:12 AM, Stefan Berger wrote: With hunks borrowed from one of David Steven's previous patches, we now add the capability of having a 'mac' chain which is useful to filter for multiple valid MAC addresses. Signed-off-by: David L

Re: [libvirt] [PATCH libvirt-glib] Don't reference GError **err parameter if it is NULL

2011-11-22 Thread Zeeshan Ali (Khattak)
On Tue, Nov 22, 2011 at 4:18 PM, Daniel P. Berrange berra...@redhat.com wrote: From: Daniel P. Berrange berra...@redhat.com ---  libvirt-gobject/libvirt-gobject-connection.c     |  104 +-  libvirt-gobject/libvirt-gobject-domain.c         |   70 --  

Re: [libvirt] [PATCH libvirt-glib] Don't reference GError **err parameter if it is NULL

2011-11-22 Thread Christophe Fergeau
On Tue, Nov 22, 2011 at 02:18:15PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-connection.c | 104 +- libvirt-gobject/libvirt-gobject-domain.c | 70 --

Re: [libvirt] [PATCH V1 5/9] Add support for STP filtering

2011-11-22 Thread Stefan Berger
On 11/21/2011 05:50 PM, Eric Blake wrote: On 10/26/2011 09:12 AM, Stefan Berger wrote: This patch adds support for filtering of STP (spanning tree protocol) traffic to the parser and makes us of the ebtables support for STP filtering. This code now enables the filtering of traffic in chains

[libvirt] [PATCH 0/4] Small fixes to non-blocking I/O in client

2011-11-22 Thread Jiri Denemark
I missed these when reviewing the series... Jiri Denemark (4): rpc: Pass the buck only to the first available thread rpc: Fix a typo in virNetClientSendNonBlock documentation rpc: Fix handling of non-blocking calls that could not be sent rpc: Add some debug messages to virNetClient

[libvirt] [PATCH 2/4] rpc: Fix a typo in virNetClientSendNonBlock documentation

2011-11-22 Thread Jiri Denemark
--- src/rpc/virnetclient.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index b518abd..0effceb 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1595,7 +1595,7 @@ int

[libvirt] [PATCH 1/4] rpc: Pass the buck only to the first available thread

2011-11-22 Thread Jiri Denemark
--- src/rpc/virnetclient.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index deeeaad..b518abd 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1102,7 +1102,7 @@ static void

[libvirt] [PATCH 4/4] rpc: Add some debug messages to virNetClient

2011-11-22 Thread Jiri Denemark
--- src/rpc/virnetclient.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index c99e87c..025d270 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1040,6 +1040,7 @@ static bool

[libvirt] [PATCH 3/4] rpc: Fix handling of non-blocking calls that could not be sent

2011-11-22 Thread Jiri Denemark
When virNetClientIOEventLoop is called for a non-blocking call and not even a single byte can be sent from this call without blocking, we properly reported that to the caller which properly frees the call. But we never removed the call from a call queue. --- src/rpc/virnetclient.c |7 ++-

Re: [libvirt] [PATCH libvirt-glib] Don't reference GError **err parameter if it is NULL

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 03:50:46PM +0100, Christophe Fergeau wrote: On Tue, Nov 22, 2011 at 02:18:15PM +, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- libvirt-gobject/libvirt-gobject-connection.c | 104 +-

Re: [libvirt] [PATCH V1 9/9] Improve error reporting of failures to apply filtering rules

2011-11-22 Thread Stefan Berger
On 11/21/2011 06:42 PM, Eric Blake wrote: On 10/26/2011 09:12 AM, Stefan Berger wrote: Display the executed command and failure message if a command failed to execute. Signed-off-by: Stefan Bergerstef...@linux.vnet.ibm.com --- src/nwfilter/nwfilter_ebiptables_driver.c | 82

[libvirt] [PATCH v5 07/13] Add support for async close of client RPC socket

2011-11-22 Thread Jiri Denemark
--- Notes: Version 5: - rebased on top of DanB's non-blocking patches; this is the only part that required non-trivial rebase so I'm posting it for additional review Version 4: - no changes Version 3: - no changes Version 2: - no changes

[libvirt] ANNOUNCE: libvirt-glib release 0.0.2

2011-11-22 Thread Daniel P. Berrange
I am pleased to announce that a new release of the libvirt-glib package, version 0.0.2 is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) New in this release: - Add API to

[libvirt] [PATCH V2 0/5] NWFilter: Filter more protocols and other extensions

2011-11-22 Thread Stefan Berger
This patch series adds: - support for a 'mac' chain - filtering support for STP (spanning tree protocol) - better error reporting if ebtables/ip(6)table commands fail v2: - shortened series since VLAN patches have been pushed - addressed Eric Blake's comments Regards, Stefan --

[libvirt] [PATCH V2 1/5] Add a mac chain

2011-11-22 Thread Stefan Berger
With hunks borrowed from one of David Steven's previous patches, we now add the capability of having a 'mac' chain which is useful to filter for multiple valid MAC addresses. Signed-off-by: David L Stevens dlstev...@us.ibm.com Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com ---

[libvirt] [PATCH V2 3/5] Add test cases for STP traffic filtering

2011-11-22 Thread Stefan Berger
This patch adds a few test cases for the XML parsing of STP filtering nodes. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- tests/nwfilterxml2xmlin/stp-test.xml | 26 ++ tests/nwfilterxml2xmlout/stp-test.xml | 12

[libvirt] [PATCH V2 4/5] Add documentation for STP filtering support

2011-11-22 Thread Stefan Berger
Add documentation for the STP filtering support. Describe the XML attributes that are supported. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- docs/formatnwfilter.html.in | 142 1 file changed, 142 insertions(+) Index:

[libvirt] [PATCH V2 5/5] Improve error reporting of failures to apply filtering rules

2011-11-22 Thread Stefan Berger
Display the executed command and failure message if a command failed to execute. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- v2: - addressing Eric Blake's comments --- src/nwfilter/nwfilter_ebiptables_driver.c | 86 +- 1 file changed, 50

[libvirt] [PATCH V2 2/5] Add support for STP filtering

2011-11-22 Thread Stefan Berger
This patch adds support for filtering of STP (spanning tree protocol) traffic to the parser and makes us of the ebtables support for STP filtering. This code now enables the filtering of traffic in chains with prefix 'stp'. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- v2: -

[libvirt] [PATCH v2 2/2] nwfilter: use shell variable to invoke 'ip(6)tables' command

2011-11-22 Thread Stefan Berger
Introduce a shell variable 'IBT' to invoke the ip(6)tables command. Tested with libvirt-tck. --- v2: - rebased --- src/nwfilter/nwfilter_ebiptables_driver.c | 313 ++ 1 file changed, 155 insertions(+), 158 deletions(-) Index:

[libvirt] [PATCH v2 1/2] nwfilter: use shell variable to invoke 'ebtables' command

2011-11-22 Thread Stefan Berger
Introduce a shell variable 'EBT' to invoke the ebtables command. Hard-code the used ebtables table to '-t nat'. Tested with libvirt-tck. --- v2: - rebased --- src/nwfilter/nwfilter_ebiptables_driver.c | 170 +- 1 file changed, 97 insertions(+), 73 deletions(-)

Re: [libvirt] [PATCH V1 5/9] Add support for STP filtering

2011-11-22 Thread Eric Blake
On 11/22/2011 07:51 AM, Stefan Berger wrote: On 11/21/2011 05:50 PM, Eric Blake wrote: On 10/26/2011 09:12 AM, Stefan Berger wrote: This patch adds support for filtering of STP (spanning tree protocol) traffic to the parser and makes us of the ebtables support for STP filtering. This code

[libvirt] [PATCH] virsh: Allow other escape characters for console

2011-11-22 Thread Michal Privoznik
Currently virsh supports only ^] as escape character for console. However, some users might want to use something else. This patch creates such ability by specifying '-e' switch on virsh command line. --- Okay, this patch is meant as RFC mainly but if it got enough ACKs I will not hesitate to push

Re: [libvirt] [PATCH] virsh: Allow other escape characters for console

2011-11-22 Thread Eric Blake
On 11/22/2011 09:18 AM, Michal Privoznik wrote: Currently virsh supports only ^] as escape character for console. However, some users might want to use something else. This patch creates such ability by specifying '-e' switch on virsh command line. --- Okay, this patch is meant as RFC mainly

[libvirt] [PATCH] docs: fix grammar of capabilities

2011-11-22 Thread Eric Blake
* docs/formatcaps.html.in: Avoid run-on sentence, wrap lines. --- Pushing under the trivial rule. docs/formatcaps.html.in | 45 ++--- 1 files changed, 26 insertions(+), 19 deletions(-) diff --git a/docs/formatcaps.html.in b/docs/formatcaps.html.in

Re: [libvirt] [PATCH v3 1/2] Implement the asynchronous suspend and RTC wakeup

2011-11-22 Thread Eric Blake
On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: Add the core functions that implement the functionality of the API. Suspend is done by using an asynchronous mechanism so that we can return the status to the caller successfully before the host gets suspended. This asynchronous operation is

Re: [libvirt] [PATCH v3 1/2] Implement the asynchronous suspend and RTC wakeup

2011-11-22 Thread Srivatsa S. Bhat
On 11/22/2011 11:33 PM, Eric Blake wrote: On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: Add the core functions that implement the functionality of the API. Suspend is done by using an asynchronous mechanism so that we can return the status to the caller successfully before the host gets

Re: [libvirt] [PATCH v3 2/2] Make the API public

2011-11-22 Thread Eric Blake
On 11/09/2011 05:05 AM, Srivatsa S. Bhat wrote: Define the required interfaces to export the API. Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com --- include/libvirt/libvirt.h.in |4 src/driver.h |5 src/libvirt.c| 48

Re: [libvirt] [PATCH V2 1/5] Add a mac chain

2011-11-22 Thread Eric Blake
On 11/22/2011 08:51 AM, Stefan Berger wrote: With hunks borrowed from one of David Steven's previous patches, we now add the capability of having a 'mac' chain which is useful to filter for multiple valid MAC addresses. Signed-off-by: David L Stevens dlstev...@us.ibm.com Signed-off-by:

Re: [libvirt] [PATCH 4/4] rpc: Add some debug messages to virNetClient

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 04:32:34PM +0100, Jiri Denemark wrote: --- src/rpc/virnetclient.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index c99e87c..025d270 100644 --- a/src/rpc/virnetclient.c +++

Re: [libvirt] [PATCH 2/4] rpc: Fix a typo in virNetClientSendNonBlock documentation

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 04:32:32PM +0100, Jiri Denemark wrote: --- src/rpc/virnetclient.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index b518abd..0effceb 100644 --- a/src/rpc/virnetclient.c +++

Re: [libvirt] [PATCH V2 2/5] Add support for STP filtering

2011-11-22 Thread Eric Blake
On 11/22/2011 08:51 AM, Stefan Berger wrote: This patch adds support for filtering of STP (spanning tree protocol) traffic to the parser and makes us of the ebtables support for STP filtering. This code now enables the filtering of traffic in chains with prefix 'stp'. Signed-off-by: Stefan

Re: [libvirt] [PATCH 3/4] rpc: Fix handling of non-blocking calls that could not be sent

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 04:32:33PM +0100, Jiri Denemark wrote: When virNetClientIOEventLoop is called for a non-blocking call and not even a single byte can be sent from this call without blocking, we properly reported that to the caller which properly frees the call. But we never removed the

Re: [libvirt] [PATCH 1/4] rpc: Pass the buck only to the first available thread

2011-11-22 Thread Daniel P. Berrange
On Tue, Nov 22, 2011 at 04:32:31PM +0100, Jiri Denemark wrote: --- src/rpc/virnetclient.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index deeeaad..b518abd 100644 --- a/src/rpc/virnetclient.c +++

Re: [libvirt] [PATCH V2 1/5] Add a mac chain

2011-11-22 Thread Stefan Berger
On 11/22/2011 01:47 PM, Eric Blake wrote: On 11/22/2011 08:51 AM, Stefan Berger wrote: With hunks borrowed from one of David Steven's previous patches, we now add the capability of having a 'mac' chain which is useful to filter for multiple valid MAC addresses. Signed-off-by: David L

Re: [libvirt] [PATCH V2 4/5] Add documentation for STP filtering support

2011-11-22 Thread Eric Blake
On 11/22/2011 08:51 AM, Stefan Berger wrote: Add documentation for the STP filtering support. Describe the XML attributes that are supported. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- docs/formatnwfilter.html.in | 142 1

Re: [libvirt] [PATCH V2 3/5] Add test cases for STP traffic filtering

2011-11-22 Thread Eric Blake
On 11/22/2011 08:51 AM, Stefan Berger wrote: This patch adds a few test cases for the XML parsing of STP filtering nodes. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- tests/nwfilterxml2xmlin/stp-test.xml | 26 ++

  1   2   >