Re: [libvirt] Feature Request: sniff a virtual interface of a guest

2012-01-30 Thread Hendrik Schwartke
Hi Dave, I'm using libvirt for quite a while but I'm relatively new to the code. So thank you for your hints. I will have a look at the streaming api this week. Thanks Hendrik On 27.01.2012 15:39, Dave Allan wrote: On Fri, Jan 27, 2012 at 09:28:21AM +0100, Hendrik Schwartke wrote: Hi,

[libvirt] [PATCH 0/4] RFC: grant KVM guest rawio capability

2012-01-30 Thread Taku Izumi
This patch is as a result of the following dispute: http://www.redhat.com/archives/libvir-list/2011-December/msg00857.html http://www.redhat.com/archives/libvir-list/2011-December/msg00950.html http://www.redhat.com/archives/libvir-list/2012-January/msg00449.html This patchset

[libvirt] [PATCH 1/4] conf: add rawio attribute to disk element of domain XML

2012-01-30 Thread Taku Izumi
This patch adds a new attribute rawio to the disk element of domain XML. Valid values of rawio attribute are yes and no. rawio='yes' indicates the disk is desirous of CAP_SYS_RAWIO. If you specify the following XML: disk type='block' device='lun' rawio='yes' ... /disk the

[libvirt] [PATCH 2/4] util: add functions to keep capabilities

2012-01-30 Thread Taku Izumi
This patch introduces virKeepCapabilities() function and implements virCommandAllowCap() function. Existing virClearCapabilities() is function to clear all capabilities. Instead virKeepCapabilities() is function to keep arbitrary capabilities. Signed-off-by: Taku Izumi

[libvirt] [PATCH 4/4] qemu: make qemu processes to retain capabilities

2012-01-30 Thread Taku Izumi
This patch revises qemuProcessStart() function for qemu processes to retain arbitrary capabilities. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com Signed-off-by: Shota Hirae m11g1...@hibikino.ne.jp --- src/qemu/qemu_process.c |1 + 1 file changed, 1 insertion(+) Index:

[libvirt] [PATCH 3/4] util: extend virExecWithHook()

2012-01-30 Thread Taku Izumi
This patch extends virExecWithHook() to receive capability information. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com Signed-off-by: Shota Hirae m11g1...@hibikino.ne.jp --- src/util/command.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) Index:

Re: [libvirt] [PATCH V4 1/5] Add new public API virDomainGetCPUStats()

2012-01-30 Thread Daniel P. Berrange
On Sat, Jan 28, 2012 at 07:37:49AM -0700, Eric Blake wrote: [I see you cc'd e...@redhat.com; unfortunately, that doesn't forward to me - at least I saw it on-list :) ] On 01/27/2012 11:20 PM, KAMEZAWA Hiroyuki wrote: add new API virDomainGetCPUStats() for getting cpu accounting

[libvirt] Segfault fixed

2012-01-30 Thread Hendrik Schwartke
Hi, there is a segfault in qemu_monitor_text.c. If some error accurs in qemuMonitorTextGetBlockInfo then the cleanup code calls VIR_FREE(info) without ensuring that info is initialized. Patch based on c6ec021b3c19c3ecc97d60d35b12eaa0b94da701: diff --git a/src/qemu/qemu_monitor_text.c

Re: [libvirt] [libvirt-glib] Add virStorageVolResize()

2012-01-30 Thread Daniel P. Berrange
On Sat, Jan 28, 2012 at 02:49:46AM +0200, Zeeshan Ali (Khattak) wrote: On Sat, Jan 28, 2012 at 1:17 AM, Eric Blake ebl...@redhat.com wrote: On 01/26/2012 10:29 PM, Zeeshan Ali (Khattak) wrote: +/** + * virStorageVolResize: + * @vol: pointer to storage volume + * @capacity: new

[libvirt] oVirt Live Snapshots

2012-01-30 Thread Federico Simoncelli
Hi, oVirt, and more specifically VDSM, is currently implementing the live snapshot feature using the API/commands provided by libvirt and qemu. It would be great if you could review the design and the current open issues at: http://ovirt.org/wiki/Live_Snapshots Thank you, -- Federico --

Re: [libvirt] [PATCH 1/4] conf: add rawio attribute to disk element of domain XML

2012-01-30 Thread Paolo Bonzini
On 01/30/2012 10:08 AM, Taku Izumi wrote: +/* cap_sys_rawio check */ +if (disk-rawio == 1 +(def-process_caps (1ULL CAP_SYS_RAWIO)) == 0) { +def-process_caps |= (1ULL CAP_SYS_RAWIO); +VIR_WARN(domain %s will be granted CAP_SYS_RAWIO,

Re: [libvirt] [PATCH] qemu: never send SIGKILL to qemu process unless specifically requested

2012-01-30 Thread Daniel P. Berrange
On Fri, Jan 27, 2012 at 01:35:35PM -0500, Laine Stump wrote: When libvirt is shutting down the qemu process, it first sends SIGTERM, then waits for 1.6 seconds and, if it sees the process still there, sends a SIGKILL. There have been reports that this behavior can lead to data loss because

Re: [libvirt] [PATCH 1/2] resize: add virStorageVolResize() API

2012-01-30 Thread Daniel P. Berrange
On Fri, Jan 27, 2012 at 05:28:15PM -0700, Eric Blake wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Add a new function to allow changing of capacity of storage volumes. Plan out several flags, even if not all of them will be implemented up front. Expose the new command via 'virsh

Re: [libvirt] [PATCH] xen: Don't add console to xml for dom0

2012-01-30 Thread Daniel P. Berrange
On Sun, Jan 29, 2012 at 02:13:10PM -0500, Cole Robinson wrote: It just doesn't really make sense and confuses virt-manager --- src/xenxs/xen_sxpr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xenxs/xen_sxpr.c b/src/xenxs/xen_sxpr.c index 7a53f94..09e7730

Re: [libvirt] [PATCHv3] network: Avoid memory leaks on networkBuildDnsmasqArgv

2012-01-30 Thread Michal Privoznik
On 29.01.2012 06:24, a...@redhat.com wrote: From: Alex Jia a...@redhat.com Detected by valgrind. Leaks introduced in commit 973af236. * src/network/bridge_driver.c: fix memory leaks on failure and successful path. * How to reproduce? % make -C tests check TESTS=networkxml2argvtest %

Re: [libvirt] [PATCH 1/4] conf: add rawio attribute to disk element of domain XML

2012-01-30 Thread Daniel P. Berrange
On Mon, Jan 30, 2012 at 06:08:35PM +0900, Taku Izumi wrote: This patch adds a new attribute rawio to the disk element of domain XML. Valid values of rawio attribute are yes and no. rawio='yes' indicates the disk is desirous of CAP_SYS_RAWIO. If you specify the following XML: disk

Re: [libvirt] [PATCH 2/4] util: add functions to keep capabilities

2012-01-30 Thread Daniel P. Berrange
On Mon, Jan 30, 2012 at 06:09:44PM +0900, Taku Izumi wrote: This patch introduces virKeepCapabilities() function and implements virCommandAllowCap() function. Existing virClearCapabilities() is function to clear all capabilities. Instead virKeepCapabilities() is function to keep arbitrary

Re: [libvirt] [PATCH 3/4] util: extend virExecWithHook()

2012-01-30 Thread Daniel P. Berrange
On Mon, Jan 30, 2012 at 06:10:50PM +0900, Taku Izumi wrote: This patch extends virExecWithHook() to receive capability information. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com Signed-off-by: Shota Hirae m11g1...@hibikino.ne.jp --- src/util/command.c | 16 ++-- 1

Re: [libvirt] [PATCH 4/4] qemu: make qemu processes to retain capabilities

2012-01-30 Thread Daniel P. Berrange
On Mon, Jan 30, 2012 at 06:11:50PM +0900, Taku Izumi wrote: This patch revises qemuProcessStart() function for qemu processes to retain arbitrary capabilities. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com Signed-off-by: Shota Hirae m11g1...@hibikino.ne.jp ---

[libvirt] [PATCH] Add virt-host-validate.1 to Mingw32 RPM spec file list

2012-01-30 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Pushed under trivial rule --- mingw32-libvirt.spec.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/mingw32-libvirt.spec.in b/mingw32-libvirt.spec.in index 961c3ba..7937e22 100644 --- a/mingw32-libvirt.spec.in +++

Re: [libvirt] [PATCH] xen: Don't add console to xml for dom0

2012-01-30 Thread Cole Robinson
On 01/30/2012 06:12 AM, Daniel P. Berrange wrote: On Sun, Jan 29, 2012 at 02:13:10PM -0500, Cole Robinson wrote: It just doesn't really make sense and confuses virt-manager --- src/xenxs/xen_sxpr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Thu, 26 Jan 2012 16:57:01 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/26/2012 01:35 PM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 08:18:03 -0700 Eric Blakeebl...@redhat.com wrote: [adding qemu-devel] On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: One thing,

Re: [libvirt] Segfault fixed

2012-01-30 Thread Michal Privoznik
On 30.01.2012 11:46, Hendrik Schwartke wrote: Hi, there is a segfault in qemu_monitor_text.c. If some error accurs in qemuMonitorTextGetBlockInfo then the cleanup code calls VIR_FREE(info) without ensuring that info is initialized. Patch based on c6ec021b3c19c3ecc97d60d35b12eaa0b94da701:

[libvirt] virDomainNetGetActualBridgeName doesn't return the actual bridge

2012-01-30 Thread Hendrik Schwartke
Hi, calling virDomainNetGetActualBridgeName on a bridge with type VIR_DOMAIN_NET_TYPE_NETWORK seems to return NULL in any case, because iface-data.network.actual is NULL. Is that intented? What is the best way to determine the bridge the interface is connected to? Hendrik Schwartke --

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Anthony Liguori
On 01/30/2012 06:57 AM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 16:57:01 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 01/26/2012 01:35 PM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 08:18:03 -0700 Eric Blakeebl...@redhat.com wrote: [adding qemu-devel] On 01/26/2012 07:46 AM,

Re: [libvirt] [PATCH 1/2] resize: add virStorageVolResize() API

2012-01-30 Thread Eric Blake
On 01/30/2012 04:08 AM, Daniel P. Berrange wrote: On Fri, Jan 27, 2012 at 05:28:15PM -0700, Eric Blake wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Add a new function to allow changing of capacity of storage volumes. Plan out several flags, even if not all of them will be

Re: [libvirt] [PATCH 1/2] resize: add virStorageVolResize() API

2012-01-30 Thread Daniel P. Berrange
On Mon, Jan 30, 2012 at 07:18:06AM -0700, Eric Blake wrote: On 01/30/2012 04:08 AM, Daniel P. Berrange wrote: On Fri, Jan 27, 2012 at 05:28:15PM -0700, Eric Blake wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Add a new function to allow changing of capacity of storage volumes.

Re: [libvirt] [PATCH 1/2] resize: add virStorageVolResize() API

2012-01-30 Thread Daniel P. Berrange
On Mon, Jan 30, 2012 at 02:25:19PM +, Daniel P. Berrange wrote: On Mon, Jan 30, 2012 at 07:18:06AM -0700, Eric Blake wrote: On 01/30/2012 04:08 AM, Daniel P. Berrange wrote: On Fri, Jan 27, 2012 at 05:28:15PM -0700, Eric Blake wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Mon, 30 Jan 2012 07:54:56 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/30/2012 06:57 AM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 16:57:01 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 01/26/2012 01:35 PM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 08:18:03

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Michael Roth
On 01/30/2012 06:57 AM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 16:57:01 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 01/26/2012 01:35 PM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 08:18:03 -0700 Eric Blakeebl...@redhat.com wrote: [adding qemu-devel] On 01/26/2012 07:46 AM,

[libvirt] [PATCHv2 0/4] API for modification of domain metadata

2012-01-30 Thread Peter Krempa
This is a corrected version of the domain metadata modification API. I dropped the limit on length of the domain title and added skipping of newlines added at the end of file by some editors, which made --edit unusable with --title for the new desc command. Peter Krempa (4): xml: Add element

[libvirt] [PATCHv2 1/4] xml: Add element title to allow short description of domains

2012-01-30 Thread Peter Krempa
This patch adds a new element title to the domain XML. This attribute can hold a short title defined by the user to ease the identification of domains. The title contain newlines and should be reasonably short. *docs/formatdomain.html.in *docs/schemas/domaincommon.rng - add schema

[libvirt] [PATCHv2 2/4] API: Add api to set and get domain metadata

2012-01-30 Thread Peter Krempa
This patch adds API to modify domain metadata for running and stopped domains. The api supports changing description, title as well as the newly added metadata element. The API has support for storing data in the metadata element using xml namespaces. * include/libvirt/libvirt.h.in *

[libvirt] [PATCHv2 3/4] virsh: Add support for modifying domain description and titles

2012-01-30 Thread Peter Krempa
This patch adds a new command desc to show and modify titles and description for the domains using the new API. This patch also adds a new flag for the list command to show titles in the domain list, to allow easy identification of VMs by storing a short description. Example: virsh # list

[libvirt] [PATCHv2 4/4] qemu: Add support for virDomainGetMetadata and virDomainSetMetadata

2012-01-30 Thread Peter Krempa
This patch adds support for the new api into the qemu driver to support modification and retireval of domain description and title. This patch does not add support for modifying the metadata element. --- Diff to v1: - move some checks to api function - change error message to argument unsupported

Re: [libvirt] [PATCHv3] network: Avoid memory leaks on networkBuildDnsmasqArgv

2012-01-30 Thread Alex Jia
Hi Michal, Thanks for your comment, the following v1 patch should be a right way? https://www.redhat.com/archives/libvir-list/2012-January/msg00209.html Regards, Alex - Original Message - From: Michal Privoznik mpriv...@redhat.com To: a...@redhat.com Cc: libvir-list@redhat.com Sent:

Re: [libvirt] [PATCH v3 0/7] Console corruption patchset

2012-01-30 Thread Peter Krempa
On 01/26/2012 06:16 PM, Peter Krempa wrote: This is the third version of this patchset, rebased, polisehd and tweaked after Eric's review. This series contains one new patch that enables reuse of code in patches later on. The qemu driver implementation of console handling is very similar to

Re: [libvirt] [PATCH 1/2] resize: add virStorageVolResize() API

2012-01-30 Thread Eric Blake
On 01/30/2012 07:28 AM, Daniel P. Berrange wrote: Why has this changed from 'unsigned long long' to just 'long long'. Because of VIR_STORAGE_VOL_RESIZE_DELTA and VIR_STORAGE_VOL_RESIZE_SHRINK. That is, virStorageVolResize(vol, -10 * 1024 * 1024, DELTA|SHRINK) is a valid call to shave off

Re: [libvirt] [PATCH 1/2] resize: add virStorageVolResize() API

2012-01-30 Thread Daniel P. Berrange
On Mon, Jan 30, 2012 at 08:23:36AM -0700, Eric Blake wrote: On 01/30/2012 07:28 AM, Daniel P. Berrange wrote: Why has this changed from 'unsigned long long' to just 'long long'. Because of VIR_STORAGE_VOL_RESIZE_DELTA and VIR_STORAGE_VOL_RESIZE_SHRINK. That is,

[libvirt] [PATCH] Support for cpu64-rhel* qemu cpu models

2012-01-30 Thread Martin Kletzander
In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not supported by libvirt. This patch adds the support with the flags specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf --- src/cpu/cpu_map.xml | 94 +++ 1 files changed,

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Michael Roth
On 01/30/2012 08:44 AM, Luiz Capitulino wrote: On Mon, 30 Jan 2012 07:54:56 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 01/30/2012 06:57 AM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 16:57:01 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 01/26/2012 01:35 PM, Luiz

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Eric Blake
On 01/30/2012 07:44 AM, Luiz Capitulino wrote: I think we should do the following then: 1. Drop the set-support-level command 2. Split the guest-suspend command into guest-suspend-ram, guest-suspend-hybrid, guest-suspend-disk 3. Libvirt should query for _QEMU_'s 'wakeup' command

[libvirt] [PATCH v2 0/3] Add virDomainGetDiskErrors API

2012-01-30 Thread Jiri Denemark
We already provide ways to detect when a domain has been paused as a result of I/O error, but there was no way of getting the exact error or even the device that experienced it. This new API may be used for both. Changes in version 2: - the API is now called virDomainGetDiskErrors - it returns a

[libvirt] [PATCH v2 2/3] qemu: Implement virDomainGetDiskErrors

2012-01-30 Thread Jiri Denemark
--- src/qemu/qemu_conf.h |1 + src/qemu/qemu_driver.c | 83 ++ src/qemu/qemu_monitor.c | 40 src/qemu/qemu_monitor.h |1 + src/qemu/qemu_monitor_json.c |8 src/qemu/qemu_monitor_text.c | 15

[libvirt] [PATCH v2 3/3] virsh: Implement domblkerror command

2012-01-30 Thread Jiri Denemark
This command lists all disk devices with errors --- tools/virsh.c | 89 +++ tools/virsh.pod |7 2 files changed, 96 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 3a59746..1b93852 100644 ---

[libvirt] [PATCH v2] Support for cpu64-rhel* qemu cpu models

2012-01-30 Thread Martin Kletzander
In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not supported by libvirt. This patch adds the support with the flags specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf --- v2: - removed duplicated entries src/cpu/cpu_map.xml | 66

[libvirt] [PATCH v2 1/3] virDomainGetDiskErrors public API and remote protocol

2012-01-30 Thread Jiri Denemark
We already provide ways to detect when a domain has been paused as a result of I/O error, but there was no way of getting the exact error or even the device that experienced it. This new API may be used for both. --- daemon/remote.c | 40

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Michal Privoznik
On 30.01.2012 15:44, Luiz Capitulino wrote: On Mon, 30 Jan 2012 07:54:56 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/30/2012 06:57 AM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 16:57:01 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 01/26/2012 01:35 PM, Luiz

[libvirt] [PATCH v3] Support for cpu64-rhel* qemu cpu models

2012-01-30 Thread Martin Kletzander
In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not supported by libvirt. This patch adds the support with the flags specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf --- v3: - fixed sse3 naming (it's 'pni' in the features) v2: - removed duplicated entries

Re: [libvirt] [PATCH 1/6] conf: remove duplicate call to VIR_FREE(info-alias)

2012-01-30 Thread Laine Stump
On 01/25/2012 09:54 PM, Eric Blake wrote: On 01/25/2012 09:58 AM, Laine Stump wrote: There is another identical call 4 lines up in the same function. --- src/conf/domain_conf.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Michael Roth
On 01/30/2012 09:58 AM, Eric Blake wrote: On 01/30/2012 07:44 AM, Luiz Capitulino wrote: I think we should do the following then: 1. Drop the set-support-level command 2. Split the guest-suspend command into guest-suspend-ram, guest-suspend-hybrid, guest-suspend-disk 3. Libvirt

Re: [libvirt] [PATCH 3/6] conf: move rombar and bootIndex into virDomainDeviceInfo

2012-01-30 Thread Laine Stump
On 01/25/2012 09:57 PM, Eric Blake wrote: On 01/25/2012 09:58 AM, Laine Stump wrote: To help consolidate the commonality between virDomainHostdevDef and virDomainInterface into as few members as possible (and because I think it makes sense), this patch moves the rombar and bootIndex members

Re: [libvirt] [PATCH 5/6] qemu: (and conf) support rombar for network devices

2012-01-30 Thread Laine Stump
On 01/25/2012 10:18 PM, Eric Blake wrote: On 01/25/2012 08:08 PM, Eric Blake wrote: On 01/25/2012 09:58 AM, Laine Stump wrote: When support for the rombar option was added, it was only added for PCI passthrough devices, configured withhostdev. The same option is available for any network

Re: [libvirt] [PATCH 4/6] conf: relocate rombar and boot order parse/format

2012-01-30 Thread Laine Stump
On 01/25/2012 10:02 PM, Eric Blake wrote: On 01/25/2012 09:58 AM, Laine Stump wrote: Since these two items are now in the virDomainDeviceInfo struct, it makes sense to parse/format them in the functions written to parse/format that structure. Not all types of devices allow them, so two internal

Re: [libvirt] g_error considered harmful

2012-01-30 Thread Christophe Fergeau
On Tue, Jan 17, 2012 at 04:52:19PM +0100, Christophe Fergeau wrote: Looking at what gtk+ does, it has gtk_init which is documented to abort, and gtk_init_check which apps can use when they need this. g_type_init has no _check alternative, but it does a few sanity checks at runtime using

Re: [libvirt] g_error considered harmful

2012-01-30 Thread Marc-André Lureau
On Mon, Jan 30, 2012 at 6:52 PM, Christophe Fergeau cferg...@redhat.com wrote: This mail should be read as a ping? on this series :) /me lost the series, you didn't use the same title or messageid/replyto? -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] g_error considered harmful

2012-01-30 Thread Christophe Fergeau
On Mon, Jan 30, 2012 at 07:05:51PM +0100, Marc-André Lureau wrote: On Mon, Jan 30, 2012 at 6:52 PM, Christophe Fergeau cferg...@redhat.com wrote: This mail should be read as a ping? on this series :) /me lost the series, you didn't use the same title or messageid/replyto? Hmm, I did and

Re: [libvirt] g_error considered harmful

2012-01-30 Thread Marc-André Lureau
Hi In general I agree with the patch series dropping g_error() in favour of normal GError reporting, so programs can cope with errors. However, it removes the forced logging and it's too easy for the caller to ignore them, making it hard to track down when something goes wrong. I think this is

Re: [libvirt] [PATCHv2] simplify block of codes

2012-01-30 Thread Eric Blake
On 01/29/2012 08:54 PM, a...@redhat.com wrote: From: Alex Jia a...@redhat.com Using new function 'virTypedParameterArrayClear' to simplify block of codes. * daemon/remote.c, src/remote/remote_driver.c: simplify codes. Signed-off-by: Alex Jia a...@redhat.com --- daemon/remote.c

Re: [libvirt] g_error considered harmful

2012-01-30 Thread Marc-André Lureau
On Mon, Jan 30, 2012 at 7:22 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: Hi In general I agree with the patch series dropping g_error() in favour of normal GError reporting, so programs can cope with errors. However, it removes the forced logging and it's too easy for the caller

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Mon, 30 Jan 2012 11:07:10 -0600 Michael Roth mdr...@linux.vnet.ibm.com wrote: On 01/30/2012 09:58 AM, Eric Blake wrote: On 01/30/2012 07:44 AM, Luiz Capitulino wrote: I think we should do the following then: 1. Drop the set-support-level command 2. Split the guest-suspend

Re: [libvirt] [Qemu-devel] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Luiz Capitulino
On Mon, 30 Jan 2012 17:08:33 +0100 Michal Privoznik mpriv...@redhat.com wrote: On 30.01.2012 15:44, Luiz Capitulino wrote: On Mon, 30 Jan 2012 07:54:56 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/30/2012 06:57 AM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 16:57:01 -0600

[libvirt] [PATCH] tests: virnettlscontexttest needs gnutls-2.6.0

2012-01-30 Thread Philipp Hahn
virnettlscontexttest uses gnutls_x509_crt_set_subject_alt_name() and GNUTLS_FSAN_APPEND, which - according to http://www.gnu.org/software/gnutls/manual/gnutls.html - are only available since 2.6.0. Since libvirt still works fine with gnutls-1.0.25 from RHEL5, only enable the test when the version

Re: [libvirt] [PATCH 1/2] resize: add virStorageVolResize() API

2012-01-30 Thread Zeeshan Ali (Khattak)
On Mon, Jan 30, 2012 at 5:27 PM, Daniel P. Berrange berra...@redhat.com wrote: On Mon, Jan 30, 2012 at 08:23:36AM -0700, Eric Blake wrote: On 01/30/2012 07:28 AM, Daniel P. Berrange wrote: Why has this changed from 'unsigned long long' to just 'long long'. Because of

[libvirt] [PATCH] tests: dynamically replace dnsmasq path

2012-01-30 Thread Philipp Hahn
The path to the dnsmasq binary can be configured while in the test data the path is hard-coded to /usr/bin/. This break the test suite if a the binary is located in a different location, like /usr/local/sbin/. Replace the hard coded path in the test data by a token, which is dynamically replaced

[libvirt] [PATCH] XenXs: Update documentation

2012-01-30 Thread Philipp Hahn
Fix several references to now renamed functions and parameters when the functions were moved from src/xen/ to src/xenxs/. Signed-off-by: Philipp Hahn h...@univention.de --- src/xenxs/xen_sxpr.c | 222 + 1 files changed, 185 insertions(+), 37

[libvirt] [PATCH] resize: slightly alter signature

2012-01-30 Thread Eric Blake
Our existing virDomainBlockResize takes an unsigned long long argument; if that command is later taught a DELTA and SHRINK flag, we cannot change its type without breaking API (but at least such a change would be ABI compatible). Meanwhile, the only time a negative size makes sense is if both

Re: [libvirt] [PATCH] tests: virnettlscontexttest needs gnutls-2.6.0

2012-01-30 Thread Eric Blake
On 01/30/2012 10:44 AM, Philipp Hahn wrote: virnettlscontexttest uses gnutls_x509_crt_set_subject_alt_name() and GNUTLS_FSAN_APPEND, which - according to http://www.gnu.org/software/gnutls/manual/gnutls.html - are only available since 2.6.0. Since libvirt still works fine with gnutls-1.0.25

Re: [libvirt] [PATCH libvirt 3/6] Fix warnings about pid_t printf format on mingw64

2012-01-30 Thread Marc-André Lureau
On Thu, Jan 26, 2012 at 11:28 AM, Daniel P. Berrange berra...@redhat.com wrote: On Wed, Jan 25, 2012 at 05:54:19PM -0700, Eric Blake wrote: On 01/25/2012 05:22 PM, Marc-André Lureau wrote: the decision should _not_ be based on _WIN64, but instead on a configure-time test on the underlying

Re: [libvirt] RFC: setting mac address on network devices being assigned to a guest via PCI passthrough (hostdev)

2012-01-30 Thread Laine Stump
On 01/23/2012 09:08 AM, Paolo Bonzini wrote: devices interface type='hostdev' source address type='pci' bus='0x06' slot='0x02' function='0x0'/ /source mac address='00:16:3e:5d:c7:9e'/ address type='pci' .../ /interface /devices This is the model that I'm now following. Looking further into

Re: [libvirt] [PATCH] tests: dynamically replace dnsmasq path

2012-01-30 Thread Eric Blake
On 01/30/2012 10:13 AM, Philipp Hahn wrote: The path to the dnsmasq binary can be configured while in the test data the path is hard-coded to /usr/bin/. This break the test suite if a the binary is located in a different location, like /usr/local/sbin/. Replace the hard coded path in the

Re: [libvirt] [PATCH libvirt 3/6] Fix warnings about pid_t printf format on mingw64

2012-01-30 Thread Eric Blake
On 01/30/2012 12:15 PM, Marc-André Lureau wrote: But we can use 'lld' because we made sure all libvirt code goes via the gnulib printf replacements which guarentee %lld works correctly. Actually, it doesn't. The replacement is provided by the module stdio which isn't used (or perhaps

Re: [libvirt] [PATCH] XenXs: Update documentation

2012-01-30 Thread Eric Blake
On 01/17/2012 01:26 AM, Philipp Hahn wrote: Fix several references to now renamed functions and parameters when the functions were moved from src/xen/ to src/xenxs/. Signed-off-by: Philipp Hahn h...@univention.de --- src/xenxs/xen_sxpr.c | 222

Re: [libvirt] [PATCH] qemu: never send SIGKILL to qemu process unless specifically requested

2012-01-30 Thread Laine Stump
On 01/30/2012 06:02 AM, Daniel P. Berrange wrote: On Fri, Jan 27, 2012 at 01:35:35PM -0500, Laine Stump wrote: When libvirt is shutting down the qemu process, it first sends SIGTERM, then waits for 1.6 seconds and, if it sees the process still there, sends a SIGKILL. There have been reports

Re: [libvirt] [RFC Incomplete Patch] Libvirt + Openvswitch

2012-01-30 Thread Dan Wendlandt
Hi Kyle! Funny how we keep bumping into each other... I hope you're keeping warm in Minnesota :) On Fri, Jan 27, 2012 at 11:22 AM, kmestery kmest...@cisco.com wrote: Hi Dan: We at Cisco have been looking at this as well, and in fact were going to propose some things in this area as well.

Re: [libvirt] [RFC Incomplete Patch] Libvirt + Openvswitch

2012-01-30 Thread kmestery
On Jan 30, 2012, at 2:41 PM, Dan Wendlandt wrote: Hi Kyle! Funny how we keep bumping into each other... I hope you're keeping warm in Minnesota :) On Fri, Jan 27, 2012 at 11:22 AM, kmestery kmest...@cisco.com wrote: Hi Dan: We at Cisco have been looking at this as well, and in fact were

Re: [libvirt] [PATCH 1/4] conf: add rawio attribute to disk element of domain XML

2012-01-30 Thread Eric Blake
On 01/30/2012 02:08 AM, Taku Izumi wrote: This patch adds a new attribute rawio to the disk element of domain XML. Valid values of rawio attribute are yes and no. rawio='yes' indicates the disk is desirous of CAP_SYS_RAWIO. If you specify the following XML: disk type='block'

Re: [libvirt] [PATCHv3] network: Avoid memory leaks on networkBuildDnsmasqArgv

2012-01-30 Thread Eric Blake
[reordering - top-posting is hard to follow] On 01/30/2012 08:11 AM, Alex Jia wrote: @@ -530,10 +532,6 @@ networkBuildDnsmasqArgv(virNetworkObjPtr network, for (i = 0; i dns-nsrvrecords; i++) { char *record = NULL; -char *recordPort = NULL; -

[libvirt] Public API Change Advice

2012-01-30 Thread Phantomcircuit
I'd like to add a simple flag to virStorageVolWipe to use O_DIRECT. What's the proper way to add such a flag? smime.p7s Description: S/MIME Cryptographic Signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Public API Change Advice

2012-01-30 Thread Eric Blake
On 01/30/2012 03:11 PM, Phantomcircuit wrote: I'd like to add a simple flag to virStorageVolWipe to use O_DIRECT. What's the proper way to add such a flag? Best is to copy by example :) Here's a recent patch that added a new flag to the public API, exposed the new flag in virsh, and

Re: [libvirt] [PATCH v2 1/3] virDomainGetDiskErrors public API and remote protocol

2012-01-30 Thread Eric Blake
On 01/30/2012 09:00 AM, Jiri Denemark wrote: We already provide ways to detect when a domain has been paused as a result of I/O error, but there was no way of getting the exact error or even the device that experienced it. This new API may be used for both. --- daemon/remote.c

Re: [libvirt] [PATCH v2 2/3] qemu: Implement virDomainGetDiskErrors

2012-01-30 Thread Eric Blake
On 01/30/2012 09:01 AM, Jiri Denemark wrote: --- src/qemu/qemu_conf.h |1 + src/qemu/qemu_driver.c | 83 ++ src/qemu/qemu_monitor.c | 40 src/qemu/qemu_monitor.h |1 +

Re: [libvirt] [PATCH v2 3/3] virsh: Implement domblkerror command

2012-01-30 Thread Eric Blake
On 01/30/2012 09:01 AM, Jiri Denemark wrote: This command lists all disk devices with errors --- tools/virsh.c | 89 +++ tools/virsh.pod |7 2 files changed, 96 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c

Re: [libvirt] [PATCHv2 1/4] xml: Add element title to allow short description of domains

2012-01-30 Thread Eric Blake
On 01/30/2012 08:09 AM, Peter Krempa wrote: This patch adds a new element title to the domain XML. This attribute can hold a short title defined by the user to ease the identification of domains. The title contain newlines and should be reasonably short. s/title contain/title may not contain/

Re: [libvirt] [PATCHv2 2/4] API: Add api to set and get domain metadata

2012-01-30 Thread Eric Blake
On 01/30/2012 08:09 AM, Peter Krempa wrote: This patch adds API to modify domain metadata for running and stopped domains. The api supports changing description, title as well as the newly added metadata element. The API has support for storing data in the metadata element using xml

Re: [libvirt] RFC: setting mac address on network devices being assigned to a guest via PCI passthrough (hostdev)

2012-01-30 Thread Roopa Prabhu
On 1/30/12 11:14 AM, Laine Stump la...@laine.org wrote: On 01/23/2012 09:08 AM, Paolo Bonzini wrote: devices interface type='hostdev' source address type='pci' bus='0x06' slot='0x02' function='0x0'/ /source mac address='00:16:3e:5d:c7:9e'/ address type='pci' .../ /interface

[libvirt] [PATCH v2 0/4] RFC: grant KVM guest rawio capability

2012-01-30 Thread Taku Izumi
This is the new version of http://www.redhat.com/archives/libvir-list/2012-January/msg01312.html Thank you for reviewing, Danie, Paolo, and Eric. -- This patchset achieves #1 and #2 of the following tasks: 1. rawio=yes|nmo on the disk element somewhere 2. Give the QEMU process

[libvirt] [PATCH v2 1/4] conf: add rawio attribute to disk element of domain XML

2012-01-30 Thread Taku Izumi
This patch adds a new attribute rawio to the disk element of domain XML. Valid values of rawio attribute are yes and no. rawio='yes' indicates the disk is desirous of CAP_SYS_RAWIO. If you specify the following XML: disk type='block' device='lun' rawio='yes' ... /disk the domain

[libvirt] [PATCH v2 4/4] qemu: make qemu processes to retain rawio capability

2012-01-30 Thread Taku Izumi
This patch revises qemuProcessStart() function for qemu processes to retain CAP_SYS_RAWIO if needed. And in case of that, add taint flag to domain. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com Signed-off-by: Shota Hirae m11g1...@hibikino.ne.jp --- src/qemu/qemu_domain.c |3 +++

[libvirt] [PATCH v2 2/4] util: add functions to keep capabilities

2012-01-30 Thread Taku Izumi
This patch introduces virSetCapabilities() function and implements virCommandAllowCap() function. Existing virClearCapabilities() is function to clear all capabilities. Instead virSetCapabilities() is function to set arbitrary capabilities. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com

[libvirt] [PATCH v2 3/4] util: extend virExecWithHook()

2012-01-30 Thread Taku Izumi
This patch extends virExecWithHook() to receive capability information. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com Signed-off-by: Shota Hirae m11g1...@hibikino.ne.jp --- src/util/command.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) Index:

Re: [libvirt] [PATCHv3] network: Avoid memory leaks on networkBuildDnsmasqArgv

2012-01-30 Thread Alex Jia
On 01/31/2012 05:34 AM, Eric Blake wrote: [reordering - top-posting is hard to follow] On 01/30/2012 08:11 AM, Alex Jia wrote: @@ -530,10 +532,6 @@ networkBuildDnsmasqArgv(virNetworkObjPtr network, for (i = 0; i dns-nsrvrecords; i++) { char *record = NULL; -