[libvirt] [PATCH][PowerPC] Implement sysinfo for libvirt on PowerPC

2012-02-09 Thread Prerna Saxena
From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Tue, 7 Feb 2012 16:55:26 +0530 Subject: [PATCH] Implement sysinfo on PowerPC. Libvirt on x86 parses 'dmidecode' to gather characteristics of host system, which are then reflected to libvirt users by virSysinfoRead(), invoked by 'virsh sysinfo'.

Re: [libvirt] [virt-tools-list] Provision through virt-manager not supported on para-virtualized Xen?

2012-02-09 Thread Cheer Xiao
2012/2/7 Cole Robinson crobi...@redhat.com: On 02/06/2012 08:01 AM, Cheer Xiao wrote: 2012/2/6 Cheer Xiao xiaqq...@gmail.com: 2012/2/5 Cheer Xiao xiaqq...@gmail.com: 2012/2/4 Cole Robinson crobi...@redhat.com: ... [snip] ... Okay, none of that indicates why it isn't working. I can't

Re: [libvirt] RFC: API to report guest IP address(es)

2012-02-09 Thread Daniel P. Berrange
On Wed, Feb 08, 2012 at 12:30:16PM +0100, Michal Privoznik wrote: Hi, Now we have qemu guest agent it is possible for us to: 1) extend guest agent to report IP addresses (not trivial among OSes). 2) Write API which will report these to mgmt application. One thing that I am not sure

[libvirt] [Bug] [vbox-driver] attach-device

2012-02-09 Thread Gravok
Hi, using the version from git I can't attach devices to my domain (using attach-device) neither using the virsh or a language binding. In both cases it throws a OutOfMemory exception. It gets thrown in vbox_tmpl.c:5340, although I got 7gb of RAM left. Am I doing something wrong, or is this a

[libvirt] [PATCH 6/5 V5] GetCPUStats: fix overflow test

2012-02-09 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- src/libvirt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 8035add..a55d823 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -18541,7 +18541,7 @@ int

[libvirt] [PATCH 4/5 V5] qemu driver for virDomainGetCPUstats using cpuacct cgroup.

2012-02-09 Thread Lai Jiangshan
From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com * Now, only cpu_time is supported. * cpuacct cgroup is used for providing percpu cputime information. * include/libvirt/libvirt.h.in - defines VIR_DOMAIN_CPU_STATS_CPUTIME * src/qemu/qemu.conf - take care of cpuacct cgroup. *

[libvirt] [PATCH 5/5 V5] cpu-accts command shows cpu accounting information of a domain.

2012-02-09 Thread Lai Jiangshan
From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Total: cpu_time15.8 CPU0: cpu_time8.6 CPU1: cpu_time3.5 CPU2: cpu_time2.4 CPU3: cpu_time1.3 --- tools/virsh.c | 116

[libvirt] [PATCH 3/5 V5] add nodeGetCPUmap() for getting available CPU IDs in a bitmap.

2012-02-09 Thread Lai Jiangshan
From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com add virBitmapParseCommaSeparetedFormat() for parsing bitmap in comma separeted ascii format. This format of bitmap is used in Linux sysfs and cpuset. Changelog: - fixed typos. - fixed string scan routine. Signed-off-by: KAMEZAWA

[libvirt] [PATCHv2 1/3] Support clock=variable relative to localtime

2012-02-09 Thread Philipp Hahn
Since Xen 3.1 the clock=variable semantic is supported. In addition to qemu/kvm Xen also knows about a variant where the offset is relative to 'localtime' instead of 'utc'. Extends the libvirt structure with a flag to specify, if the offset is relative to 'localtime' or 'utc'. Adapt the only user

[libvirt] [PATCHv2 3/3] Xen: Adapt clock tests

2012-02-09 Thread Philipp Hahn
localtime = 0 is always inserted, because otherwise on updates the value is not changed within XenD. Some statements change their order becaus code was moved around. Signed-off-by: Philipp Hahn h...@univention.de --- tests/xmconfigdata/sexpr2xml-pv-bootloader.cfg |1 +

[libvirt] [PATCHv2 2/3] Xen: Fix clock handling

2012-02-09 Thread Philipp Hahn
XenD-3.1 introduced managed domains. HV-domains have rtc_timeoffset (hgd24f37b31030 from 2007-04-03), which tracks the offset between the hypervisors clock and the domains RTC, and is persisted by XenD. In combination with localtime=1 this had a bug until XenD-3.4 (hg5d701be7c37b from 2009-04-01)

[libvirt] [PATCHv2 0/3] Xen: Fix clock handling

2012-02-09 Thread Philipp Hahn
Before version 3.1 xen only implemented clock/@offset='utc' and 'localtime'. With the introduction of managed domains in 3.1 xend keeps track of the rtc_timeoffset, even over reboots. This translates to libvirts clock/@offset='variable' variant. Be advised that only HV domains have a RTC. In

Re: [libvirt] RFC: API to report guest IP address(es)

2012-02-09 Thread Laine Stump
On 02/09/2012 04:36 AM, Daniel P. Berrange wrote: On Wed, Feb 08, 2012 at 12:30:16PM +0100, Michal Privoznik wrote: Hi, Now we have qemu guest agent it is possible for us to: 1) extend guest agent to report IP addresses (not trivial among OSes). 2) Write API which will report these to mgmt

[libvirt] [PATCH] Fixed URI parsing

2012-02-09 Thread Martin Kletzander
Function virParseURI was added. This function is wrapper around xmlParseURI. In this wrapper we are fixing what doesn't seems to be fixed in libxml2 in the near future. The wrapper is written in such way that if anything gets fixed in libxml2, it'll still work. File changes: - src/util/xml.h

[libvirt] [PATCH] Cleanup of the quick dirty fix from last week

2012-02-09 Thread Martin Kletzander
I tried lots of different solutions and this seems like the most clean and readable one. --- src/lxc/lxc_container.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index e93fda5..c55f264 100644 ---

Re: [libvirt] [virt-tools-list] Provision through virt-manager not supported on para-virtualized Xen?

2012-02-09 Thread Cole Robinson
On 02/09/2012 04:18 AM, Cheer Xiao wrote: 2012/2/7 Cole Robinson crobi...@redhat.com: On 02/06/2012 08:01 AM, Cheer Xiao wrote: 2012/2/6 Cheer Xiao xiaqq...@gmail.com: 2012/2/5 Cheer Xiao xiaqq...@gmail.com: 2012/2/4 Cole Robinson crobi...@redhat.com: ... [snip] ... Okay, none of that

[libvirt] [PATCH v4 1/1] util: Add netlink event handling to virnetlink.c

2012-02-09 Thread D. Herrendoerfer
From: D. Herrendoerfer d.herrendoer...@herrendoerfer.name This code adds a netlink event interface to libvirt. It is based upon the event_poll code and makes use of it. An event is generated for each netlink message sent to the libvirt pid. Signed-off-by: D. Herrendoerfer

[libvirt] [PATCH v4 0/1] Add netlink events to virnetlink

2012-02-09 Thread D. Herrendoerfer
From: D. Herrendoerfer d.herrendoer...@herrendoerfer.name This is the updated netlink event code based upon the updated virnetlink.[ch] files. Most of the previous remarks have been addressed. This has also seen some preliminary testing. D. Herrendoerfer (1): util: Add netlink event handling

Re: [libvirt] [PATCH] Fixed URI parsing

2012-02-09 Thread Laine Stump
On 02/09/2012 09:43 AM, Martin Kletzander wrote: Function virParseURI was added. This function is wrapper around xmlParseURI. In this wrapper we are fixing what doesn't seems to be fixed in libxml2 in the near future. The wrapper is written in such way that if anything gets fixed in libxml2,

[libvirt] Writing java wrappers to libvirt.java

2012-02-09 Thread Dario Ruiz Lopez
Hello, I am trying to write a java wrapper that could allow to expand current libvirt support for java to intercept invocations to the driver so new functionality can be added, for instance, automatically sending an accounting log of all libvirt invocations to an external server. With

Re: [libvirt] [PATCH] Fixed URI parsing

2012-02-09 Thread Martin Kletzander
On 02/09/2012 04:38 PM, Laine Stump wrote: On 02/09/2012 09:43 AM, Martin Kletzander wrote: Function virParseURI was added. This function is wrapper around xmlParseURI. In this wrapper we are fixing what doesn't seems to be fixed in libxml2 in the near future. The wrapper is written in such

Re: [libvirt] [PATCH] Fixed URI parsing

2012-02-09 Thread Laine Stump
On 02/09/2012 11:48 AM, Martin Kletzander wrote: On 02/09/2012 04:38 PM, Laine Stump wrote: On 02/09/2012 09:43 AM, Martin Kletzander wrote: Function virParseURI was added. This function is wrapper around xmlParseURI. In this wrapper we are fixing what doesn't seems to be fixed in libxml2 in

Re: [libvirt] [PATCH] Fixed URI parsing

2012-02-09 Thread Eric Blake
On 02/09/2012 10:53 AM, Laine Stump wrote: memmove(ret-server, ret-server+1, last-1) I know about memmove(), it's just that in this case I really didn't like that it copes the string somewhere else and than again back (in case of overlapping) but no problem to change this :-)

[libvirt] [PATCH] Remove single quotes from audit records

2012-02-09 Thread Marcelo Cerri
Some audit records generated by libvirt contain fields enclosed by single quotes. Since those fields are inside the msg field, which is enclosed by single quotes, these records generated by libvirt are not correctly parsed by libauparse. --- src/conf/domain_audit.c |4 ++-- 1 files changed, 2

[libvirt] Downloading and wiping assumes volume is a device or file

2012-02-09 Thread Wido den Hollander
Hi, I'm still working on the RBD (RADOS / Ceph) storage driver for libvirt and I noticed the virStorageVolDownload and virStorageVolWipe methods. I assumed those would be passed on to the storage backend, but it doesn't. In the storageDriver the method storageVolumeDownload simply opens a

Re: [libvirt] Downloading and wiping assumes volume is a device or file

2012-02-09 Thread Eric Blake
On 02/09/2012 01:04 PM, Wido den Hollander wrote: Hi, I'm still working on the RBD (RADOS / Ceph) storage driver for libvirt and I noticed the virStorageVolDownload and virStorageVolWipe methods. I assumed those would be passed on to the storage backend, but it doesn't. In the

Re: [libvirt] [PATCH] Cleanup of the quick dirty fix from last week

2012-02-09 Thread Eric Blake
On 02/09/2012 08:00 AM, Martin Kletzander wrote: I tried lots of different solutions and this seems like the most clean and readable one. --- src/lxc/lxc_container.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) @@ -511,10 +509,14 @@ static int

Re: [libvirt] [PATCHv2 0/3] Xen: Fix clock handling

2012-02-09 Thread Eric Blake
On 02/09/2012 04:36 AM, Philipp Hahn wrote: Before version 3.1 xen only implemented clock/@offset='utc' and 'localtime'. With the introduction of managed domains in 3.1 xend keeps track of the rtc_timeoffset, even over reboots. This translates to libvirts clock/@offset='variable' variant. Be

Re: [libvirt] [PATCHv2 0/3] Xen: Fix clock handling

2012-02-09 Thread Eric Blake
On 02/09/2012 03:01 PM, Eric Blake wrote: We absolutely cannot reject existing older xml files; but must load them with the semantics that make sense. But a better idea is to represent the XML in a way where the default conversion makes sense, but where a user can explicitly change the XML

Re: [libvirt] [Bug] [vbox-driver] attach-device

2012-02-09 Thread Eric Blake
On 02/09/2012 03:21 AM, Gravok wrote: Hi, using the version from git I can't attach devices to my domain (using attach-device) neither using the virsh or a language binding. In both cases it throws a OutOfMemory exception. It gets thrown in vbox_tmpl.c:5340, although I got 7gb of RAM

Re: [libvirt] [PATCH][PowerPC] Implement sysinfo for libvirt on PowerPC

2012-02-09 Thread Eric Blake
On 02/09/2012 01:47 AM, Prerna Saxena wrote: From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Tue, 7 Feb 2012 16:55:26 +0530 Subject: [PATCH] Implement sysinfo on PowerPC. Libvirt on x86 parses 'dmidecode' to gather characteristics of host system, which are then reflected to libvirt

Re: [libvirt] [PATCH v6] npiv: Auto-generate WWN if it's not specified

2012-02-09 Thread Eric Blake
On 02/07/2012 07:03 AM, Osier Yang wrote: I don't like this interface - it makes virrandom.c know too much. A better interface would be: virRandomGenerateWWN(char **wwn, const char *oui) where the caller is responsible for determining the appropriate OUI for the hypervisor to be passed in.

Re: [libvirt] [PATCHv5] python: refactoring virTypedParameter conversion for NUMA tuning APIs

2012-02-09 Thread Eric Blake
On 02/08/2012 09:29 PM, Guannan Ren wrote: On 02/09/2012 09:41 AM, Eric Blake wrote: From: Guannan Reng...@redhat.com *getPyVirTypedParameter *setPyVirTypedParameter *virDomainSetNumaParameters *virDomainGetNumaParameters Signed-off-by: Eric

Re: [libvirt] Start of freeze for libvirt-0.9.10 and availability of rc1

2012-02-09 Thread Eric Blake
On 02/06/2012 12:21 AM, Daniel Veillard wrote: We are now entering the freeze for libvirt-0.9.10 Hopefully all the API changes needed for that version are already commited to git head. I have made a release candidate 1 tarball (and associated rpms) at

Re: [libvirt] [PATCH libvirt] domain: add implicit USB controller

2012-02-09 Thread Eric Blake
On 02/08/2012 12:26 AM, Osier Yang wrote: On 2012年02月08日 08:48, Marc-André Lureau wrote: Some tools, such as virt-manager, prefers having the default USB controller explicit in the XML document. This patch makes sure there is one. With this patch, it is now possible to switch from USB1 to

Re: [libvirt] [PATCH 6/5 V5] GetCPUStats: fix overflow test

2012-02-09 Thread Eric Blake
On 02/09/2012 03:43 AM, Lai Jiangshan wrote: Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- src/libvirt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 8035add..a55d823 100644 --- a/src/libvirt.c +++ b/src/libvirt.c

Re: [libvirt] [PATCH] Remove single quotes from audit records

2012-02-09 Thread Osier Yang
On 2012年02月10日 03:06, Marcelo Cerri wrote: Some audit records generated by libvirt contain fields enclosed by single quotes. Since those fields are inside the msg field, which is enclosed by single quotes, these records generated by libvirt are not correctly parsed by libauparse. ---

Re: [libvirt] [PATCH v6] npiv: Auto-generate WWN if it's not specified

2012-02-09 Thread Osier Yang
On 2012年02月10日 07:05, Eric Blake wrote: On 02/07/2012 07:03 AM, Osier Yang wrote: I don't like this interface - it makes virrandom.c know too much. A better interface would be: virRandomGenerateWWN(char **wwn, const char *oui) where the caller is responsible for determining the appropriate

Re: [libvirt] [PATCH 0/4 v2] New command for changing media

2012-02-09 Thread Osier Yang
ping? On 2012年02月03日 17:23, Osier Yang wrote: [PATCH 0/4] introduces two new helper functions: vshFindDisk is to find the disk XML node in xml doc with the flags (indicates it's normal disk or changeable disk). VshPrepareDiskXML is to prepare the disk XML for disk changing commands' use, such

Re: [libvirt] [PATCHv5] python: refactoring virTypedParameter conversion for NUMA tuning APIs

2012-02-09 Thread Guannan Ren
On 02/10/2012 07:22 AM, Eric Blake wrote: On 02/08/2012 09:29 PM, Guannan Ren wrote: On 02/09/2012 09:41 AM, Eric Blake wrote: From: Guannan Reng...@redhat.com *getPyVirTypedParameter *setPyVirTypedParameter *virDomainSetNumaParameters

[libvirt] [PATCH] rpc: Plug memory leaks on doRemoteOpen() failure path

2012-02-09 Thread ajia
From: Alex Jia a...@redhat.com Detected by valgrind. Leaks are introduced in commit c1b2264. * src/remote/remote_driver.c (doRemoteOpen): free client program memory in failure path. * How to reproduce? % valgrind -v --leak-check=full virsh -c qemu: * Actual result ==3969== 40 bytes in 1

Re: [libvirt] [PATCH][PowerPC] Implement sysinfo for libvirt on PowerPC

2012-02-09 Thread Prerna Saxena
Hi Eric, Thanks for taking a look. On 02/10/2012 04:33 AM, Eric Blake wrote: On 02/09/2012 01:47 AM, Prerna Saxena wrote: From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Tue, 7 Feb 2012 16:55:26 +0530 Subject: [PATCH] Implement sysinfo on PowerPC. Libvirt on x86 parses 'dmidecode' to

Re: [libvirt] [PATCH] rpc: Plug memory leaks on doRemoteOpen() failure path

2012-02-09 Thread Alex Jia
On 02/10/2012 02:28 PM, Osier Yang wrote: On 2012年02月10日 13:57, a...@redhat.com wrote: From: Alex Jiaa...@redhat.com Detected by valgrind. Leaks are introduced in commit c1b2264. * src/remote/remote_driver.c (doRemoteOpen): free client program memory in failure path. * How to reproduce? %

[libvirt] [PATCHv2] python: Expose virDomain{G, S}etInterfaceParameters' APIs in python binding

2012-02-09 Thread ajia
From: Alex Jia a...@redhat.com The v2 patch to follow latest python binding codes change. An simple example to show how to use it: #!/usr/bin/env python import libvirt conn = libvirt.open(None) dom = conn.lookupByName('foo') print dom.interfaceParameters('vnet0', 0) params =