On Tue, Feb 14, 2012 at 02:10:37PM -0700, Eric Blake wrote:
Meta-question - if the XML requests secure, but TLS is disabled, should
we instead be failing to start the domain with a complaint that we can't
honor the XML?
Meta-non-answer, when a TLS port is set but TLS is disabled in the config
From: Alex Jia a...@redhat.com
* src/qemu/qemu_process.c (qemuFindAgentConfig): avoid crash libvirtd due to
deref a NULL pointer.
* How to reproduce?
1. virsh edit the following xml into guest configuration:
channel type='pty'
target type='virtio'/
address type='virtio-serial'
On 14.02.2012 23:52, Eric Blake wrote:
Leak introduced in commit bb2eddc6.
* daemon/remote.c (remoteDispatchAuthPolkit): Also free pkout on
success.
---
daemon/remote.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
ACK
--
libvir-list mailing list
libvir-list@redhat.com
On 14.02.2012 21:48, Eric Blake wrote:
Bug introduced in commit 35abced. On an inactive domain,
$ virsh snapshot-create-as dom snap
$ virsh snapshot-create dom
$ virsh snapshot-create dom
$ virsh snapshot-delete --children dom snap
could crash libvirtd, due to a use-after-free that results
On Tue, Feb 14, 2012 at 03:17:40PM -0700, Eric Blake wrote:
On 02/14/2012 01:37 AM, Martin Kletzander wrote:
Hello everyone,
I have a small bug #786770 [1] assigned and I discussed this with few
people from our team but I'm still not sure what should be the proper
fix for this bug.
On 14.02.2012 17:45, Michal Privoznik wrote:
This is basically v3 for:
https://www.redhat.com/archives/libvir-list/2012-February/msg00533.html
This time, I've split it into 2 patches so it can be reviewed easier.
Michal Privoznik (2):
qemu: Set capabilities based on supported monitor
On Wed, Feb 15, 2012 at 02:44:18PM +0800, Wen Congyang wrote:
Hi all:
If the guest runs on xen, we can know the guest OS paniced, and the guest
status
is paniced. But if the guest runs on qemu/kvm, we need the same feature. And
the
feature to know guest-is-panic is a very very good
In case libvirtd cannot detect host CPU model (which may happen if it
runs inside a virtual machine), the daemon is likely to segfault when
starting a new qemu domain. It segfaults when domain XML asks for host
(either model or passthrough) CPU or does not ask for any specific CPU
model at all.
From: Daniel P. Berrange berra...@redhat.com
---
libvirt-glib/libvirt-glib-event.c |4
libvirt-glib/libvirt-glib-main.c |4
libvirt-gobject/libvirt-gobject-compat.h |5 +
libvirt-gobject/libvirt-gobject-manager.c |1 +
4 files changed, 14
I haven't tested it but it looks good, so ACK
Christophe
On Wed, Feb 15, 2012 at 12:10:27PM +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
---
libvirt-glib/libvirt-glib-event.c |4
libvirt-glib/libvirt-glib-main.c |4
[...]we'd need to know what XML string
you are passing to attach-device
?xml version=1.0 encoding=UTF-8 standalone=no?
device
disk device=cdrom type=file
source file=/tmp/foo.iso/
target dev=hdc/
readonly/
/disk
/device
If I run it without the first line, I get an unexptected error.
and you
On 02/15/2012 11:57 AM, Daniel P. Berrange wrote:
On Tue, Feb 14, 2012 at 03:17:40PM -0700, Eric Blake wrote:
On 02/14/2012 01:37 AM, Martin Kletzander wrote:
Hello everyone,
I have a small bug #786770 [1] assigned and I discussed this with few
people from our team but I'm still not sure
# libvirtd --version
libvirtd (libvirt) 0.9.8
# which ebtables
/sbin/ebtables
2012-02-15 09:40:59.083+: 17675: error :
ebtablesCreateRuleInstance:1943 : internal error cannot create rule
since ebtables tool is missing.
2012-02-15 09:40:59.107+: 17675: error : virNetDevGetIndex:656 :
When initializing libvirt shared library, calling virOnce
to make load hypervisor drivers and create thread local key
only once.
---
src/libvirt.c | 131 +++
src/util/threads-pthread.c |8 ++-
2 files changed, 64
# libvirtd --version
libvirtd (libvirt) 0.9.8
# which ebtables
/sbin/ebtables
2012-02-15 09:40:59.083+: 17675: error :
ebtablesCreateRuleInstance:1943 : internal error cannot create rule
since ebtables tool is missing.
2012-02-15 09:40:59.107+: 17675: error : virNetDevGetIndex:656 :
From: Daniel P. Berrange berra...@redhat.com
If attempting to run
ssh root@somehost virsh console someguest
You'll get an error
2012-02-15 13:11:47.683+: 4765: info : libvirt version: 0.9.10, package:
1.fc18 (Unknown, 2012-02-15-11:48:57, lettuce.camlab.fab.redhat.com)
2012-02-15
Currently, if scrub (used for wiping algorithms) is not present
at compile time, we don't support any other wiping algorithms than
zeroing, even if it was installed later. Switch to runtime detection
instead.
---
diff to v1:
-Add BuildRequires to spec file
configure.ac | 30
On Wed, Feb 15, 2012 at 13:16:05 +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If attempting to run
ssh root@somehost virsh console someguest
You'll get an error
2012-02-15 13:11:47.683+: 4765: info : libvirt version: 0.9.10,
package: 1.fc18
On 02/13/2012 10:57 AM, Martin Kletzander wrote:
But as I say, I think this is the worst option considering the real
problem is with brackets around IPv6 in libxml2 and fixing it there
would save us from dealing with lots of bugs.
Let's suppose bug #624626 [1] will be fixed soon. Is there a
On Wed, Feb 15, 2012 at 03:05:34PM +0100, Martin Kletzander wrote:
On 02/13/2012 10:57 AM, Martin Kletzander wrote:
But as I say, I think this is the worst option considering the real
problem is with brackets around IPv6 in libxml2 and fixing it there
would save us from dealing with lots of
On Wed, Feb 15, 2012 at 10:08:24AM +0100, Christophe Fergeau wrote:
On Tue, Feb 14, 2012 at 02:10:37PM -0700, Eric Blake wrote:
Meta-question - if the XML requests secure, but TLS is disabled, should
we instead be failing to start the domain with a complaint that we can't
honor the XML?
This is counterpart for virDomainPMSuspendForDuration API which
we have already in. It allows user to wake up guest from S3 state.
1/3 is already ACKed, but I am sending it for the completeness sake.
Michal Privoznik (3):
Introduce virDomainPMWakeup API
virsh: Expose virDomainPMWakeup
---
tools/virsh.c | 46 ++
tools/virsh.pod |6 ++
2 files changed, 52 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 66ba61c..4971e36 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -2436,6 +2436,50 @@
using 'system-wakeup' monitor command. It is supported only in JSON,
as we are enabling it if possible. Moreover, this command is available
in qemu-1.1+ which definitely has JSON.
---
src/qemu/qemu_driver.c | 55 ++
src/qemu/qemu_monitor.c |
This API allows a domain which previously called
virDomainPMSuspendForDuration() to be woken up.
---
include/libvirt/libvirt.h.in |2 +
src/driver.h |4 +++
src/libvirt.c| 50 ++
src/libvirt_public.syms |1
On 15.02.2012 16:04, Michal Privoznik wrote:
This API allows a domain which previously called
virDomainPMSuspendForDuration() to be woken up.
---
include/libvirt/libvirt.h.in |2 +
src/driver.h |4 +++
src/libvirt.c| 50
On Wed, Feb 15, 2012 at 09:59:57AM -0500, Dave Allan wrote:
On Wed, Feb 15, 2012 at 10:08:24AM +0100, Christophe Fergeau wrote:
On Tue, Feb 14, 2012 at 02:10:37PM -0700, Eric Blake wrote:
Meta-question - if the XML requests secure, but TLS is disabled, should
we instead be failing to
On 02/13/2012 07:32 AM, Jiri Denemark wrote:
On Fri, Feb 10, 2012 at 11:22:09 -0700, Eric Blake wrote:
On 01/30/2012 09:25 AM, Martin Kletzander wrote:
In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not
supported by libvirt. This patch adds the support with the flags
When migrating a qemu domain, we enter the monitor, send some commands,
try to connect to destination qemu, send other commands, end exit the
monitor. However, if we couldn't connect to destination qemu we forgot
to exit the monitor.
Bug introduced by commit
On 02/13/2012 07:56 PM, a...@redhat.com wrote:
From: Alex Jia a...@redhat.com
The v3 patch to follow latest python binding codes and change 'size'
type from int to Py_ssize_t.
static PyObject *
+libvirt_virDomainSetInterfaceParameters(PyObject *self ATTRIBUTE_UNUSED,
+
Eric, yes, I haven't noticed it:( and will fix them on v4.
Thanks,
Alex
- Original Message -
From: Eric Blake ebl...@redhat.com
To: a...@redhat.com
Cc: libvir-list@redhat.com
Sent: Thursday, February 16, 2012 12:04:14 AM
Subject: Re: [libvirt] [PATCHv3] python: Expose virDomain{G,
On Wed, Feb 15, 2012 at 03:10:47PM +, Daniel P. Berrange wrote:
It enables you to turn on TLS for all guests, regardless of the
domain XML configuration, which is a desirable policy control
knob for a host level administrator to have.
I'm under the impression that it's doing the opposite
From: Alex Jia a...@redhat.com
The v4 patch corrects indentation issues.
The v3 patch follows latest python binding codes and change 'size'
type from int to Py_ssize_t.
An simple example to show how to use it:
#!/usr/bin/env python
import libvirt
conn = libvirt.open(None)
dom =
On 02/15/2012 04:33 AM, Jiri Denemark wrote:
In case libvirtd cannot detect host CPU model (which may happen if it
runs inside a virtual machine), the daemon is likely to segfault when
starting a new qemu domain.
Nested virt - what fun.
It segfaults when domain XML asks for host
(either
Eric Blake wrote:
Regression introduced in commit 7033c5f2, due to improper conversion
from snprintf to virAsprintf.
* daemon/remote.c (remoteDispatchAuthList): Check return value
correctly.
---
This one's embarrassing. I think I broke polkit authorization in
0.9.10. :(
Yes, you
On 02/15/2012 09:36 AM, Christophe Fergeau wrote:
On Wed, Feb 15, 2012 at 03:10:47PM +, Daniel P. Berrange wrote:
It enables you to turn on TLS for all guests, regardless of the
domain XML configuration, which is a desirable policy control
knob for a host level administrator to have.
On 02/07/2012 01:26 PM, Eric Blake wrote:
ACK series from me; although I'm a bit biased (having written half the
first patch before you reworked it), so you still might feedback from
danpb before pushing.
Now that 0.9.10 is out, I've pushed both of these patches. This will
give us some time
On 02/14/2012 09:26 PM, Laine Stump wrote:
On 02/14/2012 05:33 PM, Eric Blake wrote:
On 02/13/2012 10:56 PM, Laine Stump wrote:
But because an interfaceid is auto-generated by the parser when one
isn't given, and a common parser function for virtualport is used by the
domain and network
On 02/15/2012 08:01 AM, Daniel Veillard wrote:
I completely missed this, I'm not sure I understand comment 2:
paphio:~/XML - testURI --debug 'qemu+ssh://[3ffe::102]/system'
scheme: qemu+ssh
server: [3ffe::102]
path: /system
qemu+ssh://[3ffe::102]/system
paphio:~/XML -
Seems to
On 02/15/2012 06:37 AM, Michal Privoznik wrote:
Currently, if scrub (used for wiping algorithms) is not present
at compile time, we don't support any other wiping algorithms than
zeroing, even if it was installed later. Switch to runtime detection
instead.
---
diff to v1:
-Add BuildRequires
On 02/15/2012 02:27 AM, a...@redhat.com wrote:
From: Alex Jia a...@redhat.com
* src/qemu/qemu_process.c (qemuFindAgentConfig): avoid crash libvirtd due to
deref a NULL pointer.
* How to reproduce?
1. virsh edit the following xml into guest configuration:
channel type='pty'
On 02/15/2012 03:08 AM, Phantomcircuit wrote:
# libvirtd --version
libvirtd (libvirt) 0.9.8
# which ebtables
/sbin/ebtables
2012-02-15 09:40:59.083+: 17675: error :
ebtablesCreateRuleInstance:1943 : internal error cannot create rule
since ebtables tool is missing.
2012-02-15
On 02/15/2012 02:32 AM, Michal Privoznik wrote:
On 14.02.2012 23:52, Eric Blake wrote:
Leak introduced in commit bb2eddc6.
* daemon/remote.c (remoteDispatchAuthPolkit): Also free pkout on
success.
---
daemon/remote.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
ACK
On 02/15/2012 12:21 AM, Wen Congyang wrote:
At 02/15/2012 07:03 AM, Eric Blake Wrote:
Regression introduced in commit 7033c5f2, due to improper conversion
from snprintf to virAsprintf.
* daemon/remote.c (remoteDispatchAuthList): Check return value
correctly.
---
This one's embarrassing.
On 02/15/2012 10:52 AM, Jim Fehlig wrote:
This one's embarrassing. I think I broke polkit authorization in
0.9.10. :(
Yes, you did :).
I also found a segfault and was about to post the attached patch.
Regards,
Jim
0001-Fix-polkit0-authentication.patch
From
On 02/15/2012 02:41 AM, Michal Privoznik wrote:
On 14.02.2012 21:48, Eric Blake wrote:
Bug introduced in commit 35abced. On an inactive domain,
$ virsh snapshot-create-as dom snap
$ virsh snapshot-create dom
$ virsh snapshot-create dom
$ virsh snapshot-delete --children dom snap
could
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Binding for virDomainHasManagedSaveImage().
---
libvirt-gobject/libvirt-gobject-domain.c | 13 +
libvirt-gobject/libvirt-gobject-domain.h |1 +
libvirt-gobject/libvirt-gobject.sym |1 +
3 files changed, 15 insertions(+),
On 02/15/2012 08:04 AM, Michal Privoznik wrote:
This API allows a domain which previously called
virDomainPMSuspendForDuration() to be woken up.
---
include/libvirt/libvirt.h.in |2 +
src/driver.h |4 +++
src/libvirt.c| 50
On 02/15/2012 08:04 AM, Michal Privoznik wrote:
---
tools/virsh.c | 46 ++
tools/virsh.pod |6 ++
2 files changed, 52 insertions(+), 0 deletions(-)
ACK.
I'm wondering, though, if we should make this command smarter (as a
followup
Thanks; pushed.
- Original Message -
From: Eric Blake ebl...@redhat.com
To: a...@redhat.com
Cc: libvir-list@redhat.com
Sent: Thursday, February 16, 2012 6:24:14 AM
Subject: Re: [libvirt] [PATCHv4] python: Expose virDomain{G,
S}etInterfaceParameters APIs in python binding
On 02/15/2012
Hi all,
A while back I wrote the attached code to demonstrate how to use
events and serial console to create a serial console that stays up
even when the VM is down. Is it worth adding to the examples? It
might need some work, as I am not terribly strong with Python.
Dave
#!/usr/bin/python -u
On Wed, 15 Feb 2012 11:00:25 +
Daniel P. Berrange berra...@redhat.com wrote:
On Wed, Feb 15, 2012 at 02:44:18PM +0800, Wen Congyang wrote:
Hi all:
If the guest runs on xen, we can know the guest OS paniced, and the guest
status
is paniced. But if the guest runs on qemu/kvm, we
On 02/16/2012 12:57 AM, Eric Blake wrote:
On 02/15/2012 04:33 AM, Jiri Denemark wrote:
In case libvirtd cannot detect host CPU model (which may happen if it
runs inside a virtual machine), the daemon is likely to segfault when
starting a new qemu domain.
Nested virt - what fun.
I want to
Commit 8dd623b9 introduced a build error with --enable-compile-warnings=error
remote.c:2593: error: unused variable 'rv' [-Wunused-variable]
Pushing under build-breaker rule.
---
daemon/remote.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/daemon/remote.c
Eric Blake wrote:
From a06fab953f99e778883618dd0aeaef8da5d5b32a Mon Sep 17 00:00:00 2001
From: Jim Fehlig jfeh...@suse.com
Date: Wed, 15 Feb 2012 10:01:50 -0700
Subject: [PATCH] Fix polkit0 authentication
Commit 7033c5f2 introduced some bugs in polkit0 authentication.
Fix libvirtd segfault
Hi all,
Looking for someone to do a webcast about Libvirt, for the FLOSS Weekly podcast:
http://twit.tv/show/floss-weekly
Preferably someone pretty well known in the Libvirt Community (commit access
maybe?).
Said person must have decent bandwidth for the webcast connection, and be
At 02/16/2012 11:04 AM, KAMEZAWA Hiroyuki Wrote:
On Wed, 15 Feb 2012 11:00:25 +
Daniel P. Berrange berra...@redhat.com wrote:
On Wed, Feb 15, 2012 at 02:44:18PM +0800, Wen Congyang wrote:
Hi all:
If the guest runs on xen, we can know the guest OS paniced, and the guest
status
is
From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com
Changelog:
- fixed typos.
- fixed string scan routine.
Signed-off-by: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
src/libvirt_private.syms |1 +
src/nodeinfo.c |
From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com
* Now, only cpu_time is supported.
* cpuacct cgroup is used for providing percpu cputime information.
* include/libvirt/libvirt.h.in - defines VIR_DOMAIN_CPU_STATS_CPUTIME
* src/qemu/qemu.conf - take care of cpuacct cgroup.
*
Hi, Richard
virt-top and ocaml site patches can work and are completed weeks ago since
public API of libvirt is merged. Could you merged them?
virt-top and ocaml site patches only depend on the public API of libvirt.
but the testing of them may depend on the qemu-driver-site patch of libvirt,
60 matches
Mail list logo
