[libvirt] [PATCH] docs: comments wiping supported algorithms

2012-02-29 Thread Alex Jia
The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page. * tools/virsh.pod: update wiping algorithms docs. Signed-off-by: Alex Jia a...@redhat.com --- tools/virsh.pod |2 ++ 1 files changed, 2 insertions(+), 0

Re: [libvirt] [PATCH] docs: comments wiping supported algorithms

2012-02-29 Thread Alex Jia
On 02/29/2012 04:02 PM, Alex Jia wrote: The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page. * tools/virsh.pod: update wiping algorithms docs. Signed-off-by: Alex Jiaa...@redhat.com --- tools/virsh.pod |2

Re: [libvirt] Need your help with virsh desc

2012-02-29 Thread Zhimou Peng
Hi Eric, I discussed this in my team. And i don't think refuse newlines is a good idea. Description can contains several lines is better. I agree with you of the second one, keep the format of user's input is better(virt-manager shows description too). And i need more information from upstream

Re: [libvirt] [PATCH] docs: comments wiping supported algorithms

2012-02-29 Thread Daniel Veillard
On Wed, Feb 29, 2012 at 04:13:52PM +0800, Alex Jia wrote: On 02/29/2012 04:02 PM, Alex Jia wrote: The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page. * tools/virsh.pod: update wiping algorithms docs.

Re: [libvirt] Need your help with virsh desc

2012-02-29 Thread Daniel Veillard
On Wed, Feb 29, 2012 at 03:08:30AM -0500, Zhimou Peng wrote: Hi Eric, I discussed this in my team. And i don't think refuse newlines is a good idea. Description can contains several lines is better. I agree with you of the second one, keep the format of user's input is better(virt-manager

Re: [libvirt] [PATCH] storage: fix a typo

2012-02-29 Thread Daniel P. Berrange
On Wed, Feb 29, 2012 at 02:21:41PM +0800, Alex Jia wrote: * src/storage/storage_driver.c (storageVolumeWipeInternal): s/shneier/schneier. http://code.google.com/p/diskscrub/ Signed-off-by: Alex Jia a...@redhat.com --- src/storage/storage_driver.c |2 +- 1 files changed, 1

Re: [libvirt] [PATCH] storage: fix a typo

2012-02-29 Thread Peter Krempa
Dňa 29.2.2012 7:21, Alex Jia wrote / napísal(a): * src/storage/storage_driver.c (storageVolumeWipeInternal): s/shneier/schneier. http://code.google.com/p/diskscrub/ Signed-off-by: Alex Jiaa...@redhat.com --- src/storage/storage_driver.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [libvirt] [PATCH] docs: comments wiping supported algorithms

2012-02-29 Thread Daniel P. Berrange
On Wed, Feb 29, 2012 at 04:02:59PM +0800, Alex Jia wrote: The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page. * tools/virsh.pod: update wiping algorithms docs. Signed-off-by: Alex Jia a...@redhat.com ---

Re: [libvirt] [PATCH] docs: comments wiping supported algorithms

2012-02-29 Thread Daniel Veillard
On Wed, Feb 29, 2012 at 08:24:43AM +, Daniel P. Berrange wrote: On Wed, Feb 29, 2012 at 04:02:59PM +0800, Alex Jia wrote: The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page. * tools/virsh.pod:

Re: [libvirt] [PATCH 1/1] complete netlink event integration

2012-02-29 Thread Laine Stump
Since I found a couple other problems, but have made you suffer through enough back and forth already, I've made some final suggested changes myself, and am sending a diff patch as a response to this message (differences from your latest version to mine), as well as doing a repost of the original

[libvirt] [PATCH] Changes squashed into netlink event service patches

2012-02-29 Thread Laine Stump
Squashed into util: Add netlink event handling to virnetlink.c (Note that I am also re-sending the complete patchset with these changes already squashed in). * The remove callback is now an argument of virNetlinnkEventAddClient instead of virNetlinkeRemoveClient, and is stored in the

[libvirt] [PATCHv7 0/2] util: Add netlink event handling code

2012-02-29 Thread Laine Stump
This is hopefully the final spin of these patches, It squashes in all the changes from: https://www.redhat.com/archives/libvir-list/2012-February/msg01103.html as well as: https://www.redhat.com/archives/libvir-list/2012-February/msg01173.html Dirk, please test these out and let me know if

[libvirt] [PATCHv7 1/2] util: Add netlink event handling to virnetlink.c

2012-02-29 Thread Laine Stump
From: D. Herrendoerfer d.herrendoer...@herrendoerfer.name This code adds a netlink event interface to libvirt. It is based upon the event_poll code and makes use of it. An event is generated for each netlink message sent to the libvirt pid. Signed-off-by: D. Herrendoerfer

[libvirt] [PATCHv7 2/2] Add de-association handling to macvlan code

2012-02-29 Thread Laine Stump
From: D. Herrendoerfer d.herrendoer...@herrendoerfer.name Add de-association handling for 802.1qbg (vepa) via lldpad netlink messages. Also adds the possibility to perform an association request without waiting for a confirmation. Signed-off-by: D. Herrendoerfer

Re: [libvirt] [PATCH] docs: comments wiping supported algorithms

2012-02-29 Thread Alex Jia
On 02/29/2012 04:24 PM, Daniel P. Berrange wrote: On Wed, Feb 29, 2012 at 04:02:59PM +0800, Alex Jia wrote: The current scrub version doesn't support pfitzner7, pfitzner33 and schneier patterns on RHEL, we should comment it in virsh man page. * tools/virsh.pod: update wiping algorithms docs.

Re: [libvirt] [PATCH] util: fix a typo

2012-02-29 Thread Alex Jia
On 02/29/2012 04:21 PM, Daniel P. Berrange wrote: On Wed, Feb 29, 2012 at 02:54:38PM +0800, Alex Jia wrote: * src/util/event_poll.c: (virEventPollRunOnce): s/imeout/timeout/. Signed-off-by: Alex Jiaa...@redhat.com --- src/util/event_poll.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [libvirt] [PATCH] storage: fix a typo

2012-02-29 Thread Alex Jia
On 02/29/2012 04:20 PM, Daniel P. Berrange wrote: On Wed, Feb 29, 2012 at 02:21:41PM +0800, Alex Jia wrote: * src/storage/storage_driver.c (storageVolumeWipeInternal): s/shneier/schneier. http://code.google.com/p/diskscrub/ Signed-off-by: Alex Jiaa...@redhat.com ---

Re: [libvirt] [PATCH] build: update to latest gnulib

2012-02-29 Thread Laine Stump
On 02/24/2012 07:39 PM, Eric Blake wrote: It's been a while, and we're between releases, so now's as good a time as any to resync. I didn't notice any showstopper bugs being fixed, but we definitely get some improvements, such as tighter syntax checks. I just noticed this hasn't been

Re: [libvirt] [PATCH 1/3] qemu: require json for block jobs

2012-02-29 Thread Laine Stump
On 02/18/2012 12:44 PM, Eric Blake wrote: Block job commands are not part of upstream qemu until 1.1; and proper support of job completion and cancellation depends on being able to receive QMP events, which implies the JSON monitor. Additionally, some early versions of block job commands were

Re: [libvirt] [PATCH 2/3] qemu: pass block pull backing file to monitor

2012-02-29 Thread Laine Stump
On 02/18/2012 12:44 PM, Eric Blake wrote: This actually wires up the new optional parameter to block_stream: http://wiki.qemu.org/Features/LiveBlockMigration/ImageStreamingAPI The error checking is still sparse, since libvirt must not use qemu-img or header probing on a qcow2 file in use by

Re: [libvirt] [PATCH 3/3] virsh: expose partial pull

2012-02-29 Thread Laine Stump
On 02/18/2012 12:44 PM, Eric Blake wrote: Now virsh can call virDomainBlockRebase. ACK. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Fwd: Re: [libvirt-users] [need your help] Sys::Virt

2012-02-29 Thread Alex Jia
Hi all, Anybody has the same experience? Evaggelos need your help. Thanks Regards, Alex # uname -a Linux mylaptop 3.2.7-1-ARCH #1 SMP PREEMPT Tue Feb 21 16:59:04 UTC 2012 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel GNU/Linux # perl -v This is perl 5, version 14, subversion

Re: [libvirt] [PATCH] qemu: Don't emit tls-port spice option if port is -1

2012-02-29 Thread Jiri Denemark
On Tue, Feb 28, 2012 at 17:17:36 +0100, Michal Privoznik wrote: On 28.02.2012 14:16, Jiri Denemark wrote: Bug introduced by commit eda0fc7a. --- src/qemu/qemu_command.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) ACK Pushed, thanks. Jirka -- libvir-list

[libvirt] [PATCH] storage: fix typo

2012-02-29 Thread Michal Privoznik
* src/storage/storage_driver.c (storageVolumeWipeInternal): s/ pfitzner33/pfitzner33/. --- src/storage/storage_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 540e5d7..9130a40 100644 ---

Re: [libvirt] [PATCH] storage: fix typo

2012-02-29 Thread Daniel P. Berrange
On Wed, Feb 29, 2012 at 11:44:47AM +0100, Michal Privoznik wrote: * src/storage/storage_driver.c (storageVolumeWipeInternal): s/ pfitzner33/pfitzner33/. --- src/storage/storage_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] storage: fix typo

2012-02-29 Thread Michal Privoznik
On 29.02.2012 11:53, Daniel P. Berrange wrote: On Wed, Feb 29, 2012 at 11:44:47AM +0100, Michal Privoznik wrote: * src/storage/storage_driver.c (storageVolumeWipeInternal): s/ pfitzner33/pfitzner33/. --- src/storage/storage_driver.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [libvirt] [PATCH 3/4] libvirt-guests: Check if URI is reachable before launching commands

2012-02-29 Thread Peter Krempa
On 02/29/2012 04:02 AM, Eric Blake wrote: On 02/28/2012 11:00 AM, Peter Krempa wrote: This patch adds a check to the libvirt-guests script to check for the URI to be alive before attempting any calls. This avoids nasty error messages and allows us to fail gracefuly and continue on other URIs

Re: [libvirt] [PATCHv2] Error out when using SPICE TLS with spice_tls=0

2012-02-29 Thread Christophe Fergeau
On Tue, Feb 28, 2012 at 05:04:57PM +0100, Michal Privoznik wrote: On 24.02.2012 11:34, Christophe Fergeau wrote: src/qemu/qemu_command.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index

[libvirt] [PATCH] Fix typo in domain XML documentation

2012-02-29 Thread Christophe Fergeau
s/Modyfing/Modifying --- docs/formatdomain.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 5305f82..9e7dd08 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2580,7 +2580,7 @@

[libvirt] [PATCH v2 1/2] Implement sysinfo on PowerPC.

2012-02-29 Thread Prerna
From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Tue, 7 Feb 2012 16:55:26 +0530 Subject: [PATCH 1/2] Implement sysinfo on PowerPC. Libvirt on x86 parses 'dmidecode' to gather characteristics of host system, which are then reflected to libvirt users by virSysinfoRead(), invoked by 'virsh

Re: [libvirt] [PATCH 2/2] qemu: Add pre-migration hook

2012-02-29 Thread Jiri Denemark
On Tue, Feb 28, 2012 at 17:04:29 -0700, Eric Blake wrote: On 02/28/2012 02:49 PM, Jiri Denemark wrote: This hook is called during the Prepare phase on destination host and may be used for changing domain XML. --- docs/hooks.html.in| 35 +++

Re: [libvirt] [libvirt-glib 1/6] Getters for GVirConfigDomainInterface attributes

2012-02-29 Thread Christophe Fergeau
On Tue, Feb 28, 2012 at 08:25:02PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain-interface.c | 35 libvirt-gconfig/libvirt-gconfig-domain-interface.h |4 ++

[libvirt] [PATCH v2 2/2] Allow x86 to fetch sysinfo from /proc/cpuinfo when dmidecode is absent.

2012-02-29 Thread Prerna
From 98c4f68702bc21060347011144603ee10be4847e Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Thu, 16 Feb 2012 15:33:43 +0530 Subject: [PATCH 2/2] Sysinfo : Allow x86 to fetch sysinfo from /proc/cpuinfo in the event 'dmidecode' is absent in the system. Based on

Re: [libvirt] [libvirt-glib 2/6] Add gvir_domain_disk_resize()

2012-02-29 Thread Christophe Fergeau
ACK On Tue, Feb 28, 2012 at 08:25:03PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Binding for virDomainBlockResize(). --- libvirt-gobject/libvirt-gobject-domain-disk.c | 38 + libvirt-gobject/libvirt-gobject-domain-disk.h

Re: [libvirt] [libvirt-glib 3/6] Add gvir_domain_device_get_domain()

2012-02-29 Thread Christophe Fergeau
On Tue, Feb 28, 2012 at 08:25:04PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Getter for the associated domain of a domain device. NB: it already exists as a gobject property --- libvirt-gobject/libvirt-gobject-domain-device.c | 10 ++

Re: [libvirt] [libvirt-glib 3/6] Add gvir_domain_device_get_domain()

2012-02-29 Thread Christophe Fergeau
On Wed, Feb 29, 2012 at 02:02:08PM +0100, Christophe Fergeau wrote: On Tue, Feb 28, 2012 at 08:25:04PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Getter for the associated domain of a domain device. NB: it already exists as a gobject property

Re: [libvirt] [libvirt-glib 4/6] Add 'config' property to GVirDomainDevice

2012-02-29 Thread Christophe Fergeau
The code to add the property looks good to me except for one minor nit, see below. I'd rather to see patch 6/6 come right after it since I was wondering how config was getting set. On Tue, Feb 28, 2012 at 08:25:05PM +0200, Zeeshan Ali (Khattak) wrote: @@ -144,3 +166,13 @@ virDomainPtr

Re: [libvirt] [libvirt-glib 5/6] Remove now redundant 'path' property

2012-02-29 Thread Christophe Fergeau
On Tue, Feb 28, 2012 at 08:25:06PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Remove now redundant 'path' property from GVirDomainDevice subclasses. --- libvirt-gobject/libvirt-gobject-domain-disk.c | 88

Re: [libvirt] [libvirt-glib 5/6] Remove now redundant 'path' property

2012-02-29 Thread Daniel P. Berrange
On Wed, Feb 29, 2012 at 02:18:31PM +0100, Christophe Fergeau wrote: On Tue, Feb 28, 2012 at 08:25:06PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Remove now redundant 'path' property from GVirDomainDevice subclasses. ---

Re: [libvirt] [libvirt-glib 6/6] Add gvir_domain_get_devices()

2012-02-29 Thread Christophe Fergeau
On Tue, Feb 28, 2012 at 08:25:07PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Currently we only support existing DomainDevice implementations: DomainDisk and DomainInterface. --- .../libvirt-gobject-domain-device-private.h|2 +

Re: [libvirt] [PATCH 1/1] complete netlink event integration

2012-02-29 Thread D. Herrendoerfer
On Feb 29, 2012, at 9:51 AM, Laine Stump wrote: Since I found a couple other problems, but have made you suffer through enough back and forth already, I've made some final suggested changes myself, and am sending a diff patch as a response to this message (differences from your latest

Re: [libvirt] [libvirt-glib 1/6] Getters for GVirConfigDomainInterface attributes

2012-02-29 Thread Zeeshan Ali (Khattak)
On Wed, Feb 29, 2012 at 2:57 PM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Feb 28, 2012 at 08:25:02PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org ---  libvirt-gconfig/libvirt-gconfig-domain-interface.c |   35  

Re: [libvirt] [libvirt-glib 1/6] Getters for GVirConfigDomainInterface attributes

2012-02-29 Thread Christophe Fergeau
On Wed, Feb 29, 2012 at 03:44:20PM +0200, Zeeshan Ali (Khattak) wrote: On Wed, Feb 29, 2012 at 2:57 PM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Feb 28, 2012 at 08:25:02PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org ---  

Re: [libvirt] [libvirt-glib 5/6] Remove now redundant 'path' property

2012-02-29 Thread Zeeshan Ali (Khattak)
On Wed, Feb 29, 2012 at 3:18 PM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Feb 28, 2012 at 08:25:06PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Remove now redundant 'path' property from GVirDomainDevice subclasses. ---  

Re: [libvirt] [PATCH 1/1] complete netlink event integration

2012-02-29 Thread Laine Stump
On 02/29/2012 08:43 AM, D. Herrendoerfer wrote: On Feb 29, 2012, at 9:51 AM, Laine Stump wrote: Since I found a couple other problems, but have made you suffer through enough back and forth already, I've made some final suggested changes myself, and am sending a diff patch as a response to

Re: [libvirt] [PATCH RFC]: Support numad

2012-02-29 Thread Bill Burns
On 02/28/2012 11:34 PM, Osier Yang wrote: On 02/29/2012 12:40 AM, Daniel P. Berrange wrote: On Tue, Feb 28, 2012 at 11:33:03AM -0500, Dave Allan wrote: On Tue, Feb 28, 2012 at 10:10:50PM +0800, Osier Yang wrote: numad is an user-level daemon that monitors NUMA topology and processes resource

Re: [libvirt] [PATCH v2] Cleanup of the quick dirty fix from last week

2012-02-29 Thread Jiri Denemark
On Fri, Feb 10, 2012 at 11:13:54 -0700, Eric Blake wrote: On 02/10/2012 08:22 AM, Martin Kletzander wrote: Just a cleanup of commit 32f881c6c42f94da70a3782fe20a058fe3dc39cc. --- src/lxc/lxc_container.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) ACK. I

Re: [libvirt] [libvirt-glib 6/6] Add gvir_domain_get_devices()

2012-02-29 Thread Zeeshan Ali (Khattak)
On Wed, Feb 29, 2012 at 3:30 PM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Feb 28, 2012 at 08:25:07PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Currently we only support existing DomainDevice implementations: DomainDisk and

Re: [libvirt] [libvirt-glib 1/6] Getters for GVirConfigDomainInterface attributes

2012-02-29 Thread Zeeshan Ali (Khattak)
On Wed, Feb 29, 2012 at 3:49 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Feb 29, 2012 at 03:44:20PM +0200, Zeeshan Ali (Khattak) wrote: On Wed, Feb 29, 2012 at 2:57 PM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Feb 28, 2012 at 08:25:02PM +0200, Zeeshan Ali (Khattak)

Re: [libvirt] [libvirt-glib 6/6] Add gvir_domain_get_devices()

2012-02-29 Thread Christophe Fergeau
On Wed, Feb 29, 2012 at 04:01:40PM +0200, Zeeshan Ali (Khattak) wrote: On Wed, Feb 29, 2012 at 3:30 PM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Feb 28, 2012 at 08:25:07PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Currently we only

Re: [libvirt] [libvirt-glib 1/6] Getters for GVirConfigDomainInterface attributes

2012-02-29 Thread Christophe Fergeau
On Wed, Feb 29, 2012 at 04:10:29PM +0200, Zeeshan Ali (Khattak) wrote: Ah, I just realized why that is so: static char *libxml_str_to_glib(xmlChar *str) { char *g_str; if (str == NULL) return NULL; g_str = g_strdup((char *)str); xmlFree(str); return

Re: [libvirt] [PATCH v4] Support for cpu64-rhel* qemu cpu models

2012-02-29 Thread Jiri Denemark
On Fri, Feb 24, 2012 at 10:44:19 +0100, Martin Kletzander wrote: In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not supported by libvirt. This patch adds the support with the flags specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf The only difference is that

[libvirt] [PATCH] cpu: Add new flag supported by qemu to the cpu definition

2012-02-29 Thread Peter Krempa
Some new cpu features were added to qemu. This patch adds some of them to our CPU map. --- to ease review, here's an excerpt from qemu.git/target-i386/cpuid.c to ease the review: static const char *ext3_feature_name[] = { lahf_lm /* AMD LahfSahf */, cmp_legacy, svm, extapic /* AMD

Re: [libvirt] [libvirt-glib 1/6] Getters for GVirConfigDomainInterface attributes

2012-02-29 Thread Zeeshan Ali (Khattak)
On Wed, Feb 29, 2012 at 4:22 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Feb 29, 2012 at 04:10:29PM +0200, Zeeshan Ali (Khattak) wrote: Ah, I just realized why that is so: static char *libxml_str_to_glib(xmlChar *str) {     char *g_str;     if (str == NULL)         return

Re: [libvirt] [libvirt-glib 1/6] Getters for GVirConfigDomainInterface attributes

2012-02-29 Thread Christophe Fergeau
On Wed, Feb 29, 2012 at 05:26:58PM +0200, Zeeshan Ali (Khattak) wrote: There wont' be any need for freeing if gvir_config_xml_get_child_element_content() and similar functions returned chid_node-content rather than xmlNodeGetContent (child_node). That way you never need to free any string.

Re: [libvirt] [libvirt-glib 6/6] Add gvir_domain_get_devices()

2012-02-29 Thread Zeeshan Ali (Khattak)
On Wed, Feb 29, 2012 at 4:24 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Feb 29, 2012 at 04:01:40PM +0200, Zeeshan Ali (Khattak) wrote: On Wed, Feb 29, 2012 at 3:30 PM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Feb 28, 2012 at 08:25:07PM +0200, Zeeshan Ali (Khattak)

Re: [libvirt] [PATCH] Fix typo in domain XML documentation

2012-02-29 Thread Eric Blake
On 02/29/2012 05:47 AM, Christophe Fergeau wrote: s/Modyfing/Modifying --- docs/formatdomain.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ACK. You can push patches like this under the trivial rule (see HACKING); it's a good idea to still send the mail, but just

Re: [libvirt] [PATCH v5 2/2] Add de-association handling to macvlan code

2012-02-29 Thread Laine Stump
On 02/24/2012 09:29 AM, D. Herrendoerfer wrote: The callback mechanism is not re-armed when libvirt is restarted now. The reason is: lldpad remembers who sent the associate by pid - since in theory there could be multiple agents performing associations. So if the libvirt pid changes, there is

Re: [libvirt] [PATCH] build: update to latest gnulib

2012-02-29 Thread Eric Blake
On 02/29/2012 02:50 AM, Laine Stump wrote: On 02/24/2012 07:39 PM, Eric Blake wrote: It's been a while, and we're between releases, so now's as good a time as any to resync. I didn't notice any showstopper bugs being fixed, but we definitely get some improvements, such as tighter syntax

Re: [libvirt] [PATCH 3/3] virsh: expose partial pull

2012-02-29 Thread Eric Blake
On 02/29/2012 03:08 AM, Laine Stump wrote: On 02/18/2012 12:44 PM, Eric Blake wrote: Now virsh can call virDomainBlockRebase. ACK. Series pushed. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP

Re: [libvirt] [libvirt-glib 1/6] Getters for GVirConfigDomainInterface attributes

2012-02-29 Thread Zeeshan Ali (Khattak)
On Wed, Feb 29, 2012 at 2:57 PM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Feb 28, 2012 at 08:25:02PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org ---  libvirt-gconfig/libvirt-gconfig-domain-interface.c |   35  

[libvirt] [libvirt-glib 6/6] Add gvir_domain_get_devices()

2012-02-29 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org Currently we only support existing DomainDevice implementations: DomainDisk and DomainInterface. --- .../libvirt-gobject-domain-device-private.h|2 + libvirt-gobject/libvirt-gobject-domain-device.c| 22 ++

[libvirt] [libvirt-glib 2/6] Add gvir_domain_device_get_domain()

2012-02-29 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org Getter for the associated domain of a domain device. --- libvirt-gobject/libvirt-gobject-domain-device.c | 11 +++ libvirt-gobject/libvirt-gobject-domain-device.h |3 +++ libvirt-gobject/libvirt-gobject.sym |1 + 3

[libvirt] [libvirt-glib 4/6] Add 'config' property to GVirDomainDevice

2012-02-29 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org GVirDomainDevice should have an associated GVirConfigDomainDevice. --- libvirt-gobject/libvirt-gobject-domain-device.c | 33 +++ libvirt-gobject/libvirt-gobject-domain-device.h |1 + libvirt-gobject/libvirt-gobject.sym

[libvirt] [libvirt-glib 3/6] Getters for GVirConfigDomainInterface attributes

2012-02-29 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain-interface.c | 35 libvirt-gconfig/libvirt-gconfig-domain-interface.h |4 ++ libvirt-gconfig/libvirt-gconfig.sym|4 ++ 3 files changed, 43 insertions(+), 0

[libvirt] [libvirt-glib 5/6] Remove now redundant 'path' property

2012-02-29 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org Remove now redundant 'path' property from GVirDomainDevice subclasses. These classes now have access to their configurations, from which they can easily get the path (among other properties) internally. ---

[libvirt] [libvirt-glib 1/6] Set correct target node attribute for domain interface

2012-02-29 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org gvir_config_domain_interface_set_ifname() should be setting 'dev' attribute under 'target', not 'device'. --- libvirt-gconfig/libvirt-gconfig-domain-interface.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] Use the same MAC address that is defined in domain XML for attached-mac field.

2012-02-29 Thread Ansis Atteka
On Sat, Feb 18, 2012 at 7:07 PM, Laine Stump la...@laine.org wrote: On 02/17/2012 02:51 PM, Ansis Atteka wrote: On Fri, Feb 17, 2012 at 10:55 AM, Laine Stump la...@laine.org mailto:la...@laine.org wrote: On 02/16/2012 06:49 PM, Ansis Atteka wrote: Currently libvirt sets

[libvirt] Important, switch of server for libvirt.org

2012-02-29 Thread Daniel Veillard
I learned yesterday that the lab hosting libvirt.org would have power cut off for the week-end due to electical maintainance. I took the opportunity to switch the server to a new box, and just made the switch to the DNS, it may take up to 8 hours to propagate though. I cut ssh access to the

[libvirt] [Patch]: spice agent-mouse support

2012-02-29 Thread Zhou Peng
Signed-off-by: Zhou Peng zhoup...@nfs.iscas.ac.cn spice agent-mouse support diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f9654f1..79d5ac9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -852,6 +852,7 @@ void

[libvirt] [libvirt-glib] RFC: Empty statistics for user-mode interfaces

2012-02-29 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org One of the limitations of user-mode networking of libvirt is that you can't get statistics for it (not yet, at least). Instead of erroring-out in that case, simply return empty statistics result and spit a debug message. I will merge this into my

[libvirt] [libvirt-glib] Remove now redundant 'path' property

2012-02-29 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org Remove now redundant 'path' property from GVirDomainDevice subclasses. These classes now have access to their configurations, from which they can easily get the path (among other properties) internally. ---

Re: [libvirt] [Patch]: spice agent-mouse support

2012-02-29 Thread Osier Yang
On 03/01/2012 11:54 AM, Zhou Peng wrote: Signed-off-by: Zhou Pengzhoup...@nfs.iscas.ac.cn spice agent-mouse support diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f9654f1..79d5ac9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -852,6 +852,7 @@ void