Re: [libvirt] [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-24 Thread Christoph Hellwig
On Fri, Mar 09, 2012 at 06:16:54PM +0100, Paolo Bonzini wrote: I'm wondering whether it's worth expanding the SELinux policy if we will have no fstatfs(2) callers in QEMU. Are you planning to drop the XFS code? Chris Wedgwood said that on XFS you want to do discard even if the file is

Re: [libvirt] [Qemu-devel] QEMU fstatfs(2) and libvirt SELinux policy

2012-03-24 Thread Christoph Hellwig
On Fri, Mar 09, 2012 at 04:07:43PM +, Stefan Hajnoczi wrote: Paolo, your discard improvements in QEMU add FALLOC_FL_PUNCH_HOLE support. XFS supports this fallocate() flag in current kernels, thereby making the XFS-specific support obsolete. I'm wondering whether it's worth expanding the

[libvirt] [test-API PATCH 0/6] General improvements and fixes

2012-03-24 Thread Martin Kletzander
This series fixed some of the issues I came across while trying to make some tests working. I still haven't managed to run more than define, start, destroy and undefine tests, but at least this should help someone to get a start at this. There are many things that could (should?) be changed

[libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-24 Thread Martin Kletzander
I added support for 'uri' parameter and moved some functions into util/Python/utils.py in order not to lose them from the code and keep them accessible for other tests. --- repos/domain/define.py | 132 utils/Python/utils.py | 45

[libvirt] [test-API PATCH 1/6] Slight cross-distribution support

2012-03-24 Thread Martin Kletzander
There is no support for distributions without 'rpm' as a package manager. This patch modifies (at this time) the only distribution-specific import in order to ease the broadening of distribution list supported by libvirt-test-API. --- env_inspect.py = dist/redhat/env_inspect.py |0

[libvirt] [test-API PATCH 2/6] Added support for Gentoo

2012-03-24 Thread Martin Kletzander
In order to support libvirt-test-API on more distributions, this commit adds support for Gentoo. The file is copy-paste from dist/redhat/env_update.py just modified to make the get_* functions work on Gentoo, some removed. --- dist/gentoo/env_inspect.py | 98

[libvirt] [test-API PATCH 3/6] Fixed domain/start.py

2012-03-24 Thread Martin Kletzander
Function usage() was called in the code but was missing. Parameter 'flags' was defined as optional but it was still required in the code, so I fixed the handling of it. --- repos/domain/start.py | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff --git

[libvirt] [test-API PATCH 4/6] Add default 'uri' parameter to all tests

2012-03-24 Thread Martin Kletzander
Tests should be able to run on various hypervisors and machines. Now we have only two tests that have an option to do something remotely. This commit allows tests to see 'uri' parameter that they should connect to. However it doesn't have to be used always (migration etc.) --- generator.py |6

[libvirt] [test-API PATCH 6/6] Make use of new 'uri' parameter in tests

2012-03-24 Thread Martin Kletzander
I changed all tests to make use of the 'uri' parameter. This change should be more re-factored and lots of things could be changed to make the code more readable, but unfortunately there's no time for that right now, so at least this small step towards the goal. --- repos/domain/attach_disk.py