Re: [libvirt] [PATCH] fix deadlock when qemu cannot start

2012-03-26 Thread Wen Congyang
ping At 03/16/2012 02:37 PM, Wen Congyang Wrote: When qemu cannot start, we may call qemuProcessStop() twice. We have check whether the vm is running at the beginning of qemuProcessStop() to avoid libvirt deadlock. We call qemuProcessStop() with driver and vm locked. It seems that we can

[libvirt] [PATCH 2/2] python: make python APIs use these helper functions

2012-03-26 Thread Guannan Ren
*libvirt_virDomainGetCPUStats *setPyVirTypedParameter --- python/libvirt-override-api.xml |4 +- python/libvirt-override.c | 62 +- 2 files changed, 11 insertions(+), 55 deletions(-) diff --git a/python/libvirt-override-api.xml

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-03-26 Thread Philipp Hahn
Hello, On Monday 26 March 2012 04:32:23 Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) My change to correct the handling of the Xen-HV

[libvirt] [PATCH] test-API: Remove trailing spaces

2012-03-26 Thread Osier Yang
Script used to do the work: % for f in $(find . -type f -name *.py); do \ sed -i -e s/\(?*\)\s\+$/\1/g $f; \ done --- env_inspect.py | 20 +- exception.py | 12 +++--- lib/snapshotAPI.py | 18 logxmlparser.py

Re: [libvirt] [PATCH] test-API: Remove trailing spaces

2012-03-26 Thread Guannan Ren
On 03/26/2012 03:28 PM, Osier Yang wrote: Script used to do the work: % for f in $(find . -type f -name *.py); do \ sed -i -e s/\(?*\)\s\+$/\1/g $f; \ done --- env_inspect.py | 20 +- exception.py | 12 +++--- lib/snapshotAPI.py

Re: [libvirt] [test-API PATCH] streamAPI: Create stream objects that are already encapsulated

2012-03-26 Thread Peter Krempa
On 03/22/2012 02:51 PM, Guannan Ren wrote: On 03/22/2012 08:54 PM, Peter Krempa wrote: With this patch, the newStream() method of the ConnectAPI class returns an already encapsulated StreamAPI object . *lib/connectAPI.py: - modify newStream method to return StreamAPI object *lib/streamAPI.py: -

[libvirt] [test-API PATCHv2] libs: Add flags for streams and the console

2012-03-26 Thread Peter Krempa
Add the local copy of the flags. --- lib/domainAPI.py |3 +++ lib/streamAPI.py |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/domainAPI.py b/lib/domainAPI.py index bc0069b..43565c2 100644 --- a/lib/domainAPI.py +++ b/lib/domainAPI.py @@ -912,3 +912,6 @@

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Avi Kivity
On 03/25/2012 08:11 PM, Anthony Liguori wrote: I don't think -nodefconfig (as defined) is usable, since there is no way for the user to tell what it means short of reading those files. *if the user doesn't know specifics about this QEMU version. You make the assumption that all users are

Re: [libvirt] [test-API PATCHv2] libs: Add flags for streams and the console

2012-03-26 Thread Martin Kletzander
On 03/26/2012 11:07 AM, Peter Krempa wrote: Add the local copy of the flags. --- lib/domainAPI.py |3 +++ lib/streamAPI.py |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/domainAPI.py b/lib/domainAPI.py index bc0069b..43565c2 100644 ---

Re: [libvirt] [PATCH v2 2/2] Added syntax-check rule for return with parentheses

2012-03-26 Thread Martin Kletzander
On 03/26/2012 05:43 AM, Osier Yang wrote: On 2012年03月23日 15:34, Martin Kletzander wrote: After cleanup introduced with previous commit, there is a need for syntax-check rule taking care of return(). Regexp used in 'prohibit' parameter is taken from the cleanup commit and modified so it fits

[libvirt] [libvirt-glib] [PATCH] cannot build master - conn_test fails to build due to missing linkage on in tree libvirt-gconfig

2012-03-26 Thread Alban Browaeys
link conn_test againt in tree libvirt-gconfig Description of problem: CCLD conn-test ../libvirt-gobject/.libs/libvirt-gobject-1.0.so: undefined reference to `gvir_config_domain_interface_get_ifname@LIBVIRT_GCONFIG_0.0.4' Attach patch add ../libvirt-gconfig/libvirt-gconfig-1.0.la \ to the

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Gleb Natapov
On Mon, Mar 26, 2012 at 11:08:16AM +0200, Avi Kivity wrote: Exactly. The types are no different, so there's no reason to discriminate against types that happen to live in qemu-provided data files vs. qemu code. They aren't instantiated, so we lose nothing by creating the factories (just

Re: [libvirt] [test-API PATCHv2] libs: Add flags for streams and the console

2012-03-26 Thread Guannan Ren
On 03/26/2012 05:18 PM, Martin Kletzander wrote: On 03/26/2012 11:07 AM, Peter Krempa wrote: Add the local copy of the flags. --- lib/domainAPI.py |3 +++ lib/streamAPI.py |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/domainAPI.py b/lib/domainAPI.py

Re: [libvirt] [libvirt-glib] [PATCH] cannot build master - conn_test fails to build due to missing linkage on in tree libvirt-gconfig

2012-03-26 Thread Daniel P. Berrange
On Mon, Mar 26, 2012 at 11:45:19AM +0200, Alban Browaeys wrote: link conn_test againt in tree libvirt-gconfig Description of problem: CCLD conn-test ../libvirt-gobject/.libs/libvirt-gobject-1.0.so: undefined reference to `gvir_config_domain_interface_get_ifname@LIBVIRT_GCONFIG_0.0.4'

Re: [libvirt] [RFC: PATCH 2/2] viruri: add more tests

2012-03-26 Thread Daniel P. Berrange
On Fri, Mar 23, 2012 at 04:09:59PM -0600, Eric Blake wrote: When qparams support was dropped in commit bc1ff160, we forgot to add tests to ensure that viruri can do the same round trip handling of a URI. Also, we forgot to report an OOM error. NOTE: THIS TEST CURRENTLY FAILS ON ANY QUERY

Re: [libvirt] [Libvirt-announce] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-03-26 Thread Justin Clift
On 26/03/2012, at 1:32 PM, Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) I have made a release candidate 1 tarball (and associated rpms)

Re: [libvirt] Problem with Open vSwitch and dnsmasq

2012-03-26 Thread Daniele Milani
Date: Fri, 23 Mar 2012 10:15:31 -0700 Subject: Re: [libvirt] Problem with Open vSwitch and dnsmasq From: aatt...@nicira.com To: dano1...@hotmail.it CC: libvir-list@redhat.com; roberto.sa...@polito.it; paolo.smirag...@polito.it; d...@openvswitch.org; libvirt-us...@redhat.com On Fri, Mar 23,

Re: [libvirt] Problem with Open vSwitch and dnsmasq

2012-03-26 Thread Daniele Milani
From: dano1...@hotmail.it To: aatt...@nicira.com CC: libvir-list@redhat.com; roberto.sa...@polito.it; paolo.smirag...@polito.it; d...@openvswitch.org; libvirt-us...@redhat.com Subject: RE: [libvirt] Problem with Open vSwitch and dnsmasq Date: Mon, 26 Mar 2012 12:41:59 +0200 Date: Fri,

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Jiri Denemark
On Sun, Mar 25, 2012 at 10:26:57 -0500, Anthony Liguori wrote: On 03/25/2012 10:16 AM, Avi Kivity wrote: On 03/25/2012 04:59 PM, Anthony Liguori wrote: So how about: 1) Load ['@SYSCONFDIR@/qemu/qemu.cfg', '@SYSCONFDIR@/qemu/target-@ARCH@.cfg', '@DATADIR@/system.cfg',

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Avi Kivity
On 03/26/2012 01:24 PM, Jiri Denemark wrote: ... The command line becomes unstable if you use -nodefconfig. -no-user-config solves this but I fully expect libvirt would continue to use -nodefconfig. Libvirt uses -nodefaults -nodefconfig because it wants to fully control how the

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Gleb Natapov
On Mon, Mar 26, 2012 at 01:59:05PM +0200, Avi Kivity wrote: On 03/26/2012 01:24 PM, Jiri Denemark wrote: ... The command line becomes unstable if you use -nodefconfig. -no-user-config solves this but I fully expect libvirt would continue to use -nodefconfig. Libvirt uses

Re: [libvirt] [test-API PATCH 2/6] Added support for Gentoo

2012-03-26 Thread Peter Krempa
On 03/24/2012 06:42 PM, Martin Kletzander wrote: In order to support libvirt-test-API on more distributions, this commit adds support for Gentoo. The file is copy-paste from dist/redhat/env_update.py just modified to make the get_* functions work on Gentoo, some removed. Probably no one else

[libvirt] [PATCH] Expand docs for timer tick policy

2012-03-26 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com --- docs/formatdomain.html.in | 25 - 1 files changed, 20 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 814e270..c2eabc5 100644 --- a/docs/formatdomain.html.in +++

Re: [libvirt] [test-API PATCH 1/6] Slight cross-distribution support

2012-03-26 Thread Peter Krempa
On 03/24/2012 06:42 PM, Martin Kletzander wrote: There is no support for distributions without 'rpm' as a package manager. This patch modifies (at this time) the only distribution-specific import in order to ease the broadening of distribution list supported by libvirt-test-API. ---

Re: [libvirt] [test-API PATCH 1/6] Slight cross-distribution support

2012-03-26 Thread Michal Novotny
On 03/26/2012 02:30 PM, Peter Krempa wrote: On 03/24/2012 06:42 PM, Martin Kletzander wrote: There is no support for distributions without 'rpm' as a package manager. This patch modifies (at this time) the only distribution-specific import in order to ease the broadening of distribution list

Re: [libvirt] [test-API PATCH 5/6] Cleanup and fix of domain/define test

2012-03-26 Thread Guannan Ren
On 03/25/2012 01:42 AM, Martin Kletzander wrote: I added support for 'uri' parameter and moved some functions into util/Python/utils.py in order not to lose them from the code and keep them accessible for other tests. --- repos/domain/define.py | 132

Re: [libvirt] [test-API PATCH 3/6] Fixed domain/start.py

2012-03-26 Thread Guannan Ren
On 03/25/2012 01:42 AM, Martin Kletzander wrote: Function usage() was called in the code but was missing. Parameter 'flags' was defined as optional but it was still required in the code, so I fixed the handling of it. --- repos/domain/start.py | 15 +++ 1 files changed, 11

Re: [libvirt] [test-API PATCH 4/6] Add default 'uri' parameter to all tests

2012-03-26 Thread Guannan Ren
On 03/25/2012 01:42 AM, Martin Kletzander wrote: Tests should be able to run on various hypervisors and machines. Now we have only two tests that have an option to do something remotely. This commit allows tests to see 'uri' parameter that they should connect to. However it doesn't have to be

Re: [libvirt] [test-API PATCH 1/6] Slight cross-distribution support

2012-03-26 Thread Guannan Ren
On 03/26/2012 08:30 PM, Peter Krempa wrote: On 03/24/2012 06:42 PM, Martin Kletzander wrote: There is no support for distributions without 'rpm' as a package manager. This patch modifies (at this time) the only distribution-specific import in order to ease the broadening of distribution list

[libvirt] LIBVIRT-PHP List of domains

2012-03-26 Thread Ali Raza Memon
Hi.. I am trying to get the names of all the xen domains using libvirt-php. I saw this php script: ?php $conn = libvirt_connect('null', false); $doms = libvirt_list_domains($conn); print_r($doms); ? It gives me error. Could you please tell me how to connect to xen hypervisor? I

[libvirt] libvirt: xen: Shutdown detection fixes

2012-03-26 Thread Stefan Bader
The issue is easy to observe when using virt-manager as a frontend. Its main window seems to open connections for the up/down main display once and then only repeats DomainGetInfo on the same connection to check whether the instance is up or shut down. The initial open on the connection sets the

[libvirt] xend_internal: Use domain/status for shutdown check

2012-03-26 Thread Stefan Bader
xend_internal: Use domain/status for shutdown check On newer xend (v3.x and after) there is no state and domid reported for inactive domains. When initially creating connections this is handled in various places by assigning domain-id = -1. But once an instance has been running, the id is set to

[libvirt] xen-hypervisor: GetVcpus may not find a certain domain

2012-03-26 Thread Stefan Bader
xen-hypervisor: GetVcpus may not find a certain domain Observed on connections that have been running and then shut down. The hypervisor subdriver fills the log with internal errors while the xend driver actually can handle the query. This only handles the case which I observed after shutting

[libvirt] CPU topology 'sockets' handling guest vs host

2012-03-26 Thread Daniel P. Berrange
On my x86_64 host I have a pair of Quad core CPUs, each in a separate NUMA node. The virsh capabilities topology data reports this: # virsh capabilities | xmllint --xpath /capabilities/host/cpu - cpu archx86_64/arch modelOpteron_G3/model vendorAMD/vendor topology

Re: [libvirt] CPU topology 'sockets' handling guest vs host

2012-03-26 Thread Jiri Denemark
On Mon, Mar 26, 2012 at 15:42:58 +0100, Daniel P. Berrange wrote: On my x86_64 host I have a pair of Quad core CPUs, each in a separate NUMA node. The virsh capabilities topology data reports this: # virsh capabilities | xmllint --xpath /capabilities/host/cpu - cpu

Re: [libvirt] CPU topology 'sockets' handling guest vs host

2012-03-26 Thread Daniel P. Berrange
On Mon, Mar 26, 2012 at 05:08:05PM +0200, Jiri Denemark wrote: On Mon, Mar 26, 2012 at 15:42:58 +0100, Daniel P. Berrange wrote: On my x86_64 host I have a pair of Quad core CPUs, each in a separate NUMA node. The virsh capabilities topology data reports this: # virsh capabilities |

[libvirt] sr-iov ethernet VF is not assigned correctly to guest

2012-03-26 Thread Scott
Hi, I'm hoping someone could possibly show me what I may be doing wrong here, and why I'm not seeing the expected results Thanks in advance! Server Information:HP Product Name: ProLiant DL165 G7 Ethernet Card Information: Intel 82599EB 10-Gigabit SFI/SFP+ uname: Linux 3.0.0-16-server x86_64

Re: [libvirt] sr-iov ethernet VF is not assigned correctly to guest

2012-03-26 Thread Daniel P. Berrange
On Mon, Mar 26, 2012 at 11:12:56AM -0400, Scott wrote: Hi, I'm hoping someone could possibly show me what I may be doing wrong here, and why I'm not seeing the expected results Thanks in advance! Server Information:HP Product Name: ProLiant DL165 G7 Ethernet Card Information: Intel

[libvirt] [PATCH] Detect location fo selinux mount point

2012-03-26 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The SELinux mount point moved from /selinux to /sys/fs/selinux when systemd came along. * configure.ac: Probe for SELinux mount point * src/lxc/lxc_container.c: Use SELinux mount point determined by configure.ac --- configure.ac| 19

[libvirt] [PATCH 3/3] qemu: Build activeUsbHostdevs list on process reconnect

2012-03-26 Thread Michal Privoznik
If the daemon is restarted it will loose list of active USB devices assigned to active domains. Therefore we need to rebuild this list on qemuProcessReconnect(). --- src/qemu/qemu_hostdev.c | 40 src/qemu/qemu_hostdev.h |2 ++ src/qemu/qemu_process.c

[libvirt] [PATCH 0/3] qemu: Improve USB devices list handling

2012-03-26 Thread Michal Privoznik
This patch set fixes two bugs: https://bugzilla.redhat.com/show_bug.cgi?id=806449 https://bugzilla.redhat.com/show_bug.cgi?id=743671 tl;dr - we are only adding to the list, removing only on detach-device. Need to remove on qemuProcessStop too. And need to rebuild the list on

[libvirt] [PATCH 1/3] qemu: Don't leak temporary list of USB devices

2012-03-26 Thread Michal Privoznik
and add debug message when adding USB device to the list of active devices. --- src/qemu/qemu_hostdev.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 329e3fc..d4d7461 100644 --- a/src/qemu/qemu_hostdev.c

[libvirt] [PATCH 2/3] qemu: Delete USB devices used by domain on stop

2012-03-26 Thread Michal Privoznik
To prevent assigning one USB device to two domains, we keep a list of assigned USB devices. On domain startup - qemuProcessStart() - we insert devices used by domain into the list but remove them only on detach-device. Devices are, however, released on qemuProcessReconnect() as well. ---

Re: [libvirt] CPU topology 'sockets' handling guest vs host

2012-03-26 Thread Jiri Denemark
On Mon, Mar 26, 2012 at 16:11:08 +0100, Daniel P. Berrange wrote: On Mon, Mar 26, 2012 at 05:08:05PM +0200, Jiri Denemark wrote: On Mon, Mar 26, 2012 at 15:42:58 +0100, Daniel P. Berrange wrote: So, the XML checker is mistaking 'sockets' as the total number of sockets, rather than the

[libvirt] [PATCH] Prefer to use 'qemu-system-i386' over 'qemu'

2012-03-26 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com For i686 arch we look for the 'qemu' binary, followed by the 'qemu-system-x86_64' binary. This is not good with QEMU 1.0, since the 'qemu' binary was renamed to 'qemu-system-i386' and the 'qemu' name might be reused for another purpose later. Make

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Eduardo Habkost
On Sun, Mar 25, 2012 at 12:19:13PM +0200, Gleb Natapov wrote: (That's why I said that perhaps keymaps could become configuration someday. Because maybe they can be converted to a key=value model relatively easily) Such whole sale approach is harmful since it starts to affect design

Re: [libvirt] [PATCH] Detect location fo selinux mount point

2012-03-26 Thread Eric Blake
On 03/26/2012 09:40 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The SELinux mount point moved from /selinux to /sys/fs/selinux when systemd came along. * configure.ac: Probe for SELinux mount point * src/lxc/lxc_container.c: Use SELinux mount point

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Eduardo Habkost
On Mon, Mar 26, 2012 at 02:03:21PM +0200, Gleb Natapov wrote: On Mon, Mar 26, 2012 at 01:59:05PM +0200, Avi Kivity wrote: On 03/26/2012 01:24 PM, Jiri Denemark wrote: ... The command line becomes unstable if you use -nodefconfig. -no-user-config solves this but I fully expect

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Eduardo Habkost
On Sun, Mar 25, 2012 at 01:11:04PM -0500, Anthony Liguori wrote: On 03/25/2012 10:40 AM, Avi Kivity wrote: On 03/25/2012 05:26 PM, Anthony Liguori wrote: Put the emphasis around *configuration*. So how about: 1) Load ['@SYSCONFDIR@/qemu/qemu.cfg', '@SYSCONFDIR@/qemu/target-@ARCH@.cfg',

Re: [libvirt] Problem with Open vSwitch and dnsmasq

2012-03-26 Thread Daniele Milani
I solved a part of the problem: running a bridge network (forward mode=network) and starting manually multiple instances of dnsmasq (one for each tag I have) it works... I'm still not able to make it work in a nat network. Daniele Milani From: dano1...@hotmail.it To: aatt...@nicira.com CC:

[libvirt] [PATCH 2/2] Add LXC XML files to schema test fix problems this uncovers

2012-03-26 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com * docs/schemas/domaincommon.rng: Add missing lxc openvz console target types. Allow arch on LXC os type element * tests/domainschematest: Include tests/lxcxml2xmldata/ --- docs/schemas/domaincommon.rng | 14 ++ tests/domainschematest

Re: [libvirt] [ovs-dev] Problem with Open vSwitch and dnsmasq

2012-03-26 Thread Daniele Milani
[...] (forward mode=network) [...] s/network/bridge/g :-) From: dano1...@hotmail.it To: aatt...@nicira.com CC: libvir-list@redhat.com; roberto.sa...@polito.it; paolo.smirag...@polito.it; d...@openvswitch.org; libvirt-us...@redhat.com Subject: RE: [libvirt] Problem with Open vSwitch

[libvirt] [PATCH 1/2] Add support for setting init argv for LXC

2012-03-26 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Pass argv to the init binary of LXC, using a new initarg element. * docs/formatdomain.html.in: Document os usage for containers * docs/schemas/domaincommon.rng: Add initarg element * src/conf/domain_conf.c, src/conf/domain_conf.h: parsing and

[libvirt] [PATCH test-API 0/2]Use encapsulated python APIs in testcases

2012-03-26 Thread Guannan Ren
These two patches modify library modules and exsiting testcases for disallowing the use of the objects of subclasses in libvirt.py directly. The files in lib directory are the layer of encapsulated python APIs. we should use methods in it for good error catching. 93 files changed, 292

[libvirt] [PATCH test-API 1/2] lib: pass instance of ConnectAPI into other lib modules

2012-03-26 Thread Guannan Ren
This change make any instance of subclasses in libvirt.py invisible to testcases in order to catch libvirtError. connectAPI.py domainAPI.py interfaceAPI.py networkAPI.py nodedevAPI.py nwfilterAPI.py secretAPI.py snapshotAPI.py

Re: [libvirt] [PATCH] Prefer to use 'qemu-system-i386' over 'qemu'

2012-03-26 Thread Eric Blake
On 03/26/2012 09:59 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com For i686 arch we look for the 'qemu' binary, followed by the 'qemu-system-x86_64' binary. This is not good with QEMU 1.0, since the 'qemu' binary was renamed to 'qemu-system-i386' and the 'qemu'

Re: [libvirt] [PATCH 2/2] Add LXC XML files to schema test fix problems this uncovers

2012-03-26 Thread Eric Blake
On 03/26/2012 11:13 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com * docs/schemas/domaincommon.rng: Add missing lxc openvz console target types. Allow arch on LXC os type element * tests/domainschematest: Include tests/lxcxml2xmldata/ ---

Re: [libvirt] [PATCH 1/2] Add support for setting init argv for LXC

2012-03-26 Thread Eric Blake
On 03/26/2012 11:13 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Pass argv to the init binary of LXC, using a new initarg element. * docs/formatdomain.html.in: Document os usage for containers * docs/schemas/domaincommon.rng: Add initarg element *

[libvirt] [PATCH 1/3] build: fix missing initializer error in qemu_process.c

2012-03-26 Thread Laine Stump
Found when attempting to build on Fedora 17 alpha with: ./autogen.sh --system --enable-compile-warnings=error (this same build command works without problem on Fedora 16). Since the consumer of the qemuProcessReconnectData doesn't assume that the other fields of the struct are initialized

[libvirt] [PATCH 2/3] build: fix missing initializer errors in virsh.c

2012-03-26 Thread Laine Stump
Found when attempting to build on Fedora 17 alpha with: ./autogen.sh --system --enable-compile-warnings=error (this same build command works without problem on Fedora 16). All other struct initializers for this struct have the extra field filled in (almost always to 0), so the two errant ones

[libvirt] [PATCH 3/3] build: avoid frame size error when building without -O2

2012-03-26 Thread Laine Stump
libvirt always adds -Werror-frame-larger-than=4096 to the flags when it builds. When building on Fedora 17, two functions with multiple 1024 buffers declared inside if {} blocks would generate frame size errors; apparently the version of gcc on Fedora 16 will merge these multiple buffers into a

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Anthony Liguori
On 03/25/2012 01:09 PM, Avi Kivity wrote: Suppose we define the southbridge via a configuration file. Does that mean we don't load it any more? Yes. If I want the leanest and meanest version of QEMU that will start in the smallest number of milliseconds, then being able to tell QEMU not to

[libvirt] [PATCH 0/3] build: fix 3 Fedora 17 build errors

2012-03-26 Thread Laine Stump
The first two of these (missing initializer) I would expect anybody to get if they're building with -Wall on Fedora 17, but the problems have been there at least since the last libvirt release. The last error only happens if you manually specify CFLAGS with no -O (or with -O0). Although these

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Anthony Liguori
On 03/26/2012 04:08 AM, Avi Kivity wrote: If I see something like -nodefconfig, I assume it will create a bare bones guest that will not depend on any qemu defaults and will be stable across releases. That's not even close to what -nodefconfig is. That's pretty much what -nodefaults is but

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Anthony Liguori
On 03/26/2012 11:14 AM, Eduardo Habkost wrote: On Mon, Mar 26, 2012 at 02:03:21PM +0200, Gleb Natapov wrote: On Mon, Mar 26, 2012 at 01:59:05PM +0200, Avi Kivity wrote: On 03/26/2012 01:24 PM, Jiri Denemark wrote: ... The command line becomes unstable if you use -nodefconfig.

Re: [libvirt] sr-iov ethernet VF is not assigned correctly to guest

2012-03-26 Thread Scott
On Mar 26, 2012, at 11:20 AM, Daniel P. Berrange wrote: On Mon, Mar 26, 2012 at 11:12:56AM -0400, Scott wrote: Hi, I'm hoping someone could possibly show me what I may be doing wrong here, and why I'm not seeing the expected results Thanks in advance! Server Information:HP Product

[libvirt] libvirt support for hot plugging multifunction PCI devices to KVM guests

2012-03-26 Thread Nandini Chandra
I'd like to understand where libvirt is with regards to supporting hot plugging of multifunction PCI devices to a KVM guest. http://www.redhat.com/archives/libvir-list/2011-December/msg00621.html According to the above thread,the --multifunction option can be specified with the virsh

[libvirt] Turning off libvirtd mdns by default

2012-03-26 Thread Stef Walter
In the GNOME UI we'd like to make use of Avahi discovery and name resolution out of the box. A typical use case is for discovery of printers that are advertised using MDNS. This should work even on potentially 'hostile' networks such as a wireless access point in a print shop or airport. It

Re: [libvirt] [PATCH 1/3] build: fix missing initializer error in qemu_process.c

2012-03-26 Thread Eric Blake
On 03/26/2012 12:53 PM, Laine Stump wrote: Found when attempting to build on Fedora 17 alpha with: ./autogen.sh --system --enable-compile-warnings=error (this same build command works without problem on Fedora 16). Since the consumer of the qemuProcessReconnectData doesn't assume that

Re: [libvirt] [PATCH 2/3] build: fix missing initializer errors in virsh.c

2012-03-26 Thread Eric Blake
On 03/26/2012 12:53 PM, Laine Stump wrote: Found when attempting to build on Fedora 17 alpha with: ./autogen.sh --system --enable-compile-warnings=error (this same build command works without problem on Fedora 16). All other struct initializers for this struct have the extra field

Re: [libvirt] [PATCH 3/3] build: avoid frame size error when building without -O2

2012-03-26 Thread Eric Blake
On 03/26/2012 12:53 PM, Laine Stump wrote: libvirt always adds -Werror-frame-larger-than=4096 to the flags when it builds. When building on Fedora 17, two functions with multiple 1024 buffers declared inside if {} blocks would generate frame size errors; apparently the version of gcc on Fedora

Re: [libvirt] Createion of external snapshot qcow2

2012-03-26 Thread Eric Blake
On 03/25/2012 11:18 PM, Pankaj Rawat wrote: Hi all, [your mailer uses lots of spurious whitespace] I have a query regarding the external snapshot in qcow2 also known as backing file. In qemu I created a external snapshot and then create its xml in order to boot it from VIRSH. But

Re: [libvirt] [PATCH] Expand docs for timer tick policy

2012-03-26 Thread Eric Blake
On 03/26/2012 06:29 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com --- docs/formatdomain.html.in | 25 - 1 files changed, 20 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index

[libvirt] [libvirt PATCHv7 1/1] add DHCP snooping

2012-03-26 Thread David L Stevens
This patch adds DHCP snooping support to libvirt. The learning method for IP addresses is specified by setting the ip_learning variable to one of any [default] (existing IP learning code), none (static only addresses) or dhcp (DHCP snooping). Active leases are saved in a lease file and reloaded

Re: [libvirt] [PATCH v2 2/2] Added syntax-check rule for return with parentheses

2012-03-26 Thread Eric Blake
On 03/26/2012 03:48 AM, Martin Kletzander wrote: On 03/26/2012 05:43 AM, Osier Yang wrote: On 2012年03月23日 15:34, Martin Kletzander wrote: After cleanup introduced with previous commit, there is a need for syntax-check rule taking care of return(). Regexp used in 'prohibit' parameter is taken

Re: [libvirt] Turning off libvirtd mdns by default

2012-03-26 Thread Doug Goldstein
On Mon, Mar 26, 2012 at 2:31 PM, Stef Walter st...@gnome.org wrote: In the GNOME UI we'd like to make use of Avahi discovery and name resolution out of the box. A typical use case is for discovery of printers that are advertised using MDNS. This should work even on potentially 'hostile'

Re: [libvirt] [PATCH 1/2] python: Add new helper functions for python to C integral conversion

2012-03-26 Thread Eric Blake
On 03/26/2012 12:10 AM, Guannan Ren wrote: int libvirt_intUnwrap(PyObject *obj, int *val); int libvirt_uintUnwrap(PyObject *obj, unsigned int *val); int libvirt_longUnwrap(PyObject *obj, long *val); int libvirt_ulongUnwrap(PyObject *obj, unsigned long *val); int

Re: [libvirt] [PATCH 2/2] python: make python APIs use these helper functions

2012-03-26 Thread Eric Blake
On 03/26/2012 12:11 AM, Guannan Ren wrote: *libvirt_virDomainGetCPUStats *setPyVirTypedParameter --- python/libvirt-override-api.xml |4 +- python/libvirt-override.c | 62 +- 2 files changed, 11 insertions(+), 55 deletions(-) Nice

[libvirt] [PATCH] qemu: Make migration fail when port profile association fails on the dst host

2012-03-26 Thread Christian Benvenuti (benve)
In the current V3 migration protocol, Libvirt does not check the result of the function qemuMigrationVPAssociatePortProfiles This means that it is possible for a migration to complete successfully even when the VM loses network connectivity on the destination host. With this change libvirt

Re: [libvirt] [PATCH] Add migration APIs for libxl driver

2012-03-26 Thread Chunyan Liu
2012/3/19 Daniel P. Berrange berra...@redhat.com On Fri, Mar 09, 2012 at 06:55:55PM +0800, Chunyan Liu wrote: diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index d5fa64a..5dc29a0 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c +static int

[libvirt] RFC: storage migration via pre-copy and streaming mirrors

2012-03-26 Thread Eric Blake
This is the counter-proposal to my earlier RFC for storage migration via snapshot mirrors[1], resulting from a NACK on the code review for that earlier proposal[2]. In particular, this proposal fleshes out some of Paolo's design overview on the qemu wiki[3]. [1]

Re: [libvirt] [PATCH 2/2] python: make python APIs use these helper functions

2012-03-26 Thread Guannan Ren
On 03/27/2012 07:11 AM, Eric Blake wrote: On 03/26/2012 12:11 AM, Guannan Ren wrote: *libvirt_virDomainGetCPUStats *setPyVirTypedParameter --- python/libvirt-override-api.xml |4 +- python/libvirt-override.c | 62 +- 2 files changed,

Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1

2012-03-26 Thread Jim Fehlig
Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) I have made a release candidate 1 tarball (and associated rpms) at

Re: [libvirt] [PATCH 1/2] python: Add new helper functions for python to C integral conversion

2012-03-26 Thread Guannan Ren
On 03/27/2012 07:03 AM, Eric Blake wrote: +int +libvirt_boolUnwrap(PyObject *obj, bool *val) +{ +int ret = -1; + +/* We only accept PyInt_Type, PyLong_Type and PyBool_Type + * as the boolean representation. Why? + */ +if (PyInt_Check(obj) || +PyLong_Check(obj) ||