Re: [libvirt] [test-API PATCHv2 1/2] sharemod: Add a new file for variable sharing in testcases

2012-04-16 Thread Osier Yang
s/sharing in/sharing among/, but given it's already pushed. let's live with it. On 2012年04月10日 21:38, Guannan Ren wrote: sharedmod.py --- sharedmod.py | 16 1 files changed, 16 insertions(+), 0 deletions(-) create mode 100644 sharedmod.py diff --git a/sharedmod.py

[libvirt] [test-API PATCH 2/3] improvement on comments function name and destruct logger handlers

2012-04-16 Thread Guannan Ren
generator.py libvirt-test-api.py mapper.py utils/log.py: add __del__() to destruct logger handlers when it go out of context --- generator.py|2 +- libvirt-test-api.py |1 + mapper.py | 14 +- utils/log.py|6

[libvirt] [test-API PATCH 1/3] cleanup:make clean function optional

2012-04-16 Thread Guannan Ren
The patch make the writing of clean function optional If a testcase makes testing environment dirty after running, it must write a CASENAME_clean function to restore back the testing environment, otherwise, the clean function could be omitted --- env_clear.py |9 -

[libvirt] [test-API PATCH 0/3] make clean function optional

2012-04-16 Thread Guannan Ren
The set of patches is to make the writing of clean function optional. If a testcase which doesn't dirty the testing environment, then the TESTCASE_clean function could be optional or omitted. Because loggers in python are static objects managed by the module itself. When you create one, it

[libvirt] [test-API PATCH 2/2] proxy: import each testcase file only once, initialize proxy once

2012-04-16 Thread Guannan Ren
*libvirt-test-api.py: initialize proxy module only once *casecfgcheck.py: use proxy object rather than initialize it by itself *proxy.py: make get_func_call_dict more flexible --- casecfgcheck.py |5 + libvirt-test-api.py | 12 +--- proxy.py

[libvirt] [test-API PATCH 1/2] add a new option -t to print template of testcase config file

2012-04-16 Thread Guannan Ren
If a given testcase has clean function, the clean flag will be used automatically # python libvirt-test-api.py -t repos/domain/attach_disk.py \ repos/storage/create_netfs_pool.py \ repos/domain/save.py output:

[libvirt] [test-API PATCH 3/3] repo: cleanup clean functions that are not used

2012-04-16 Thread Guannan Ren
--- repos/domain/attach_disk.py|4 repos/domain/autostart.py |4 repos/domain/balloon_memory.py |4 repos/domain/blkstats.py |4 repos/domain/console_mutex.py

Re: [libvirt] [test-API PATCH 0/3] make clean function optional

2012-04-16 Thread Osier Yang
On 2012年04月16日 14:11, Guannan Ren wrote: The set of patches is to make the writing of clean function optional. If a testcase which doesn't dirty the testing environment, then the TESTCASE_clean function could be optional or omitted. Good, this was one of the TODO thing in my mind. Because

Re: [libvirt] [test-API PATCH 3/3] repo: cleanup clean functions that are not used

2012-04-16 Thread Osier Yang
On 2012年04月16日 14:11, Guannan Ren wrote: --- repos/domain/attach_disk.py|4 repos/domain/autostart.py |4 repos/domain/balloon_memory.py |4 repos/domain/blkstats.py |

[libvirt] [test-API PATCH 0/5] add TESTCASE_check optional function support

2012-04-16 Thread Guannan Ren
In some cases, we need to check if the testing environment is satisfied to run a certain testcase. The testcase only will be executed If some specific hardware is present on box. The patches add a optional check function support. For example: a testcase named testa.py with testa_check() defined

[libvirt] [test-API PATCH 2/5] generator: calling testcase_check if it is present in testcase

2012-04-16 Thread Guannan Ren
*calling testcase_check() if testcase defined it. On pass, run testcase(), otherwise, skip the testcase. *add Skip counting *because we don't treat clean flag as a seprate call, so we run clean function based on the check of clean flag on testcase name that returned by

[libvirt] [test-API PATCH 1/5] mapper: don't treat clean flag as a testcase

2012-04-16 Thread Guannan Ren
Original, the clean flag work with previous testcase to form a separate call request to generator. the patch will append :clean to previous testcase to mark that the previous testcase needs to clean after running. It make counting of testcase number easier. And rename the

[libvirt] [test-API PATCH 4/5] libvirt-test-api: get reference to check function in testcases

2012-04-16 Thread Guannan Ren
*proxy_obj.get_optionalfunc_call_dict('check') to get references to 'check' function that defined in testcases, and pass them to generator for running later --- libvirt-test-api.py |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/libvirt-test-api.py

[libvirt] [test-API PATCH 3/5] proxy: generalize function get_optionalfunc_call_dict

2012-04-16 Thread Guannan Ren
*make get_optionalfunc_call_dict work for both testcase_check() and testcase_clean() *imporve the code readability --- proxy.py | 26 ++ 1 files changed, 14 insertions(+), 12 deletions(-) diff --git a/proxy.py b/proxy.py index 49a0420..32a8eb2 100644 ---

[libvirt] [test-API PATCH 5/5] function and variable name improvement

2012-04-16 Thread Guannan Ren
*env_clear.py *utils/format.py we use 2 for skip flag --- env_clear.py| 26 +- utils/format.py |2 +- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/env_clear.py b/env_clear.py index 2e5bcf5..a5dc4fa 100644 --- a/env_clear.py +++

Re: [libvirt] [test-API PATCH 1/3] cleanup:make clean function optional

2012-04-16 Thread Osier Yang
s/cleanup:make/cleanup: Make/ On 2012年04月16日 14:11, Guannan Ren wrote: The patch make the writing of clean function optional If a testcase makes testing environment dirty after running, it If a case dirties the testing environment, must write a CASENAME_clean function to

Re: [libvirt] [test-API PATCH 0/2] support variables share across testcases

2012-04-16 Thread Guannan Ren
On 04/16/2012 10:03 AM, Osier Yang wrote: On 2012年04月06日 17:53, Guannan Ren wrote: An example: #sharedvar.cfg domain:testa domain:testb #testa.py import sharedmod def testa(params): conn = sharedmod.conn logger = params['logger'] Given that the connection object is shared among test

Re: [libvirt] [PATCH] domain:screenshot: Added cleanup function

2012-04-16 Thread Martin Kletzander
On 04/16/2012 04:43 AM, Osier Yang wrote: On 2012年04月13日 23:44, Martin Kletzander wrote: Added cleanup function to the screeshot testcase. This makes use of the new sharedmod module. --- WARNING: don't push this before the patch with sharedmod is pushed in the repo, otherwise this will not

Re: [libvirt] [PATCH] openvz: wire up more node information functions

2012-04-16 Thread Guido Günther
On Mon, Apr 16, 2012 at 09:48:38AM +0800, Osier Yang wrote: On 2012年04月15日 04:20, Guido Günther wrote: in detail nodeGetCPUStats, nodeGetMemoryStats, nodeGetCellsFreeMemory and nodeGetFreeMemory --- src/openvz/openvz_driver.c |4 1 file changed, 4 insertions(+) diff --git

Re: [libvirt] [PATCH 1/3] numad: Convert node list to cpumap before setting affinity

2012-04-16 Thread Daniel Veillard
On Wed, Apr 11, 2012 at 10:40:32PM +0800, Osier Yang wrote: Instead of returning a CPUs list, numad returns NUMA node list instead, this patch is to convert the node list to cpumap before affinity setting. Otherwise, the domain processes will be pinned only to CPU[$numa_cell_num], which will

Re: [libvirt] [PATCH 2/3] numad: Ignore cpuset if placement is auto

2012-04-16 Thread Daniel Veillard
On Wed, Apr 11, 2012 at 10:40:33PM +0800, Osier Yang wrote: As explained in previous patch, numad will balance the affinity dynamically, so reflecting the cpuset from numad at the first time doesn't make much case, and may just could cause confusion. --- docs/formatdomain.html.in | 10

Re: [libvirt] [PATCH 3/3] qemu: Avoid the memory allocation and freeing

2012-04-16 Thread Daniel Veillard
On Wed, Apr 11, 2012 at 10:40:34PM +0800, Osier Yang wrote: --- src/qemu/qemu_process.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 0bf743b..7a48c12 100644 --- a/src/qemu/qemu_process.c +++

Re: [libvirt] [test-API PATCH 2/2] proxy: import each testcase file only once, initialize proxy once

2012-04-16 Thread Martin Kletzander
On 04/16/2012 08:15 AM, Guannan Ren wrote: *libvirt-test-api.py: initialize proxy module only once *casecfgcheck.py: use proxy object rather than initialize it by itself *proxy.py: make get_func_call_dict more flexible --- casecfgcheck.py |5 +

Re: [libvirt] [PATCH] domain:screenshot: Added cleanup function

2012-04-16 Thread Osier Yang
On 2012年04月16日 14:52, Martin Kletzander wrote: On 04/16/2012 04:43 AM, Osier Yang wrote: On 2012年04月13日 23:44, Martin Kletzander wrote: Added cleanup function to the screeshot testcase. This makes use of the new sharedmod module. --- WARNING: don't push this before the patch with sharedmod is

Re: [libvirt] [test-API PATCHv2 1/2] sharemod: Add a new file for variable sharing in testcases

2012-04-16 Thread Martin Kletzander
On 04/16/2012 08:03 AM, Osier Yang wrote: s/sharing in/sharing among/, but given it's already pushed. let's live with it. On 2012年04月10日 21:38, Guannan Ren wrote: sharedmod.py --- sharedmod.py | 16 1 files changed, 16 insertions(+), 0 deletions(-) create

Re: [libvirt] [PATCH] domain:screenshot: Added cleanup function

2012-04-16 Thread Martin Kletzander
On 04/16/2012 10:00 AM, Osier Yang wrote: On 2012年04月16日 14:52, Martin Kletzander wrote: On 04/16/2012 04:43 AM, Osier Yang wrote: On 2012年04月13日 23:44, Martin Kletzander wrote: Added cleanup function to the screeshot testcase. This makes use of the new sharedmod module. --- WARNING: don't

Re: [libvirt] [test-API PATCH 1/3] cleanup:make clean function optional

2012-04-16 Thread Guannan Ren
On 04/16/2012 02:34 PM, Osier Yang wrote: s/cleanup:make/cleanup: Make/ On 2012年04月16日 14:11, Guannan Ren wrote: The patch make the writing of clean function optional If a testcase makes testing environment dirty after running, it If a case dirties the testing environment,

Re: [libvirt] [test-API PATCH 3/3] repo: cleanup clean functions that are not used

2012-04-16 Thread Guannan Ren
On 04/16/2012 02:26 PM, Osier Yang wrote: On 2012年04月16日 14:11, Guannan Ren wrote: --- repos/domain/attach_disk.py|4 repos/domain/autostart.py |4 repos/domain/balloon_memory.py |4

Re: [libvirt] [test-API PATCH 0/3] make clean function optional

2012-04-16 Thread Guannan Ren
On 04/16/2012 02:20 PM, Osier Yang wrote: On 2012年04月16日 14:11, Guannan Ren wrote: The set of patches is to make the writing of clean function optional. If a testcase which doesn't dirty the testing environment, then the TESTCASE_clean function could be optional or omitted. Good, this was

Re: [libvirt] [test-API PATCH 2/2] proxy: import each testcase file only once, initialize proxy once

2012-04-16 Thread Guannan Ren
On 04/16/2012 03:54 PM, Martin Kletzander wrote: On 04/16/2012 08:15 AM, Guannan Ren wrote: *libvirt-test-api.py: initialize proxy module only once *casecfgcheck.py: use proxy object rather than initialize it by itself *proxy.py: make get_func_call_dict

[libvirt] [libvirt-test-API PATCH] domain:screenshot: Added cleanup function

2012-04-16 Thread Martin Kletzander
--- v2: - removed sharedmod for persistence of the filename repos/domain/screenshot.py |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/repos/domain/screenshot.py b/repos/domain/screenshot.py index 82425f3..2761dc5 100644 --- a/repos/domain/screenshot.py +++

Re: [libvirt] [PATCH 1/3] numad: Convert node list to cpumap before setting affinity

2012-04-16 Thread Osier Yang
On 2012年04月16日 15:45, Daniel Veillard wrote: On Wed, Apr 11, 2012 at 10:40:32PM +0800, Osier Yang wrote: Instead of returning a CPUs list, numad returns NUMA node list instead, this patch is to convert the node list to cpumap before affinity setting. Otherwise, the domain processes will be

Re: [libvirt] [libvirt-test-API PATCH] domain:screenshot: Added cleanup function

2012-04-16 Thread Osier Yang
On 2012年04月16日 17:32, Martin Kletzander wrote: --- v2: - removed sharedmod for persistence of the filename repos/domain/screenshot.py |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/repos/domain/screenshot.py b/repos/domain/screenshot.py index

Re: [libvirt] [libvirt-test-API PATCH] domain:screenshot: Added cleanup function

2012-04-16 Thread Martin Kletzander
On 04/16/2012 12:14 PM, Osier Yang wrote: On 2012年04月16日 17:32, Martin Kletzander wrote: --- v2: - removed sharedmod for persistence of the filename repos/domain/screenshot.py |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/repos/domain/screenshot.py

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Cole Robinson
On 04/13/2012 09:14 AM, Stefan Bader wrote: I think it would be better if we just centralized this logic, as in, only set that (type ioemu) bit in conditional rather than 2. Should be pretty straightforward. Did you have something like below in mind? -Stefan From

[libvirt] cgroup cpuset limited by default?

2012-04-16 Thread Marc-André Lureau
Hi, I noticed recently that my system VMs feel much slower, and that seems to be because of cpuset cgroup which constrain the VM on the first cpu. This doesn't happen with session VMs, since they are not ruled by cgroup. I run f17 with libvirt git, the VMs are created with virt-manager, using

Re: [libvirt] [PATCH] storage: lvm: use correct lv* command parameters

2012-04-16 Thread Cole Robinson
On 04/15/2012 09:22 PM, Osier Yang wrote: On 2012幎04月13日 22:09, Cole Robinson wrote: On 04/13/2012 09:03 AM, Osier Yang wrote: On 04/13/2012 07:50 PM, Cole Robinson wrote: lvcreate want's the parent pool's name, not the pool path lvchange and lvremove want lv specified as

Re: [libvirt] cgroup cpuset limited by default?

2012-04-16 Thread Srivatsa S. Bhat
On 04/16/2012 05:34 PM, Marc-André Lureau wrote: Hi, I noticed recently that my system VMs feel much slower, and that seems to be because of cpuset cgroup which constrain the VM on the first cpu. This doesn't happen with session VMs, since they are not ruled by cgroup. I run f17 with

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Stefan Bader
On 16.04.2012 13:58, Cole Robinson wrote: On 04/13/2012 09:14 AM, Stefan Bader wrote: I think it would be better if we just centralized this logic, as in, only set that (type ioemu) bit in conditional rather than 2. Should be pretty straightforward. Did you have something like below in mind?

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Cole Robinson
On 04/16/2012 08:36 AM, Stefan Bader wrote: On 16.04.2012 13:58, Cole Robinson wrote: On 04/13/2012 09:14 AM, Stefan Bader wrote: I think it would be better if we just centralized this logic, as in, only set that (type ioemu) bit in conditional rather than 2. Should be pretty straightforward.

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Stefan Bader
On 16.04.2012 14:45, Cole Robinson wrote: On 04/16/2012 08:36 AM, Stefan Bader wrote: On 16.04.2012 13:58, Cole Robinson wrote: On 04/13/2012 09:14 AM, Stefan Bader wrote: I think it would be better if we just centralized this logic, as in, only set that (type ioemu) bit in conditional rather

Re: [libvirt] [PATCHv4 08/18] blockjob: react to active block copy

2012-04-16 Thread Jiri Denemark
On Fri, Apr 13, 2012 at 09:28:08 -0600, Eric Blake wrote: On 04/13/2012 05:35 AM, Jiri Denemark wrote: On Mon, Apr 09, 2012 at 21:52:17 -0600, Eric Blake wrote: For now, disk migration via block copy job is not implemented. But when we do implement it, we have to deal with the fact that

Re: [libvirt] [PATCH] Do not enforce source type of console[0]

2012-04-16 Thread Jan Kiszka
On 2012-03-13 16:48, Jan Kiszka wrote: If console[0] is an alias for serial[0], do not enforce the former to have a PTY source type. This breaks serial consoles on stdio and makes no sense. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- src/qemu/qemu_process.c |1 - 1 files

Re: [libvirt] [PATCHv4 12/18] blockjob: implement block copy for qemu

2012-04-16 Thread Jiri Denemark
On Fri, Apr 13, 2012 at 09:15:18 -0600, Eric Blake wrote: On 04/13/2012 08:46 AM, Jiri Denemark wrote: I guess I wasn't paying enough attention somewhere but why do we forbid block copy for persistent domains? I understand why we want to forbid certain operations when block copy is

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Stefan Bader
On 16.04.2012 14:54, Stefan Bader wrote: On 16.04.2012 14:45, Cole Robinson wrote: On 04/16/2012 08:36 AM, Stefan Bader wrote: On 16.04.2012 13:58, Cole Robinson wrote: On 04/13/2012 09:14 AM, Stefan Bader wrote: I think it would be better if we just centralized this logic, as in, only set

[libvirt] [PATCH] docs: fix path to openvz network configuration file

2012-04-16 Thread Guido Günther
It's vznet.conf not vznetctl.conf, see e.g.: http://git.openvz.org/?p=vzctl;a=blob;f=bin/vznetcfg.in;h=e91f5c4a0744c1ea149e1b8c241b666052e10b12;hb=HEAD --- docs/drvopenvz.html.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drvopenvz.html.in

Re: [libvirt] [PATCH] docs: fix path to openvz network configuration file

2012-04-16 Thread Michal Privoznik
On 16.04.2012 16:21, Guido Günther wrote: It's vznet.conf not vznetctl.conf, see e.g.: http://git.openvz.org/?p=vzctl;a=blob;f=bin/vznetcfg.in;h=e91f5c4a0744c1ea149e1b8c241b666052e10b12;hb=HEAD --- docs/drvopenvz.html.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Qualifies

Re: [libvirt] [PATCHv4 16/18] blockjob: add virDomainBlockCopy

2012-04-16 Thread Jiri Denemark
On Fri, Apr 13, 2012 at 15:42:20 -0600, Eric Blake wrote: On 04/13/2012 03:25 PM, Jiri Denemark wrote: On Mon, Apr 09, 2012 at 21:52:25 -0600, Eric Blake wrote: This new API provides additional flexibility over what can be crammed on top of virDomainBlockRebase (namely, the ability to

Re: [libvirt] [PATCH] docs: fix path to openvz network configuration file

2012-04-16 Thread Daniel P. Berrange
On Mon, Apr 16, 2012 at 04:21:01PM +0200, Guido Günther wrote: It's vznet.conf not vznetctl.conf, see e.g.: http://git.openvz.org/?p=vzctl;a=blob;f=bin/vznetcfg.in;h=e91f5c4a0744c1ea149e1b8c241b666052e10b12;hb=HEAD --- docs/drvopenvz.html.in |2 +- 1 file changed, 1 insertion(+), 1

[libvirt] [PATCH RESEND] qemuProcessStart: Switch to flags instead of bunch booleans

2012-04-16 Thread Michal Privoznik
Currently, we have 3 boolean arguments we have to pass to qemuProcessStart(). As libvirt grows it is harder and harder to remember them and their position. Therefore we should switch to flags instead. --- This is just rebased version of:

Re: [libvirt] [PATCH RESEND] qemuProcessStart: Switch to flags instead of bunch booleans

2012-04-16 Thread Daniel P. Berrange
On Mon, Apr 16, 2012 at 04:55:41PM +0200, Michal Privoznik wrote: Currently, we have 3 boolean arguments we have to pass to qemuProcessStart(). As libvirt grows it is harder and harder to remember them and their position. Therefore we should switch to flags instead. --- This is just rebased

Re: [libvirt] [PATCH] docs: fix path to openvz network configuration file

2012-04-16 Thread Guido Günther
On Mon, Apr 16, 2012 at 03:27:28PM +0100, Daniel P. Berrange wrote: On Mon, Apr 16, 2012 at 04:21:01PM +0200, Guido Günther wrote: It's vznet.conf not vznetctl.conf, see e.g.: http://git.openvz.org/?p=vzctl;a=blob;f=bin/vznetcfg.in;h=e91f5c4a0744c1ea149e1b8c241b666052e10b12;hb=HEAD ---

[libvirt] [ANNOUNCE] Perl binding Sys-Virt release 0.9.11

2012-04-16 Thread Daniel P. Berrange
I am pleased to announce that release 0.9.11 of Sys-Virt, the libvirt Perl API binding is now available for download: http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.9.11.tar.gz Changed in this release: - Add all new APIs in libvirt 0.9.11 - Add test case to validate API

[libvirt] [PATCH V10 6/7] nwfilter: Add multiple IP address support to DHCP snooping

2012-04-16 Thread Stefan Berger
With support for multiple IP addresses per interface in place, this patch now adds support for multiple IP addresses per interface for the DHCP snooping code. Testing: Since the infrastructure I tested this with does not provide multiple IP addresses per MAC address (anymore), I either had to

[libvirt] [PATCH V10 5/7] nwfilter: move code for IP address map into separate file

2012-04-16 Thread Stefan Berger
The goal of this patch is to prepare for support for multiple IP addresses per interface in the DHCP snooping code. Move the code for the IP address map that maps interface names to IP addresses into their own file. Rename the functions on the way but otherwise leave the code as-is. Initialize

[libvirt] [PATCH V10 7/7] nwfilter: Display detected IP address in domain XML

2012-04-16 Thread Stefan Berger
Display detected IP addresses in the domain XML using the IP_LEASE variable name. This variable name now becomes a reserved variable name that can be read only but not set by the user. The format of the value is: ip addresss,lease timeout in seconds An example of a displayed XML may then be:

[libvirt] [PATCH V10 2/7] Support for atomic operations on integers

2012-04-16 Thread Stefan Berger
For threading support, add atomic add and sub operations working on integers. Base this on locking support provided by virMutex. --- src/util/viratomic.h | 91 +++ 1 file changed, 91 insertions(+) Index: libvirt-acl/src/util/viratomic.h

[libvirt] [PATCH V10 3/7] nwfilter: Fix support for trusted DHCP servers

2012-04-16 Thread Stefan Berger
Fix the support for trusted DHCP server in the ebtables code's hard-coded function applying DHCP only filtering rules: Rather than using a char * use the more flexible virNWFilterVarValuePtr that contains the trusted DHCP server(s) IP address. Process all entries. Since all callers so far

[libvirt] [PATCH V10 1/7] Implement virHashRemoveAll function

2012-04-16 Thread Stefan Berger
Implement function to remove all entries of a hash table. --- src/libvirt_private.syms |1 + src/util/virhash.c | 25 + src/util/virhash.h |5 + 3 files changed, 31 insertions(+) Index: libvirt-acl/src/libvirt_private.syms

[libvirt] [PATCH v2] qemuProcessStart: Switch to flags instead of bunch booleans

2012-04-16 Thread Michal Privoznik
Currently, we have 3 boolean arguments we have to pass to qemuProcessStart(). As libvirt grows it is harder and harder to remember them and their position. Therefore we should switch to flags instead. --- diff to v1: -fix a test for START_PAUSED flag src/qemu/qemu_driver.c| 45

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Cole Robinson
On 04/16/2012 10:11 AM, Stefan Bader wrote: On 16.04.2012 14:54, Stefan Bader wrote: On 16.04.2012 14:45, Cole Robinson wrote: On 04/16/2012 08:36 AM, Stefan Bader wrote: On 16.04.2012 13:58, Cole Robinson wrote: On 04/13/2012 09:14 AM, Stefan Bader wrote: I think it would be better if we

[libvirt] [libvirt-test-API PATCH 2/2] Documentation: Update to current information

2012-04-16 Thread Martin Kletzander
Update of all the things found to be outdated. The test described in the chapter Writing a test case was changed to simpler one, with only one source file included. It shows how to use the libvirt API (no need for connectAPI etc. anymore) and mainly libvirt test API. ---

Re: [libvirt] [PATCH v2] qemuProcessStart: Switch to flags instead of bunch booleans

2012-04-16 Thread Daniel P. Berrange
On Mon, Apr 16, 2012 at 05:09:59PM +0200, Michal Privoznik wrote: Currently, we have 3 boolean arguments we have to pass to qemuProcessStart(). As libvirt grows it is harder and harder to remember them and their position. Therefore we should switch to flags instead. --- diff to v1: -fix a

[libvirt] [libvirt-test-API PATCH 1/2] domain:screenshot: fixes and cleanup

2012-04-16 Thread Martin Kletzander
After the conn object was transferred into sharedmod, its import was missing. I also cleaned up and commented few lines in order to use them for documentation purposes. --- repos/domain/screenshot.py | 45 ++- 1 files changed, 35 insertions(+), 10

Re: [libvirt] [PATCH v2] qemuProcessStart: Switch to flags instead of bunch booleans

2012-04-16 Thread Michal Privoznik
On 16.04.2012 17:26, Daniel P. Berrange wrote: On Mon, Apr 16, 2012 at 05:09:59PM +0200, Michal Privoznik wrote: Currently, we have 3 boolean arguments we have to pass to qemuProcessStart(). As libvirt grows it is harder and harder to remember them and their position. Therefore we should

[libvirt] [libvirt-test-API PATCH 0/2] Documentation update

2012-04-16 Thread Martin Kletzander
I updated part of the documentation that was changed in last few weeks. Screenshot test was updated again a little bit to suit the needs of a documentation and replaced the source codes of previous two tests mentioned in the documentation as it describe just what is needed and has no overhead on

[libvirt] OpenSSH authentification in Java libvirt API

2012-04-16 Thread Alexandre Garnier
Hello, It seems that today you can’t authenticate on a qemu+ssh connection via OpenSSH without having to manually type the password in CLI or a pop-up window, using the Java API for libvirt. Being able to push a String in OpenSSH user input would be an easier and faster solution, for the

Re: [libvirt] cgroup cpuset limited by default?

2012-04-16 Thread Marc-André Lureau
Hi On Mon, Apr 16, 2012 at 2:32 PM, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com wrote: On 04/16/2012 05:34 PM, Marc-André Lureau wrote: Did you happen to perform a suspend/resume or a hibernation/restore on your computer? (Or did you do CPU hotplug manually?) If yes, you might be

Re: [libvirt] [PATCH] Do not enforce source type of console[0]

2012-04-16 Thread Cole Robinson
On 04/16/2012 09:47 AM, Jan Kiszka wrote: On 2012-03-13 16:48, Jan Kiszka wrote: If console[0] is an alias for serial[0], do not enforce the former to have a PTY source type. This breaks serial consoles on stdio and makes no sense. Signed-off-by: Jan Kiszka jan.kis...@siemens.com ---

Re: [libvirt] cgroup cpuset limited by default?

2012-04-16 Thread Daniel P. Berrange
On Mon, Apr 16, 2012 at 06:00:22PM +0200, Marc-André Lureau wrote: Hi On Mon, Apr 16, 2012 at 2:32 PM, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com wrote: On 04/16/2012 05:34 PM, Marc-André Lureau wrote: Did you happen to perform a suspend/resume or a hibernation/restore on your

[libvirt] 2 trivial doc patches

2012-04-16 Thread Christophe Fergeau
Hey, I've just pushed these 2 documentation patches under the trivial rule. Christophe -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/2] docs: add missing /span in vcpu placement doc

2012-04-16 Thread Christophe Fergeau
--- docs/formatdomain.html.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index bb67cd1..e08a3d2 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -359,7 +359,7 @@ 0.8.5/span, the

[libvirt] [PATCH 2/2] docs: fix 'omitted' typo in cputune doc

2012-04-16 Thread Christophe Fergeau
'omitted' was mispelt 'commited' twice. One of the sentences with the typo was also missing an 'is' ('each VCPU *is* pinned to all...') which I added in this commit while I was at it. --- docs/formatdomain.html.in |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [libvirt] [PATCHv4 15/18] blockjob: accommodate RHEL backport names

2012-04-16 Thread Eric Blake
On 04/09/2012 09:52 PM, Eric Blake wrote: RHEL-only drive-mirror and drive-reopen are still under upstream qemu discussion; as a result, RHEL decided to backport things under a downstream name. Accommodate this alternate spelling. I don't think it's worth trying to support both spellings

[libvirt] [PATCH V10 0/7] Add DHCP snooping support to nwfilter

2012-04-16 Thread Stefan Berger
This series of patches adds DHCP snooping support to libvirt's nwfilter subsystem. DHCP snooping detects DHCP leases obtained by a VM and automatically adjusts the network traffic filters to reflect the IP addresses with which a VM may send its traffic, thus for example preventing IP address

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Stefan Bader
On 16.04.2012 17:21, Cole Robinson wrote: On 04/16/2012 10:11 AM, Stefan Bader wrote: On 16.04.2012 14:54, Stefan Bader wrote: On 16.04.2012 14:45, Cole Robinson wrote: On 04/16/2012 08:36 AM, Stefan Bader wrote: On 16.04.2012 13:58, Cole Robinson wrote: On 04/13/2012 09:14 AM, Stefan Bader

Re: [libvirt] [PATCH V10 0/7] Add DHCP snooping support to nwfilter

2012-04-16 Thread dennis jenkins
On Mon, Apr 16, 2012 at 10:08 AM, Stefan Berger stef...@linux.vnet.ibm.comwrote: This series of patches adds DHCP snooping support to libvirt's nwfilter subsystem. Stefan, David, Thank you very much for this functionality. As a side-effect, it solves a problem that I needed addressed:

Re: [libvirt] [PATCH V10 0/7] Add DHCP snooping support to nwfilter

2012-04-16 Thread Stefan Berger
On 04/16/2012 03:12 PM, dennis jenkins wrote: On Mon, Apr 16, 2012 at 10:08 AM, Stefan Berger stef...@linux.vnet.ibm.com mailto:stef...@linux.vnet.ibm.com wrote: This series of patches adds DHCP snooping support to libvirt's nwfilter subsystem. Stefan, David, Thank you very much

Re: [libvirt] [PATCH V10 0/7] Add DHCP snooping support to nwfilter

2012-04-16 Thread dennis jenkins
On Mon, Apr 16, 2012 at 2:22 PM, Stefan Berger stef...@linux.vnet.ibm.comwrote: ** On 04/16/2012 03:12 PM, dennis jenkins wrote: On Mon, Apr 16, 2012 at 10:08 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote: This series of patches adds DHCP snooping support to libvirt's nwfilter

Re: [libvirt] virsh list hangs

2012-04-16 Thread Eric Blake
[please don't top-post on technical lists] On 04/15/2012 03:30 AM, Qian Zhang wrote: I think what happened to me is https://bugzilla.redhat.com/show_bug.cgi?id=757382 which is a dead lock issue between libvirtd process and its child process. It looks this issue has been fixed for Fedora 16,

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Cole Robinson
On 04/16/2012 02:06 PM, Stefan Bader wrote: On 16.04.2012 17:21, Cole Robinson wrote: On 04/16/2012 10:11 AM, Stefan Bader wrote: On 16.04.2012 14:54, Stefan Bader wrote: On 16.04.2012 14:45, Cole Robinson wrote: On 04/16/2012 08:36 AM, Stefan Bader wrote: On 16.04.2012 13:58, Cole Robinson

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Eric Blake
[adding direct cc to Osier] On 04/16/2012 01:58 PM, Cole Robinson wrote: Rebasing to HEAD made things rather worse... now 3 checks are failing (without my patch)... Might be something simple like missing a build dep. Try getting some debug output from the tests and it might be clear. If

Re: [libvirt] [PATCH] openvz: wire up more node information functions

2012-04-16 Thread Eric Blake
On 04/16/2012 01:00 AM, Guido Günther wrote: On Mon, Apr 16, 2012 at 09:48:38AM +0800, Osier Yang wrote: On 2012年04月15日 04:20, Guido Günther wrote: in detail nodeGetCPUStats, nodeGetMemoryStats, nodeGetCellsFreeMemory and nodeGetFreeMemory --- src/openvz/openvz_driver.c |4 1 file

Re: [libvirt] VN-Link vNIC memory state copying on VM Migration

2012-04-16 Thread Christian Benvenuti (benve)
Jagath, -Original Message- From: Jagath Weerasinghe [mailto:jagf...@gmail.com] Sent: Sunday, April 15, 2012 6:59 AM To: Christian Benvenuti (benve) Cc: libvir-list@redhat.com Subject: Re: [libvirt] VN-Link vNIC memory state copying on VM Migration Chris, Thanks the explanation

Re: [libvirt] [PATCHv4 12/18] blockjob: implement block copy for qemu

2012-04-16 Thread Eric Blake
On 04/13/2012 09:15 AM, Eric Blake wrote: On 04/13/2012 08:46 AM, Jiri Denemark wrote: On Mon, Apr 09, 2012 at 21:52:21 -0600, Eric Blake wrote: Minimal patch to wire up all the pieces in the previous patches to actually enable a block copy job. By minimal, I mean that qemu creates the file

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Osier Yang
On 2012年04月17日 04:17, Eric Blake wrote: [adding direct cc to Osier] On 04/16/2012 01:58 PM, Cole Robinson wrote: Rebasing to HEAD made things rather worse... now 3 checks are failing (without my patch)... Might be something simple like missing a build dep. Try getting some debug output from

Re: [libvirt] [PATCH] openvz: wire up more node information functions

2012-04-16 Thread Osier Yang
On 2012年04月17日 05:53, Eric Blake wrote: On 04/16/2012 01:00 AM, Guido Günther wrote: On Mon, Apr 16, 2012 at 09:48:38AM +0800, Osier Yang wrote: On 2012年04月15日 04:20, Guido Günther wrote: in detail nodeGetCPUStats, nodeGetMemoryStats, nodeGetCellsFreeMemory and nodeGetFreeMemory ---

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Eric Blake
On 04/16/2012 08:05 PM, Osier Yang wrote: [09:31]danpb1eblake: the fact that we see that error message suggest a pre-existing bug in the test suite - the XML being used to define the test domain is missing a UUID [09:31]danpb1eblake: so the 2 repeated defines get different

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Osier Yang
On 2012年04月17日 10:44, Eric Blake wrote: On 04/16/2012 08:05 PM, Osier Yang wrote: [09:31]danpb1eblake: the fact that we see that error message suggest a pre-existing bug in the test suite - the XML being used to define the test domain is missing a UUID [09:31]danpb1eblake: so

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Eric Blake
On 04/16/2012 09:03 PM, Osier Yang wrote: On 2012年04月17日 10:44, Eric Blake wrote: On 04/16/2012 08:05 PM, Osier Yang wrote: [09:31]danpb1eblake: the fact that we see that error message suggest a pre-existing bug in the test suite - the XML being used to define the test domain is

[libvirt] [test-API] add docs files TESTCASE.py and TESTCASES.conf

2012-04-16 Thread Guannan Ren
*docs/TESTCASE.py: an template of testcase.py *docs/TESTCASES.conf: an template of testcase config file with simple explanation --- docs/TESTCASE.py| 45 docs/TESTCASES.conf | 70

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Eric Blake
On 04/16/2012 05:58 AM, Cole Robinson wrote: On 04/13/2012 09:14 AM, Stefan Bader wrote: I think it would be better if we just centralized this logic, as in, only set that (type ioemu) bit in conditional rather than 2. Should be pretty straightforward. Did you have something like below in

Re: [libvirt] [PATCH] Do not enforce source type of console[0]

2012-04-16 Thread Eric Blake
On 04/16/2012 10:05 AM, Cole Robinson wrote: On 04/16/2012 09:47 AM, Jan Kiszka wrote: On 2012-03-13 16:48, Jan Kiszka wrote: If console[0] is an alias for serial[0], do not enforce the former to have a PTY source type. This breaks serial consoles on stdio and makes no sense. Signed-off-by:

Re: [libvirt] [PATCH v2] libvirt: xen: do not use ioemu type for any emulated NIC

2012-04-16 Thread Osier Yang
On 2012年04月17日 11:38, Eric Blake wrote: On 04/16/2012 09:03 PM, Osier Yang wrote: On 2012年04月17日 10:44, Eric Blake wrote: On 04/16/2012 08:05 PM, Osier Yang wrote: [09:31]danpb1eblake: the fact that we see that error message suggest a pre-existing bug in the test suite - the XML being

[libvirt] [PATCHv5 04/23] blockjob: add new API flags

2012-04-16 Thread Eric Blake
This patch introduces a new block job, useful for live storage migration using pre-copy streaming. Justification for including this under virDomainBlockRebase rather than adding a new command includes: 1) there are now two possible block jobs in qemu, with virDomainBlockRebase starting either

[libvirt] [PATCHv5 02/23] qemu: use consistent error when qemu binary is too old

2012-04-16 Thread Eric Blake
Most of our errors complaining about an inability to support a particular action due to qemu limitations used CONFIG_UNSUPPORTED, but we had a few outliers. Reported by Jiri Denemark. * src/qemu/qemu_command.c (qemuBuildDriveDevStr): Prefer CONFIG_UNSUPPORTED. * src/qemu/qemu_driver.c

[libvirt] [PATCHv5 00/23] live block migration

2012-04-16 Thread Eric Blake
This series shows how to do live block migration using both streaming mirror (as proposed for upstream qemu 1.1) and snapshot+mirror (as proposed for RHEL 6.3, although not as actively tested, since streaming mirror seems so much nicer). v4 (blockjob):

[libvirt] [PATCHv5 01/23] virsh: minor syntactic cleanups

2012-04-16 Thread Eric Blake
No semantic change. * tools/virsh.c: Fix some spacing issues, {} usage, long lines, and redundant (). --- v5: new patch, factored out from comments on other patches tools/virsh.c | 197 + 1 files changed, 100 insertions(+), 97

[libvirt] [PATCHv5 05/23] blockjob: add 'blockcopy' to virsh

2012-04-16 Thread Eric Blake
Rather than further overloading 'blockpull', I decided to create a new virsh command to expose the new flags of virDomainBlockRebase. Blocking until the command completes naturally is pointless, since the block copy job is intended to run indefinitely. Instead, I made the command support three

[libvirt] [PATCHv5 12/23] blockjob: relax block job behavior when setting speed up front

2012-04-16 Thread Eric Blake
In qemu, it is possible to call 'migrate_set_speed' prior to 'migrate', and therefore ensure a constant throttling through the entire migration. However, this is not possible with 'block-job-set-speed', which fails if a job is not already active. This means that you can't detect a device that

  1   2   >