On 04/26/2012 04:46 AM, Eric Blake wrote:
On 04/25/2012 02:01 PM, Laine Stump wrote:
This patch resolves https://bugzilla.redhat.com/show_bug.cgi?id=815270
The function virNetDevMacVLanVPortProfileRegisterCallback() takes an
arg virtPortProfile, and was checking it for non-NULL before using
On 04/25/2012 04:46 PM, Eric Blake wrote:
On 04/25/2012 02:01 PM, Laine Stump wrote:
This patch resolves https://bugzilla.redhat.com/show_bug.cgi?id=815270
The function virNetDevMacVLanVPortProfileRegisterCallback() takes an
arg virtPortProfile, and was checking it for non-NULL before using
On 04/26/2012 02:12 AM, Alex Jia wrote:
On 04/26/2012 04:46 AM, Eric Blake wrote:
On 04/25/2012 02:01 PM, Laine Stump wrote:
This patch resolves https://bugzilla.redhat.com/show_bug.cgi?id=815270
The function virNetDevMacVLanVPortProfileRegisterCallback() takes an
arg virtPortProfile, and
The ATTRIBUTE_NONNULL(m) macro normally resolves to the gcc builtin
__attribute__((__nonnull__(m))). The effect of this in gcc is
unfortunately only to make gcc believe that m can never possibly be
NULL, *not* to add in any checks to guarantee that it isn't ever NULL
(i.e. it is an optimization
Remove parameter nr_pcpus. Add another parameter total of type bool
to indicate wheter to get total cpu statistic or per_cpu statistics.
---
examples/get_cpu_stats.ml | 50 ++--
libvirt/libvirt.ml |2 +-
libvirt/libvirt.mli |2 +-
---
examples/get_cpu_stats.ml |2 +-
libvirt/libvirt.ml |2 +-
libvirt/libvirt.mli |2 +-
libvirt/libvirt_c_oneoffs.c |9 +
4 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/examples/get_cpu_stats.ml b/examples/get_cpu_stats.ml
index
On Thu, Apr 26, 2012 at 04:09:05PM +0800, Hu Tao wrote:
---
examples/get_cpu_stats.ml |2 +-
libvirt/libvirt.ml |2 +-
libvirt/libvirt.mli |2 +-
libvirt/libvirt_c_oneoffs.c |9 +
4 files changed, 8 insertions(+), 7 deletions(-)
diff --git
On Thu, Apr 26, 2012 at 12:04 AM, Eric Blake ebl...@redhat.com wrote:
With RHEL 6.2, virDomainBlockPull(dom, dev, bandwidth, 0) has a race
with non-zero bandwidth: there is a window between the block_stream
and block_job_set_speed monitor commands where an unlimited amount
of data was let
On 04/25/2012 02:07 PM, Jiri Denemark wrote:
Once qemu monitor reports migration has completed, we just closed our
end of the pipe and let migration tunnel die. This generated bogus error
in case we did so before the thread saw EOF on the pipe and migration
was aborted even though it was in fact
On 04/25/2012 04:41 PM, Jiri Denemark wrote:
On Wed, Apr 25, 2012 at 16:18:07 +0200, Peter Krempa wrote:
The docs for virConnectSetKeepAlive() advertise that this function
should be able to disable keepalives on negative or zero interval time.
This patch removes the check that prohibited this
On 12.04.2012 16:37, Michal Privoznik wrote:
Currently, qemu GA is not providing 'desc' field for errors like
we are used to from qemu monitor. Therefore, we fall back to this
general 'unknown error' string. However, GA is reporting 'class' which
is not perfect, but much more helpful than
[trimming cc's]
On 04/25/2012 09:18 PM, Alex Jia wrote:
Hello Eric,
I still met this issue on latest upstream HEAD(f78024b)
when compiling libvirt:
Making all in po
make[2]: Entering directory `/home/ajia/Workspace/libvirt/po'
*** error: gettext infrastructure mismatch: using a
On 04/26/2012 01:44 AM, Alex Jia wrote:
As Laine and I discussed on IRC, I'm half wondering if we should
just do:
#ifdef STATIC_ANALYSIS /* attributes supported */
# define ATTRIBUTE_NONNULL(n) __attribute__((__nonnull__(n)))
#else
# define ATTRIBUTE_NONNULL(n) /* empty, due to gcc
On 04/26/2012 12:56 AM, Laine Stump wrote:
The ATTRIBUTE_NONNULL(m) macro normally resolves to the gcc builtin
__attribute__((__nonnull__(m))). The effect of this in gcc is
unfortunately only to make gcc believe that m can never possibly be
NULL, *not* to add in any checks to guarantee that it
On 04/20/2012 08:01 PM, Dmitry Guryanov wrote:
Add driver, which can report node info only.
changes:
* add me to AUTHORS
* fix indent in preprocessor directives in pvs_driver.h
* remove unneded include
* remove pvs_driver.c from po/POTFILES.in
Signed-off-by: Dmitry
QEMU binary is called several times when we probe different kinds of
capabilities the binary supports. This patch introduces new common
helper so that all probes use a consistent way of invoking qemu.
---
src/qemu/qemu_capabilities.c | 59 ++---
Thanks to this new option we are now able to use modern CPU models (such
as Westmere) defined in external configuration file.
---
src/qemu/qemu_capabilities.c |7 ++-
src/qemu/qemu_capabilities.h |1 +
src/qemu/qemu_command.c | 11 ++-
src/qemu/qemu_driver.c |
Eduardo submitted patches[1] for qemu implementing -no-user-config as a better
alternative to all-or-nothing -nodefconfig. With this new option, we are
finally able to use modern CPU models defined in qemu's configuration file
without allowing user-supplied qemu configuration to mess up with qemu
On Wed, Apr 25, 2012 at 14:07:44 +0200, Jiri Denemark wrote:
All bugs fixed by the following patches were spotted while testing
tunnelled migration. However, the first three of them may also be hit in
other scenarios.
Jiri Denemark (4):
qemu: Preserve original error during migration
On Wed, Apr 25, 2012 at 17:04:25 -0600, Eric Blake wrote:
With RHEL 6.2, virDomainBlockPull(dom, dev, bandwidth, 0) has a race
with non-zero bandwidth: there is a window between the block_stream
and block_job_set_speed monitor commands where an unlimited amount
of data was let through,
On 04/26/2012 09:00 AM, Jiri Denemark wrote:
On Wed, Apr 25, 2012 at 17:04:25 -0600, Eric Blake wrote:
With RHEL 6.2, virDomainBlockPull(dom, dev, bandwidth, 0) has a race
with non-zero bandwidth: there is a window between the block_stream
and block_job_set_speed monitor commands where an
On 04/26/2012 08:28 AM, Jiri Denemark wrote:
QEMU binary is called several times when we probe different kinds of
capabilities the binary supports. This patch introduces new common
helper so that all probes use a consistent way of invoking qemu.
---
src/qemu/qemu_capabilities.c | 59
On 04/26/2012 08:28 AM, Jiri Denemark wrote:
Thanks to this new option we are now able to use modern CPU models (such
as Westmere) defined in external configuration file.
---
I agree with your decision to not push this patch until we have a
documented qemu pull request incorporating the qemu
Hello Eric,
Unfortunately, Clang hasn't also complain the issue like Coverity on
commit 'bae1312 build: fix bootstrap on RHEL'.
Regards,
Alex
- Original Message -
From: Eric Blake ebl...@redhat.com
To: Alex Jia a...@redhat.com
Cc: Laine Stump la...@laine.org, libvir-list@redhat.com
Sent:
On 04/26/2012 03:05 AM, Stefan Hajnoczi wrote:
On Thu, Apr 26, 2012 at 12:04 AM, Eric Blake ebl...@redhat.com wrote:
With RHEL 6.2, virDomainBlockPull(dom, dev, bandwidth, 0) has a race
with non-zero bandwidth: there is a window between the block_stream
and block_job_set_speed monitor commands
Hi all,
An idea we've kicked around for awhile in Red Hat/Fedora land is doing
official libvirt stable releases, but nothing ever took shape. The idea was
brought up again recently and I've offered to help get something going.
I've pushed an upstream v0.9.11-maint branch with a bunch of patches
On 04/20/2012 04:50 AM, Daniel Veillard wrote:
On Fri, Apr 20, 2012 at 02:26:31PM +0800, Wen Congyang wrote:
When I build libvirt, I meet the following error message
sometimes:
make[4]: Entering directory `/home/wency/rpmbuild/BUILD/libvirt-0.9.11/docs'
GENlibvirt-api.xml
GEN
How should libvirt deal with different SR-IOV VLAN scenarios?
Hardware with full SR-IOV and ACS support is increasingly available
and in production. I just took delivery of such a server this week. It
would be nice if the software can fully take advantage of the
hardware.
== Scenario A -
With RHEL 6.2, virDomainBlockPull(dom, dev, bandwidth, 0) has a race
with non-zero bandwidth: there is a window between the block_stream
and block_job_set_speed monitor commands where an unlimited amount
of data was let through, defeating the point of a throttle.
This race was first identified in
Some of the error messages in this function should have been
virReportSystemError (since they have an errno they want to log), but
were mistakenly written as netlinkError, which expects a libvirt error
code instead. The result was that when one of the errors was
encountered, No error message
On 04/26/2012 12:39 PM, Cole Robinson wrote:
Hi all,
An idea we've kicked around for awhile in Red Hat/Fedora land is doing
official libvirt stable releases, but nothing ever took shape. The idea was
brought up again recently and I've offered to help get something going.
I've pushed an
On 04/26/2012 01:09 PM, Laine Stump wrote:
Some of the error messages in this function should have been
virReportSystemError (since they have an errno they want to log), but
were mistakenly written as netlinkError, which expects a libvirt error
code instead. The result was that when one of the
This patch addresses the following coverity findings:
/libvirt/src/conf/nwfilter_params.c:157:
deref_parm: Directly dereferencing parameter val.
/libvirt/src/conf/nwfilter_params.c:473:
negative_returns: Using variable iterIndex as an index to array
res-iter.
On 04/26/2012 03:14 PM, Eric Blake wrote:
On 04/26/2012 01:09 PM, Laine Stump wrote:
Some of the error messages in this function should have been
virReportSystemError (since they have an errno they want to log), but
were mistakenly written as netlinkError, which expects a libvirt error
code
On 04/26/2012 03:12 PM, Eric Blake wrote:
On 04/26/2012 12:39 PM, Cole Robinson wrote:
Hi all,
An idea we've kicked around for awhile in Red Hat/Fedora land is doing
official libvirt stable releases, but nothing ever took shape. The idea was
brought up again recently and I've offered to help
I'm pleased to announce the release of libvirt-0.9.11.1. This is
libvirt-0.9.11 with additional bugfixes that have accumulated upstream since
the initial release.
This release can be downloaded at:
http://libvirt.org/sources/libvirt-0.9.11.1.tar.gz
For a complete list of changes since
On 04/26/2012 03:12 PM, Eric Blake wrote:
On 04/26/2012 12:39 PM, Cole Robinson wrote:
Hi all,
An idea we've kicked around for awhile in Red Hat/Fedora land is doing
official libvirt stable releases, but nothing ever took shape. The idea was
brought up again recently and I've offered to help
This patch addresses the following coverity findings:
/libvirt/src/conf/nwfilter_params.c:390:
var_assigned: Assigning: varValue = null return value from
virHashLookup.
/libvirt/src/conf/nwfilter_params.c:392:
dereference: Dereferencing a pointer that might be null varValue when
calling
https://bugzilla.redhat.com/show_bug.cgi?id=816662 pointed out
that attempting 'virsh blockpull' on an offline domain gave a
misleading error message about qemu lacking support for the
operation, even when qemu was specifically updated to support it.
The real problem is that we have several
Anyone have an ACK or comments?
Stefan
On 04/23/2012 08:21 AM, Stefan Berger wrote:
Recent iptables fixes a lot of issues with missing spaces and
other information that was previously not reported properly. To make
the test program and test cases work on old and newer installations
of
On 04/23/2012 08:49 PM, Eric Blake wrote:
Minimal patch to wire up all the pieces in the previous patches
to actually enable a block copy job. By minimal, I mean that
qemu creates the file (that is, no REUSE_EXT flag support yet),
SELinux must be disabled, a lock manager is not informed, and
On 04/26/2012 03:50 PM, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=816662 pointed out
that attempting 'virsh blockpull' on an offline domain gave a
misleading error message about qemu lacking support for the
operation, even when qemu was specifically updated to support it.
Similar to the recent race fix for 'block-stream', it is possible
to set the speed of a block copy job up front thanks to an optional
'speed' parameter to 'drive-mirror'.
* src/qemu/qemu_monitor_json.c (qemuMonitorJSONDriveMirror): Set
speed at job start.
* src/qemu/qemu_monitor_json.h
On 04/26/2012 02:11 PM, Stefan Berger wrote:
On 04/26/2012 03:50 PM, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=816662 pointed out
that attempting 'virsh blockpull' on an offline domain gave a
misleading error message about qemu lacking support for the
operation, even
On 04/26/2012 01:17 PM, Stefan Berger wrote:
This patch addresses the following coverity findings:
/libvirt/src/conf/nwfilter_params.c:157:
deref_parm: Directly dereferencing parameter val.
/libvirt/src/conf/nwfilter_params.c:473:
negative_returns: Using variable iterIndex as an index to
On 04/23/2012 06:21 AM, Stefan Berger wrote:
Recent iptables fixes a lot of issues with missing spaces and
other information that was previously not reported properly. To make
the test program and test cases work on old and newer installations
of iptables tools, some adjustments need to be
On 04/26/2012 01:46 PM, Stefan Berger wrote:
This patch addresses the following coverity findings:
/libvirt/src/conf/nwfilter_params.c:390:
var_assigned: Assigning: varValue = null return value from
virHashLookup.
/libvirt/src/conf/nwfilter_params.c:392:
dereference: Dereferencing a
On 04/26/2012 04:15 PM, Eric Blake wrote:
Similar to the recent race fix for 'block-stream', it is possible
to set the speed of a block copy job up front thanks to an optional
'speed' parameter to 'drive-mirror'.
* src/qemu/qemu_monitor_json.c (qemuMonitorJSONDriveMirror): Set
speed at job
On 04/26/2012 02:38 PM, Stefan Berger wrote:
On 04/26/2012 04:15 PM, Eric Blake wrote:
Similar to the recent race fix for 'block-stream', it is possible
to set the speed of a block copy job up front thanks to an optional
'speed' parameter to 'drive-mirror'.
* src/qemu/qemu_monitor_json.c
Osier Yang wrote:
On 2012年04月24日 03:47, Guido Günther wrote:
Hi,
On Sun, Apr 22, 2012 at 02:41:54PM -0400, Jim Paris wrote:
Hi,
http://bugs.debian.org/663931 is a bug I'm hitting, where virt-manager
times out on the initial connection to libvirt.
I reassigned the bug back to libvirt. I
On 04/23/2012 06:20 AM, Stefan Berger wrote:
Add test cases for the ipset extension.
Since ipset may not be available on all system, the first line of the XML
file containing the test filter has been extended with a specially formatted
XML comment containing a command line test for whether
On 02/28/2012 03:38 AM, Guannan Ren wrote:
If we don't explicitly specify the format of backing file,
it should use raw by default, if so, libvirt's security drivers
should *not* grant access to the last.img file the guest
should not see the last.img data. That is the
Below patch fixes the following coverity findings
Error: OVERRUN_STATIC:
/libvirt/src/qemu/qemu_command.c:152:
overrun-buffer-val: Overrunning static array net-mac of size 6 bytes
by passing it as an argument to a function which indexes it at byte
position 15.
On 04/26/2012 03:16 PM, Stefan Berger wrote:
Below patch fixes the following coverity findings
Error: OVERRUN_STATIC:
/libvirt/src/qemu/qemu_command.c:152:
overrun-buffer-val: Overrunning static array net-mac of size 6 bytes
by passing it as an argument to a function which indexes it at
Okay, I screwed up the tarball for the first stable release, due to not
building it from a fresh checkout :/ No changes for this one except a version
bump and dist rebuild.
This release can be downloaded at:
http://libvirt.org/sources/libvirt-0.9.11.2.tar.gz
Thanks,
Cole
--
libvir-list mailing
On 04/26/2012 02:17 PM, Eric Blake wrote:
On 04/26/2012 02:11 PM, Stefan Berger wrote:
On 04/26/2012 03:50 PM, Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=816662 pointed out
that attempting 'virsh blockpull' on an offline domain gave a
misleading error message about qemu
On 27/04/2012, at 8:04 AM, Cole Robinson wrote:
Okay, I screwed up the tarball for the first stable release, due to not
building it from a fresh checkout :/ No changes for this one except a version
bump and dist rebuild.
This release can be downloaded at:
In building the libvirt-0.9.11.2 stable tarball, I saw these errors:
tar:
libvirt-0.9.11.2/tests/nodeinfodata/linux-nodeinfo-sysfs-test-1/cpu/cpu0/topology/thread_siblings_list:
file name is too long (max 99); not dumped
tar:
[ CC to Cole ]
Osier Yang wrote:
On 2012年04月24日 03:47, Guido Günther wrote:
Hi,
On Sun, Apr 22, 2012 at 02:41:54PM -0400, Jim Paris wrote:
Hi,
http://bugs.debian.org/663931 is a bug I'm hitting, where virt-manager
times out on the initial connection to libvirt.
I reassigned the bug back
On 2012年04月27日 08:17, Cole Robinson wrote:
In building the libvirt-0.9.11.2 stable tarball, I saw these errors:
tar:
libvirt-0.9.11.2/tests/nodeinfodata/linux-nodeinfo-sysfs-test-1/cpu/cpu0/topology/thread_siblings_list:
file name is too long (max 99); not dumped
tar:
On 04/27/2012 05:15 AM, Eric Blake wrote:
On 02/28/2012 03:38 AM, Guannan Ren wrote:
If we don't explicitly specify the format of backing file,
it should use raw by default, if so, libvirt's security drivers
should *not* grant access to the last.img file the guest
61 matches
Mail list logo
