Re: [libvirt] Libvirt Support Virtio-serail

2012-06-08 Thread Pankaj Rawat
Well I tried many times. But result is still the same I am not able to connect to guest using this console , How can I ensure that the problem is getty , without entering into guest. And the main problem is if I use virtio-console alone , even ssh don't work.seems like there is some error Can

[libvirt] libvirt secret support password or encryption keys?

2012-06-08 Thread Zhimou Peng
Hi all, # man virsh ... SECRET COMMMANDS The following commands manipulate secrets (e.g. passwords, passphrases - secret-set-value only support passphrases and encryption keys). Libvirt can store secrets independently from their So, will libvirt support

Re: [libvirt] Libvirt Support Virtio-serail

2012-06-08 Thread Pankaj Rawat
Scenario:- The host is fedora17 Libvirt:0.9.11 And guest is rhel6.2, fedora17 The Host is running on a Intel I5 processor Our xml file contain entry for 1 serial console , 2 virtio console The xml file get properly defined, and proper port assigned to each console Now when guest is started. I

Re: [libvirt] pointless time-consuming test 'virsh-all'

2012-06-08 Thread Martin Kletzander
On 06/07/2012 04:37 PM, Eric Blake wrote: On 06/07/2012 06:31 AM, Martin Kletzander wrote: $ time tools/virsh -c test:///default connect error: Failed to connect to the hypervisor error: Failed to connect socket to '/run/user/eblake/libvirt/libvirt-sock': No such file or directory Odd.

Re: [libvirt] [PATCH v2] virsh: add keepalive protocol in virsh

2012-06-08 Thread Jiri Denemark
On Thu, Jun 07, 2012 at 12:03:02 -0600, Eric Blake wrote: On 06/05/2012 02:36 AM, Guannan Ren wrote: Bugzilla:https://bugzilla.redhat.com/show_bug.cgi?id=822839 add two general virsh options to support keepalive message protocol -i | --keepalive_interval interval time value (default 5

[libvirt] [PATCH 2/7] virsh: Expose virDomainInterfacesAddresses

2012-06-08 Thread Michal Privoznik
--- tools/virsh.c | 92 +++ tools/virsh.pod | 10 ++ 2 files changed, 102 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index abcfbff..9782534 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1621,6

[libvirt] [PATCH 3/7] qemu_agent: Implement 'guest-network-get-interfaces' command handling

2012-06-08 Thread Michal Privoznik
This command returns an array of all guest interfaces among with their IP and HW addresses. --- src/qemu/qemu_agent.c | 158 + src/qemu/qemu_agent.h |4 + 2 files changed, 162 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_agent.c

[libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-08 Thread Michal Privoznik
This feature has been requested for a very long time. However, we had to wait for guest agent to obtain reliable results as user might create totally different structure of interfaces than seen from outside (e.g. bonding, virtual interfaces, etc.). That's the main reason why sniffing for domain

[libvirt] [PATCH 6/7] python: Expose virDomainInterfacesAddresses

2012-06-08 Thread Michal Privoznik
--- python/libvirt-override-api.xml |6 ++ python/libvirt-override.c | 116 +++ 2 files changed, 122 insertions(+), 0 deletions(-) diff --git a/python/libvirt-override-api.xml b/python/libvirt-override-api.xml index 0bafd21..d2ea831 100644 ---

[libvirt] [PATCH 1/7] Introduce virDomainInterfacesAddresses API

2012-06-08 Thread Michal Privoznik
This API returns dynamically allocated array of IP addresses for all domain interfaces. --- include/libvirt/libvirt.h.in | 32 + python/generator.py |1 + src/driver.h |6 +++ src/libvirt.c| 101

[libvirt] [PATCH 5/7] remote: Implement virDomainInterfacesAddresses

2012-06-08 Thread Michal Privoznik
--- daemon/remote.c | 122 ++ src/remote/remote_driver.c | 95 src/remote/remote_protocol.x | 25 - 3 files changed, 241 insertions(+), 1 deletions(-) diff --git a/daemon/remote.c

[libvirt] [PATCH 7/7] python: create example for dumping domain IP addresses

2012-06-08 Thread Michal Privoznik
--- examples/python/Makefile.am |2 +- examples/python/README|1 + examples/python/domipaddrs.py | 50 + 3 files changed, 52 insertions(+), 1 deletions(-) create mode 100644 examples/python/domipaddrs.py diff --git

[libvirt] [PATCH 4/7] qemu: Implement virDomainInterfacesAddresses

2012-06-08 Thread Michal Privoznik
--- src/qemu/qemu_driver.c | 76 1 files changed, 76 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d3f74d2..e662fbd 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12946,6

Re: [libvirt] [Qemu-devel] [PATCH qom-next 2/7] qom: Add get_id

2012-06-08 Thread Andreas Färber
Am 08.06.2012 09:44, schrieb Anthony Liguori: On 06/08/2012 03:11 PM, Andreas Färber wrote: Am 08.06.2012 03:22, schrieb Anthony Liguori: On 06/08/2012 03:31 AM, Andreas Färber wrote: From: Paolo Bonzinipbonz...@redhat.com Some classes may present objects differently in errors, for example

[libvirt] [PATCH] add xhci support

2012-06-08 Thread Gerd Hoffmann
qemu 1.1 features a xhci controller, this patch adds support for it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/conf/domain_conf.c |3 ++- src/conf/domain_conf.h |1 + src/qemu/qemu_capabilities.c |3 +++ src/qemu/qemu_capabilities.h |1 +

Re: [libvirt] [PATCH] add xhci support

2012-06-08 Thread Jiri Denemark
On Fri, Jun 08, 2012 at 10:19:37 +0200, Gerd Hoffmann wrote: qemu 1.1 features a xhci controller, this patch adds support for it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/conf/domain_conf.c |3 ++- src/conf/domain_conf.h |1 +

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-08 Thread Alex Jia
On 06/08/2012 04:04 PM, Michal Privoznik wrote: This feature has been requested for a very long time. However, I'm very glad to see this patch :-) we had to wait for guest agent to obtain reliable results as Yeah, it's a good way to get guest IP by GA, the disadvantage is we have to depend on

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-08 Thread Michal Privoznik
On 08.06.2012 11:02, Alex Jia wrote: On 06/08/2012 04:04 PM, Michal Privoznik wrote: This feature has been requested for a very long time. However, I'm very glad to see this patch :-) we had to wait for guest agent to obtain reliable results as Yeah, it's a good way to get guest IP by GA, the

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-08 Thread Alex Jia
On 06/08/2012 05:13 PM, Michal Privoznik wrote: On 08.06.2012 11:02, Alex Jia wrote: On 06/08/2012 04:04 PM, Michal Privoznik wrote: This feature has been requested for a very long time. However, I'm very glad to see this patch :-) we had to wait for guest agent to obtain reliable results as

Re: [libvirt] [PATCH v2] virsh: add keepalive protocol in virsh

2012-06-08 Thread Guannan Ren
On 06/08/2012 03:46 PM, Jiri Denemark wrote: On Thu, Jun 07, 2012 at 12:03:02 -0600, Eric Blake wrote: On 06/05/2012 02:36 AM, Guannan Ren wrote: Bugzilla:https://bugzilla.redhat.com/show_bug.cgi?id=822839 add two general virsh options to support keepalive message protocol -i |

Re: [libvirt] [Qemu-devel] [PATCH qom-next 2/7] qom: Add get_id

2012-06-08 Thread Daniel P. Berrange
On Fri, Jun 08, 2012 at 10:17:05AM +0200, Andreas Färber wrote: Am 08.06.2012 09:44, schrieb Anthony Liguori: On 06/08/2012 03:11 PM, Andreas Färber wrote: Since qdev-id is NULL 90% of the time, I don't think a user can realistically rely on it. I don't think changing the type of the data

Re: [libvirt] [PATCH V14 5/5] nwfilter: Display detected IP address in domain XML

2012-06-08 Thread Stefan Berger
On 06/01/2012 07:41 PM, Stefan Berger wrote: On 06/01/2012 03:05 PM, Eric Blake wrote: On 05/25/2012 05:56 AM, Stefan Berger wrote: An example of a displayed XML may then be: interface type='bridge' mac address='52:54:00:68:e3:90'/ source bridge='virbr0'/ target dev='vnet1'/ model

Re: [libvirt] pointless time-consuming test 'virsh-all'

2012-06-08 Thread Eric Blake
On 06/08/2012 01:15 AM, Martin Kletzander wrote: I'd suspect that 'virsh -c uri connect' connects to uri (maybe twice, but still the same URI). Maybe there could be a fix that the '-c' parameter sets the default uri, because 'virsh -c uri uri' prints out 'uri' and also because it seems *very*

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-08 Thread Eric Blake
On 06/08/2012 02:04 AM, Michal Privoznik wrote: This feature has been requested for a very long time. However, we had to wait for guest agent to obtain reliable results as user might create totally different structure of interfaces than seen from outside (e.g. bonding, virtual interfaces,

[libvirt] [PATCH] Only check for cluster fs if we're using a filesystem

2012-06-08 Thread Guido Günther
otherwise migration fails for e.g. network filesystems like sheepdog with: error: Invalid relative path 'virt-name': Invalid argument while we should fail with: Migration may lead to data corruption if disks use cache != none References:

Re: [libvirt] daemon: Install libvirtd under 'bin' not 'sbin'

2012-06-08 Thread Daniel P. Berrange
On Thu, Jun 07, 2012 at 04:31:14PM +0300, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This binary is not admin-only at all and launching it as normal user is a supported use case: session. While running it as a normal user is supported, users should never

Re: [libvirt] daemon: Install libvirtd under 'bin' not 'sbin'

2012-06-08 Thread Daniel P. Berrange
On Thu, Jun 07, 2012 at 11:42:53AM -0600, Eric Blake wrote: On 06/07/2012 11:13 AM, Eric Blake wrote: On 06/07/2012 07:31 AM, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This binary is not admin-only at all and launching it as normal user is a supported

Re: [libvirt] pointless time-consuming test 'virsh-all'

2012-06-08 Thread Daniel P. Berrange
On Wed, Jun 06, 2012 at 09:32:08PM -0600, Eric Blake wrote: The command 'make -C tests check' takes forever, because it is calling this lengthy virsh command and ignoring the failures: $ time tools/virsh -c test:///default connect error: Failed to connect to the hypervisor error: Failed to

Re: [libvirt] libvirt Application Development Guide - revival

2012-06-08 Thread Daniel P. Berrange
On Thu, Jun 07, 2012 at 09:25:02AM +1000, Scott Radvan wrote: Hi list, I write virtualization docs for Red Hat and would like to maintain this guide[1] - it's in need of a bit of attention. I have publican and the publican brand up and running, and have already cloned the git repo, but

Re: [libvirt] [patch]make rundir permission equals to socket permission to support unprivileged access

2012-06-08 Thread Daniel P. Berrange
On Tue, Jun 05, 2012 at 02:21:10PM +0800, Royce Lv wrote: Libvirt-socket-rw and libvirt-socket-ro are not used only for libvirt or root user, but also for unprivileged application such as vdsm, Restrain the rundir only read/search for libvirt prevent comunication with unprivileged

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-08 Thread Dave Allan
On Fri, Jun 08, 2012 at 10:04:31AM +0200, Michal Privoznik wrote: This feature has been requested for a very long time. However, we had to wait for guest agent to obtain reliable results as user might create totally different structure of interfaces than seen from outside (e.g. bonding,

Re: [libvirt] Compiling out SSL support - status?

2012-06-08 Thread Daniel P. Berrange
On Wed, May 30, 2012 at 05:20:12PM -0400, Chris Van Heuveln wrote: Hi, I want to remove TLS from libvirt (0.8.4). I ran across this earlier thread on the same topic: http://www.redhat.com/archives/libvir-list/2012-January/msg00479.html ...just curious if any further development

Re: [libvirt] Bug report 826704 - sanlock releases all resources on virsh detach-disk

2012-06-08 Thread Daniel P. Berrange
On Fri, Jun 01, 2012 at 10:46:04AM +0200, Frido Roose wrote: On Thursday 31 May 2012 at 10:44, Frido Roose wrote: Hello, I logged a bug about using virsh detach-disk cleaning up all sanlock resources for the domain instead of only the device in question. After a quick look into the

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-08 Thread Michal Privoznik
On 08.06.2012 15:26, Dave Allan wrote: On Fri, Jun 08, 2012 at 10:04:31AM +0200, Michal Privoznik wrote: This feature has been requested for a very long time. However, we had to wait for guest agent to obtain reliable results as user might create totally different structure of interfaces than

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-08 Thread Eric Blake
On 06/08/2012 08:39 AM, Michal Privoznik wrote: This API is called virDomainInterfacesAddresses (okay, maybe too many plurals) and returns a dynamically allocated array of virDomainInterface struct. The great disadvantage once this gets released, it's written in stone and we cannot change or

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-08 Thread Daniel P. Berrange
On Fri, Jun 08, 2012 at 04:39:06PM +0200, Michal Privoznik wrote: On 08.06.2012 15:26, Dave Allan wrote: On Fri, Jun 08, 2012 at 10:04:31AM +0200, Michal Privoznik wrote: This feature has been requested for a very long time. However, we had to wait for guest agent to obtain reliable results

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-08 Thread Daniel P. Berrange
On Fri, Jun 08, 2012 at 09:26:35AM -0400, Dave Allan wrote: On Fri, Jun 08, 2012 at 10:04:31AM +0200, Michal Privoznik wrote: This feature has been requested for a very long time. However, we had to wait for guest agent to obtain reliable results as user might create totally different

[libvirt] [PATCH 0/5] Support forward mode='hostdev' and interface pools

2012-06-08 Thread Shradha Shah
This patch series supports the forward mode='hostdev'. The functionality of this mode is the same as interface type='hostdev' but with the added benefit of using interface pools. The patch series also contains a patch to support use of interface names and PCI device addresses interchangeably in a

[libvirt] [PATCH 3/5] Introduce forward mode='hostdev' for network XML in order to use the functionality of interface pools.

2012-06-08 Thread Shradha Shah
This new forward mode sets up a PCI network device to be assigned to the guest with PCI passthrough. The PCI network device is chosen from an interface pool. Currently there is no support for USB devices when using this forward mode. Example XML: Network XML: network namedirect-network/name

[libvirt] [PATCH 1/5] Code to return interface name or pci_addr of the VF in actualDevice

2012-06-08 Thread Shradha Shah
The network pool should be able to keep track of both, network device names nad PCI addresses, and return the appropriate one in the actualDevice when networkAllocateActualDevice is called. Signed-off-by: Shradha Shah ss...@solarflare.com --- src/conf/network_conf.c | 55

[libvirt] [PATCH 2/5] Moved the code to create implicit interface pool from PF to a new function

2012-06-08 Thread Shradha Shah
This makes the code reusable Signed-off-by: Shradha Shah ss...@solarflare.com --- src/network/bridge_driver.c | 109 ++- 1 files changed, 66 insertions(+), 43 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index

[libvirt] [PATCH 4/5] Forward Mode Hostdev Implementation

2012-06-08 Thread Shradha Shah
This patch chooses a free network device from the interface pool and creates a PCI HostDef to be passed to the guest, when forward mode is hostdev. networkNotifyActualDevice and networkReleaseActualDevice are modified accordingly. Signed-off-by: Shradha Shah ss...@solarflare.com ---

[libvirt] [PATCH 5/5] Supporting managed option for forward devs when using HOSTDEV mode

2012-06-08 Thread Shradha Shah
This patch supports the managed option in a network xml for network devices. This option is used for pci network devices when forward mode=hostdev. Hence the example network xml would be: network namedirect-network/name uuid81ff0d90-c91e-6742-64da-4a736edb9a8f/uuid forward mode=hostdev

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-08 Thread Daniel P. Berrange
On Fri, Jun 08, 2012 at 06:13:43AM -0600, Eric Blake wrote: On 06/08/2012 02:04 AM, Michal Privoznik wrote: This feature has been requested for a very long time. However, we had to wait for guest agent to obtain reliable results as user might create totally different structure of interfaces

Re: [libvirt] [Qemu-devel] [PATCH v2 0/4] file descriptor passing using passfd

2012-06-08 Thread Corey Bryant
Please ignore this series as well. Something is amiss. I'll be resending. -- Regards, Corey On 06/08/2012 10:53 AM, Corey Bryant wrote: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other words, sVirt uses

Re: [libvirt] [Qemu-devel] [PATCH v2 0/4] file descriptor passing using passfd

2012-06-08 Thread Corey Bryant
Please ignore this series. Something is amiss. I'll be resending. -- Regards, Corey On 06/08/2012 10:49 AM, Corey Bryant wrote: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other words, sVirt uses SELinux to

Re: [libvirt] [PATCH 0/5] Support forward mode='hostdev' and interface pools

2012-06-08 Thread Shradha Shah
Hello all, I have actually based these patches of v0.9.12. Top of tree libvirt had some errors due to which I was not able to use virsh and test these patches so I based them off the last release. But these patches should work equivalently well with top of tree. Many Thanks, Regards, Shradha

[libvirt] [PATCH] snapshot: add virDomainSnapshotRef API

2012-06-08 Thread Eric Blake
virDomainSnapshotPtr has a refcount member, but no one was able to use it. Furthermore, all of our other vir*Ptr objects have a *Ref method to match their *Free method. Thankfully, this is client-side only, so we can use this new function regardless of how old the server side is! (I have future

Re: [libvirt] [PATCH] snapshot: add virDomainSnapshotRef API

2012-06-08 Thread Daniel P. Berrange
On Fri, Jun 08, 2012 at 10:33:42AM -0600, Eric Blake wrote: virDomainSnapshotPtr has a refcount member, but no one was able to use it. Furthermore, all of our other vir*Ptr objects have a *Ref method to match their *Free method. Thankfully, this is client-side only, so we can use this new

Re: [libvirt] [Qemu-devel] [PATCH v2 0/4] file descriptor passing using passfd

2012-06-08 Thread Corey Bryant
Please review this patch series if you could. I apologize for sending it more than once. Thanks! -- Regards, Corey On 06/08/2012 11:42 AM, Corey Bryant wrote: libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In

Re: [libvirt] [PATCH] snapshot: add virDomainSnapshotRef API

2012-06-08 Thread Eric Blake
On 06/08/2012 10:38 AM, Daniel P. Berrange wrote: On Fri, Jun 08, 2012 at 10:33:42AM -0600, Eric Blake wrote: virDomainSnapshotPtr has a refcount member, but no one was able to use it. Furthermore, all of our other vir*Ptr objects have a *Ref method to match their *Free method. Thankfully,

[libvirt] [PATCH] snapshot: avoid virsh crash with older servers

2012-06-08 Thread Eric Blake
Commits 51082301, 16d7b39, and 521cc447 introduced support for 'virsh snapshot-list --from' when talking to a server older than 0.9.5, but broke support for plain 'virsh snapshot-list' for the same old server in the process. Because the code is not properly gated, we end up with a SIGSEGV during

Re: [libvirt] libvirt Application Development Guide - revival

2012-06-08 Thread Laine Stump
On 06/06/2012 07:25 PM, Scott Radvan wrote: Hi list, I write virtualization docs for Red Hat and would like to maintain this guide[1] - it's in need of a bit of attention. Very kindly understated :-) I have publican and the publican brand up and running, and have already cloned the git

Re: [libvirt] Compiling out SSL support - status?

2012-06-08 Thread Chris Van Heuveln
Okay, thanks. I've got the code done and working with 0.8.4 -- though I haven't changed configure.ac yet. If I get a chance I'll patch these into latest and send them on. Chris On Jun 8, 2012, at 9:36 AM, Daniel P. Berrange wrote: On Wed, May 30, 2012 at 05:20:12PM -0400, Chris Van Heuveln

[libvirt] [PATCH] virsh: let 'connect' without args remember -c option

2012-06-08 Thread Eric Blake
If a user invokes 'virsh -c $URI', then within that batch shell, they probably want 'connect' to revert to $URI rather than the normal default URI you get for passing in NULL. In particular, I had a setup where qemu:///session was failing, but took 20 seconds to fail; since 'make -C tests check

Re: [libvirt] [PATCH 2/7] virsh: Expose virDomainInterfacesAddresses

2012-06-08 Thread Stefan Berger
On 06/08/2012 04:04 AM, Michal Privoznik wrote: --- tools/virsh.c | 92 +++ tools/virsh.pod | 10 ++ 2 files changed, 102 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c + +cleanup: +for (i = 0; i

Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses

2012-06-08 Thread Stefan Berger
On 06/08/2012 08:13 AM, Eric Blake wrote: On 06/08/2012 02:04 AM, Michal Privoznik wrote: This feature has been requested for a very long time. However, we had to wait for guest agent to obtain reliable results as user might create totally different structure of interfaces than seen from

[libvirt] [PATCH 1/6] buf: support peeking at string contents

2012-06-08 Thread Eric Blake
Right now, the only way to get at the contents of a virBuffer is to destroy it. But there are cases in my upcoming patches where peeking at the contents makes life easier. I suppose this does open up the potential for bad code to dereference a stale pointer, by disregarding the docs that the

[libvirt] [PATCH 0/6] refactor 'virsh snapshot-list'

2012-06-08 Thread Eric Blake
I'm in the middle of writing a patch series for virDomainListAllSnapshots; this series is preliminary to that, and I'd like to get the review started now. The end result of this series is a net gain in lines of code, but a much nicer framework for changing just one point in the code to use new

[libvirt] [PATCH 2/6] virsh: remove limits on tree listing

2012-06-08 Thread Eric Blake
I am not a fan of fixed-width buffers. All it takes is a linear chain of more than 100 snapshots to mess up 'virsh snapshot-list --tree'. Now that virBuffer is more powerful, we might as well exploit its power. * tools/virsh.c (cmdNodeListDevicesPrint): Simplify to use a virBuffer instead of

[libvirt] [PATCH 3/6] virsh: make tree listing more flexible

2012-06-08 Thread Eric Blake
Requiring the user to pass in parallel arrays of names and parents is annoying; it means that you can't qsort one of the arrays without invalidating the ordering of the other. By refactoring this function to use callbacks, we isolate the layout to be independent of the printing, and a future

[libvirt] [PATCH 4/6] snapshot: virsh indentation cleanup

2012-06-08 Thread Eric Blake
No semantic change; this will make it easier to refactor code. * tools/virsh.c (cmdSnapshotList): Drop level of indentation, and rename a variable. --- tools/virsh.c | 238 - 1 file changed, 118 insertions(+), 120 deletions(-) diff --git

[libvirt] [PATCH 5/6] snapshot: new virsh function factored from snapshot-list

2012-06-08 Thread Eric Blake
This patch copies just the fallback code out of cmdSnapshotList, and keeps the snapshot objects around rather than just their name for easier manipulation. It looks forward to a future patch when we add a way to list all snapshot objects at once, and the next patch will simplify cmdSnapshotList

[libvirt] [PATCH 6/6] snapshot: use new virsh function for snapshot-list

2012-06-08 Thread Eric Blake
Operating on a list of snapshot objects looks so much simpler. In particular, since the helper function already trimmed out irrelevant entries, we no longer have quite so many special cases on finding the first snapshot to operate on. * tools/virsh.c (cmdSnapshotList): Use previous patches. ---