Re: [libvirt] Fwd: Re: Intend to add OVA installation API

2012-06-25 Thread Daniel Veillard
On Sun, Jun 24, 2012 at 10:47:01PM -0400, Bob Cochran wrote: Ooops, I should have sent this to the list. I want to support Doug's suggestion, thanks. Bob Cochran Original Message Subject: Re: [libvirt] Intend to add OVA installation API Date: Sun, 24 Jun

Re: [libvirt] [PATCH] Add support for RAM filesystems for LXC

2012-06-25 Thread Daniel Veillard
On Fri, Jun 22, 2012 at 11:29:40AM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce a new syntax for filesystems to allow use of a RAM filesystem filesystem type='ram' source usage='10' units='MiB'/ target dir='/mnt'/ /filesystem

[libvirt] [PATCH] qemu: Support attaching controller device persistently

2012-06-25 Thread Osier Yang
src/conf/domain_conf.*: (Introduce virDomainControllerFind) src/libvirt_private.syms: (Add virDomainControllerFind to private symbol) src/qemu/qemu_driver.c: (Use of virDomainControllerFind) src/qemu/qemu_driver.c: (Support attaching controller device persistently) --- src/conf/domain_conf.c |

Re: [libvirt] [PATCH] Add support for guest bind mounts with LXC

2012-06-25 Thread Daniel Veillard
On Fri, Jun 22, 2012 at 11:29:59AM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Currently you can configure LXC to bind a host directory to a guest directory, but not to bind a guest directory to a guest directory. While the guest container init could do

Re: [libvirt] [PATCHv2 1/5] S390: Override QEMU_CAPS_NO_ACPI for s390x

2012-06-25 Thread Daniel Veillard
On Fri, Jun 22, 2012 at 01:50:10PM +0200, Viktor Mihajlovski wrote: Starting a KVM guest on s390 fails immediately. This is because qemu --help reports -no-acpi even for the s390(x) architecture but -no-acpi isn't supported there. Workaround is to remove QEMU_CAPS_NO_ACPI from the capability

Re: [libvirt] [PATCHv2 0/5] Basic Enablement of s390

2012-06-25 Thread Daniel Veillard
On Fri, Jun 22, 2012 at 01:50:09PM +0200, Viktor Mihajlovski wrote: Resending as a thread, same content. Please ignore previous submission. The first series of patches aimed to enable libvirt to manage qemu/kvm domains hosted on the System z platform. The patches in this series address s390

Re: [libvirt] [PATCHv2 2/5] S390: CPU support for s390(x)

2012-06-25 Thread Daniel Veillard
On Fri, Jun 22, 2012 at 01:50:11PM +0200, Viktor Mihajlovski wrote: From: Thang Pham thang.p...@us.ibm.com Adding CPU encoder/decoder for s390 to avoid runtime error messages. Signed-off-by: Thang Pham thang.p...@us.ibm.com Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH] virsh: Add domdisplay command for VNC and SPICE

2012-06-25 Thread Christophe Fergeau
On Sun, Jun 24, 2012 at 06:54:10PM -0500, Doug Goldstein wrote: On Fri, Jun 22, 2012 at 3:56 AM, Christophe Fergeau cferg...@redhat.com wrote: For SPICE, a URI you can pass to remote-viewer is spice://hostname?port=xxtls-port=yypassword=zzz For simple cases, spice://hostname:port will

[libvirt] [PATCH v7 3/8] parallels: implement functions for domain life cycle management

2012-06-25 Thread Dmitry Guryanov
Add functions for create/shutdown/destroy and suspend/resume domain. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 149 ++ src/parallels/parallels_driver.h |1 + src/parallels/parallels_utils.c | 18 +

[libvirt] [PATCH v7 5/8] parallels: add support of VNC remote display

2012-06-25 Thread Dmitry Guryanov
Add support for reading VNC parameters of the VM. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 65 ++ 1 files changed, 65 insertions(+), 0 deletions(-) diff --git a/src/parallels/parallels_driver.c

[libvirt] [PATCH v7 4/8] parallels: get info about serial ports

2012-06-25 Thread Dmitry Guryanov
Add support of collecting information about serial ports. This change is needed mostly as an example, support of other devices will be added later. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 119 ++ 1 files

[libvirt] [PATCH v7 8/8] parallels: implement VM creation

2012-06-25 Thread Dmitry Guryanov
To create a new VM in Parallels Clud Server we should issue prlctl create command, and give path to the directory, where VM should be created. VM's storage will be in that directory later. So in this first version find out location of first VM's hard disk and create VM there. Signed-off-by:

[libvirt] [PATCH v7 6/8] parallels: implement virDomainDefineXML operation for existing domains

2012-06-25 Thread Dmitry Guryanov
Add parallelsDomainDefineXML function, it works only for existing domains for the present. It's too hard to convert libvirt's XML domain configuration into parallels's one, so I've decided to compare virDomainDef structures: current domain definition and the one created from XML, given to the

[libvirt] [PATCH v7 7/8] parallels: add storage driver

2012-06-25 Thread Dmitry Guryanov
Parallels Cloud Server has one serious discrepancy with libvirt: libvirt stores domain configuration files in one place, and storage files in other places (with the API of storage pools and storage volumes). Parallels Cloud Server stores all domain data in a single directory, for example, you may

[libvirt] [PATCH v7 2/8] parallels: add functions to list domains and get info

2012-06-25 Thread Dmitry Guryanov
Parallels driver is 'stateless', like vmware or openvz drivers. It collects information about domains during startup using command-line utility prlctl. VMs in Parallels Cloud Server are identified by UUIDs or unique names, which can be used as respective fields in virDomainDef structure. Currently

Re: [libvirt] [Qemu-devel] [PATCH v4 1/7] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg

2012-06-25 Thread Stefan Hajnoczi
On Fri, Jun 22, 2012 at 01:31:17PM -0600, Eric Blake wrote: On 06/22/2012 12:36 PM, Corey Bryant wrote: This sets the close-on-exec flag for the file descriptor received via SCM_RIGHTS. Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com --- v4 -This patch is new in v4

[libvirt] [PATCH v7 0/8] Add basic driver for Parallels Virtuozzo Server

2012-06-25 Thread Dmitry Guryanov
Parallels Cloud Server is a virtualization solution that allows users to simultaneously run multiple virtual machines and containers on the same physical server. More information can be found here: http://www.parallels.com/products/pcs/ Also beta version of Parallels Cloud Server can be

[libvirt] regression ?

2012-06-25 Thread Harsh Bora
Hi, I was testing an under-development patch on upstream libvirt using domxml-to-native and domxml-from-native and realised that the domxml-from-native fails for a successfully generated qemu cmd line using domxml-to-native. To isolate the issue, I tried generating the qemu cmd line for

Re: [libvirt] [PATCH] virsh: Use virXPath wrappers for vncdisplay cmd

2012-06-25 Thread Peter Krempa
On 06/24/12 23:36, Doug Goldstein wrote: Update the vncdisplay command to use the virXPath wrappers as well as check if the domain is up rather than using the port set to -1 to mean the domain is not up. Signed-off-by: Doug Goldstein car...@cardoe.com --- tools/virsh.c | 30

Re: [libvirt] regression ?

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 02:55:39PM +0530, Harsh Bora wrote: Hi, I was testing an under-development patch on upstream libvirt using domxml-to-native and domxml-from-native and realised that the domxml-from-native fails for a successfully generated qemu cmd line using domxml-to-native. To

Re: [libvirt] This patch mounts /run and /var/run before running a sandbox container

2012-06-25 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 09:56:39AM -0400, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 We do not want to share /run between containers and the host. This patch mounts a tmpfs on /run and then bind mounts /run on /var/run. Reason this is pach 0003 is that this is a

Re: [libvirt] [libvirt-glib] mainloop integration fixes

2012-06-25 Thread Christophe Fergeau
Ping ? Christophe On Wed, Jun 20, 2012 at 12:29:46PM +0200, Christophe Fergeau wrote: Hey, While testing Boxes, I've noticed that if I started a VM and then let it in the background for a while, it usually crashed after a while. When this happens, the backtrace is: Program received

Re: [libvirt] [libvirt-glib 1/5] mainloop: improve handle operations debug messages

2012-06-25 Thread Daniel P. Berrange
On Wed, Jun 20, 2012 at 12:29:47PM +0200, Christophe Fergeau wrote: Make sure the watch ID and the address of the structure libvirt-glib uses to watch the handle are always printed to make tracking operation on the same watch easier. --- libvirt-glib/libvirt-glib-event.c |6 +++--- 1

Re: [libvirt] [libvirt-glib 3/5] mainloop: remove unused gvir_event_{handle, timeout}_update arg

2012-06-25 Thread Daniel P. Berrange
On Wed, Jun 20, 2012 at 12:29:49PM +0200, Christophe Fergeau wrote: --- libvirt-glib/libvirt-glib-event.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/libvirt-glib/libvirt-glib-event.c b/libvirt-glib/libvirt-glib-event.c index c720c1f..c2eeb7a

Re: [libvirt] [libvirt-glib 2/5] mainloop: add missing debug message

2012-06-25 Thread Daniel P. Berrange
On Wed, Jun 20, 2012 at 12:29:48PM +0200, Christophe Fergeau wrote: All timeout and watch additions/updates/removals are logged except successful watch updates. This commit adds such a log message. --- libvirt-glib/libvirt-glib-event.c |2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [libvirt] [libvirt-glib 4/5] mainloop: protect 'handles' and 'timeouts' against concurrent accesses

2012-06-25 Thread Daniel P. Berrange
On Wed, Jun 20, 2012 at 12:29:50PM +0200, Christophe Fergeau wrote: Timeout and watch deletion is done from an idle callback. However, we cannot assume that all libvirt event calls (the callbacks passed to virEventRegisterImpl) will be done from the mainloop thread. It's thus possible that a

Re: [libvirt] This patch creates a mount point for libvirt-lxc containers to mount on the destination system if it does not exist.

2012-06-25 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 09:59:58AM -0400, Daniel J Walsh wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Currently libvirt-lxc checks to see if the destination exists and is a directory. If it is not a directory then the mount fails. Since libvirt-lxc can bind mount files on an

Re: [libvirt] [libvirt-glib 5/5] mainloop: don't reschedule deleted timeouts/watches

2012-06-25 Thread Daniel P. Berrange
On Wed, Jun 20, 2012 at 12:29:51PM +0200, Christophe Fergeau wrote: The deletion of libvirt timeouts/watches is done in 2 steps: - the first step is synchronous and unregisters the timeout/watch from glib mainloop - the second step is asynchronous and triggered from the first step. It

[libvirt] [PATCH 1/2] storage: Switch to new def on pool-destroy

2012-06-25 Thread Michal Privoznik
Currently, we share the idea of old new def with domains. Users can *-edit an object (domain, pool) which spawns a new internal representation for them. This is referenced via {domainObj,poolObj}-newDef [compared to -def]. However, for pool we were never overwriting def with newDef. This must be

Re: [libvirt] [PATCH 1/2] storage: Switch to new def on pool-destroy

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 12:32:47PM +0200, Michal Privoznik wrote: Currently, we share the idea of old new def with domains. Users can *-edit an object (domain, pool) which spawns a new internal representation for them. This is referenced via {domainObj,poolObj}-newDef [compared to -def].

Re: [libvirt] [PATCH 2/2] storage: Introduce --inactive for pool-dumpxml

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 12:32:48PM +0200, Michal Privoznik wrote: Storage is one of the last domains in libvirt where we don't fully utilize inactive and live XML. Okay, it might be because we don't have support for that. So implement such support. However, we need to fallback when talking to

[libvirt] [PATCH] Fix compilation on older sanlock

2012-06-25 Thread Daniel Veillard
This is clearly not ideal, but we ought to check the version of sanlock and act accordingly. We may end up with autoconf.ac and libvirt.spec.in change for the real fix. Pushing under the build breaker rule Temporary fix since compilation broke with older version of sanlock following

[libvirt] [PATCH 2/2] storage: Introduce --inactive for pool-dumpxml

2012-06-25 Thread Michal Privoznik
Storage is one of the last domains in libvirt where we don't fully utilize inactive and live XML. Okay, it might be because we don't have support for that. So implement such support. However, we need to fallback when talking to old daemon which doesn't support this new flag. ---

Re: [libvirt] [PATCH 2/2] storage: Introduce --inactive for pool-dumpxml

2012-06-25 Thread Michal Privoznik
On 25.06.2012 12:38, Daniel P. Berrange wrote: On Mon, Jun 25, 2012 at 12:32:48PM +0200, Michal Privoznik wrote: Storage is one of the last domains in libvirt where we don't fully utilize inactive and live XML. Okay, it might be because we don't have support for that. So implement such

[libvirt] [PATCH] sanlock: Properly indent

2012-06-25 Thread Michal Privoznik
One of latest patches (0fce94fe) didn't properly indented #define making syntax-check fail. --- Pushed under build-breaker rule. src/locking/lock_driver_sanlock.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/locking/lock_driver_sanlock.c

[libvirt] [PATCH] qemu: Improve error if setmem fails for lacking of balloon support

2012-06-25 Thread Osier Yang
cannot set memory of an active domain is misleading, it sounds like setting memory of active domain is not supported. --- src/qemu/qemu_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5713650..bb33fd5 100644

Re: [libvirt] [PATCH 2/2] storage: Introduce --inactive for pool-dumpxml

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 12:43:16PM +0200, Michal Privoznik wrote: On 25.06.2012 12:38, Daniel P. Berrange wrote: On Mon, Jun 25, 2012 at 12:32:48PM +0200, Michal Privoznik wrote: Storage is one of the last domains in libvirt where we don't fully utilize inactive and live XML. Okay, it might

Re: [libvirt] [libvirt-glib 5/5] mainloop: don't reschedule deleted timeouts/watches

2012-06-25 Thread Christophe Fergeau
On Mon, Jun 25, 2012 at 11:03:16AM +0100, Daniel P. Berrange wrote: On Wed, Jun 20, 2012 at 12:29:51PM +0200, Christophe Fergeau wrote: The deletion of libvirt timeouts/watches is done in 2 steps: - the first step is synchronous and unregisters the timeout/watch from glib mainloop - the

Re: [libvirt] [PATCH 1/2] storage: Switch to new def on pool-destroy

2012-06-25 Thread Michal Privoznik
On 25.06.2012 12:36, Daniel P. Berrange wrote: On Mon, Jun 25, 2012 at 12:32:47PM +0200, Michal Privoznik wrote: Currently, we share the idea of old new def with domains. Users can *-edit an object (domain, pool) which spawns a new internal representation for them. This is referenced via

[libvirt] [PATCH libvirt-gconfig] Add support for domain filesystems with type=bind|ram

2012-06-25 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com This adds support for filesystems with type=bind or type=ram, eg filesystem type='bind' source dir=/some/guest/file/ target dir=/other/guest/file/ /filesystem And filesystem type='ram' source usage='102400'/ target

[libvirt] Entering freeze for libvirt-0.9.13

2012-06-25 Thread Daniel Veillard
I just tagged the git tree and I pushed the tarball for rc1: ftp://libvirt.org/libvirt/libvirt-0.9.13-rc1.tar.gz the rpms I build are coming along soon. Please give it a try, the basic seems okay to me (kvm driver seems to need the qemu one now but otherwise, no surprize so far) Give it a

[libvirt] [PATCH v2] storage: Introduce --inactive for pool-dumpxml

2012-06-25 Thread Michal Privoznik
Storage is one of the last domains in libvirt where we don't fully utilize inactive and live XML. Okay, it might be because we don't have support for that. So implement such support. However, we need to fallback when talking to old daemon which doesn't support this new flag called

Re: [libvirt] [PATCHv2 3/5] S390: Fixed Parser for /proc/cpuinfo needs to be adapted for your architecture

2012-06-25 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 01:50:12PM +0200, Viktor Mihajlovski wrote: From: Thang Pham thang.p...@us.ibm.com Minimal CPU parser for s390 to avoid compile time warning. Signed-off-by: Thang Pham thang.p...@us.ibm.com Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCHv2 4/5] S390: Fixed core identification for s390

2012-06-25 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 01:50:13PM +0200, Viktor Mihajlovski wrote: For the s390x architecture the sysfs core_id alone is not unique. As a result it can happen that libvirt thinks there are less host CPUs available than really present. Currently, a logical CPU is equivalent to a core for

Re: [libvirt] [PATCHv2 5/5] S390: Added sysinfo for host on s390x.

2012-06-25 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 01:50:14PM +0200, Viktor Mihajlovski wrote: +static int +virSysinfoParseProcessor(const char *base, virSysinfoDefPtr ret) +{ +/* Find processor N: line and gather the processor manufacturer, version, serial number, and family */ +while((tmp_base =

Re: [libvirt] [PATCHv2 2/5] S390: CPU support for s390(x)

2012-06-25 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 01:50:11PM +0200, Viktor Mihajlovski wrote: From: Thang Pham thang.p...@us.ibm.com Adding CPU encoder/decoder for s390 to avoid runtime error messages. Signed-off-by: Thang Pham thang.p...@us.ibm.com Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com ---

[libvirt] [PATCH 0/6 v2] Support forward mode='hostdev' and interface pools

2012-06-25 Thread Shradha Shah
This patch series supports the forward mode='hostdev'. The functionality of this mode is the same as interface type='hostdev' but with the added benefit of using interface pools. The patch series also contains a patch to support use of interface names and PCI device addresses interchangeably in a

Re: [libvirt] [PATCH v2] storage: Introduce --inactive for pool-dumpxml

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 01:24:57PM +0200, Michal Privoznik wrote: Storage is one of the last domains in libvirt where we don't fully utilize inactive and live XML. Okay, it might be because we don't have support for that. So implement such support. However, we need to fallback when talking to

[libvirt] [PATCH 1/6 v2] Prerequisite Patch. virDomainDevicePCIAddress and respective functions moved to a new file called conf/device_conf.ch

2012-06-25 Thread Shradha Shah
Refactoring existing code without causing any functional changes to prepare for new code. This patch makes the code reusable. Signed-off-by: Shradha Shah ss...@solarflare.com --- src/Makefile.am |7 ++- src/conf/device_conf.c | 135

Re: [libvirt] [PATCH] qemu: Improve error if setmem fails for lacking of balloon support

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 06:49:52PM +0800, Osier Yang wrote: cannot set memory of an active domain is misleading, it sounds like setting memory of active domain is not supported. --- src/qemu/qemu_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[libvirt] [PATCH 3/6 v2] RNG updates, new xml parser/formatter code to support forward mode=hostdev

2012-06-25 Thread Shradha Shah
This patch introduces the new forward mode='hostdev' along with attribute managed Includes updates to the network RNG and new xml parser/formatter code. Signed-off-by: Shradha Shah ss...@solarflare.com --- docs/schemas/network.rng | 82 +++--

Re: [libvirt] [libvirt-glib 3/8] Setters for CapabilitiesCpuTopology props

2012-06-25 Thread Christophe Fergeau
Same concerns as with the first patch, GVirConfigCapabilitiesCpuTopology isn't mutable, it may be worth introducing a GVirConfigDomainCpuTopology which would contain these setters (and this would go well with the other GVirConfigDomain classes you introduce in this series). Christophe On Sat,

Re: [libvirt] [libvirt-glib 1/8] Setters/adders for GVirConfigCapabilitiesCpu props

2012-06-25 Thread Christophe Fergeau
On Sat, Jun 23, 2012 at 10:17:57PM +0300, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org - gvir_config_capabilities_cpu_add_feature - gvir_config_capabilities_cpu_set_topology As I understand it, the capabilities XML is read-only, the only reason for these

[libvirt] [PATCH 5/6 v2] Forward Mode Hostdev network driver Implementation

2012-06-25 Thread Shradha Shah
This patch updates the network driver to properly utilize the new attributes/elements that are now in virNetworkDef Signed-off-by: Shradha Shah ss...@solarflare.com --- docs/formatnetwork.html.in | 62 + src/network/bridge_driver.c | 213

[libvirt] [PATCH 4/6 v2] Code to return interface name or pci_addr of the VF in actualDevice

2012-06-25 Thread Shradha Shah
The network pool should be able to keep track of both, network device names nad PCI addresses, and return the appropriate one in the actualDevice when networkAllocateActualDevice is called. Signed-off-by: Shradha Shah ss...@solarflare.com --- src/network/bridge_driver.c | 33

[libvirt] [PATCH 2/6 v2] Moved the code to create implicit interface pool from PF to a new function

2012-06-25 Thread Shradha Shah
Just code movement no functional changes here. This makes the code reusable Signed-off-by: Shradha Shah ss...@solarflare.com --- src/network/bridge_driver.c | 84 ++ 1 files changed, 52 insertions(+), 32 deletions(-) diff --git

Re: [libvirt] [libvirt-glib 1/8] Setters/adders for GVirConfigCapabilitiesCpu props

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 01:34:41PM +0200, Christophe Fergeau wrote: On Sat, Jun 23, 2012 at 10:17:57PM +0300, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org - gvir_config_capabilities_cpu_add_feature - gvir_config_capabilities_cpu_set_topology As I

[libvirt] [PATCH 6/6 v2] Forward Mode 'Hostdev' qemu driver implementation

2012-06-25 Thread Shradha Shah
Signed-off-by: Shradha Shah ss...@solarflare.com --- src/qemu/qemu_command.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 93c018d..0f6b714 100644 --- a/src/qemu/qemu_command.c +++

Re: [libvirt] [libvirt-glib 6/8] Make GVirConfigCapabilitiesCpu.get_features virtual

2012-06-25 Thread Christophe Fergeau
On Sat, Jun 23, 2012 at 10:18:02PM +0300, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c | 28 +--- libvirt-gconfig/libvirt-gconfig-capabilities-cpu.h |4 ++- 2 files changed, 22

Re: [libvirt] [libvirt-glib 1/8] Setters/adders for GVirConfigCapabilitiesCpu props

2012-06-25 Thread Christophe Fergeau
On Mon, Jun 25, 2012 at 12:37:48PM +0100, Daniel P. Berrange wrote: On Mon, Jun 25, 2012 at 01:34:41PM +0200, Christophe Fergeau wrote: On Sat, Jun 23, 2012 at 10:17:57PM +0300, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org -

Re: [libvirt] [libvirt-glib 5/5] mainloop: don't reschedule deleted timeouts/watches

2012-06-25 Thread Christophe Fergeau
On Mon, Jun 25, 2012 at 01:04:30PM +0200, Christophe Fergeau wrote: It happens at more or less random times, so I'm not sure if I'll be able to catch a backtrace when the watch is removed. Luckily watches don't get removed very often, so I managed to catch both the remove and the following

Re: [libvirt] [PATCH] conf: Fill listenAddr from driver if none set

2012-06-25 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 03:52:45PM +0200, Michal Privoznik wrote: Currently, if domain's graphic has no listenAddr set we provide the one from qemu.conf. However, we must make this transient to not overwrite future changes to the config file. Moreover, we have to store this into domain state

Re: [libvirt] [PATCH] conf: Fill listenAddr from driver if none set

2012-06-25 Thread Michal Privoznik
On 25.06.2012 13:53, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 03:52:45PM +0200, Michal Privoznik wrote: Currently, if domain's graphic has no listenAddr set we provide the one from qemu.conf. However, we must make this transient to not overwrite future changes to the config file.

Re: [libvirt] [PATCH] conf: Fill listenAddr from driver if none set

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 02:03:04PM +0200, Michal Privoznik wrote: On 25.06.2012 13:53, Daniel P. Berrange wrote: From 25273cfefec989d78ec867b6ff56e22f7317f82a Mon Sep 17 00:00:00 2001 From: Daniel P. Berrange berra...@redhat.com Date: Mon, 25 Jun 2012 12:50:52 +0100 Subject: [PATCH]

Re: [libvirt] [PATCH] conf: Fill listenAddr from driver if none set

2012-06-25 Thread Michal Privoznik
On 25.06.2012 14:03, Michal Privoznik wrote: On 25.06.2012 13:53, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 03:52:45PM +0200, Michal Privoznik wrote: Currently, if domain's graphic has no listenAddr set we provide the one from qemu.conf. However, we must make this transient to not

Re: [libvirt] [PATCH] conf: Fill listenAddr from driver if none set

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 02:08:23PM +0200, Michal Privoznik wrote: On 25.06.2012 14:03, Michal Privoznik wrote: On 25.06.2012 13:53, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 03:52:45PM +0200, Michal Privoznik wrote: Currently, if domain's graphic has no listenAddr set we provide

Re: [libvirt] [PATCH libvirt-gconfig] Add support for domain filesystems with type=bind|ram

2012-06-25 Thread Christophe Fergeau
On Mon, Jun 25, 2012 at 12:14:59PM +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This adds support for filesystems with type=bind or type=ram, Both of these are new in libvirt 0.9.13. However, libvirt-glib will still compile and work if it's linking with an

Re: [libvirt] [PATCH v2] storage backend: Add sheepdog support

2012-06-25 Thread Daniel P. Berrange
On Thu, Jun 14, 2012 at 01:14:56PM +0200, Sebastian Wiedenroth wrote: This patch brings support to manage sheepdog pools and volumes to libvirt. It uses the collie command-line utility that comes with sheepdog for that. A sheepdog pool in libvirt maps to a sheepdog cluster. It needs a host

Re: [libvirt] [PATCH] storage backend rbd: Do not prefix rbd: on volume names.

2012-06-25 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 02:45:59PM +0200, Wido den Hollander wrote: We used to prefix 'rbd:' to volume names, this is not necessary. Qemu takes RBD devices in this way, like: qemu -drive rbd:pool/image When attaching a network disk like RBD to a guest we however do not use this prefix.

Re: [libvirt] [PATCHv2 0/5] Basic Enablement of s390

2012-06-25 Thread Viktor Mihajlovski
On 06/25/2012 10:41 AM, Daniel Veillard wrote: On Fri, Jun 22, 2012 at 01:50:09PM +0200, Viktor Mihajlovski wrote: Resending as a thread, same content. Please ignore previous submission. The first series of patches aimed to enable libvirt to manage qemu/kvm domains hosted on the System z

Re: [libvirt] This patch creates a mount point for libvirt-lxc containers to mount on the destination system if it does not exist.

2012-06-25 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/25/2012 05:56 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 09:59:58AM -0400, Daniel J Walsh wrote: Currently libvirt-lxc checks to see if the destination exists and is a directory. If it is not a directory then the mount fails.

Re: [libvirt] [PATCHv2 0/5] Basic Enablement of s390

2012-06-25 Thread Daniel Veillard
On Mon, Jun 25, 2012 at 03:08:09PM +0200, Viktor Mihajlovski wrote: On 06/25/2012 10:41 AM, Daniel Veillard wrote: On Fri, Jun 22, 2012 at 01:50:09PM +0200, Viktor Mihajlovski wrote: Resending as a thread, same content. Please ignore previous submission. The first series of patches aimed to

Re: [libvirt] [PATCH] qemu: Improve error if setmem fails for lacking of balloon support

2012-06-25 Thread Osier Yang
On 2012年06月25日 19:34, Daniel P. Berrange wrote: On Mon, Jun 25, 2012 at 06:49:52PM +0800, Osier Yang wrote: cannot set memory of an active domain is misleading, it sounds like setting memory of active domain is not supported. --- src/qemu/qemu_driver.c |3 ++- 1 files changed, 2

Re: [libvirt] [PATCHv2 0/5] Basic Enablement of s390

2012-06-25 Thread Daniel Veillard
On Mon, Jun 25, 2012 at 09:43:41PM +0800, Daniel Veillard wrote: On Mon, Jun 25, 2012 at 03:08:09PM +0200, Viktor Mihajlovski wrote: On 06/25/2012 10:41 AM, Daniel Veillard wrote: On Fri, Jun 22, 2012 at 01:50:09PM +0200, Viktor Mihajlovski wrote: Resending as a thread, same content. Please

Re: [libvirt] [Qemu-devel] [PATCH v4 1/7] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg

2012-06-25 Thread Corey Bryant
On 06/25/2012 05:16 AM, Stefan Hajnoczi wrote: On Fri, Jun 22, 2012 at 01:31:17PM -0600, Eric Blake wrote: On 06/22/2012 12:36 PM, Corey Bryant wrote: This sets the close-on-exec flag for the file descriptor received via SCM_RIGHTS. Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH v7 0/8] Add basic driver for Parallels Virtuozzo Server

2012-06-25 Thread Daniel Veillard
On Mon, Jun 25, 2012 at 12:57:55PM +0400, Dmitry Guryanov wrote: Parallels Cloud Server is a virtualization solution that allows users to simultaneously run multiple virtual machines and containers on the same physical server. More information can be found here:

Re: [libvirt] [PATCH v7 0/8] Add basic driver for Parallels Virtuozzo Server

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 09:49:03PM +0800, Daniel Veillard wrote: On Mon, Jun 25, 2012 at 12:57:55PM +0400, Dmitry Guryanov wrote: Parallels Cloud Server is a virtualization solution that allows users to simultaneously run multiple virtual machines and containers on the same physical server.

Re: [libvirt] [Qemu-devel] [PATCH v4 7/7] osdep: Enable qemu_open to dup pre-opened fd

2012-06-25 Thread Corey Bryant
On 06/22/2012 03:58 PM, Eric Blake wrote: On 06/22/2012 12:36 PM, Corey Bryant wrote: This patch adds support to qemu_open to dup(fd) a pre-opened file descriptor if the filename is of the format /dev/fd/X. This can be used when QEMU is restricted from opening files, and the management

Re: [libvirt] [PATCH 1/2] storage: Switch to new def on pool-destroy

2012-06-25 Thread Dave Allan
On Mon, Jun 25, 2012 at 01:13:48PM +0200, Michal Privoznik wrote: On 25.06.2012 12:36, Daniel P. Berrange wrote: On Mon, Jun 25, 2012 at 12:32:47PM +0200, Michal Privoznik wrote: Currently, we share the idea of old new def with domains. Users can *-edit an object (domain, pool) which

[libvirt] Stored secrets seem to get corrupted

2012-06-25 Thread Wido den Hollander
Hi, On one of my systems I'm having troubles with my RBD storage backend. At first I thought it was a problem with my code, but after trying the same code on a second machine I'm a bit confused. The problem is that the storage backend tries to retrieve the value of a secret and base64

Re: [libvirt] [Qemu-devel] [PATCH v4 7/7] osdep: Enable qemu_open to dup pre-opened fd

2012-06-25 Thread Eric Blake
On 06/25/2012 08:24 AM, Corey Bryant wrote: +if (fcntl_setfl(ret, O_CLOEXEC, (flags O_CLOEXEC) ? 1 : 0) 0) { Broken. O_CLOEXEC _only_ affects open(); to change it on an existing fd, you have to use fcntl(F_GETFD/F_SETFD) (not F_GETFL/F_SETFL). I'll fix this in v5. Don't

Re: [libvirt] [PATCHv2 5/5] S390: Added sysinfo for host on s390x.

2012-06-25 Thread Michal Privoznik
On 25.06.2012 13:29, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 01:50:14PM +0200, Viktor Mihajlovski wrote: +static int +virSysinfoParseProcessor(const char *base, virSysinfoDefPtr ret) +{ +/* Find processor N: line and gather the processor manufacturer, version, serial

[libvirt] [PATCH 1/2] nodeinfo: Fix code style and some minor bugs.

2012-06-25 Thread Peter Krempa
This patch cleans up some line breaks and fixes two minor bugs: - buffer pointer increment to the actual length that should be skipped - jump to cleanup section instead of returning -1 --- src/nodeinfo.c | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-)

Re: [libvirt] [PATCHv2 1/5] S390: Override QEMU_CAPS_NO_ACPI for s390x

2012-06-25 Thread Michal Privoznik
On 22.06.2012 13:50, Viktor Mihajlovski wrote: Starting a KVM guest on s390 fails immediately. This is because qemu --help reports -no-acpi even for the s390(x) architecture but -no-acpi isn't supported there. Workaround is to remove QEMU_CAPS_NO_ACPI from the capability set after the

[libvirt] [PATCH 2/2] nodeinfo: Fix CPU core counting

2012-06-25 Thread Peter Krempa
Parsing of the processor information from /sys/ didn't take into account that cores on different physical processors may have different core ID's. This resulted in reporting more cores than actually were present. This patch changes the process of counting cores. So that cores are counted

Re: [libvirt] [PATCHv2 2/5] S390: CPU support for s390(x)

2012-06-25 Thread Michal Privoznik
On 22.06.2012 13:50, Viktor Mihajlovski wrote: From: Thang Pham thang.p...@us.ibm.com Adding CPU encoder/decoder for s390 to avoid runtime error messages. Signed-off-by: Thang Pham thang.p...@us.ibm.com Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/Makefile.am

[libvirt] [PATCH 0/2] Fix counting of cores while gathering processor information

2012-06-25 Thread Peter Krempa
Peter Krempa (2): nodeinfo: Fix code style and some minor bugs. nodeinfo: Fix CPU core counting src/nodeinfo.c | 137 +--- .../linux-nodeinfo-sysfs-test-4-cpu-x86-output.txt |1 + .../linux-nodeinfo-sysfs-test-4-x86.cpuinfo| 400

Re: [libvirt] [PATCHv2 0/5] Basic Enablement of s390

2012-06-25 Thread Michal Privoznik
On 25.06.2012 15:54, Daniel Veillard wrote: On Mon, Jun 25, 2012 at 09:43:41PM +0800, Daniel Veillard wrote: On Mon, Jun 25, 2012 at 03:08:09PM +0200, Viktor Mihajlovski wrote: On 06/25/2012 10:41 AM, Daniel Veillard wrote: On Fri, Jun 22, 2012 at 01:50:09PM +0200, Viktor Mihajlovski wrote:

Re: [libvirt] [PATCHv2 3/5] S390: Fixed Parser for /proc/cpuinfo needs to be adapted for your architecture

2012-06-25 Thread Michal Privoznik
On 25.06.2012 13:26, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 01:50:12PM +0200, Viktor Mihajlovski wrote: From: Thang Pham thang.p...@us.ibm.com Minimal CPU parser for s390 to avoid compile time warning. Signed-off-by: Thang Pham thang.p...@us.ibm.com Signed-off-by: Viktor

Re: [libvirt] [PATCHv2 4/5] S390: Fixed core identification for s390

2012-06-25 Thread Michal Privoznik
On 25.06.2012 13:25, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 01:50:13PM +0200, Viktor Mihajlovski wrote: For the s390x architecture the sysfs core_id alone is not unique. As a result it can happen that libvirt thinks there are less host CPUs available than really present. Currently,

[libvirt] [PATCH] AUTHORS: Update

2012-06-25 Thread Michal Privoznik
Latest patchset enabling libvirt on s390(x) was developed by Viktor Mihajlovski mihaj...@linux.vnet.ibm.com Thang Pham thang.p...@us.ibm.com Add them to the AUTHORS file. --- Let me know if you prefer any other spelling. AUTHORS |2 ++ 1 files changed, 2 insertions(+), 0

Re: [libvirt] Stored secrets seem to get corrupted

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 04:37:48PM +0200, Wido den Hollander wrote: Hi, On one of my systems I'm having troubles with my RBD storage backend. At first I thought it was a problem with my code, but after trying the same code on a second machine I'm a bit confused. The problem is that the

Re: [libvirt] [PATCH] storage backend rbd: Do not prefix rbd: on volume names.

2012-06-25 Thread Michal Privoznik
On 25.06.2012 15:04, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 02:45:59PM +0200, Wido den Hollander wrote: We used to prefix 'rbd:' to volume names, this is not necessary. Qemu takes RBD devices in this way, like: qemu -drive rbd:pool/image When attaching a network disk like RBD to a

Re: [libvirt] [Qemu-devel] [PATCH v4 7/7] osdep: Enable qemu_open to dup pre-opened fd

2012-06-25 Thread Kevin Wolf
Am 25.06.2012 16:34, schrieb Eric Blake: Also, I noticed in the fnctl man page that F_SETFL: On Linux this command can change only the O_APPEND, O_ASYNC, O_DIRECT, O_NOATIME, and O_NONBLOCK flags. So I'll only set/unset these flags. O_NDELAY is the obsolete spelling of O_NONBLOCK; which

Re: [libvirt] [Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command

2012-06-25 Thread Corey Bryant
On 06/22/2012 04:24 PM, Eric Blake wrote: On 06/22/2012 12:36 PM, Corey Bryant wrote: This patch adds the pass-fd QMP command using the QAPI framework. Like the getfd command, it is used to pass a file descriptor via SCM_RIGHTS and associate it with a name. However, the pass-fd command also

Re: [libvirt] [Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command

2012-06-25 Thread Kevin Wolf
Am 25.06.2012 16:51, schrieb Corey Bryant: Thanks for catching this. I'll fix this in v5. In terms of platforms that support dup3 vs dup2, I'm assuming the following preprocessor checks will do what we need: #if defined(__linux__) || defined(__CYGWIN__) dup3(fd, monfd-fd, O_CLOEXEC)

[libvirt] [PATCH] qemu: Always set auth_supported for Ceph disks.

2012-06-25 Thread Wido den Hollander
Recently the Ceph project defaulted auth_supported from 'none' to 'cephx'. When no auth information was set for Ceph disks this would lead to librados defaulting to 'cephx', but there would be no additional authorization information. We now explicitly set auth_supported to none when passing

[libvirt] [ANNOUNCE] libvirt-glib 0.0.9 release

2012-06-25 Thread Daniel P. Berrange
I am pleased to announce that a new release of the libvirt-glib package, version 0.0.8 is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) New in this release: - Full API

Re: [libvirt] [PATCH v2 1/5] Introduce virDomainGetInterfacesAddresses API

2012-06-25 Thread Peter Krempa
On 06/21/12 15:55, Michal Privoznik wrote: This API returns dynamically allocated XML document showing IP addresses for all domain interfaces. --- docs/schemas/interfaces.rng | 57 ++ include/libvirt/libvirt.h.in |2 + src/driver.h

Re: [libvirt] [Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command

2012-06-25 Thread Eric Blake
On 06/25/2012 09:34 AM, Kevin Wolf wrote: Am 25.06.2012 16:51, schrieb Corey Bryant: Thanks for catching this. I'll fix this in v5. In terms of platforms that support dup3 vs dup2, I'm assuming the following preprocessor checks will do what we need: #if defined(__linux__) ||

  1   2   >