Re: [libvirt] [PATCH 09/11] Run an RPC protocol over the LXC controller monitor

2012-07-27 Thread Jiri Denemark
On Tue, Jul 24, 2012 at 14:22:51 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This defines a new RPC protocol to be used between the LXC controller and the libvirtd LXC driver. There is only a single RPC message defined thus far, an asynchronous EXIT event

Re: [libvirt] [PATCH 10/11] Allow CAP_SYS_REBOOT on new enough kernels

2012-07-27 Thread Jiri Denemark
On Tue, Jul 24, 2012 at 14:22:52 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Check whether the reboot() system call is virtualized, and if it is, then allow the container to keep CAP_SYS_REBOOT. Based on an original patch by Serge Hallyn Signed-off-by:

Re: [libvirt] [PATCHv2 1/2] virsh: Refactor error clearing on graceful fallback paths

2012-07-27 Thread Martin Kletzander
On 07/26/2012 02:48 PM, Peter Krempa wrote: Virsh uses an error handler to save errors from libvirt. On some code paths it's needed to clear libvirt errors and continue on fallback code paths without reporting failure. This patch adds function vshResetLibvirtError() that clears error

Re: [libvirt] [PATCH 11/11] Add handling for reboots of LXC containers

2012-07-27 Thread Jiri Denemark
On Tue, Jul 24, 2012 at 14:22:53 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The reboot() syscall is allowed by new kernels for LXC containers. The LXC controller can detect whether a reboot was requested (instead of a normal shutdown) by looking at the init

Re: [libvirt] [PATCHv2 2/2] virsh: Fix error resetting on fallback paths

2012-07-27 Thread Martin Kletzander
On 07/26/2012 02:48 PM, Peter Krempa wrote: On some fallback paths in virsh, error reported by the previously failed API is cleared by virResetLastError() that doesn'd free error stored by s/doesn'd/doesn't/ virsh. This patch changes this to clear it using vshResetLibvirtError(). ACK,

Re: [libvirt] [PATCHv2 2/2] virsh: Fix error resetting on fallback paths

2012-07-27 Thread Peter Krempa
On 07/27/12 10:21, Martin Kletzander wrote: On 07/26/2012 02:48 PM, Peter Krempa wrote: On some fallback paths in virsh, error reported by the previously failed API is cleared by virResetLastError() that doesn'd free error stored by s/doesn'd/doesn't/ virsh. This patch changes this to clear

Re: [libvirt] [PATCH v2 3/5] Add callback to virNetClient to be invoked on connection close

2012-07-27 Thread Daniel P. Berrange
On Thu, Jul 26, 2012 at 03:17:21PM +0200, Jiri Denemark wrote: On Tue, Jul 24, 2012 at 14:17:03 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Allow detection of socket close in virNetClient via an callback s/an/a/ function, triggered on any condition

Re: [libvirt] [PATCH 07/11] Move LXC monitor code out into separate file

2012-07-27 Thread Daniel P. Berrange
On Fri, Jul 27, 2012 at 12:22:23AM +0200, Jiri Denemark wrote: On Tue, Jul 24, 2012 at 14:22:49 +0100, Daniel P. Berrange wrote: + +#define VIR_FROM_THIS VIR_FROM_LXC + +struct _virLXCMonitor { +int refs; + +virMutex lock; /* also used to protect fd */ Which fd are you

Re: [libvirt] [PATCH 10/11] Allow CAP_SYS_REBOOT on new enough kernels

2012-07-27 Thread Daniel P. Berrange
On Fri, Jul 27, 2012 at 09:59:47AM +0200, Jiri Denemark wrote: On Tue, Jul 24, 2012 at 14:22:52 +0100, Daniel P. Berrange wrote: @@ -1651,6 +1730,9 @@ static int lxcContainerChild( void *data ) goto cleanup; } +if ((hasReboot = lxcContainerHasReboot()) 0) +

Re: [libvirt] [PATCH 11/11] Add handling for reboots of LXC containers

2012-07-27 Thread Daniel P. Berrange
On Fri, Jul 27, 2012 at 10:18:48AM +0200, Jiri Denemark wrote: On Tue, Jul 24, 2012 at 14:22:53 +0100, Daniel P. Berrange wrote: +static int +virLXCProcessReboot(virLXCDriverPtr driver, +virDomainObjPtr vm) +{ +virConnectPtr conn =

Re: [libvirt] [PATCH 09/11] Run an RPC protocol over the LXC controller monitor

2012-07-27 Thread Daniel P. Berrange
On Fri, Jul 27, 2012 at 09:41:29AM +0200, Jiri Denemark wrote: On Tue, Jul 24, 2012 at 14:22:51 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com This defines a new RPC protocol to be used between the LXC controller and the libvirtd LXC driver. There is only a

Re: [libvirt] [PATCH v2 4/5] Update remote driver to support the connection close callbacks

2012-07-27 Thread Daniel P. Berrange
On Thu, Jul 26, 2012 at 03:23:48PM +0200, Jiri Denemark wrote: On Tue, Jul 24, 2012 at 14:17:04 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Update the remote driver to use the virNetClient close callback to trigger the virConnectPtr close callbacks

Re: [libvirt] [PATCH 00/13 v2] Split virsh

2012-07-27 Thread Osier Yang
On 2012年07月27日 12:42, Laine Stump wrote: On 07/26/2012 11:00 AM, Eric Blake wrote: My apologies - I'm confusing the source files for virt-host-validate with the files for virsh. I guess that means I'm now wondering if we should refactor tools into having subdirectories, one per tool? Now that

Re: [libvirt] [PATCH] maint: avoid regression on copyright listings

2012-07-27 Thread Osier Yang
On 2012年07月27日 07:14, Eric Blake wrote: Commit f9ce7dad6 tried to kill uses of a raw street address, but missed a few instances. Automate things so we don't introduce new problems in the future. * cfg.mk (sc_copyright_address): New rule. (exclude_file_name_regexp--sc_copyright_address): Add

Re: [libvirt] [PATCH 2/8] parallels: add functions to list domains and get info

2012-07-27 Thread Daniel P. Berrange
On Thu, Jul 26, 2012 at 10:32:01PM +0400, Dmitry Guryanov wrote: +static virDomainObjPtr +parallelsLoadDomain(parallelsConnPtr privconn, virJSONValuePtr jobj) +{ +if (!(def-os.type = strdup(hvm))) +goto no_memory; + +if (!(def-os.arch = strdup(PARALLELS_DEFAULT_ARCH))) +

Re: [libvirt] [PATCH 1/8] parallels: add driver skeleton

2012-07-27 Thread Daniel P. Berrange
On Thu, Jul 26, 2012 at 10:32:00PM +0400, Dmitry Guryanov wrote: Parallels Cloud Server is a cloud-ready virtualization solution that allows users to simultaneously run multiple virtual machines and containers on the same physical server. More information can be found here:

Re: [libvirt] [PATCH 2/8] parallels: add functions to list domains and get info

2012-07-27 Thread Daniel P. Berrange
On Thu, Jul 26, 2012 at 10:32:01PM +0400, Dmitry Guryanov wrote: Parallels driver is 'stateless', like vmware or openvz drivers. It collects information about domains during startup using command-line utility prlctl. VMs in Parallels are identified by UUIDs or unique names, which can be used

Re: [libvirt] [PATCH 3/8] parallels: implement functions for domain life cycle management

2012-07-27 Thread Daniel P. Berrange
On Thu, Jul 26, 2012 at 10:32:02PM +0400, Dmitry Guryanov wrote: Add functions for create/shutdown/destroy and suspend/resume domain. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 143 ++

Re: [libvirt] [PATCH 4/8] parallels: get info about serial ports

2012-07-27 Thread Daniel P. Berrange
On Thu, Jul 26, 2012 at 10:34:31PM +0400, Dmitry Guryanov wrote: Add support of collecting information about serial ports. This change is needed mostly as an example, support of other devices will be added later. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com ---

Re: [libvirt] [PATCH 5/8] parallels: add support of VNC remote display

2012-07-27 Thread Daniel P. Berrange
On Thu, Jul 26, 2012 at 10:34:32PM +0400, Dmitry Guryanov wrote: Add support for reading VNC parameters of the VM. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 60 ++ 1 files changed, 60 insertions(+),

Re: [libvirt] [PATCH 1/8] parallels: add driver skeleton

2012-07-27 Thread Dmitry Guryanov
On 07/27/2012 01:16 PM, Daniel P. Berrange wrote: On Thu, Jul 26, 2012 at 10:32:00PM +0400, Dmitry Guryanov wrote: Parallels Cloud Server is a cloud-ready virtualization solution that allows users to simultaneously run multiple virtual machines and containers on the same physical server. More

Re: [libvirt] [PATCH 1/8] parallels: add driver skeleton

2012-07-27 Thread Daniel P. Berrange
On Fri, Jul 27, 2012 at 01:48:49PM +0400, Dmitry Guryanov wrote: On 07/27/2012 01:16 PM, Daniel P. Berrange wrote: On Thu, Jul 26, 2012 at 10:32:00PM +0400, Dmitry Guryanov wrote: +static virCapsPtr +parallelsBuildCapabilities(void) +{ +virCapsPtr caps; +virCapsGuestPtr guest; +

[libvirt] [PATCH] maint: Use consistent copyright.

2012-07-27 Thread Who should the emails appear to be from? [Osier Yang
From: Osier Yang jy...@redhat.com This is a follow up patch of commit f9ce7dad6, it modifies all the files which declare the copyright like See COPYING.LIB for the License of this software to use the detailed/consistent one. And deserts the outdated comments like: * libvirt-qemu.h: * Summary:

Re: [libvirt] [PATCH 2/8] parallels: add functions to list domains and get info

2012-07-27 Thread Dmitry Guryanov
On 07/27/2012 01:23 PM, Daniel P. Berrange wrote: On Thu, Jul 26, 2012 at 10:32:01PM +0400, Dmitry Guryanov wrote: +static virDomainObjPtr +parallelsLoadDomain(parallelsConnPtr privconn, virJSONValuePtr jobj) +{ +if (!(def-os.type = strdup(hvm))) +goto no_memory; + +if

Re: [libvirt] [PATCH] maint: Use consistent copyright.

2012-07-27 Thread Daniel P. Berrange
Hmm, something went strange in the 'From' line of your email with your name ! On Fri, Jul 27, 2012 at 06:06:29PM +0800, ?[4mWho should the emails appear to be from? [Osier Yang wrote: From: Osier Yang jy...@redhat.com This is a follow up patch of commit f9ce7dad6, it modifies all the files

Re: [libvirt] [PATCH] maint: Use consistent copyright.

2012-07-27 Thread Osier Yang
On 2012年07月27日 18:18, Daniel P. Berrange wrote: Hmm, something went strange in the 'From' line of your email with your name ! On Fri, Jul 27, 2012 at 06:06:29PM +0800, ?[4mWho should the emails appear to be from? [Osier Yang wrote: seems my git-send-email did some tricks. From: Osier

Re: [libvirt] [PATCH 3/8] parallels: implement functions for domain life cycle management

2012-07-27 Thread Dmitry Guryanov
On 07/27/2012 01:32 PM, Daniel P. Berrange wrote: On Thu, Jul 26, 2012 at 10:32:02PM +0400, Dmitry Guryanov wrote: Add functions for create/shutdown/destroy and suspend/resume domain. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 143

Re: [libvirt] [PATCH 3/8] parallels: implement functions for domain life cycle management

2012-07-27 Thread Daniel P. Berrange
On Fri, Jul 27, 2012 at 02:26:44PM +0400, Dmitry Guryanov wrote: On 07/27/2012 01:32 PM, Daniel P. Berrange wrote: On Thu, Jul 26, 2012 at 10:32:02PM +0400, Dmitry Guryanov wrote: Add functions for create/shutdown/destroy and suspend/resume domain. Signed-off-by: Dmitry Guryanov

[libvirt] [PATCH v3 4/5] Update remote driver to support the connection close callbacks

2012-07-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Update the remote driver to use the virNetClient close callback to trigger the virConnectPtr close callbacks Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/datatypes.h|2 ++ src/libvirt.c |3 ++-

Re: [libvirt] [PATCH 01/11] Process all pending I/O for a RPC client before checking EOF

2012-07-27 Thread Daniel P. Berrange
On Thu, Jul 26, 2012 at 04:00:22PM +0200, Jiri Denemark wrote: On Tue, Jul 24, 2012 at 14:22:43 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com In the socket event handler for the RPC client we must deal with read/write events, before checking for EOF,

[libvirt] [PATCH] Remove tabs from all perl files enforce this

2012-07-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The cfg.mk file rule to check for tab characters was not applied to perl files. Much of our Perl code is full of tabs as a result. Kill them, kill them all ! --- build-aux/augeas-gentest.pl | 42 +++ cfg.mk |2 +-

[libvirt] [PATCH 07/11 v2] Move LXC monitor code out into separate file

2012-07-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Move the code that handles the LXC monitor out of the lxc_process.c file and into lxc_monitor.{c,h} Signed-off-by: Daniel P. Berrange berra...@redhat.com --- po/POTFILES.in|1 + src/Makefile.am |1 + src/lxc/lxc_domain.h |4

Re: [libvirt] Can I run a shell script in Guest OS via libvirt

2012-07-27 Thread Eric Blake
On 07/26/2012 10:16 PM, Doan Van Tuyen wrote: Hi all. I amd trying to use libvirt-php to build a public cloud. I used Vmware hypervisor (free), XEN and KVM. Now I want to create a Virtual Machine from template. After that, I want to install some application on that VM. *Can I run a shell

[libvirt] [PATCH 0/2] Fix build of docs

2012-07-27 Thread Peter Krempa
This series probably would qualify as build breaker but I'm posting it anyways. Without this, docs building in apibuild.py fails. Peter Krempa (2): docs: Add method to print warnings in docBuilder class lib: Revert removing of Summary and Description fields in headers docs/apibuild.py

[libvirt] [PATCH 2/2] lib: Revert removing of Summary and Description fields in headers

2012-07-27 Thread Peter Krempa
Those fields are used by the apibuild script to create documentation. This commit partialy reverts a4bcefbcff01c9cdc257127df376929cd80304b1. --- include/libvirt/libvirt-qemu.h |3 +++ include/libvirt/libvirt.h.in |3 +++ include/libvirt/virterror.h|3 +++ 3 files changed, 9

[libvirt] [PATCH 1/2] docs: Add method to print warnings in docBuilder class

2012-07-27 Thread Peter Krempa
The method was not existing and did not allow to diagnose problems. --- docs/apibuild.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index 05c2c8b..3f0ecd9 100755 --- a/docs/apibuild.py +++ b/docs/apibuild.py @@ -1961,6 +1961,11

[libvirt] [PATCH 6/7] target-i386: add implementation of query-cpudefs

2012-07-27 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- target-i386/cpu.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 6b9659f..b398439 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -28,6

Re: [libvirt] [PATCH 0/2] Fix build of docs

2012-07-27 Thread Daniel P. Berrange
On Fri, Jul 27, 2012 at 03:23:30PM +0200, Peter Krempa wrote: This series probably would qualify as build breaker but I'm posting it anyways. Without this, docs building in apibuild.py fails. Peter Krempa (2): docs: Add method to print warnings in docBuilder class lib: Revert

[libvirt] [PATCH 3/7] qapi: add query-machines command

2012-07-27 Thread Anthony Liguori
This provides the same output as -M ? but in a structured way. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- qapi-schema.json | 28 qmp-commands.hx |6 ++ vl.c | 31 +++ 3 files changed, 65 insertions(+),

[libvirt] [PATCH 0/2] Fix segfault when destroying domain with console open

2012-07-27 Thread Peter Krempa
In some cases when a newly created domain was destroyed the daemon crashed as it freed the console access data structure sooner than the stream could be freed so that the stream actually called the closing callback taht referenced freed data. Peter Krempa (2): conf: Remove dead code from

[libvirt] [PATCH 1/2] conf: Remove dead code from virConsoleOpen()

2012-07-27 Thread Peter Krempa
--- src/conf/virconsole.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/src/conf/virconsole.c b/src/conf/virconsole.c index 05e2b07..3d12011 100644 --- a/src/conf/virconsole.c +++ b/src/conf/virconsole.c @@ -381,15 +381,11 @@ int virConsoleOpen(virConsolesPtr cons,

[libvirt] [PATCH 1/7] qmp: introduce device-list-properties command

2012-07-27 Thread Anthony Liguori
This can be used in conjunction with qom-list-types to determine the supported set of devices and their parameters. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- qapi-schema.json | 28 qmp-commands.hx |7 +++ qmp.c| 50

Re: [libvirt] [PATCH] Remove tabs from all perl files enforce this

2012-07-27 Thread Peter Krempa
On 07/27/12 15:45, Peter Krempa wrote: On 07/27/12 14:52, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The cfg.mk file rule to check for tab characters was not applied to perl files. Much of our Perl code is full of tabs as a result. Kill them, kill them all ! ...

Re: [libvirt] [PATCH] maint: avoid regression on copyright listings

2012-07-27 Thread Eric Blake
On 07/27/2012 03:21 AM, Osier Yang wrote: On 2012年07月27日 07:14, Eric Blake wrote: Commit f9ce7dad6 tried to kill uses of a raw street address, but missed a few instances. Automate things so we don't introduce new problems in the future. # You should have received a copy of the GNU Lesser

[libvirt] [PATCH 2/7] qapi: mark QOM commands stable

2012-07-27 Thread Anthony Liguori
We've had a cycle to tweak. It is time to commit to supporting them. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- qapi-schema.json | 19 --- 1 files changed, 4 insertions(+), 15 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 015a84a..28e9914

Re: [libvirt] [PATCH] Remove tabs from all perl files enforce this

2012-07-27 Thread Eric Blake
On 07/27/2012 06:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The cfg.mk file rule to check for tab characters was not applied to perl files. Much of our Perl code is full of tabs as a result. Kill them, kill them all ! LOL. ---

[libvirt] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Anthony Liguori
This lets us provide a default implementation of a symbol which targets can override. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- compiler.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/compiler.h b/compiler.h index 736e770..f76921e 100644 --- a/compiler.h

[libvirt] [PATCH 2/2] conf: Remove callback from stream when freeing entries in console hash

2012-07-27 Thread Peter Krempa
When a domain has a active console connection and is destroyed the callback is called on private data that no longer exist causing a segfault. --- src/conf/virconsole.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/conf/virconsole.c b/src/conf/virconsole.c index

Re: [libvirt] [PATCH 5/7] qapi: add query-cpudefs command

2012-07-27 Thread Peter Maydell
On 27 July 2012 14:37, Anthony Liguori aligu...@us.ibm.com wrote: This command attempts to map to the behavior of -cpu ?. Unfortunately, the output of this command differs wildly across targets. I've never really understood why so much of the cpu selection logic is deferred to target-*... To

Re: [libvirt] [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Peter Maydell
On 27 July 2012 14:37, Anthony Liguori aligu...@us.ibm.com wrote: --- a/compiler.h +++ b/compiler.h @@ -45,6 +45,7 @@ # define GCC_ATTR __attribute__((__unused__, format(gnu_printf, 1, 2))) # define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m))) # endif +#define GCC_WEAK

Re: [libvirt] [PATCH 0/2] Fix build of docs

2012-07-27 Thread Peter Krempa
On 07/27/12 15:38, Daniel P. Berrange wrote: On Fri, Jul 27, 2012 at 03:23:30PM +0200, Peter Krempa wrote: This series probably would qualify as build breaker but I'm posting it anyways. Without this, docs building in apibuild.py fails. Peter Krempa (2): docs: Add method to print warnings

[libvirt] [PATCH 7/7] target-ppc: add implementation of query-cpudefs

2012-07-27 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- target-ppc/translate_init.c | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 5742229..7e025cb 100644 ---

[libvirt] [PATCH 0/7] qapi: add commands to remove the need to parse -help output

2012-07-27 Thread Anthony Liguori
This series implements the necessary commands to implements danpb's idea to remove -help parsing in libvirt. We would introduce all of these commands in 1.2 and then change the -help output starting in 1.3. Here is Dan's plan from a previous thread: danpb Basically I'd sum up my new idea as

[libvirt] [PATCH 5/7] qapi: add query-cpudefs command

2012-07-27 Thread Anthony Liguori
This command attempts to map to the behavior of -cpu ?. Unfortunately, the output of this command differs wildly across targets. To accomodate this, we use a weak symbol to implement a default version of the command that fails with a QERR_NOT_SUPPORTED error code. Targets can then override and

Re: [libvirt] [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 14:37, Anthony Liguori aligu...@us.ibm.com wrote: --- a/compiler.h +++ b/compiler.h @@ -45,6 +45,7 @@ # define GCC_ATTR __attribute__((__unused__, format(gnu_printf, 1, 2))) # define GCC_FMT_ATTR(n, m)

Re: [libvirt] [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Peter Maydell
On 27 July 2012 15:27, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: The GCC manual says Weak symbols are supported for ELF targets, and also for a.out targets when using the GNU assembler and linker. Have you tested this on Windows and MacOSX ?

[libvirt] [PATCH] shutting down guest vms on host shutdown does not work

2012-07-27 Thread Gerd v. Egidy
Hi, I originally postet this into the Fedora bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=843836 but was asked by Eric to post it here for review. Currently gracefully shutting down guest vms on host shutdown does not work on Fedora 17, the guests are killed hard on system shutdown. I

Re: [libvirt] [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 15:27, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: The GCC manual says Weak symbols are supported for ELF targets, and also for a.out targets when using the GNU assembler and linker.

[libvirt] [PATCH] maint: regenerate bootstrap

2012-07-27 Thread Eric Blake
Commit 3ad13c92a7 blindly touched all files to have a 3-line hint for getting LGPL, but bootstrap is synced from gnulib where it has a 2-line hint. * bootstrap: Resync from gnulib. --- Pushing under the trivial rule. bootstrap | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [libvirt] [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command

2012-07-27 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 14:37, Anthony Liguori aligu...@us.ibm.com wrote: This command attempts to map to the behavior of -cpu ?. Unfortunately, the output of this command differs wildly across targets. I've never really understood why so much of the

Re: [libvirt] [PATCH] shutting down guest vms on host shutdown does not work

2012-07-27 Thread Eric Blake
On 07/27/2012 09:01 AM, Gerd v. Egidy wrote: Hi, I originally postet this into the Fedora bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=843836 but was asked by Eric to post it here for review. Thanks. Currently gracefully shutting down guest vms on host shutdown does not work

Re: [libvirt] [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 14:37, Anthony Liguori aligu...@us.ibm.com wrote: --- a/compiler.h +++ b/compiler.h @@ -45,6 +45,7 @@ # define GCC_ATTR __attribute__((__unused__, format(gnu_printf, 1, 2))) # define GCC_FMT_ATTR(n, m)

Re: [libvirt] [PATCH 01/11] Process all pending I/O for a RPC client before checking EOF

2012-07-27 Thread Jiri Denemark
On Fri, Jul 27, 2012 at 13:33:06 +0100, Daniel P. Berrange wrote: On Thu, Jul 26, 2012 at 04:00:22PM +0200, Jiri Denemark wrote: On Tue, Jul 24, 2012 at 14:22:43 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com In the socket event handler for the RPC

Re: [libvirt] [Qemu-devel] [PATCH 2/7] qapi: mark QOM commands stable

2012-07-27 Thread Luiz Capitulino
On Fri, 27 Jul 2012 08:37:14 -0500 Anthony Liguori aligu...@us.ibm.com wrote: We've had a cycle to tweak. It is time to commit to supporting them. qmp_qom_get() and qpm_qom_set() still use the legacy monitor interface, can't we convert it to the qapi? Signed-off-by: Anthony Liguori

Re: [libvirt] [Qemu-devel] [PATCH 1/7] qmp: introduce device-list-properties command

2012-07-27 Thread Luiz Capitulino
On Fri, 27 Jul 2012 08:37:13 -0500 Anthony Liguori aligu...@us.ibm.com wrote: This can be used in conjunction with qom-list-types to determine the supported set of devices and their parameters. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- qapi-schema.json | 28

Re: [libvirt] [Qemu-devel] [PATCH 3/7] qapi: add query-machines command

2012-07-27 Thread Luiz Capitulino
On Fri, 27 Jul 2012 08:37:15 -0500 Anthony Liguori aligu...@us.ibm.com wrote: This provides the same output as -M ? but in a structured way. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- qapi-schema.json | 28 qmp-commands.hx |6 ++ vl.c

Re: [libvirt] [Qemu-devel] [PATCH 5/7] qapi: add query-cpudefs command

2012-07-27 Thread Luiz Capitulino
On Fri, 27 Jul 2012 08:37:17 -0500 Anthony Liguori aligu...@us.ibm.com wrote: This command attempts to map to the behavior of -cpu ?. Unfortunately, the output of this command differs wildly across targets. To accomodate this, we use a weak symbol to implement a default version of the

Re: [libvirt] [PATCH v3 4/5] Update remote driver to support the connection close callbacks

2012-07-27 Thread Jiri Denemark
On Fri, Jul 27, 2012 at 11:39:55 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Update the remote driver to use the virNetClient close callback to trigger the virConnectPtr close callbacks Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need to parse -help output

2012-07-27 Thread Luiz Capitulino
On Fri, 27 Jul 2012 08:37:12 -0500 Anthony Liguori aligu...@us.ibm.com wrote: This series implements the necessary commands to implements danpb's idea to remove -help parsing in libvirt. We would introduce all of these commands in 1.2 and then change the -help output starting in 1.3. I've

Re: [libvirt] [PATCH] security: Skip labeling resources when seclabel defaults to none

2012-07-27 Thread Daniel P. Berrange
On Wed, Jul 25, 2012 at 03:30:28PM +0200, Jiri Denemark wrote: If a domain is explicitly configured with seclabel type=none/ we correctly ensure that no labeling will be done by setting norelabel=true. However, if no seclabel element is present in domain XML and hypervisor is configured not to

Re: [libvirt] [Patch v2 3/3] apparmor: QEMU bridge helper policy updates

2012-07-27 Thread rmarwah
Quoting Corey Bryant cor...@linux.vnet.ibm.com: On 07/26/2012 10:30 AM, rmar...@linux.vnet.ibm.com wrote: Quoting Jamie Strandboge ja...@canonical.com: On Mon, 2012-07-09 at 10:22 -0400, rmar...@linux.vnet.ibm.com wrote: Quoting Jamie Strandboge ja...@canonical.com: On Tue, 2012-07-03

Re: [libvirt] [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need to parse -help output

2012-07-27 Thread Daniel P. Berrange
On Fri, Jul 27, 2012 at 01:21:01PM -0300, Luiz Capitulino wrote: On Fri, 27 Jul 2012 08:37:12 -0500 Anthony Liguori aligu...@us.ibm.com wrote: This series implements the necessary commands to implements danpb's idea to remove -help parsing in libvirt. We would introduce all of these

Re: [libvirt] [PATCH 07/11 v2] Move LXC monitor code out into separate file

2012-07-27 Thread Jiri Denemark
On Fri, Jul 27, 2012 at 13:57:32 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Move the code that handles the LXC monitor out of the lxc_process.c file and into lxc_monitor.{c,h} Signed-off-by: Daniel P. Berrange berra...@redhat.com --- po/POTFILES.in

Re: [libvirt] [PATCH] security: Skip labeling resources when seclabel defaults to none

2012-07-27 Thread Jiri Denemark
On Fri, Jul 27, 2012 at 17:14:41 +0100, Daniel P. Berrange wrote: On Wed, Jul 25, 2012 at 03:30:28PM +0200, Jiri Denemark wrote: If a domain is explicitly configured with seclabel type=none/ we correctly ensure that no labeling will be done by setting norelabel=true. However, if no seclabel

Re: [libvirt] Support to transfer OVSDB:Interface stats during Live Migration

2012-07-27 Thread kiran Chunduri
Hi Laine, Thanks for the response. Please find my comments inline. regards Kiran On Thu, Jul 26, 2012 at 9:39 PM, Laine Stump la...@laine.org wrote: On 07/26/2012 09:40 PM, kiran Chunduri wrote: Hi, I was experimenting 'live migration' with libvirt (using virsh) and observed that post

Re: [libvirt] [PATCH] build: update to latest gnulib, for secure tarball

2012-07-27 Thread Eric Blake
On 07/26/2012 07:52 AM, Eric Blake wrote: On 07/26/2012 07:45 AM, Daniel P. Berrange wrote: On Fri, Jul 20, 2012 at 05:39:43PM -0600, Eric Blake wrote: Pick up some build fixes in the latest gnulib. In particular, we want to ensure that official tarballs are secure, but don't want to

Re: [libvirt] [PATCH 3/7] qapi: add query-machines command

2012-07-27 Thread Eric Blake
On 07/27/2012 07:37 AM, Anthony Liguori wrote: This provides the same output as -M ? but in a structured way. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- qapi-schema.json | 28 qmp-commands.hx |6 ++ vl.c | 31

Re: [libvirt] [PATCH 1/2] ESX: Add routines to interface driver

2012-07-27 Thread Ata E Husain
-Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Laine Stump Sent: Monday, July 23, 2012 12:43 PM To: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH 1/2] ESX: Add routines to interface driver On 07/20/2012 05:20 PM,

Re: [libvirt] [Qemu-devel] [PATCH 3/7] qapi: add query-machines command

2012-07-27 Thread Anthony Liguori
Eric Blake ebl...@redhat.com writes: On 07/27/2012 07:37 AM, Anthony Liguori wrote: This provides the same output as -M ? but in a structured way. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- qapi-schema.json | 28 qmp-commands.hx |6 ++

Re: [libvirt] [Qemu-devel] [PATCH 3/7] qapi: add query-machines command

2012-07-27 Thread Eric Blake
On 07/27/2012 12:12 PM, Anthony Liguori wrote: Eric Blake ebl...@redhat.com writes: +# @name: the name of the machine +# +# @alias: #optional an alias for the machine name Can a machine have more than one alias? No, it can't. Really, alias is only used to map 'pc' - 'pc-1.1'. It's

Re: [libvirt] [PATCH 5/7] qapi: add query-cpudefs command

2012-07-27 Thread Eric Blake
On 07/27/2012 07:37 AM, Anthony Liguori wrote: This command attempts to map to the behavior of -cpu ?. Unfortunately, the output of this command differs wildly across targets. To accomodate this, we use a weak symbol to implement a default version of the s/accomodate/accommodate/ command

Re: [libvirt] [PATCH] build: update to latest gnulib, for secure tarball

2012-07-27 Thread Eric Blake
On 07/27/2012 11:18 AM, Eric Blake wrote: On 07/26/2012 07:52 AM, Eric Blake wrote: On 07/26/2012 07:45 AM, Daniel P. Berrange wrote: On Fri, Jul 20, 2012 at 05:39:43PM -0600, Eric Blake wrote: Pick up some build fixes in the latest gnulib. In particular, we want to ensure that official

Re: [libvirt] [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Blue Swirl
On Fri, Jul 27, 2012 at 3:31 PM, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 15:27, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: The GCC manual says Weak symbols are supported for ELF

Re: [libvirt] Question about pci-passthrough

2012-07-27 Thread Laine Stump
On 07/26/2012 11:53 AM, Shradha Shah wrote: Hello All, I had a question about pci-passthrough using hostdev mode in Libvirt. When I assign hostdev-parent.type = VIR_DOMAIN_DEVICE_NET, the hostdev is passed into the guest and acts as a network device. Actually, aside from libvirt setting

Re: [libvirt] [Patch v2 3/3] apparmor: QEMU bridge helper policy updates

2012-07-27 Thread Laine Stump
On 07/26/2012 11:54 PM, Corey Bryant wrote: On 07/26/2012 10:30 AM, rmar...@linux.vnet.ibm.com wrote: Quoting Jamie Strandboge ja...@canonical.com: On Mon, 2012-07-09 at 10:22 -0400, rmar...@linux.vnet.ibm.com wrote: Quoting Jamie Strandboge ja...@canonical.com: On Tue, 2012-07-03 at 12:05

Re: [libvirt] Support to transfer OVSDB:Interface stats during Live Migration

2012-07-27 Thread Laine Stump
On 07/27/2012 01:00 PM, kiran Chunduri wrote: Hi Laine, Thanks for the response. Please find my comments inline. regards Kiran On Thu, Jul 26, 2012 at 9:39 PM, Laine Stump la...@laine.org mailto:la...@laine.org wrote: On 07/26/2012 09:40 PM, kiran Chunduri wrote: Hi, I was

Re: [libvirt] [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Anthony Liguori
Blue Swirl blauwir...@gmail.com writes: On Fri, Jul 27, 2012 at 3:31 PM, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 15:27, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: The GCC manual

Re: [libvirt] [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Blue Swirl
On Fri, Jul 27, 2012 at 8:51 PM, Anthony Liguori aligu...@us.ibm.com wrote: Blue Swirl blauwir...@gmail.com writes: On Fri, Jul 27, 2012 at 3:31 PM, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 15:27, Anthony Liguori

[libvirt] KVM Forum 2012 Call For Participation

2012-07-27 Thread KVM Forum 2012 Program Committee
= KVM Forum 2012: Call For Participation November 7-9, 2012 - Hotel Fira Palace - Barcelona, Spain (All submissions must be received before midnight Aug 31st, 2012) =