Re: [libvirt] [PATCH] qemu: Avoid libvirtd crash in qemuDomainObjExitAgentInternal

2012-08-07 Thread Alex Jia
On 08/07/2012 07:34 PM, Daniel P. Berrange wrote: On Tue, Aug 07, 2012 at 03:18:38PM +0800, Alex Jia wrote: * src/qemu/qemu_domain.c (qemuDomainObjExitAgentInternal): fix crashing libvirtd due to derefing a NULL pointer. For details, please see bug: RHBZ: https://bugzilla.redhat.com/show_bug

Re: [libvirt] [PATCH 07/17] Add qemuProcessSetHypervisorAffinites and set hypervisor threads affinities

2012-08-07 Thread Hu Tao
On Mon, Aug 06, 2012 at 05:09:04PM -0600, Eric Blake wrote: > On 08/03/2012 12:36 AM, Hu Tao wrote: > > From: Tang Chen > > > > Hypervisor threads should also be pinned by sched_setaffinity(), just > > the same as vcpu threads. > > Indeed, this fallback makes sense when cpuset cgroup is not pres

Re: [libvirt] PF interface brought down if guest using a VF in hostdev mode under 802.1Qbh

2012-08-07 Thread Laine Stump
On 08/07/2012 01:53 PM, Nishank Trivedi (nistrive) wrote: > Hi, > > In 802.1Qbh case where exists a SR-IOV capable network device, if any of > the virtual functions of this device is used in hostdev mode for the > guest, port-profile disassociate will also cause physical function > interface to go

Re: [libvirt] [PATCH 00/17] Supports for hypervisor-pin and hypervisor-bandwidth

2012-08-07 Thread Hu Tao
On Tue, Aug 07, 2012 at 06:35:32PM +0100, Daniel P. Berrange wrote: > On Tue, Aug 07, 2012 at 10:13:19AM -0600, Eric Blake wrote: > > On 08/07/2012 09:47 AM, Daniel P. Berrange wrote: > > > On Fri, Aug 03, 2012 at 02:36:02PM +0800, Hu Tao wrote: > > >> This series is a merge of > > >> > > >> 1) "

Re: [libvirt] [PATCH v2] storage: support all file permissions

2012-08-07 Thread Laine Stump
On 08/07/2012 10:40 AM, Dave Allan wrote: > On Tue, Aug 07, 2012 at 10:27:15AM +0200, Ján Tomko wrote: >> On 08/07/12 07:17, Laine Stump wrote: >>> On 07/26/2012 04:52 AM, Ján Tomko wrote: sticky, setuid and setgid are no longer ignored. >>> I'm always automatically wary of any code that allow

Re: [libvirt] [PATCH 05/17] Support hypervisorpin xml parse.

2012-08-07 Thread Hu Tao
On Mon, Aug 06, 2012 at 04:51:49PM -0600, Eric Blake wrote: > On 08/03/2012 12:36 AM, Hu Tao wrote: > > From: Tang Chen > > > > This patch adds a new xml element , > > I would mention that this is a sibling to the existing element > under the . > > > and also the parser functions, docs, and te

Re: [libvirt] [PATCH 04/17] Enable cpuset cgroup and synchronous vcpupin info to cgroup.

2012-08-07 Thread Hu Tao
On Mon, Aug 06, 2012 at 03:41:29PM -0600, Eric Blake wrote: > On 08/03/2012 12:36 AM, Hu Tao wrote: > > From: Tang Chen > > > > vcpu threads pin are implemented using sched_setaffinity(), but > > not controlled by cgroup. This patch does the following things: > > > > 1) enable cpuset cgroup

Re: [libvirt] [PATCH 02/17] Introduce the function virCgroupMoveTask

2012-08-07 Thread Hu Tao
On Mon, Aug 06, 2012 at 03:09:51PM -0600, Eric Blake wrote: > On 08/03/2012 12:36 AM, Hu Tao wrote: > > From: Wen Congyang > > > > Introduce a new API to move tasks of one controller from a cgroup to > > another cgroup > > > > Signed-off-by: Wen Congyang > > Signed-off-by: Tang Chen > > Signe

[libvirt] [PATCH 4/5] Add virDomainQemuAgentCommand() support function to python module

2012-08-07 Thread MATSUDA, Daiki
Add virDomainQemuAgentCommand() support function to python module. generator.py |1 + libvirt-qemu-override-api.xml |8 libvirt-qemu-override.c | 31 +++ 3 files changed, 40 insertions(+) diff --git a/python/generator.py b

[libvirt] [PATCH 0/5] support guest agent general command

2012-08-07 Thread MATSUDA, Daiki
Hi, All. I rewrote the patches as Eric suggested. virsh # help qemu-agent-command NAME qemu-agent-command - Qemu Guest Agent Command SYNOPSIS qemu-agent-command [--timeout ] {[--cmd] }... DESCRIPTION Qemu Guest Agent Command OPTIONS [--domain] domain name, id or uu

[libvirt] [PATCH 1/5] add timeout seconds to qemuAgentSend()

2012-08-07 Thread MATSUDA, Daiki
Add @seconds valuable to qemuAgentSend(). It points timeout seconds on @timeout true. If @seconds is 0 on @timeout true, use default timeout value (QEMU_AGENT_WAIT_TIME). If @timeout is false, @seconds is meanless. qemu_agent.c | 21 - 1 file changed, 12 ins

[libvirt] [PATCH 5/5] Add qemu-agent-command command to virsh

2012-08-07 Thread MATSUDA, Daiki
Add qemu-agent-command command to virsh to support virDomainQemuAgentCommand(). virsh-host.c | 70 +++ 1 file changed, 70 insertions(+) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index d9d09b4..b9180f3 100644 --- a/tools/vi

[libvirt] [PATCH 3/5] add virDomainQemuAgentCommand() to qemu driver and remote driver

2012-08-07 Thread MATSUDA, Daiki
Add virDomainQemuAgentCommand() to qemu driver and remote driver to support qemuAgentCommand(). daemon/remote.c| 35 include/libvirt/libvirt-qemu.h |3 + src/driver.h |6 +++ src/libvirt-qemu.c | 58 +++

[libvirt] [PATCH 2/5] add qemuAgentCommand()

2012-08-07 Thread MATSUDA, Daiki
Add qemuAgentCommand() for general qemu agent command. include/libvirt/libvirt-qemu.h |5 + src/qemu/qemu_agent.c | 38 ++ src/qemu/qemu_agent.h |5 + 3 files changed, 48 insertions(+) diff --git a/include/libvirt/libvir

Re: [libvirt] [PATCH 2/3] qemu: add two qemu caps for lsi and virtio-scsi SCSI controllers

2012-08-07 Thread Eric Blake
On 08/07/2012 03:55 PM, Eric Blake wrote: > On 08/07/2012 11:21 AM, Guannan Ren wrote: >> Rename qemuDefaultScsiControllerModel to qemuCheckScsiControllerModel. >> When scsi model is given explicitly in XML(model > 0) checking if the >> underlying QEMU supports it or not first, raise an error on ch

Re: [libvirt] [PATCH 1/3] qemu: add capabilities flags related to scsi controller

2012-08-07 Thread Eric Blake
On 08/07/2012 03:46 PM, Eric Blake wrote: > On 08/07/2012 11:21 AM, Guannan Ren wrote: >> QEMU_CAPS_SCSI_LSI >> set the flag when "lsi53c895a", bus PCI, alias "lsi" in >> the output of "qemu -device ?" >> -device lsi in qemu command line >> >> QEMU_CAPS_VIRIO_SCSI_PCI >> set the

Re: [libvirt] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-07 Thread Eric Blake
On 08/07/2012 11:07 AM, Corey Bryant wrote: >>> +# >>> +# Since: 1.2.0 >> >> We're not very consistent on '1.2' vs. '1.2.0' in since listings, but >> that's probably worth a global cleanup closer to hard freeze. >> > > I'll make a note of it. Or does Luiz usually do a cleanup? No idea. >>> +##

Re: [libvirt] [PATCH 2/3] qemu: add two qemu caps for lsi and virtio-scsi SCSI controllers

2012-08-07 Thread Eric Blake
On 08/07/2012 11:21 AM, Guannan Ren wrote: > Rename qemuDefaultScsiControllerModel to qemuCheckScsiControllerModel. > When scsi model is given explicitly in XML(model > 0) checking if the > underlying QEMU supports it or not first, raise an error on checking > failure. > When the model is not given

Re: [libvirt] [PATCH 3/3] test: add lsi and virtio-scsi qemu caps in testcases.

2012-08-07 Thread Eric Blake
On 08/07/2012 11:21 AM, Guannan Ren wrote: > --- > tests/qemuhelptest.c | 10 +++--- > tests/qemuxml2argvtest.c | 16 ++-- > 2 files changed, 17 insertions(+), 9 deletions(-) > > @@ -755,7 +757,9 @@ mymain(void) > QEMU_CAPS_NO_USER_CONFIG, > QEMU_

Re: [libvirt] [PATCH 1/3] qemu: add capabilities flags related to scsi controller

2012-08-07 Thread Eric Blake
On 08/07/2012 11:21 AM, Guannan Ren wrote: > QEMU_CAPS_SCSI_LSI > set the flag when "lsi53c895a", bus PCI, alias "lsi" in > the output of "qemu -device ?" > -device lsi in qemu command line > > QEMU_CAPS_VIRIO_SCSI_PCI > set the flag when "name "virtio-scsi-pci", bus PCI" in >

Re: [libvirt] [PATCH 17/17] update doc about hypervisor_period/hypervisor_quota

2012-08-07 Thread Eric Blake
On 08/03/2012 12:36 AM, Hu Tao wrote: > --- > tools/virsh.pod | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/tools/virsh.pod b/tools/virsh.pod > index ffc0777..92cb897 100644 > --- a/tools/virsh.pod > +++ b/tools/virsh.pod > @@ -1202,7 +1202,8 @@ available

Re: [libvirt] [Qemu-devel] [PATCH v6 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-07 Thread Corey Bryant
On 08/07/2012 02:16 PM, Stefan Hajnoczi wrote: On Fri, Aug 3, 2012 at 6:28 PM, Corey Bryant wrote: diff --git a/monitor.c b/monitor.c index 49dccfe..9aa9f7e 100644 --- a/monitor.c +++ b/monitor.c @@ -140,6 +140,24 @@ struct mon_fd_t { QLIST_ENTRY(mon_fd_t) next; }; +/* file descripto

Re: [libvirt] [PATCH v5] ESX: Add routines to interface driver

2012-08-07 Thread Matthias Bolte
2012/8/7 Laine Stump : > On 08/06/2012 03:18 PM, Ata Bohra wrote: >> But re-thinking the whole design in light of the explanation provided by >> you, libvirt interfaces are actually mapping physical interfaces to virtual >> network. Further, hostVirtualSwitch behaves like switch which defines ports

Re: [libvirt] [PATCH v5] ESX: Add routines to interface driver

2012-08-07 Thread Matthias Bolte
2012/8/6 Ata Bohra : > (Please ignore earlier messages, as for reason the messages got truncated) > > Thanks Matthias for the explanation, I was working on the project which > required libvirt to control/set networking on a given ESX host. As ESXi is > different from hosted hypervisors, we need to

[libvirt] sending openvswitch "port db" info during libvirt migration

2012-08-07 Thread Laine Stump
Someone asked on IRC the other day about sending openvswitch per-port data (normally stored in the switch) to the destination host during a migration. I suggested maybe this could be handled by encoding the information into the interface's prior to migration, and then writing it back out to openvs

Re: [libvirt] [PATCH 16/17] qemu: Implement hypervisor_period and hypervisor_quota's modification

2012-08-07 Thread Eric Blake
On 08/03/2012 12:36 AM, Hu Tao wrote: > From: Wen Congyang > > allow the user change/get hypervisor's period and quota when the vm is > running. > --- > include/libvirt/libvirt.h.in | 16 + > src/qemu/qemu_driver.c | 133 > +- > 2 files chan

Re: [libvirt] [Qemu-devel] [PATCH v6 3/6] monitor: Clean up fd sets on monitor disconnect

2012-08-07 Thread Corey Bryant
On 08/07/2012 01:32 PM, Stefan Hajnoczi wrote: On Fri, Aug 03, 2012 at 01:28:06PM -0400, Corey Bryant wrote: Each fd set has a boolean that keeps track of whether or not the fd set is in use by a monitor connection. When a monitor disconnects, all fds that are members of an fd set with refcou

Re: [libvirt] [PATCH] util: include stderr in log message when an external command fails

2012-08-07 Thread Laine Stump
On 08/07/2012 07:38 AM, Daniel P. Berrange wrote: > On Mon, Aug 06, 2012 at 08:07:32PM -0400, Laine Stump wrote: >> This patch is in response to: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=818467 >> >> If a caller to virCommandRun doesn't ask for the exitstatus of the >> program it's runni

Re: [libvirt] [PATCH 15/17] qemu: Implement hypervisor's period and quota tunable XML configuration and parsing

2012-08-07 Thread Eric Blake
On 08/03/2012 12:36 AM, Hu Tao wrote: > From: Wen Congyang subject is long. I'd suggest: qemu: introduce period/quota tuning for emulator -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signat

Re: [libvirt] [PATCH 14/17] Update XML Schema for new entries

2012-08-07 Thread Eric Blake
On 08/03/2012 12:36 AM, Hu Tao wrote: > From: Wen Congyang > > --- > docs/schemas/domaincommon.rng | 10 ++ > 1 file changed, 10 insertions(+) Missing counterpart documentation in docs/formatdomain.html.in, and a corresponding test case somewhere in tests. I would consider squashing

Re: [libvirt] [PATCH 13/17] limit cpu bandwidth only for vcpus

2012-08-07 Thread Eric Blake
On 08/03/2012 12:36 AM, Hu Tao wrote: > This patch changes the behaviour of xml element cputune.period > and cputune.quota to limit cpu bandwidth only for vcpus, and no > longer limit cpu bandwidth for the whole guest. > > The reasons to do this are: > > - This matches docs of cputune.period an

[libvirt] [PATCH v7 3/6] monitor: Clean up fd sets on monitor disconnect

2012-08-07 Thread Corey Bryant
Fd sets are shared by all monitor connections. Fd sets are considered to be in use while at least one monitor is connected. When the last monitor disconnects, all fds that are members of an fd set with refcount of zero are closed. This prevents any fd leakage associated with a client disconnect

Re: [libvirt] [Qemu-devel] [PATCH v6 3/6] monitor: Clean up fd sets on monitor disconnect

2012-08-07 Thread Stefan Hajnoczi
On Fri, Aug 03, 2012 at 01:28:06PM -0400, Corey Bryant wrote: > Each fd set has a boolean that keeps track of whether or not the > fd set is in use by a monitor connection. When a monitor > disconnects, all fds that are members of an fd set with refcount > of zero are closed. This prevents any fd

Re: [libvirt] [Qemu-devel] [PATCH v6 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-07 Thread Stefan Hajnoczi
On Fri, Aug 3, 2012 at 6:28 PM, Corey Bryant wrote: > diff --git a/monitor.c b/monitor.c > index 49dccfe..9aa9f7e 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -140,6 +140,24 @@ struct mon_fd_t { > QLIST_ENTRY(mon_fd_t) next; > }; > > +/* file descriptor associated with a file descriptor s

[libvirt] [ANNOUNCE] libvirt-glib 0.1.1 release

2012-08-07 Thread Zeeshan Ali (Khattak)
I am pleased to announce that a new release of the libvirt-glib package, version 0.1.1 is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key fingerprint: DE11 B48B FDC1 6349 4312 0860 FCAC ABEE 62D1 1E4C (2048R) New in this release: - Add bindings fo

Re: [libvirt] [PATCH 12/17] Improve vcpupin to support hypervisorpin dynamically.

2012-08-07 Thread Eric Blake
On 08/03/2012 12:36 AM, Hu Tao wrote: > From: Tang Chen > > Modify vcpupin command to support hypervisor threads pin. > 1) add "--hypervisor" option to get hypervisor threads info. > 2) add "--hypervisor cpuset" to set hypervisor threads to specified > cpuset. Dan's comment of s/hypervi

[libvirt] PF interface brought down if guest using a VF in hostdev mode under 802.1Qbh

2012-08-07 Thread Nishank Trivedi (nistrive)
Hi, In 802.1Qbh case where exists a SR-IOV capable network device, if any of the virtual functions of this device is used in hostdev mode for the guest, port-profile disassociate will also cause physical function interface to go down. This appears to be a bug, but wanted to find if this was done i

Re: [libvirt] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-07 Thread Corey Bryant
On 08/07/2012 12:49 PM, Eric Blake wrote: On 08/07/2012 09:58 AM, Corey Bryant wrote: This patch adds support that enables passing of file descriptors to the QEMU monitor where they will be stored in specified file descriptor sets. A file descriptor set can be used by a client like libvirt to

Re: [libvirt] [PATCH 00/17] Supports for hypervisor-pin and hypervisor-bandwidth

2012-08-07 Thread Daniel P. Berrange
On Tue, Aug 07, 2012 at 10:13:19AM -0600, Eric Blake wrote: > On 08/07/2012 09:47 AM, Daniel P. Berrange wrote: > > On Fri, Aug 03, 2012 at 02:36:02PM +0800, Hu Tao wrote: > >> This series is a merge of > >> > >> 1) "Support hypervisor-threads-pin in vcpupin" > >> (https://www.redhat.com/arc

[libvirt] [PATCH 0/3 v2] Add lsi and virtio-scsi qemu caps

2012-08-07 Thread Guannan Ren
Add two capabilities flags for the model of scsi controller LSI and virtio-scsi. Use the lsilogic model by default, if current QEMU supports doesn't it, raise an error. When scsi model is given in XML explicitly, we try to check if the underlying QEMU supports it or not, raise an error on checking

[libvirt] [PATCH 2/3] qemu: add two qemu caps for lsi and virtio-scsi SCSI controllers

2012-08-07 Thread Guannan Ren
Rename qemuDefaultScsiControllerModel to qemuCheckScsiControllerModel. When scsi model is given explicitly in XML(model > 0) checking if the underlying QEMU supports it or not first, raise an error on checking failure. When the model is not given(mode <= 0), return LSI by default, if the QEMU doesn

[libvirt] [PATCH 1/3] qemu: add capabilities flags related to scsi controller

2012-08-07 Thread Guannan Ren
QEMU_CAPS_SCSI_LSI set the flag when "lsi53c895a", bus PCI, alias "lsi" in the output of "qemu -device ?" -device lsi in qemu command line QEMU_CAPS_VIRIO_SCSI_PCI set the flag when "name "virtio-scsi-pci", bus PCI" in the output of qemu devices query. -device virtio-sc

[libvirt] [PATCH 3/3] test: add lsi and virtio-scsi qemu caps in testcases.

2012-08-07 Thread Guannan Ren
--- tests/qemuhelptest.c | 10 +++--- tests/qemuxml2argvtest.c | 16 ++-- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index 75c818c..28d742e 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -482,

Re: [libvirt] [PATCH 11/17] Introduce remoteDomainPinHypervisorFlags and remoteDomainGetHypervisorPinInfo functions in remote driver.

2012-08-07 Thread Eric Blake
On 08/03/2012 12:36 AM, Hu Tao wrote: > From: Tang Chen Again, a long subject line. Given Dan's rename suggestion, I propose: remote: introduce emulator pinning RPCs > > static int > +remoteDispatchDomainPinHypervisorFlags(virNetServerPtr server > ATTRIBUTE_UNUSED, No need for the 'Flags'

Re: [libvirt] [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-08-07 Thread Corey Bryant
On 08/06/2012 10:15 AM, Corey Bryant wrote: On 08/06/2012 09:51 AM, Kevin Wolf wrote: Am 06.08.2012 15:32, schrieb Corey Bryant: On 08/06/2012 05:15 AM, Kevin Wolf wrote: Am 03.08.2012 00:21, schrieb Corey Bryant: @@ -84,6 +158,36 @@ int qemu_open(const char *name, int flags, ...)

Re: [libvirt] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-07 Thread Eric Blake
On 08/07/2012 09:58 AM, Corey Bryant wrote: > This patch adds support that enables passing of file descriptors > to the QEMU monitor where they will be stored in specified file > descriptor sets. > > A file descriptor set can be used by a client like libvirt to > store file descriptors for the sam

[libvirt] [PATCH v7 0/6] file descriptor passing using fd sets

2012-08-07 Thread Corey Bryant
libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other words, sVirt uses SELinux to prevent a QEMU process from opening files that do not belong to it. sVirt provides this support by labeling guests and resources with

[libvirt] [PATCH v7 5/6] block: Convert close calls to qemu_close

2012-08-07 Thread Corey Bryant
This patch converts all block layer close calls, that correspond to qemu_open calls, to qemu_close. Signed-off-by: Corey Bryant --- v5: -This patch is new in v5. (kw...@redhat.com, ebl...@redhat.com) v6-v7: -No changes block/raw-posix.c | 24 block/raw-win32.c |

[libvirt] [PATCH v7 1/6] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg

2012-08-07 Thread Corey Bryant
Set the close-on-exec flag for the file descriptor received via SCM_RIGHTS. Signed-off-by: Corey Bryant --- v4 -This patch is new in v4 (ebl...@redhat.com) v5 -Fallback to FD_CLOEXEC if MSG_CMSG_CLOEXEC is not available (ebl...@redhat.com, stefa...@linux.vnet.ibm.com) v6 -Set cloexec on co

Re: [libvirt] [PATCH 00/17] Supports for hypervisor-pin and hypervisor-bandwidth

2012-08-07 Thread Eric Blake
On 08/07/2012 09:47 AM, Daniel P. Berrange wrote: > On Fri, Aug 03, 2012 at 02:36:02PM +0800, Hu Tao wrote: >> This series is a merge of >> >> 1) "Support hypervisor-threads-pin in vcpupin" >> (https://www.redhat.com/archives/libvir-list/2012-July/msg01361.html) >> 2) "support to set cpu b

[libvirt] [PATCH v7 6/6] block: Enable qemu_open/close to work with fd sets

2012-08-07 Thread Corey Bryant
When qemu_open is passed a filename of the "/dev/fdset/nnn" format (where nnn is the fdset ID), an fd with matching access mode flags will be searched for within the specified monitor fd set. If the fd is found, a dup of the fd will be returned from qemu_open. Each fd set has a reference count.

[libvirt] [PATCH] Add support for firewalld (new version)

2012-08-07 Thread Thomas Woerner
* bridge_driver, nwfilter_driver: new dbus filters to get FirewallD1.Reloaded signal and DBus.NameOwnerChanged on org.fedoraproject.FirewallD1 * iptables, ebtables, nwfilter_ebiptables_driver: use firewall-cmd direct passthrough interface * spec file changed as requested --- configure.ac

[libvirt] [PATCH v7 4/6] block: Convert open calls to qemu_open

2012-08-07 Thread Corey Bryant
This patch converts all block layer open calls to qemu_open. Note that this adds the O_CLOEXEC flag to the changed open paths when the O_CLOEXEC macro is defined. Signed-off-by: Corey Bryant --- v2: -Convert calls to qemu_open instead of file_open (kw...@redhat.com) -Mention introduction of O_

[libvirt] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-07 Thread Corey Bryant
This patch adds support that enables passing of file descriptors to the QEMU monitor where they will be stored in specified file descriptor sets. A file descriptor set can be used by a client like libvirt to store file descriptors for the same file. This allows the client to open a file with diff

Re: [libvirt] [PATCH 09/17] Introduce virDomainPinHypervisorFlags and virDomainGetHypervisorPinInfo functions.

2012-08-07 Thread Daniel P. Berrange
On Mon, Aug 06, 2012 at 05:31:23PM -0600, Eric Blake wrote: > On 08/03/2012 12:36 AM, Hu Tao wrote: > > From: Tang Chen > > > > Introduce 2 APIs for client to use. > > 1) virDomainPinHypervisorFlags: call remote driver api, such as > > remoteDomainPinHypervisorFlags. > > 2) virDomainGetH

Re: [libvirt] [PATCH 00/17] Supports for hypervisor-pin and hypervisor-bandwidth

2012-08-07 Thread Daniel P. Berrange
On Fri, Aug 03, 2012 at 02:36:02PM +0800, Hu Tao wrote: > This series is a merge of > > 1) "Support hypervisor-threads-pin in vcpupin" > (https://www.redhat.com/archives/libvir-list/2012-July/msg01361.html) > 2) "support to set cpu bandwidth for hypervisor threads" > (https://www.red

Re: [libvirt] [PATCH v2] storage: support all file permissions

2012-08-07 Thread Dave Allan
On Tue, Aug 07, 2012 at 10:27:15AM +0200, Ján Tomko wrote: > On 08/07/12 07:17, Laine Stump wrote: > > On 07/26/2012 04:52 AM, Ján Tomko wrote: > >> sticky, setuid and setgid are no longer ignored. > > > > I'm always automatically wary of any code that allows setting the suid > > bit, in case it m

Re: [libvirt] [PATCH] Set LIBVIRT_AUTOSTART=0 when running test suites

2012-08-07 Thread Eric Blake
On 08/07/2012 05:03 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Occassionally some test cases will (accidentally) try to spawn s/Occassionally/Occasionally/ > libvirtd. Set the LIBVIRT_AUTOSTART=0 environment variable to > ensure the remote driver never tries autostart. > ---

Re: [libvirt] [PATCH] Don't check the 'connect' command in virsh-all test

2012-08-07 Thread Eric Blake
On 08/07/2012 05:03 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The 'virsh-all' test case will invoke each virsh command with > no args. With the 'connect' command this causes virsh to try > to connect to the default URI, which in turn tries to spawn > libvirtd. This is not som

Re: [libvirt] [PATCH V1] on special migration(domain defined, not started yet)

2012-08-07 Thread Eric Blake
On 08/07/2012 02:00 AM, liguang wrote: > Hi, Eric > what do you think of this kludged way of > off-line migration? > > 在 2012-08-02四的 17:02 +0800,liguang写道: >> >> From: liguang >> >> a roughly way for offline-migrate (domain defined, >> not started yet), now can do like this: >> migrate --hard-mi

Re: [libvirt] [test-API][PATCH 1/2] Reconnct libvirt after libvirtd restart

2012-08-07 Thread Guannan Ren
On 08/06/2012 03:46 PM, Wayne Sun wrote: In domain_nfs_start case, libvirtd will be restarted during test, which broke existing connection. User need re-init connection in test case, for this: * Using sharedmod data dictionary to store Envparser class in generator. * Do

Re: [libvirt] [test-API][PATCH 2/2] Replace env.conf with global.conf in env_parser

2012-08-07 Thread Guannan Ren
On 08/06/2012 03:46 PM, Wayne Sun wrote: Only update the expection info when parsing. Signed-off-by: Wayne Sun --- src/env_parser.py | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/env_parser.py b/src/env_parser.py index f02af57..ddda727

Re: [libvirt] [test-API][PATCH] Delete the unused util param

2012-08-07 Thread Guannan Ren
On 08/07/2012 07:31 PM, Wayne Sun wrote: The util is undefined and cause case run fail, it's with no use and should be deleted. Signed-off-by: Wayne Sun --- repos/interface/create.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/repos/interface/create.py b

[libvirt] Memory Ballooning for VM Issue

2012-08-07 Thread xuanmao_001
Hi, I have some problems with qemu ballooning. I saw the qemu docs. I found the qemu monitor command "balloon" that can request VM to change its memory allocation to value(in MB). it requested qemu command line with "-balloon virtio", then I start qemu into monitor mode with memory 512MB. first

Re: [libvirt] [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-07 Thread Markus Armbruster
ronnie sahlberg writes: > Since pretty much every cdrom drive use scsi today, shouldnt the > readonly/writeable flag for MMC devices rather > be done down in the hw/scsi* code rather than the generic block code? There are two separate things that can be read-only: device models and BlockDriverS

Re: [libvirt] [PATCH 0/2] Add lsi and virtio-scsi qemu caps

2012-08-07 Thread Guannan Ren
On 08/07/2012 07:37 PM, Daniel P. Berrange wrote: On Tue, Aug 07, 2012 at 02:54:33PM +0800, Guannan Ren wrote: On qemu-kvm-0.15.1, it supports only lsi scsi controller model. On qemu-kvm-0.12.1.2, it supports only virtio-scsi-pci scsi model This doesn't make sense. virtio-scsi did not exist un

Re: [libvirt] [PATCH] util: include stderr in log message when an external command fails

2012-08-07 Thread Daniel P. Berrange
On Mon, Aug 06, 2012 at 08:07:32PM -0400, Laine Stump wrote: > This patch is in response to: > > https://bugzilla.redhat.com/show_bug.cgi?id=818467 > > If a caller to virCommandRun doesn't ask for the exitstatus of the > program it's running, the virCommand functions assume that they should > l

Re: [libvirt] [PATCH 0/2] Add lsi and virtio-scsi qemu caps

2012-08-07 Thread Daniel P. Berrange
On Tue, Aug 07, 2012 at 02:54:33PM +0800, Guannan Ren wrote: > > On qemu-kvm-0.15.1, it supports only lsi scsi controller model. > On qemu-kvm-0.12.1.2, it supports only virtio-scsi-pci scsi model This doesn't make sense. virtio-scsi did not exist until long after qemu-kvm-0.12.1.2. > On qemu 1

[libvirt] [test-API][PATCH] Delete the unused util param

2012-08-07 Thread Wayne Sun
The util is undefined and cause case run fail, it's with no use and should be deleted. Signed-off-by: Wayne Sun --- repos/interface/create.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/repos/interface/create.py b/repos/interface/create.py index 50d92d2..f5ef3

Re: [libvirt] [PATCH] qemu: Avoid libvirtd crash in qemuDomainObjExitAgentInternal

2012-08-07 Thread Daniel P. Berrange
On Tue, Aug 07, 2012 at 03:18:38PM +0800, Alex Jia wrote: > * src/qemu/qemu_domain.c (qemuDomainObjExitAgentInternal): fix crashing > libvirtd due to derefing a NULL pointer. > > For details, please see bug: > RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=845966 > > Signed-off-by: Alex Jia

Re: [libvirt] [PATCH v3 10/10] Turn virNetClient* into virObject instances

2012-08-07 Thread Daniel P. Berrange
On Mon, Aug 06, 2012 at 01:56:33PM -0600, Eric Blake wrote: > On 08/06/2012 05:53 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Make all the virNetClient* objects use virObject APIs for > > reference counting > > > > Signed-off-by: Daniel P. Berrange > > --- > > src/libv

Re: [libvirt] [PATCH] Add APIs for obtaining the unique ID of LVM & SCSI volumes

2012-08-07 Thread Daniel P. Berrange
On Mon, Aug 06, 2012 at 02:16:39PM -0600, Eric Blake wrote: > On 08/02/2012 07:09 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Both LVM volumes and SCSI LUNs have a globally unique > > identifier associated with them. It is useful to be able > > to query this identifier to

Re: [libvirt] [PATCH] Add APIs for obtaining the unique ID of LVM & SCSI volumes

2012-08-07 Thread Daniel P. Berrange
On Fri, Aug 03, 2012 at 04:03:55PM +0100, Daniel P. Berrange wrote: > On Thu, Aug 02, 2012 at 11:32:14PM -0500, Doug Goldstein wrote: > > On Thu, Aug 2, 2012 at 8:09 AM, Daniel P. Berrange > > wrote: > > > From: "Daniel P. Berrange" > > > > > > Both LVM volumes and SCSI LUNs have a globally uniq

[libvirt] [PATCH] Set LIBVIRT_AUTOSTART=0 when running test suites

2012-08-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Occassionally some test cases will (accidentally) try to spawn libvirtd. Set the LIBVIRT_AUTOSTART=0 environment variable to ensure the remote driver never tries autostart. --- tests/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b

[libvirt] [PATCH] Don't check the 'connect' command in virsh-all test

2012-08-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The 'virsh-all' test case will invoke each virsh command with no args. With the 'connect' command this causes virsh to try to connect to the default URI, which in turn tries to spawn libvirtd. This is not something we want todo in the test suite, so skip the 'connect' c

Re: [libvirt] [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-07 Thread ronnie sahlberg
Since pretty much every cdrom drive use scsi today, shouldnt the readonly/writeable flag for MMC devices rather be done down in the hw/scsi* code rather than the generic block code? If/when/ever I get enough time I would like to port the writeable dvd+r emulation I wrote for STGT to qemu. In ST

Re: [libvirt] [PATCH] block: Set cdrom device read only flag

2012-08-07 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.08.2012 09:20, schrieb Kevin Shanahan: >> On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote: >>> On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote: On Thu, Aug 02, 2012 at 11:02:42AM +0930, Kevin Shanahan wrote: > Set the block driver

Re: [libvirt] [PATCH v2] storage: support all file permissions

2012-08-07 Thread Ján Tomko
On 08/07/12 07:17, Laine Stump wrote: > On 07/26/2012 04:52 AM, Ján Tomko wrote: >> sticky, setuid and setgid are no longer ignored. > > I'm always automatically wary of any code that allows setting the suid > bit, in case it may allow some new security hole. I can't think of > anything specific t

Re: [libvirt] [PATCH V1] on special migration(domain defined, not started yet)

2012-08-07 Thread liguang
Hi, Eric what do you think of this kludged way of off-line migration? 在 2012-08-02四的 17:02 +0800,liguang写道: > > From: liguang > > a roughly way for offline-migrate (domain defined, > not started yet), now can do like this: > migrate --hard-migrate --xml dom.xml dom qemu+ssh://target/system > >

Re: [libvirt] [PATCH 03/48] list: Define new API virStorageListALlStoragePools

2012-08-07 Thread Guido Günther
On Fri, Aug 03, 2012 at 11:48:06PM +0800, Osier Yang wrote: > This introduces a new API to list the storage pool objects, > 4 groups of flags are provided to filter the returned pools: Typo on the subject: capital all in virStorageListALlStoragePools ^ Cheers, --

[libvirt] [PATCH] qemu: Avoid libvirtd crash in qemuDomainObjExitAgentInternal

2012-08-07 Thread Alex Jia
* src/qemu/qemu_domain.c (qemuDomainObjExitAgentInternal): fix crashing libvirtd due to derefing a NULL pointer. For details, please see bug: RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=845966 Signed-off-by: Alex Jia --- src/qemu/qemu_domain.c | 10 ++ 1 files changed, 6 inser

Re: [libvirt] [PATCH 03/17] create a new cgroup and move all hypervisor threads to the new cgroup

2012-08-07 Thread Hu Tao
On Mon, Aug 06, 2012 at 03:18:07PM -0600, Eric Blake wrote: > On 08/03/2012 12:36 AM, Hu Tao wrote: > > From: Wen Congyang > > > > Create a new cgroup and move all hypervisor threads to the new cgroup. > > And then we can do the other things: > > 1. limit only vcpu usage rather than the whole qem