Re: [libvirt] libvirtd crash when attach-disk to VM

2012-08-18 Thread Peter Krempa
On 08/16/12 11:15, Wangpan wrote: Hi all, I got a depressed problem(libvirtd crash with SIGABRT or SIGSEGV sometimes) when attach a nbd disk to a VM by using cmd as follow: virsh attach-disk 228 --source /dev/nbd0 --target vdd --sourcetype block --driver qemu --subdriver raw or just using

[libvirt] [PATCH] esx: Support VLAN tags in virtual network port groups

2012-08-18 Thread Matthias Bolte
--- src/esx/esx_network_driver.c | 38 +- 1 files changed, 33 insertions(+), 5 deletions(-) diff --git a/src/esx/esx_network_driver.c b/src/esx/esx_network_driver.c index 09d46d3..2f5f1ab 100644 --- a/src/esx/esx_network_driver.c +++

Re: [libvirt] [PATCH 4/4] virsh: kill some double underscores

2012-08-18 Thread Eric Blake
On 08/17/2012 11:38 PM, Laine Stump wrote: On 08/18/2012 12:38 AM, Eric Blake wrote: Use of __foo naming is against C99. Besides, we had several different styles in use; this consolidates things to set up the typedefs up front then declare the types. * tools/virsh.h: Use consistent struct

[libvirt] [PATCH] virsh: fix syntax check

2012-08-18 Thread Eric Blake
Oops, I pushed patches without doing syntax checks along the way. * cfg.mk (exclude_file_name_regexp--sc_avoid_strcase): Track file split. * tools/virsh-domain.h (VIRSH_DOMAIN_H): Fix indentation. * tools/virsh.h (VIRSH_H): Likewise. --- Pushing under the build-breaker rule. cfg.mk

Re: [libvirt] [PATCH] Add support for setting VLANs on Open vSwitch ports

2012-08-18 Thread Kyle Mestery (kmestery)
On Aug 17, 2012, at 1:18 PM, Laine Stump wrote: On 08/17/2012 12:04 AM, Kyle Mestery wrote: Add the ability to support VLAN tags for Open vSwitch virtual port types. To accomplish this, modify virNetDevOpenvswitchAddPort and virNetDevTapCreateInBridgePort to take a virNetDevVlanPtr argument.

[libvirt] [PATCH 6/4] virsh: use coming namespacing

2012-08-18 Thread Eric Blake
Convert the exported items in virsh.h to use a common 'vsh' prefix. * tools/virsh.h (VIRSH_MAX_XML_FILE, GETTIMEOFDAY): Rename... (VSH_MAX_XML_FILE): ...and parenthesize. (DIFF_MSEC, CTRL_CLOSE_BRACKET): Delete. (vshUsage, vshInit, vshDeinit, vshParseArgv): Remove prototype. (editWriteToTempFile,

Re: [libvirt] libvirtd crash when attach-disk to VM

2012-08-18 Thread Wangpan
Thanks Peter, I have verified this bug on libvirt-0.9.13 by compiling the source tarball, It's OK now! 2012-08-19 Wangpan You probably (looking at the version numbers) came across a known bug: https://bugzilla.redhat.com/show_bug.cgi?id=822068 0x745c5475 in raise () from