On 08/28/2012 11:38 AM, Alex Jia wrote:
From: Alex Jia Alex Jia a...@redhat.com
The default flags are inconsistent on both qemuSetSchedulerParameters()
and qemuGetSchedulerParameters() in libvirt, the qemuGetSchedulerParameters()
always passes 'VIR_DOMAIN_AFFECT_CURRENT' flag to the
On 08/28/2012 11:52 PM, Osier Yang wrote:
These APIs accept one more argument (flags), which was ignored in
the XS implementations.
---
Virt.xs | 46 ++
1 files changed, 26 insertions(+), 20 deletions(-)
diff --git a/Virt.xs b/Virt.xs
index
On Wed, Aug 29, 2012 at 01:29:37AM -0400, Alex Jia wrote:
ACK.
--
Regards,
Alex
- Original Message -
From: Osier Yang jy...@redhat.com
To: libvir-list@redhat.com
Sent: Tuesday, August 28, 2012 11:52:24 PM
Subject: [libvirt] [libvirt-perl PATCH] Fix several APIs
On 08/29/2012 12:01 AM, Osier Yang wrote:
To make sure the domain config is not broken after the API calls.
---
This depends on
https://www.redhat.com/archives/libvir-list/2012-August/msg01792.html
---
scripts/domain/202-numa-set-parameters.t | 99 ++
1 files
On Wed, Aug 29, 2012 at 01:26:54PM +0800, Daniel Veillard wrote:
As planned, I tagged the release this morning and pushed the builds
at the usual place:
ftp://libvirt.org/libvirt/
With this (also with 0.10.0rc2) kvm domains won't start giving:
$ virsh start foo
error: Failed to start
On 29.08.2012 09:15, Guido Günther wrote:
On Wed, Aug 29, 2012 at 01:26:54PM +0800, Daniel Veillard wrote:
As planned, I tagged the release this morning and pushed the builds
at the usual place:
ftp://libvirt.org/libvirt/
With this (also with 0.10.0rc2) kvm domains won't start giving:
On 08/29/2012 02:12 PM, Guannan Ren wrote:
On 08/28/2012 11:38 AM, Alex Jia wrote:
From: Alex Jia Alex Jia a...@redhat.com
The default flags are inconsistent on both qemuSetSchedulerParameters()
and qemuGetSchedulerParameters() in libvirt, the
qemuGetSchedulerParameters()
always passes
From: Alex Jia Alex Jia a...@redhat.com
The default flags are inconsistent on both qemuSetSchedulerParameters()
and qemuGetSchedulerParameters() in libvirt, the qemuGetSchedulerParameters()
always passes 'VIR_DOMAIN_AFFECT_CURRENT' flag to the
qemuGetSchedulerParametersFlags(),
it should be a
* src/security/security_dac.c: remove useless dead code.
Signed-off-by: Alex Jia a...@redhat.com
---
src/security/security_dac.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index 5de7391..211fb37 100644
---
On 08/29/12 12:01, Alex Jia wrote:
* src/security/security_dac.c: remove useless dead code.
Signed-off-by: Alex Jia a...@redhat.com
---
src/security/security_dac.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
Gah, I fixed the patch that made dead code from the break;
On 08/29/2012 06:23 PM, Peter Krempa wrote:
Gah, I fixed the patch that made dead code from the break; statement
on a different machine. ACK.
Got it :) push now.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
This bug was revealed by the crash described in
https://bugzilla.redhat.com/show_bug.cgi?id=852383
The vlan info pointer sent to virNetDevOpenvswitchAddPort should never
be non-NULL unless there is at least one tag. The factthat such a vlan
info pointer was receveid pointed out that a caller
On 08/28/2012 07:28 AM, Alex Jia wrote:
* src/util/virnetdevopenvswitch.c (virNetDevOpenvswitchAddPort): avoid
libvirtd
crash due to derefing a NULL virtVlan-tag.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=852383
Signed-off-by: Alex Jia a...@redhat.com
---
On 08/29/2012 06:45 PM, Laine Stump wrote:
On 08/28/2012 07:28 AM, Alex Jia wrote:
* src/util/virnetdevopenvswitch.c (virNetDevOpenvswitchAddPort): avoid libvirtd
crash due to derefing a NULL virtVlan-tag.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=852383
Signed-off-by: Alex
On 08/29/2012 06:43 PM, Laine Stump wrote:
This bug was revealed by the crash described in
https://bugzilla.redhat.com/show_bug.cgi?id=852383
The vlan info pointer sent to virNetDevOpenvswitchAddPort should never
be non-NULL unless there is at least one tag. The factthat such a vlan
info
This reverts commit 9f9b7b85c9b422e8f4e813f3920bf8f433246a4a.
The DAC security driver needs special handling and extra parameters and
can't just be added to regular security drivers.
---
src/security/security_driver.c | 2 --
1 file changed, 2 deletions(-)
diff --git
The security driver loading code in qemu has a flaw that causes it to
register the DAC security driver twice. This causes problems (machines
unable to start) as the two DAC drivers clash together.
This patch refactors the code to allow loading the DAC driver even if
its specified in configuration
The DAC driver was registered twice, breaking starting of machines if no
other security driver was used (basicaly on all non-selinux machines).
Peter Krempa (2):
Revert security: Add DAC to security_drivers
qemu: Refactor initialisation of security drivers.
src/qemu/qemu_driver.c |
If cgroups are enabled in general but cpu cgroup is disabled in
qemu.conf or not mounted at all, libvirt would refuse to start any
domain even though scheduler parameters are not set in domain XML.
This patch makes cpu cgroup mandatory only for domains that actually
want to use it.
---
On Wed, Aug 29, 2012 at 03:42:57PM +0200, Jiri Denemark wrote:
If cgroups are enabled in general but cpu cgroup is disabled in
qemu.conf or not mounted at all, libvirt would refuse to start any
domain even though scheduler parameters are not set in domain XML.
This patch makes cpu cgroup
On Wed, Aug 29, 2012 at 02:56:13PM +0200, Peter Krempa wrote:
The DAC driver was registered twice, breaking starting of machines if no
other security driver was used (basicaly on all non-selinux machines).
Peter Krempa (2):
Revert security: Add DAC to security_drivers
qemu: Refactor
On Wed, Aug 29, 2012 at 21:51:58 +0800, Daniel Veillard wrote:
On Wed, Aug 29, 2012 at 03:42:57PM +0200, Jiri Denemark wrote:
If cgroups are enabled in general but cpu cgroup is disabled in
qemu.conf or not mounted at all, libvirt would refuse to start any
domain even though scheduler
On 08/29/12 16:02, Daniel Veillard wrote:
On Wed, Aug 29, 2012 at 02:56:13PM +0200, Peter Krempa wrote:
The DAC driver was registered twice, breaking starting of machines if no
other security driver was used (basicaly on all non-selinux machines).
Peter Krempa (2):
Revert security: Add DAC
On Aug 29, 2012, at 6:19 AM, Alex Jia wrote:
On 08/29/2012 06:43 PM, Laine Stump wrote:
This bug was revealed by the crash described in
https://bugzilla.redhat.com/show_bug.cgi?id=852383
The vlan info pointer sent to virNetDevOpenvswitchAddPort should never
be non-NULL unless there is
I was a bit afraid of the .0 effect on release name, but we really
have a number of problem with 0.10.0 that ought to be fixed in a
brown paper bag release. I would urge people to report and try to
fix the problem being raised in 0.10.0, let's try to get them fixed
today or tomorrow and I will
Introducing a new iolimits element allowing to override certain
properties of a guest block device like the physical and logical
block size.
This can be useful for platforms with 'non-standard' disk formats
like S390 DASD with its 4K block size.
Signed-off-by: Viktor Mihajlovski
Depending on the hypervisor (e.g. QEMU) it is possible to override
certain properties of a block device. In Linux these are called
IO limits and can be observed in the guest's sysfs under
/sys/block/dev/queue.
This patch set enables libvirt to override the logical and physical
block size for
Implementation of iolimits for the qemu driver with
capability probing for block size attribute and
command line generation for block sizes.
Including testcase for qemuxml2argvtest.
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
src/qemu/qemu_capabilities.c
It should be [] instead of ().
---
docs/schemas/nodedev.rng |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/schemas/nodedev.rng b/docs/schemas/nodedev.rng
index c07a97d..88a4e9d 100644
--- a/docs/schemas/nodedev.rng
+++ b/docs/schemas/nodedev.rng
@@ -247,7 +247,7 @@
* docs/formatdomain.html.in: Add document.
* docs/schemas/nodedev.rng: Move definition of wwn to ...
* docs/schemas/basictypes.rng: ...Here
* docs/schemas/domaincommon.rng: Add schema for disk wwn
---
docs/formatdomain.html.in |5 +
docs/schemas/basictypes.rng |6 ++
This introduces new element wwn for disk, to allow to set wwn
(just like setting serial number) for the virtual disk (Only QEMU
devices like ide-drive, ide-hd, ide-cd, scsi-disk, scsi-hd, and
scsi-cd support it).
Osier Yang (4):
schema: Add schema for disk wwn
conf: Parse and format disk wwn
* src/conf/domain_conf.h: New member 'wwn' for disk def.
* src/conf/domain_conf.c: Parse and format disk wwn
---
src/conf/domain_conf.c |8
src/conf/domain_conf.h |1 +
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
This assumes ide-drive.wwn, ide-hd.wwn, ide-cd.wwn were supported
at the same time, similar for scsi-disk.wwn, scsi-hd.wwn, and
scsi-cd.wwn. So only two new caps (QEMU_CAPS_IDE_DRIVE_WWN,
and QEMU_CAPS_SCSI_DISK_WWN) are introduced.
---
src/qemu/qemu_capabilities.c |4
As the next boot doesn't have to worry about the previous numa
params setting (there is no).
---
src/qemu/qemu_driver.c | 52 ---
1 files changed, 27 insertions(+), 25 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index
All of ide-drive, ide-hd, ide-cd, scsi-disk, scsi-hd, and scsi-cd
supports wwn property. (NB, scsi-block doesn't support to set wwn).
* src/qemu/qemu_command.c: Error out if underlying QEMU doesn't
support wwn property for the device; Set wwn for the device otherwise.
*
On 08/29/2012 09:28 AM, Osier Yang wrote:
It should be [] instead of ().
---
docs/schemas/nodedev.rng |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
ACK.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
On Wed, Aug 29, 2012 at 05:48:30PM +0200, Viktor Mihajlovski wrote:
Introducing a new iolimits element allowing to override certain
properties of a guest block device like the physical and logical
block size.
This can be useful for platforms with 'non-standard' disk formats
like S390 DASD
Hello All,
I have a question regarding the domain XML and its conversion to
hypervisor specific config files.
I am using libvirt to talk to vmware ESX. ESX has a feature where you
can add a line such as:
guestinfo.xxx=abc
in the .vmx file that describes the VM. Later, the guest can
When building without driver modules, I've noticed that the legacy xen
driver no longer works. The attached patch fixes it, but I'm not sure
if this is the correct fix. I need to do some more testing with and
without modules, but wanted to raise this on the list for
comments/suggestions.
Fixup buffer usage when handling VLANs. Also fix the logic
used to determine if the virNetDevVlanPtr is valid or not.
Fixes crashes in the latest code when using Open vSwitch
virtualports.
Signed-off-by: Kyle Mestery kmest...@cisco.com
---
src/util/virnetdevopenvswitch.c | 26
On Wed, Aug 29, 2012 at 10:19 AM, Daniel Veillard veill...@redhat.com wrote:
I was a bit afraid of the .0 effect on release name, but we really
have a number of problem with 0.10.0 that ought to be fixed in a
brown paper bag release. I would urge people to report and try to
fix the problem
On Aug 29, 2012, at 9:49 AM, Kyle Mestery (kmestery) wrote:
On Aug 29, 2012, at 6:19 AM, Alex Jia wrote:
On 08/29/2012 06:43 PM, Laine Stump wrote:
This bug was revealed by the crash described in
https://bugzilla.redhat.com/show_bug.cgi?id=852383
The vlan info pointer sent to
On Wed, Aug 29, 2012 at 11:24:08AM +0200, Michal Privoznik wrote:
On 29.08.2012 09:15, Guido Günther wrote:
On Wed, Aug 29, 2012 at 01:26:54PM +0800, Daniel Veillard wrote:
As planned, I tagged the release this morning and pushed the builds
at the usual place:
Can you send me foo's XML? I can't reproduce this error and I'd like to
check it.
There's a good chance that the last two Peter's patches fix that:
commit eb8e9b6027512edf2c93343f430e7e6429af0ff5
Author: Peter Krempa pkre...@redhat.com
Date: Wed Aug 29 14:19:39 2012 +0200
qemu: Refactor
Jim Fehlig wrote:
When building without driver modules, I've noticed that the legacy xen
driver no longer works. The attached patch fixes it, but I'm not sure
if this is the correct fix.
Sorry, I should have elaborated here. I don't think this is the correct
fix because now libvirt.so has a
On Wed, Aug 29, 2012 at 12:21:18PM -0600, Jim Fehlig wrote:
When building without driver modules, I've noticed that the legacy xen
driver no longer works. The attached patch fixes it, but I'm not sure
if this is the correct fix. I need to do some more testing with and
without modules, but
On Wed, Aug 29, 2012 at 03:59:17PM -0600, Jim Fehlig wrote:
Jim Fehlig wrote:
When building without driver modules, I've noticed that the legacy xen
driver no longer works. The attached patch fixes it, but I'm not sure
if this is the correct fix.
Sorry, I should have elaborated here. I
From: Daniel P. Berrange berra...@redhat.com
If no 'security_driver' config option was set, then the code
just loaded the 'dac' security driver. This is a regression
on previous behaviour, where we would probe for a possible
security driver. ie default to SELinux if available.
This changes
Hi, Harsh:
I've try your patch, but can't boot the vm.
[root@yinyin qemu-glusterfs]# virsh create gluster-libvirt.xml
错误：从 gluster-libvirt.xml 创建域失败
错误：Unable to read from monitor: Connection reset by peer
the libvirt build the qemu/gluster command correctly, the qemu-kvm try to
run, but
On Wed, Aug 29, 2012 at 01:50:03PM -0500, Doug Goldstein wrote:
On Wed, Aug 29, 2012 at 10:19 AM, Daniel Veillard veill...@redhat.com wrote:
I was a bit afraid of the .0 effect on release name, but we really
have a number of problem with 0.10.0 that ought to be fixed in a
brown paper bag
Hi, Harsh:
I make some break in glusterd , and can gdb the qemu-kvm forked from
libvirtd.
break in glusterd:
(gdb) i b
Num Type Disp Enb AddressWhat
1 breakpoint keep y 0x7f903ef1a0a0 in server_getspec at
glusterd-handshake.c:122
2 breakpoint
What about renaming to
qemu: Sort the numa params only when it affects the live config
instead ?
On Thu, Aug 30, 2012 at 12:37:58AM +0800, Osier Yang wrote:
As the next boot doesn't have to worry about the previous numa
params setting (there is no).
there is no ??? i assume you mean it
On 08/30/2012 02:44 AM, Kyle Mestery wrote:
Fixup buffer usage when handling VLANs. Also fix the logic
used to determine if the virNetDevVlanPtr is valid or not.
Fixes crashes in the latest code when using Open vSwitch
virtualports.
Hi Kyle,
I just waive my patch then apply Laine and your
On Thu, Aug 30, 2012 at 01:37:01AM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If no 'security_driver' config option was set, then the code
just loaded the 'dac' security driver. This is a regression
on previous behaviour, where we would probe for a possible
On 2012年08月30日 11:22, Daniel Veillard wrote:
What about renaming to
qemu: Sort the numa params only when it affects the live config
instead ?
Better. :-)
On Thu, Aug 30, 2012 at 12:37:58AM +0800, Osier Yang wrote:
As the next boot doesn't have to worry about the previous numa
params
On 2012年08月30日 11:22, Daniel Veillard wrote:
What about renaming to
qemu: Sort the numa params only when it affects the live config
instead ?
On Thu, Aug 30, 2012 at 12:37:58AM +0800, Osier Yang wrote:
As the next boot doesn't have to worry about the previous numa
params setting (there
On 08/30/2012 08:27 AM, Yin Yin wrote:
Hi, Harsh:
I make some break in glusterd , and can gdb the qemu-kvm forked from
libvirtd.
break in glusterd:
(gdb) i b
Num Type Disp Enb Address What
1 breakpoint keep y 0x7f903ef1a0a0 in server_getspec at
glusterd-handshake.c:122
2 breakpoint
On 08/30/2012 08:27 AM, Yin Yin wrote:
Hi, Harsh:
I make some break in glusterd , and can gdb the qemu-kvm forked from
libvirtd.
break in glusterd:
(gdb) i b
Num Type Disp Enb AddressWhat
1 breakpoint keep y 0x7f903ef1a0a0 in server_getspec
On 08/29/2012 11:44 AM, Kyle Mestery wrote:
Fixup buffer usage when handling VLANs. Also fix the logic
used to determine if the virNetDevVlanPtr is valid or not.
Fixes crashes in the latest code when using Open vSwitch
virtualports.
Signed-off-by: Kyle Mestery kmest...@cisco.com
---
It's
On 08/29/2012 08:45 PM, Alex Jia wrote:
On 08/30/2012 02:44 AM, Kyle Mestery wrote:
Fixup buffer usage when handling VLANs. Also fix the logic
used to determine if the virNetDevVlanPtr is valid or not.
Fixes crashes in the latest code when using Open vSwitch
virtualports.
Hi Kyle,
I just
On 08/29/2012 05:37 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If no 'security_driver' config option was set, then the code
just loaded the 'dac' security driver. This is a regression
on previous behaviour, where we would probe for a possible
security driver.
On 08/29/2012 10:32 PM, Eric Blake wrote:
On 08/29/2012 11:44 AM, Kyle Mestery wrote:
Fixup buffer usage when handling VLANs. Also fix the logic
used to determine if the virNetDevVlanPtr is valid or not.
Fixes crashes in the latest code when using Open vSwitch
virtualports.
Signed-off-by:
On Wed, Aug 29, 2012 at 10:35:30PM -0700, Eric Blake wrote:
On 08/29/2012 05:37 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
If no 'security_driver' config option was set, then the code
just loaded the 'dac' security driver. This is a regression
on
On Wed, Aug 29, 2012 at 02:44:36PM -0400, Kyle Mestery wrote:
Fixup buffer usage when handling VLANs. Also fix the logic
used to determine if the virNetDevVlanPtr is valid or not.
Fixes crashes in the latest code when using Open vSwitch
virtualports.
Signed-off-by: Kyle Mestery
64 matches
Mail list logo
