[libvirt] [PATCH 4/5] list: Use virConnectListAllInterfaces in virsh

2012-09-04 Thread Osier Yang
tools/virsh-interface.c: * vshInterfaceSorter to sort interfaces by name * vshInterfaceListFree to free the interface objects list. * vshInterfaceListCollect to collect the interface objects, trying to use new API first, fall back to older APIs if it's not supported. ---

[libvirt] [PATCH 1/5] list: Define new API virConnectListAllInterfaces

2012-09-04 Thread Osier Yang
This is to list the interface objects, supported filtering flags are: active|inactive. include/libvirt/libvirt.h.in: Declare enum virConnectListAllInterfaceFlags and virConnectListAllInterfaces. python/generator.py: Skip auto-generating src/driver.h:

Re: [libvirt] [PATCH] Include some extra headers needed for OpenBSD.

2012-09-04 Thread Jasper Lievisse Adriaanse
On Tue, Sep 04, 2012 at 09:18:20AM -0600, Eric Blake wrote: On 09/04/2012 08:57 AM, Jasper Lievisse Adriaanse wrote: From bafcb4ed2b90b5ba845ca6b61861e3caa548b16a Mon Sep 17 00:00:00 2001 From: Jasper Lievisse Adriaanse jas...@humppa.nl Date: Tue, 4 Sep 2012 16:57:09 +0200 Subject: [PATCH]

Re: [libvirt] [PATCH] Use sockpeercred on OpenBSD.

2012-09-04 Thread Jasper Lievisse Adriaanse
On Tue, Sep 04, 2012 at 09:22:56AM -0600, Eric Blake wrote: On 09/04/2012 09:00 AM, Jasper Lievisse Adriaanse wrote: From 0f352c0577f76a64924636a8c9ba72de5862b6d6 Mon Sep 17 00:00:00 2001 From: Jasper Lievisse Adriaanse jas...@humppa.nl Date: Tue, 4 Sep 2012 16:59:55 +0200 Subject: [PATCH]

Re: [libvirt] [PATCH] Rename iolimit to blockio.

2012-09-04 Thread Viktor Mihajlovski
On 09/04/2012 04:56 PM, Eric Blake wrote: This hunk will invalidate any running domains that were started with libvirt.git after the original patch but prior to applying this patch; but since that is unreleased code, I think anyone affected will be reading this list, so I'm not worried about it.

Re: [libvirt] [PATCH] Pass a correct pointer type to localtime_r(3).

2012-09-04 Thread Jasper Lievisse Adriaanse
On Tue, Sep 04, 2012 at 09:20:24AM -0600, Eric Blake wrote: [adding bug-gnulib] On 09/04/2012 08:49 AM, Jasper Lievisse Adriaanse wrote: From b53dc971cc50b5ac397e4568449d25041477c8d6 Mon Sep 17 00:00:00 2001 From: Jasper Lievisse Adriaanse jas...@humppa.nl Date: Tue, 4 Sep 2012 16:47:26

Re: [libvirt] [PATCH] Pass a correct pointer type to localtime_r(3).

2012-09-04 Thread Eric Blake
On 09/04/2012 10:32 AM, Jasper Lievisse Adriaanse wrote: On Tue, Sep 04, 2012 at 09:20:24AM -0600, Eric Blake wrote: [adding bug-gnulib] NACK from the libvirt point of view. tv_sec is required by POSIX to be of type time_t; so this is a bug in the OpenBSD header, and gnulib should be

Re: [libvirt] [PATCH] Include some extra headers needed for OpenBSD.

2012-09-04 Thread Eric Blake
On 09/04/2012 10:23 AM, Jasper Lievisse Adriaanse wrote: On Tue, Sep 04, 2012 at 09:18:20AM -0600, Eric Blake wrote: On 09/04/2012 08:57 AM, Jasper Lievisse Adriaanse wrote: From bafcb4ed2b90b5ba845ca6b61861e3caa548b16a Mon Sep 17 00:00:00 2001 From: Jasper Lievisse Adriaanse jas...@humppa.nl

Re: [libvirt] [PATCH] Include some extra headers needed for OpenBSD.

2012-09-04 Thread Jasper Lievisse Adriaanse
On Tue, Sep 04, 2012 at 10:45:41AM -0600, Eric Blake wrote: On 09/04/2012 10:23 AM, Jasper Lievisse Adriaanse wrote: On Tue, Sep 04, 2012 at 09:18:20AM -0600, Eric Blake wrote: On 09/04/2012 08:57 AM, Jasper Lievisse Adriaanse wrote: From bafcb4ed2b90b5ba845ca6b61861e3caa548b16a Mon Sep 17

Re: [libvirt] [PATCH] Don't link with -lrt on OpenBSD

2012-09-04 Thread Eric Blake
On 09/04/2012 09:26 AM, Eric Blake wrote: On 09/04/2012 09:04 AM, Jasper Lievisse Adriaanse wrote: From bdf3bce37531ec346474bc5c4f37a5d2985d1d35 Mon Sep 17 00:00:00 2001 From: Jasper Lievisse Adriaanse jas...@humppa.nl Date: Tue, 4 Sep 2012 17:03:43 +0200 Subject: [PATCH] Don't link with -lrt

Re: [libvirt] [PATCH] Pass a correct pointer type to localtime_r(3).

2012-09-04 Thread Paul Eggert
On 09/04/2012 08:20 AM, Eric Blake wrote: tv_sec is required by POSIX to be of type time_t; so this is a bug in the OpenBSD header Most likely this problem arose because of the patch I pushed in gnulib commit e07d7c40f3ca5ec410cf5aa6fa03cfe51e712039. Previously, gnulib required timeval's tv_sec

[libvirt] broken OpenBSD net/if.h [was: [PATCH] Include some extra headers needed for OpenBSD.]

2012-09-04 Thread Eric Blake
[adding gnulib] On 09/04/2012 10:52 AM, Jasper Lievisse Adriaanse wrote: I'd still like to know the compiler error you got when sys/socket.h was not present, but just guessing from the source code, I see one call of socket() (protected behind #if defined(HAVE_NET_IF_H) defined(SIOCBRADDBR),

[libvirt] [PATCH] build: require netcf-0.2.2 when installing on Fedora18+

2012-09-04 Thread Laine Stump
A previous patch forced libnl-3 and netcf-0.2.2 (which itself requires libnl-3) when *building* for Fedora 18+ (and RHEL 7+), but the install-time Requires: for netcf has always been implicit due to libvirtd linking with libnetcf.so. However, the since the API of netcf didn't change when it was

Re: [libvirt] [PATCH] build: require netcf-0.2.2 when installing on Fedora18+

2012-09-04 Thread Eric Blake
On 09/04/2012 11:10 AM, Laine Stump wrote: A previous patch forced libnl-3 and netcf-0.2.2 (which itself requires libnl-3) when *building* for Fedora 18+ (and RHEL 7+), but the install-time Requires: for netcf has always been implicit due to libvirtd linking with libnetcf.so. However, the

Re: [libvirt] [PATCH] Don't link with -lrt on OpenBSD

2012-09-04 Thread Jasper Lievisse Adriaanse
On Tue, Sep 04, 2012 at 10:59:05AM -0600, Eric Blake wrote: On 09/04/2012 09:26 AM, Eric Blake wrote: On 09/04/2012 09:04 AM, Jasper Lievisse Adriaanse wrote: From bdf3bce37531ec346474bc5c4f37a5d2985d1d35 Mon Sep 17 00:00:00 2001 From: Jasper Lievisse Adriaanse jas...@humppa.nl Date: Tue,

Re: [libvirt] broken OpenBSD net/if.h [was: [PATCH] Include some extra headers needed for OpenBSD.]

2012-09-04 Thread Jasper Lievisse Adriaanse
On Tue, Sep 04, 2012 at 11:08:30AM -0600, Eric Blake wrote: [adding gnulib] On 09/04/2012 10:52 AM, Jasper Lievisse Adriaanse wrote: I'd still like to know the compiler error you got when sys/socket.h was not present, but just guessing from the source code, I see one call of socket()

Re: [libvirt] [PATCH] Don't link with -lrt on OpenBSD

2012-09-04 Thread Eric Blake
On 09/04/2012 11:20 AM, Jasper Lievisse Adriaanse wrote: In fact, gnulib already provides the LGPLv2+ clock-time module for clock_gettime and clock_settime, with an appropriate link library $(LIB_CLOCK_GETTIME) that is set to -lrt when necessary. Does this patch work for you? Yep, this seems

Re: [libvirt] [PATCH] Pass a correct pointer type to localtime_r(3).

2012-09-04 Thread Jasper Lievisse Adriaanse
On Tue, Sep 04, 2012 at 10:03:41AM -0700, Paul Eggert wrote: On 09/04/2012 08:20 AM, Eric Blake wrote: tv_sec is required by POSIX to be of type time_t; so this is a bug in the OpenBSD header Most likely this problem arose because of the patch I pushed in gnulib commit

Re: [libvirt] broken OpenBSD net/if.h [was: [PATCH] Include some extra headers needed for OpenBSD.]

2012-09-04 Thread Eric Blake
On 09/04/2012 11:23 AM, Jasper Lievisse Adriaanse wrote: On Tue, Sep 04, 2012 at 11:08:30AM -0600, Eric Blake wrote: [adding gnulib] Ouch. The POSIX definition of net/if.h doesn't include any interface that needs to use struct sockaddr. Which OpenBSD extension function is triggering this

[libvirt] patch for dnsmasq parameters is not complete

2012-09-04 Thread Gene Czarcinski
Although the patch with --domain xxx --local=/xxx/ for dnsmasq command line parameters is good as far as it goes, it is not complete. As it is, dnsmasq will no longer forward names in its name-domain, but it will forward reverse lookup (IP address) queries. I am going to need to look at the

[libvirt] [PATCH 1/1 V2] Migrate per-port data for Open vSwitch ports during Qemu Live Migration

2012-09-04 Thread Kyle Mestery
Add the ability to migrate per-port data on Open vSwitch ports during qemu live migration. A controller can use this to store data relating to each port, and have it migrated with the virtual machine and populated on the destination host. Signed-off-by: Kyle Mestery kmest...@cisco.com Cc: Laine

Re: [libvirt] [PATCH v2 0/4] Add cpu hotplug support to libvirt.

2012-09-04 Thread Srivatsa S. Bhat
On 09/04/2012 07:25 PM, Daniel P. Berrange wrote: On Tue, Sep 04, 2012 at 04:45:16PM +0800, Tang Chen wrote: It seems that libvirt is not cpu hotplug aware. Please refer to the following problem. 1. At first, we have 2 cpus. # cat /cgroup/cpuset/cpuset.cpus 0-1 # cat

Re: [libvirt] [PATCH] Fix adding ports to OVS bridges without VLAN tags

2012-09-04 Thread Kyle Mestery (kmestery)
On Aug 31, 2012, at 9:09 AM, Daniel Veillard wrote: On Fri, Aug 31, 2012 at 01:32:34PM +, Kyle Mestery (kmestery) wrote: On Aug 30, 2012, at 10:23 PM, Daniel Veillard wrote: On Thu, Aug 30, 2012 at 04:38:06PM -0400, Kyle Mestery wrote: [...] Still there is something which looks wrong, if

Re: [libvirt] [PATCH] Pass a correct pointer type to localtime_r(3).

2012-09-04 Thread Eric Blake
On 09/04/2012 11:03 AM, Paul Eggert wrote: For this particular case, though, how about if we avoid the problem entirely? libvirt doesn't need to use struct timeval here at all. I'd use the following (untested) patch: it makes libvirt smaller and probably faster, and it ports to OpenBSD

[libvirt] [PATCH] build: use re-entrant functions in virsh

2012-09-04 Thread Eric Blake
Today's patches pointed out that virsh was still using localtime(), which is not thread-safe, even though virsh is definitely multi-threaded. * cfg.mk (exclude_file_name_regexp--sc_prohibit_nonreentrant): Tighten the rule. * tools/virsh.c (vshOutputLogFile): Avoid localtime.

[libvirt] [PATCH] maint: avoid doubled name in syntax check failures

2012-09-04 Thread Eric Blake
Based on a similar gnulib patch; use of $(_sc_search_regexp) already injects $(ME) into any output messages, so a failure of these rules would look like this, pre-patch: ./config.status: ./config.status: use virStrToLong_*, not strtol variants * cfg.mk (sc_prohibit_strncmp, sc_prohibit_strtol)

Re: [libvirt] [PATCH 02/10] list: Add helpers for listing storage pool objects

2012-09-04 Thread Eric Blake
On 09/04/2012 09:16 AM, Osier Yang wrote: src/conf/storage_conf.c: Add virStoragePoolMatch to filter the pools; Add virStoragePoolList to iterate over the pool objects with filter. src/conf/storage_conf.h: Declare virStoragePoolMatch, virStoragePoolList, and the macros for filters.

Re: [libvirt] [PATCH 03/10] list: Implement the RPC calls for virConnectListAllStoragePools

2012-09-04 Thread Eric Blake
On 09/04/2012 09:16 AM, Osier Yang wrote: The RPC generator doesn't support returning list of object, this patch do s/patch do/patch does/ the work manually. @@ -5612,6 +5675,7 @@ static virStorageDriver storage_driver = { .listPools = remoteListStoragePools, /* 0.4.1 */

Re: [libvirt] [PATCH 04/10] list: Implement listAllStoragePools for storage driver

2012-09-04 Thread Eric Blake
On 09/04/2012 09:16 AM, Osier Yang wrote: src/storage/storage_driver.c: Implement listAllStoragePools. --- src/storage/storage_driver.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) @@ -2293,6 +2310,7 @@ static virStorageDriver storageDriver = {

Re: [libvirt] [PATCH 03/10] list: Implement the RPC calls for virConnectListAllStoragePools

2012-09-04 Thread Eric Blake
On 09/04/2012 05:48 PM, Eric Blake wrote: On 09/04/2012 09:16 AM, Osier Yang wrote: The RPC generator doesn't support returning list of object, this patch do s/patch do/patch does/ the work manually. @@ -5612,6 +5675,7 @@ static virStorageDriver storage_driver = { .listPools =

Re: [libvirt] [PATCH V4] implement offline migration

2012-09-04 Thread liguang
在 2012-09-04二的 12:12 +0100,Daniel P. Berrange写道: On Mon, Sep 03, 2012 at 02:23:24PM +0800, liguang wrote: allow migration even domain isn't active by inserting some stubs to tunnel migration path. Signed-off-by: liguang lig.f...@cn.fujitsu.com --- src/qemu/qemu_driver.c|2 +-

Re: [libvirt] [PATCH V4] implement offline migration

2012-09-04 Thread liguang
在 2012-09-05三的 08:51 +0800,liguang写道: 在 2012-09-04二的 12:12 +0100,Daniel P. Berrange写道: On Mon, Sep 03, 2012 at 02:23:24PM +0800, liguang wrote: allow migration even domain isn't active by inserting some stubs to tunnel migration path. Signed-off-by: liguang lig.f...@cn.fujitsu.com

Re: [libvirt] [PATCH 1/2] build: define WITH_INTERFACE for the driver

2012-09-04 Thread Daniel Veillard
On Sun, Sep 02, 2012 at 10:44:16PM -0500, Doug Goldstein wrote: Based exclusively on work by Eric Blake in a patch posted with the same subject. However some modifications related to comments and my plans to add another backend. Added WITH_INTERFACE as the only automake variable deciding

Re: [libvirt] [PATCH] conf: describe security_driver behavior

2012-09-04 Thread Martin Kletzander
On 09/04/2012 04:51 PM, Eric Blake wrote: On 09/04/2012 08:23 AM, Martin Kletzander wrote: As a request was raised for this, I added few lines in the Notes part of the security_driver comments about allowed values. --- The related bug for this patch is here:

Re: [libvirt] [PATCH] docs: correct dompmwakeup description

2012-09-04 Thread Martin Kletzander
On 09/04/2012 04:52 PM, Eric Blake wrote: On 09/04/2012 08:23 AM, Martin Kletzander wrote: The command 'dompmwakeup' can wakeup any pmsuspended domain, not only domains suspended previously by dompmsuspend and this patch fixed the man page and help string for that. --- tools/virsh-domain.c

Re: [libvirt] [PATCH] Fix adding ports to OVS bridges without VLAN tags

2012-09-04 Thread Daniel Veillard
On Tue, Sep 04, 2012 at 09:03:22PM +, Kyle Mestery (kmestery) wrote: On Aug 31, 2012, at 9:09 AM, Daniel Veillard wrote: On Fri, Aug 31, 2012 at 01:32:34PM +, Kyle Mestery (kmestery) wrote: On Aug 30, 2012, at 10:23 PM, Daniel Veillard wrote: On Thu, Aug 30, 2012 at 04:38:06PM

Re: [libvirt] [PATCH v2 0/4] Add cpu hotplug support to libvirt.

2012-09-04 Thread Tang Chen
Hi Srivatsa, Daniel, Thank you very much for all the comments. :) On 09/05/2012 04:57 AM, Srivatsa S. Bhat wrote: I had posted a Linux kernel patchset[1] some time ago to expose another file so that we can distinguish between the user specified settings vs the actual scenario underneath. But

[libvirt] [PATCH 2/7] list: Implemente RPC calls for virConnectListAllNodeDevices

2012-09-04 Thread Osier Yang
The RPC generator doesn't support returning list of object yet, this patch do the work manually. * daemon/remote.c: Implemente the server side handler remoteDispatchConnectListAllNodeDevices. * src/remote/remote_driver.c: Add remote driver handler remoteConnectListAllNodeDevices.

[libvirt] [PATCH 0/7 v4] Atomic API to list node devices

2012-09-04 Thread Osier Yang
v3 - v4: * Just rebase on the top, split the patches from v3's larget set. Osier Yang (7): list: Define new API virConnectListAllNodeDevices list: Implemente RPC calls for virConnectListAllNodeDevices list: Add helpers for listing node devices list: Implement listAllNodeDevices list:

[libvirt] [PATCH 3/7] list: Add helpers for listing node devices

2012-09-04 Thread Osier Yang
src/conf/node_device_conf.h: * New macro VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP * Declare virNodeDeviceList src/conf/node_device_conf.c: * New helpers virNodeDeviceCapMatch, virNodeDeviceMatch. virNodeDeviceCapMatch looks up the list of all the caps the device support, to see if

[libvirt] [PATCH 4/7] list: Implement listAllNodeDevices

2012-09-04 Thread Osier Yang
This simply implements listAllNodeDevices using helper virNodeDeviceList src/node_device/node_device_driver.h: * Declare nodeListAllNodeDevices. src/node_device/node_device_driver.c: * Implement nodeListAllNodeDevices. src/node_device/node_device_hal.c: * Hook listAllNodeDevices to

[libvirt] [PATCH 5/7] list: Expose virConnectListAllNodeDevices to Python binding

2012-09-04 Thread Osier Yang
The implementation is done manually as the generator does not support wrapping lists of C pointers into Python objects. python/libvirt-override-api.xml: Document python/libvirt-override-virConnect.py: * Implementation for listAllNodeDevices. python/libvirt-override.c: Implementation for the

[libvirt] [PATCH 6/7] virsh: Fix a bug of nodedev-list

2012-09-04 Thread Osier Yang
output of commands like '%virsh nodedev-list --tree --cap pci' could be empty. Remove the useless checking. --- tools/virsh-nodedev.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index e784af1..cd88538 100644 ---

[libvirt] [PATCH 7/7] list: Use virConnectListAllNodeDevices in virsh

2012-09-04 Thread Osier Yang
tools/virsh-nodedev.c: * vshNodeDeviceSorter to sort node devices by name * vshNodeDeviceListFree to free the node device objects list. * vshNodeDeviceListCollect to collect the node device objects, trying to use new API first, fall back to older APIs if it's not supported. * Change

[libvirt] [PATCH 1/7] list: Define new API virConnectListAllNodeDevices

2012-09-04 Thread Osier Yang
This is to list the node device objects, supports to filter the results by capability types. include/libvirt/libvirt.h.in: Declare enum virConnectListAllNodeDeviceFlags and virConnectListAllNodeDevices. python/generator.py: Skip auto-generating src/driver.h:

<    1   2