Re: [libvirt] [Qemu-devel] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-26 Thread Michal Privoznik
On 26.09.2012 22:46, Anthony Liguori wrote: > Michal Privoznik writes: > >> On 25.09.2012 19:08, Doug Goldstein wrote: >>> On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange >>> wrote: On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: > On 09/25/2012 06:54 AM, Daniel P. Berr

Re: [libvirt] [PATCH v3 14/20] Add a qemuMonitorGetObjectTypes() method for QMP qom-list-types command

2012-09-26 Thread Eric Blake
On 09/25/2012 12:00 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Add a new qemuMonitorGetObjectTypes() method to support invocation > of the 'qom-list' JSON monitor command. No HMP equivalent 'qom-list-types' > is required, since this will only be present for QEMU >= 1.2 > >

Re: [libvirt] [PATCH v9] support offline migration

2012-09-26 Thread li guang
ping ... 在 2012-09-25二的 15:45 +0800,liguang写道: > original migration did not aware of offline case, > so, try to support offline migration quietly > (did not disturb original migration) by pass > VIR_MIGRATE_OFFLINE flag to migration APIs if only > the domain is really inactive, and > migration pro

Re: [libvirt] [PATCH v3 13/20] Add a qemuMonitorGetEvents() method for QMP query-events command

2012-09-26 Thread Eric Blake
On 09/25/2012 12:00 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Add a new qemuMonitorGetEvents() method to support invocation > of the 'query-events' JSON monitor command. No HMP equivalent > is required, since this will only be used when JSON is available > > The existing qem

Re: [libvirt] [PATCH] Fix compilation of legacy xen driver with Xen 4.2

2012-09-26 Thread Eric Blake
On 09/26/2012 03:49 PM, Jim Fehlig wrote: > In Xen 4.2, xs.h is deprecated in favor of xenstore.h. xs.h now > contains > > #warning xs.h is deprecated use xenstore.h instead > #include > > which fails compilation when warnings are treated as errors. > > Introduce a configure-time check for xen

[libvirt] [PATCH] Fix compilation of legacy xen driver with Xen 4.2

2012-09-26 Thread Jim Fehlig
In Xen 4.2, xs.h is deprecated in favor of xenstore.h. xs.h now contains #warning xs.h is deprecated use xenstore.h instead #include which fails compilation when warnings are treated as errors. Introduce a configure-time check for xenstore.h and if found, use it instead of xs.h. --- configure

Re: [libvirt] [Qemu-devel] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-26 Thread Anthony Liguori
Michal Privoznik writes: > On 25.09.2012 19:08, Doug Goldstein wrote: >> On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange >> wrote: >>> On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: > On Tue, Sep 25, 2012 at 02:49:00PM

Re: [libvirt] [PATCH v3 12/20] Add a qemuMonitorGetCommands() method for QMP query-commands command

2012-09-26 Thread Eric Blake
On 09/25/2012 12:00 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Add a new qemuMonitorGetCPUCommands() method to support invocation > of the 'query-cpu-definitions' JSON monitor command. No HMP equivalent s/cpu-definitions/commands/ > is required, since this will only be used

[libvirt] [PATCH v3] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on "recent" kernels

2012-09-26 Thread Benjamin Cama
Hi, I hit this problem recently when trying to create a bridge with an IPv6 address on a 3.2 kernel: dnsmasq (and, further, radvd) would not bind to the given address, waiting 20s and then giving up with -EADDRNOTAVAIL (resp. exiting immediately with "error parsing or activating the config file",

Re: [libvirt] [PATCH] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on "recent" kernels

2012-09-26 Thread Benjamin Cama
Hi, Le vendredi 21 septembre 2012 à 16:28 -0400, Laine Stump a écrit : > On 09/21/2012 02:45 PM, Eric Blake wrote: > > From: Benjamin Cama > > > > Le mercredi 20 juin 2012 à 11:05 +0100, Daniel P. Berrange a écrit : > >> I think you also need to have a VIR_FOFRCE_CLOSE(tapfd) in the > >> very las

[libvirt] [PATCH 2/2] python: return error if PyObject obj is NULL for unwrapper helper functions

2012-09-26 Thread Guannan Ren
The result is indeterminate for NULL argument to python functions as follows. It's better to return negative value in these situations. PyObject_IsTrue will segfault if the argument is NULL PyFloat_AsDouble(NULL) is -1.00 PyLong_AsUnsignedLongLong(NULL) is 0.00 --- python/typewrappers.c |

[libvirt] [PATCH 1/2] python: cleanup vcpu related binding APIs

2012-09-26 Thread Guannan Ren
libvirt_virDomainGetVcpus: add error handling, return -1 instead of None libvirt_virDomainPinVcpu and libvirt_virDomainPinVcpuFlags: make use of libvirt_boolUnwrap Set bitmap according to these values which are contained in given argument of vcpu tuple and turn off these bit corresponding to

[libvirt] [PATCH v2 0/2] python: cleanup vcpu related binding APIs

2012-09-26 Thread Guannan Ren
The first version https://www.redhat.com/archives/libvir-list/2012-April/msg00848.html Sorry for so late. I will go on adding error handling and make it strong for python binding APIs if necessary Guannan Ren python: cleanup vcpu related binding APIs python: return error if PyObject obj is N

Re: [libvirt] [PATCH] Support Xen sysctl version 9 in Xen 4.2

2012-09-26 Thread Daniel P. Berrange
On Wed, Sep 26, 2012 at 11:05:52AM -0600, Jim Fehlig wrote: > Xen upstream c/s 24102:dc8e55c9 bumped the sysctl version to 9. > Support this sysctl version in the xen_hypervisor sub-driver. > --- > src/xen/xen_hypervisor.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/s

[libvirt] [PATCH] build: avoid older gcc warning

2012-09-26 Thread Eric Blake
Jim Fehlig reported a compilation error with older gcc 4.3.4: libvirt.c: In function 'virDomainGetEmulatorPinInfo': libvirt.c:9111: error: logical '&&' with non-zero constant will always evaluate as true [-Wlogical-op] It looks like someone programmed via too much copy-and-paste. * src/libvirt.

Re: [libvirt] [PATCH] Support Xen sysctl version 9 in Xen 4.2

2012-09-26 Thread Eric Blake
On 09/26/2012 11:05 AM, Jim Fehlig wrote: > Xen upstream c/s 24102:dc8e55c9 bumped the sysctl version to 9. > Support this sysctl version in the xen_hypervisor sub-driver. > --- > src/xen/xen_hypervisor.c | 12 > 1 file changed, 12 insertions(+) ACK. -- Eric Blake ebl...@redhat

[libvirt] [PATCH] Support Xen sysctl version 9 in Xen 4.2

2012-09-26 Thread Jim Fehlig
Xen upstream c/s 24102:dc8e55c9 bumped the sysctl version to 9. Support this sysctl version in the xen_hypervisor sub-driver. --- src/xen/xen_hypervisor.c | 12 1 file changed, 12 insertions(+) diff --git a/src/xen/xen_hypervisor.c b/src/xen/xen_hypervisor.c index fdc3071..3244bbd

Re: [libvirt] [PATCH] Move most of qemuProcessKill into virProcessKillPainfully

2012-09-26 Thread Eric Blake
On 09/26/2012 10:25 AM, Daniel P. Berrange wrote: > On Wed, Sep 26, 2012 at 10:07:42AM -0600, Eric Blake wrote: >>> +++ b/src/qemu/qemu_driver.c >>> @@ -2006,13 +2006,11 @@ qemuDomainDestroyFlags(virDomainPtr dom, >>> * it now means the job will be released >>> */ >>> if (flags & V

Re: [libvirt] [PATCH] Move most of qemuProcessKill into virProcessKillPainfully

2012-09-26 Thread Daniel P. Berrange
On Wed, Sep 26, 2012 at 10:07:42AM -0600, Eric Blake wrote: > > +++ b/src/qemu/qemu_driver.c > > @@ -2006,13 +2006,11 @@ qemuDomainDestroyFlags(virDomainPtr dom, > > * it now means the job will be released > > */ > > if (flags & VIR_DOMAIN_DESTROY_GRACEFUL) { > > -if (qemuP

Re: [libvirt] [PATCH] Move most of qemuProcessKill into virProcessKillPainfully

2012-09-26 Thread Eric Blake
On 09/26/2012 08:44 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > In the cgroups APIs we have a virCgroupKillPainfully function > which does the loop sending SIGTERM, then SIGKILL and waiting > for the process to exit. There is similar functionality for > simple processes in qemu

Re: [libvirt] [PATCH] Use size_t instead of int for virDomainDefPtr struct

2012-09-26 Thread Eric Blake
On 09/26/2012 09:13 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Many parts of virDomainDefPtr were using 'int' variables as > array length counts. Replace all these with size_t and update > various format strings & API signatures to adapt > --- > src/conf/domain_conf.c

Re: [libvirt] [PATCH] Don't skip over socket label cleanup

2012-09-26 Thread Eric Blake
On 09/26/2012 08:49 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > If QEMU quits immediately after we opened the monitor it was extra space before 'was' > possible we would skip the clearing of the SELinux process > socket context > > Signed-off-by: Daniel P. Berrange > --- >

Re: [libvirt] [PATCH] Fix potential deadlock when agent is closed

2012-09-26 Thread Eric Blake
On 09/26/2012 09:25 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > If the qemuAgentClose method is called from a place which holds > the domain lock, it is theoretically possible to get a deadlock > in the agent destroy callback. This has not ben observed, but s/ben/been/ > the

[libvirt] [PATCH] Fix potential deadlock when agent is closed

2012-09-26 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If the qemuAgentClose method is called from a place which holds the domain lock, it is theoretically possible to get a deadlock in the agent destroy callback. This has not ben observed, but the equivalent code in the QEMU monitor destroy callback has seen a deadlock. R

Re: [libvirt] [PATCH 2/4] parallels: fix memory allocation

2012-09-26 Thread Daniel P. Berrange
On Wed, Sep 26, 2012 at 09:00:06AM -0600, Eric Blake wrote: > On 09/26/2012 07:01 AM, Daniel P. Berrange wrote: > > On Wed, Sep 26, 2012 at 04:53:07PM +0400, Dmitry Guryanov wrote: > > >>> It is actually preferrable to use VIR_EXPAND_N here, eg > >>> > >>> if (VIR_EXPAND_N(def->videos, def->n

[libvirt] [PATCH] Use size_t instead of int for virDomainDefPtr struct

2012-09-26 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Many parts of virDomainDefPtr were using 'int' variables as array length counts. Replace all these with size_t and update various format strings & API signatures to adapt --- src/conf/domain_conf.c | 28 ++-- src/conf/domain_conf.h

Re: [libvirt] [PATCH 2/4] parallels: fix memory allocation

2012-09-26 Thread Eric Blake
On 09/26/2012 07:01 AM, Daniel P. Berrange wrote: > On Wed, Sep 26, 2012 at 04:53:07PM +0400, Dmitry Guryanov wrote: >>> It is actually preferrable to use VIR_EXPAND_N here, eg >>> >>> if (VIR_EXPAND_N(def->videos, def->nvideos, 1) < 0) >>> goto no_memory; >>> >>> def->videos[de

Re: [libvirt] [PATCH] Fix (rare) deadlock in QEMU monitor callbacks

2012-09-26 Thread Daniel P. Berrange
On Wed, Sep 26, 2012 at 03:56:52PM +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Some users report (very rarely) seeing a deadlock in the QEMU > monitor callbacks > > Thread 10 (Thread 0x7fcd11e20700 (LWP 26753)): > at util/threads-pthread.c:85 > at conf/domain_conf.c

[libvirt] [PATCH] Fix (rare) deadlock in QEMU monitor callbacks

2012-09-26 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Some users report (very rarely) seeing a deadlock in the QEMU monitor callbacks Thread 10 (Thread 0x7fcd11e20700 (LWP 26753)): at util/threads-pthread.c:85 at conf/domain_conf.c:14256 vm=0x7f00a850) at qemu/qemu_process.c:1026 at qemu/qemu_monitor.c

Re: [libvirt] [PATCH] Fix (rare) deadlock in QEMU monitor callbacks

2012-09-26 Thread Eric Blake
On 09/26/2012 08:56 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Some users report (very rarely) seeing a deadlock in the QEMU > monitor callbacks > > Thread 10 (Thread 0x7fcd11e20700 (LWP 26753)): > at util/threads-pthread.c:85 > at conf/domain_conf.c:14256 > vm=0x

[libvirt] [PATCH] Move most of qemuProcessKill into virProcessKillPainfully

2012-09-26 Thread Daniel P. Berrange
From: "Daniel P. Berrange" In the cgroups APIs we have a virCgroupKillPainfully function which does the loop sending SIGTERM, then SIGKILL and waiting for the process to exit. There is similar functionality for simple processes in qemuProcessKill, but it is tangled with the QEMU code. Untangle it

[libvirt] [PATCH] Don't skip over socket label cleanup

2012-09-26 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If QEMU quits immediately after we opened the monitor it was possible we would skip the clearing of the SELinux process socket context Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_process.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --

Re: [libvirt] [PATCH] Fix deadlock in handling EOF in LXC monitor

2012-09-26 Thread Eric Blake
On 09/26/2012 08:34 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Depending on the scenario in which LXC containers exit, it is > possible for the EOF callback of the LXC monitor to deadlock > the driver. When the driver calls virLXCMonitorClose, there > is really no need for the

[libvirt] [PATCH] Fix deadlock in handling EOF in LXC monitor

2012-09-26 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Depending on the scenario in which LXC containers exit, it is possible for the EOF callback of the LXC monitor to deadlock the driver. When the driver calls virLXCMonitorClose, there is really no need for the EOF callback to be invoked in this case, since the caller can

Re: [libvirt] [libvirt-glib PATCHv2 1/3] Implement gvir_config_domain_graphics_vnc_set_socket

2012-09-26 Thread Michal Privoznik
On 26.09.2012 14:07, Christophe Fergeau wrote: > --- > libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 10 ++ > libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h | 3 +++ > libvirt-gconfig/libvirt-gconfig.sym | 2 ++ > 3 files changed, 15 insertions(+) > A

Re: [libvirt] [PATCH 2/4] parallels: fix memory allocation

2012-09-26 Thread Daniel P. Berrange
On Wed, Sep 26, 2012 at 04:53:07PM +0400, Dmitry Guryanov wrote: > On 120926 16:33:28, Daniel P. Berrange wrote: > > On Wed, Sep 26, 2012 at 04:30:00PM +0400, Dmitry Guryanov wrote: > > > size of videos array must be increased. > > > > > > Signed-off-by: Dmitry Guryanov > > > --- > > > src/paral

Re: [libvirt] [PATCH v3 06/20] Make qemuCapsProbeMachineTypes & qemuCapsProbeCPUModels static

2012-09-26 Thread Daniel P. Berrange
On Wed, Sep 26, 2012 at 11:42:09AM +0200, Jiri Denemark wrote: > On Tue, Sep 25, 2012 at 18:59:59 +0100, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > The qemuCapsProbeMachineTypes & qemuCapsProbeCPUModels methods > > do not need to be invoked directly anymore. Make them static

Re: [libvirt] [libvirt-glib PATCHv2 2/3] Add a few GVirConfigDomainGraphicsVnc getters

2012-09-26 Thread Michal Privoznik
On 26.09.2012 14:07, Christophe Fergeau wrote: > --- > libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 16 > libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h | 2 ++ > libvirt-gconfig/libvirt-gconfig.sym | 2 ++ > 3 files changed, 20 insertions(+)

Re: [libvirt] [libvirt-glib PATCHv2 3/3] Implement gvir_config_domain_graphics_spice_get_port

2012-09-26 Thread Michal Privoznik
On 26.09.2012 14:07, Christophe Fergeau wrote: > --- > libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 8 > libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 1 + > libvirt-gconfig/libvirt-gconfig.sym | 2 ++ > libvirt-gconfig/tests/test-domain-create

Re: [libvirt] [PATCH v3 06/20] Make qemuCapsProbeMachineTypes & qemuCapsProbeCPUModels static

2012-09-26 Thread Jiri Denemark
On Wed, Sep 26, 2012 at 13:56:22 +0100, Daniel P. Berrange wrote: > On Wed, Sep 26, 2012 at 11:42:09AM +0200, Jiri Denemark wrote: > > On Tue, Sep 25, 2012 at 18:59:59 +0100, Daniel P. Berrange wrote: > > > > > > -p = t; > > > -if (!(t = strstr(p, "(default)")) || (next && t >= nex

Re: [libvirt] [PATCH 2/4] parallels: fix memory allocation

2012-09-26 Thread Dmitry Guryanov
On 120926 16:33:28, Daniel P. Berrange wrote: > On Wed, Sep 26, 2012 at 04:30:00PM +0400, Dmitry Guryanov wrote: > > size of videos array must be increased. > > > > Signed-off-by: Dmitry Guryanov > > --- > > src/parallels/parallels_driver.c |2 +- > > 1 files changed, 1 insertions(+), 1 dele

Re: [libvirt] [PATCH v3 11/20] Add a qemuMonitorGetCPUDefinitions method for QMP query-cpu-definitions command

2012-09-26 Thread Jiri Denemark
On Tue, Sep 25, 2012 at 19:00:04 +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Add a new qemuMonitorGetCPUDefinitions() method to support invocation > of the 'query-cpu-definitions' JSON monitor command. No HMP equivalent > is required, since this will only be present for QEMU

Re: [libvirt] [PATCH 2/4] parallels: fix memory allocation

2012-09-26 Thread Dmitry Guryanov
On 120926 16:33:28, Daniel P. Berrange wrote: > On Wed, Sep 26, 2012 at 04:30:00PM +0400, Dmitry Guryanov wrote: > > size of videos array must be increased. > > > > Signed-off-by: Dmitry Guryanov > > --- > > src/parallels/parallels_driver.c |2 +- > > 1 files changed, 1 insertions(+), 1 dele

Re: [libvirt] [PATCH 1/4] parallels: remove unused member 'os' from parallelsDomObj

2012-09-26 Thread Daniel P. Berrange
On Wed, Sep 26, 2012 at 04:29:59PM +0400, Dmitry Guryanov wrote: > > Signed-off-by: Dmitry Guryanov > --- > src/parallels/parallels_utils.h |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/src/parallels/parallels_utils.h b/src/parallels/parallels_utils.h > index 082

Re: [libvirt] [PATCH 2/4] parallels: fix memory allocation

2012-09-26 Thread Daniel P. Berrange
On Wed, Sep 26, 2012 at 04:30:00PM +0400, Dmitry Guryanov wrote: > size of videos array must be increased. > > Signed-off-by: Dmitry Guryanov > --- > src/parallels/parallels_driver.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/parallels/parallels_driver.c

[libvirt] [PATCH 05/13] parallels: create storage pools by VM list

2012-09-26 Thread Dmitry Guryanov
There are no storage pools in Parallels Cloud Server - All VM data stored in a single directory: config, snapshots, memory dump together with disk images. Let's look through list of VMs and create a storage pool for each directory, containing VMs. So if you have 3 vms: /var/parallels/vm-1.pvm, /v

[libvirt] [PATCH 11/13] parallels: add support of disks creation

2012-09-26 Thread Dmitry Guryanov
Implement creation of new disks - if a new disk found in configuration, find a volume by disk path and actually create a disk image by issuing prlctl command. If it's successfully finished - remove the file with volume definition. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver

[libvirt] [PATCH 09/13] parallels: split parallelsStorageVolumeDelete function

2012-09-26 Thread Dmitry Guryanov
Move part, which deletes existing volume, to a new function parallelsStorageVolumeDefRemove so that we can use it later in parallels_driver.c Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_storage.c | 83 +--- src/parallels/parallels_utils.h |2

[libvirt] [PATCH 12/13] parallels: apply config after VM creation

2012-09-26 Thread Dmitry Guryanov
New VM will have default values for all parameters, like cpu number, we have to change its configuration as provided by xml definition, given to parallelsDomainDefineXML. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c | 33 + 1 files changed

[libvirt] [PATCH 07/13] parallels: add info about volumes

2012-09-26 Thread Dmitry Guryanov
Disk images in Parallels Cloud Server stored in directories. Each one has files with data and xml description of an image stored in file DiskDescriptior.xml. Since we have to support 'detached' images, which are not used by any VM, the better way to collect info about volumes is searching for dire

[libvirt] [PATCH 08/13] parallels: fill volumes capacity parameter

2012-09-26 Thread Dmitry Guryanov
Read disk images size from xml description and fill virStorageVolDef.capacity and allocation (let's consider that allocation is the same as capacity, calculating real allocation will be implemented later). Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_storage.c | 54 ++

Re: [libvirt] [PATCH 4/4] parallels: don't give null pointers to virBitmapEqual

2012-09-26 Thread Daniel P. Berrange
On Wed, Sep 26, 2012 at 04:30:02PM +0400, Dmitry Guryanov wrote: > > Signed-off-by: Dmitry Guryanov > --- > src/parallels/parallels_driver.c |8 ++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/parallels/parallels_driver.c > b/src/parallels/parallels_driver.

[libvirt] [PATCH 00/13] parallels: implement operations with hard disks

2012-09-26 Thread Dmitry Guryanov
This patch series adds ability to list existing disk images, create a new ones and add or remove hard disk devices to the VM. Dmitry Guryanov (13): parallels: add info about hard disk devices parallels: handle disk devices in parallelsDomainDefineXML parallels: split parallelsStorageOpen fun

[libvirt] [PATCH 13/13] parallels: add support of removing disks

2012-09-26 Thread Dmitry Guryanov
If some hard disk is not found in new domain configuration, it should be removed. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c | 28 1 files changed, 24 insertions(+), 4 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parall

[libvirt] [PATCH 03/13] parallels: split parallelsStorageOpen function

2012-09-26 Thread Dmitry Guryanov
Move code for loading information about pools to a separate function - parallelsLoadPools. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_storage.c | 65 ++--- 1 files changed, 39 insertions(+), 26 deletions(-) diff --git a/src/parallels/parallels_s

[libvirt] [PATCH 1/4] parallels: remove unused member 'os' from parallelsDomObj

2012-09-26 Thread Dmitry Guryanov
Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_utils.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/parallels/parallels_utils.h b/src/parallels/parallels_utils.h index 082ee75..6a27003 100644 --- a/src/parallels/parallels_utils.h +++ b/src/parallels/pa

[libvirt] [PATCH 01/13] parallels: add info about hard disk devices

2012-09-26 Thread Dmitry Guryanov
Parse information about hard disks and fill disks array in virDomainDef structure. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c | 118 ++ 1 files changed, 118 insertions(+), 0 deletions(-) diff --git a/src/parallels/parallels_driver.c

[libvirt] [PATCH 06/13] parallels: fix leaks in parallelsFindVolumes

2012-09-26 Thread Dmitry Guryanov
We always must close opened dir and free 'path'. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_storage.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/parallels/parallels_storage.c b/src/parallels/parallels_storage.c index c3daee0.

[libvirt] [PATCH 02/13] parallels: handle disk devices in parallelsDomainDefineXML

2012-09-26 Thread Dmitry Guryanov
Allow changing some parameters of the hard disks: bus, image and drive address. Creating new disk devices and removing existing ones require changes in the storage driver, so it will be implemented later. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c | 73 +++

[libvirt] [PATCH 04/13] parallels: remove unused code from storage driver

2012-09-26 Thread Dmitry Guryanov
We don't support unprivileged users anymore, so remove code, which selects configuration directory depending on user. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_storage.c | 22 +++--- 1 files changed, 3 insertions(+), 19 deletions(-) diff --git a/src/parallels/

Re: [libvirt] [PATCH 3/4] parallels: remove unneded code from parallelsDoCmdRun

2012-09-26 Thread Daniel P. Berrange
On Wed, Sep 26, 2012 at 04:30:01PM +0400, Dmitry Guryanov wrote: > scmd was used for debugging and I forgot to remove it before > commit, so remove it now. > > Signed-off-by: Dmitry Guryanov > --- > src/parallels/parallels_utils.c |6 -- > 1 files changed, 0 insertions(+), 6 deletions(-)

[libvirt] [PATCH 4/4] parallels: don't give null pointers to virBitmapEqual

2012-09-26 Thread Dmitry Guryanov
Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 87e8cf5..f4799f3 100644 --- a/src/parallels/parallels_driver.c +++ b/src/p

[libvirt] [PATCH 2/4] parallels: fix memory allocation

2012-09-26 Thread Dmitry Guryanov
size of videos array must be increased. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 20ee361..87e8cf5 100644 --- a/src/parall

[libvirt] [PATCH 3/4] parallels: remove unneded code from parallelsDoCmdRun

2012-09-26 Thread Dmitry Guryanov
scmd was used for debugging and I forgot to remove it before commit, so remove it now. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_utils.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/parallels/parallels_utils.c b/src/parallels/parallels_utils.

[libvirt] [PATCH 10/13] parallels: add function parallelsGetDiskBusName

2012-09-26 Thread Dmitry Guryanov
Add function for conversion bus from libvirt's numeric constant to a name, used in a parallels command-line tools. Signed-off-by: Dmitry Guryanov --- src/parallels/parallels_driver.c | 28 ++-- 1 files changed, 18 insertions(+), 10 deletions(-) diff --git a/src/paralle

Re: [libvirt] [PATCH v3 10/20] Add a qemuMonitorGetMachines() method for QMP query-machines command

2012-09-26 Thread Jiri Denemark
On Tue, Sep 25, 2012 at 19:00:03 +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Add a new qemuMonitorGetMachines() method to support invocation > of the 'query-machines' JSON monitor command. No HMP equivalent > is required, since this will only be present for QEMU >= 1.2 > >

Re: [libvirt] [PATCH v3 09/20] Add a qemuMonitorGetVersion() method for QMP query-version command

2012-09-26 Thread Jiri Denemark
On Tue, Sep 25, 2012 at 19:00:02 +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Add a new qemuMonitorGetVersion() method to support invocation > of the 'query-version' JSON monitor command. No HMP equivalent > is provided, since this will only be used for QEMU >= 1.2 > > Signe

[libvirt] [libvirt-glib PATCHv2 3/3] Implement gvir_config_domain_graphics_spice_get_port

2012-09-26 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 8 libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 1 + libvirt-gconfig/libvirt-gconfig.sym | 2 ++ libvirt-gconfig/tests/test-domain-create.c | 1 + 4 files changed, 12 insertions(+)

[libvirt] [libvirt-glib PATCHv2 2/3] Add a few GVirConfigDomainGraphicsVnc getters

2012-09-26 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 16 libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h | 2 ++ libvirt-gconfig/libvirt-gconfig.sym | 2 ++ 3 files changed, 20 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-grap

[libvirt] [libvirt-glib PATCHv2 1/3] Implement gvir_config_domain_graphics_vnc_set_socket

2012-09-26 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 10 ++ libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h | 3 +++ libvirt-gconfig/libvirt-gconfig.sym | 2 ++ 3 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics-

Re: [libvirt] [PATCH] Change qemuSetSchedularParameters to use AFFECT_CURRENT

2012-09-26 Thread Eric Blake
On 09/26/2012 05:17 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > When adding variants of parameter setting APIs which accepted > flags, the existing APIs were all adapted internally to pass > VIR_DOMAIN_AFFECT_CURRENT to the new API. The QEMU impl > qemuSetSchedularParameters wa

[libvirt] [PATCH] Change qemuSetSchedularParameters to use AFFECT_CURRENT

2012-09-26 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When adding variants of parameter setting APIs which accepted flags, the existing APIs were all adapted internally to pass VIR_DOMAIN_AFFECT_CURRENT to the new API. The QEMU impl qemuSetSchedularParameters was an exception, which instead used VIR_DOMAIN_AFFECT_LIVE. Cha

Re: [libvirt] [PATCH v3 08/20] Refactor guest init to support qemu-system-i386 binary too

2012-09-26 Thread Jiri Denemark
On Tue, Sep 25, 2012 at 19:00:01 +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Signed-off-by: Daniel P. Berrange > --- > src/qemu/qemu_capabilities.c | 163 > +++ > 1 file changed, 89 insertions(+), 74 deletions(-) > > diff --git a/s

Re: [libvirt] [PATCH v4] qemu: wait for SPICE to migrate

2012-09-26 Thread Michal Privoznik
On 26.09.2012 11:17, Daniel P. Berrange wrote: > On Wed, Sep 26, 2012 at 11:11:51AM +0200, Michal Privoznik wrote: >> Recently, there have been some improvements made to qemu so it >> supports seamless migration or something very close to it. >> However, it requires libvirt interaction. Once qemu i

Re: [libvirt] [PATCH v3 06/20] Make qemuCapsProbeMachineTypes & qemuCapsProbeCPUModels static

2012-09-26 Thread Jiri Denemark
On Tue, Sep 25, 2012 at 18:59:59 +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The qemuCapsProbeMachineTypes & qemuCapsProbeCPUModels methods > do not need to be invoked directly anymore. Make them static > and refactor them to directly populate the qemuCapsPtr object > > Sig

[libvirt] [PATCH v4] qemu: wait for SPICE to migrate

2012-09-26 Thread Michal Privoznik
Recently, there have been some improvements made to qemu so it supports seamless migration or something very close to it. However, it requires libvirt interaction. Once qemu is migrated, the SPICE server needs to send its internal state to the destination. Once it's done, it fires SPICE_MIGRATE_COM

Re: [libvirt] [PATCH v4] qemu: wait for SPICE to migrate

2012-09-26 Thread Daniel P. Berrange
On Wed, Sep 26, 2012 at 11:11:51AM +0200, Michal Privoznik wrote: > Recently, there have been some improvements made to qemu so it > supports seamless migration or something very close to it. > However, it requires libvirt interaction. Once qemu is migrated, > the SPICE server needs to send its int

Re: [libvirt] [PATCH v3 07/20] Remove xenner support

2012-09-26 Thread Jiri Denemark
On Tue, Sep 25, 2012 at 19:00:00 +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Signed-off-by: Daniel P. Berrange > --- > src/qemu/qemu_capabilities.c | 158 > +-- > 1 file changed, 47 insertions(+), 111 deletions(-) ACK Jirka -- li

Re: [libvirt] [PATCH] Simplify some redundant locking while unref'ing objects

2012-09-26 Thread Daniel P. Berrange
On Tue, Sep 25, 2012 at 05:49:39PM -0600, Eric Blake wrote: > On 09/25/2012 02:29 PM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > There is no need to hold the mutex when unref'ing > > virObject instances > > > > Signed-off-by: Daniel P. Berrange > > --- > > src/conf/domain

Re: [libvirt] [PATCH v3 05/20] Remove probing of CPU models when launching QEMU guests

2012-09-26 Thread Jiri Denemark
On Tue, Sep 25, 2012 at 18:59:58 +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > When launching a QEMU guest the binary is probed to discover > the list of supported CPU names. Remove this probing with a > simple lookup of CPU models in the qemuCapsPtr object. This > avoids anot

Re: [libvirt] [PATCH v3] qemu: wait for SPICE to migrate

2012-09-26 Thread Daniel P. Berrange
On Wed, Sep 26, 2012 at 08:57:28AM +0200, Michal Privoznik wrote: > On 25.09.2012 19:57, Daniel P. Berrange wrote: > > On Thu, Sep 20, 2012 at 01:29:21PM +0200, Michal Privoznik wrote: > >> Recently, there have been some improvements made to qemu so it > >> supports seamless migration or something

Re: [libvirt] [libvirt-glib PATCHv3] Fix *_new_from_xml

2012-09-26 Thread Michal Privoznik
On 25.09.2012 14:30, Michal Privoznik wrote: > On 25.09.2012 11:21, Christophe Fergeau wrote: >> Ping? >> Can this patch go as is, or do we want to go all the way to switching to >> GInitable as Marc-André suggested in >> http://www.mail-archive.com/libvir-list@redhat.com/msg59538.html ? >> >> Chri

Re: [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-26 Thread Michal Privoznik
On 25.09.2012 19:08, Doug Goldstein wrote: > On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange > wrote: >> On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: >>> On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: On Tue, Sep 25, 2012 at 02:49:00PM +0200, Michal Privoznik wrote: >>>