Re: [libvirt] [PATCHv4 24/51] snapshot: prevent stranding snapshot data on domain destruction

2012-11-05 Thread Philipp Hahn
Hello Eric, thank you for your answer; I had hoped to stop your from spending any further time ony this by my 2nd mail from October 26, because I found my thinko myself after reading some more code. Actually I was reading a patched version, where the patch broke it. This behaviour is

Re: [libvirt] [PATCH v6 1/6] add a configure option --with-fuse to prepare introduction of fuse support for libvirt lxc

2012-11-05 Thread Richard W.M. Jones
On Mon, Nov 05, 2012 at 01:23:51PM +0800, Gao feng wrote: +dnl libfuse +AC_ARG_WITH([fuse], + AC_HELP_STRING([--with-fuse], [use libfuse to proivde fuse filesystem support for libvirt lxc]), + [], + [with_fuse=check]) +dnl +dnl This check looks for 'fuse' +dnl +FUSE_CFLAGS=

Re: [libvirt] jna problem

2012-11-05 Thread Claudio Bley
Hi. At Wed, 31 Oct 2012 14:21:42 +0100 (CET), Matthieu Simonin wrote: Hello, Since this morning i got this exception throwed by the libvirt-java : java.lang.UnsatisfiedLinkError: com.sun.jna.Native.pointerSize()I at com.sun.jna.Native.pointerSize(Native Method) What could be the

Re: [libvirt] [PATCH v6 1/6] add a configure option --with-fuse to prepare introduction of fuse support for libvirt lxc

2012-11-05 Thread Gao feng
于 2012年11月05日 18:30, Daniel P. Berrange 写道: On Mon, Nov 05, 2012 at 10:11:17AM +, Richard W.M. Jones wrote: On Mon, Nov 05, 2012 at 01:23:51PM +0800, Gao feng wrote: +dnl libfuse +AC_ARG_WITH([fuse], + AC_HELP_STRING([--with-fuse], [use libfuse to proivde fuse filesystem support for

Re: [libvirt] [PATCH v6 1/6] add a configure option --with-fuse to prepare introduction of fuse support for libvirt lxc

2012-11-05 Thread Richard W.M. Jones
On Mon, Nov 05, 2012 at 08:10:26PM +0800, Gao feng wrote: 于 2012年11月05日 18:30, Daniel P. Berrange 写道: On Mon, Nov 05, 2012 at 10:11:17AM +, Richard W.M. Jones wrote: On Mon, Nov 05, 2012 at 01:23:51PM +0800, Gao feng wrote: +dnl libfuse +AC_ARG_WITH([fuse], +

[libvirt] Limit autostarting of domains to a few at a time.

2012-11-05 Thread Ruben Kerkhof
Hi list, I have about a hundred kvm vm's on a physical host, all marked as autostart. As soon as libvirtd starts up, all vms get started and they start fighting for disk I/O. Would it be possible to add an option to wait a while before starting the next vm? Batch-starting them in parallel, let's

[libvirt] [libvirt-glib] Log virStreamFinish error when it fails

2012-11-05 Thread Christophe Fergeau
GVirObjectStream::finalize() logs a critical() if virStreamFinish fails. This commit adds the libvirt error message to this critical to ease debugging. --- libvirt-gobject/libvirt-gobject-stream.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH] iohelper: Don't try to fdatasync(stdout)

2012-11-05 Thread Christophe Fergeau
After upgrading to libvirt 1.0.0, I've started getting warnings from libvirt: (gnome-boxes:5965): Libvirt.GObject-CRITICAL **: cannot finish stream: internal error libvirt_iohelper: unable to fsync stdout: Invalid argument On further investigation, in iohelper.c:runIO(), fdatasync can get called

Re: [libvirt] [libvirt-glib] Log virStreamFinish error when it fails

2012-11-05 Thread Michal Privoznik
On 05.11.2012 14:21, Christophe Fergeau wrote: GVirObjectStream::finalize() logs a critical() if virStreamFinish fails. This commit adds the libvirt error message to this critical to ease debugging. --- libvirt-gobject/libvirt-gobject-stream.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [libvirt] [PATCH] qemu: Allow the user to specify vendor and product for disk

2012-11-05 Thread Martin Kletzander
On 11/05/2012 08:04 AM, Osier Yang wrote: QEMU supports to set vendor and product strings for disk since 1.2.0 (only scsi-disk, scsi-hd, scsi-cd support it), this patch exposes it with new XML elements vendor and product of disk device. --- docs/formatdomain.html.in

[libvirt] [PATCH v2 1/3] qemu: Wrap controllers code into dummy loop

2012-11-05 Thread Michal Privoznik
which just re-indent code and prepare it for next patch. --- src/qemu/qemu_command.c | 95 --- 1 files changed, 48 insertions(+), 47 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 389c480..566565a 100644 ---

[libvirt] [PATCH v2 2/3] qemu: Add controllers in specified order

2012-11-05 Thread Michal Privoznik
qemu is sensitive to the order of arguments passed. Hence, if a device requires a controller, the controller cmd string must precede device cmd string. The same apply for controllers, when for instance ccid controller requires usb controller. So controllers create partial ordering in which they

[libvirt] [PATCH v2 0/3] QEMU: Specific order for controllers in cmd line

2012-11-05 Thread Michal Privoznik
The order is basically random for now, with one constraint: CCID must be preceded with USB. diff to v1: -split into 2 patches -add a test case Michal Privoznik (3): qemu: Wrap controllers code into dummy loop qemu: Add controllers in specified order tests: Add test for controller order

[libvirt] [PATCH v2 3/3] tests: Add test for controller order

2012-11-05 Thread Michal Privoznik
--- .../qemuxml2argv-controller-order.args | 28 ++ .../qemuxml2argv-controller-order.xml | 89 tests/qemuxml2argvtest.c |6 ++ 3 files changed, 123 insertions(+), 0 deletions(-) create mode 100644

Re: [libvirt] Limit autostarting of domains to a few at a time.

2012-11-05 Thread Peter Krempa
On 11/05/12 13:32, Ruben Kerkhof wrote: Hi list, Hi Ruben, I have about a hundred kvm vm's on a physical host, all marked as autostart. As soon as libvirtd starts up, all vms get started and they start fighting for disk I/O. Would it be possible to add an option to wait a while before

Re: [libvirt] [PATCH] iohelper: Don't try to fdatasync(stdout)

2012-11-05 Thread Eric Blake
On 11/05/2012 06:21 AM, Christophe Fergeau wrote: After upgrading to libvirt 1.0.0, I've started getting warnings from libvirt: (gnome-boxes:5965): Libvirt.GObject-CRITICAL **: cannot finish stream: internal error libvirt_iohelper: unable to fsync stdout: Invalid argument On further

[libvirt] [PATCH] iohelper: Don't report errors on special FDs

2012-11-05 Thread Michal Privoznik
Some FDs may not implement fdatasync() functionality, e.g. pipes or stdout. In that case EINVAL or EROFS is returned. We don't want to fail then nor report any error. Reported-by: Christophe Fergeau cferg...@redhat.com --- I know that those two 'if-s' can be joined together but it just looks

[libvirt] [PATCH] qemu: Add ability to disable autostarting of guests on daemon start

2012-11-05 Thread Peter Krempa
When the daemon is starting it autostarts all guests marked as autostartable. This is not an ideal solution for autostarting if there's a lot of domains configured so. After autostarting all right away the guests start competing for disk I/O and the boot is prolonged unnecessarily. This patch

[libvirt] [PATCH] qemu: Emit event if save fails

2012-11-05 Thread Michal Privoznik
When we are doing a (managed-) save of a domain, we stop its processors firstly. And if the process of saving fails for some reason we try to wake them up again. However, if this fails, an event should be emitted so mgmt application can decide what to do. --- I am not completely sure about

Re: [libvirt] [PATCH] qemu: Add ability to disable autostarting of guests on daemon start

2012-11-05 Thread Michal Privoznik
On 05.11.2012 16:02, Peter Krempa wrote: When the daemon is starting it autostarts all guests marked as autostartable. This is not an ideal solution for autostarting if there's a lot of domains configured so. After autostarting all right away the guests start competing for disk I/O and the

Re: [libvirt] [PATCH v2] gitignore: ignore more files

2012-11-05 Thread Martin Kletzander
On 11/05/2012 05:59 AM, liguang wrote: ignore cscope.in.out, cscope.po.out Signed-off-by: liguang lig.f...@cn.fujitsu.com --- .gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 79a055b..12fbe0e 100644 --- a/.gitignore +++

Re: [libvirt] [PATCH] iohelper: Don't report errors on special FDs

2012-11-05 Thread Eric Blake
On 11/05/2012 07:54 AM, Michal Privoznik wrote: Some FDs may not implement fdatasync() functionality, e.g. pipes or stdout. In that case EINVAL or EROFS is returned. Don't mention 'stdout'. It is not an inherent property of fd 1 that it can't support fdatasync(); rather, it is a property of

Re: [libvirt] [PATCH] qemu: Add ability to disable autostarting of guests on daemon start

2012-11-05 Thread Eric Blake
On 11/05/2012 08:02 AM, Peter Krempa wrote: When the daemon is starting it autostarts all guests marked as autostartable. This is not an ideal solution for autostarting if there's a lot of domains configured so. After autostarting all right away the guests start competing for disk I/O and the

Re: [libvirt] Proposed: replace radvd with dnsmasq for Router Advertizing

2012-11-05 Thread Gene Czarcinski
On 11/05/2012 12:29 AM, Doug Goldstein wrote: On Sun, Nov 4, 2012 at 6:26 AM, Gene Czarcinski g...@czarc.net wrote: On 11/03/2012 08:58 PM, Laine Stump wrote: On 11/02/2012 12:39 PM, Gene Czarcinski wrote: On 11/02/2012 11:58 AM, Jiri Denemark wrote: On Fri, Nov 02, 2012 at 08:25:42 -0400,

Re: [libvirt] [PATCH] iohelper: Don't report errors on special FDs

2012-11-05 Thread Michal Privoznik
On 05.11.2012 16:40, Eric Blake wrote: On 11/05/2012 07:54 AM, Michal Privoznik wrote: Some FDs may not implement fdatasync() functionality, e.g. pipes or stdout. In that case EINVAL or EROFS is returned. Don't mention 'stdout'. It is not an inherent property of fd 1 that it can't support

Re: [libvirt] [PATCH v2 0/3] QEMU: Specific order for controllers in cmd line

2012-11-05 Thread Eric Blake
On 11/05/2012 06:37 AM, Michal Privoznik wrote: The order is basically random for now, with one constraint: CCID must be preceded with USB. diff to v1: -split into 2 patches -add a test case Thanks. ACK series. Michal Privoznik (3): qemu: Wrap controllers code into dummy loop

Re: [libvirt] Proposed: always allow packets internal to an interface

2012-11-05 Thread Eric Blake
On 11/04/2012 10:18 AM, Gene Czarcinski wrote: On 11/02/2012 07:46 AM, Gene Czarcinski wrote: Currently, when an interface (virtual network) is started, if no ip address is defined, then no rule is added to bemit internal network traffic. However, virtual guests can use such a network to

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-11-05 Thread Eric Blake
On 10/30/2012 05:56 AM, Daniel P. Berrange wrote: Then why are we explicitly starting cgconfig.service in the spec file? Shouldn't the argument go that only those people customizing the service file to use cgconfig need cgconfig enabled in the first place? In other words, is there anything

Re: [libvirt] Proposed: always allow packets internal to an interface

2012-11-05 Thread Laine Stump
On 11/02/2012 07:46 AM, Gene Czarcinski wrote: Currently, when an interface (virtual network) is started, if no ip address is defined, then no rule is added to bemit internal network traffic. However, virtual guests can use such a network to communicate if a rule is added to the

Re: [libvirt] Proposed: always allow packets internal to an interface

2012-11-05 Thread Laine Stump
On 11/04/2012 12:18 PM, Gene Czarcinski wrote: On 11/02/2012 07:46 AM, Gene Czarcinski wrote: Currently, when an interface (virtual network) is started, if no ip address is defined, then no rule is added to bemit internal network traffic. However, virtual guests can use such a network to

Re: [libvirt] Using Generic Ethernet type with custom networking without lowering the host security level

2012-11-05 Thread Laine Stump
On 10/31/2012 05:10 AM, Ishimoto, Ryu wrote: Hi Everyone, I wanted to ask a question about the 'generic ethernet' NIC type. If I understand its security concerns correctly, because it expects QEMU to execute scripts to bring up/down the interface, it requires that the host security level is

[libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-05 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping 'start', 'stop', 'restart'; might be easier to remember than the current mix of 'start', 'shutdown', 'reboot'. * tools/virsh-domain.c (domManagementCmds): Add other

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-05 Thread Dave Allan
On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping 'start', 'stop', 'restart'; might be easier to remember than the current mix of 'start', 'shutdown',

Re: [libvirt] Patch replaces scriptlets with new systemd macros

2012-11-05 Thread Eric Blake
On 10/25/2012 04:10 AM, Václav Pavlín wrote: Hi, sorry, I didn't realize I have to modify upstream version. No problem - we'll get it all straightened out. I added Requires stanza to libvirtd service file for cgconfig.service, so you should not need to call enable in spec file for it.

Re: [libvirt] [PATCHv2 14/20] snapshot: qemu: Add flag VIR_DOMAIN_SNAPSHOT_REVERT_STOPPED

2012-11-05 Thread Eric Blake
On 11/02/2012 07:48 PM, Eric Blake wrote: +++ b/include/libvirt/libvirt.h.in @@ -3872,6 +3872,7 @@ typedef enum { VIR_DOMAIN_SNAPSHOT_REVERT_RUNNING = 1 0, /* Run after revert */ VIR_DOMAIN_SNAPSHOT_REVERT_PAUSED = 1 1, /* Pause after revert */

Re: [libvirt] [PATCH] qemu: Add ability to disable autostarting of guests on daemon start

2012-11-05 Thread Peter Krempa
On 11/05/12 16:48, Eric Blake wrote: On 11/05/2012 08:02 AM, Peter Krempa wrote: When the daemon is starting it autostarts all guests marked as autostartable. This is not an ideal solution for autostarting if there's a lot of domains configured so. After autostarting all right away the guests

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-05 Thread Peter Krempa
On 11/05/12 20:59, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping 'start', 'stop', 'restart'; might be easier to remember than the current mix of 'start', 'shutdown', 'reboot'. *

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-05 Thread Eric Blake
On 11/05/2012 03:53 PM, Peter Krempa wrote: On 11/05/12 20:59, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping 'start', 'stop', 'restart'; might be easier to remember than the current mix of

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-05 Thread Doug Goldstein
On Mon, Nov 5, 2012 at 4:57 PM, Eric Blake ebl...@redhat.com wrote: On 11/05/2012 03:53 PM, Peter Krempa wrote: On 11/05/12 20:59, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping 'start',

Re: [libvirt] [PATCHv2 15/20] snapshot: qemu: Add support for external inactive snapshots

2012-11-05 Thread Eric Blake
On 11/02/2012 10:49 PM, Eric Blake wrote: On 11/01/2012 10:22 AM, Peter Krempa wrote: This patch adds support for external disk snapshots of inactive domains. The snapshot is created by calling qemu-img create -o backing_file=/path/to/disk /path/snapshot_file -f

Re: [libvirt] [PATCH v6 1/6] add a configure option --with-fuse to prepare introduction of fuse support for libvirt lxc

2012-11-05 Thread Gao feng
于 2012年11月05日 20:14, Richard W.M. Jones 写道: On Mon, Nov 05, 2012 at 08:10:26PM +0800, Gao feng wrote: 于 2012年11月05日 18:30, Daniel P. Berrange 写道: On Mon, Nov 05, 2012 at 10:11:17AM +, Richard W.M. Jones wrote: On Mon, Nov 05, 2012 at 01:23:51PM +0800, Gao feng wrote: +dnl libfuse

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-05 Thread Jim Fehlig
Doug Goldstein wrote: On Mon, Nov 5, 2012 at 4:57 PM, Eric Blake ebl...@redhat.com wrote: On 11/05/2012 03:53 PM, Peter Krempa wrote: On 11/05/12 20:59, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown',

[libvirt] [test-API][PATCH] Fix a typo xml_file_path

2012-11-05 Thread hongming
Change the undefined variable xml_file_path to file_path --- src/testcasexml.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/testcasexml.py b/src/testcasexml.py index 8485d3d..4cbdc03 100644 --- a/src/testcasexml.py +++ b/src/testcasexml.py @@ -31,7 +31,7 @@ def

Re: [libvirt] [test-API][PATCH] Fix a typo xml_file_path

2012-11-05 Thread Guannan Ren
On 11/06/2012 11:21 AM, hongming wrote: Change the undefined variable xml_file_path to file_path --- src/testcasexml.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/testcasexml.py b/src/testcasexml.py index 8485d3d..4cbdc03 100644 --- a/src/testcasexml.py +++

Re: [libvirt] [PATCH v3 UPDATED 0/2] Qemu/Gluster support in Libvirt

2012-11-05 Thread Harsh Bora
Hi Daniel, Does this patchset look good to you now ? Jiri and Paolo, Would you like to formally ack the patchset if there are no further changes required ? regards, Harsh On 10/26/2012 10:27 PM, Harsh Prateek Bora wrote: Changelog: v3 updated: - Fix other network backends (nbd, rbd,

[libvirt] [PATCH v7 6/6] Mount fuse's meminfo file to container's /proc/meminfo

2012-11-05 Thread Gao feng
we already have virtualize meminfo for container through fuse filesystem, add function lxcContainerMountProcFuse to mount this meminfo file to the container's /proc/meminfo. So we can isolate container's /proc/meminfo from host now. Signed-off-by: Gao feng gaof...@cn.fujitsu.com ---

[libvirt] [PATCH v7 1/6] add a configure option --with-fuse to prepare introduction of fuse support for libvirt lxc

2012-11-05 Thread Gao feng
add a configure option --with-fuse to prepare introduction of fuse support for libvirt lxc. With help from Daniel and Richard. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- configure.ac| 29 + libvirt.spec.in |9 + 2 files changed, 38

[libvirt] [PATCH v7 4/6] add interface virCgroupGetAppRoot

2012-11-05 Thread Gao feng
because libvirt_lxc's cgroup mountpoint is what it shown in /proc/self/cgroup. we can get container's cgroup through virCgroupNew(/, group), add interface virCgroupGetAppRoot to help container to get it's cgroup. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/libvirt_private.syms |1

[libvirt] [PATCH v7 3/6] add interface virCgroupGetMemSwapUsage

2012-11-05 Thread Gao feng
virCgroupGetMemSwapUsage is used to get container's swap usage, with this interface,we can get swap usage in fuse filesystem. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/libvirt_private.syms |1 + src/util/cgroup.c| 20 src/util/cgroup.h|

[libvirt] [PATCH v7 2/6] add fuse support for libvirt lxc

2012-11-05 Thread Gao feng
this patch addes fuse support for libvirt lxc. we can use fuse filesystem to generate sysinfo dynamically, So we can isolate /proc/meminfo,cpuinfo and so on through fuse filesystem. we mount fuse filesystem for every container. the mount name is libvirt,mount point is

[libvirt] [PATCH v7 5/6] make /proc/meminfo isolate with host through fuse

2012-11-05 Thread Gao feng
with this patch,container's meminfo will be shown based on containers' mem cgroup. Right now,it's impossible to virtualize all values in meminfo, I collect some values such as MemTotal,MemFree,Cached,Active, Inactive,Active(anon),Inactive(anon),Active(file),Inactive(anon),