Re: [libvirt] [PATCH v3 1/2] helper of copy-storage-* features

2012-11-06 Thread li guang
ping ... 在 2012-11-01四的 08:40 +0800,liguang写道: help to create disk images copy-storage-* required, try to do non-shared migration without bothering to create disk images at target by hand. consider this situation: 1. non-shared migration virsh migrate --copy-storage-all ... 2.

Re: [libvirt] [PATCH v3 2/2] init qemu_driver's qemuImgBinary field

2012-11-06 Thread li guang
ping ... 在 2012-11-01四的 08:40 +0800,liguang写道: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- src/qemu/qemu_domain.c |2 +- src/qemu/qemu_driver.c |3 +++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

Re: [libvirt] [PATCH v7 1/6] add a configure option --with-fuse to prepare introduction of fuse support for libvirt lxc

2012-11-06 Thread Richard W.M. Jones
On Tue, Nov 06, 2012 at 02:07:17PM +0800, Gao feng wrote: add a configure option --with-fuse to prepare introduction of fuse support for libvirt lxc. With help from Daniel and Richard. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- configure.ac| 29

Re: [libvirt] [PATCH v7 2/6] add fuse support for libvirt lxc

2012-11-06 Thread Richard W.M. Jones
On Tue, Nov 06, 2012 at 02:07:18PM +0800, Gao feng wrote: +static int +virLXCControllerSetupFuse(virLXCControllerPtr ctrl) +{ +int try = 0; +virThread thread; +if (virThreadCreate(thread, true, lxcRegisterFuse, +(void *)ctrl-def) 0) +return -1;

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-06 Thread Viktor Mihajlovski
On 11/05/2012 08:59 PM, Eric Blake wrote: This patch documents both spellings. An alternative would be to leave the alternate spellings as hidden aliases (virsh has support for that), but still mention them in virsh.pod (see how we did an alias for nodedev-dettach, for reference). In my

Re: [libvirt] [PATCH v7 3/6] add interface virCgroupGetMemSwapUsage

2012-11-06 Thread Richard W.M. Jones
On Tue, Nov 06, 2012 at 02:07:19PM +0800, Gao feng wrote: virCgroupGetMemSwapUsage is used to get container's swap usage, with this interface,we can get swap usage in fuse filesystem. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/libvirt_private.syms |1 + src/util/cgroup.c

Re: [libvirt] [PATCH v7 2/6] add fuse support for libvirt lxc

2012-11-06 Thread Gao feng
于 2012年11月06日 16:34, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 02:07:18PM +0800, Gao feng wrote: +static int +virLXCControllerSetupFuse(virLXCControllerPtr ctrl) +{ +int try = 0; +virThread thread; +if (virThreadCreate(thread, true, lxcRegisterFuse, +

Re: [libvirt] [PATCH v7 6/6] Mount fuse's meminfo file to container's /proc/meminfo

2012-11-06 Thread Richard W.M. Jones
On Tue, Nov 06, 2012 at 02:07:22PM +0800, Gao feng wrote: +int ret = 0; In this case, it's better NOT to initialize 'ret'. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-06 Thread Peter Krempa
On 11/06/12 09:30, Viktor Mihajlovski wrote: On 11/05/2012 08:59 PM, Eric Blake wrote: This patch documents both spellings. An alternative would be to leave the alternate spellings as hidden aliases (virsh has support for that), but still mention them in virsh.pod (see how we did an alias for

Re: [libvirt] [PATCH v7 2/6] add fuse support for libvirt lxc

2012-11-06 Thread Richard W.M. Jones
On Tue, Nov 06, 2012 at 04:54:59PM +0800, Gao feng wrote: Because libvirt_lxc create a thread to mount fuse filesystem. and then libvirt_lxc will try to access the fuse filesystem. Without waiting,libvirt_lxc may access fuse before it is mounted. And I can't find a better way to make

Re: [libvirt] [PATCH v7 5/6] make /proc/meminfo isolate with host through fuse

2012-11-06 Thread Richard W.M. Jones
On Tue, Nov 06, 2012 at 02:07:21PM +0800, Gao feng wrote: +unsigned long long meminfo[VIR_LXC_FUSE_MEMMAX]; +enum { +VIR_LXC_FUSE_MEMTOTAL, +VIR_LXC_FUSE_MEMUSAGE, +VIR_LXC_FUSE_CACHED, +VIR_LXC_FUSE_ACTIVE_ANON, +VIR_LXC_FUSE_INACTIVE_ANON, +

Re: [libvirt] [PATCH v7 5/6] make /proc/meminfo isolate with host through fuse

2012-11-06 Thread Richard W.M. Jones
On Tue, Nov 06, 2012 at 02:07:21PM +0800, Gao feng wrote: +while (fgets(line, sizeof(line), statfd) != NULL) { I wonder if libvirt prefers the getline API instead of fgets? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog:

Re: [libvirt] [PATCHv2 15/20] snapshot: qemu: Add support for external inactive snapshots

2012-11-06 Thread Peter Krempa
On 11/06/12 01:06, Eric Blake wrote: On 11/02/2012 10:49 PM, Eric Blake wrote: On 11/01/2012 10:22 AM, Peter Krempa wrote: This patch adds support for external disk snapshots of inactive domains. The snapshot is created by calling qemu-img create -o backing_file=/path/to/disk

[libvirt] [PATCH] esx: Yet another connection fix for 5.1

2012-11-06 Thread Martin Kletzander
After the connection to ESX 5.1 being broken since g1e7cd39, the fix in bab7752c helped a bit, but still missed a spot, so the connection is now successful, but some APIs (for example defineXML) don't work. Two cases missing are added in this patch to avoid that. --- src/esx/esx_vi.c | 4 +++- 1

Re: [libvirt] [PATCH v7 5/6] make /proc/meminfo isolate with host through fuse

2012-11-06 Thread Gao feng
于 2012年11月06日 17:04, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 02:07:21PM +0800, Gao feng wrote: +unsigned long long meminfo[VIR_LXC_FUSE_MEMMAX]; +enum { +VIR_LXC_FUSE_MEMTOTAL, +VIR_LXC_FUSE_MEMUSAGE, +VIR_LXC_FUSE_CACHED, +VIR_LXC_FUSE_ACTIVE_ANON, +

Re: [libvirt] [PATCH v2 0/3] QEMU: Specific order for controllers in cmd line

2012-11-06 Thread Michal Privoznik
On 05.11.2012 17:25, Eric Blake wrote: On 11/05/2012 06:37 AM, Michal Privoznik wrote: The order is basically random for now, with one constraint: CCID must be preceded with USB. diff to v1: -split into 2 patches -add a test case Thanks. ACK series. Pushed. Thanks. Michal --

Re: [libvirt] [PATCH v7 5/6] make /proc/meminfo isolate with host through fuse

2012-11-06 Thread Richard W.M. Jones
On Tue, Nov 06, 2012 at 05:47:41PM +0800, Gao feng wrote: 于 2012年11月06日 17:04, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 02:07:21PM +0800, Gao feng wrote: +unsigned long long meminfo[VIR_LXC_FUSE_MEMMAX]; +enum { +VIR_LXC_FUSE_MEMTOTAL, +VIR_LXC_FUSE_MEMUSAGE, +

Re: [libvirt] [PATCH] esx: Yet another connection fix for 5.1

2012-11-06 Thread Peter Krempa
On 11/06/12 10:22, Martin Kletzander wrote: After the connection to ESX 5.1 being broken since g1e7cd39, the fix in bab7752c helped a bit, but still missed a spot, so the connection is now successful, but some APIs (for example defineXML) don't work. Two cases missing are added in this patch to

Re: [libvirt] [PATCH] esx: Yet another connection fix for 5.1

2012-11-06 Thread Michal Privoznik
On 06.11.2012 10:22, Martin Kletzander wrote: After the connection to ESX 5.1 being broken since g1e7cd39, the fix in bab7752c helped a bit, but still missed a spot, so the connection is now successful, but some APIs (for example defineXML) don't work. Two cases missing are added in this patch

[libvirt] [PATCH] qemu: Don't corrupt pointer in qemuDomainSaveMemory()

2012-11-06 Thread Peter Krempa
The code that was split out into the qemuDomainSaveMemory expands the pointer containing the XML description of the domain that it gets from higher layers. If the pointer changes the old one is invalid and the upper layer function tries to free it causing an abort. This patch changes the

Re: [libvirt] [PATCH] esx: Yet another connection fix for 5.1

2012-11-06 Thread Martin Kletzander
On 11/06/2012 11:00 AM, Peter Krempa wrote: On 11/06/12 10:22, Martin Kletzander wrote: After the connection to ESX 5.1 being broken since g1e7cd39, the fix in bab7752c helped a bit, but still missed a spot, so the connection is now successful, but some APIs (for example defineXML) don't work.

Re: [libvirt] [PATCH v7 5/6] make /proc/meminfo isolate with host through fuse

2012-11-06 Thread Gao feng
于 2012年11月06日 17:55, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 05:47:41PM +0800, Gao feng wrote: 于 2012年11月06日 17:04, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 02:07:21PM +0800, Gao feng wrote: +unsigned long long meminfo[VIR_LXC_FUSE_MEMMAX]; +enum { +

Re: [libvirt] [libvirt-glib] Log virStreamFinish error when it fails

2012-11-06 Thread Christophe Fergeau
On Mon, Nov 05, 2012 at 02:29:27PM +0100, Michal Privoznik wrote: On 05.11.2012 14:21, Christophe Fergeau wrote: GVirObjectStream::finalize() logs a critical() if virStreamFinish fails. This commit adds the libvirt error message to this critical to ease debugging. ACK Actually I'm going

[libvirt] [libvirt-glib] Introduce gvir_warning/gvir_critical

2012-11-06 Thread Christophe Fergeau
They are similar to g_warning/g_critical, but also log the last libvirt error. They are meant to be called right after a libvirt call failed, in other cases g_warning/g_critical are still to be used. --- libvirt-glib/libvirt-glib-error.c | 34 +++

[libvirt] [libvirt-glib 1/4] gobject: don't try to use pool's volumes before a successful refresh

2012-11-06 Thread Christophe Fergeau
gvir_storage_pool_refresh must be called and must be successful before trying to use gvir_storage_pool_get_volume, gvir_storage_pool_get_volumes and gvir_storage_pool_create_volume. As the storage pool refresh can fail for reasons external to libvirt/libvirt-gobject, the library user should check

[libvirt] [libvirt-glib 2/4] gobject: Wrap virStoragePoolDestroy

2012-11-06 Thread Christophe Fergeau
--- libvirt-gobject/libvirt-gobject-storage-pool.c | 90 ++ libvirt-gobject/libvirt-gobject-storage-pool.h | 10 +++ libvirt-gobject/libvirt-gobject.sym| 6 ++ 3 files changed, 106 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-storage-pool.c

[libvirt] [libvirt-glib 3/4] gobject: Wrap virStoragePoolUndefine

2012-11-06 Thread Christophe Fergeau
--- libvirt-gobject/libvirt-gobject-storage-pool.c | 90 ++ libvirt-gobject/libvirt-gobject-storage-pool.h | 11 libvirt-gobject/libvirt-gobject.sym| 3 + 3 files changed, 104 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-storage-pool.c

[libvirt] [libvirt-glib 4/4] gobject: Wrap virStoragePoolDelete

2012-11-06 Thread Christophe Fergeau
--- libvirt-gobject/libvirt-gobject-storage-pool.c | 105 + libvirt-gobject/libvirt-gobject-storage-pool.h | 11 +++ libvirt-gobject/libvirt-gobject.sym| 3 + 3 files changed, 119 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-storage-pool.c

Re: [libvirt] [PATCH v7 2/6] add fuse support for libvirt lxc

2012-11-06 Thread Gao feng
于 2012年11月06日 17:11, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 04:54:59PM +0800, Gao feng wrote: Because libvirt_lxc create a thread to mount fuse filesystem. and then libvirt_lxc will try to access the fuse filesystem. Without waiting,libvirt_lxc may access fuse before it is mounted.

Re: [libvirt] [libvirt-glib] gobject: Add GVirDomainRebootFlags

2012-11-06 Thread Christophe Fergeau
Looks good, ACK Christophe On Wed, Oct 31, 2012 at 11:51:54PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Add flags to be used with gvir_domain_reboot(). --- libvirt-gobject/libvirt-gobject-domain.c | 2 +- libvirt-gobject/libvirt-gobject-domain.h

Re: [libvirt] [PATCH v7 2/6] add fuse support for libvirt lxc

2012-11-06 Thread Richard W.M. Jones
On Tue, Nov 06, 2012 at 07:50:33PM +0800, Gao feng wrote: 于 2012年11月06日 17:11, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 04:54:59PM +0800, Gao feng wrote: Because libvirt_lxc create a thread to mount fuse filesystem. and then libvirt_lxc will try to access the fuse filesystem.

Re: [libvirt] [PATCH] qemu: Don't corrupt pointer in qemuDomainSaveMemory()

2012-11-06 Thread Eric Blake
On 11/06/2012 03:07 AM, Peter Krempa wrote: The code that was split out into the qemuDomainSaveMemory expands the pointer containing the XML description of the domain that it gets from higher layers. If the pointer changes the old one is invalid and the upper layer function tries to free it

Re: [libvirt] [PATCH] qemu: Don't corrupt pointer in qemuDomainSaveMemory()

2012-11-06 Thread Peter Krempa
On 11/06/12 14:21, Eric Blake wrote: On 11/06/2012 03:07 AM, Peter Krempa wrote: The code that was split out into the qemuDomainSaveMemory expands the pointer containing the XML description of the domain that it gets from higher layers. If the pointer changes the old one is invalid and the

Re: [libvirt] [PATCH] qemu: Add ability to disable autostarting of guests on daemon start

2012-11-06 Thread Daniel P. Berrange
On Mon, Nov 05, 2012 at 04:02:28PM +0100, Peter Krempa wrote: When the daemon is starting it autostarts all guests marked as autostartable. This is not an ideal solution for autostarting if there's a lot of domains configured so. After autostarting all right away the guests start competing for

Re: [libvirt] [PATCH v12] support offline migration

2012-11-06 Thread Jiri Denemark
On Mon, Nov 05, 2012 at 11:33:48 +0800, li guang wrote: 在 2012-11-02五的 15:32 +0100,Jiri Denemark写道: ... @@ -1607,6 +1630,15 @@ qemuMigrationPrepareAny(struct qemud_driver *driver, goto endjob; } +if (!(mig = qemuMigrationEatCookie(driver, vm, cookiein,

Re: [libvirt] [PATCH v13] support offline migration

2012-11-06 Thread Jiri Denemark
On Mon, Nov 05, 2012 at 12:17:50 +0800, liguang wrote: original migration did not aware of offline case, so, try to support offline migration quietly (did not disturb original migration) by pass VIR_MIGRATE_OFFLINE flag to migration APIs if only the domain is really inactive, and migration

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-06 Thread Laine Stump
On 11/06/2012 03:30 AM, Viktor Mihajlovski wrote: On 11/05/2012 08:59 PM, Eric Blake wrote: @@ -1523,6 +1524,7 @@ be hot-plugged the next time the domain is booted. As such, it must only be used with the I--config flag, and not with the I--live flag. =item Bshutdown Idomain [I--mode

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-06 Thread Eric Blake
On 11/06/2012 02:01 AM, Peter Krempa wrote: =item Breboot Idomain [I--mode acpi|agent] +=item Brestart Idomain [I--mode acpi|agent] Reboot a domain. This acts just as if the domain had the Breboot command run from the console. The command returns as soon as it has Now it would be a

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-06 Thread Eric Blake
On 11/06/2012 07:31 AM, Laine Stump wrote: On 11/06/2012 03:30 AM, Viktor Mihajlovski wrote: On 11/05/2012 08:59 PM, Eric Blake wrote: @@ -1523,6 +1524,7 @@ be hot-plugged the next time the domain is booted. As such, it must only be used with the I--config flag, and not with the I--live

Re: [libvirt] [PATCH v13] support offline migration

2012-11-06 Thread Eric Blake
On 11/06/2012 04:16 AM, Jiri Denemark wrote: Another thing I didn't notice last time :-( Is there any reason why offline migrating a running domain should be forbidden? But even if there was a reason, this check doesn't belong to virsh. Good observation. I think that supporting --offline

Re: [libvirt] [PATCH v2 2/2] Document bracket whitespace rules add syntax-check rule

2012-11-06 Thread Martin Kletzander
On 11/01/2012 11:53 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com [...] --- build-aux/bracket-spacing.pl | 116 +++ cfg.mk | 7 ++- docs/hacking.html.in | 49 ++ 3 files

[libvirt] [PATCH 0/3] dnsmasq conf-file, interface=, and DHCPv6

2012-11-06 Thread Gene Czarcinski
The three sets of patches implement the changes listed below. Although they were developed on v1.0.0, they have been updated to the current git master as of the time of their submital [so if anything major updated bridge_driver.c, network_conf.c or dnamasq.c, your milage may vary]. These three

[libvirt] [PATCH 2/3] v6-6: add dnsmasq interface= parameter

2012-11-06 Thread Gene Czarcinski
This patch adds the interface= dnsmasq parameter to the dnsmasq conf-file. The relavant tests are updated. --- src/network/bridge_driver.c| 10 ++ tests/networkxml2argvdata/isolated-network.argv| 1 +

[libvirt] [PATCH 1/3] v6-6: put dnsmasq parameters into a file

2012-11-06 Thread Gene Czarcinski
This patch changes how parameters are passed to dnsmasq. Instead of being on the command line, the parameters are put into a file (one parameter per line) and a commandline --conf-file= specifies the location of the file. The file is located in the same directory as the leases file. ---

Re: [libvirt] Proposed: always allow packets internal to an interface

2012-11-06 Thread Gene Czarcinski
On 11/05/2012 12:35 PM, Laine Stump wrote: On 11/02/2012 07:46 AM, Gene Czarcinski wrote: Currently, when an interface (virtual network) is started, if no ip address is defined, then no rule is added to bemit internal network traffic. However, virtual guests can use such a network to

Re: [libvirt] [PATCHv2 15/20] snapshot: qemu: Add support for external inactive snapshots

2012-11-06 Thread Eric Blake
On 11/05/2012 05:06 PM, Eric Blake wrote: Here's the first round of things to squash - I noticed that my earlier suggestion of checking for _LIVE and _REDEFINE being mutually exclusive is done too late - that needs to be done _before_ the point where we alter the current snapshot when

[libvirt] [PATCH 3/3] v6-6: Add support for DHCPv6

2012-11-06 Thread Gene Czarcinski
This support includes IPv6 dhcp-range= and dhcp-host= for one IPv6 subnetwork on one interface. The parameter tests have been updated to add some new DHCPv6 tests. Three new tests (6 files) were added. The xml format html documentation has been updated to reflect support for IPv6 DHCP. ---

Re: [libvirt] Proposed: replace radvd with dnsmasq for Router Advertizing

2012-11-06 Thread Gene Czarcinski
On 11/05/2012 12:27 AM, Doug Goldstein wrote: On Sun, Nov 4, 2012 at 7:12 AM, Gene Czarcinski g...@czarc.net wrote: On 11/03/2012 09:01 PM, Laine Stump wrote: On 11/02/2012 08:25 AM, Gene Czarcinski wrote: I have been doing some testing and dnsmasq is capable of handling the service currently

Re: [libvirt] [PATCH] qemu: Emit event if save fails

2012-11-06 Thread Eric Blake
On 11/05/2012 08:05 AM, Michal Privoznik wrote: When we are doing a (managed-) save of a domain, we stop its processors firstly. And if the process of saving fails for some reason we try to wake them up again. However, if this fails, an event should be emitted so mgmt application can decide

Re: [libvirt] [PATCH] qemu: Emit event if save fails

2012-11-06 Thread Michal Privoznik
On 06.11.2012 18:07, Eric Blake wrote: On 11/05/2012 08:05 AM, Michal Privoznik wrote: When we are doing a (managed-) save of a domain, we stop its processors firstly. And if the process of saving fails for some reason we try to wake them up again. However, if this fails, an event should be

Re: [libvirt] Proposed: replace radvd with dnsmasq for Router Advertizing

2012-11-06 Thread Gene Czarcinski
On 11/06/2012 11:50 AM, Gene Czarcinski wrote: I am looking into an alternate method of obtaining the dnsmasq version but the dnsmasq version will be the deciding rule for radvd versus dnsmasq usage. Try dig chaos txt version.bind -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCHv2 16/20] conf: Add helper to determine if snapshot is external

2012-11-06 Thread Eric Blake
On 11/01/2012 10:22 AM, Peter Krempa wrote: Snapshots are external if they are disk snapshots or if they have an external memory image. Other possibilities are not supported (yet). And given the discussion on 15/20, even though it might be technically possible to mix internal and external disk

Re: [libvirt] [PATCH] qemu: Add ability to disable autostarting of guests on daemon start

2012-11-06 Thread Jiri Denemark
On Tue, Nov 06, 2012 at 14:57:30 +0100, Daniel P. Berrange wrote: On Mon, Nov 05, 2012 at 04:02:28PM +0100, Peter Krempa wrote: When the daemon is starting it autostarts all guests marked as autostartable. This is not an ideal solution for autostarting if there's a lot of domains configured

[libvirt] [PATCH v2 0/2] Emit more events

2012-11-06 Thread Michal Privoznik
diff to v1: -a new event invented -more APIs updated Michal Privoznik (2): Introduce new VIR_DOMAIN_EVENT_SUSPENDED_API_ERROR event qemu: Emit event if 'cont' fails examples/domain-events/events-c/event-test.c |3 + examples/domain-events/events-python/event-test.py |2 +-

[libvirt] [PATCH v2 1/2] Introduce new VIR_DOMAIN_EVENT_SUSPENDED_API_ERROR event

2012-11-06 Thread Michal Privoznik
This is supposed to be thrown every time we need to pause domain because of API execution (e.g. qemuDomainSaveInternal) but fails to restore it back after. In this case, domain remains paused, however, none of existing reasons can fit this scenario. ---

Re: [libvirt] Proposed: replace radvd with dnsmasq for Router Advertizing

2012-11-06 Thread Laine Stump
On 11/06/2012 12:40 PM, Gene Czarcinski wrote: On 11/06/2012 11:50 AM, Gene Czarcinski wrote: I am looking into an alternate method of obtaining the dnsmasq version but the dnsmasq version will be the deciding rule for radvd versus dnsmasq usage. Try dig chaos txt version.bind Yeah, I saw

[libvirt] [PATCH v2 2/2] qemu: Emit event if 'cont' fails

2012-11-06 Thread Michal Privoznik
Some operations, APIs needs domain to be paused prior operation can be performed, e.g. (managed-) save of a domain. The processors should be restored in the end. However, if 'cont' fails for some reason, we log a message but this is not sufficient as an event should be emitted as well. Mgmt

Re: [libvirt] [PATCHv2 17/20] snapshot: qemu: Add detail option for PMSUSPENDED event.

2012-11-06 Thread Eric Blake
On 11/01/2012 10:22 AM, Peter Krempa wrote: This patch adds an event to be raised if a PM suspended guest is restored from a snapshot. --- examples/domain-events/events-c/event-test.c | 3 +++ include/libvirt/libvirt.h.in | 2 ++ 2 files changed, 5 insertions(+) Hmm, the

Re: [libvirt] [PATCH v2 1/2] Introduce new VIR_DOMAIN_EVENT_SUSPENDED_API_ERROR event

2012-11-06 Thread Eric Blake
On 11/06/2012 11:23 AM, Michal Privoznik wrote: This is supposed to be thrown every time we need to pause domain because of API execution (e.g. qemuDomainSaveInternal) but fails to restore it back after. In this case, domain remains paused, however, none of existing reasons can fit this

Re: [libvirt] [PATCH v2 2/2] qemu: Emit event if 'cont' fails

2012-11-06 Thread Eric Blake
On 11/06/2012 11:23 AM, Michal Privoznik wrote: Some operations, APIs needs domain to be paused prior operation can be performed, e.g. (managed-) save of a domain. The processors should be restored in the end. However, if 'cont' fails for some reason, we log a message but this is not

Re: [libvirt] [PATCHv2 18/20] snapshot: qemu: Fix detection of external snapshots when deleting

2012-11-06 Thread Eric Blake
On 11/01/2012 10:22 AM, Peter Krempa wrote: Only external disk snapshots were taken into account while checking if snapshot deletion is possible. This patch adds checking also for external checkpoint.s s/\.s/s./ --- src/qemu/qemu_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [libvirt] Proposed: replace radvd with dnsmasq for Router Advertizing

2012-11-06 Thread Gene Czarcinski
On 11/06/2012 01:56 PM, Laine Stump wrote: On 11/06/2012 12:40 PM, Gene Czarcinski wrote: On 11/06/2012 11:50 AM, Gene Czarcinski wrote: I am looking into an alternate method of obtaining the dnsmasq version but the dnsmasq version will be the deciding rule for radvd versus dnsmasq usage. Try

Re: [libvirt] Release of libvirt-1.0.0

2012-11-06 Thread Kashyap Chamarthy
On 11/02/2012 10:43 AM, Daniel Veillard wrote: Well we just crossed that important milestone in the life of any project, so congratulation everybody the 1.0.0 release is out !!! For a bit of history, this is actually the 7th birthday of the project accounted from the first commit, on Nov

Re: [libvirt] [PATCHv2 19/20] snapshot: qemu: Add support for external snapshot deletion.

2012-11-06 Thread Eric Blake
On 11/01/2012 10:22 AM, Peter Krempa wrote: This patch adds limited support for deleting external snaphots. The s/snaphots/snapshots/ machine must not be active and only whole subtrees of snapshots can be deleted as reparenting was not yet implemented for external snapshots. These are

Re: [libvirt] [PATCHv2 20/20] snapshot: qemu: Implement reverting of external snapshots

2012-11-06 Thread Eric Blake
On 11/01/2012 10:22 AM, Peter Krempa wrote: This patch adds support for reverting of external snapshots. The support is somewhat limited yet (you can only revert to a snapshot that has no children or delete the children that would have their image chains invalidated). Sounds like we need to

Re: [libvirt] [PATCHv2 00/20] External snapshot support

2012-11-06 Thread Eric Blake
On 11/01/2012 10:22 AM, Peter Krempa wrote: This is a second spin of the patches: Changes to previous version: - pushed fix for private_syms file patches 1-4 are Eric's patches that this series builds upon patches 5,were ACKed in v1 patches 6,7,9,10,14 are fixed versions after review

Re: [libvirt] [PATCH v7 2/6] add fuse support for libvirt lxc

2012-11-06 Thread Gao feng
于 2012年11月06日 20:55, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 07:50:33PM +0800, Gao feng wrote: 于 2012年11月06日 17:11, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 04:54:59PM +0800, Gao feng wrote: Because libvirt_lxc create a thread to mount fuse filesystem. and then libvirt_lxc will

[libvirt] [PATCH 0/2] make external snapshots easier in virsh

2012-11-06 Thread Eric Blake
Creating external snapshots with 'virsh snapshot-create' is awkward, as it requires quite a bit of XML. This adds support in the snapshot-create-as command to make the task easier. Eric Blake (2): virsh: make ,, escape parsing common virsh: add snapshot-create-as memspec support

[libvirt] [PATCH 2/2] virsh: add snapshot-create-as memspec support

2012-11-06 Thread Eric Blake
External checkpoints could be created with snapshot-create, but without libvirt supplying a default name for the memory file, it is essential to add a new argument to snapshot-create-as to allow the user to choose the memory file name. This adds the option --memspec [file=]name[,snapshot=type],

[libvirt] [PATCH 1/2] virsh: make ,, escape parsing common

2012-11-06 Thread Eric Blake
So far, none of the existing callers of vshStringToArray expected the user to ever pass a literal comma; meanwhile, snapshot parsing had rolled its own array parser. Moving the comma escaping into the common function won't affect any existing callers, and will make this function reusable for

Re: [libvirt] [PATCH v7 2/6] add fuse support for libvirt lxc

2012-11-06 Thread Gao feng
于 2012年11月06日 20:55, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 07:50:33PM +0800, Gao feng wrote: 于 2012年11月06日 17:11, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 04:54:59PM +0800, Gao feng wrote: Because libvirt_lxc create a thread to mount fuse filesystem. and then libvirt_lxc will

Re: [libvirt] [PATCH 1/2] virsh: make ,, escape parsing common

2012-11-06 Thread Doug Goldstein
On Tue, Nov 6, 2012 at 10:00 PM, Eric Blake ebl...@redhat.com wrote: So far, none of the existing callers of vshStringToArray expected the user to ever pass a literal comma; meanwhile, snapshot parsing had rolled its own array parser. Moving the comma escaping into the common function won't

Re: [libvirt] [PATCH v7 2/6] add fuse support for libvirt lxc

2012-11-06 Thread Wanlong Gao
On 11/07/2012 11:54 AM, Gao feng wrote: 于 2012年11月06日 20:55, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 07:50:33PM +0800, Gao feng wrote: 于 2012年11月06日 17:11, Richard W.M. Jones 写道: On Tue, Nov 06, 2012 at 04:54:59PM +0800, Gao feng wrote: Because libvirt_lxc create a thread to mount fuse

Re: [libvirt] [PATCH 2/2] virsh: add snapshot-create-as memspec support

2012-11-06 Thread Doug Goldstein
On Tue, Nov 6, 2012 at 10:00 PM, Eric Blake ebl...@redhat.com wrote: External checkpoints could be created with snapshot-create, but without libvirt supplying a default name for the memory file, it is essential to add a new argument to snapshot-create-as to allow the user to choose the memory